Timeline
Mar 22, 2008:
- 3:21 PM Changeset in webkit [31235] by
-
- 2 edits in trunk/WebCore
2008-03-22 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=16339
Frame scrollbar positions are not updated on page scroll
Widget::geometryChanged() was called instead of
ScrollViewScrollbar::geometryChanged() because of a missing const.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): add the missing const.
- 3:01 PM Changeset in webkit [31234] by
-
- 6 edits in trunk/WebCore
2008-03-22 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Mark Rowe.
Bug 17974: REGRESSION: npfunctions.h should not import npruntime_internal.h
<http://bugs.webkit.org/show_bug.cgi?id=17974>
<rdar://problem/5782310>
Include npapi.h and npruntime.h directly in npfunctions.h.
Add npfunctions.h and npapi.h to npruntime_internal.h.
Replace includes of npfunctions.h with npruntime_internal.h.
- bridge/npruntime_internal.h:
- plugins/PluginPackage.h:
- plugins/PluginStream.h:
- plugins/npapi.cpp:
- plugins/npfunctions.h:
- 2:04 PM Changeset in webkit [31233] by
-
- 4 edits in trunk
Fix the Qt build.
- 3:31 AM Changeset in webkit [31232] by
-
- 3 edits in trunk
Update a (passing) result I missed in my last checkin. No review.
- dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
- 2:50 AM Changeset in webkit [31231] by
-
- 10 edits6 adds in trunk
Reviewed by mjs.
Unify handling of NAMESPACE_ERR and fix Acid3 test 25
http://bugs.webkit.org/show_bug.cgi?id=16693
Test: fast/dom/DOMImplementation/createDocumentType-err.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocumentType): (WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.idl:
- dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): (WebCore::Document::createElementNS): (WebCore::Document::parseQualifiedName): (WebCore::Document::createAttributeNS):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::setAttributeNS):
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
- 2:49 AM Changeset in webkit [31230] by
-
- 5 edits7 adds in trunk
Reviewed by mjs.
Fix createElementNS to throw exceptions for invalid qualified names
Fixes Acid3 sub-test 23
http://bugs.webkit.org/show_bug.cgi?id=16833
Tests: fast/dom/Document/createAttributeNS-namespace-err.html
fast/dom/Document/createElementNS-namespace-err.html
- dom/Document.cpp: (WebCore::Document::createElement): (WebCore::hasNamespaceError): (WebCore::Document::createElementNS): (WebCore::Document::createAttributeNS):
- dom/Document.idl:
- 2:14 AM Changeset in webkit [31229] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig. Landed by eseidel.
Make testkjs flush stdout after printing.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/testkjs.cpp: (functionPrint):
- 12:14 AM Changeset in webkit [31228] by
-
- 3 edits2 adds in trunk
2008-03-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh
<http://bugs.webkit.org/show_bug.cgi?id=13693>
Reviewed by Oliver Hunt
Do not create bogus history items for unloaded <object> elements, because they
cause fallback content to be ignored on reload.
Mar 21, 2008:
- 11:57 PM Changeset in webkit [31227] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17988 REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com
Test: fast/css-generated-content/empty-content-with-float-crash.html
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added a null check for the case where the block contains no in-flow elements but still lays out as a line flow, which can happen as a result of empty generated content.
LayoutTests:
Reviewed by Oliver Hunt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17988 REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com
- fast/css-generated-content/empty-content-with-float-crash-expected.txt: Added.
- fast/css-generated-content/empty-content-with-float-crash.html: Added.
- 9:59 PM Changeset in webkit [31226] by
-
- 3 edits in trunk/JavaScriptCore
Optimise lookup of Math, undefined, NaN and Infinity
Reviewed by Maciej
Added a method to JSVariableObject to allow us to inject DontDelete properties
into the symbol table and localStorage. This results in a 0.4% progression in
SunSpider, with a 8% gain in math-partial-sums.
- 7:36 PM Changeset in webkit [31225] by
-
- 8 edits in trunk
Global properties that use LocalStorage are not correctly listed as enumerable.
Reviewed by Geoff Garen
The problem was caused by JSObject::getPropertyAttributes not being aware
of the JSVariableObject SymbolTable. The fix is to make getPropertyAttributes
virtual and override in JSVariableObject. This does not produce any performance
regression.
- 5:39 PM Changeset in webkit [31224] by
-
- 5 edits2 adds in trunk
WebCore:
2008-03-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix <rdar://problem/5788451>
toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Hard code support for just PNG's on windows, the minimum the spec requires.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL):
LayoutTests:
2008-03-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Enable tests for <rdar://problem/5788451>
toDataURL not implemented for Windows (need mapping of MIME type to UTI)
- platform/win/Skipped:
- platform/win/fast/canvas: Added.
- platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
- 4:58 PM Changeset in webkit [31223] by
-
- 4 edits in trunk/WebCore
2008-03-21 Matt Lilek <webkit@mattlilek.com>
Not reviewed, Mac build fix.
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
- bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
- 4:31 PM Changeset in webkit [31222] by
-
- 1 edit2 adds in trunk/WebKitSite
2008-03-21 Antti Koivisto <Antti Koivisto>
Add some images for a blog post.
- blog-files/wsj-nopreload.png: Added.
- blog-files/wsj-preload.png: Added.
- 4:30 PM Changeset in webkit [31221] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Mac build
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
- 3:09 PM Changeset in webkit [31220] by
-
- 35 edits in trunk/WebCore
Rename static info members to s_info
This avoids conflicts with custom "info" methods, such as the one that
will soon be added to Console.
Reviewed by Ada Chan and Sam Weinig.
- 3:00 PM Changeset in webkit [31219] by
-
- 3 edits in trunk/WebCore
2008-03-21 David Hyatt <hyatt@apple.com>
<rdar://problem/5808863> Zooming should not let non-zero border width become zero
Make sure zoomed values that begin >= 1 are not allowed to fall below 1.
Reviewed by adele
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
- loader/CachedImage.cpp: (WebCore::CachedImage::imageSize): (WebCore::CachedImage::imageRect):
- 2:05 PM Changeset in webkit [31218] by
-
- 2 edits in trunk/WebCore
2008-03-21 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam.
-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
- Instrument the InspectorController to cache XHR resrouces since they are not cached by WebCore. The resources will be kept in the same map as all other resources so they will have the exact same lifecycle.
- ChangeLog:
- page/InspectorController.cpp: (WebCore::InspectorCachedXMLHttpRequestResource::type): (WebCore::InspectorCachedXMLHttpRequestResource::setType): (WebCore::InspectorCachedXMLHttpRequestResource::data): (WebCore::InspectorCachedXMLHttpRequestResource::setData): (WebCore::InspectorCachedXMLHttpRequestResource::encoding): (WebCore::InspectorCachedXMLHttpRequestResource::setEncoding): (WebCore::InspectorCachedXMLHttpRequestResource::create): (WebCore::InspectorCachedXMLHttpRequestResource::InspectorCachedXMLHttpRequestResource):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- 1:40 PM Changeset in webkit [31217] by
-
- 1 edit in trunk/ChangeLog
Add missing ChangeLog entry for r31214.
2008-03-21 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Holger.
Remove the JSCore include path options from global_cppflags.
Place JSCore include path options in javascriptcore_cppflags.
Add javascriptcore_cppflags to libWebCore_la_CPPFLAGS.
- GNUmakefile.am:
- 12:26 PM Changeset in webkit [31216] by
-
- 2 edits in trunk/JavaScriptCore
2008-03-21 Arkadiusz Miskiewicz <arekm@maven.pl>
Webkit does not build on linux powerpc
Reviewed by David Kilzer.
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):
- 11:48 AM Changeset in webkit [31215] by
-
- 2 edits in trunk/SunSpider
Reviewed by Geoff.
- sunspider: Pause update daemon on Darwin to make results reliable again (workaround for <rdar://problem/5811127>).
- 11:21 AM Changeset in webkit [31214] by
-
- 7 edits in trunk
JavaScriptCore/ChangeLog:
2008-03-21 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Holger.
Add javascriptcore_cppflags to Programs_minidom_CPPFLAGS.
- GNUmakefile.am:
WebCore/ChaneLog:
2008-03-21 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Holger.
Remove WebCore/ForwardingHeaders from cppflags as it is not needed,
and causes build problems with GTK+.
- GNUmakefile.am:
WebKitTools/ChangeLog:
2008-03-21 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Holger.
Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
- GNUmakefile.am:
- 10:17 AM Changeset in webkit [31213] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Adele Peterson.
- fix http://bugs.webkit.org/show_bug.cgi?id=17966 REGRESSION (r31114-r31132): Clearing via br behaves unpredictably
Test: fast/block/float/br-with-clear.html
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Fixed the logic for the very special case of an all-lines-clean block that ends with a float- clearing <br> by looking for the <br> at the end of the line rather than at its beginning.
LayoutTests:
Reviewed by Adele Peterson.
- test for http://bugs.webkit.org/show_bug.cgi?id=17966 REGRESSION (r31114-r31132): Clearing via br behaves unpredictably
- fast/block/float/br-with-clear.html: Added.
- platform/mac/fast/block/float/br-with-clear-expected.checksum: Added.
- platform/mac/fast/block/float/br-with-clear-expected.png: Added.
- platform/mac/fast/block/float/br-with-clear-expected.txt: Added.
- 9:36 AM Changeset in webkit [31212] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/5810324> visitCount not updated in History.plist
Call WebCore::HistoryItem::mergeAutoCompleteHints() in WebHistoryItem::mergeAutoCompleteHints().
Reviewed by Steve.
- WebHistoryItem.cpp: (WebHistoryItem::mergeAutoCompleteHints): (WebHistoryItem::QueryInterface):
- 9:29 AM Changeset in webkit [31211] by
-
- 3 edits in trunk/WebKitTools
Remove a non-working mirror from cygwin-downloader and add the ruby package
- CygwinDownloader/cygwin-downloader.py:
- CygwinDownloader/cygwin-downloader.zip: Updated.
- 9:27 AM Changeset in webkit [31210] by
-
- 3 edits in trunk/WebCore
Don't allow any newly-scheduled plugin requests to be serviced when JS is paused
This is a followup to r31199.
Reviewed by Tim Hatcher.
- plugins/PluginView.cpp: (WebCore::PluginView::requestTimerFired): Added an assertion that JS is not paused. (WebCore::PluginView::scheduleRequest): Don't start the request timer if JS is paused. This is the bug fix. (WebCore::PluginView::setJavaScriptPaused): Replaced the use of m_requestTimerWasActive with a check to see if we have any pending requests. m_requestTimerWasActive would not be accurate if a new request had been scheduled while JS was paused. (WebCore::PluginView::PluginView): Removed initialization of m_requestTimerWasActive.
- plugins/PluginView.h: Removed m_requestTimerWasActive.
- 9:19 AM UpdatingCygwinDownloader created by
- Initial version
- 9:14 AM WikiStart edited by
- Add a link to a page to describe how to update cygwin-downloader (diff)
- 9:00 AM Changeset in webkit [31209] by
-
- 6 edits in trunk/WebKit/mac
Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
http://bugs.webkit.org/show_bug.cgi?id=17980
Reviewed by Adam.
The new highlight drawing was not honoring the fade value, so it was
always drawing at full opacity. The animation code didn't match Windows
and the new highlight anyway, so it has been removed. The highlight
how just detaches when it is hidden.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
(-[WebInspectorWindowController close]): Ditto.
(-[WebInspectorWindowController highlightNode:]): Call attach.
(-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
- WebInspector/WebNodeHighlight.h:
- WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
(-[WebNodeHighlight attach]): Renamed from attachHighlight.
(-[WebNodeHighlight detach]): Renamed from detachHighlight.
(-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
- WebInspector/WebNodeHighlightView.h:
- WebInspector/WebNodeHighlightView.m:
(-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
- 4:14 AM Changeset in webkit [31208] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Consolidate static identifier initializers within CommonIdentifiers.
No reliably measurable change on SunSpider; maybe a tiny improvement (within 0.2%).
- kjs/CommonIdentifiers.h: Added static identifiers that were lazily initialized throughout the code.
- kjs/date_object.cpp: (KJS::DateObjectImp::DateObjectImp):
- kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype):
- kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype):
- kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): Use the values from CommonIdentifiers.
- kjs/lookup.h: Caching the identifier in a static wasn't a win on SunSpider, removed it.
- kjs/value.h: (KJS::jsNaN): We already have a shared NaN value, no need for a duplicate here.
- wtf/MathExtras.h: (wtf_atan2): Having local variables for numeric_limits constants is good for readability, but there is no reason to keep them static.
- JavaScriptCore.exp: Don't needlessly export JSGlobalObject::s_head.
- 12:07 AM Changeset in webkit [31207] by
-
- 4 edits in trunk/LayoutTests
- update results for the 'zoom' property added in <http://trac.webkit.org/projects/webkit/changeset/31155>
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
