⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 24, 2008:

11:57 PM squirrelfish edited by oliver@apple.com
(diff)
11:56 PM Changeset in webkit [31278] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Mark.

Clean up SVG features message to be less confusing.

  • Scripts/build-webkit:
11:21 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
11:20 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
10:48 PM Changeset in webkit [31277] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed recent 25% regression on simple for loop test. GCC seems to be
very finicky about the code that gets inlined into
Machine::privateExecute.

Everything in this patch is simply the result of experiment.


The resolve and resolve_base opcodes do not seem to have gotten slower
from this change.

  • VM/Machine.cpp: (KJS::resolve): (KJS::resolveBase): (KJS::Machine::privateExecute):
  • kjs/nodes.h:
10:05 PM Changeset in webkit [31276] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Bug 18059: squirrelfish needs to compile on platforms without computed goto
<​http://bugs.webkit.org/show_bug.cgi?id=18059>

Reviewed by Geoff Garen

"Standard" macro style support for conditionalising the use of computed goto.

10:02 PM Changeset in webkit [31275] by Darin Adler
  • 2 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

  • try to fix broken Wx build
  • platform/wx/TemporaryLinkStubs.cpp: (GraphicsContext::setPlatformShadow): (GraphicsContext::clearPlatformShadow):
9:35 PM Changeset in webkit [31274] by oliver@apple.com
  • 3 edits
    1 move in trunk

Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
<​http://bugs.webkit.org/show_bug.cgi?id=18030>

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
<​http://bugs.webkit.org/show_bug.cgi?id=18057>

9:30 PM Changeset in webkit [31273] by Darin Adler
  • 5 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • use AtomicString more consistently for attribute values

1% speedup on Acid3 test 26

  • dom/Element.cpp: (WebCore::Element::setAttribute): Changed value argument to AtomicString. Also fixed call to lower() to only be done if the name isn't already lowercase. Also took out one unneeded condition in a cascade of if statements. (WebCore::Element::createAttribute): Ditto. (WebCore::Element::setAttributeNS): Ditto.
  • dom/Element.h: Ditto.
  • dom/StyledElement.cpp: (WebCore::StyledElement::createAttribute): Ditto.
  • dom/StyledElement.h: Ditto.
9:28 PM Changeset in webkit [31272] by Darin Adler
  • 3 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • get rid of extra level of function call in toJS functions for Node

0.6% speedup on Acid3 test 26

  • bindings/js/JSNodeCustom.cpp: (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.
  • bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode* to avoid ambiguity that otherwise exists between the toJS for EventTarget* and for Node*.
8:43 PM Changeset in webkit [31271] by weinig@apple.com
  • 5 edits in trunk/WebKitTools

2008-03-24 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt.

Add EventSender.zoomPageIn/zoomPageOut support to DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController zoomPageIn]): (-[EventSendingController zoomPageOut]):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/EventSender.cpp: (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback):
8:39 PM Changeset in webkit [31270] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • convert a JavaScript immediate number to a string more efficiently

2% speedup of Acid3 test 26

  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toString): Take advantage of the fact that all immediate numbers are integers, and use the faster UString function for formatting integers instead of the slower one that works for floating point. I think this is a leftover from when immediate numbers were floating point.
8:26 PM Changeset in webkit [31269] by Darin Adler
  • 2 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Hyatt.

  • add fast path to isValidName that does not use advanced Unicode functions

2% speedup on Acid3 test 26

  • dom/Document.cpp: (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function. (WebCore::isValidNameASCII): Added. Contains a simpler function that returns true for most valid names that are also all ASCII. (WebCore::Document::isValidName): Changed to call both of the above functions. The common case is that isValidNameASCII returns true so isValidNameNonASCII is never called.
7:39 PM Changeset in webkit [31268] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-03-24 David Hyatt <​hyatt@apple.com>

Fix for bug 18052, window properties need to respect zoom factor.

Reviewed by Beth

  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
7:26 PM Changeset in webkit [31267] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-03-23 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created
ExecState.

  • API/testapi.c: (main): Add tests for setting the thisObject when calling JSEvaluateScript.
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment.

WebCore:

2008-03-24 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same behavior.
6:19 PM Changeset in webkit [31266] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

2008-03-24 Brady Eidson <​beidson@apple.com>

Made new layout test files executable, as needed for the tests to not fail!

  • http/tests/navigation/resources/reload-subframe-content.pl: Added.
  • http/tests/navigation/resources/reload-subframe.pl: Added.
6:10 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
5:49 PM Changeset in webkit [31265] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Moved my notes from nodes.h to the wiki.

  • kjs/nodes.h:
5:48 PM squirrelfish edited by ggaren@apple.com
(diff)
5:44 PM squirrelfish edited by oliver@apple.com
(diff)
5:44 PM WikiStart edited by ggaren@apple.com
(diff)
5:43 PM squirrelfish edited by ggaren@apple.com
(diff)
5:41 PM squirrelfish created by ggaren@apple.com
initial rough cut of tasks and ideas
5:37 PM Changeset in webkit [31264] by beidson@apple.com
  • 3 edits
    8 adds in trunk

WebKit/mac:

2008-03-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Bug 3580: iFrames Appear to be Cached
<​http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
<​http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
<​http://bugs.webkit.org/show_bug.cgi?id=15554>

If a page is reloaded, a child frame's URL can not be taken from a history item.

  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

LayoutTests:

2008-03-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Tests for the following bugs:

Bug 3580: iFrames Appear to be Cached
<​http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
<​http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
<​http://bugs.webkit.org/show_bug.cgi?id=15554>

  • http/tests/navigation/reload-subframe-frame-expected.txt: Added.
  • http/tests/navigation/reload-subframe-frame.html: Added.
  • http/tests/navigation/reload-subframe-iframe-expected.txt: Added.
  • http/tests/navigation/reload-subframe-iframe.html: Added.
  • http/tests/navigation/reload-subframe-object-expected.txt: Added.
  • http/tests/navigation/reload-subframe-object.html: Added.
  • http/tests/navigation/resources/reload-subframe-content.pl: Added.
  • http/tests/navigation/resources/reload-subframe.pl: Added.
5:16 PM Changeset in webkit [31263] by ggaren@apple.com
  • 9 edits
    17 adds in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by NOBODY.


SquirrelFish lives.


Initial check-in of the code I've been carrying around. Lots of stuff
doesn't work. Plus a bunch of empty files.

5:10 PM Changeset in webkit [31262] by mrowe@apple.com
  • 1 copy in branches/squirrelfish

New branch.

5:09 PM Changeset in webkit [31261] by mrowe@apple.com
  • 1 delete in branches/squirrelfish
4:19 PM Changeset in webkit [31260] by Darin Adler
  • 8 edits in trunk/WebKit/mac

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Beth.

  • fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
  • History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • History/WebHistory.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm: Remove unneeded imports of KURL.h.
4:15 PM Changeset in webkit [31259] by ggaren@apple.com
  • 1 move in branches/squirrelfish

No, I am not kidding.

3:59 PM Changeset in webkit [31258] by beidson@apple.com
  • 9 edits
    1 move
    12 adds in trunk

WebCore:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/archive: Added.
  • loader/archive/Archive.h: Added.
  • loader/archive/ArchiveFactory.cpp: Added.
  • loader/archive/ArchiveFactory.h: Added.
  • loader/archive/ArchiveResource.cpp: Added.
  • loader/archive/ArchiveResource.h: Added.
  • loader/archive/ArchiveResourceCollection.cpp: Added.
  • loader/archive/ArchiveResourceCollection.h: Added.
  • loader/archive/cf: Added.
  • loader/archive/cf/LegacyWebArchive.cpp: Added.
  • loader/archive/cf/LegacyWebArchive.h: Added.
  • loader/archive/cf/LegacyWebArchiveMac.mm: Added.

WebKit:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename a .m to .mm

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename this file for upcoming work.

  • WebView/WebArchive.m: Removed.
  • WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3:51 PM Changeset in webkit [31257] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-03-24 David Hyatt <​hyatt@apple.com>

Fix for bug 18009. Make sure the IE offset/client/scroll* extensions respect full page zoom.

Reviewed by Beth

  • dom/Element.cpp: (WebCore::localZoomForRenderer): (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent):
  • rendering/RenderObject.h:
2:59 PM Changeset in webkit [31256] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

2:57 PM Changeset in webkit [31255] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.16

New tag.

2:53 PM Changeset in webkit [31254] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • update bisect-builds for Safari 3.1
  • Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal revision, r29711.
2:51 PM Changeset in webkit [31253] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r31236.

2:51 PM Changeset in webkit [31252] by mrowe@apple.com
  • 16 edits
    6 adds in branches/Safari-3-1-branch

Merge r31144.

2:19 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
2:17 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
1:43 PM Changeset in webkit [31251] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Some style cleanup and add a logging channel for upcoming work

  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
1:31 PM Changeset in webkit [31250] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

Test: fast/repaint/renderer-destruction-by-invalidateSelection-crash.html

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): Removed repaintRects code. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::addRepaintInfo): Removed.
  • page/FrameView.h: Removed addRepaintInfo().
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Changed to call repaintRectangle instead of FrameView::addRepaintInfo().
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47
  • fast/repaint/renderer-destruction-by-invalidateSelection-crash.html: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
12:26 PM Changeset in webkit [31249] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-24 Alp Toker <​alp@atoker.com>

GTK+/soup http backend build fix for breakage introduced in r31141.
Fix suggested by Xan.

  • platform/network/ResourceHandle.h:
12:15 PM Changeset in webkit [31248] by ggaren@apple.com
  • 1 copy in branches/registercode/JavaScriptCore

Imported r31247 of JavaScriptCore from trunk.

12:07 PM Changeset in webkit [31247] by ggaren@apple.com
  • 1 add in branches/registercode

Created registercode branch.

10:55 AM Changeset in webkit [31246] by mitz@apple.com
  • 9 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/5792582> CSS opacity does not work with GDI text
  • fix <rdar://problem/5792619> non-opaque CSS colors do not work with GDI text (RGBA, HSLA)
  • fix <rdar://problem/5792624> GDI text can't be stroked/filled independently
  • make text-shadow work with GDI text
  • make -webkit-background-clip: text work with GDI text
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): Made this a shared method that updates the state and calls the platform-specific method. (WebCore::GraphicsContext::clearShadow): Ditto. (WebCore::GraphicsContext::getShadow): Added.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::WindowsBitmap): Added this class that represents a bitmap with a Windows device context that GDI can draw into.
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState): Added the shadow parameters to the graphics state.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/win/FontCGWin.cpp: (WebCore::toCGFloat): Added. Converts a Windows FIXED. (WebCore::createPathForGlyph): Added. Retrieves a glyph's hinted outline from GDI and creates a CGPath containing it. (WebCore::Font::drawGlyphs): Added two code paths in the GDI case. The existing code path, which uses GDI to draw text directly to the graphics context, is used for opaque-colored, non-transformed, non-stroked, non-shadowed text in a GDI-backed graphics context that is not in a transparency layer. An additional code path is used for non-stroked text in all other cases. It uses GDI to draw black text into an all-white Windows bitmap, then uses the green channel as a mask to create a bitmap with the desired fill color and alpha. The bitmap is then drawn into the graphics context, at which time transparency layers, transforms and shadows are handled properly. A third code path is used for stroked text. It constructs a path from hinted glyph outlines retrieved from GDI and strokes (and optionally fills) it.
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Added a mayCreateBitmap parameter. When false, prevents this method from creating a Windows device context if the graphics context does not already have one. (WebCore::GraphicsContext::releaseWindowsContext): Added a mayCreateBitmap parameter to match getWindowsContext(). (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): Added. (WebCore::GraphicsContext::drawWindowsBitmap): Added. Draws the bitmap as a non-alpha-premultiplied image.
10:45 AM Changeset in webkit [31245] by kmccullough@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2008-03-24 Kevin McCullough <​kmccullough@apple.com>

  • Fixed Changelog
10:16 AM Changeset in webkit [31244] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-24 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17845
[GTK] combo box menu displayed in the wrong position

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show): Change the popup menu vertical position so that the active item is over the combo box. (WebCore::PopupMenu::menuPositionFunction): use the "push in" style like native GTK+ combo boxes to handle menus that don't fit in the screen.
5:00 AM Changeset in webkit [31243] by Adam Roben
  • 2 edits in trunk/WebCore
  • WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector to the project.
1:15 AM Changeset in webkit [31242] by ap@webkit.org
  • 4 edits in trunk

Build fix.

  • WebCore/WebCore.xcodeproj/project.pbxproj: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h to Copy Generated Headers phase.
  • WebKit/MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
12:24 AM Changeset in webkit [31241] by eric@webkit.org
  • 2 edits in trunk/WebCore

Build fix, no review.

Fix project paths to be group relative instead of project relative

  • WebCore.xcodeproj/project.pbxproj:

Mar 23, 2008:

10:36 PM Changeset in webkit [31240] by mjs@apple.com
  • 18 edits
    6 adds in trunk

WebCore:

2008-03-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • svg/SVGAltGlyphElement.cpp: Added. Implementation for new element. (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::~SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::setGlyphRef): (WebCore::SVGAltGlyphElement::glyphRef): (WebCore::SVGAltGlyphElement::setFormat): (WebCore::SVGAltGlyphElement::format): (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan, which is right for everything besides the alternate glyph substitution itself.
  • svg/SVGAltGlyphElement.h: Added. Header for new element. (WebCore::SVGAltGlyphElement::contextElement):
  • svg/SVGAltGlyphElement.idl: Added. Interface for new element.
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
  • svg/svgtags.in: Add altGlyph
  • DerivedSources.make: Add new files
  • GNUmakefile.am: ditto
  • WebCore.SVG.exp: Add new ObjC DOM class
  • WebCore.pro: Add new files
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): ditto
  • bindings/objc/DOMInternal.h: Include altGlyph header
  • bindings/objc/DOMSVG.h: Include altGlyph header

LayoutTests:

2008-03-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • svg/dom/altGlyph-dom-expected.txt: Added.
  • svg/dom/altGlyph-dom.xhtml: Added.
  • svg/dom/resources/altGlyph-dom.js: Added.
6:21 PM Changeset in webkit [31239] by Antti Koivisto
  • 1 edit
    1 add in trunk/WebKitSite

2008-03-23 Antti Koivisto <Antti Koivisto>

  • blog-files/wsj-vs.png: Added.
2:08 PM Changeset in webkit [31238] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by eseidel. Landed by eseidel.

Bug 17685: [~=] attribute selector failing to match empty string
<​http://bugs.webkit.org/show_bug.cgi?id=17685>

Test: fast/css/attribute-selector-empty-value.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
2:03 PM Changeset in webkit [31237] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Sam.

Make our SVG status document slightly less inaccurate.

  • projects/svg/status.xml:
3:48 AM Changeset in webkit [31236] by oliver@apple.com
  • 3 edits
    2 adds in trunk

Bug 17670: Key events may improperly propagate from iframe to parent frame
Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus

Reviewed by Maciej

Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
as that results in us dispatching the key events for each frame going up the frame
tree.

Note: See TracTimeline for information about the timeline view.