⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 27, 2008:

11:41 PM Changeset in webkit [31388] by mrowe@apple.com
  • 5 edits in trunk

2008-03-27 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

<rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.

  • pcre/pcre_compile.cpp: (multiplyWithOverflowCheck): (calculateCompiledPatternLength): Check for overflow when dealing with nested repetition counts and bail with an error rather than returning incorrect results.

2008-03-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam Roben.

Tests for <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.

  • fast/js/regexp-overflow-expected.txt:
  • fast/js/resources/regexp-overflow.js:
10:49 PM Changeset in webkit [31387] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Return a default value for operator == when !USE(WXGC) (not implemented in that case).

10:42 PM Changeset in webkit [31386] by mjs@apple.com
  • 2 edits in trunk/WebCore

2008-03-27 Maciej Stachowiak <​mjs@apple.com>

  • fix build
  • svg/SVGGlyphMap.h: (WebCore::GlyphMapNode::create):
10:37 PM Changeset in webkit [31385] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-03-27 Brady Eidson <​beidson@apple.com>

Forgot a small requested change before committing

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
10:33 PM Changeset in webkit [31384] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2008-03-27 Brady Eidson <​beidson@apple.com>

Reviewed by Adam Roben

Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.

This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.

This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.

  • WebCore.base.exp:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::archiveResourceForURL): Make this const (WebCore::DocumentLoader::mainResource): (WebCore::DocumentLoader::subresource): Make this const and relocate (WebCore::DocumentLoader::getSubresources):
  • loader/DocumentLoader.h:

WebKit/mac:

2008-03-27 Brady Eidson <​beidson@apple.com>

Reviewed by Adam Roben

Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.

This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.

This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.

  • WebView/WebDataSource.mm: (-[WebDataSource mainResource]): Call DocumentLoader implementation (-[WebDataSource subresources]): Ditto
  • WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
  • WebView/WebFrameInternal.h:

LayoutTests:

2008-03-27 Brady Eidson <​beidson@apple.com>

Reviewed by Adam Roben

Updated results, as we now more consistently archive empty frames/empty resources

  • webarchive/archive-empty-frame-source-expected.txt:
10:25 PM Changeset in webkit [31383] by mjs@apple.com
  • 2 edits in trunk/WebCore

2008-03-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • fixed many buildbot leaks in glyph map code
  • svg/SVGGlyphMap.h: (WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking these objects. (WebCore::SVGGlyphMap::add): Call create instead of using new.
8:39 PM Changeset in webkit [31382] by weinig@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add emitCode support for UnaryPlusNode, NegateNode, BitwiseNotNode and LogicalNotNode.

  • VM/CodeBlock.cpp: (KJS::printUnaryOp): (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitNot):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode):
  • kjs/nodes.h:
8:37 PM Changeset in webkit [31381] by mjs@apple.com
  • 2 edits in trunk/WebCore

2008-03-27 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Oliver.

  • re-fix Acid3, some code was incorrectly moved when fixing the Qt build
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
8:06 PM Changeset in webkit [31380] by weinig@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Add support for LogicalAndNode and LogicalOrNode.

  • kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode):
  • kjs/nodes.h:
8:02 PM squirrelfish edited by oliver@apple.com
(diff)
8:01 PM squirrelfish edited by oliver@apple.com
(diff)
7:52 PM Changeset in webkit [31379] by weinig@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Sam Weinig <​sam@webkit.org>

Clean up code and debug output.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
7:09 PM Changeset in webkit [31378] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Geoffrey Garen <​ggaren@apple.com>

Moved an ASSERT to a more logical place.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
6:10 PM Changeset in webkit [31377] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-03-27 Brady Eidson <​beidson@apple.com>

Reviewed by Adam

Change the "init from WebCore resource" version of WebResource to take PassRefPtr
(more efficient)

  • WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]):
  • WebView/WebResourceInternal.h:
3:14 PM Changeset in webkit [31376] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef.

2:44 PM Changeset in webkit [31375] by weinig@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Add emitCode support for InstanceOfNode.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitInstanceOf):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::InstanceOfNode::emitCode):
  • kjs/nodes.h:
2:37 PM Changeset in webkit [31374] by Simon Hausmann
  • 11 edits in trunk/WebCore

Fix the Qt build and the build without ENABLE(SVG_FONTS)

1:58 PM Changeset in webkit [31373] by oliver@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

Bug 18142: squirrelfish needs to support dynamic scoping/with
<​http://bugs.webkit.org/show_bug.cgi?id=18142>

Reviewed by Maciej

Add support for dynamic scoping and add code to handle 'with'
statements.

12:37 PM Changeset in webkit [31372] by weinig@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

2008-03-27 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add emitCode support for NullNode, FalseNode, TrueNode, IfNode, IfElseNode, DoWhileNode and WhileNode

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Dump op_jfalse opcode.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfFalse): Identical to emitJumpIfTrue except it emits the op_jfalse opcode. (KJS::CodeGenerator::emitLoad): Add and emitLoad override for booleans.
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute): Adds execution of op_jfalse. It is identical to op_jtrue, except the the condition is reversed.
  • VM/Opcode.h: Add op_jfalse.
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): Added. (KJS::FalseNode::emitCode): Added. (KJS::TrueNode::emitCode): Added. (KJS::IfNode::emitCode): Added. (KJS::IfElseNode::emitCode): Added. (KJS::DoWhileNode::emitCode): Added. (KJS::WhileNode::emitCode): Added.
  • kjs/nodes.h:
3:56 AM Changeset in webkit [31371] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Removed whitespace that crept in from r31357.

12:12 AM Changeset in webkit [31370] by timothy@apple.com
  • 4 edits
    7 moves in trunk/WebCore

2008-03-26 Timothy Hatcher <​timothy@apple.com>

Rename some Inspector files to facilitate the up-coming UI refresh changes.

​http://bugs.webkit.org/show_bug.cgi?id=17773

Rubber-stamped by Adam Roben.

  • WebCore.vcproj/WebCore.vcproj:
  • page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
  • page/inspector/ConsolePanel.js: Removed.
  • page/inspector/DocumentPanel.js: Removed.
  • page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
  • page/inspector/FontPanel.js: Removed.
  • page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
  • page/inspector/ImagePanel.js: Removed.
  • page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
  • page/inspector/NetworkPanel.js: Removed.
  • page/inspector/ResourcePanel.js: Removed.
  • page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
  • page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
  • page/inspector/SourcePanel.js: Removed.
  • page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
  • page/inspector/WebKit.qrc:
  • page/inspector/inspector.html:

Mar 26, 2008:

11:44 PM Changeset in webkit [31369] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Steve Falkenburg <​sfalken@apple.com>

Enable LTCG on css, dom files in WebCore

Reviewed by Stephanie.

  • WebCore.vcproj/WebCore.vcproj:
11:39 PM squirrelfish edited by ggaren@apple.com
(diff)
11:24 PM Changeset in webkit [31368] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-03-26 Stephanie Lewis <Stephanie Lewis>

Fix Windows Build

  • WebCore.vcproj/WebCore.vcproj:
11:14 PM Changeset in webkit [31367] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Nixed an unused List.


The calm before my stormy war against the List class.

  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
11:01 PM Changeset in webkit [31366] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative GTK build fix.

10:16 PM Changeset in webkit [31365] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-03-26 Brady Eidson <​beidson@apple.com>

Build fix - accidentally checked in this change which was work in progress

  • DOM/WebDOMOperations.mm:
10:00 PM Changeset in webkit [31364] by ggaren@apple.com
  • 5 edits
    9 adds in branches/squirrelfish

SunSpider:

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


--squirrelfish mode: pared down tests for squirrelfish to chew on.

  • sunspider:
  • tests/LIST:
  • tests/squirrelfish: Added.
  • tests/squirrelfish/function-closure.js: Added.
  • tests/squirrelfish/function-empty.js: Added.
  • tests/squirrelfish/function-missing-args.js: Added.
  • tests/squirrelfish/function-sum.js: Added.
  • tests/squirrelfish/loop-empty-resolve.js: Added.
  • tests/squirrelfish/loop-empty.js: Added.
  • tests/squirrelfish/loop-resolve.js: Added.
  • tests/squirrelfish/loop-sum.js: Added.

WebKitTools:

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

--squirrelfish mode: pared down tests for squirrelfish to chew on.

  • Scripts/run-sunspider:
9:59 PM Changeset in webkit [31363] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Mac build fix.

9:42 PM Changeset in webkit [31362] by ggaren@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

2008-03-26 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoffrey Garen.

Adds support for EqualNode, NotEqualNode, StrictEqualNode, NotStrictEqualNode,
LessEqNode, GreaterNode, GreaterEqNode, MultNode, DivNode, ModNode, SubNode,
LeftShiftNode, RightShiftNode, UnsignedRightShiftNode, BitAndNode, BitXOrNode,
and BitOrNode.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitMult): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::jsLessEq): (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::MultNode::emitCode): (KJS::DivNode::emitCode): (KJS::ModNode::emitCode): (KJS::SubNode::emitCode): (KJS::LeftShiftNode::emitCode): (KJS::RightShiftNode::emitCode): (KJS::UnsignedRightShiftNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::BitAndNode::emitCode): (KJS::BitXOrNode::emitCode): (KJS::BitOrNode::emitCode):
  • kjs/nodes.h:
9:36 PM Changeset in webkit [31361] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Only print debug dumps in debug builds.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::generate):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
9:36 PM Changeset in webkit [31360] by mjs@apple.com
  • 1 edit
    2 adds in trunk/WebKitSite

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

More screenshots for teh blog.

  • blog-files/acid3-full-rendering-pass.png: Added.
  • blog-files/acid3-rendering-reference.png: Added.
9:33 PM Changeset in webkit [31359] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Sam Weinig <​sam@webkit.org>

Try and fix Gtk+ again.

  • GNUmakefile.am:
9:13 PM Changeset in webkit [31358] by mitz@apple.com
  • 2 edits
    2 adds in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren() on the new node. (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::reopenResidualStyleTags): Ditto. (WebCore::HTMLParser::pushBlock): Removed incorrect call to beginParsingChildren() on the current node.
  • manual-tests/applet-finish-parsing-children.html: Added.
  • manual-tests/resources/DrawMessage.class: Added.
9:08 PM Changeset in webkit [31357] by beidson@apple.com
  • 37 edits in trunk

WebCore:

2008-03-26 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"

That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node

  • WebCore.base.exp:


  • dom/Node.cpp: (WebCore::Node::getSubresourceURLs): (WebCore::Node::getSubresourceAttributeStrings): Virtual and empty. Subclasses of Node that have subresources will override it.
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
  • dom/ProcessingInstruction.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
  • html/HTMLBodyElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
  • html/HTMLEmbedElement.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
  • html/HTMLInputElement.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
  • html/HTMLLinkElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
  • html/HTMLObjectElement.h:
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
  • html/HTMLParamElement.h:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
  • html/HTMLScriptElement.h:
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
  • html/HTMLTableCellElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
  • html/HTMLTableElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
  • svg/SVGCursorElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
  • svg/SVGFEImageElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::getSubresourceAttributeStrings):
  • svg/SVGImageElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
  • svg/SVGScriptElement.h:

WebKit/mac:

2008-03-26 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"

That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node

  • DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by calling into individual WebCore::Node implementations
  • DOM/WebDOMOperationsPrivate.h:
9:02 PM Changeset in webkit [31356] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • maintain subpixel-antialiasing when drawing text with a simple shadow
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): If the shadow has a zero blur radius, draw the shadow by drawing the text at an offset instead of relying on Core Graphics shadows. (WebCore::Font::drawGlyphs): Ditto.
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.
8:58 PM Changeset in webkit [31355] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2008-03-26 Brady Eidson <​beidson@apple.com>

Reviewed by Mark Rowe

Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

  • WebCore.base.exp:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists Otherwise, fallback to an ArchiveResource from the current Archive if any. Otherwise, return null
  • loader/DocumentLoader.h:
  • loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): (WebCore::ArchiveResource::ArchiveResource):
  • loader/archive/ArchiveResource.h:

WebKit/mac:

2008-03-26 Brady Eidson <​beidson@apple.com>

Reviewed by Mark Rowe

Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

  • WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
  • WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use has now been ported down to WebCore
  • WebView/WebFrameInternal.h:
8:54 PM Changeset in webkit [31354] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Sam Weinig <​sam@webkit.org>

Fix Gtk+ build.

  • GNUmakefile.am:
8:48 PM Changeset in webkit [31353] by mrowe@apple.com
  • 6 edits in trunk

Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.

Rubber-stamped by Brady Eidson.

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/WebCore.xcconfig:
  • Configurations/WebKit.xcconfig:
8:43 PM Changeset in webkit [31352] by pewtermoose@webkit.org
  • 4 edits in trunk

WebCore:

2008-03-26 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
​http://bugs.webkit.org/show_bug.cgi?id=17985

  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

2008-03-26 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
​http://bugs.webkit.org/show_bug.cgi?id=17985

  • WebKit.vcproj/WebKit.vcproj:
8:38 PM Changeset in webkit [31351] by Adam Roben
  • 3 edits in trunk/WebCore

Record JS exceptions triggered by the Inspector's use of JSC

We now dump all exceptions returned from JavaScriptCore into the
Inspector's console.

The HANDLE_EXCEPTION macro records the line on which the exception was
returned. It calls a new private handleException method on
InspectorController.

Reviewed by Kevin McCullough.

  • page/InspectorController.cpp: (WebCore::InspectorController::callSimpleFunction): Made this be a member of InspectorController so that it can call handleException. (WebCore::addSourceToFrame): Pass the exception pointer on to inner JSC calls, and check it after those calls return. (WebCore::getResourceDocumentNode): Ditto. (WebCore::search): Ditto. Also changed the name/type of an existing exception variable to ExceptionCode ec. (WebCore::databaseTableNames): Ditto. (WebCore::moveByUnrestricted): Ditto. (WebCore::InspectorController::~InspectorController): Check for and record exceptions as we call JSC. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Added an exception parameter. (WebCore::scriptObjectForRequest): Ditto. (WebCore::scriptObjectForResponse): Ditto. (WebCore::InspectorController::addScriptResource): Check for and record exceptions as we call JSC. (WebCore::InspectorController::addAndUpdateScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::updateScriptResourceRequest): Check for and record exceptions as we call JSC. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::addScriptConsoleMessage): Check for and record exceptions as we call JSC. (WebCore::InspectorController::handleException): Added.
  • page/InspectorController.h:
8:35 PM Changeset in webkit [31350] by Adam Roben
  • 4 edits in trunk/JavaScriptCore

Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString

<​http://bugs.webkit.org/show_bug.cgi?id=18060>

Reviewed by Geoff Garen.

Bug fix:

  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks instance only be in scope while calling convertToType.

Test:

  • API/testapi.c: (MyObject_convertToType): Implement type conversion to string.
  • API/testapi.js: Add a test for type conversion to string.
8:14 PM Changeset in webkit [31349] by Darin Adler
  • 3 edits in trunk/WebCore

2008-03-26 Darin Adler <Darin Adler>

Rubber stamped by Maciej.

  • removed a couple log messages in error cases that are handled internally
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Ditto.
8:11 PM Changeset in webkit [31348] by Adam Roben
  • 4 edits in trunk/WebKitLibraries

Windows build fix after r31322

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
  • win/lib/WebKitSystemInterface.lib: Updated.
  • win/lib/WebKitSystemInterface_debug.lib: Updated.
7:56 PM Changeset in webkit [31347] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

  • page/Location.idl: Don't enumerate toString.
7:53 PM Changeset in webkit [31346] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-03-26 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Adam Roben.

Update test result.

  • fast/dom/Window/window-special-properties-expected.txt:
7:45 PM Changeset in webkit [31345] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Screenshot for blog post.

  • blog-files/acid3-100.png: Added.
7:41 PM Changeset in webkit [31344] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Release build fix.

7:34 PM Changeset in webkit [31343] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix

  • kjs/array_instance.cpp: Touched this.
  • wtf/HashFunctions.h: (WTF::intHash): Added 8- and 16-bit versions of intHash.
7:34 PM Changeset in webkit [31342] by mjs@apple.com
  • 22 edits
    5 adds in trunk

WebCore:

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Hyatt and Adam.

Coded by me and Darin.


  • SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet)


Acid3 100/100

  • DerivedSources.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.cpp: (WebCore::Font::floatWidth): (WebCore::Font::isSVGFont):
  • platform/graphics/Font.h:
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
  • rendering/SVGInlineTextBox.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  • rendering/SVGRootInlineBox.h: (WebCore::LastGlyphInfo::LastGlyphInfo):
  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): (WebCore::Font::svgFont): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::Font::floatWidthUsingSVGFont): (WebCore::Font::drawTextUsingSVGFont): (WebCore::Font::selectionRectForTextUsingSVGFont):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::invalidateGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::parseUnicodeRange): (WebCore::parseUnicodeRangeList): (WebCore::stringMatchesUnicodeRange): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
  • svg/SVGFontElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):
  • svg/SVGHKernElement.cpp: Added. (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::~SVGHKernElement): (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGHKernElement.h: Added. (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair): (WebCore::SVGHKernElement::rendererIsNeeded):
  • svg/SVGHKernElement.idl: Added.
  • svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
  • svg/svgtags.in:

LayoutTests:

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Hyatt and Adam.


  • new test case and test fixes for SVG text kerning
  • svg/text/kerning.svg: Added.
  • platform/mac/svg/text/kerning-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
7:21 PM Changeset in webkit [31341] by weinig@apple.com
  • 16 edits
    4 adds
    2 deletes in trunk/WebCore

2008-03-26 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Autogenerate JSLocation.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add files.
  • DerivedSources.make: Add Location, remove JSLocation.lut.h
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate): (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::clearHelperObjectProperties): (WebCore::JSDOMWindowBase::disconnectFrame):
  • bindings/js/JSDOMWindowBase.h: Remove manuel management of the Location object.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Add marking of JSLocation. (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when safe and we need to keep Dashboard quirks.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Fetch the location object using the normal toJS route.
  • bindings/js/JSLocation.cpp: Removed.
  • bindings/js/JSLocation.h: Removed.
  • bindings/js/JSLocationCustom.cpp: Added. (WebCore::JSLocation::customGetOwnPropertySlot): (WebCore::JSLocation::customPut): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::customGetPropertyNames): (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): Setter and Functions need custom implementations as they rely on the dynamic global object for determining the behavior of the navigation.
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
  • history/CachedPage.h: Removed all the special casing for location as it should be treated like all the other objects hanging off the window.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::location):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalLocation):
  • page/DOMWindow.idl: Add Location accessor and pointer getter for marking.
  • page/Location.cpp: Added. (WebCore::Location::Location): (WebCore::Location::disconnectFrame): (WebCore::Location::url): (WebCore::Location::href): (WebCore::Location::protocol): (WebCore::Location::host): (WebCore::Location::hostname): (WebCore::Location::port): (WebCore::Location::pathname): (WebCore::Location::search): (WebCore::Location::hash): (WebCore::Location::toString):
  • page/Location.h: Added. (WebCore::Location::create): (WebCore::Location::frame):
  • page/Location.idl: Added.
6:53 PM Changeset in webkit [31340] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/svg/custom

Add layout test results for altGlyph.

6:53 PM Changeset in webkit [31339] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/svg/custom/altglyph.svg

Add layout test for altGlyph.

6:52 PM Changeset in webkit [31338] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-03-26 David Hyatt <​hyatt@apple.com>

Add support for the rendering and measurement of the <altGlyph> element in SVG. This patch brings
is half of what's needed to reach 100/100 on Acid3 and pass the test. Maciej has coded up the other half. :)

Reviewed by mjs

Added svg/custom/altGlyph.svg

  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::glyphElement):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):
6:43 PM Changeset in webkit [31337] by Adam Roben
  • 8 edits in trunk

Turn on SVG animation on Windows

JavaScriptCore:

Force JSC headers to be copied by touching a file

  • kjs/array_instance.cpp: (KJS::ArrayInstance::getPropertyNames):

WebCore:

Turn on SVG animation on Windows

Also touched some files to force things to rebuild/regenerate.

  • WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
  • bindings/scripts/CodeGenerator.pm: Touched.
  • config.h: Touched.
  • svg/svgtags.in: Touched.
6:10 PM Changeset in webkit [31336] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Harrison.

<rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution

  • editing/markup.cpp: (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n" with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>". Don't enclose paragraphs in clones of the context's enclosing block if that block is the html or body element. Currently no way to test [DOMHTMLElement createFragmentFromText:].
5:58 PM Changeset in webkit [31335] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix after r31324

Written with Darin.

Added HashTable plumbing to support using wchar_t as a key type.

  • wtf/HashFunctions.h:
  • wtf/HashTraits.h: (WTF::):
5:21 PM Changeset in webkit [31334] by Antti Koivisto
  • 6 edits in trunk

WebCore:

2008-03-26 Antti Koivisto <Antti Koivisto>

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=17077
Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)

  • enable SVG animation support.
  • basic implementation of beginElement()/endElement().


Animation definitely will need more work than this, but it is a start!

  • Configurations/WebCore.xcconfig:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds): (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
  • svg/SVGAnimationElement.h:

WebKitTools:

2008-03-26 Antti Koivisto <Antti Koivisto>

Reviewed by Anders.


Enable SVG animation support by default.

  • Scripts/build-webkit:
4:34 PM Changeset in webkit [31333] by mrowe@apple.com
  • 10 edits in trunk

2008-03-26 Mark Rowe <​mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

  • WebCore.Tiger.exp:
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2008-03-26 Mark Rowe <​mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:

2008-03-26 Mark Rowe <​mrowe@apple.com>

Reviewed by David Hyatt.

Make the Ahem font antialias correctly on Acid3 on Tiger.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
4:03 PM squirrelfish edited by ggaren@apple.com
(diff)
4:02 PM Changeset in webkit [31332] by Simon Hausmann
  • 3 edits in trunk/WebCore

Attempt to fix the Qt build.

3:56 PM Changeset in webkit [31331] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-03-26 Stephanie Lewis <Stephanie Lewis>

Not Reviewed.

Move storage tests to Skipped list since they hang 80% of the time. See <rdar://problem/5787763>.

  • platform/win/Skipped:
3:54 PM Changeset in webkit [31330] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Moved a few files around in the XCode project.

3:50 PM Changeset in webkit [31329] by ggaren@apple.com
  • 11 edits
    2 adds in branches/squirrelfish/JavaScriptCore

2008-03-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Made closures work.


An activation object aliases to the register file until its associated
function returns, at which point it copies the registers for locals and
parameters into an independent storage buffer.

3:49 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
1:53 PM Changeset in webkit [31328] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Dan Bernstein <​mitz@apple.com>

Reviewed by Anders Carlsson.

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch old clean lines (due to changed or newly-added floats), keep the reference to those lines so they can be properly deleted in the end, and use a separate flag to signal that no matching should be attempted.
1:21 PM Changeset in webkit [31327] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative Windows build fix.

1:04 PM squirrelfish edited by weinig@apple.com
Note that Sam is working on implementing more code emitters (diff)
1:01 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
12:59 PM Changeset in webkit [31326] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 Steve Falkenburg <​sfalken@apple.com>

Turn on link-time-codegen in html and rendering related files.

Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj:
12:26 PM Changeset in webkit [31325] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • wtf/HashFunctions.h: (WTF::):
  • wtf/HashTraits.h: (WTF::):
12:22 PM Changeset in webkit [31324] by mjs@apple.com
  • 8 edits
    1 add in trunk

WebCore:

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::addGlyphToCache): (WebCore::SVGFontElement::removeGlyphFromCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::SVGFontElement::getGlyphIdentifiersForString):
  • svg/SVGFontElement.h:
  • svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
  • svg/SVGGlyphMap.h: Added. New radix tree based glyph map. (WebCore::GlyphMapNode::GlyphMapNode): (WebCore::SVGGlyphMap::SVGGlyphMap): (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get): (WebCore::SVGGlyphMap::clear):

LayoutTests:

2008-03-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

These test cases were already checking for this exact bug and now
render correctly.


  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
12:12 PM Changeset in webkit [31323] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-03-26 David Hyatt <​hyatt@apple.com>

Fix build bustage on Tiger. Tiger will not have the bug fix.

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
12:01 PM Changeset in webkit [31322] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-03-26 David Hyatt <​hyatt@apple.com>

Make the Ahem font antialias correctly on Acid3.

Reviewed by Dan

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
11:04 AM Changeset in webkit [31321] by mrowe@apple.com
  • 4 edits in trunk

Fix the Mac build.

10:49 AM Changeset in webkit [31320] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties

<​http://bugs.webkit.org/show_bug.cgi?id=17768>

We were throwing an exception from Object.describe because of some
undefined variables.

Reviewed by Tim Hatcher.

  • page/inspector/utilities.js: (Object.describe): Reinstate the type1 and type2 variables that were removed in r30146. They're still used when formatting a function.
10:44 AM Changeset in webkit [31319] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

Cache C string identifiers by address, not value, assuming that C strings can only
be literals.

1% speedup on Acid3 test 26.

  • kjs/identifier.cpp: (KJS::literalIdentifierTable): (KJS::Identifier::add): Added a new table to cache UString::Reps created from C strings by address. Elements are never removed from this cache, as only predefined identifiers can get there.
  • kjs/identifier.h: (KJS::Identifier::Identifier): Added a warning.
10:29 AM Changeset in webkit [31318] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej.

An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
The condition existed before, and got uncovered by turning compiled-out dtoa checks into
ASSERTs.

The assertion was verifying that the caller wasn't constructing a Bigint from 0.
This might have had some reason behind it originally, but I couldn't find any,
and this doesn't look like a reasonable requirement.

  • kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).
10:27 AM Changeset in webkit [31317] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by darin.

Forgot to add braces darin asked for during review.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
10:19 AM Changeset in webkit [31316] by eric@webkit.org
  • 22 edits
    7 adds in trunk

Reviewed by darin.

Fix, makes us pass Test 70
XML documents should be strict about encoding checks
​http://bugs.webkit.org/show_bug.cgi?id=17079

Test: fast/encoding/invalid-xml.html

  • WebCore.base.exp:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode):
  • loader/TextResourceDecoder.h:
  • platform/text/TextCodec.h: (WebCore::TextCodec::decode):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decodeToBuffer): (WebCore::ErrorCallbackSetter::ErrorCallbackSetter): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::TextCodecICU::decode):
  • platform/text/TextCodecICU.h:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecLatin1.h:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUTF16.h:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/TextCodecUserDefined.h:
  • platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
  • platform/text/TextDecoder.h: (WebCore::TextDecoder::decode):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
  • platform/text/TextEncoding.h: (WebCore::TextEncoding::decode):
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
  • platform/text/mac/TextCodecMac.h:
9:59 AM Changeset in webkit [31315] by Antti Koivisto
  • 9 edits
    2 adds in trunk/WebCore

2008-03-26 Antti Koivisto <Antti Koivisto>

Reviewed by Adam.

Add ElementTimeControl interface to SVGAnimationElement.
Passes Acid3 test 75.

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • svg/ElementTimeControl.h: Added. (WebCore::ElementTimeControl::~ElementTimeControl):
  • svg/ElementTimeControl.idl: Added.
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
  • svg/SVGAnimationElement.h:
  • svg/SVGAnimationElement.idl:
9:22 AM Changeset in webkit [31314] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-26 Kevin McCullough <​kmccullough@apple.com>

  • LayoutTest fix. Null check.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
7:33 AM Changeset in webkit [31313] by mitz@apple.com
  • 5 edits
    12 adds in trunk

WebCore:

Reviewed by Darin Adler.

Tests: fast/repaint/subtree-root-clip.html

fast/repaint/subtree-root-clip-2.html
fast/repaint/subtree-root-clip-3.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Changed to not set an initial clip. Since the root is clipping, there is no need to set a clip, and setting the clip based on the container was wrong because often the root was not included in the container's overflow rect because it had its own layer.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Removed code that added table cell's extra top offset only in the slow (recursive) code path.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Added code to add the extra top offset in both code paths.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/subtree-root-clip-2.html: Added.
  • fast/repaint/subtree-root-clip-3.html: Added.
  • fast/repaint/subtree-root-clip.html: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
6:00 AM Changeset in webkit [31312] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build.

3:18 AM Changeset in webkit [31311] by mjs@apple.com
  • 2 edits in trunk

Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog

3:10 AM Changeset in webkit [31310] by mjs@apple.com
  • 15 edits
    2 adds in trunk

WebCore:

2008-03-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Maciej.

  • platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end, and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
  • platform/graphics/Font.h:
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out argument. (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument. (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs right but I don't know what effects this would have.
  • rendering/SVGInlineTextBox.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right but again I am not sure what effect this would have. (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
  • rendering/SVGRootInlineBox.h:
  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how many chars were consumed). (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers. (WebCore::Font::floatWidthUsingSVGFont): ditto (WebCore::Font::drawTextUsingSVGFont): ditto (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
  • svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): ditto (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto

LayoutTests:

2008-03-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Maciej.

  • svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar access of multichar glyphs.
  • platform/mac/svg/text/multichar-glyph-expected.txt: Added.

The following test results changed, all appear to be improvements.


  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
Note: See TracTimeline for information about the timeline view.