⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 29, 2008:

9:58 PM Changeset in webkit [31439] by mjs@apple.com
  • 8 edits in trunk/WebCore

2008-03-28 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.

  • yet still more bindings speedup


Make AtomicString straight from UString in handcoded bindings

  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNS):
  • dom/Document.cpp: (WebCore::Document::createElement):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
  • html/HTMLDocument.h:
7:21 PM Changeset in webkit [31438] by weinig@apple.com
  • 10 edits in trunk/WebCore

2008-03-29 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix for <rdar://problem/5828873>

Since NSURL is allowing invalid urls to be loaded, we need to
check the URL validity at the ResourceHandle level and fire off
a cannotShowURL error.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::cannotShowURLError):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::wasBlocked): (WebCore::ResourceLoader::cannotShowURL):
  • loader/ResourceLoader.h:
  • platform/KURL.h: (WebCore::KURL::isValid):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::scheduleFailure): (WebCore::ResourceHandle::fireFailure): (WebCore::portAllowed):
  • platform/network/ResourceHandle.h: (WebCore::ResourceHandle::):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::cannotShowURL):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
6:47 PM Changeset in webkit [31437] by Darin Adler
  • 3 edits in trunk/WebCore

2008-03-29 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • more bindings speedup

When I changed the temporary variables to be UString that means that the
valueToString functions also need to return UString to avoid converting
from UString to String twice.

  • bindings/js/kjs_binding.cpp: (WebCore::valueToStringWithNullCheck): Changed return value to UString. (WebCore::valueToStringWithUndefinedOrNullCheck): Ditto.
  • bindings/js/kjs_binding.h: Ditto.
10:52 AM Changeset in webkit [31436] by Darin Adler
  • 2 edits in trunk/WebCore

2008-03-29 Darin Adler <Darin Adler>

Reviewed by Sam.

  • DerivedSources.make: Removed temporary remove-stray-JSRGBColor build rule.
10:51 AM Changeset in webkit [31435] by Darin Adler
  • 21 edits in trunk/WebCore

2008-03-29 Darin Adler <Darin Adler>

Reviewed by Sam.

  • tweak handling of the class attribute to speed up code that sets it but never needs to parse it

6% speedup of Acid3 test 26

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Change to use non-virtual classNames function since the hasClass bit can only be set for a StyledElement. (WebCore::CSSStyleSelector::checkOneSelector): Ditto. Also streamlined the code a bit for the tag matching as well.
  • dom/ClassNames.cpp: (WebCore::hasNonASCIIOrUpper): Added. This function does what other callers seem to want isLower() to do. We should merge this with isLower() in a subsequent cleanup pass. (WebCore::ClassNamesData::createVector): Renamed from parseClassAttribute. Turns the string into a vector. (WebCore::ClassNamesData::containsAll): Added. Used by getElementsByClassName.
  • dom/ClassNames.h: Added a separate ClassNameData class so we could hold the string and case folding flag as well as the vector. Changed ClassNames to have a set function rather than a parseClassAttribute function. Removed the "static" from isClassWhitespace. There's no reason to ask for internal linkage.
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Use constructor instead of the parseClassAttribute function. (WebCore::ClassNodeList::nodeMatches): Get rid of unnneeded isElementNode check, since hasClass will only be true for StyledElement nodes. Use the new containsAll function in ClassNames instead of having a loop here.
  • dom/ClassNodeList.h: Removed unneeded forward declaration.
  • dom/Document.cpp: Removed unneeded include.
  • dom/Element.cpp: (WebCore::Element::cloneNode): Changed code to copy attributes to use a function call instead of the assignment operator. This paves the way to making the function more efficient, using a virtual function. (WebCore::Element::setAttributeMap): Updated for PassRefPtr and for name change (element -> m_element). (WebCore::Element::createAttributeMap): Changed to use create function instead of calling the constructor directly.
  • dom/Element.h: Removed unneeded virtual getClassNames function. Changed the argument to setAttributeMap to be a PassRefPtr.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::NamedAttrMap): Updated for name change (element -> m_element). (WebCore::NamedAttrMap::getNamedItem): Ditto. (WebCore::NamedAttrMap::removeNamedItem): Ditto. (WebCore::NamedAttrMap::setNamedItem): Ditto. (WebCore::NamedAttrMap::item): Ditto. (WebCore::NamedAttrMap::detachFromElement): Ditto. (WebCore::NamedAttrMap::setAttributes): Renamed this from the assignment operator. (WebCore::NamedAttrMap::addAttribute): Ditto. (WebCore::NamedAttrMap::removeAttribute): Ditto. (WebCore::NamedAttrMap::isReadOnlyNode): Ditto.
  • dom/NamedAttrMap.h: Removed the copy constructor and assignment operator and added a new function, setAttributes, possibly to be made virtual in the future. Made isReadOnlyNode non-virtual. Renamed element -> m_element. Made constructor protected and added a create function.
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Changed constructor parameter to take a StyledElement. (WebCore::NamedMappedAttrMap::setClass): Changed to use the new set function.
  • dom/NamedMappedAttrMap.h: Made constructor private and added a create function. Replaced theparseClassAttribute function with clearClass and setClass functions. Replaced the getClassNames function with a classNames function returning a reference instead of a pointer.
  • dom/NamedNodeMap.h: Changed to start refcount at 1 instead of 0. Removed unneeded virtual function isReadOnlyNode.
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Rewrote class attribute handling to use new function names and took out uneeded special case for null attribute. (WebCore::StyledElement::createAttributeMap): Changed to use create function instead of a direct call to new.
  • dom/StyledElement.h: Replaced the virtual getClassNames function with a non-virtual inline classNames function.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode): Changed code to copy attributes to use a function call instead of the assignment operator.
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Use create function instead of a a direct call to new.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use RefPtr and the new create function. (WebCore::HTMLViewSourceDocument::addViewSourceToken): Ditto. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addText): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
  • html/HTMLViewSourceDocument.h: Ditto.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Changed code to copy attributes to use a function call instead of the assignment operator. (WebCore::SVGUseElement::transferUseAttributesToReplacedElement): Ditto.
8:17 AM Changeset in webkit [31434] by weinig@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-03-29 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Fix crash when canceling a resource load while port blocked failure
timer is going.

Test: fast/loader/cancel-load-during-port-block-timer.html

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::scheduleBlockedFailure): (WebCore::ResourceHandle::fireBlockedFailure):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Make the Timer a member variable of ResourceHandleInternal so that it can be canceled if the ResourceHandle is destroyed.

LayoutTests:

2008-03-29 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Test for crash when canceling a resource load while port blocked failure
timer is going

  • fast/loader/cancel-load-during-port-block-timer-expected.txt: Added.
  • fast/loader/cancel-load-during-port-block-timer.html: Added.
1:18 AM Changeset in webkit [31433] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

<rdar://problem/5829556> REGRESSION: Leak in KJS::initializeThreading()

  • kjs/InitializeThreading.cpp: (KJS::initializeThreading): There is no guarantee that initializeThreading() is called only once; check that the mutex hasn't been already allocated.
1:15 AM squirrelfish edited by ggaren@apple.com
(diff)
1:13 AM Changeset in webkit [31432] by ggaren@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-03-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Mark the register file.


It's a conservative mark for now, but once registers are typed, we can
do an exact mark.


1.4% regression regardless of whether we actually do the marking.
GCC is is worth every penny.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Most of the changes here are just for the fact that "registers" is a pointer now.
  • kjs/JSGlobalObject.cpp: The global object owns the register file now.
12:25 AM Changeset in webkit [31431] by oliver@apple.com
  • 5 edits in trunk

Bug 17924: Crash in KJS::ConstDeclNode::evaluate with |with| and |const|
<​http://bugs.webkit.org/show_bug.cgi?id=17924>
<rdar://problem/5806933>

Reviewed by Geoff.

It turns out this is trivially avoidable if we just match firefox's
semantics and ensure that an assignment in a const declaration always
writes to the variable object.

Mar 28, 2008:

11:46 PM squirrelfish edited by ggaren@apple.com
(diff)
11:45 PM squirrelfish edited by ggaren@apple.com
(diff)
9:29 PM Changeset in webkit [31430] by oliver@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

Bug 18204: SquirrelFish: continue/break do not correctly handle scope popping
<​http://bugs.webkit.org/show_bug.cgi?id=18204>

Reviewed by Maciej.

We now track the scope depth as part of a loop context, and add an
extra instruction op_jump_scopes that is used to perform a jump across
dynamic scope boundaries.

8:38 PM Changeset in webkit [31429] by Stephanie Lewis
  • 3 edits in trunk/WebCore

2008-03-28 Stephanie <Stephanie Lewis>

Fix 64bit build

  • WebCore.LP64.exp:
  • loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::createResourceResponseFromMacArchivedData):
8:31 PM Changeset in webkit [31428] by weinig@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-28 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add emitCode support for ConditionalNode.

  • kjs/nodes.cpp: (KJS::ConditionalNode::emitCode):
  • kjs/nodes.h:
8:28 PM Changeset in webkit [31427] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-03-28 Steve Falkenburg <​sfalken@apple.com>

Enabled LTCG on files within "page".

Rubber stamped by Oliver.

  • WebCore.vcproj/WebCore.vcproj:
8:07 PM Changeset in webkit [31426] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix a percentage background position regression from r31389

Test: fast/backgrounds/background-position-1.html

  • rendering/Length.h: (WebCore::Length::calcValue): Divide by 100. (WebCore::Length::calcMinValue): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • pixel test for a percentage background position regression from r31389
  • fast/backgrounds/background-position-1.html: Added.
  • platform/mac/fast/backgrounds/background-position-1-expected.checksum: Added.
  • platform/mac/fast/backgrounds/background-position-1-expected.png: Added.
  • platform/mac/fast/backgrounds/background-position-1-expected.txt: Added.
7:21 PM Changeset in webkit [31425] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Oops. Back out unintentional change to RenderBlock.cpp

7:21 PM Changeset in webkit [31424] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-03-28 David Hyatt <​hyatt@apple.com>

Back out the Ahem font antialiasing hack, since it is now no longer required for LCD antialiased text
to match the reference rendering on Acid 3.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):
5:51 PM Changeset in webkit [31423] by beidson@apple.com
  • 8 edits
    2 deletes in trunk/WebKit

WebKit:

2008-03-28 Brady Eidson <​beidson@apple.com>

Rubberstamped by Darin Adler

Remove WebArchiver.h/mm

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-28 Brady Eidson <​beidson@apple.com>

Rubberstamped by Darin Adler

Remove WebArchiver.h/mm

  • WebView/WebArchiver.h: Removed.
  • WebView/WebArchiver.mm: Removed.
  • DOM/WebDOMOperations.mm:
  • WebCoreSupport/WebDragClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebHTMLView.mm:
5:49 PM Changeset in webkit [31422] by sfalken@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKitLibraries

Merged fix from r31420.

5:40 PM Changeset in webkit [31421] by beidson@apple.com
  • 5 edits in trunk/WebKit/mac

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection):
  • WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
  • WebView/WebArchiver.mm: Ditto
  • WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
5:35 PM Changeset in webkit [31420] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Versioning.

5:18 PM Changeset in webkit [31419] by beidson@apple.com
  • 6 edits in trunk

WebCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

More Kit->Core WebArchive changes.

Create an archive from the current selection in a frame

  • WebCore.base.exp:
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • loader/archive/cf/LegacyWebArchive.h:

WebKit/mac:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

More Kit->Core WebArchive changes.

Create an archive from the current selection in a frame

  • WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off easily in a followup
5:14 PM Changeset in webkit [31418] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-28 Kevin McCullough <​kmccullough@apple.com>

  • Somehow managed to duplicate code :(
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
5:04 PM Changeset in webkit [31417] by ggaren@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-03-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Responding to feedback, added some comments, fixed up a few names, and
clarified that "locals" always means all local variables, functions,
and parameters.

5:01 PM Changeset in webkit [31416] by ggaren@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

2008-03-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added support for "this".


Supply an implicit "this" value as the first argument to every function.
Alias the "this" keyword to that argument.


1% regression overall, 2.5% regression on empty function calls. Seems
like a reasonable cost for now, since we're doing more work.
(Eventually, we might decide to create a version of op_call specialized
for a known null "this" value.)

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall):
  • VM/CodeGenerator.h: (KJS::CodeGenerator::CodeGenerator):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
  • kjs/CommonIdentifiers.h:
  • kjs/nodes.cpp: (KJS::ThisNode::emitCode): (KJS::FunctionCallResolveNode::emitCode):
  • kjs/nodes.h:
4:50 PM Changeset in webkit [31415] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-28 Kevin McCullough <​kmccullough@apple.com>

  • Missed some changes in previous checkin.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Get identifier from synchronous loader. (WebCore::XMLHttpRequest::didFinishLoading):
4:28 PM Changeset in webkit [31414] by kmccullough@apple.com
  • 7 edits in trunk/WebCore

2008-03-28 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)

  • Send the XMLHttpRequest data to the Inspector Controller.
  • loader/FrameLoader.cpp: Return the identifier for this resource since we need it in the XHR case. (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/FrameLoader.h: Ditto.
  • page/InspectorController.cpp: (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): We only need the data since the type will be XHR and the encoding is not used (we decoded earlier). (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): Locking is necessary when setting and clearing the KJS::UString::Rep. (WebCore::InspectorResource::setXMLHttpRequestProperties): (WebCore::InspectorResource::sourceString): Return the decoded source. (WebCore::addSourceToFrame): No longer do the decoding here, it has been encapsulated in the InspectorResource. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  • page/InspectorController.h: Pass a UString instead of copying to a WebCore::String. In case we never ask for the string's contents this will save us an extra copy.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): In the synchronous load case we normally do not keep the identifier but we need it to find the InspectorResource in order to tell it that it was loaded via XHR. (WebCore::XMLHttpRequest::didFinishLoading): Tell the InspectorController that its resource was loaded via XHR.
  • xml/XMLHttpRequest.h: Ditto.
4:28 PM Changeset in webkit [31413] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-03-28 Stephanie Lewis <Stephanie Lewis>

Update Windows Skipped list. Bugs filed.

  • platform/win/Skipped:
4:11 PM Changeset in webkit [31412] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

WebArchive saga continues - Can now make archives from ranges in WebCore

Again, previous layout test coverage exercised this code

  • WebCore.base.exp:
  • editing/markup.cpp: (WebCore::createFullMarkup): Added a "markup from range" variant that copies the previous WebKit implementation
  • editing/markup.h:
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
  • loader/archive/cf/LegacyWebArchive.h:

WebKit/mac:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

WebArchive saga continues - Can now make archives from ranges in WebCore

  • DOM/WebDOMOperations.mm: (-[DOMRange webArchive]): (-[DOMRange markupString]):
  • WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
  • WebView/WebArchiver.mm:
3:39 PM Changeset in webkit [31411] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Bug 18192: Squirrelfish needs support for break and continue
<​http://bugs.webkit.org/show_bug.cgi?id=18192>

Reviewed by Geoff

Added a loop context stack to the code generator to provide the
correct jump labels for continue and goto. Added logic to the
currently implemented loop constructs to manage entry and exit
from the loop contexts. Finally, implemented codegen for break
and continue (and a pass through for LabelNode)

3:09 PM Changeset in webkit [31410] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-03-28 Stephanie Lewis <Stephanie Lewis>

windows build fix.

  • platform/win/MainThreadWin.cpp: (WebCore::initializeThreadingAndMainThread):
2:29 PM Changeset in webkit [31409] by beidson@apple.com
  • 8 edits in trunk

WebCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

More Kit->Core webarchive code movement

  • WebCore.base.exp:
  • editing/markup.cpp: (WebCore::createFullMarkup): Replacement for [DOMNode markupString], creating full markup at this node including the document type string, which the WebKit implementation did indirectly
  • editing/markup.h:

WebKit/mac:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

More Kit->Core webarchive code movement

  • DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Call createFullMarkup() instead
  • WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
  • WebView/WebFrameInternal.h: Ditto
2:01 PM Changeset in webkit [31408] by mrowe@apple.com
  • 5 edits
    2 adds in branches/Safari-3-1-branch

Merge r31071.

2:01 PM Changeset in webkit [31407] by mrowe@apple.com
  • 2 edits
    2 adds in branches/Safari-3-1-branch/WebCore

Merge r31358.

2:00 PM Changeset in webkit [31406] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r31336.

1:56 PM Changeset in webkit [31405] by Darin Adler
  • 10 edits in trunk/WebCore

2008-03-28 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • cut down on copying and refcount churn a little by using references a bit more for KURL and String
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Use const KURL& instead of KURL.
  • css/StyleSheet.h: (WebCore::StyleSheet::href): Return const String& instead of String. (WebCore::StyleSheet::title): Ditto.
  • dom/Document.cpp: (WebCore::Document::completeURL): Use const KURL* for a local variable instead of KURL to avoid copying the KURL.
  • dom/Element.cpp: (WebCore::Element::baseURI): Use const KURL& instead of KURL.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hostname): Ditto.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Ditto.
  • html/HTMLKeygenElement.cpp: Removed unneeded include of KURL.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Get rid of temporary KURL.
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createForFrame): Use const KURL& instead of KURL.
1:21 PM Changeset in webkit [31404] by ap@webkit.org
  • 14 edits
    3 adds in trunk

Reviewed by Sam Weinig.

Fix a dtoa thread safety issue.

WebCore can call kjs_strtod without holding JS lock, but we didn't have thread safety
compiled in for dtoa.

This is a 0.5% regression on SunSpider, which Sam Weinig has volunteered to cover with
his recent improvement.

  • kjs/dtoa.cpp: (Bigint::Balloc): (Bigint::Bfree): Changed to use fastMalloc/fastDelete - they are much faster than the dtoa custom version was in the presence of locking (but somewhat slower in single-threaded case). (Bigint::pow5mult): Got rid of the dreaded double-checked locking anti-pattern (had to restructure the code to avoid significant performance implications). (Bigint::lshift): Rewrote to avoid an allocation, if possible.

(Bigint::rv_alloc):
(Bigint::kjs_freedtoa):
(Bigint::kjs_dtoa):
Check for USE(MULTIPLE_THREADS), not dtoa legacy MULTIPLE_THREADS.

  • kjs/InitializeThreading.cpp: Added. (KJS::initializeThreading):
  • kjs/InitializeThreading.h: Added. Initialize threading at KJS level, if enabled.
  • kjs/dtoa.h: Expose dtoa mutex for KJS::initializeThreading.
  • kjs/testkjs.cpp: (kjsmain): Call initializeThreading.
  • wtf/Threading.h: Removed a using directive for WTF::initializeThreading - it is only to be called from KJS::initializeThreading, and having it in the global namespace is useless.
1:02 PM Changeset in webkit [31403] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-03-28 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Maciej, landed by Brady

Correct build regression (​http://bugs.webkit.org/show_bug.cgi?id=18148)

  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
1:01 PM Changeset in webkit [31402] by beidson@apple.com
  • 4 edits in trunk/WebKit/mac

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller

  • WebView/WebArchiver.h:
  • WebView/WebArchiver.mm:
  • WebView/WebDataSource.mm: (-[WebDataSource webArchive]):
12:57 PM Changeset in webkit [31401] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Remove unused [WebArchiver archiveNode:], made obsolete in r31400

  • WebView/WebArchiver.h:
  • WebView/WebArchiver.mm:
12:47 PM Changeset in webkit [31400] by beidson@apple.com
  • 7 edits in trunk

WebCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

"Yet another transitional step" to empty out WebKit-based code for archiving.

With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.

This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
covered the relevant code

  • WebCore.base.exp:
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
  • loader/archive/cf/LegacyWebArchive.h:

WebKit/mac:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

"Yet another transitional step" to empty out WebKit-based code for archiving.

With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.

  • DOM/WebDOMOperations.mm:
  • WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
11:26 AM Changeset in webkit [31399] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-28 Jasper Bryant-Greene <​jasper@unix.geek.nz>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18061
PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets

Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.

  • platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::geometryChanged):
10:53 AM Changeset in webkit [31398] by beidson@apple.com
  • 6 edits
    1 add in trunk

JavaScriptCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Export Unicode/UTF8.h and convertUTF16ToUTF8() for more flexible conversion in WebCore

WebCore:

2008-03-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
created from a String.

  • ForwardingHeaders/wtf/unicode/UTF8.h: Added.
  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::utf8Buffer):
10:37 AM Changeset in webkit [31397] by Darin Adler
  • 3 edits in trunk/WebCore

2008-03-28 Darin Adler <Darin Adler>

Reviewed by Adam.

  • eliminate a tiny bit of unnecessary refcount churn
  • bindings/js/JSEventTargetBase.cpp: (WebCore::eventNameForPropertyToken): Return const AtomicString&.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::getValueProperty): Update for above change. (WebCore::JSEventTargetBase::putValueProperty): Ditto.
10:03 AM Changeset in webkit [31396] by Darin Adler
  • 3 edits in trunk/LayoutTests

2008-03-28 Darin Adler <Darin Adler>

Reviewed by Sam.

  • fast/encoding/invalid-xml-expected.txt: Update to reflect a true success.
  • fast/encoding/resources/invalid-xml.js: Eliminate race condition by not ending the test until the js-test-post.js script has loaded.
9:26 AM Changeset in webkit [31395] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Brady.

Enable server-side includes via AddHandler, hopefully making Apache 1.3 happy.

  • http/tests/misc/.htaccess:
  • http/tests/misc/resources/acid3/.htaccess:
9:16 AM Changeset in webkit [31394] by Darin Adler
  • 3 edits in trunk/WebKitSite

2008-03-28 Darin Adler <Darin Adler>

  • building/build.html: Add another mention of using the Cygwin shell.
  • building/tools.html: Fix a typo on the name Cygwin.
7:15 AM Changeset in webkit [31393] by ap@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed.

Enable mod_include for acid3.html - the previous check-in only had it in resources
subdirectory.

  • http/tests/misc/.htaccess: Added.
2:44 AM Changeset in webkit [31392] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build.

  • rendering/Length.h: Include wtf/MathExtras.h for round().
2:23 AM Changeset in webkit [31391] by eric@webkit.org
  • 1 edit
    23 adds in trunk/LayoutTests

Reviewed by mjs.

Add Acid3 test as an http test
​http://bugs.webkit.org/show_bug.cgi?id=18176

  • http/tests/misc/acid3-expected.checksum: Added.
  • http/tests/misc/acid3-expected.png: Added.
  • http/tests/misc/acid3-expected.txt: Added.
  • http/tests/misc/acid3.html: Added.
  • http/tests/misc/resources/acid3/.htaccess: Added.
  • http/tests/misc/resources/acid3/empty.css: Added.
  • http/tests/misc/resources/acid3/empty.html: Added.
  • http/tests/misc/resources/acid3/empty.png: Added.
  • http/tests/misc/resources/acid3/empty.txt: Added.
  • http/tests/misc/resources/acid3/empty.xml: Added.
  • http/tests/misc/resources/acid3/font.svg: Added.
  • http/tests/misc/resources/acid3/font.ttf: Added.
  • http/tests/misc/resources/acid3/instructions.inc: Added.
  • http/tests/misc/resources/acid3/reference.html: Added.
  • http/tests/misc/resources/acid3/reference.png: Added.
  • http/tests/misc/resources/acid3/support-a.png.404: Added.
  • http/tests/misc/resources/acid3/support-b.png: Added.
  • http/tests/misc/resources/acid3/support-c.png: Added.
  • http/tests/misc/resources/acid3/svg.xml: Added.
  • http/tests/misc/resources/acid3/xhtml.1: Added.
  • http/tests/misc/resources/acid3/xhtml.2: Added.
  • http/tests/misc/resources/acid3/xhtml.3: Added.
1:54 AM Changeset in webkit [31390] by hyatt@apple.com
  • 5 adds in trunk/LayoutTests

Add layout tests for background position rounding.

1:53 AM Changeset in webkit [31389] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-03-28 David Hyatt <​hyatt@apple.com>

Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
pixel values. This matches other browsers.

Reviewed by maciej

Added fast/backgrounds/background-position-rounding.html

  • rendering/Length.h: (WebCore::Length::calcValue): (WebCore::Length::calcMinValue):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundImageGeometry):
Note: See TracTimeline for information about the timeline view.