⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 4, 2008:

11:34 PM Changeset in webkit [31656] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Only delete the backing store of background windows.

Reviewed by Ada Chan.

  • WebView.cpp: (WebView::WebView): (WebView::deleteBackingStore): (WebView::paint): Added active check. (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon): Added. (WebView::active): Added. (WebView::updateActiveState): Moved active check code from here to active().
  • WebView.h:
10:50 PM Changeset in webkit [31655] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Fix tooltip window leak.


Explicitly call DestroyWindow on the tooltip.
Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.

Reviewed by Ada Chan.

  • WebView.cpp: (WebView::~WebView):
10:17 PM Changeset in webkit [31654] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Add GradientWx.cpp to the wx build process.

9:54 PM Changeset in webkit [31653] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • speed up CSSFontSelector::getFontData()
  • css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Factored out of getFontData(). (WebCore::CSSFontSelector::getFontData): Changed to call fontDataForGenericFamily() directly if the map is empty.
9:02 PM Changeset in webkit [31652] by jhoneycutt@apple.com
  • 5 edits in trunk/WebCore

2008-04-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Oliver.

Replace AccessibilityObject::isRenderImage() with a virtual
RenderObject::isRenderImage().

  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored): (WebCore::AccessibilityObject::addChildren):
  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::isDetached):
  • rendering/RenderImage.h: (WebCore::RenderImage::isRenderImage):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderImage):
7:14 PM Changeset in webkit [31651] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Delete backing store after we go 5 seconds without a paint.


Timer will be reset if a paint occurs, so this won't negatively impact performance.


Reviewed by Ada Chan.

  • WebView.cpp: (WebView::paint): Call deleteBackingStoreSoon after paint. (WebViewWndProc): Add DeleteBackingStoreTimer. (WebView::deleteBackingStoreSoon): Added.
  • WebView.h: Add deleteBackingStoreSoon.
5:13 PM Changeset in webkit [31650] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the wx build
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::fontWeightToWxFontWeight): (WebCore::FontPlatformData::FontPlatformData):
5:05 PM Changeset in webkit [31649] by jhoneycutt@apple.com
  • 4 edits in trunk/WebCore

2008-04-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Beth.

Some more clean-up of AccessibilityObject:

  • Rearranged/grouped methods.
  • Marked many methods const.
  • Changed many methods to take args by const ref instead of by val.
  • Made headingLevel() static.
  • Renamed detached() to isDetached(), loaded() to isLoaded(), documentLinks to getDocumentLinks().
  • Made clearChildren(), removeAXObjectID(), isDetached() private.
  • Added notImplemented() calls for unimplemented methods.
  • Replaced stringForReplacedNode method with static function.
3:32 PM squirrelfish edited by weinig@apple.com
Remove some implemented Nodes from un-implemented opcode list (diff)
2:13 PM Changeset in webkit [31648] by timothy@apple.com
  • 2 edits in trunk/WebCore

Restore the user entered text when clearing the auto-completion.
This is important when the user typed text that is a different
case than the completion. This has no affect on the Console, since
it matches completions case-sensitively. This is used in the up-coming
Database Query view for words like "SELECT" and "INSERT".

Reviewed by Adam Roben.

  • page/inspector/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
text in the original DOM range that complete() saved away.
(WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
and it's text content so clearAutoComplete can restore it.

2:11 PM Changeset in webkit [31647] by weinig@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

2008-04-04 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

  • Implement codegen for Switch statements.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::pushJumpContext): (KJS::CodeGenerator::popJumpContext): (KJS::CodeGenerator::jumpContextForLabel):
  • VM/CodeGenerator.h: Rename LoopContext to JumpContext now that it used of Switch statements in addition to loops.
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::ContinueNode::emitCode): (KJS::BreakNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock): (KJS::SwitchNode::emitCode):
  • kjs/nodes.h: (KJS::CaseClauseNode::expr): (KJS::CaseClauseNode::children): (KJS::CaseBlockNode::):
1:58 PM Changeset in webkit [31646] by timothy@apple.com
  • 2 edits in trunk/WebCore

Don't trim whitespace when looking for the current match, this prevents tabbing through matches in the up-coming Database Query view.

Reviewed by Adam Roben.

  • page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
1:50 PM Changeset in webkit [31645] by timothy@apple.com
  • 5 edits
    1 add in trunk/WebCore

Factor out the Console text completion and command history into
a new TextPrompt object. This TextPrompt object will be used later
other parts of the Inspector that need text completion and history.
Not functionality changed, just moved code around.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
  • page/inspector/Console.js: Call the new prompt object and delete all the code that moved.
  • page/inspector/TextPrompt.js: Added. Moved code from Console.js.
  • page/inspector/WebKit.qrc: Add TextPrompt.js.
  • page/inspector/inspector.html: Add TextPrompt.js.
1:29 PM Changeset in webkit [31644] by timothy@apple.com
  • 2 edits in trunk/WebCore

Makes setting shouldRefreshChildren on a TreeElement perform the refresh
immediately if the element is already expanded.

Reviewed by Adam Roben.

  • page/inspector/treeoutline.js:

(TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
(TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
already expanded,
call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
(TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
(TreeElement.prototype.expand): Ditto.

1:21 PM ApplicationsGtk edited by alp@atoker.com
Epiphany is now WebKit-only (diff)
1:17 PM Changeset in webkit [31643] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2008-04-04 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Beth.

Some clean up of AccessibilityObject:

  • Use existing isImage() in more places.
  • Use existing isTextControl() in more places.
  • Added isRenderImage(). Check this before casting to RenderImage, since other, non-RenderImage derived RenderObjects (e.g. RenderListMarker) can return true for isImage().
  • Fix two copy/paste errors with improper semicolons.
  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isImageButton): Use isImage(). (WebCore::AccessibilityObject::isRenderImage): Added. (WebCore::AccessibilityObject::isAnchor): Use isImage(). (WebCore::AccessibilityObject::isAttachment): Same. (WebCore::AccessibilityObject::accessibilityDescription): Same. (WebCore::AccessibilityObject::accessibilityIsIgnored): Use isRenderImage() instead of isImage(). (WebCore::AccessibilityObject::url): Use isImage(). (WebCore::AccessibilityObject::textControl): Remove improper semicolon, and use isTextControl(). (WebCore::AccessibilityObject::textMarkerForIndex): Same. (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl(). (WebCore::AccessibilityObject::doAXRangeForLine): Same. (WebCore::AccessibilityObject::doAXRangeForIndex): Same (WebCore::AccessibilityObject::doAXStringForRange): Same. (WebCore::AccessibilityObject::roleValue): Use isImage(). (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
  • page/AccessibilityObject.h:
1:13 PM Changeset in webkit [31642] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a null exception when hovering in some areas of the DOM tree.

Reviewed by Adam Roben.

  • page/inspector/treeoutline.js:

(TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
before accessing any properties. Return null if listNode is null.

1:05 PM Changeset in webkit [31641] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changing WebInspector.currentFocusElement to/from an input element
does not change the actual focus of that input element. You see this
in the search field.

Reviewed by Adam Roben.

  • page/inspector/inspector.js:

(WebInspector.set currentFocusElement): Call blur and focus if the
node implements them.

12:18 PM Changeset in webkit [31640] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-04-04 David Hyatt <​hyatt@apple.com>

Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
Treat them as having a background-size of 100%. This means their maximal size will be the box established
by background-origin.

Reviewed by Beth

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
12:16 PM Changeset in webkit [31639] by timothy@apple.com
  • 5 edits in trunk/WebCore

Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
from view-source.css for the DOCTYPE in the DOM tree.

Reviewed by Adam Roben.

  • css/view-source.css: Add and correct comments about keeping

in-sync with inspector.css.

  • page/inspector/ElementsPanel.js:

(WebInspector.DocumentPanel.prototype.updateBreadcrumb):
Add a case for Node.DOCUMENT_TYPE_NODE.

  • page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
  • page/inspector/utilities.js:

(nodeTitleInfo): Use the webkit-html-doctype class for nodes
with Node.DOCUMENT_TYPE_NODE.

12:02 PM Changeset in webkit [31638] by mitz@apple.com
  • 1 edit
    1 copy in trunk/WebCore
  • try to fix the Tiger build
  • icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
11:17 AM Changeset in webkit [31637] by Adam Roben
  • 4 edits in trunk

Make WebKit use WebCore's copy of the ICU headers

WebCore:

Copy icu/ to PrivateHeaders for WebKit's benefit

Rubberstamped by Tim Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding Headers build phase to Copy Forwarding and ICU Headers, and added the icu/ directory to it.

WebKit/mac:

Use WebCore's ICU headers instead of our own copy

Rubberstamped by Tim Hatcher.

  • Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's PrivateHeaders.
10:47 AM Changeset in webkit [31636] by Adam Roben
  • 4 edits in trunk

Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies

WebCore:

Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies

Patch by Tim Hatcher, typed by me.

  • WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy Forwarding Headers, that copies the ForwardingHeaders directory to WebCore's PrivateHeaders directory.

WebKit/mac:

Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies

Patch by Tim Hatcher, typed by me.

  • Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in WebCore's PrivateHeaders instead of our own copy.
10:21 AM Changeset in webkit [31635] by adachan@apple.com
  • 7 edits in trunk

WebCore:

Changed the signature of imageTitleForFilename so we can pass in the width
and height as integers.

Reviewed by Dan.

  • page/mac/WebCoreViewFactory.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle):

WebKit:

Updated the format string for window title for a standalone image to take integers.

Reviewed by Dan.

  • English.lproj/Localizable.strings:

WebKit/mac:

Now we pass width and height directly as integers to format
the window title for a standalone image.

Reviewed by Dan.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:width:height:]):
8:57 AM Changeset in webkit [31634] by adachan@apple.com
  • 3 edits in trunk/WebKit/win

<rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
Changed the format string to take in integers.

Reviewed by Dan.

  • English.lproj/Localizable.strings: Updated.
  • WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
12:54 AM squirrelfish edited by ggaren@apple.com
(diff)
12:52 AM QtWebKitContrib edited by Simon Hausmann
(diff)
12:42 AM squirrelfish edited by ggaren@apple.com
(diff)

Apr 3, 2008:

11:38 PM Changeset in webkit [31633] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam.


  • fix crash in codegen from new nodes
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitConstruct):
  • kjs/nodes.h:
11:38 PM Changeset in webkit [31632] by mjs@apple.com
  • 1 edit in branches/squirrelfish/JavaScriptCore/kjs/nodes.h

File I forgot in my last commit.

11:34 PM Changeset in webkit [31631] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/nodes.cpp: (KJS::ReadModifyResolveNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
  • kjs/nodes.h:
10:28 PM Changeset in webkit [31630] by mitz@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/FontCacheWin.cpp

Forgot to save after the last change...

10:20 PM Changeset in webkit [31629] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::matchImprovingEnumProc):
10:08 PM Changeset in webkit [31628] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Fix PlatformGradient so that it's a pointer on all platforms.

9:47 PM Changeset in webkit [31627] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • 64-bit build fix
  • platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
9:34 PM Changeset in webkit [31626] by kevino@webkit.org
  • 1 edit
    1 add in trunk/WebCore

wx build fix. Add stubs for gradient class platform functions.

9:32 PM Changeset in webkit [31625] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

Refactor Gradient.h to have the same API on platforms without a gradient class.

9:13 PM Changeset in webkit [31624] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Qt build fix
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::Font):
9:07 PM Changeset in webkit [31623] by mitz@apple.com
  • 3 edits in trunk/WebCore
  • Tiger build fix
  • platform/mac/WebFontCache.mm:
  • rendering/RenderThemeMac.mm:
9:04 PM Changeset in webkit [31622] by mitz@apple.com
  • 4 edits in trunk/WebCore
  • Gtk build fix
  • platform/graphics/gtk/FontPlatformData.h: (WebCore::FontPlatformData::size):
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
8:51 PM Changeset in webkit [31621] by mitz@apple.com
  • 4 edits in trunk/WebCore
  • project file updates in preparation for build fixes
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
8:46 PM Changeset in webkit [31620] by mitz@apple.com
  • 29 edits
    1 add in trunk

WebCore:

2008-04-03 Nicholas Shanks <​webkit@nickshanks.com>

Updated by Dan Bernstein. Reviewed by Dave Hyatt.

Tests to come: <​http://bugs.webkit.org/show_bug.cgi?id=18306>

Build fixes for platforms other than Mac and Windows to come.

  • WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to return additional weight value keywords 100, 200, 300, 500, 600, 800 and 900.
  • css/CSSFontSelector.cpp: (WebCore::hashForFont): Changed the bold parameter into a weight parameter and added the weight to the string to be hashed. (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS weight values to the font description. (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to go through all weights equal or lighter from the desired weight. For SVG, to also consider heavier weights.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight property.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS weight values to the font description.
  • platform/graphics/Font.h: (WebCore::Font::weight): Updated for the change to FontDescription::weight().
  • platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced the bold component of the key with a weight component. (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above. (WebCore::computeHash): Ditto. (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed unnecessary parameters. (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto. (WebCore::FontCache::getCachedFontPlatformData): Updated for the change in FontPlatformDataCacheKey.
  • platform/graphics/FontDescription.cpp: Added. (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS font-weight value if there is one, or the lightest value. (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS font-weight value if there is one, or the heaviest value.
  • platform/graphics/FontDescription.h: (WebCore::FontWeight): Added this enumeration. (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::bold): Removed. (WebCore::FontDescription::weight): Changed to return a FontWeight. (WebCore::FontDescription::setBold): Removed. (WebCore::FontDescription::setWeight): Changed to take a FontWeight.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit font weight scale of 0-15. (WebCore::isAppKitFontWeightBold): Added. (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight instead of the bold trait for custom fonts, and to decide whether to synthesize bold based on the weights rather than the bold trait. (WebCore::FontCache::fontExists): Updated for the change in WebFontCache . (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to decide whether to synthesize bold based on the weights rather than on the bold trait.
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font weight constant. (WebCore::isGDIFontWeightBold): Added. (WebCore::adjustedGDIFontWeight): Added. (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this data structure for use by the following callback. (WebCore::matchImprovingEnumProc): Added. The logic of this method is a simplification of the betterChoice() predicate in WebFontCache.mm, which considers only the italic trait and the weight. (WebCore::createGDIFont): Added. Similarly to +[WebFontCache fontWithFamily:traits:weight:size:], this function finds the closest match in the family for the desired italic bit and weight. (WebCore::FontCache::fontExists): Changed to call createGDIFont(). (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to compute the synthetic bold and synthetic italic flags based on weights and italic bits and pass them to the FontPlatformData constructor.
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Changed the bold and oblique parameters to mean whether these should be synthesized and removed the font enumeration code that used to decide that.
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the synthetic bold and oblique flags from the full-size FontPlatformData to the FontPlatformData constructor for the small caps font.
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreFindFont): Added a weight parameter, which is passed to +[WebFontCache fontWithFamily:traits:weight:size:].
  • platform/mac/WebFontCache.h:
  • platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): Changed to ignore the bold trait. Changed the logic for deciding based on weights to prefer the font whose weight is closer to the desired one, or, if both candidates' weights are the same distance from the desired weight, the one that is more "off-center". (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to check for weight when matching by full name. Changed to pass the actual desired weight instead of the constant 5 to acceptableChoice() and betterChoice(). Changed to use weights to decide whether to synthesize bold. (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight parameter, which is passed to the internal method.
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Updated for the change to FontDescription.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Ditto. (WebCore::RenderListBox::paintItemForeground): Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::toFontWeight): Added. Maps the AppKit font weight range of 0-15 to the FontWeight range. (WebCore::RenderThemeMac::systemFont): Updated for the change to FontDescription.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::systemFont): Ditto.

WebKit/mac:

2008-04-03 Nicholas Shanks <​webkit@nickshanks.com>

Updated by Dan Bernstein. Reviewed by Dave Hyatt.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _styleFromFontAttributes:]): (-[WebHTMLView _originalFontB]): (-[WebHTMLView _addToStyle:fontA:fontB:]):

WebKit/win:

2008-04-03 Dan Bernstein <​mitz@apple.com>

Reviewed by Dave Hyatt.

  • DOMCoreClasses.cpp: (DOMElement::font): Updated for the change to FontDescription.
  • WebCoreSupport/WebDragClient.cpp: (dragLabelFont): Ditto.
  • WebKitGraphics.cpp: (makeFont): Ditto.
  • WebKitGraphics.h: Added a FIXME.
8:10 PM Changeset in webkit [31619] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • another Gtk build fix attempt
  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformDestroy):
7:25 PM Changeset in webkit [31618] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.18.1

Versioning.

7:18 PM Changeset in webkit [31617] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.18.1

New tag.

7:17 PM Changeset in webkit [31616] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

2008-04-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/5832603> REGRESSION: Adding an image to the header image well causes Journal page to incorrectly draw

  • dom/Document.cpp: (WebCore::Document::childrenChanged): Make sure to chain up to ContainerNode::childrenChanged.
7:05 PM Changeset in webkit [31615] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • attempted Gtk build fix
  • GNUmakefile.am:
6:02 PM Changeset in webkit [31614] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • attempted Qt build fix
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformDestroy):
5:43 PM Changeset in webkit [31613] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • attempted Gtk build fix
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke):
5:40 PM Changeset in webkit [31612] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • attempted Qt build fix
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke):
4:13 PM Changeset in webkit [31611] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

<rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created


Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
just setting a string.


Reviewed by Adam Roben.

  • WebView.cpp: (WebView::close): Add null check (found via code inspection). (WebView::initWithFrame): Store the group name directly in Page. (WebView::setGroupName): Store the group name directly in Page. (WebView::groupName): Retrieve the group name directly from Page.
  • WebView.h: Removed m_groupName
4:08 PM Changeset in webkit [31610] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-04-03 Beth Dakin <Beth Dakin>

Reviewed by Alice.

Build fix for non-Macs.

  • page/AXObjectCache.h: (WebCore::AXObjectCache::isIDinUse):
3:48 PM Changeset in webkit [31609] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-04-03 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Darin.

Correct build error due to incomplete merging of changes to project
files from Issue 17985. This small project file patch corrects
the build issue (see ​http://bugs.webkit.org/show_bug.cgi?id=18195).

  • WebCore.vcproj/WebCore.vcproj:
3:02 PM Changeset in webkit [31608] by Beth Dakin
  • 12 edits
    1 delete in trunk/WebCore

2008-04-02 Beth Dakin <Beth Dakin>

Reviewed by Hyatt.

This patch eliminates AccessibilityObjectMac. All of the platform-
specific code is now in AccessibilityObjectWrapper.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.h: (WebCore::Element::isPasswordField):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isPasswordField):
  • page/AXObjectCache.h: (WebCore::AXObjectCache::isIDinUse):
  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::press): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange): (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::areaElement): (WebCore::AccessibilityObject::setWrapper):
  • page/mac/AXObjectCacheMac.mm:
  • page/mac/AccessibilityObjectMac.mm: Removed.
  • page/mac/AccessibilityObjectWrapper.h:
  • page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper attachmentView]): (textMarkerForVisiblePosition): (visiblePositionForTextMarker): (visiblePositionForStartOfTextMarkerRange): (visiblePositionForEndOfTextMarkerRange): (textMarkerRangeFromMarkers): (AXAttributeStringSetFont): (CreateCGColorIfDifferent): (AXAttributeStringSetColor): (AXAttributeStringSetNumber): (AXAttributeStringSetStyle): (blockquoteLevel): (AXAttributeStringSetBlockquoteLevel): (AXAttributeStringSetSpelling): (AXAttributeStringSetHeadingLevel): (AXLinkElementForNode): (AXAttributeStringSetElement): (AXAttributedStringAppendText): (nsStringForReplacedNode): (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): (textMarkerRangeFromVisiblePositions): (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]): (-[AccessibilityObjectWrapper textMarkerRangeForSelection]): (-[AccessibilityObjectWrapper position]): (createAccessibilityRoleMap): (RoleEntry::): (roleValueToNSString): (-[AccessibilityObjectWrapper role]): (-[AccessibilityObjectWrapper subrole]): (-[AccessibilityObjectWrapper roleDescription]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityIsIgnored]): (-[AccessibilityObjectWrapper accessibilityPerformAction:]): (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]): (-[AccessibilityObjectWrapper doAXRTFForRange:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::viewRectToScreen): (WebCore::ScrollView::absolutePointToView):
2:57 PM Changeset in webkit [31607] by hyatt@apple.com
  • 10 edits
    5 adds in trunk/WebCore

2008-04-03 David Hyatt <​hyatt@apple.com>

Create a new cross-platform Gradient abstraction and make CanvasGradient wrap it. This first
step just cleans up CanvasGradient. The code that calls it remains ifdef'd however.

Reviewed by olliej

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS):
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
  • html/CanvasGradient.h: (WebCore::CanvasGradient::gradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::getColor):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
  • html/CanvasStyle.h: (WebCore::CanvasStyle::canvasGradient):
  • platform/graphics/Gradient.cpp: Added. (WebCore::Gradient::Gradient): (WebCore::Gradient::~Gradient): (WebCore::Gradient::addColorStop): (WebCore::compareStops): (WebCore::Gradient::getColor): (WebCore::Gradient::findStop):
  • platform/graphics/Gradient.h: Added. (WebCore::Gradient::ColorStop::ColorStop): (WebCore::Gradient::platformInit):
  • platform/graphics/cairo/GradientCairo.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
  • platform/graphics/cg/GradientCG.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::gradientCallback): (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GradientQt.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
2:47 PM Changeset in webkit [31606] by Simon Hausmann
  • 11 edits in trunk

Roll out r31599 and r31605 again after discussion with Mark Rowe.

2:25 PM Changeset in webkit [31605] by Simon Hausmann
  • 2 edits in trunk/WebKit/win

Attempted build fix

2:14 PM Changeset in webkit [31604] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-04-03 David Hyatt <​hyatt@apple.com>

Fix for bug 18194, resizable text fields get messed up when resizing in the presence of zoom.

Reviewed by adele

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
1:49 PM Changeset in webkit [31603] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

1:48 PM Changeset in webkit [31602] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.18

New tag.

1:47 PM Changeset in webkit [31601] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r31320.

1:30 PM Changeset in webkit [31600] by oliver@apple.com
  • 227 edits
    13 deletes in trunk

Rollout r31566 as there were a few issues i missed during review (thanks to antti for pointing them out)

1:17 PM Changeset in webkit [31599] by Simon Hausmann
  • 9 edits in trunk

2008-04-03 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Change IconDatabase::iconForPageURL to return more information. E.g. if an image has been found, or if the loading of an image has been scheduled.
  • Update FrameLoader to use another method to trigger reading from disk
  • Update the QWebFrame and QWebSettings
12:22 PM Changeset in webkit [31598] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Safari is using the IconDatabase the following way (assumption). Before they call iconDatabase()->open they "retain" all URLs they are interested in, these could come from the history.
  • When opening the iconDatabase() a thread will be started that is going to import the URLs, all none manually retained URLs are scheduled for removal. The removal is going to happen when the next icon gets stored in the database.
  • We do not have any IconDatabase code, we can not retain the URLs before opening the database. To disable the automatic pruning of the icons we will ask the IconDatabase to delay this operation. This means our IconDatabase, when used, will grow, so we should try to have a IconDatabase class in 4.4.
  • The only way to counter the growth is a call to QWebSettings::clearIconDatabase
12:01 PM Changeset in webkit [31597] by Simon Hausmann
  • 1 edit in trunk/WebKit/qt/Api/qwebsettings.cpp

Oops, fixed previous commit/merge error that caused build failure in Qt.

12:00 PM Changeset in webkit [31596] by adachan@apple.com
  • 8 edits in trunk/WebKit/win

Allow WebArchive to be created via COM.
Replaced IID_DOMNode with uuidof(DOMNode).

Reviewed by Adam and Steve.

  • DOMCoreClasses.cpp: (DOMNode::QueryInterface): (DOMNode::isSameNode):
  • DOMCoreClasses.h:
  • ForEachCoClass.h:
  • Interfaces/WebKit.idl:
  • WebArchive.cpp: (WebArchive::createInstance):
  • WebArchive.h:
  • WebKitClassFactory.cpp:
11:59 AM Changeset in webkit [31595] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Add a way to get the site icon for a url
static QPixmap iconForUrl(const QUrl &url);

11:46 AM Changeset in webkit [31594] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Update the Copyright info in QWebSettings
11:46 AM Changeset in webkit [31593] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • The isEmpty check is not needed anymore with the earlier backport
10:49 AM squirrelfish edited by ggaren@apple.com
(diff)
9:50 AM Changeset in webkit [31592] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2008-04-03 Brady Eidson <​beidson@apple.com>

Fix a tab into 4-spaces instead

  • webarchive/test-css-import-expected.txt:
9:20 AM Changeset in webkit [31591] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Mac build fix
  • WebCore.base.exp:
6:21 AM Changeset in webkit [31590] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the build when building without icondatabase.

5:27 AM Changeset in webkit [31589] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Remove the unused 'cache' parameter
5:04 AM Changeset in webkit [31588] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-03 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Add WebCore/loader/icon to the DEPENDPATH as well
4:40 AM Changeset in webkit [31587] by Simon Hausmann
  • 1 edit
    1 add in trunk/LayoutTests

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Add a Qt specific result for bad-scheme-subframe-expected.txt
  • To match the mac-port we would have to return IgnoreNavigationRequest for schemes/URLs not supported by the QNetworkAccessManager in QWebPage::navigationRequested but we can't do that because QNetworkAccessManager does not expose a list of supported schemes and operations. So in contrast to the mac we will try to load the frame and fail.
4:40 AM Changeset in webkit [31586] by Simon Hausmann
  • 1 edit
    4 adds in trunk/LayoutTests

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix http/tests/loading/simple-subframe.html by adding a test result. The result is quite similar to the one of the mac port.
3:31 AM Changeset in webkit [31585] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-04-03 Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

Reviewed by Simon.

  • Enable running http tests for Qt again. Failing tests can be put into the skipped list.
  • Running these tests on windows and other platforms might need some work.
3:31 AM Changeset in webkit [31584] by Simon Hausmann
  • 4 edits in trunk

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • For the http tests we need the output of the FrameLoaderClient. The QtWebKit API is not exporting enough to create the output in DRT itself. Settle with the approach Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
  • run-webkit-tests http/tests(/loading) can now be executed.
  • For tests in loading/ directories we are going to throw away the dirty QWebPage to start with something clean.
3:30 AM Changeset in webkit [31583] by Simon Hausmann
  • 3 edits in trunk/WebKitTools

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Treat http and https as special URLs as well. Change the main.cpp and DumpRenderTree.cpp to handle http and https URIs as input.
  • I'm not doing the clean up and merging of these two checks now.
3:30 AM Changeset in webkit [31582] by Simon Hausmann
  • 4 edits in trunk

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Remove dumpFrameLoadCallbacks from simple-subframe.html because it is located in a directory with the name "loading". And this will autoamtically enable dumping.
  • Remove this method from the LayoutTestController as it is unused now and this avoids adding it to the DRT of the Qt port.
Note: See TracTimeline for information about the timeline view.