Timeline
Apr 5, 2008:
- 11:50 PM squirrelfish edited by
- Remove InNode (diff)
- 11:50 PM Changeset in webkit [31669] by
-
- 1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog
Fix ChangeLog
- 11:48 PM Changeset in webkit [31668] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement codegen for ForInNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitIn):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::InNode::emitCode):
- kjs/nodes.h:
- 5:56 PM Changeset in webkit [31667] by
-
- 2 edits in trunk/WebKit/wx
Rubber stamped by Mark Rowe.
Don't assume wxWebKit to be part of the wx package. This allows us to run it from any directory on the PYTHONPATH rather than having to copy files into the wxPython directory.
- 5:38 PM Changeset in webkit [31666] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
Add CSS to the MIMETypeRegistry, which ensures CSS files get the right MIMEType when loaded from disk.
- 4:17 PM squirrelfish edited by
- DeleteNodes now work (diff)
- 3:58 PM Changeset in webkit [31665] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-05 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
- Implement codegen for DeleteResolveNode, DeleteBracketNode, DeleteDotNode and DeleteValueNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitGetPropId): (KJS::CodeGenerator::emitPutPropId): (KJS::CodeGenerator::emitDeletePropId): (KJS::CodeGenerator::emitDeletePropVal): (KJS::CodeGenerator::emitPutPropIndex):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::DeleteValueNode::emitCode):
- kjs/nodes.h:
- 1:43 PM Changeset in webkit [31664] by
-
- 4 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=17129
Incorrect style resolution in CSS styled SVG, with multiple style sheets
Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
attributes title and alternate are transferred to the stylesheet
created from the ProcessingInstruction.
- 9:05 AM Changeset in webkit [31663] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
Test: fast/repaint/table-two-pass-layout-overpaint.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Changed the first pass over the sections to only call calcRowHeight() and recalcOuterBorder() but not layoutRows(), because the section's final height is unknown yet. Removed caching of m_height before the call to calcHeight(), because for non-positioned tables, calcHeight() only calculates the vertical margins and does not change m_height. Added a second pass over the sections, after the table height is known, to call layoutRows() on each section, with additional height if needed. Did minimal cleanup including caching the value of collapseBorders() in a local variable and changing a while loop into a for loop.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): Changed to return the height of the section based on row height calculations. (WebCore::RenderTableSection::layoutRows): Removed a call to recalcOuterBorder(), which is now done by RenderTable::layout().
- rendering/RenderTableSection.h: Changed calcRowHeight() to have a return value.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
- fast/repaint/table-two-pass-layout-overpaint.html: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Added.
- 5:33 AM Changeset in webkit [31662] by
-
- 3 edits in trunk/WebCore
Simon Hausmann <shausman@trolltech.com>
Fixes: Disable "unimplemented" warnings when building WebKit inside Qt.
- 5:24 AM Changeset in webkit [31661] by
-
- 2 edits in trunk/WebKit/qt
Olivier Goffart <ogoffart@trolltech.com>
Fixes: Right clicking an image and choosing "copy image" doesnt put anything in the clipboard.
- 5:24 AM Changeset in webkit [31660] by
-
- 2 edits in trunk/WebKit/qt
Olivier Goffart <ogoffart@trolltech.com>
Fixes: Right click, and "Open image" open the link instead of the image.
- 5:23 AM Changeset in webkit [31659] by
-
- 2 edits in trunk/WebCore
Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger
Revert "* Load images incrementally. This will show warnings on the console"
This rolls out -r29739.
This unfortunately caused some crashes and drawing errors. Backing out for now.
- 5:01 AM QtWebKitContrib edited by
- (diff)
- 4:56 AM Changeset in webkit [31658] by
-
- 2 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Added doc stub for QWebSettings so class docs are generated
- 4:56 AM Changeset in webkit [31657] by
-
- 4 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Propose the addition of updateRequest and scrollRequest to the QWebPage.
- The question is if these signals belong to QWebPage or QWebFrame.
-It is more easy to have them in QWebPage because ScrollView is invoking
the ChromeClient with the right coordinates
-On the other hand someone wants to render frames separately. But this is partly
doomed as you can have overlapping frames and what you paint would not relate to
what you normally see on webpages.
Apr 4, 2008:
- 11:34 PM Changeset in webkit [31656] by
-
- 3 edits in trunk/WebKit/win
Only delete the backing store of background windows.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::WebView): (WebView::deleteBackingStore): (WebView::paint): Added active check. (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon): Added. (WebView::active): Added. (WebView::updateActiveState): Moved active check code from here to active().
- WebView.h:
- 10:50 PM Changeset in webkit [31655] by
-
- 2 edits in trunk/WebKit/win
Fix tooltip window leak.
Explicitly call DestroyWindow on the tooltip.
Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::~WebView):
- 10:17 PM Changeset in webkit [31654] by
-
- 2 edits in trunk/WebCore
Add GradientWx.cpp to the wx build process.
- 9:54 PM Changeset in webkit [31653] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- speed up CSSFontSelector::getFontData()
- css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Factored out of getFontData(). (WebCore::CSSFontSelector::getFontData): Changed to call fontDataForGenericFamily() directly if the map is empty.
- 9:02 PM Changeset in webkit [31652] by
-
- 5 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Oliver.
Replace AccessibilityObject::isRenderImage() with a virtual
RenderObject::isRenderImage().
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored): (WebCore::AccessibilityObject::addChildren):
- page/AccessibilityObject.h: (WebCore::AccessibilityObject::isDetached):
- rendering/RenderImage.h: (WebCore::RenderImage::isRenderImage):
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderImage):
- 7:14 PM Changeset in webkit [31651] by
-
- 3 edits in trunk/WebKit/win
Delete backing store after we go 5 seconds without a paint.
Timer will be reset if a paint occurs, so this won't negatively impact performance.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::paint): Call deleteBackingStoreSoon after paint. (WebViewWndProc): Add DeleteBackingStoreTimer. (WebView::deleteBackingStoreSoon): Added.
- WebView.h: Add deleteBackingStoreSoon.
- 5:13 PM Changeset in webkit [31650] by
-
- 2 edits in trunk/WebCore
- try to fix the wx build
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::fontWeightToWxFontWeight): (WebCore::FontPlatformData::FontPlatformData):
- 5:05 PM Changeset in webkit [31649] by
-
- 4 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Beth.
Some more clean-up of AccessibilityObject:
- Rearranged/grouped methods.
- Marked many methods const.
- Changed many methods to take args by const ref instead of by val.
- Made headingLevel() static.
- Renamed detached() to isDetached(), loaded() to isLoaded(), documentLinks to getDocumentLinks().
- Made clearChildren(), removeAXObjectID(), isDetached() private.
- Added notImplemented() calls for unimplemented methods.
- Replaced stringForReplacedNode method with static function.
- 3:32 PM squirrelfish edited by
- Remove some implemented Nodes from un-implemented opcode list (diff)
- 2:13 PM Changeset in webkit [31648] by
-
- 2 edits in trunk/WebCore
Restore the user entered text when clearing the auto-completion.
This is important when the user typed text that is a different
case than the completion. This has no affect on the Console, since
it matches completions case-sensitively. This is used in the up-coming
Database Query view for words like "SELECT" and "INSERT".
Reviewed by Adam Roben.
- page/inspector/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
text in the original DOM range that complete() saved away.
(WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
and it's text content so clearAutoComplete can restore it.
- 2:11 PM Changeset in webkit [31647] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-04-04 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
- Implement codegen for Switch statements.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::pushJumpContext): (KJS::CodeGenerator::popJumpContext): (KJS::CodeGenerator::jumpContextForLabel):
- VM/CodeGenerator.h: Rename LoopContext to JumpContext now that it used of Switch statements in addition to loops.
- kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::ContinueNode::emitCode): (KJS::BreakNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock): (KJS::SwitchNode::emitCode):
- kjs/nodes.h: (KJS::CaseClauseNode::expr): (KJS::CaseClauseNode::children): (KJS::CaseBlockNode::):
- 1:58 PM Changeset in webkit [31646] by
-
- 2 edits in trunk/WebCore
Don't trim whitespace when looking for the current match, this prevents tabbing through matches in the up-coming Database Query view.
Reviewed by Adam Roben.
- page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
- 1:50 PM Changeset in webkit [31645] by
-
- 5 edits1 add in trunk/WebCore
Factor out the Console text completion and command history into
a new TextPrompt object. This TextPrompt object will be used later
other parts of the Inspector that need text completion and history.
Not functionality changed, just moved code around.
Reviewed by Adam Roben.
- WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
- page/inspector/Console.js: Call the new prompt object and delete all the code that moved.
- page/inspector/TextPrompt.js: Added. Moved code from Console.js.
- page/inspector/WebKit.qrc: Add TextPrompt.js.
- page/inspector/inspector.html: Add TextPrompt.js.
- 1:29 PM Changeset in webkit [31644] by
-
- 2 edits in trunk/WebCore
Makes setting shouldRefreshChildren on a TreeElement perform the refresh
immediately if the element is already expanded.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js:
(TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
(TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
already expanded,
call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
(TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
(TreeElement.prototype.expand): Ditto.
- 1:21 PM ApplicationsGtk edited by
- Epiphany is now WebKit-only (diff)
- 1:17 PM Changeset in webkit [31643] by
-
- 3 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Beth.
Some clean up of AccessibilityObject:
- Use existing isImage() in more places.
- Use existing isTextControl() in more places.
- Added isRenderImage(). Check this before casting to RenderImage, since other, non-RenderImage derived RenderObjects (e.g. RenderListMarker) can return true for isImage().
- Fix two copy/paste errors with improper semicolons.
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isImageButton): Use isImage(). (WebCore::AccessibilityObject::isRenderImage): Added. (WebCore::AccessibilityObject::isAnchor): Use isImage(). (WebCore::AccessibilityObject::isAttachment): Same. (WebCore::AccessibilityObject::accessibilityDescription): Same. (WebCore::AccessibilityObject::accessibilityIsIgnored): Use isRenderImage() instead of isImage(). (WebCore::AccessibilityObject::url): Use isImage(). (WebCore::AccessibilityObject::textControl): Remove improper semicolon, and use isTextControl(). (WebCore::AccessibilityObject::textMarkerForIndex): Same. (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl(). (WebCore::AccessibilityObject::doAXRangeForLine): Same. (WebCore::AccessibilityObject::doAXRangeForIndex): Same (WebCore::AccessibilityObject::doAXStringForRange): Same. (WebCore::AccessibilityObject::roleValue): Use isImage(). (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
- page/AccessibilityObject.h:
- 1:13 PM Changeset in webkit [31642] by
-
- 2 edits in trunk/WebCore
Fixes a null exception when hovering in some areas of the DOM tree.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js:
(TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
before accessing any properties. Return null if listNode is null.
- 1:05 PM Changeset in webkit [31641] by
-
- 2 edits in trunk/WebCore
Changing WebInspector.currentFocusElement to/from an input element
does not change the actual focus of that input element. You see this
in the search field.
Reviewed by Adam Roben.
- page/inspector/inspector.js:
(WebInspector.set currentFocusElement): Call blur and focus if the
node implements them.
- 12:18 PM Changeset in webkit [31640] by
-
- 2 edits in trunk/WebCore
2008-04-04 David Hyatt <hyatt@apple.com>
Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
Treat them as having a background-size of 100%. This means their maximal size will be the box established
by background-origin.
Reviewed by Beth
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
- 12:16 PM Changeset in webkit [31639] by
-
- 5 edits in trunk/WebCore
Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
from view-source.css for the DOCTYPE in the DOM tree.
Reviewed by Adam Roben.
- css/view-source.css: Add and correct comments about keeping
in-sync with inspector.css.
- page/inspector/ElementsPanel.js:
(WebInspector.DocumentPanel.prototype.updateBreadcrumb):
Add a case for Node.DOCUMENT_TYPE_NODE.
- page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
- page/inspector/utilities.js:
(nodeTitleInfo): Use the webkit-html-doctype class for nodes
with Node.DOCUMENT_TYPE_NODE.
- 12:02 PM Changeset in webkit [31638] by
-
- 1 edit1 copy in trunk/WebCore
- try to fix the Tiger build
- icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
- 11:17 AM Changeset in webkit [31637] by
-
- 4 edits in trunk
Make WebKit use WebCore's copy of the ICU headers
WebCore:
Copy icu/ to PrivateHeaders for WebKit's benefit
Rubberstamped by Tim Hatcher.
- WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding Headers build phase to Copy Forwarding and ICU Headers, and added the icu/ directory to it.
WebKit/mac:
Use WebCore's ICU headers instead of our own copy
Rubberstamped by Tim Hatcher.
- Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's PrivateHeaders.
- 10:47 AM Changeset in webkit [31636] by
-
- 4 edits in trunk
Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies
WebCore:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
- WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy Forwarding Headers, that copies the ForwardingHeaders directory to WebCore's PrivateHeaders directory.
WebKit/mac:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
- Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in WebCore's PrivateHeaders instead of our own copy.
- 10:21 AM Changeset in webkit [31635] by
-
- 7 edits in trunk
WebCore:
Changed the signature of imageTitleForFilename so we can pass in the width
and height as integers.
Reviewed by Dan.
- page/mac/WebCoreViewFactory.h:
- platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle):
WebKit:
Updated the format string for window title for a standalone image to take integers.
Reviewed by Dan.
- English.lproj/Localizable.strings:
WebKit/mac:
Now we pass width and height directly as integers to format
the window title for a standalone image.
Reviewed by Dan.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:width:height:]):
- 8:57 AM Changeset in webkit [31634] by
-
- 3 edits in trunk/WebKit/win
<rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
Changed the format string to take in integers.
Reviewed by Dan.
- English.lproj/Localizable.strings: Updated.
- WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
- 12:54 AM squirrelfish edited by
- (diff)
- 12:52 AM QtWebKitContrib edited by
- (diff)
- 12:42 AM squirrelfish edited by
- (diff)
