⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 19, 2008:

11:59 PM Changeset in webkit [32278] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Mark Rowe.

Complete the Cairo (CSS) gradient implementation.

  • platform/graphics/Gradient.h:
  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::fill):
11:13 PM Changeset in webkit [32277] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Don't call emitCode directly on subnodes, instead use CodeGenerator::emitNode

Reviewed by Maciej

This patch just a preparation for tracking line numbers.

10:34 PM Changeset in webkit [32276] by alp@webkit.org
  • 6 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt.

Restore Cairo canvas support following the recent changes in
BitmapImage and ImageBuffer integrating canvas with CSS. Some
drawing regressions remain unfixed.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex):
9:26 PM Changeset in webkit [32275] by mitz@apple.com
  • 4 edits
    1 copy
    3 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/text/trailing-white-space-2.html

  • platform/text/BidiResolver.h: (WebCore::::moveRunToEnd): (WebCore::::moveRunToBeginning):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/text/trailing-white-space-2.html: Copied from LayoutTests/fast/text/trailing-white-space.html.
  • platform/mac/fast/text/trailing-white-space-2-expected.checksum: Added.
  • platform/mac/fast/text/trailing-white-space-2-expected.png: Added.
  • platform/mac/fast/text/trailing-white-space-2-expected.txt: Added.
7:27 PM Changeset in webkit [32274] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-04-19 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, Windows build fix - copy the profiler headers in all
configurations, not just Debug_Internal.

7:10 PM Changeset in webkit [32273] by mrowe@apple.com
  • 6 edits
    4 adds in tags/Safari-6526.1

Merge r31964.

7:10 PM Changeset in webkit [32272] by mrowe@apple.com
  • 2 edits in tags/Safari-6526.1/WebKit/mac

Merge r32023.

7:06 PM Changeset in webkit [32271] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

6:58 PM Changeset in webkit [32270] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.1

New tag.

3:34 PM Changeset in webkit [32269] by oliver@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

Bug 18619: Support continue, break, and return in try .. finally blocks
<​https://bugs.webkit.org/show_bug.cgi?id=18619>

Reviewed by Maciej

This patch replaces the current partial finally support (which uses code
duplication to achieve what it does) with a subroutine based approach.
This has a number of advantages over code duplication:

  • Reduced code size
  • Simplified exception handling as the finaliser code only exists in one place, so no "magic" is needed to get the correct handler for a finaliser.
  • When we support instruction to line number mapping we won't need to worry about the dramatic code movement caused by duplication

On the downside it is necessary to add two new opcodes, op_jsr and op_sret
to enter and exit the finaliser subroutines, happily SunSpider reports
a performance progression (gcc amazes me) and ubench reports a wash.

While jsr and sret provide a mechanism that allows us to enter and exit
any arbitrary finaliser we need to, it was still necessary to increase
the amount of information tracked when entering and exiting both finaliser
scopes and dynamic scopes ("with"). This means "scopeDepth" is now
the combination of "finaliserDepth" and "dynamicScopeDepth". We also
now use a scopeContextStack to ensure that we pop scopes and execute
finalisers in the correct order. This increases the cost of "with" nodes
during codegen, but it should not be significant enough to effect real
world performance and greatly simplifies codegen for return, break and
continue when interacting with finalisers.

2:11 PM Changeset in webkit [32268] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Maciej.

Enable visited link tracking by default at startup.

With this patch, the GTK+ port rendering of Acid3 now matches the
reference page.

  • webkit/webkitprivate.cpp: (WebKit::core): (webkit_init):
1:34 PM Changeset in webkit [32267] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-04-19 Julien Chaffraix <​jchaffraix@webkit.org>

Qt build fix (renderer() -> contentRenderer()).

  • Api/qwebframe.cpp: (QWebFrame::renderTreeDump): (QWebFrame::render):
9:00 AM Changeset in webkit [32266] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2008-04-19 Brady Eidson <​beidson@apple.com>

Update window-properties to add the profiler and fix a layout test

  • fast/dom/Window/window-properties-expected.txt:
9:00 AM Changeset in webkit [32265] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. renderer() -> contentRenderer()

2:39 AM Changeset in webkit [32264] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-19 Alp Toker <​alp@nuanti.com>

Reviewed by Nikolas.

Add text shadow support for simple text in FontCairo.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
2:21 AM Changeset in webkit [32263] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-04-19 David Hyatt <​hyatt@apple.com>

Fix a minor typo in CSSGradientValue's cssText() method.

Reviewed by olliej

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::cssText):
12:56 AM Changeset in webkit [32262] by alp@webkit.org
  • 4 edits in trunk

2008-04-19 Mike Hommey <​glandium@debian.org>

Reviewed by Alp Toker.

Don't build GtkLauncher and DumpRenderTree with rpath.

Don't build testkjs with rpath.

12:26 AM Changeset in webkit [32261] by beidson@apple.com
  • 9 edits in trunk

WebCore:

2008-04-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Add LocalStorageDatabasePath to the settings for the location of persistent local storage.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setLocalStorageDatabasePath):
  • page/Settings.h: (WebCore::Settings::localStorageDatabasePath):

WebKit/mac:

2008-04-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Add a WebPreference for the path of the local storage persistent store.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (-[WebPreferences _localStorageDatabasePath]): (-[WebPreferences _setLocalStorageDatabasePath:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

Apr 18, 2008:

10:46 PM Changeset in webkit [32260] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Fix build after r32231.

  • WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation): renderer() -> contentRenderer()
10:39 PM Changeset in webkit [32259] by kevino@webkit.org
  • 7 edits
    1 move in trunk/JavaScriptCore

wx build fixes. Rename LocalStorage.h to LocalStorageEntry.h to avoid header detection issues between WebCore/storage/LocalStorage.h and it, and add $(PROFILER_SOURCES) to the wx JSCore build.

10:19 PM Changeset in webkit [32258] by alp@webkit.org
  • 4 edits in trunk

Fix changelog entries for r32257 (reference to wrong bug).
This commit was unrelated to plugin support.

10:16 PM Changeset in webkit [32257] by alp@webkit.org
  • 8 edits in trunk

2008-04-18 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=14750
[gtk] Implement plugin support in GTK backend

Cleanups.

10:08 PM Changeset in webkit [32256] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Fix build after r32231.

  • WebView.cpp: (WebView::paintIntoBackingStore): renderer() -> contentRenderer() (WebView::elementAtPoint): Same.
10:02 PM Changeset in webkit [32255] by jhoneycutt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Windows build fix.
9:01 PM Changeset in webkit [32254] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

  • AccessibleBase.cpp: Build fix for copy/paste error.
8:54 PM Changeset in webkit [32253] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement IAccessible::get_accChild().

  • AccessibleBase.cpp: (AccessibleBase::get_accChild): Call getAccessibilityObjectForChild to find the AccessibilityObject for the VARIANT vChild. Get the AccessibilityObjectWrapper for the child, add a ref, and pass it back. (AccessibleBase::getAccessibilityObjectForChild): Added; finds the AccessibilityObject referred to by a VARIANT, or returns a COM error on failure. (AccessibleBase::wrapper): Added; returns the wrapper for the AccessibilityObject. Creates one if necessary.
  • AccessibleBase.h: Added definitions for wrapper() and getAccessibilityObjectForChild().
8:53 PM Changeset in webkit [32252] by jhoneycutt@apple.com
  • 6 edits in trunk

2008-04-18 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin, Ollie.

  • AccessibleBase.cpp: (AccessibleBase::get_accChildCount): Implement get_accChildCount.
8:53 PM Changeset in webkit [32251] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Implement IAccessible::get_accParent().

  • AccessibleBase.cpp: (AccessibleBase::get_accParent): Call AccessibleObjectFromWindow with OBJID_WINDOW. This will be handled by Windows to return the default accessible object for the WebView, because we only handle OBJID_CLIENT.
  • WebView.cpp: (WebView::AccessibleObjectFromWindow): Added; calls through to the AccessibleObjectFromWindow in the MSAA DLL.
  • WebView.h: Added definition for AccessibleObjectFromWindow.
8:52 PM Changeset in webkit [32250] by jhoneycutt@apple.com
  • 4 edits
    2 adds in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Return an AccessibleDocument when our root accessible object is queried
for.

  • AccessibleDocument.cpp: Added; represents an AccessibilityObject that itself represents a Document. (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with the AccessibilityObject for this Document.
  • AccessibleDocument.h: Added.
  • WebFrame.cpp: (WebFrame::accessible): If m_accessible is 0, or if Document in this frame does not match the Document in the cached m_accessible object, create a new AccessibleDocument for this frame's Document.
  • WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
  • WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}
8:52 PM Changeset in webkit [32249] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin, Alice.

Implement AXObjectCache::detachWrapper() on Windows.

  • page/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::detachWrapper): If this object has a wrapper, call its detach() method.
8:51 PM Changeset in webkit [32248] by jhoneycutt@apple.com
  • 5 edits in trunk/WebKit/win

2008-04-17 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

Respond to WM_GETOBJECT messages. Currently returns NULL.

  • WebFrame.cpp: (WebFrame::accessible): Added; will return the root accessible object for this frame.
  • WebFrame.h: Added definition for accessible().
  • WebView.cpp: (WebViewWndProc): Handle WM_GETOBJECT messages by calling onGetObject(). (WebView::onGetObject): Added; enables the AXObjectCache in WebCore, queries the top-level frame for its root accessible object, and loads the MSAA DLL and locates its LresultFromObject function. If calling LresultFromObject succeeds, it returns a reference to the accessible object to pass back to Windows. If not, we return false and let Windows handle the request through DefWindowProc.
  • WebView.h: Added definition for onGetObject().
8:37 PM Changeset in webkit [32247] by Antti Koivisto
  • 5 edits in trunk/LayoutTests

2008-04-18 Antti Koivisto <Antti Koivisto>

Update test results.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
8:32 PM Changeset in webkit [32246] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-18 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=18357
[GTK] Enter on buttons doesn't work

  • platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString): Set the text of a keyboard event for GDK_ISO_Enter, GDK_KP_Enter, GDK_Return to "\r" instead of an empty string.
8:29 PM Changeset in webkit [32245] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-18 Marco Barisione <​marco@barisione.org>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=18576
[GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and
GDK_KP_Enter

  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent.
7:58 PM SuccessfulPortHowTo created by ddkilzer@webkit.org
7:50 PM Changeset in webkit [32244] by mrowe@apple.com
  • 2 edits
    1 move
    1 add in trunk/WebCore

Gtk build fix.

7:34 PM WikiStart edited by ddkilzer@webkit.org
Added link to Successful Port How To page. (diff)
6:34 PM Changeset in webkit [32243] by Antti Koivisto
  • 5 edits in trunk/WebCore

2008-04-18 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Implement path animation for <animateMotion>.


SVG test suite tests
animate-elem-07-t.svg
animate-elem-08-t.svg
animate-elem-24-t.svg
animate-elem-30-t.svg

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::rotateMode): (WebCore::SVGAnimateMotionElement::animationPath): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGAnimateMotionElement.h: (WebCore::SVGAnimateMotionElement::):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::animationMode): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::): (WebCore::SVGAnimationElement::calculateDistance): (WebCore::SVGAnimationElement::animationPath):
6:31 PM Changeset in webkit [32242] by mrowe@apple.com
  • 9 edits in trunk

Silence some warnings that GCC 4.3 triggers.

Rubber-stamped by Antti Koivisto.

6:12 PM Changeset in webkit [32241] by beidson@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
No reason to do the work twice...

  • WebView/WebView.mm: (-[WebView _close]):

WebKit/win:

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
No reason to do the work twice...

  • WebView.cpp: (WebView::close):
6:01 PM Changeset in webkit [32240] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

Gtk build fix after r32231.

5:15 PM Changeset in webkit [32239] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-04-18 Brady Eidson <​beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out ​http://trac.webkit.org/projects/webkit/changeset/32204 as it was an incorrect build fix.
The feature in question was NOT database support.

The proper build fix was later applied by Mark in ​http://trac.webkit.org/projects/webkit/changeset/32225

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
4:58 PM Changeset in webkit [32238] by weinig@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2008-04-18 Sam Weinig <​sam@webkit.org>

Disable this test until we can figure out why it is failing on some systems.

  • fast/canvas/toDataURL-supportedTypes.html: Removed.
  • fast/canvas/toDataURL-supportedTypes.html-disabled: Copied from fast/canvas/toDataURL-supportedTypes.html.
4:56 PM Changeset in webkit [32237] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-04-18 Brady Eidson <​beidson@apple.com>

Reviewed by Darin and Sam

Don't forget PageGroups when their last Page goes away, as this hurts visited links and anything
else that will be per-PageGroup in the future (such as LocalStorage).

This also fixes a leak, since PageGroups are ref-counted and therefore clearing the raw pointer out
of the PageGroups map without manual deletion leaked it!

  • page/Page.cpp: (WebCore::Page::setGroupName):
4:19 PM Changeset in webkit [32236] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Brady Eidson.

  • fix <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page

Test: fast/dynamic/5872671.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added a missing null check.

LayoutTests:

Reviewed by Brady Eidson.

  • test for <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page
  • fast/dynamic/5872671-expected.txt: Added.
  • fast/dynamic/5872671.html: Added.
3:58 PM Changeset in webkit [32235] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-04-18 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

responseText and responseXML don't throw exceptions so they don't need an ExceptionCode parameter.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:
3:41 PM Changeset in webkit [32234] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Use Deque instead of Vector since the profiler uses prepend a lot and deque is faster at that.
  • profiler/FunctionCallProfile.h: (KJS::FunctionCallProfile::milliSecs): Corrected the name to match its output.
  • wtf/Deque.h: (WTF::deleteAllValues):
3:17 PM Changeset in webkit [32233] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

  • Build fix.
  • page/Console.cpp: (WebCore::Console::profile):
  • page/Console.h:
  • page/Console.idl:
2:59 PM Changeset in webkit [32232] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by darin.

Fix probable crasher caused by invalid static_cast
​https://bugs.webkit.org/show_bug.cgi?id=18585

  • page/Frame.cpp: (WebCore::Frame::contentRenderer): (WebCore::Frame::ownerRenderer):
  • rendering/RenderObject.h: sort the "is*" functions (WebCore::RenderObject::isApplet): (WebCore::RenderObject::isBR): (WebCore::RenderObject::isBlockFlow): (WebCore::RenderObject::isCounter): (WebCore::RenderObject::isFrame): (WebCore::RenderObject::isFrameSet): (WebCore::RenderObject::isImage): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isInlineFlow): (WebCore::RenderObject::isListBox): (WebCore::RenderObject::isListItem): (WebCore::RenderObject::isListMarker): (WebCore::RenderObject::isMedia): (WebCore::RenderObject::isMenuList): (WebCore::RenderObject::isRenderBlock): (WebCore::RenderObject::isRenderImage): (WebCore::RenderObject::isRenderInline): (WebCore::RenderObject::isRenderPart): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::isSlider): (WebCore::RenderObject::isTable): (WebCore::RenderObject::isTableCell): (WebCore::RenderObject::isTableCol): (WebCore::RenderObject::isTableRow): (WebCore::RenderObject::isTableSection): (WebCore::RenderObject::isTextArea):
  • rendering/RenderPart.h:
2:59 PM Changeset in webkit [32231] by eric@webkit.org
  • 14 edits in trunk

Reviewed by beth.

Rename Frame::renderer() to contentRenderer() and fix uses.

  • WebCore.base.exp:
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
  • page/DragController.cpp: (WebCore::DragController::canProcessDrag): (WebCore::DragController::mayStartDragAtEventLocation): (WebCore::DragController::startDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::contentRenderer): (WebCore::Frame::paint): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout): (WebCore::FrameView::updateControlTints):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
2:56 PM Changeset in webkit [32230] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-04-18 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

​https://bugs.webkit.org/show_bug.cgi?id=18551
REGRESSION (r31801?): Crash in ContainerNode::removedFromDocument on many SVG tests


Fix for test svg/W3C-SVG-1.1/animate-elem-62-t.svg which was still
crashing under guard malloc after the previous fix.


If the event base element was a parent of the current element, dereffing it during
removedFromDocument() would cause problems. Avoid this by not holding ref pointer
to the event base but instead checking from the ref count of the event listener whether
it is still alive and in need for unregistering.


This shold not be a problem for syncbase pointers since those are always animation elements
and leaf nodes.

  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::unregister): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions): (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
  • svg/animation/SVGSMILElement.h:
2:50 PM Changeset in webkit [32229] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk/WebCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam and Adam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Added support for console.profile() and console.profileEnd().
  • ForwardingHeaders/kjs/FunctionCallProfile.h: Added.
  • ForwardingHeaders/kjs/Profiler.h: Added.
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h:
  • page/Console.idl:
2:49 PM Changeset in webkit [32228] by kmccullough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-04-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam and Adam.

-<rdar://problem/5770054> JavaScript profiler (10928)

  • Cleaned up the header file and made some functions static, added a new, sane, printing function, and fixed a few minor bugs.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::didExecute): Removed assertion that time is

    0 because at ms resolution that may not be true and only cross-

    platform way to get time differences is in ms. (KJS::FunctionCallProfile::printDataInspectorStyle): Added a new printing function for dumping data in a sane style. (KJS::FunctionCallProfile::printDataSampleStyle): Fixed a bug where we displayed too much precision when printing our floats. Also added logic to make sure we don't display 0 because that doesn't make sense for a sampling profile.
  • profiler/FunctionCallProfile.h:
  • profiler/Profiler.cpp: Moved functions that could be static into the implementation, and chaned the ASSERTs to early returns. I did this because console.profile() is a JS function and so was being profiled but asserting because the profiler had not been started! In the future I would like to put the ASSERTs back and not profile the calls to console.profile() and console.profileEnd(). (KJS::Profiler::willExecute): (KJS::Profiler::didExecute): (KJS::getStackNames): Fixed a bug where the wrong ExecState was being used. (KJS::getFunctionName): (KJS::Profiler::printDataInspectorStyle):
  • profiler/Profiler.h:
2:25 PM Changeset in webkit [32227] by kevino@webkit.org
  • 4 edits in trunk

wx build 'fix'. Add loader/appcache sources to the build, and define ENABLE_DOM_STORAGE.

2:18 PM Changeset in webkit [32226] by mitz@apple.com
  • 46 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/text/trailing-white-space.html

Made trailing white space on the line always behave like it has the base
bidi level of the block, meaning it will always go on the right (left)
of the line in a left-to-right (right-to-left) block. Made the trailing
white space vanish when it is next to a margin that the text should
be touching, and made its width not count when computing the center
point for center alignment.

  • platform/text/BidiResolver.h: (WebCore::::prependRun): Added.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed the logicallyLastRun parameter to an optional trailingSpaceRun and changed the alignment logic to implement the above rules. (WebCore::RenderBlock::layoutInlineChildren): Added code to identify when there is trailing white space that needs to be split into its own run and optionally re-ordered. (WebCore::RenderBlock::findNextLineBreak): Removed code that split some trailing space into a separate run in one special case.

LayoutTests:

Reviewed by Darin Adler.

  • fast/text/trailing-white-space.html: Added.
  • http/tests/misc/acid3-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/editing/execCommand/5482023-expected.txt:
  • platform/mac/editing/execCommand/boldSelection-expected.txt:
  • platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
  • platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • platform/mac/editing/execCommand/print-expected.txt:
  • platform/mac/editing/execCommand/selectAll-expected.txt:
  • platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/insert-div-027-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/mac/editing/selection/5081257-1-expected.txt:
  • platform/mac/editing/selection/after-line-wrap-expected.txt:
  • platform/mac/editing/selection/mixed-editability-1-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/create-block-for-style-012-expected.checksum:
  • platform/mac/editing/style/create-block-for-style-012-expected.png:
  • platform/mac/editing/style/create-block-for-style-012-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
  • platform/mac/fast/text/justified-text-rect-expected.txt:
  • platform/mac/fast/text/trailing-white-space-expected.checksum: Added.
  • platform/mac/fast/text/trailing-white-space-expected.png: Added.
  • platform/mac/fast/text/trailing-white-space-expected.txt: Added.
  • platform/mac/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
1:54 PM Changeset in webkit [32225] by mrowe@apple.com
  • 5 edits in trunk/WebCore

Fix builds that do not have DOM storage enabled.

1:33 PM Changeset in webkit [32224] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the regression where style rules in the Inspector always show "inline stylesheet"
for the source of the rule and not the URL or other sources.

​https://bugs.webkit.org/show_bug.cgi?id=18592

Reviewed by Dan Bernstein.

  • page/inspector/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update): Add parentStyleSheet to the anonymous obejct
that we make for each matched rule. The parentStyleSheet property is used later to make the subtitle.

1:14 PM Changeset in webkit [32223] by dino@apple.com
  • 4 edits in trunk/WebCore

Fixed marquee suspension on wrong document. Passes current
document into Frame::clearTimers.

Reviewed by hyatt.

  • history/CachedPage.cpp:

(WebCore::CachedPage::clear):

  • page/Frame.cpp:

(WebCore::Frame::clearTimers):

  • page/Frame.h:
12:46 PM Changeset in webkit [32222] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix leaks during plugin tests (which actually excercise background JS), and potential
PAC brokenness that was not reported, but very likely.

The leaks shadowed a bigger problem with Identifier destruction. Identifier::remove involves
an IdentifierTable lookup, which is now a per-thread instance. Since garbage collection can
currently happen on a different thread than allocation, a wrong table was used.

No measurable change on SunSpider total, ~1% variation on individual tests.

  • kjs/ustring.cpp: (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy):
  • kjs/ustring.h: Replaced isIdentifier with a pointer to IdentifierTable, so that destruction can be done correctly. Took one bit from reportedCost, to avoid making UString::Rep larger (performance effect was measurable on SunSpider).
  • kjs/identifier.cpp: (KJS::IdentifierTable::IdentifierTable): (KJS::IdentifierTable::~IdentifierTable): (KJS::IdentifierTable::add): (KJS::IdentifierTable::remove): Make IdentifierTable a real class. Its destructor needs to zero out outstanding references, because some identifiers may briefly outlive it during thread destruction, and we don't want them to use their stale pointers.

(KJS::LiteralIdentifierTable):
(KJS::Identifier::add):
Now that LiteralIdentifierTable is per-thread and can be destroyed not just during application
shutdown, it is not appropriate to simply bump refcount for strings that get there; changed
the table to hold RefPtrs.

(KJS::CStringTranslator::translate):
(KJS::UCharBufferTranslator::translate):
(KJS::Identifier::addSlowCase):
(KJS::Identifier::remove):

  • kjs/identifier.h: (KJS::Identifier::add): Use and update UString::Rep::identifierTable as appropriate. Updating it is now done in IdentifierTable::add, not in translators.
12:45 PM Changeset in webkit [32221] by dino@apple.com
  • 4 edits in trunk/WebCore

Add 'ease' timing function to transitions and
make it the default. See latest specification proposal at:
​http://webkit.org/specs/CSSVisualEffects/CSSTransitions.html

Reviewed by hyatt.

NOTE: still working on a way to test animating/transitioning content

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransitionTimingFunction):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapTransitionTimingFunction):

  • css/CSSValueKeywords.in:
12:02 PM Changeset in webkit [32220] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Get rid of static compareWithCompareFunctionArguments in array_instance.cpp.

No change on SunSpider, CelticKane or iBench JavaScript. It is probable that in some cases,
merge sort is still faster, but more investigation is needed to determine a new cutoff.
Or possibly, it would be better to do what FIXME says (change to tree sort).

Also, made arguments a local variable - not sure why it was a member of
CompareWithCompareFunctionArguments.

  • kjs/array_instance.cpp: (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (KJS::CompareWithCompareFunctionArguments::operator()): (KJS::ArrayInstance::sort):
11:03 AM Changeset in webkit [32219] by Adam Roben
  • 10 edits in trunk

Change JavaScriptDebugListener to use KJS::UString instead of WebCore::String

WebCore:

Change JavaScriptDebugListener to use KJS::UString instead of
WebCore::String

This should reduce the number of string allocations performed while
debugging.

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: Updated JavaScriptDebugListener functions.
  • page/InspectorController.h: Ditto.
  • page/JavaScriptDebugListener.h: Changed to use KJS::UString instead of WebCore::String.
  • page/JavaScriptDebugServer.cpp: Ditto.
  • platform/win/BString.cpp: (WebCore::BString::BString): Added a constructor that takes a KJS::UString.
  • platform/win/BString.h:

WebKit/win:

Update WebScriptDebugServer for JavaScriptDebugListener changes

Reviewed by Tim Hatcher.

  • WebScriptDebugServer.cpp: Changed to use KJS::UString instead of WebCore::String.
  • WebScriptDebugServer.h: Ditto.
10:27 AM Changeset in webkit [32218] by Adam Roben
  • 2 edits in trunk/WebCore

Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Mark JavaScriptDebugListener.h private.
9:32 AM Changeset in webkit [32217] by Adam Roben
  • 3 edits in trunk/WebCore

Make InspectorController a JavaScriptDebugListener

I added two new functions to the InspectorController JS object:
reloadInspectedPageAndStartDebugging and stopDebugging. These control
when the InspectorController adds/removes itself to/from the
JavaScriptDebugServer.

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::reloadInspectedPageAndStartDebugging): Added. Just calls through to InspectorController. (WebCore::stopDebugging): Ditto. (WebCore::InspectorController::~InspectorController): Make sure we stop debugging before we are destroyed so the JavaScriptDebugServer won't be left with a stale pointer. (WebCore::InspectorController::windowScriptObjectAvailable): Added two new functions to our JS object. (WebCore::InspectorController::closeWindow): Stop debugging when the window closes. (WebCore::InspectorController::reloadInspectedPageAndStartDebugging): Added. (WebCore::InspectorController::stopDebugging): Added.

(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
(WebCore::InspectorController::didEnterCallFrame):
(WebCore::InspectorController::willExecuteStatement):
(WebCore::InspectorController::willLeaveCallFrame):
Added empty implementations of the JavaScriptDebugListener functions.

  • page/InspectorController.h:
9:01 AM Changeset in webkit [32216] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • add css2.1/t1506-c525-font-wt-00-b.html to the Windows skipped list
  • platform/win/Skipped:
8:43 AM Changeset in webkit [32215] by Adam Roben
  • 2 edits in trunk/WebCore

Rename ExecState* instances from state to exec

Requested by Darin Adler and Sam Weinig.

  • bindings/js/JSConsoleCustom.cpp:
8:41 AM Changeset in webkit [32214] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added another failing test.
8:38 AM Changeset in webkit [32213] by Adam Roben
  • 2 edits in trunk/WebCore

Clean up InspectorController's use of JSStringRef

All JSStringRef creation now happens through a helper function,
jsStringRef, which takes either a const char* or a const String& and
returns a JSRetainPtr<JSStringRef>.

Reviewed by Mitz Pettel.

  • page/InspectorController.cpp: Added jsStringRef and converted all callers to JSStringCreateWithUTF8CString or JSStringCreateWithCharacters to use it.
8:34 AM Changeset in webkit [32212] by Adam Roben
  • 2 edits in trunk/WebKitTools

Drop the hang timer to 30 seconds

This matches what DRT/mac was using.

Reviewed by Mitz Pettel.

  • Scripts/run-webkit-tests:
8:33 AM Changeset in webkit [32211] by Adam Roben
  • 4 edits
    4 deletes in trunk/WebKitTools

Get rid of DRT's Watchdog

run-webkit-tests now detects hangs and samples DRT as needed.

Reviewed by Mitz Pettel.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed Watchdog* files from the project.
  • DumpRenderTree/Watchdog.cpp: Removed.
  • DumpRenderTree/Watchdog.h: Removed.
  • DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog (dumpRenderTree): (runTest):
  • DumpRenderTree/mac/WatchdogMac.h: Removed.
  • DumpRenderTree/mac/WatchdogMac.mm: Removed.
  • Scripts/run-webkit-tests: (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out. (sub sampleDumpTool): Added. Writes a sample report to ~/Library/Logs/DumpRenderTree/HangReport.txt.
8:19 AM Changeset in webkit [32210] by Adam Roben
  • 3 edits in trunk/WebCore

Add wrappers around InspectorClient::{show,close}Window

This will let us perform actions when the window is actually
showing/closing (InspectorController::show doesn't always directly
show the window).

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): Call showWindow() instead of m_client->showWindow(). (WebCore::InspectorController::show): Ditto. (WebCore::InspectorController::close): Ditto for closeWindow(). (WebCore::InspectorController::showWindow): (WebCore::InspectorController::closeWindow):
  • page/InspectorController.h:
7:53 AM Changeset in webkit [32209] by Simon Hausmann
  • 22 edits in trunk

Many API changes and additions after a full review with Jasmin Blanchette <​jasmin@trolltech.com>

The diff is too big to mention the changes individually, but most of the changes were of cosmetic
nature where methods or enums have been renamed or prefixed/suffixed according to the consistency
rules of the Qt API.

7:37 AM Changeset in webkit [32208] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-18 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=18477

No resize indication is shown when moving/hovering over the frame
border/splitter.

7:32 AM Changeset in webkit [32207] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Added QWebView::find/QWebFrame::find.

7:07 AM Changeset in webkit [32206] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

Same as before, but for fabs/fabsf.

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateDistance): Changed to use fabsf and removed narrowPrecisionToFloat.
6:57 AM Changeset in webkit [32205] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

In MSVC, sqrt() has three overloads: float, double, and long
double. In GCC, sqrt() is only for doubles. Both MSVC and GCC have
sqrtf() to operate explicitly on floats.

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::calculateDistance): Changed to use sqrtf and removed narrowPrecisionToFloat.
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateDistance): Ditto.
5:47 AM Changeset in webkit [32204] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the build without Database support (fixes the Qt/win build).

4:13 AM Changeset in webkit [32203] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-04-18 Alp Toker <​alp@atoker.com>

Rubber-stamped by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=18218
[Gtk] segfault when clicking on a disabled button

Always use the main frame for mouse events (not the focused frame)
since it knows best how to get the event through to the right target.

This also fixes a null crasher.

  • webkit/webkitwebview.cpp:
4:03 AM Changeset in webkit [32202] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Gtk build on the build bot.

3:44 AM Changeset in webkit [32201] by Simon Hausmann
  • 2 edits in trunk/WebCore

Prospective wx build fix.

3:40 AM Changeset in webkit [32200] by Simon Hausmann
  • 2 edits in trunk/WebCore

Build fix. Back out previous #include fix for PageGroup.h as it broke
the Mac build due to forwarding headers.

3:00 AM Changeset in webkit [32199] by Simon Hausmann
  • 3 edits in trunk/WebCore

Build fix for Qt and gcc 4.3.

2:31 AM Changeset in webkit [32198] by Simon Hausmann
  • 6 edits in trunk

Build fix for gcc 4.3 and Gtk.

12:40 AM Changeset in webkit [32197] by Antti Koivisto
  • 7 edits in trunk/WebCore

2008-04-17 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.


​https://bugs.webkit.org/show_bug.cgi?id=18573

Implement supplemental transforms and use them for <animateMotion> instead of the transform list.
This will allow <animateTransform> and <animateMotion> combine properly.

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGElement.h: (WebCore::SVGElement::supplementalTransform):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::supplementalTransform):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::supplementalTransform):
Note: See TracTimeline for information about the timeline view.