Context Navigation

These tests were passing incorrectly. testkjs creates a global array
named "arguments" to hold command-line arguments. That array was
tricking these tests into thinking that an arguments object with length
0 had been created. Since our new vanilla object shadows the global
property named arguments, that object no longer fools these tests into
passing.

Net change: +1 failing test.

kjs/AllInOneFile.cpp: Had to put JSActivation.cpp into AllInOneFile.cpp to solve a surprising 8.6% regression in bitops-3bit-bits-in-byte.

9:29 PM Changeset in webkit [32456] by mitz@apple.com

4 edits in trunk/LayoutTests

Rubber-stamped by Dave Hyatt.

update computed style results for border-image and mask-image

fast/css/computed-style-expected.txt:
fast/css/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

8:55 PM Changeset in webkit [32455] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Reviewed by Alp Toker.

Typo fix to restore text entry.

8:39 PM Changeset in webkit [32454] by beidson@apple.com

3 edits in trunk/WebCore

2008-04-23 Brady Eidson <beidson@apple.com>

Reviewed by Jon Honeycutt

Preparing for making LocalStorageAreas persistent.

Since LocalStorageAreas will need to do a lot of additional work for each of the basic
operations a Storage object supports, this patch makes the API entry points virtual so
LocalStorageArea can override them. The behavior for both Local and Session StorageAreas
is unchanged with this patch, but LocalStorageArea will override them in the future.

storage/StorageArea.cpp: Rename the implementations to internalFoo (WebCore::StorageArea::internalLength): (WebCore::StorageArea::internalKey): (WebCore::StorageArea::internalGetItem): (WebCore::StorageArea::internalSetItem): (WebCore::StorageArea::internalRemoveItem): (WebCore::StorageArea::internalContains):

storage/StorageArea.h: Call internalFoo variants (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::contains):

8:38 PM Changeset in webkit [32453] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

save and restore callFrame

VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::execute): (KJS::Machine::privateExecute):
kjs/testkjs.cpp: (main):

8:12 PM Changeset in webkit [32452] by hyatt@apple.com

3 edits
2 adds in trunk

WebCore:

2008-04-23 David Hyatt <hyatt@apple.com>

Implement getComputedStyle for border-image.

Reviewed by Dan Bernstein

Added fast/css/getComputedStyle-border-image.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForRepeatRule): (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

2008-04-23 David Hyatt <hyatt@apple.com>

Implement getComputedStyle for -webkit-border-image.

Reviewed by Dan Bernstein

fast/css/getComputedStyle-border-image-expected.txt: Added.
fast/css/getComputedStyle-border-image.html: Added.

3:55 PM Changeset in webkit [32451] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed scopes for named function expressions.

Fixes one regression test.

Two changes here:

(1) The function's name is supposed to have attributes DontDelete,
ReadOnly, regardless of the type of code executing.

(2) Push the name object on the function's scope chain, rather than
the ExecState's scope chain because, well, that's where it belongs.

2:41 PM Changeset in webkit [32450] by Darin Adler

5 edits in trunk/WebCore

2008-04-22 Darin Adler <Darin Adler>

Reviewed by Anders.

simplify use of HashTraits to prepare for some upcoming hash table changes

page/AXObjectCache.h: Removed uneeded AXIDHashTraits, which are no different from the default hash traits for unsigned.
page/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::removeAXID): Remove assertion that's already done by HashTable that the value is not the deleted value.

platform/graphics/StringTruncator.cpp: Removed unneeded include.
svg/SVGFontFaceElement.cpp: Removed unneeded include.

2:41 PM Changeset in webkit [32449] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-04-22 Darin Adler <Darin Adler>

Reviewed by Anders.

simplify use of HashTraits to prepare for some upcoming hash table changes

kjs/SymbolTable.h: Made SymbolTableIndexHashTraits derive from HashTraits<size_t> and specialize only the empty value.

2:19 PM Changeset in webkit [32448] by kevino@webkit.org

3 edits in trunk/WebCore

wx build fixes. Changing BackgroundLayer -> FillLayer and adding Frame::disconnectPlatformScriptObjects()

2:00 PM Changeset in webkit [32447] by ggaren@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Inlined JSObject::putDirect, for a .4% SunSpider speedup.

I did this as a first step toward removing nodes.cpp from
AllInOneFile.cpp, but I'm putting that larger project aside for now.

1:31 PM Changeset in webkit [32446] by hyatt@apple.com

16 edits
9 adds in trunk

WebCore:

2008-04-23 David Hyatt <hyatt@apple.com>

Add support for mask-box-image (similar to border-image). This property enables a single image
to overlay the entire mask area (with nine-piece slicing rules similar to border image).

Reviewed by Dan Bernstein

Added inline-mask-overlay.html, block-mask-overlay.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderImage):
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines):
rendering/RenderObject.cpp: (WebCore::RenderObject::paintNinePieceImage): (WebCore::RenderObject::paintBorder):
rendering/RenderObject.h:
rendering/RenderStyle.cpp: (WebCore::NinePieceImage::operator==):
rendering/RenderStyle.h: (WebCore::): (WebCore::NinePieceImage::m_verticalRule): (WebCore::NinePieceImage::horizontalRule): (WebCore::NinePieceImage::verticalRule): (WebCore::RenderStyle::borderImage): (WebCore::RenderStyle::maskOverlayImage): (WebCore::RenderStyle::hasMask): (WebCore::RenderStyle::resetBorderImage): (WebCore::RenderStyle::setBorderImage): (WebCore::RenderStyle::setMaskOverlayImage): (WebCore::RenderStyle::initialNinePieceImage):
rendering/RenderTable.cpp: (WebCore::RenderTable::paintMask):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask):

LayoutTests:

2008-04-23 David Hyatt <hyatt@apple.com>

Add support for a new mask-box-image property that is analogous to border-image.

Reviewed by Dan Bernstein

fast/borders/block-mask-overlay-image.html: Added.
fast/borders/inline-mask-overlay-image.html: Added.
fast/borders/resources/mask.png: Added.
platform/mac/fast/borders/block-mask-overlay-image-expected.checksum: Added.
platform/mac/fast/borders/block-mask-overlay-image-expected.png: Added.
platform/mac/fast/borders/block-mask-overlay-image-expected.txt: Added.
platform/mac/fast/borders/inline-mask-overlay-image-expected.checksum: Added.
platform/mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
platform/mac/fast/borders/inline-mask-overlay-image-expected.txt: Added.

12:49 PM Changeset in webkit [32445] by mjs@apple.com

3 edits in branches/squirrelfish/JavaScriptCore

2008-04-23 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Geoff.

add OldInterpreterExecState class and use it in dead code

This will allow removing things from the real ExecState class
without having to figure out how to remove all this code without
getting a perf regression.

kjs/nodes.cpp: (KJS::ExpressionNode::evaluateToNumber): (KJS::ExpressionNode::evaluateToBoolean): (KJS::ExpressionNode::evaluateToInt32): (KJS::ExpressionNode::evaluateToUInt32): (KJS::Node::setErrorCompletion): (KJS::Node::throwError): (KJS::Node::throwUndefinedVariableError): (KJS::Node::handleException): (KJS::Node::rethrowException): (KJS::BreakpointCheckStatement::execute): (KJS::BreakpointCheckStatement::optimizeVariableAccess): (KJS::NullNode::evaluate): (KJS::FalseNode::evaluate): (KJS::TrueNode::evaluate): (KJS::NumberNode::evaluate): (KJS::NumberNode::evaluateToNumber): (KJS::NumberNode::evaluateToBoolean): (KJS::NumberNode::evaluateToInt32): (KJS::NumberNode::evaluateToUInt32): (KJS::ImmediateNumberNode::evaluate): (KJS::ImmediateNumberNode::evaluateToInt32): (KJS::ImmediateNumberNode::evaluateToUInt32): (KJS::StringNode::evaluate): (KJS::StringNode::evaluateToNumber): (KJS::StringNode::evaluateToBoolean): (KJS::RegExpNode::evaluate): (KJS::ThisNode::evaluate): (KJS::ResolveNode::inlineEvaluate): (KJS::ResolveNode::evaluate): (KJS::ResolveNode::evaluateToNumber): (KJS::ResolveNode::evaluateToBoolean): (KJS::ResolveNode::evaluateToInt32): (KJS::ResolveNode::evaluateToUInt32): (KJS::getSymbolTableEntry): (KJS::ResolveNode::optimizeVariableAccess): (KJS::LocalVarAccessNode::inlineEvaluate): (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarAccessNode::evaluateToNumber): (KJS::LocalVarAccessNode::evaluateToBoolean): (KJS::LocalVarAccessNode::evaluateToInt32): (KJS::LocalVarAccessNode::evaluateToUInt32): (KJS::getNonLocalSymbol): (KJS::ScopedVarAccessNode::inlineEvaluate): (KJS::ScopedVarAccessNode::evaluate): (KJS::ScopedVarAccessNode::evaluateToNumber): (KJS::ScopedVarAccessNode::evaluateToBoolean): (KJS::ScopedVarAccessNode::evaluateToInt32): (KJS::ScopedVarAccessNode::evaluateToUInt32): (KJS::NonLocalVarAccessNode::inlineEvaluate): (KJS::NonLocalVarAccessNode::evaluate): (KJS::NonLocalVarAccessNode::evaluateToNumber): (KJS::NonLocalVarAccessNode::evaluateToBoolean): (KJS::NonLocalVarAccessNode::evaluateToInt32): (KJS::NonLocalVarAccessNode::evaluateToUInt32): (KJS::ElementNode::optimizeVariableAccess): (KJS::ElementNode::evaluate): (KJS::ArrayNode::optimizeVariableAccess): (KJS::ArrayNode::evaluate): (KJS::ObjectLiteralNode::optimizeVariableAccess): (KJS::ObjectLiteralNode::evaluate): (KJS::PropertyListNode::optimizeVariableAccess): (KJS::PropertyListNode::evaluate): (KJS::PropertyNode::optimizeVariableAccess): (KJS::PropertyNode::evaluate): (KJS::BracketAccessorNode::optimizeVariableAccess): (KJS::BracketAccessorNode::inlineEvaluate): (KJS::BracketAccessorNode::evaluate): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::BracketAccessorNode::evaluateToBoolean): (KJS::BracketAccessorNode::evaluateToInt32): (KJS::BracketAccessorNode::evaluateToUInt32): (KJS::DotAccessorNode::optimizeVariableAccess): (KJS::DotAccessorNode::inlineEvaluate): (KJS::DotAccessorNode::evaluate): (KJS::DotAccessorNode::evaluateToNumber): (KJS::DotAccessorNode::evaluateToBoolean): (KJS::DotAccessorNode::evaluateToInt32): (KJS::DotAccessorNode::evaluateToUInt32): (KJS::ArgumentListNode::optimizeVariableAccess): (KJS::ArgumentListNode::evaluateList): (KJS::ArgumentsNode::optimizeVariableAccess): (KJS::NewExprNode::optimizeVariableAccess): (KJS::NewExprNode::inlineEvaluate): (KJS::NewExprNode::evaluate): (KJS::NewExprNode::evaluateToNumber): (KJS::NewExprNode::evaluateToBoolean): (KJS::NewExprNode::evaluateToInt32): (KJS::NewExprNode::evaluateToUInt32): (KJS::ExpressionNode::resolveAndCall): (KJS::EvalFunctionCallNode::optimizeVariableAccess): (KJS::EvalFunctionCallNode::evaluate): (KJS::FunctionCallValueNode::optimizeVariableAccess): (KJS::FunctionCallValueNode::evaluate): (KJS::FunctionCallResolveNode::optimizeVariableAccess): (KJS::FunctionCallResolveNode::inlineEvaluate): (KJS::FunctionCallResolveNode::evaluate): (KJS::FunctionCallResolveNode::evaluateToNumber): (KJS::FunctionCallResolveNode::evaluateToBoolean): (KJS::FunctionCallResolveNode::evaluateToInt32): (KJS::FunctionCallResolveNode::evaluateToUInt32): (KJS::LocalVarFunctionCallNode::inlineEvaluate): (KJS::LocalVarFunctionCallNode::evaluate): (KJS::LocalVarFunctionCallNode::evaluateToNumber): (KJS::LocalVarFunctionCallNode::evaluateToBoolean): (KJS::LocalVarFunctionCallNode::evaluateToInt32): (KJS::LocalVarFunctionCallNode::evaluateToUInt32): (KJS::ScopedVarFunctionCallNode::inlineEvaluate): (KJS::ScopedVarFunctionCallNode::evaluate): (KJS::ScopedVarFunctionCallNode::evaluateToNumber): (KJS::ScopedVarFunctionCallNode::evaluateToBoolean): (KJS::ScopedVarFunctionCallNode::evaluateToInt32): (KJS::ScopedVarFunctionCallNode::evaluateToUInt32): (KJS::NonLocalVarFunctionCallNode::inlineEvaluate): (KJS::NonLocalVarFunctionCallNode::evaluate): (KJS::NonLocalVarFunctionCallNode::evaluateToNumber): (KJS::NonLocalVarFunctionCallNode::evaluateToBoolean): (KJS::NonLocalVarFunctionCallNode::evaluateToInt32): (KJS::NonLocalVarFunctionCallNode::evaluateToUInt32): (KJS::FunctionCallBracketNode::optimizeVariableAccess): (KJS::FunctionCallBracketNode::evaluate): (KJS::FunctionCallDotNode::optimizeVariableAccess): (KJS::FunctionCallDotNode::inlineEvaluate): (KJS::FunctionCallDotNode::evaluate): (KJS::FunctionCallDotNode::evaluateToNumber): (KJS::FunctionCallDotNode::evaluateToBoolean): (KJS::FunctionCallDotNode::evaluateToInt32): (KJS::FunctionCallDotNode::evaluateToUInt32): (KJS::PostIncResolveNode::optimizeVariableAccess): (KJS::PostIncResolveNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecResolveNode::optimizeVariableAccess): (KJS::PostDecResolveNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::PostDecLocalVarNode::inlineEvaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToNumber): (KJS::PostDecLocalVarNode::evaluateToBoolean): (KJS::PostDecLocalVarNode::evaluateToInt32): (KJS::PostDecLocalVarNode::evaluateToUInt32): (KJS::PostfixBracketNode::optimizeVariableAccess): (KJS::PostIncBracketNode::evaluate): (KJS::PostDecBracketNode::evaluate): (KJS::PostfixDotNode::optimizeVariableAccess): (KJS::PostIncDotNode::evaluate): (KJS::PostDecDotNode::evaluate): (KJS::PostfixErrorNode::evaluate): (KJS::DeleteResolveNode::optimizeVariableAccess): (KJS::DeleteResolveNode::evaluate): (KJS::LocalVarDeleteNode::evaluate): (KJS::DeleteBracketNode::optimizeVariableAccess): (KJS::DeleteBracketNode::evaluate): (KJS::DeleteDotNode::optimizeVariableAccess): (KJS::DeleteDotNode::evaluate): (KJS::DeleteValueNode::optimizeVariableAccess): (KJS::DeleteValueNode::evaluate): (KJS::VoidNode::optimizeVariableAccess): (KJS::VoidNode::evaluate): (KJS::TypeOfValueNode::optimizeVariableAccess): (KJS::TypeOfResolveNode::optimizeVariableAccess): (KJS::LocalVarTypeOfNode::evaluate): (KJS::TypeOfResolveNode::evaluate): (KJS::TypeOfValueNode::evaluate): (KJS::PreIncResolveNode::optimizeVariableAccess): (KJS::PreIncLocalVarNode::evaluate): (KJS::PreIncResolveNode::evaluate): (KJS::PreDecResolveNode::optimizeVariableAccess): (KJS::PreDecLocalVarNode::evaluate): (KJS::PreDecResolveNode::evaluate): (KJS::PreIncConstNode::evaluate): (KJS::PreDecConstNode::evaluate): (KJS::PostIncConstNode::evaluate): (KJS::PostDecConstNode::evaluate): (KJS::PrefixBracketNode::optimizeVariableAccess): (KJS::PreIncBracketNode::evaluate): (KJS::PreDecBracketNode::evaluate): (KJS::PrefixDotNode::optimizeVariableAccess): (KJS::PreIncDotNode::evaluate): (KJS::PreDecDotNode::evaluate): (KJS::PrefixErrorNode::evaluate): (KJS::UnaryPlusNode::optimizeVariableAccess): (KJS::UnaryPlusNode::evaluate): (KJS::UnaryPlusNode::evaluateToBoolean): (KJS::UnaryPlusNode::evaluateToNumber): (KJS::UnaryPlusNode::evaluateToInt32): (KJS::UnaryPlusNode::evaluateToUInt32): (KJS::NegateNode::optimizeVariableAccess): (KJS::NegateNode::evaluate): (KJS::NegateNode::evaluateToNumber): (KJS::BitwiseNotNode::optimizeVariableAccess): (KJS::BitwiseNotNode::inlineEvaluateToInt32): (KJS::BitwiseNotNode::evaluate): (KJS::BitwiseNotNode::evaluateToNumber): (KJS::BitwiseNotNode::evaluateToBoolean): (KJS::BitwiseNotNode::evaluateToInt32): (KJS::BitwiseNotNode::evaluateToUInt32): (KJS::LogicalNotNode::optimizeVariableAccess): (KJS::LogicalNotNode::evaluate): (KJS::LogicalNotNode::evaluateToBoolean): (KJS::MultNode::optimizeVariableAccess): (KJS::MultNode::inlineEvaluateToNumber): (KJS::MultNode::evaluate): (KJS::MultNode::evaluateToNumber): (KJS::MultNode::evaluateToBoolean): (KJS::MultNode::evaluateToInt32): (KJS::MultNode::evaluateToUInt32): (KJS::DivNode::optimizeVariableAccess): (KJS::DivNode::inlineEvaluateToNumber): (KJS::DivNode::evaluate): (KJS::DivNode::evaluateToNumber): (KJS::DivNode::evaluateToInt32): (KJS::DivNode::evaluateToUInt32): (KJS::ModNode::optimizeVariableAccess): (KJS::ModNode::inlineEvaluateToNumber): (KJS::ModNode::evaluate): (KJS::ModNode::evaluateToNumber): (KJS::ModNode::evaluateToBoolean): (KJS::ModNode::evaluateToInt32): (KJS::ModNode::evaluateToUInt32): (KJS::throwOutOfMemoryErrorToNumber): (KJS::addSlowCase): (KJS::addSlowCaseToNumber): (KJS::add): (KJS::addToNumber): (KJS::AddNode::optimizeVariableAccess): (KJS::AddNode::evaluate): (KJS::AddNode::inlineEvaluateToNumber): (KJS::AddNode::evaluateToNumber): (KJS::AddNode::evaluateToInt32): (KJS::AddNode::evaluateToUInt32): (KJS::AddNumbersNode::inlineEvaluateToNumber): (KJS::AddNumbersNode::evaluate): (KJS::AddNumbersNode::evaluateToNumber): (KJS::AddNumbersNode::evaluateToInt32): (KJS::AddNumbersNode::evaluateToUInt32): (KJS::AddStringsNode::evaluate): (KJS::AddStringLeftNode::evaluate): (KJS::AddStringRightNode::evaluate): (KJS::SubNode::optimizeVariableAccess): (KJS::SubNode::inlineEvaluateToNumber): (KJS::SubNode::evaluate): (KJS::SubNode::evaluateToNumber): (KJS::SubNode::evaluateToInt32): (KJS::SubNode::evaluateToUInt32): (KJS::LeftShiftNode::optimizeVariableAccess): (KJS::LeftShiftNode::inlineEvaluateToInt32): (KJS::LeftShiftNode::evaluate): (KJS::LeftShiftNode::evaluateToNumber): (KJS::LeftShiftNode::evaluateToInt32): (KJS::LeftShiftNode::evaluateToUInt32): (KJS::RightShiftNode::optimizeVariableAccess): (KJS::RightShiftNode::inlineEvaluateToInt32): (KJS::RightShiftNode::evaluate): (KJS::RightShiftNode::evaluateToNumber): (KJS::RightShiftNode::evaluateToInt32): (KJS::RightShiftNode::evaluateToUInt32): (KJS::UnsignedRightShiftNode::optimizeVariableAccess): (KJS::UnsignedRightShiftNode::inlineEvaluateToUInt32): (KJS::UnsignedRightShiftNode::evaluate): (KJS::UnsignedRightShiftNode::evaluateToNumber): (KJS::UnsignedRightShiftNode::evaluateToInt32): (KJS::UnsignedRightShiftNode::evaluateToUInt32): (KJS::lessThan): (KJS::lessThanEq): (KJS::LessNode::optimizeVariableAccess): (KJS::LessNode::inlineEvaluateToBoolean): (KJS::LessNode::evaluate): (KJS::LessNode::evaluateToBoolean): (KJS::LessNumbersNode::inlineEvaluateToBoolean): (KJS::LessNumbersNode::evaluate): (KJS::LessNumbersNode::evaluateToBoolean): (KJS::LessStringsNode::inlineEvaluateToBoolean): (KJS::LessStringsNode::evaluate): (KJS::LessStringsNode::evaluateToBoolean): (KJS::GreaterNode::optimizeVariableAccess): (KJS::GreaterNode::inlineEvaluateToBoolean): (KJS::GreaterNode::evaluate): (KJS::GreaterNode::evaluateToBoolean): (KJS::LessEqNode::optimizeVariableAccess): (KJS::LessEqNode::inlineEvaluateToBoolean): (KJS::LessEqNode::evaluate): (KJS::LessEqNode::evaluateToBoolean): (KJS::GreaterEqNode::optimizeVariableAccess): (KJS::GreaterEqNode::inlineEvaluateToBoolean): (KJS::GreaterEqNode::evaluate): (KJS::GreaterEqNode::evaluateToBoolean): (KJS::InstanceOfNode::optimizeVariableAccess): (KJS::InstanceOfNode::evaluate): (KJS::InstanceOfNode::evaluateToBoolean): (KJS::InNode::optimizeVariableAccess): (KJS::InNode::evaluate): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::optimizeVariableAccess): (KJS::EqualNode::inlineEvaluateToBoolean): (KJS::EqualNode::evaluate): (KJS::EqualNode::evaluateToBoolean): (KJS::NotEqualNode::optimizeVariableAccess): (KJS::NotEqualNode::inlineEvaluateToBoolean): (KJS::NotEqualNode::evaluate): (KJS::NotEqualNode::evaluateToBoolean): (KJS::StrictEqualNode::optimizeVariableAccess): (KJS::StrictEqualNode::inlineEvaluateToBoolean): (KJS::StrictEqualNode::evaluate): (KJS::StrictEqualNode::evaluateToBoolean): (KJS::NotStrictEqualNode::optimizeVariableAccess): (KJS::NotStrictEqualNode::inlineEvaluateToBoolean): (KJS::NotStrictEqualNode::evaluate): (KJS::NotStrictEqualNode::evaluateToBoolean): (KJS::BitAndNode::optimizeVariableAccess): (KJS::BitAndNode::evaluate): (KJS::BitAndNode::inlineEvaluateToInt32): (KJS::BitAndNode::evaluateToNumber): (KJS::BitAndNode::evaluateToBoolean): (KJS::BitAndNode::evaluateToInt32): (KJS::BitAndNode::evaluateToUInt32): (KJS::BitXOrNode::optimizeVariableAccess): (KJS::BitXOrNode::inlineEvaluateToInt32): (KJS::BitXOrNode::evaluate): (KJS::BitXOrNode::evaluateToNumber): (KJS::BitXOrNode::evaluateToBoolean): (KJS::BitXOrNode::evaluateToInt32): (KJS::BitXOrNode::evaluateToUInt32): (KJS::BitOrNode::optimizeVariableAccess): (KJS::BitOrNode::inlineEvaluateToInt32): (KJS::BitOrNode::evaluate): (KJS::BitOrNode::evaluateToNumber): (KJS::BitOrNode::evaluateToBoolean): (KJS::BitOrNode::evaluateToInt32): (KJS::BitOrNode::evaluateToUInt32): (KJS::LogicalAndNode::optimizeVariableAccess): (KJS::LogicalAndNode::evaluate): (KJS::LogicalAndNode::evaluateToBoolean): (KJS::LogicalOrNode::optimizeVariableAccess): (KJS::LogicalOrNode::evaluate): (KJS::LogicalOrNode::evaluateToBoolean): (KJS::ConditionalNode::optimizeVariableAccess): (KJS::ConditionalNode::evaluate): (KJS::ConditionalNode::evaluateToBoolean): (KJS::ConditionalNode::evaluateToNumber): (KJS::ConditionalNode::evaluateToInt32): (KJS::ConditionalNode::evaluateToUInt32): (KJS::valueForReadModifyAssignment): (KJS::ReadModifyResolveNode::optimizeVariableAccess): (KJS::AssignResolveNode::optimizeVariableAccess): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::AssignLocalVarNode::evaluate): (KJS::ReadModifyConstNode::evaluate): (KJS::AssignConstNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::AssignResolveNode::evaluate): (KJS::AssignDotNode::optimizeVariableAccess): (KJS::AssignDotNode::evaluate): (KJS::ReadModifyDotNode::optimizeVariableAccess): (KJS::ReadModifyDotNode::evaluate): (KJS::AssignErrorNode::evaluate): (KJS::AssignBracketNode::optimizeVariableAccess): (KJS::AssignBracketNode::evaluate): (KJS::ReadModifyBracketNode::optimizeVariableAccess): (KJS::ReadModifyBracketNode::evaluate): (KJS::CommaNode::optimizeVariableAccess): (KJS::CommaNode::evaluate): (KJS::ConstDeclNode::optimizeVariableAccess): (KJS::ConstDeclNode::handleSlowCase): (KJS::ConstDeclNode::evaluateSingle): (KJS::ConstDeclNode::evaluate): (KJS::ConstStatementNode::optimizeVariableAccess): (KJS::ConstStatementNode::execute): (KJS::statementListExecute): (KJS::BlockNode::optimizeVariableAccess): (KJS::BlockNode::execute): (KJS::EmptyStatementNode::execute): (KJS::ExprStatementNode::optimizeVariableAccess): (KJS::ExprStatementNode::execute): (KJS::VarStatementNode::optimizeVariableAccess): (KJS::VarStatementNode::execute): (KJS::IfNode::optimizeVariableAccess): (KJS::IfNode::execute): (KJS::IfElseNode::optimizeVariableAccess): (KJS::IfElseNode::execute): (KJS::DoWhileNode::optimizeVariableAccess): (KJS::DoWhileNode::execute): (KJS::WhileNode::optimizeVariableAccess): (KJS::WhileNode::execute): (KJS::ForNode::optimizeVariableAccess): (KJS::ForNode::execute): (KJS::ForInNode::optimizeVariableAccess): (KJS::ForInNode::execute): (KJS::ContinueNode::execute): (KJS::BreakNode::execute): (KJS::ReturnNode::optimizeVariableAccess): (KJS::ReturnNode::execute): (KJS::WithNode::optimizeVariableAccess): (KJS::WithNode::execute): (KJS::CaseClauseNode::optimizeVariableAccess): (KJS::CaseClauseNode::evaluate): (KJS::CaseClauseNode::executeStatements): (KJS::ClauseListNode::optimizeVariableAccess): (KJS::CaseBlockNode::optimizeVariableAccess): (KJS::CaseBlockNode::executeBlock): (KJS::SwitchNode::optimizeVariableAccess): (KJS::SwitchNode::execute): (KJS::LabelNode::optimizeVariableAccess): (KJS::LabelNode::execute): (KJS::ThrowNode::optimizeVariableAccess): (KJS::ThrowNode::execute): (KJS::TryNode::optimizeVariableAccess): (KJS::TryNode::execute): (KJS::ProgramNode::initializeSymbolTable): (KJS::ScopeNode::optimizeVariableAccess): (KJS::ProgramNode::processDeclarations): (KJS::EvalNode::processDeclarations): (KJS::ProgramNode::execute): (KJS::EvalNode::execute): (KJS::FunctionBodyNodeWithDebuggerHooks::execute): (KJS::FuncDeclNode::execute): (KJS::FuncExprNode::evaluate):
kjs/nodes.h: (KJS::Node::): (KJS::FalseNode::): (KJS::TrueNode::): (KJS::ArgumentsNode::):

12:36 PM Changeset in webkit [32444] by oliver@apple.com

4 edits
1 add in branches/squirrelfish/JavaScriptCore

Bug 18672: SQUIRRELFISH: codegen fails with a large number of temporaries
<https://bugs.webkit.org/show_bug.cgi?id=18672>

Reviewed by Geoff

Add a SegmentedVector type, which provides a Vector<T> which maintains
existing memory locations during resize. This allows dynamically sizing
local, temporary and label "vectors" in CodeGenerator.

11:25 AM Changeset in webkit [32443] by justin.garcia@apple.com

3 edits
4 adds in trunk

WebCore:

2008-04-23 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Return a null VisiblePosition if this function moves out of highestRoot. Re-wrote so as to not duplicate code inside and outside of the while loop. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.

LayoutTests:

2008-04-23 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

editing/selection/5825350-1-expected.txt: Added.
editing/selection/5825350-1.html: Added.
editing/selection/5825350-2-expected.txt: Added.
editing/selection/5825350-2.html: Added.

10:49 AM Changeset in webkit [32442] by pewtermoose@webkit.org

5 edits in trunk

WebCore:

2008-04-23 Daniel Zucker <zucker@wake3.com>

Reviewed by Adam Roben.

Fix build errors needed to compile Curl in Cairo build. Add stubs for
didReceiveAuthenticationChallenge, receivedCredential,
receivedRequestToContinueWithoutCredential, and receivedCancellation.
<https://bugs.webkit.org/show_bug.cgi?id=18468>

platform/network/ResourceHandle.h:
platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):

WebKit/win:

2008-04-23 Daniel Zucker <zucker@wake3.com>

Reviewed by Adam Roben.

<https://bugs.webkit.org/show_bug.cgi?id=18468>

WebError.h: include RetainPtr.h to fix build errors in Cairo build

10:43 AM Changeset in webkit [32441] by pewtermoose@webkit.org

2 edits in trunk/WebKit/win

2008-04-23 Daniel Zucker <zucker@wake3.com>

Reviewed by Adam Roben.

Move the location of #if USE(CFNETWORK) to fix a cairo/curl build error.
<https://bugs.webkit.org/show_bug.cgi?id=18470>

WebError.cpp: (WebError::sslPeerCertificate):

10:35 AM Changeset in webkit [32440] by Adam Roben

2 edits in trunk/WebKitTools

Make crashes be reported as crashes, not hangs

Reviewed by David Kilzer.

Scripts/run-webkit-tests: (top level): Use the new status field of the output from readFromDumpToolWithTimer to determine if the test crashed or hung. (sub readFromDumpToolWithTimer):
- If we fail to read a line and $! is not EAGAIN, then we've crashed and should not try to read any more.
- Changed the timedout field to a more general status field.

9:08 AM Changeset in webkit [32439] by Darin Adler

2 edits in trunk/LayoutTests

2008-04-23 Darin Adler <Darin Adler>

updated a test affected by the addition of mask-composite

svg/css/getComputedStyle-basic-expected.txt: Updated.

7:50 AM Changeset in webkit [32438] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix a bug where moving forward in bidirectional text skips over the position after the end of the line

Test: editing/selection/move-past-trailing-space.html

dom/Position.cpp: (WebCore::Position::upstream): Changed the logic for identifying when a position is after the last character of a text box of a text node that continues on the next line, to make it work correctly when boxes are not laid out in logical order. (WebCore::Position::downstream): Ditto.

LayoutTests:

Reviewed by Darin Adler.

test that moving forward through bidirectional text does not skip the position after the last character on the line

editing/selection/move-past-trailing-space.html: Added.
platform/mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
platform/mac/editing/selection/move-past-trailing-space-expected.png: Added.
platform/mac/editing/selection/move-past-trailing-space-expected.txt: Added.

7:45 AM Changeset in webkit [32437] by Simon Hausmann

3 edits in trunk/WebKit/qt

Fix compilation against Qt 4.3

7:44 AM Changeset in webkit [32436] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

A little refactoring in preparation for supporting 'arguments'.

Fixes 2 regression tests.

SunSpider reports no change.

We now check the activation register, instead of the codeBlock, to
determine whether we need to tear off the activation. This is to support
"f.arguments", which will create an activation/arguments pair for f,
even though the needsFullScopeChain flag is false for f's codeBlock.

The test fixes resulted from calling initializeCallFrame for re-entrant
function code, instead of initializing (not enough) parts of the call
frame by hand.

7:36 AM Changeset in webkit [32435] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <zecke@selfish.org>

Make sure the "Inspect Element" item gets added to the ContextMenu, a call to ContextMenu::populate() is not adding it, the ContextMenuController does add it after the call to populate(). Do that as well.

7:36 AM Changeset in webkit [32434] by Simon Hausmann

2 edits in trunk/WebCore

Brad Hughes <bhughes@trolltech.com>

Fix release build with the intel compiler

Intel compiler can't compile qtwebkit with -O2 or -O1, so we're left with -O0

7:36 AM Changeset in webkit [32433] by Simon Hausmann

5 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Fix crashes on window.close().

We should not delete the QWebPage object in the ChromeClient but leave it up to
the application when and whether to delete a browser window. For this we now
emit the windowCloseRequested() signal.

Done with Tor Arne.

7:21 AM Changeset in webkit [32432] by Simon Hausmann

3 edits in trunk/WebKit/qt

Fix parsing of external scripts/stylesheets when using setHtml(const QString &html).

We used to pass the html string to the frameloader in utf-16, which also meant that the default
encoding of external scripts/stylesheets became utf-16. That doesn't make sense, so assume utf-8
by default. This is now also documented.

6:58 AM Changeset in webkit [32431] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Holger Hans Peter Freyther <zecke@selfish.org>

Removed the #define for USE_SYSTEM_MALLOC that we set in WebKit.pri
already.

1:31 AM Changeset in webkit [32430] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Fixes background color propagation when using a custom QWebPage

Set the palette in setPage(), not during the creation on-demand.

1:26 AM Changeset in webkit [32429] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Fix the user agent on the mac to be BSD4

Put Q_OS_DARWIN before Q_OS_BSD4 sense they are both defined on the mac

1:07 AM Changeset in webkit [32428] by Simon Hausmann

2 edits in trunk/WebKit/qt

Added missing copyright notice.
Small fixes to the documentation.

12:49 AM Changeset in webkit [32427] by Simon Hausmann

3 edits in trunk/WebKit/qt

Zack Rusin <zack@tungstengraphics.com>

Added a contentsSize() property.

Apr 22, 2008:

9:22 PM Changeset in webkit [32426] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

remove unused calls to Position::upstream()

editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): (WebCore::InsertLineBreakCommand::insertNodeBeforePosition):

9:19 PM Changeset in webkit [32425] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Sam.

Implement get_accKeyboardShortcut().

AccessibleBase.cpp: (AccessibleBase::get_accKeyboardShortcut): Report the key combination that will perform the object's access key action, represented as a string.

9:18 PM Changeset in webkit [32424] by jhoneycutt@apple.com

9 edits in trunk/WebCore

2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Sam.

Add a method to query which modifier keys the platform uses for access
key actions.

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Bitwise and the event's modifier keys with the platform's access key modifier mask to determine whether this event can perform an access key action.
page/EventHandler.h: Added s_accessKeyModifiers, a platform-defined mask of modifier keys used for access key actions, and a getter.
page/mac/EventHandlerMac.mm: Use PlatformKeyboardEvent::CtrlKey for access key actions.
page/qt/EventHandlerQt.cpp: Same.
page/gtk/EventHandlerGtk.cpp: Use AltKey.
page/win/EventHandlerWin.cpp: Same.
page/wx/EventHandlerWx.cpp: Same.
platform/PlatformKeyboardEvent.h: Added an enum, ModifierKey. (WebCore::PlatformKeyboardEvent::): (WebCore::PlatformKeyboardEvent::modifiers): Return which modifier keys were active, a combination of ModifierKey values.

8:58 PM Changeset in webkit [32423] by mjs@apple.com

3 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam.

propagate the "this" value properly to local eval

(fixes a measly one regression test)

VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
VM/Machine.cpp: (KJS::Machine::privateExecute):

8:52 PM Changeset in webkit [32422] by weinig@apple.com

3 edits in trunk/WebCore

2008-04-22 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Make the KJSProxy and FrameLoader member variables instead of pointers
in FramePrivate in a bid to do a little clean up before the last of the
split window patches. Also, make the KJSProxy not lazily created, as the
real benefit comes from lazily creating the JSDOMWindowWrapper, which we
still do.

page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::scriptProxy): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::clearScriptProxy): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
page/FramePrivate.h:

8:42 PM Changeset in webkit [32421] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

2008-04-22 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dan Bernstein.

fix https://bugs.webkit.org/show_bug.cgi?id=18584 border-color, outline-color, column-color, -webkit-text-stroke-color, and -webkit-text-fill-color inheritance to correctly use parent's color if the parent's corresponding (border, outline, etc.)-color property wasn't set.

Test: fast/borders/border-color-inherit.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

2008-04-22 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=18584
Add a test case for border-color inheritance.

fast/borders/border-color-inherit.html: Added.
platform/mac/fast/borders/border-color-inherit-expected.checksum: Added.
platform/mac/fast/borders/border-color-inherit-expected.png: Added.
platform/mac/fast/borders/border-color-inherit-expected.txt: Added.

8:14 PM Changeset in webkit [32420] by alp@webkit.org

2 edits in trunk

2008-04-22 Alp Toker <alp@nuanti.com>

GTK+ debug build fix for changes in r32257.

GNUmakefile.am:

8:13 PM Changeset in webkit [32419] by mjs@apple.com

6 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for function declarations in eval code.

(this fixes 12 more regression tests)

VM/CodeBlock.h:
VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
VM/CodeGenerator.h:
VM/Machine.cpp: (KJS::Machine::execute):
kjs/nodes.cpp: (KJS::EvalNode::generateCode):

7:15 PM Changeset in webkit [32418] by alp@webkit.org

3 edits in trunk/WebCore

2008-04-22 Alp Toker <alp@nuanti.com>

Rubber-stamped by Dave Hyatt.

Move GraphicsContext::clipToImageBuffer() notImplemented() stub to
GraphicsContextCairo.

platform/graphics/GraphicsContext.cpp:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipToImageBuffer):

7:13 PM Changeset in webkit [32417] by hyatt@apple.com

11 edits
13 adds in trunk

WebCore:

2008-04-22 David Hyatt <hyatt@apple.com>

Add support for mask-composite to match background-composite.

Reviewed by Sam Weinig

Added fast/backgrounds/mask-composite.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillProperty):
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):

LayoutTests:

2008-04-22 David Hyatt <hyatt@apple.com>

Add support for mask-composite.

Reviewed by Sam Weinig

fast/backgrounds/mask-composite.html: Added.
fast/backgrounds/resources/mask-bottom-left.png: Added.
fast/backgrounds/resources/mask-bottom-right.png: Added.
fast/backgrounds/resources/mask-bottom.png: Added.
fast/backgrounds/resources/mask-center.png: Added.
fast/backgrounds/resources/mask-left.png: Added.
fast/backgrounds/resources/mask-right.png: Added.
fast/backgrounds/resources/mask-top-left.png: Added.
fast/backgrounds/resources/mask-top-right.png: Added.
fast/backgrounds/resources/mask-top.png: Added.
platform/mac/fast/backgrounds/mask-composite-expected.checksum: Added.
platform/mac/fast/backgrounds/mask-composite-expected.png: Added.
platform/mac/fast/backgrounds/mask-composite-expected.txt: Added.

5:45 PM Changeset in webkit [32416] by hyatt@apple.com

3 edits in trunk/WebCore

2008-04-22 David Hyatt <hyatt@apple.com>

Fix for bug 18688, background-color stopped painting on inlines. Fix a virtual function
misnaming that led to the derived class not getting called properly.

Reviewed by Mark Rowe

ChangeLog:
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
rendering/RenderObject.h: (WebCore::RenderObject::paintFillLayerExtended):

5:21 PM Changeset in webkit [32415] by mjs@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Implement LabelNode.

VM/CodeGenerator.cpp: (KJS::CodeGenerator::pushJumpContext): (KJS::CodeGenerator::jumpContextForContinue): (KJS::CodeGenerator::jumpContextForBreak):
VM/CodeGenerator.h:
kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::ContinueNode::emitCode): (KJS::BreakNode::emitCode): (KJS::SwitchNode::emitCode): (KJS::LabelNode::emitCode):

5:16 PM Changeset in webkit [32414] by hyatt@apple.com

6 adds in trunk/LayoutTests/platform/mac/fast/backgrounds

Add new layout test results.

5:13 PM Changeset in webkit [32413] by beidson@apple.com

4 edits in trunk/WebCore

2008-04-22 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/5733282> and https://bugs.webkit.org/show_bug.cgi?id=18680
Always loads default shortcut icon URL when an external <script> is referenced before the icon URL is set.

dom/Document.cpp: (WebCore::Document::implicitClose): Call FrameLoader->startIconLoader() here, when the document is finished parsing.

loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoadingMainResource): Don't start the icon load here, when the document is finished parsing. This was often too early, as document parsing may be blocked on an external script and therefore the correct iconURL is not set yet. The isLoadingFromCachedPage() check was when we started the icon load based on *loading* instead parsing, and is now irrelevant.
loader/FrameLoader.h: Make startIconLoader() public

4:52 PM Changeset in webkit [32412] by Antti Koivisto

2 edits in trunk/LayoutTests

2008-04-22 Antti Koivisto <Antti Koivisto>

Update SVG animation test results.

platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:

4:51 PM Changeset in webkit [32411] by Antti Koivisto

4 edits in trunk/WebCore

2008-04-22 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Support keyPoints attribute of <animateMotion>.

Tested by SVG test suite test
animate-elem-33-t.svg

svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::calculatePercentForSpline): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval): (WebCore::SVGAnimationElement::updateAnimation):
svg/SVGAnimationElement.h:

3:37 PM Changeset in webkit [32410] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed crash when unwinding from exceptions inside eval.

VM/Machine.cpp: (KJS::Machine::unwindCallFrame): Don't assume that the top of the current call frame's scope chain is an activation: it can be the global object, instead.

3:34 PM Changeset in webkit [32409] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.

kjs/testkjs.cpp: (main): Convert signals to exit codes, so that crashing tests are detected as regression test failures.

2:49 PM Changeset in webkit [32408] by zecke@webkit.org

2 edits in trunk/WebCore

2008-04-22 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix.

Update WebKit.qrc to catch up with the addition and removal of images
from page/inspector/Images in recent commits.

page/inspector/WebKit.qrc:

2:44 PM Changeset in webkit [32407] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 18683: update-webkit returns 0 even if it fails

<https://bugs.webkit.org/show_bug.cgi?id=18683>

Reviewed by Mitz Pettel.

Scripts/update-webkit: (runSvnUpdate): Die if close() fails.

2:40 PM Changeset in webkit [32406] by hyatt@apple.com

25 edits
3 adds in trunk

WebCore:

2008-04-22 David Hyatt <hyatt@apple.com>

Fix for <rdar://5589634>.

Implement CSS alpha masks. The syntax is very similar to that used for backgrounds. Multiple mask images
can be specified, and each one can be tiled, positioned, etc. The following new properties have been
added (all of which are analogous to their background-* counterparts).

mask, mask-image, mask-clip, mask-origin, mask-repeat, mask-attachment, mask-position

The alpha values in the final composite image are used to determine how the mask applies (alpha of 1 = show,
alpha of 0 = don't show).

SVG images and CSS gradients can also be used as masks.

Reviewed by Dan

Added fast/backgrounds/repeat/mask-negative-offset-repeat.html, fast/backgrounds/svg-as-mask.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::initShorthandMap):
css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransformOrigin):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
rendering/InlineFlowBox.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): (WebCore::RenderBox::paintFillLayerExtended):
rendering/RenderBox.h:
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
rendering/RenderFieldset.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::paintLayer):
rendering/RenderObject.cpp: (WebCore::RenderObject::requiresLayer): (WebCore::mustRepaintFillLayers): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::updateFillImages):
rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::paintMask): (WebCore::RenderObject::paintFillExtended):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
rendering/RenderStyle.h: (WebCore::FillLayer::initialFillComposite): (WebCore::FillLayer::initialFillSize): (WebCore::FillLayer::FillLayer): (WebCore::RenderStyle::hasMask):
rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::paintMask):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintMask):
rendering/RenderTableCell.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): (WebCore::SVGImage::dataChanged):

LayoutTests:

2008-04-22 David Hyatt <hyatt@apple.com>

Add support for CSS alpha masks. Test cases.

Reviewed by Dan

fast/backgrounds/repeat/mask-negative-offset-repeat.html: Added.
fast/backgrounds/repeat/resources/white.gif: Added.
fast/backgrounds/svg-as-mask.html: Added.

2:38 PM Changeset in webkit [32405] by weinig@apple.com

13 edits
2 adds in trunk/WebCore

2008-04-22 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Make DOMAbstractView have a weak reference to the Frame instead of ref'ing
the DOMWindow.

To ensure that the WindowScriptObject (which is a DOMAbstractView) stays valid
after a navigation once the split window is completed, the DOMAbstractView must
wrap the Frame instead of a DOMWindow since the DOMWindow will change.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView dealloc]): (-[DOMAbstractView finalize]): (-[DOMAbstractView document]): (-[DOMAbstractView _disconnectFrame]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithFrame:WebCore::]): (+[DOMAbstractView _wrapAbstractView:WebCore::]): Add custom implementation to implement weak reference semantics.

bindings/objc/DOMAbstractViewFrame.h: Added. Declare the [DOMAbstractView _disconectFrame] selector.
bindings/objc/DOMInternal.h: Remove DOMRGBColor Internal category since it is now generated.

bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): Don't ever create a DOMAbstractView from a JSDOMWindow, only from JSDOMWindowWrapper.

bindings/scripts/CodeGeneratorObjC.pm: Generate internal header for IDLs that want custom implementations.

css/RGBColor.idl: Make this a PODType as it really is in the implementation.

page/AbstractView.idl: This now needs a custom objective-c binding implementation.

page/Frame.cpp: (WebCore::Frame::~Frame): disconnect the weak frame reference in the WindowScriptObject.

page/Frame.h:
page/gtk/FrameGtk.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): ASSERT that the windowScriptObject is a DOMAbstractView. (WebCore::Frame::disconnectPlatformScriptObjects): Disconnect the frame pointer from the windowScriptObject.
page/qt/FrameQt.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
page/win/FrameWin.cpp: (WebCore::Frame::disconnectPlatformScriptObjects): Ditto.

2:21 PM Changeset in webkit [32404] by ggaren@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Maciej Stachowiak.

Renamed "needsActivation" to "needsFullScopeChain" because lying will
make hair grow on the backs of your hands.

1:45 PM Changeset in webkit [32403] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog.

1:42 PM Changeset in webkit [32402] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Sam Weinig.

preparation https://bugs.webkit.org/show_bug.cgi?id=3729 <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Make sure to give the trailing white space a bidi level consistent with its position.

LayoutTests:

Reviewed by Sam Weinig.

updated results with the trailing space having the right directionality

platform/mac/fast/text/trailing-white-space-2-expected.txt:

11:52 AM Changeset in webkit [32401] by timothy@apple.com

1 edit
75 deletes in trunk/WebCore

Remove many unused Web Inspector images.

Rubber-stamped by Adam Roben and Sam Weinig.

page/inspector/Images/attachedShadow.png: Removed.
page/inspector/Images/backNormal.png: Removed.
page/inspector/Images/bottomShadow.png: Removed.
page/inspector/Images/breadcrumbBackground.png: Removed.
page/inspector/Images/console.png: Removed.
page/inspector/Images/databaseBrowserViewNormal.png: Removed.
page/inspector/Images/databaseBrowserViewNormalSelected.png: Removed.
page/inspector/Images/databaseBrowserViewSmall.png: Removed.
page/inspector/Images/databaseBrowserViewSmallSelected.png: Removed.
page/inspector/Images/databaseQueryViewNormal.png: Removed.
page/inspector/Images/databaseQueryViewNormalSelected.png: Removed.
page/inspector/Images/databaseQueryViewSmall.png: Removed.
page/inspector/Images/databaseQueryViewSmallSelected.png: Removed.
page/inspector/Images/disclosureDownPressed.png: Removed.
page/inspector/Images/disclosureRightDown.png: Removed.
page/inspector/Images/disclosureRightPressed.png: Removed.
page/inspector/Images/document.png: Removed.
page/inspector/Images/domViewNormal.png: Removed.
page/inspector/Images/domViewNormalSelected.png: Removed.
page/inspector/Images/domViewSmall.png: Removed.
page/inspector/Images/domViewSmallSelected.png: Removed.
page/inspector/Images/downTriangle.png: Removed.
page/inspector/Images/folder.png: Removed.
page/inspector/Images/forwardNormal.png: Removed.
page/inspector/Images/gradient.png: Removed.
page/inspector/Images/gradientHighlight.png: Removed.
page/inspector/Images/gradientHighlightBottom.png: Removed.
page/inspector/Images/hideStatusWidget.png: Removed.
page/inspector/Images/hideStatusWidgetPressed.png: Removed.
page/inspector/Images/network.png: Removed.
page/inspector/Images/plainDocument.png: Removed.
page/inspector/Images/popupArrows.png: Removed.
page/inspector/Images/popupArrowsBlack.png: Removed.
page/inspector/Images/reload.png: Removed.
page/inspector/Images/rightTriangle.png: Removed.
page/inspector/Images/showStatusWidget.png: Removed.
page/inspector/Images/showStatusWidgetPressed.png: Removed.
page/inspector/Images/sidbarItemBackground.png: Removed.
page/inspector/Images/sidebarActionWidget.png: Removed.
page/inspector/Images/sidebarActionWidgetPressed.png: Removed.
page/inspector/Images/sidebarAttachWidget.png: Removed.
page/inspector/Images/sidebarAttachWidgetPressed.png: Removed.
page/inspector/Images/sidebarDetachWidget.png: Removed.
page/inspector/Images/sidebarDetachWidgetPressed.png: Removed.
page/inspector/Images/sidebarResizeWidget.png: Removed.
page/inspector/Images/sidebarStatusAreaBackground.png: Removed.
page/inspector/Images/sourceViewNormal.png: Removed.
page/inspector/Images/sourceViewNormalSelected.png: Removed.
page/inspector/Images/sourceViewSmall.png: Removed.
page/inspector/Images/sourceViewSmallSelected.png: Removed.
page/inspector/Images/tab.png: Removed.
page/inspector/Images/tabSelected.png: Removed.
page/inspector/Images/toggleDown.png: Removed.
page/inspector/Images/toggleUp.png: Removed.
page/inspector/Images/toolbarButtonNormal.png: Removed.
page/inspector/Images/toolbarButtonNormalInactive.png: Removed.
page/inspector/Images/toolbarButtonNormalPressed.png: Removed.
page/inspector/Images/toolbarButtonNormalSelected.png: Removed.
page/inspector/Images/toolbarButtonNormalSelectedInactive.png: Removed.
page/inspector/Images/toolbarButtonSmall.png: Removed.
page/inspector/Images/toolbarButtonSmallInactive.png: Removed.
page/inspector/Images/toolbarButtonSmallPressed.png: Removed.
page/inspector/Images/toolbarButtonSmallSelected.png: Removed.
page/inspector/Images/toolbarButtonSmallSelectedInactive.png: Removed.
page/inspector/Images/toolbarPopupButtonNormal.png: Removed.
page/inspector/Images/toolbarPopupButtonNormalInactive.png: Removed.
page/inspector/Images/toolbarPopupButtonNormalPressed.png: Removed.
page/inspector/Images/toolbarPopupButtonSmall.png: Removed.
page/inspector/Images/toolbarPopupButtonSmallInactive.png: Removed.
page/inspector/Images/toolbarPopupButtonSmallPressed.png: Removed.
page/inspector/Images/toolbarSplitButtonDividerNormal.png: Removed.
page/inspector/Images/toolbarSplitButtonDividerNormalInactive.png: Removed.
page/inspector/Images/toolbarSplitButtonDividerSmall.png: Removed.
page/inspector/Images/toolbarSplitButtonDividerSmallInactive.png: Removed.
page/inspector/Images/treeLeftTriangleBlack.png: Removed.

11:29 AM Changeset in webkit [32400] by andersca@apple.com

6 edits in trunk

WebCore:

2008-04-22 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.

bridge/npapi.h:
bridge/npruntime.h:
plugins/npfunctions.h:

WebKit/mac:

2008-04-22 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.

Plugins/npfunctions.h:

11:19 AM Changeset in webkit [32399] by ggaren@apple.com

1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog

Fixed ChangeLog

10:55 AM Changeset in webkit [32398] by ggaren@apple.com

8 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed ScopeChainNode lifetime problems:

(1) In "with" and "catch" scopes, we would construct a ScopeChain
object and then jump across its destructor, leaking the ScopeChainNode
we had pushed.

(2) In global and eval scopes, we would fail to initially ref
"scopeChain", causing us to overrelease it later. Now that we ref
"scopeChain" properly, we also need to deref it when the script
terminates.

SunSpider reports no change.

10:55 AM Changeset in webkit [32397] by alice.liu@apple.com

3 edits
2 adds in trunk

WebCore:

2008-04-22 Alice Liu <alice.liu@apple.com>

Reviewed by John Sullivan and Adam Roben.

Test: fast/events/tabindex-focus-chain.html

dom/Document.cpp: (WebCore::Document::nextFocusableNode): (WebCore::Document::previousFocusableNode): If the focused node has been removed from the normal tabbing order, advancing focus from this node should advance to the next focusable node in tree order, and not start over at the beginning of the focus chain.

LayoutTests:

2008-04-22 Alice Liu <alice.liu@apple.com>

Reviewed by John Sullivan and Adam Roben.

Test for new behavior when advancing focus from a focusable-by-script node, which now
matches Firefox 2 and 3

fast/events/tabindex-focus-chain-expected.txt: Added.
fast/events/tabindex-focus-chain.html: Added.

9:54 AM Changeset in webkit [32396] by timothy@apple.com

6 edits
1 add in trunk/WebCore

Adds a debugger toggle button to the scripts status bar that will start
and stop debugging of the inspected page.

Reviewed by Adam Roben.

English.lproj/InspectorLocalizedStrings.js: Adds the two new tooltip strings.
page/InspectorController.cpp:

(WebCore::debuggerAttached): Call InspectorController::debuggerAttached.
(WebCore::InspectorController::InspectorController): Initialize
m_debuggerAttached to false.
(WebCore::InspectorController::windowScriptObjectAvailable): Add the debuggerAttached
property to the InspectorController class.
(WebCore::InspectorController::startDebuggingAndReloadInspectedPage):
Set m_debuggerAttached to true.
(WebCore::InspectorController::stopDebugging): Set m_debuggerAttached to false.

page/InspectorController.h:
page/inspector/Images/debuggingButtons.png: Added.
page/inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Disable the pause button. Create the debugging
button and setup the id, className and event listener. Call reset.
(WebInspector.ScriptsPanel.prototype.get statusBarItems): Return an array
(WebInspector.ScriptsPanel.prototype.reset): Call _updateDebuggerButtons.
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Adjust the title of
the debugging button to match what will happen when clicked. Change the style class,
and toggle the disabled state of the pause button.
(WebInspector.ScriptsPanel.prototype._toggleDebugging): Start or stop debugging
depending on InspectorController.debuggerAttached().

page/inspector/inspector.css: Added style rules for the debugger button.

8:19 AM Changeset in webkit [32395] by Adam Roben

2 edits in trunk/WebCore

Change PlatformWheelEvent to use GET_WHEEL_DELTA_WPARAM

Reviewed by Dan Bernstein.

platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use GET_WHEEL_DELTA_WPARAM, which is documented way of getting the wheel delta (it is equivalent to what we were previously doing, however).

8:05 AM Changeset in webkit [32394] by Simon Hausmann

2 edits in trunk/WebCore

Qt build fix.

Adjust the Qt resource file to removed image files.

6:56 AM Changeset in webkit [32393] by timothy@apple.com

2 edits
18 deletes in trunk/WebCore

Use CSS gradients to replace many image files in the Web Inspector.

Rubber-stamped by Adam Roben.

page/inspector/Images/alternateTableRows.png: Removed.
page/inspector/Images/darkShadow.png: Removed.
page/inspector/Images/paneHeader.png: Removed.
page/inspector/Images/paneHeaderActive.png: Removed.
page/inspector/Images/sidebarSelection.png: Removed.
page/inspector/Images/sidebarSelectionBackground.png: Removed.
page/inspector/Images/sidebarSelectionBackgroundFocused.png: Removed.
page/inspector/Images/sidebarSelectionBackgroundInactive.png: Removed.
page/inspector/Images/sidebarSelectionBlurred.png: Removed.
page/inspector/Images/sidebarSelectionBlurredTall.png: Removed.
page/inspector/Images/sidebarSelectionGray.png: Removed.
page/inspector/Images/sidebarSelectionGrayTall.png: Removed.
page/inspector/Images/sidebarSelectionTall.png: Removed.
page/inspector/Images/sidebarSmallSelectionBackground.png: Removed.
page/inspector/Images/sidebarSmallSelectionBackgroundFocused.png: Removed.
page/inspector/Images/sidebarSmallSelectionBackgroundInactive.png: Removed.
page/inspector/Images/toolbarBackground.png: Removed.
page/inspector/Images/toolbarBackgroundInactive.png: Removed.
page/inspector/inspector.css:

5:46 AM Changeset in webkit [32392] by Simon Hausmann

3 edits in trunk/WebCore

Andre Poenitz <andre.poenitz@trolltech.com>

Remove compiler warnings on string literals used to construct QStrings
in webkit.

4:33 AM Changeset in webkit [32391] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Fixes: QWebPage's QNetworkManager's can be shared among webpages.

Don't force the deletion of the object, but let QObject take care of it.

4:27 AM Changeset in webkit [32390] by Simon Hausmann

3 edits in trunk/WebKit/qt

Documentation for QWebPluginFactory and documentation updates for QWebPage.

4:27 AM Changeset in webkit [32389] by Simon Hausmann

5 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Added QWebPage::swallowContextMenuEvent and QWebPage::updatePositionDependentActions.

3:56 AM Changeset in webkit [32388] by Simon Hausmann

4 edits in trunk/WebKit/qt

Added Extension APIs for QWebPage.

3:46 AM Changeset in webkit [32387] by Simon Hausmann

2 edits in trunk/WebKit/qt

Tor Arne Vestbø <tavestbo@trolltech.com>

Emit loadProgress() signal on loadStarted().

3:33 AM Changeset in webkit [32386] by Simon Hausmann

9 edits in trunk/WebKit/qt

Zack Rusin <zack@kde.org>

Fix background propagation from the QWebView's palette.

The background brush of the palette needs to be propagated to the WebCore::FrameView.

3:30 AM Changeset in webkit [32385] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Fix maps.google.com

We have to include a version in the Safari tag in the user-agent.

3:30 AM Changeset in webkit [32384] by Simon Hausmann

2 edits in trunk/WebCore

Tor Arne Vestbø <tavestbo@trolltech.com>

Fall back to last path component for suggested filename if the HTTP content disposition is not set.

3:14 AM Changeset in webkit [32383] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Alexey.

use global object instead of null for "this" on unqualified calls

This fixes 10 more JSC test regressions.

VM/Machine.cpp: (KJS::Machine::privateExecute):

2:36 AM Changeset in webkit [32382] by Simon Hausmann

2 edits in trunk/WebCore

Tor Arne Vestbø <tavestbo@trolltech.com>

Implemented the generation of the title string for images.

2:31 AM Changeset in webkit [32381] by Simon Hausmann

2 edits in trunk/WebKit/qt

Tor Arne Vestbø <tavestbo@trolltech.com>

Add visual focusing hint for clear button and
Change focus to web page after user enters new URL.

1:31 AM Changeset in webkit [32380] by Simon Hausmann

7 edits in trunk/WebKit/qt

Added QWebFrame::hitTestContent() and QWebHitTestResult.

1:31 AM Changeset in webkit [32379] by Simon Hausmann

2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Don't crash if an input method query is done without a page.

1:30 AM Changeset in webkit [32378] by Simon Hausmann

5 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Added re-implementations of QObject::event for future safety.

This makes it easier to fix bugs with the event handling even in patch releases
and is a general style we follow in Qt.

1:19 AM Changeset in webkit [32377] by mjs@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

throw proper exceptions for objects that don't implement call or construct

This fixes 21 more JSC test regressions. It is also seemingly an
0.5% progression.

VM/ExceptionHelpers.cpp: (KJS::createNotAnObjectError): (KJS::createNotAConstructorError): (KJS::createNotAFunctionError):
VM/ExceptionHelpers.h:
VM/Machine.cpp: (KJS::Machine::privateExecute):

12:56 AM Changeset in webkit [32376] by Simon Hausmann