⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 29, 2008:

11:13 PM Changeset in webkit [32719] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=11939
Quirksmode: Ignores media types in stylesheet PIs

Transfer the xml-stylesheet pseudo attribute media to the css
stylesheet created from the ProcessingInstruction.

Tests: fast/css/xml-stylesheet-media-processing.xhtml

10:10 PM Changeset in webkit [32718] by oliver@apple.com
  • 9 edits in branches/squirrelfish/JavaScriptCore

Bug 18643: SQUIRRELFISH: need to support implicit function calls (valueOf, toString, getters/setters)
<​https://bugs.webkit.org/show_bug.cgi?id=18643>

Reviewed by Maciej

Prevent static slot optimisation for new variables and functions in
globally re-entrant code called from an an implicit function call.

This is necessary to prevent us from needing to resize the global
slot portion of the root RegisterFile during an implicit (and hence
unguarded) function call.

8:38 PM Changeset in webkit [32717] by adachan@apple.com
  • 5 edits in trunk/WebKit/win

Support text shadow in WebDrawText().
Remove DrawTextAtPoint() since it is only called by WebDrawText().

Reviewed by Adam.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
  • WebKitGraphics.cpp: (WebDrawText):
  • WebKitGraphics.h:


8:27 PM Changeset in webkit [32716] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref()

On the buildbot, this is a fatal error:

ld: symbols names listed in -exported_symbols_list: WebKitBuild/Release/DerivedSources/WebCore/WebCore.exp not in linked objects
ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv
/usr/bin/libtool: internal link edit command failed

Newer dev tools only produce a warning:

ld warning: cannot export hidden symbol ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv from WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/DocumentLoader.o

  • WebCore.base.exp: Remove hidden symbol from export list.
8:21 PM Changeset in webkit [32715] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

2008-04-29 David D. Kilzer <​ddkilzer@apple.com>

BUILD FIX for Release build.

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent separately so the compiler doesn't complain about an unused variable. (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
7:16 PM Changeset in webkit [32714] by andersca@apple.com
  • 7 edits
    4 adds in trunk/WebKit

WebKit:

2008-04-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Add new event handlers.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-04-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Refactor the Carbon event handling code out into a separate class in preparation for adding
the Cocoa event handling code.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView _viewHasMoved]):
  • Plugins/WebBaseNetscapePluginViewInternal.h:
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEventHandler.h: Added. (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler): (WebNetscapePluginEventHandler::currentEventIsUserGesture): (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
  • Plugins/WebNetscapePluginEventHandler.mm: Added. (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added. (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon): (getCarbonEvent): (modifiersForEvent): (WebNetscapePluginEventHandlerCarbon::sendNullEvent): (WebNetscapePluginEventHandlerCarbon::drawRect): (WebNetscapePluginEventHandlerCarbon::mouseDown): (WebNetscapePluginEventHandlerCarbon::mouseUp): (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseDragged): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::keyDown): (keyMessageForEvent): (WebNetscapePluginEventHandlerCarbon::keyUp): (WebNetscapePluginEventHandlerCarbon::focusChanged): (WebNetscapePluginEventHandlerCarbon::windowFocusChanged): (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired): (WebNetscapePluginEventHandlerCarbon::startTimers): (WebNetscapePluginEventHandlerCarbon::stopTimers): (WebNetscapePluginEventHandlerCarbon::sendEvent):
5:53 PM Changeset in webkit [32713] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Another BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • dom/make_names.pl: Added #if ENABLE(DASHBOARD_SUPPORT) to Dashboard code.
5:31 PM Changeset in webkit [32712] by ddkilzer@apple.com
  • 8 edits in trunk

Top:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • configure.ac: Added conditional for ENABLE_DASHBOARD_SUPPORT.

JavaScriptCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • wtf/Platform.h: Defined ENABLE(DASHBOARD_SUPPORT) to 1 only for PLATFORM(MAC) and PLATFORM(WIN). Changed default to 0 for other ports.

WebCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

  • DerivedSources.make: Removed duplication of targets for generating CSSPropertyNames.h and CSSValueKeywords.h.
  • GNUmakefile.am: Ditto. Added support for ENABLE_DASHBOARD_SUPPORT.
  • WebCore.pro: Added support for ENABLE_DASHBOARD_SUPPORT. Made both SVG and non-SVG variables of GENERATOR 6-A use new DASHBOARDSUPPORTCSSPROPERTIES variable.
5:13 PM Changeset in webkit [32711] by adachan@apple.com
  • 2 edits in trunk/WebCore

Added missing return.

  • platform/win/COMPtr.h: (WTF::):
5:07 PM Changeset in webkit [32710] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-04-29 Alp Toker <​alp@nuanti.com>

GTK+ build fix attempt following breakage in r32700 which
conditionalised dashboard support.

  • GNUmakefile.am:
4:15 PM Changeset in webkit [32709] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.2.1

Versioning.

4:14 PM Changeset in webkit [32708] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.2.1/WebKit/mac

Merge r32706.

4:10 PM Changeset in webkit [32707] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.2.1

New tag.

4:08 PM Changeset in webkit [32706] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

2008-04-29 Mark Rowe <​mrowe@apple.com>

Reviewed by David Harrison.

Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.

  • WebKit.exp:
  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m:
4:00 PM Changeset in webkit [32705] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

2008-04-29 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dan Bernstein.

Modified the SVG test case for RGB and RGBA parsing - mixing percentage and
numerical values is illegal.

  • svg/custom/rgbcolor-syntax.svg:
3:23 PM Changeset in webkit [32704] by Adam Roben
  • 31 edits in trunk

Restore the beloved COMPtr::operator&

WebCore:

Restore the beloved COMPtr::operator&

  • platform/win/COMPtr.h: Removed the HashTableDeletedValueType constructor and isHashTableDeletedValue and hashTableDeletedValue functions. (WTF::): Changed constructDeletedValue to play nicely with COMPtr::operator&.

WebKit/win:

Restore the beloved COMPtr::operator&

WebKitTools:

Restore the beloved COMPtr::operator&

3:03 PM SquirrelFishPerfIdeas edited by ggaren@apple.com
(diff)
2:53 PM Changeset in webkit [32703] by Adam Roben
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog order

2:50 PM Changeset in webkit [32702] by Adam Roben
  • 2 edits in trunk/WebCore

Fix assertion on launch on Windows

  • platform/graphics/win/FontPlatformData.h: Pass WTF::HashTableDeletedValue to the m_font constructor instead of a bogus -1 value. This is needed because m_font is a RefPtr.
2:48 PM Changeset in webkit [32701] by Adam Roben
  • 11 edits in trunk/WebKitTools

Windows build fixes

Replace COMPtr::operator& with COMPtr::adoptionPointer.

2:31 PM Changeset in webkit [32700] by ddkilzer@apple.com
  • 46 edits
    2 adds in trunk

JavaScriptCore:

2008-04-29 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • wtf/Platform.h:

WebCore:

2008-04-29 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • DerivedSources.make:
  • WebCore.DashboardSupport.exp: Added.
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/DashboardRegion.h:
  • css/DashboardSupportCSSPropertyNames.in: Added.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::importNode):
  • dom/Document.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clip):
  • html/CanvasRenderingContext2D.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • page/Chrome.cpp:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
  • page/mac/FrameMac.mm:
  • page/mac/WebDashboardRegion.h:
  • page/mac/WebDashboardRegion.m:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader):

WebKit/mac:

2008-04-29 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebView/WebClipView.m: (-[WebClipView scrollWheel:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView acceptsFirstMouse:]):
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]):
  • WebView/WebViewPrivate.h:
2:07 PM Changeset in webkit [32699] by Adam Roben
  • 20 edits in trunk

Windows build fix

WebCore:

Windows build fix

This removes COMPtr::operator&, which didn't jive with HashTable. It
is replaced by COMPtr::adoptionPointer.

Discussed with Darin Adler and Anders Carlsson.

  • platform/win/COMPtr.h: Replaced operator& with adoptionPointer.

WebKit/win:

Windows build fix

Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.

2:02 PM Changeset in webkit [32698] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a Windows build error

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::variableNames): Don't use ::adopt now that PropertyNameArray has no swap function.
1:49 PM Changeset in webkit [32697] by hyatt@apple.com
  • 1 add in trunk/WebKitSite/blog-files/kate-reflected.png

Add reflection example photo.

1:39 PM Changeset in webkit [32696] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-04-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


In nested program code, don't propogate "this" back to the parent
register file. ("this" should remain constant in the parent register
file, regardless of the scripts it invokes.)

  • VM/RegisterFile.cpp: (KJS::RegisterFile::copyGlobals):
1:34 PM Changeset in webkit [32695] by hyatt@apple.com
  • 26 edits
    23 adds in trunk

WebCore:

2008-04-29 David Hyatt <​hyatt@apple.com>

Implement the new box-reflect property in CSS. This property enables real-time reflections on
objects (yes you can reflect <video>!).

Reviewed by Dan Bernstein

Test cases added in fast/reflections/

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForReflection): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseTransform):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSReflectValue.cpp: Added. (WebCore::CSSReflectValue::cssText):
  • css/CSSReflectValue.h: Added. (WebCore::): (WebCore::CSSReflectValue::CSSReflectValue): (WebCore::CSSReflectValue::direction): (WebCore::CSSReflectValue::offset): (WebCore::CSSReflectValue::mask): (WebCore::CSSReflectValue::setDirection): (WebCore::CSSReflectValue::setOffset): (WebCore::CSSReflectValue::setMask):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapNinePieceImage):
  • css/CSSStyleSelector.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintMask):
  • rendering/Length.h: (WebCore::Length::calcFloatValue):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowLeft): (WebCore::RenderBlock::overflowTop): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::transparencyClipBox): (WebCore::RenderLayer::operator delete): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer): (WebCore::RenderLayer::insertOnlyThisLayer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::reflectionLayer): (WebCore::RenderLayer::createReflection): (WebCore::RenderLayer::updateReflectionStyle):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::reflection): (WebCore::RenderLayer::paintingInsideReflection):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::updateImage): (WebCore::RenderObject::reflectionBox): (WebCore::RenderObject::reflectionOffset):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasReflection): (WebCore::RenderObject::hasReflection):
  • rendering/RenderReplica.cpp: Added. (WebCore::RenderReplica::RenderReplica): (WebCore::RenderReplica::~RenderReplica): (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h: Added. (WebCore::RenderReplica::renderName): (WebCore::RenderReplica::requiresLayer):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::applyTransform):
  • rendering/RenderStyle.h: (WebCore::TranslateTransformOperation::apply): (WebCore::StyleReflection::StyleReflection): (WebCore::StyleReflection::operator==): (WebCore::StyleReflection::operator!=): (WebCore::StyleReflection::direction): (WebCore::StyleReflection::offset): (WebCore::StyleReflection::mask): (WebCore::StyleReflection::setDirection): (WebCore::StyleReflection::setOffset): (WebCore::StyleReflection::setMask): (WebCore::RenderStyle::boxReflect): (WebCore::RenderStyle::setBoxReflect): (WebCore::RenderStyle::initialBoxReflect):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paintMask):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintMask):

LayoutTests:

2008-04-29 David Hyatt <​hyatt@apple.com>

Implement support for the new box-reflect property. Tests of the new property.

Reviewed by Dan Bernstein

  • fast/reflections: Added.
  • fast/reflections/reflection-computed-style-expected.txt: Added.
  • fast/reflections/reflection-computed-style.html: Added.
  • fast/reflections/reflection-direction.html: Added.
  • fast/reflections/reflection-masks.html: Added.
  • fast/reflections/reflection-nesting.html: Added.
  • fast/reflections/resources: Added.
  • fast/reflections/resources/kate.png: Added.
  • fast/reflections/resources/vignette-mask.png: Added.
1:27 PM Changeset in webkit [32694] by Beth Dakin
  • 5 edits in trunk/WebCore

2008-04-29 Beth Dakin <Beth Dakin>

Reviewed by Alice.

Initial implementation of the following ARIA roles: button,
checkbox, heading, link, radio, textbox.

  • html/HTMLAttributeNames.in: Add 'role' to list of attributes.
  • page/AccessibilityObject.cpp: When an ARIA role is set, the role overrides whatever the actual
11:09 AM Changeset in webkit [32693] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-04-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Keep call count.

  • profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::didExecute): Implements call count and fixed a bug where a stackIndex of 0 was causing the assert to be hit. (KJS::FunctionCallProfile::stopProfiling): (KJS::FunctionCallProfile::endAndRecordCall):
  • profiler/FunctionCallProfile.h:
10:36 AM Changeset in webkit [32692] by timothy@apple.com
  • 3 edits in trunk/WebCore

Make the exceptions that the InspectorController catches log the
original file and line number, if present on the exception object.

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::callFunction): Pass the context to HANDLE_EXCEPTION.
(WebCore::InspectorController::~InspectorController): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::updateScriptResourceRequest): Ditto.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
(WebCore::InspectorController::handleException): Take a context. Pull the line
and sourceURL properties off the exception if it is an object.

  • page/InspectorController.h: Change handleException to take a context.
10:12 AM Changeset in webkit [32691] by timothy@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove .idl and .in files from WebCore's framework Resources.

10:05 AM Changeset in webkit [32690] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a regression where the Page's debugger would not be reattached
when a new JSDOMWindow is created.

Reviewed by Sam Weinig.

  • bindings/js/kjs_proxy.cpp:

(WebCore::KJSProxy::clear): Call attachDebugger after creating the JSDOMWindow.

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore): For the case where the CachedPage doesn't
contain a window, reattach the debugger to the new JSDOMWindow by calling
proxy->attachDebugger. Also restore the setPageGroupIdentifier.

9:50 AM Changeset in webkit [32689] by mitz@apple.com
  • 6 edits in trunk

WebCore:

2008-04-29 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18355
Fixed RGB and RGBA parsing to ignore the declaration when the value is not
"either three integer values or three percentage values."

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

LayoutTests:

2008-04-29 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18355
Updated the results of the layout test for "RGB color syntax error handling".

  • platform/mac/css2.1/t040306-syntax-01-f-expected.checksum:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.png:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.txt:
7:41 AM Changeset in webkit [32688] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​zecke@selfish.org>

Fix crash when setHtml gets called from slots connected to QWebPage::unsupportedContent

Ben found this crash in the demo browser.

In void MainResourceLoader::continueAfterContentPolicy(PolicyAction contentPolicy,

case PolicyDownload:

frameLoader()->client()->download(m_handle.get(), request(), m_handle.get()->request(), r);
receivedError(interruptionForPolicyChangeError());

We are in a policy check, the download() call will call setHtml, which will start loading
the data into a frame. The loading will cancel all policy checks and call ResourceLoader::releaseResources
which will set m_frame to 0. Then we return and invoke interruptionForPolicyChangeError() which
will use the m_frame->loader() but it is gone. Do not call into receivedError and
interruptionForPolicyChangeError if we are gone anyway...

7:34 AM Changeset in webkit [32687] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Qt/Windows build fix. The externally declared hash tables are actually
declared const and the const is mangled in the symbol name, so when
importing they also need to be marked const.

When compiling without MULTIPLE_THREADS use a const HashTable&
instead of a HashTable& in ThreadClassInfoHashTables to avoid
initializing the latter with a const reference.

7:16 AM Changeset in webkit [32686] by Simon Hausmann
  • 209 edits in trunk/LayoutTests

Simon Hausmann <Simon Hausmann>

Updated the layout tests after the latest submits to the Qt port
to our new baseline, after numerous fixes in RenderThemeQt
and assorted.

Updated the Skipped file with new expected failures that need
fixing.

2:47 AM Changeset in webkit [32685] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Lincoln Ramsay <​lincoln.ramsay@trolltech.com>

Fix compilation with QT_NO_PRINTER

1:51 AM Changeset in webkit [32684] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Ensure that relative URL is converted to absolute URL.

This is necessary because loading a relative URL is not really supported
(the web page may load, but the subsequent URLs for images and links will
not be resolved properly).
This also fixes ​https://bugs.webkit.org/show_bug.cgi?id=18484

1:51 AM Changeset in webkit [32683] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Simplification of Qt Launcher (no animation and use standard progress bar widget)

Status bar shows the hovered link without any animation. Progress bar just uses the standard QProgressBar (no custom widget). The launcher is leaner and faster to use under the debugger and/or valgrind.

1:51 AM Changeset in webkit [32682] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Update the cursor when the frame/page loading is finished.

This fixes ​https://bugs.webkit.org/show_bug.cgi?id=18712

1:51 AM Changeset in webkit [32681] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Simon Hausmann <​shausman@trolltech.com>

Fixes: QWebPage::acceptNavigationRequest not being called / linkClicked() not being emitted when clicking on <a href="..." target="_blank"> kind of links.

Call QWebPage::acceptNavigationRequest when the creation of a new window with
URL is requested. The frame pointer is set to null in this case.

1:47 AM Changeset in webkit [32680] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​zecke@selfish.org>

Rely on auto-boxing of C++ for the QCursor c'tor

1:47 AM Changeset in webkit [32679] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​zecke@selfish.org>

Add the remaining cursors that defaulted to PointerCursor

1:47 AM Changeset in webkit [32678] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​zecke@selfish.org>

Use the WebCore facility to do the scrolling. Move some code around.

1:42 AM Changeset in webkit [32677] by alice.liu@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-04-29 Alice Liu <​alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

Test: fast/parser/tabindex-parsing.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):

LayoutTests:

2008-04-29 Alice Liu <​alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

  • fast/parser/tabindex-parsing-expected.txt: Added.
  • fast/parser/tabindex-parsing.html: Added.
1:36 AM Changeset in webkit [32676] by Simon Hausmann
  • 3 edits in trunk/WebCore

Fixes: Fix timing problem where scrollbars in subframes were sometimes not property repainted.

​https://bugs.webkit.org/show_bug.cgi?id=18482

We need to repaint scrollbars after a geometry change, and also make sure
the computed clipping rect for the corners between scrollbars is propagated
to the chrome client without beeing intersected by the visible content rect
of the frame.

12:49 AM Changeset in webkit [32675] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.

12:43 AM Changeset in webkit [32674] by Simon Hausmann
  • 6 edits in trunk

Holger Hans Peter Freyther <​zecke@selfish.org>

Calling QWebView::setCursor will override the WebCore Cursor.
Calling QWebView::setCursor will override the WebCore Cursor using
QWidget::unsetCursor will revert to the WebCore Cursor.

For detecting the unset we have to compare the shape of the
cursor to the default arrow. Qt::WA_SetCursor can not be used
as it is set unconditionally but conditionally removed.

Calling QWidget::setCursor will immediately send the CursorChange
event. We listen to this event to decide if we currently use a
WebCore cursor, got a cursor from outside, or revert to the default.

This should be race free and work reliable, the manual test for this
is WebCore/manual-tests/cursor.html

12:34 AM Changeset in webkit [32673] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>

Documentation fixes:

  • Fixed a qdoc warning
  • Mention that fav icons can be of arbitrary size
  • Fix signature of QWebPage::acceptNavigationRequest show in the documentation

Apr 28, 2008:

11:14 PM Changeset in webkit [32672] by rwlbuis@webkit.org
  • 2 edits in trunk/WebKit/mac

Reviewed by Maciej.

Build fix for Tiger.

11:05 PM Changeset in webkit [32671] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Maciej Stachowiak.

  • rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): The loop was doing one extra pass without shadow even in cases where the last pass with a shadow was painting the text at the right position (rather than outside the clip). Fixed that. The only case where a separate pass without shadow is needed is when there is text-stroke, since in that case all shadow passes paint the text outside the clip.

LayoutTests:

Reviewed by Maciej Stachowiak.

  • platform/mac/fast/css/shadow-multiple-expected.checksum:
  • platform/mac/fast/css/shadow-multiple-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
10:53 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
10:51 PM SquirrelFishPerfIdeas edited by mjs@apple.com
(diff)
10:30 PM SquirrelFishPerfIdeas edited by ggaren@apple.com
(diff)
9:10 PM Changeset in webkit [32670] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Restore base pointer when popping a global RegisterFile

Reviewed by Geoff

8:57 PM Changeset in webkit [32669] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Bug 18643: SQUIRRELFISH: need to support implicit function calls (valueOf, toString, getters/setters)
<​https://bugs.webkit.org/show_bug.cgi?id=18643>

Reviewed by Geoff

Partial fix. This results in all implicit calls to toString or valueOf
executing in a separate RegisterFile, so ensuring that the the pointers
in the triggering interpreter don't get trashed. This still leaves the
task of preventing new global re-entry from toString and valueOf from
clobbering the RegisterFile.

8:14 PM Changeset in webkit [32668] by beidson@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

2008-04-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Add Storage.clear(), per updates to HTML5

Tests: storage/domstorage/localstorage/clear.html

storage/domstorage/sessionstorage/clear.html

  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::areaCleared):
  • storage/LocalStorageArea.h:
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::areaCleared):
  • storage/SessionStorageArea.h:
  • storage/Storage.cpp: (WebCore::Storage::clear):
  • storage/Storage.h:
  • storage/Storage.idl:
  • storage/StorageArea.cpp: (WebCore::StorageArea::internalClear):
  • storage/StorageArea.h: (WebCore::StorageArea::clear):

LayoutTests:

2008-04-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Add Storage.clear(), per updates to HTML5

  • storage/domstorage/localstorage/clear-expected.txt: Added.
  • storage/domstorage/localstorage/clear.html: Added.
  • storage/domstorage/sessionstorage/clear-expected.txt: Added.
  • storage/domstorage/sessionstorage/clear.html: Added.
6:54 PM Changeset in webkit [32667] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Simplified activation object a bit: No need to store the callee
in the activation object -- we can pull it out of the call frame
when needed, instead.


SunSpider reports no change.

6:30 PM Changeset in webkit [32666] by adele@apple.com
  • 21 edits in trunk

WebCore:

2008-04-28 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.

WebCore part of fix for <rdar://problem/3709505>
Safari should have a way to upload bundles from the file upload control (as zip)

  • WebCore.base.exp: Added symbols.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ask the application if a file will need to be replaced before it's uploaded. It will also give the replacement filename which is used to determine the correct mime-type and to construct the correct header.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Asks the application to generate any files for the form data before a form submission starts. (WebCore::FrameLoader::loadItem): ditto.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): Tells the FormData from the request to remove any generated files if it needs to. (WebCore::ResourceLoader::didCancel): ditto. (WebCore::ResourceLoader::didFail): ditto.
  • platform/network/FormData.cpp: (WebCore::FormData::FormData): Initializes m_hasGeneratedFiles, which keeps track of whether there are files that will need to be removed. (WebCore::FormData::~FormData): Added. Assert that there are no files that need to be removed, but if there are, release builds will still remove them here. (WebCore::FormData::appendFile): Passes along a shouldGenerateFile flag to the FormDataElement. (WebCore::FormData::generateFiles): Added. Iterates through the FormDataElements, and using the ChromeClient pointer, asks the application to create any compressed files so the FormDataElements can store the paths. (WebCore::FormData::removeGeneratedFilesIfNeeded): Added. Removes generated files and their directories (if empty).
  • platform/network/FormData.h: (WebCore::FormDataElement::FormDataElement): Added a boolean to track whether the file will need to be generated, and a string to hold the path of the generated file.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Uses the generated file path instead of the original file path when streaming the file. (WebCore::setHTTPBody): Uses the generated file path when determining the size of the file to be uploaded.
  • platform/FileSystem.h: Added directoryName.
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::directoryName): Added.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::directoryName): Added empty implementation.
  • platform/qt/FileSystemQt.cpp: (WebCore::directoryName): ditto.
  • platform/win/FileSystemWin.cpp: (WebCore::directoryName): ditto.
  • platform/wx/FileSystemWx.cpp: (WebCore::directoryName): ditto.

Added new ChromeClient methods to give the application control over the file compression for uploading.

  • page/Chrome.cpp: (WebCore::ChromeClient::shouldReplaceWithGeneratedFileForUpload): Added a default implementation. (WebCore::ChromeClient::generateReplacementFile): ditto.
  • page/ChromeClient.h:

WebKit/mac:

2008-04-28 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.

WebKit part of fix for <rdar://problem/3709505>
Safari should have a way to upload bundles from the file upload control (as zip)

Added UIDelegate methods to let the application handle generating replacement files for uploads.
In this case, Safari will create archived files for bundles so they can be uploaded properly.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]): (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldReplaceWithGeneratedFileForUpload): (WebChromeClient::generateReplacementFile):
  • WebView/WebUIDelegatePrivate.h:
6:28 PM Changeset in webkit [32665] by andersca@apple.com
  • 6 edits in trunk

WebCore:

2008-04-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam, Mark, Adele and Darin.

Add a (currently not called) method for opening the application cache database.


  • WebCore.base.exp:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::setCacheDirectory): (WebCore::ApplicationCacheStorage::openDatabase):
  • loader/appcache/ApplicationCacheStorage.h:

WebKit/mac:

2008-04-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam, Mark, Adele and Darin.

Initialize the application cache path.


  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _commonInitializationWithFrameName:groupName:]):
6:18 PM Changeset in webkit [32664] by alice.liu@apple.com
  • 34 edits
    8 adds in trunk

WebCore:

2008-04-28 Alice Liu <​alice.liu@apple.com>

Reviewed by Darin.

Fix <rdar://problem/4911289> Add tabindex property to all children
of HTMLElement (7138)
​http://bugs.webkit.org/show_bug.cgi?id=7138

Test: fast/events/tabindex-focus-blur-all.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h: -DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h are no longer needed
  • bindings/objc/PublicDOMInterfaces.h: -Moving focus, blur, tabindex to HTMLElement from its descendants.
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::isFocusable): (WebCore::Node::isKeyboardFocusable): -The concept of being focusable now needs to account for tabindex attribute.
  • dom/Node.h: -Need to use a bit to keep track of whether tabindex was explicitly set to 0 or was just initialized to 0. (WebCore::Node::tabIndex): -Make this virtual so that Anchors and GenericFormElements can determine tabindex without accounting for focusability (WebCore::Node::setTabIndexExplicitly): -Renamed setTabIndex() to setTabIndexExplicitly() so as not to hide behind and/or be confused for HTMLElement::setTabIndex
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAnchorElement.h: (WebCore::HTMLAnchorElement::tabIndex):
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::tabIndex): -Anchors and form elements are normally focusable, and need to avert the check for focusability in HTMLElement::tabIndex because tabIndex could be queried before a first layout happens.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): -Function Node::setTabIndex changed to Node::setTabIndexExplicitly (WebCore::HTMLElement::isFocusable): -The concept of being focusable now needs to account for tabindex attribute. (WebCore::HTMLElement::tabIndex): -HTML5 specifies that querying tabindex for elements that aren't focusable shall return -1 (WebCore::HTMLElement::setTabIndex): -New default implementation
  • html/HTMLElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::focus): -Now with HTML5's enhanced specification of tabindex, legend elements themselves shall focus (if they should), and not the first form element they encapsulate. This matches Firefox behavior. HTMLLabelElements still forward focus to the encapsulated element. This also matches other browsers.
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::isFocusable):
  • html/HTMLAreaElement.h: -HTMLAreaElement isn't subject to the same focusability requirements as its parent, HTMLAnchorElement. Default HTMLElement implementation is desired.
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::isFocusable):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::isFocusable):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::isFocusable):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::isFocusable): -These elements aren't subject to the same focusability requirements as their parent, HTMLGenericFormElement. Default HTMLElement implementation is desired.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl: -Moving tabindex attribute, focus and blur methods from descendants of HTMLElement to HTMLElement

WebKit/mac:

2008-04-28 Alice Liu <​alice.liu@apple.com>

Reviewed by Darin.

Fix <rdar://problem/4911289> Add tabindex property to all children
of HTMLElement (7138)
​http://bugs.webkit.org/show_bug.cgi?id=7138

  • MigrateHeaders.make: Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h because now that focus() has been moved to DOMHTMLElement.h, these files are no longer needed.

LayoutTests:

2008-04-28 Alice Liu <​alice.liu@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/4911289> Add tabindex property to all children
of HTMLElement (7138)
​http://bugs.webkit.org/show_bug.cgi?id=7138

minor updates to these existing tests:

  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
  • fast/events/resources/abe.png: Added.
  • fast/events/resources/tabindex-focus-blur-all-frame1.html: Added.
  • fast/events/resources/tabindex-focus-blur-all-frame2.html: Added.
  • fast/events/resources/tabindex-focus-blur-all-iframe1.html: Added.
  • fast/events/resources/tabindex-focus-blur-all-iframe2.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js: Added.
  • fast/events/tabindex-focus-blur-all-expected.txt: Added.
  • fast/events/tabindex-focus-blur-all.html: Added.
5:26 PM Changeset in webkit [32663] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


RS by Oliver Hunt on moving JSArguments.cpp out of AllInOneFile.cpp.

Substantially more handling of "arguments": "arguments" works fully
now, but "f.arguments" still doesn't work.

Fixes 10 regression tests.


SunSpider reports no regression.

  • kjs/JSActivation.cpp: (KJS::JSActivation::createArgumentsObject): Reconstruct an arguments List to pass to the arguments object constructor.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp: Removed JSActivation.cpp from AllInOneFile.cpp because that seems to make GCC happy. (Previously, I had added JSActivation.cpp to AllInOneFile.cpp because *that* seemed to make GCC happy. So it goes.)
4:39 PM Changeset in webkit [32662] by ggaren@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-04-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Groundwork for more handling of "arguments". I'm not checking in the
actual handling of "arguments" yet, because it still needs a little
fiddling to avoid a performance regression.


SunSpider reports no change.

  • VM/Machine.cpp: (KJS::initializeCallFrame): Put argc in the register file, so the arguments object can find it later, to determine arguments.length.
  • kjs/nodes.h: (KJS::FunctionBodyNode::): Added a special code accessor for when you know the code has already been generated, and you don't have a scopeChain to supply for potential code generation. (This is the case when the activation object creates the arguments object.)
4:04 PM Changeset in webkit [32661] by oliver@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

Replace unsafe use of auto_ptr in Vector with manual memory
management.

Reviewed by Geoff

2:28 PM Changeset in webkit [32660] by mitz@apple.com
  • 15 edits
    20 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • support multiple box- and text-shadows

Tests: fast/css/shadow-multiple.html

fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): Changed to account for reversing the order of the shadow values in the ShadowData list.
  • css/CSSValueList.cpp: (WebCore::CSSValueList::prepend): Added.
  • css/CSSValueList.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Changed to account for all shadows in overflow calculation. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Changed to account for all shadows when testing for intersection with the damage rect. (WebCore::InlineFlowBox::paintTextDecorations): Changed to paint all shadows.
  • rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): Factored out from paint() and changed to paint all shadows. (WebCore::InlineTextBox::paint): Moved the text painting code out to paintTextWithShadows(). Changed to not paint shadows for markers and composition underlines and in "force black text" mode. (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): Changed to paint all shadows.
  • rendering/InlineTextBox.h: Changed some public methods to private or protected.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Changed to account for all shadows. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBoxShadow): Changed to paint all shadows. Changed to avoid clipping out the box if it has a fully opaque background. (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Changed to account for all shadows. (WebCore::RenderObject::selectionForegroundColor): Cleaned up. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Changed to account for all shadows.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Ditto.
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Changed to prepend when adding so that the stacking order of shadows when painting will be "first o top". (WebCore::RenderStyle::setBoxShadow): Ditto.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Changed to account for all shadows.

LayoutTests:

Reviewed by Dave Hyatt.

  • add rendering and invalidation tests for multiple shadows
  • fast/css/shadow-multiple.html: Added.
  • fast/repaint/shadow-multiple-horizontal.html: Added.
  • fast/repaint/shadow-multiple-strict-horizontal.html: Added.
  • fast/repaint/shadow-multiple-strict-vertical.html: Added.
  • fast/repaint/shadow-multiple-vertical.html: Added.
  • platform/mac/fast/css/shadow-multiple-expected.checksum: Added.
  • platform/mac/fast/css/shadow-multiple-expected.png: Added.
  • platform/mac/fast/css/shadow-multiple-expected.txt: Added.
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.txt: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.txt: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.txt: Added.
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.txt: Added.
12:47 PM Changeset in webkit [32659] by Adam Roben
  • 2 edits in trunk/WebCore

Fix some more Windows build errors in COMPtr

  • platform/win/COMPtr.h: (WTF::): Define DefaultHash<COMPtr<P> > by using PtrHash<COMPtr<P> >, which is just a copy of PtrHash<RefPtr<P> >.
12:39 PM Changeset in webkit [32658] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix some Windows build errors in WebKit

  • Interfaces/WebKit.idl: Touched to force Interfaces to rebuild.
  • WebKitPrefix.cpp: Touched to force WebKit to rebuild.
12:28 PM Changeset in webkit [32657] by Adam Roben
  • 2 edits in trunk/WebCore

Fix some Windows build errors in COMPtr

  • platform/win/COMPtr.h: Explicitly name the WTF namespace when using HashTableDeletedValueType.
12:22 PM Changeset in webkit [32656] by Adam Roben
  • 2 edits in trunk/WebCore

Fix some Windows build errors in FontPlatfomrData

  • platform/graphics/win/FontPlatformData.h: Removed the Deleted constructor and replaced it with a HashTableDeletedValueType constructor. Also added isHashTableDeletedValue() and hashTableDeletedFontValue().
12:14 PM Changeset in webkit [32655] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-04-28 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=18780

Canvas can't draw itself into its own buffer. Make sure the dirtying call comes after the image()
has been accessed. Technically willDraw should be renamed to didDraw and all calls should be moved
to after draws have occurred (since if the draw op itself wants to reference the image it shouldn't get
a dirty copy either), but I'll take that up with olliej when he wakes up. :)

Reviewed by Dan Bernstein

Added fast/canvas/canvasDrawsIntoSelf.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

2008-04-28 David Hyatt <​hyatt@apple.com>

Add layout test for canvas self-drawing bug.

Reviewed by Dan Bernstein

  • fast/canvas/canvasDrawingIntoSelf.html: Added.
  • platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
12:12 PM Changeset in webkit [32654] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/ExecState.h: For whatever reason, MSVC couldn't generate a default constructor for a struct that had a "const List" member. Removing the const qualifier makes the problem go away.
11:58 AM Changeset in webkit [32653] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

<rdar://problem/5825192> Replace use of Gestalt with BSD sysctl

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable): There is no need to check QuickTime version post-Tiger, as it will never be below 7.3 again. This change may make library loading happen earlier in some cases, hopefully, that's not a big deal.
11:22 AM Changeset in webkit [32652] by ap@webkit.org
  • 64 edits in trunk

Reviewed by Darin.

Fix run-webkit-tests --threading
and provisionally fix <​https://bugs.webkit.org/show_bug.cgi?id=18661>
Proxy server issue in Sunday's Nightly

Changed ClassInfo objects for built-in objects to hold a getter function returning
a per-thread instance. This makes it safe to share these ClassInfo objects between threads -
and these are the only ones that need to be shared.

11:15 AM Changeset in webkit [32651] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-04-28 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=18779

The arguments in drawImage were reversed when I switched away from the image buffer method.

Reviewed by Tim Hatcher

Added fast/canvas/drawImage.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

2008-04-28 David Hyatt <​hyatt@apple.com>

Add layout test for canvas.

Reviewed by Tim Hatcher

  • fast/canvas/drawImage.html: Added.
  • platform/mac/fast/canvas/drawImage-expected.checksum: Added.
  • platform/mac/fast/canvas/drawImage-expected.png: Added.
  • platform/mac/fast/canvas/drawImage-expected.txt: Added.
10:18 AM Changeset in webkit [32650] by Darin Adler
  • 7 edits in trunk/JavaScriptCore

2008-04-28 Darin Adler <Darin Adler>

Reviewed by Adam.

  • make sure RefPtr's default hash doesn't ref/deref when computing the hash
  • remove remnants of the hash table storage type optimization
  • wtf/HashFunctions.h: Used "using" to get the hash and equal functions from PtrHash<P*> into PtrHash<RefPtr<P>>.
  • wtf/HashMap.h: Replaced uses of PairBaseHashTraits with PairHashTraits. Eliminated storage-related typedefs. Removed constructor, destructor, copy constructor, and destructor since the compiler-generated ones are fine. Removed refAll and derefAll. Took out unnnecessary typecasts. Removed use of RefCounter.
  • wtf/HashSet.h: Eliminated storage-related typedefs. Removed constructor, destructor, copy constructor, and destructor since the compiler-generated ones are fine. Removed refAll and derefAll. Removed unneeded template arguents from HashSetTranslatorAdapter. Eliminated unneeded HashSetTranslator template.
  • wtf/HashTable.h: Tweaked formatting. Removed NeedsRef, RefCounterBase, RefCounter, HashTableRefCounterBase, HashTableRefCounter, and Assigner class templates.
  • wtf/HashTraits.h: Removed StorageTraits, needsRef, PairBaseHashTraits, and HashKeyStorageTraits.
  • wtf/RefPtrHashMap.h: Made all the same fixes as in HashMap. Also made the corresponding changes to RefPtrHashMapRawKeyTranslator.
10:06 AM Changeset in webkit [32649] by Darin Adler
  • 2 edits in trunk/WebKitLibraries

2008-04-28 Darin Adler <Darin Adler>

Reviewed by Adam.

  • fix Windows build
  • win/tools/vsprops/common.vsprops: Add warning 4344 to the list of disabled warnings. It's really a warning about a bug they fixed in MSVC -- not helpful to us in WebKit.
9:54 AM Changeset in webkit [32648] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-04-28 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • fix assertion hit every time you view www.apple.com
  • kjs/PropertyNameArray.cpp: (KJS::PropertyNameArray::add): Changed assertion to allow null and empty strings. Now to find out why we have a property named "" and if that's a bug!
8:25 AM Changeset in webkit [32647] by Simon Hausmann
  • 3 edits
    4 adds in trunk

Holger Hans Peter Freyther <​zecke@selfish.org>

Fix the crash on ​http://www.orad.pl. We called end too early.

  1. we need a ::write that will pause the parser due a pending script
  2. we need a second write to queue data (tricky part)
  3. we need to get a finish call (document loaded)
  4. we resume the script and parse, schedule loading of a new script and have called end
  5. we resume the new script and we get a crash

This bug is hard to trigger, e.g. if the web server is only allowing
one connection per client/IP. This is why we need to sleep in the scripts. We
want to make sure that the page is first fully received before serving the
scripts.

8:24 AM Changeset in webkit [32646] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

Holger Hans Peter Freyther <​zecke@selfish.org>

Update the Skipped list, we pass most of the http/tests/misc

8:24 AM Changeset in webkit [32645] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Holger Hans Peter Freyther <​zecke@selfish.org>

Reset dumping resource load callbacks to false for the next test

8:14 AM Changeset in webkit [32644] by Simon Hausmann
  • 2 edits in trunk/WebCore

Ariya Hidayat <​ahidayat@trolltech.com>

Fix rounded corner on combo box with CSS border

8:14 AM Changeset in webkit [32643] by Simon Hausmann
  • 13 edits in trunk

Tor Arne Vestbø <​tavestbo@trolltech.com>

Fix QWebView::loadFinished isn't always emitted

Replaced loadDone() with loadFinished(bool) and moved the signals for progress
tracking (start, progres, and finish) to the page instead of the frame. This
ensures that we emit loadFinished even when a subframe started the actual load.

This causes a few regressions in the layout tests that we for now accept for
the sake of the correct API. Layout tests we can fix any time though, including
patch release, the API however we can't change anymore in patch releases.

8:09 AM Changeset in webkit [32642] by Simon Hausmann
  • 2 edits in trunk/WebCore

Ariya Hidayat <​ahidayat@trolltech.com>

Fix CSS border does not show up for combo boxes

Do not clear the border when painting the combo box for 'select' form element

8:09 AM Changeset in webkit [32641] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>

Added more documentation for QWebSettings, QWebPluginFactory and QWebFrame

8:09 AM Changeset in webkit [32640] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ahidayat@trolltech.com>

Fix document/frame title not reset when loading a new URI

We should assume first the frame has no title. If it has, then the dispatchDidReceiveTitle()
will be called very soon with the correct title.
This properly resets the title when we navigate to a URI without a title.

8:08 AM Changeset in webkit [32639] by Simon Hausmann
  • 2 edits in trunk/WebCore

Olivier Goffart <​ogoffart@trolltech.com>

Avoid comparing to 0 in qFuzzyCompare for increased
numeric stability.

7:51 AM Changeset in webkit [32638] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Minor documentation changes.

7:51 AM Changeset in webkit [32637] by Simon Hausmann
  • 2 edits in trunk/WebCore

Benjamin Meyer <​bmeyer@trolltech.com>

Fixes: Pages returning 404 with content are not displayed.

A web page that returns 404 can still have content.

7:50 AM Changeset in webkit [32636] by Simon Hausmann
  • 2 edits in trunk/WebCore

Paul Olav Tvete <​paul@trolltech.com>

Fix compiler warning

7:29 AM Changeset in webkit [32635] by Simon Hausmann
  • 4 edits in trunk

Tor Arne Vestbø <​tavestbo@trolltech.com>

Prevent middle-click from triggering open URL from clipboard when the event has already been accepted.

7:29 AM Changeset in webkit [32634] by Simon Hausmann
  • 5 edits in trunk

Tor Arne Vestbø <​tavestbo@trolltech.com>

Fix scrollbar behavior in QtWebKit to match QScrollBar.

Right click context menu is now supported, along with
middle click to center slider thumb over mouse cursor.

7:24 AM Changeset in webkit [32633] by Simon Hausmann
  • 5 edits
    1 add in trunk

Tor Arne Vestbø <​tavestbo@trolltech.com>

Implemented channel-based logging for QtWebKit.

Comma-separated log channels are read from the QT_WEBKIT_LOG environment variable.
Warnings for notImplemented() is still output by default, but can be disabled
by setting DISABLE_NI_WARNINGS=1.

6:52 AM Changeset in webkit [32632] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Simon Hausmann <​shausman@trolltech.com>

Removed setHtml(const QByteArray &) overload as it breaks the common use of the setHtml() API.

6:52 AM Changeset in webkit [32631] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>

Doc - adding more documentation to QWebFrame, QWebPage and QWebView

6:50 AM Changeset in webkit [32630] by Simon Hausmann
  • 4 edits in trunk

Simon Hausmann <​shausman@trolltech.com>

Fixes: Popups/Context menu in WebKit appearing at the wrong location when embedded in the graphics view or using multiple screens

Give the popups the right parent widget and the right coordinates relative within the parent.

6:45 AM Changeset in webkit [32629] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Doc: Add see also's (and a few minor whitespace/typo corrections)

6:45 AM Changeset in webkit [32628] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>

Submitting more documentation for QWebPage

6:45 AM Changeset in webkit [32627] by Simon Hausmann
  • 2 edits in trunk/WebCore

Tor Arne Vestbø <​tavestbo@trolltech.com>

Fixes: Tabbing to a checkbox/button doesn't work on Win/X11

Respect platform settings for tabbing to all controls.

6:45 AM Changeset in webkit [32626] by Simon Hausmann
  • 2 edits in trunk/WebCore

Tor Arne Vestbø <​tavestbo@trolltech.com>

First part of the fix for tabbing to a checkbox/button doesn't work on Win/X11

Draw controls instead of pimitive elements, to get focus rects for free.

6:44 AM Changeset in webkit [32625] by Simon Hausmann
  • 5 edits in trunk

Lincoln Ramsay <​lincoln.ramsay@trolltech.com>

Compile when QT_NO_CLIPBOARD is defined.

6:44 AM Changeset in webkit [32624] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Minor documentation fix.

6:34 AM Changeset in webkit [32623] by Simon Hausmann
  • 3 edits in trunk/WebCore

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Draw the arrow button on the styled combo box using the fallback ("Windows") style

6:30 AM Changeset in webkit [32622] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix positioning of native widgets (plugins).

Correctly convert the coordinates of the Widget in Widget::setFrameGeometry()
to be relative to the containing toplevel QWidget using convertToContainingWindow().

Note: convertToContainingWindow() takes child coordinates.

6:30 AM Changeset in webkit [32621] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​zecke@selfish.org>

plugins: fix scrolling issues

When scrolling you can see artefacts that remain on the screen, they
seem to originate from the backingstore handling. I'm not entirely sure
where they come from, my workarounds involved a
data->m_widget->parentWidget()->update() call in Widget::geometryChanged or
handling widgets with a native QWidget embedded like web pages with a
static background. This needs more investigations, I think the ScrollView
change is cleaner than the brute force in Widget::geometryChanged

Focus handling seems to be broken as well and needs further work, we don't
clip plugin QWidgets and they can draw out of their bounds, e.g. on the ScrollBar,
the z-order is likely not honored as well.

6:29 AM Changeset in webkit [32620] by Simon Hausmann
  • 1 edit
    3 adds in trunk/WebCore

Holger Hans Peter Freyther <​zecke@selfish.org>

Add manual test to test placement of QWidgets in iframe's

6:29 AM Changeset in webkit [32619] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​zecke@selfish.org>

Implement QWebPage::createPlugin

The code is coming from the demo browser and needed here
for some manual tests.

4:59 AM Changeset in webkit [32618] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Qt/Win build fix. Include config.h to get the implicit MathExtras.h
inclusion correct with regards to rand_s.

4:21 AM Changeset in webkit [32617] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the build with ENABLE_DATABASE=0 (Qt/Windows) by including
SecurityOrigin.h. It's used in the file and also implicitly included
through the database headers.

3:52 AM Changeset in webkit [32616] by Simon Hausmann
  • 2 edits in trunk/WebCore

Prospective Wx build fix.

3:52 AM Changeset in webkit [32615] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-28 Simon Hausmann <Simon Hausmann>

Reviewed by Alp.

Gtk build fix, similar to the changes done in r32609.

3:24 AM Changeset in webkit [32614] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-04-28 Simon Hausmann <Simon Hausmann>

Prospective build fix. After r32609 it seems the workaround here
is not needed anymore. With gcc 4.2/4.3 before 32609 the workaround
is needed for compilation, after 32609 compilation only succeeds
without the workaround.

  • plugins/PluginPackage.h: Removed workaround of extra StorageTraits specification for the custom hash function of PluginPackage used in PluginSet.
3:10 AM Changeset in webkit [32613] by Simon Hausmann
  • 6 edits in trunk

2008-04-28 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18713

Fix scrollbar painting issues in QtWebKit.

Hovering and click-draging outside of the scrollbar would
produce unexpected and inconcistent results. We also didn't
pass on leave-events to the underlying WebKit code, which
was nessecary to implement the paint fix.

12:41 AM Changeset in webkit [32612] by oliver@apple.com
  • 8 edits
    1 add in trunk

Bug 17173: HTML5 Canvas API requires us to ignore certain operations
<​https://bugs.webkit.org/show_bug.cgi?id=17173>

Reviewed by Maciej

This fixes the semantics of a number of Canvas functions to match
the new HTML5 non-throwing semantics.

Test: fast/canvas/canvas-path-with-inf-nan-dimensions.html

Note: See TracTimeline for information about the timeline view.