Context Navigation

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (PluginTimer::PluginTimer): (PluginTimer::start): (PluginTimer::fired): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView eventModel]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebBaseNetscapePluginView unscheduleTimer:]):
Plugins/WebBaseNetscapePluginViewInternal.h:
Plugins/WebBaseNetscapePluginViewPrivate.h:
Plugins/WebNetscapePluginEventHandler.h:
Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
Plugins/WebNetscapePluginEventHandlerCarbon.h:
Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::scrollWheel): (WebNetscapePluginEventHandlerCarbon::flagsChanged): (WebNetscapePluginEventHandlerCarbon::platformWindow):
Plugins/WebNetscapePluginEventHandlerCocoa.h: Added. (WebNetscapePluginEventHandlerCocoa::startTimers): (WebNetscapePluginEventHandlerCocoa::stopTimers):
Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added. (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::mouseDown): (WebNetscapePluginEventHandlerCocoa::mouseDragged): (WebNetscapePluginEventHandlerCocoa::mouseEntered): (WebNetscapePluginEventHandlerCocoa::mouseExited): (WebNetscapePluginEventHandlerCocoa::mouseMoved): (WebNetscapePluginEventHandlerCocoa::mouseUp): (WebNetscapePluginEventHandlerCocoa::scrollWheel): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::keyUp): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged): (WebNetscapePluginEventHandlerCocoa::platformWindow): (WebNetscapePluginEventHandlerCocoa::sendEvent):
Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
Plugins/npapi.m: (NPN_ScheduleTimer): (NPN_UnscheduleTimer):
Plugins/npfunctions.h:

5:08 PM Changeset in webkit [32751] by Beth Dakin

2 edits in trunk/WebCore

2008-04-30 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

This patch does three things:

Adds support for the "img" ARIA role
Switches over to a HashMap for converting ARIA role attributes to WebCore's AccessibilityRole type.
Fixes a crash in the new ARIA code that I ran into while browsing with VoiceOver enabled.

page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::headingLevel): This is the crash fix. Make sure the node's renderer is not null before looking up its corresponding AccessibilityObject in the cache. (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for ARIA images. (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to the Map. (WebCore::RoleEntry::): Same. (WebCore::ariaRoleToWebCoreRole): Same. (WebCore::AccessibilityObject::ariaRoleAttribute): Same.

4:16 PM Changeset in webkit [32750] by beidson@apple.com

2 edits in trunk/WebKit/mac

2008-04-30 Brady Eidson <beidson@apple.com>

Fix my WebPreferences revert check-in

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

4:11 PM Changeset in webkit [32749] by ggaren@apple.com

7 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more ExecState refactoring: Now, only the global object creates
an ExecState.

Also inlined ExecState::lexicalGlobalObject().

SunSpider reports no change.

3:37 PM Changeset in webkit [32748] by ggaren@apple.com

2 edits in branches/squirrelfish/WebKit/mac

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: #ifdef'd out some code that doesn't work anymore.

3:33 PM Changeset in webkit [32747] by ggaren@apple.com

5 edits in branches/squirrelfish/WebCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: supply a parameter that used to be implicit to
Interpreter::evaluate.

3:33 PM Changeset in webkit [32746] by beidson@apple.com

2 edits in trunk/WebKit/mac

2008-04-30 Brady Eidson <beidson@apple.com>

Rubberstamped by John Sullivan

Revert the remainder of my original preferences changes from last week.
They caused a massive PLT regression (too many notifications being sent out
or listened to that weren't previously) and it's not in my schedule to refine
the preferences code instead of working on my feature!

WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): (-[WebView _commonInitializationWithFrameName:groupName:]):

3:25 PM Changeset in webkit [32745] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

WebCore build fix: forward-declare ScopeChain.

kjs/interpreter.h:

3:23 PM Changeset in webkit [32744] by ggaren@apple.com

2 edits in branches/squirrelfish/WebCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: #ifdef'd out some code that doesn't work anymore.

bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):

3:10 PM Changeset in webkit [32743] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptGlue

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix: supply missing parameter that used to be implicit.

JSRun.cpp: (JSRun::Evaluate):

3:10 PM Changeset in webkit [32742] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Build fix for JavaScriptGlue: export a missing symbol.

JavaScriptCore.exp:

3:09 PM Changeset in webkit [32741] by ggaren@apple.com

2 edits in branches/squirrelfish/WebKit/mac

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

#ifdef'd out some debugger code that doesn't work anymore.

WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):

2:52 PM Changeset in webkit [32740] by andersca@apple.com

5 edits in trunk/WebKit/mac

2008-04-30 Anders Carlsson <andersca@apple.com>

Fix the 64-bit build.

Plugins/WebNetscapePluginEventHandler.h:
Plugins/WebNetscapePluginEventHandler.mm:
Plugins/WebNetscapePluginEventHandlerCarbon.h:
Plugins/WebNetscapePluginEventHandlerCarbon.mm:

1:49 PM Changeset in webkit [32739] by ggaren@apple.com

22 edits
2 deletes in branches/squirrelfish/JavaScriptCore

2008-04-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a lot of unused bits from ExecState, moving them into
OldInterpreterExecState, the fake scaffolding class.

The clutter was making it hard to see the forest from the trees.

.4% SunSpider speedup, probably because ExecState::lexicalGlobalObject()
is faster now.

1:47 PM Google Summer of Code 2008 edited by ddkilzer@apple.com

(diff)

1:36 PM Changeset in webkit [32738] by rwlbuis@webkit.org

5 edits
10 adds in trunk

Reviewed by Nikolas.

https://bugs.webkit.org/show_bug.cgi?id=16447
onload called too many times for <svg:image>
https://bugs.webkit.org/show_bug.cgi?id=12282
SVG wastes time in malloc to send loadEvents to non-existent listeners

Postpone load event dispatching for image when externalResourcesRequired is true, delaying parents but not siblings, and make sure the load event is sent once for image in all cases.

1:21 PM Changeset in webkit [32737] by hyatt@apple.com

5 edits
4 adds in trunk

WebCore:

2008-04-30 David Hyatt <hyatt@apple.com>

Fix crashes when dynamically removing <video> elements with layers that establish stacking contexts. This
won't typically crash release builds because of arena recycling.

Reviewed by Dan Bernstein

rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Make sure to remove the reflection's child layer from its parent.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::~RenderMedia): (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::removeChild):
rendering/RenderMedia.h: Adjust the teardown of RenderMedia so that it does all of its teardown inside destroy() (this makes it more like other renderers and doesn't leave you staring at a trashed layer hierarchy in the RenderMedia destructor).

LayoutTests:

2008-04-30 David Hyatt <hyatt@apple.com>

Add test for video crasher.

Reviewed by Dan Bernstein

media/video-layer-crash.html: Added.
platform/mac/media/video-layer-crash-expected.checksum: Added.
platform/mac/media/video-layer-crash-expected.png: Added.
platform/mac/media/video-layer-crash-expected.txt: Added.

11:00 AM Changeset in webkit [32736] by rwlbuis@webkit.org

2 edits in trunk

Fix the ChangeLogs so it includes the details about r32719.

10:57 AM Changeset in webkit [32735] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Adding Radar link

10:55 AM Changeset in webkit [32734] by mitz@apple.com

2 edits in trunk/WebCore

2008-04-30 Rémi Zara <remi_zara@mac.com>

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=18618
REGRESSION (r31823-r31847): Patterns are upside down

svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback): flip the y axis when drawing the tile

10:32 AM Changeset in webkit [32733] by timothy@apple.com

2 edits in trunk/WebCore

Fixes an undefined type exception that fires when adding a resource to the inspector
that has a MIME type warning.

Reviewed by Adam Roben.

page/inspector/Resource.js:

(WebInspector.Resource.prototype._addTip): Call WebInspector.console instead of
WebInspector.consolePanel.
(WebInspector.Resource.prototype._checkWarning): Ditto.

10:32 AM Changeset in webkit [32732] by timothy@apple.com

2 edits in trunk/WebCore

Fixes the bug where the selected resource would be deselected after
changing the sort order in the Resources panel.

Reviewed by Dan Bernstein.

page/inspector/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
Rememebr if the tree element that we are sorting was selected, so
the selection can be restored after it is re-inserted. The onSelect
is suppressed since we don't need to show the resource again.

10:31 AM Changeset in webkit [32731] by timothy@apple.com

2 edits in trunk/WebCore

Fixes the regression where error bubbles in source views always show
"undefined" for the content because the message property on
ConsoleMessage was removed. Adds support for a plain text formated
message that is stored in the message proeprty.

Reviewed by Adam Roben.

page/inspector/Console.js:

(WebInspector.Console.prototype._format): Add a plainText argument that is passed to
the formatters.
(WebInspector.Console.prototype._formatvalue): Add a plainText argument, and a comment
about needing to honor it if the textContent of the output doesn't make sense.
(WebInspector.Console.prototype._formatvalue): Ditto.
(WebInspector.Console.prototype._formatstring): Ditto.
(WebInspector.Console.prototype._formatregexp): Ditto.
(WebInspector.Console.prototype._formatarray): Ditto.
(WebInspector.Console.prototype._formatnode): Ditto.
(WebInspector.Console.prototype._formatobject): Ditto.
(WebInspector.Console.prototype._formaterror): Ditto.
(WebInspector.ConsoleMessage): Call _format passing true for plainText. Get the
textContnet of the result and assign to the message proeprty. This property is
referenced from the SourceView.
(WebInspector.ConsoleMessage.prototype._format): Add a plainText argument. Build the
result element as a local and return it, instead of using formatedMessage directly.

10:31 AM Changeset in webkit [32730] by timothy@apple.com

2 edits in trunk/WebCore

Adds a helper function to convert a JSValueRef to a String.

Reviewed by Adam Roben.

page/InspectorController.cpp:

(WebCore::toString): Converts a JSValueRef to a String.
(WebCore::search): Use toString.
(WebCore::InspectorController::handleException): Ditto.

9:08 AM Changeset in webkit [32729] by Simon Hausmann

146 edits in trunk/LayoutTests

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon

Updated the expected test results to reflect the fact that most render objects now are anonymous.

6:41 AM Changeset in webkit [32728] by Simon Hausmann

2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build the Qt port with SVG Foreign Object support.

5:49 AM Changeset in webkit [32727] by Simon Hausmann

2 edits in trunk/WebCore

2008-04-30 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix null pointer deference triggered by
LayoutTests/fast/loader/cancel-load-during-port-block-timer.html

3:25 AM Changeset in webkit [32726] by Simon Hausmann

128 edits in trunk/LayoutTests

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon.

Updated the expected test results to the current font metrics.

3:22 AM Changeset in webkit [32725] by Simon Hausmann

2 edits in trunk/LayoutTests

2008-04-30 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Updated the skip list for the Qt port to exclude features currently
not implemented.

2:39 AM Changeset in webkit [32724] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

In focusIn and focusOut event always update the active state of the
focus controller. Fixes ~400 failing layout tests due to missing
editing callbacks that relied on the correct focus.

2:07 AM Changeset in webkit [32723] by zecke@webkit.org

4 edits in trunk/WebKit/gtk

2008-04-30 Sean Egan <seanegan@gmail.com>

Reviewed and modified by Holger.

https://bugs.webkit.org/show_bug.cgi?id=17626
Support setting background color and a 16-bit alpha channel.

webkit/webkitprivate.h:
webkit/webkitwebview.cpp:
webkit/webkitwebview.h:

1:12 AM Changeset in webkit [32722] by hyatt@apple.com

13 edits in trunk/WebCore

2008-04-29 David Hyatt <hyatt@apple.com>

Improve the performance of masks by adding code to set more precise clips on the transparency layers
used to paint the content under the mask, and then also avoid creating transparency layers for the masks
themselves in common cases.

Reviewed by Dan Bernstein

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage): Fix a bug in drawTiledImage where the composite mode got lost in the double stretch case for nine piece images.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintMask): Optimize to only push a transparency layer for the mask if multiple images are combining. Add a new composite operator argument for use when painting fill layers to do direct destination-in compositing while painting images.

rendering/InlineFlowBox.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages): Optimize to only push a transparency layer for the mask if multiple images are combining.

(WebCore::RenderBox::maskClipRect):
A new method that attempts to compute a precise clip rect for the mask images.

(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
(WebCore::RenderBox::paintFillLayerExtended):

rendering/RenderBox.h: Added the composite operator argument to the paintFillLayer methods.

rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask): Call the new base class paintMaskImages method for optimized mask painting.

rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Fix a coordinate space issue with transparencyClipBox when masks were used. The border box was in the wrong coordinate space. Moved the code into the layer's boundingBox() method instead.

(WebCore::RenderLayer::paintLayer):
Removed the code that always pushed a transparency layer before painting masks.

(WebCore::RenderLayer::boundingBox):
Call maskClipRect to shrink the bounding box of the layer to fit the mask clip.

rendering/RenderObject.cpp: (WebCore::RenderObject::paintNinePieceImage): Added a composite operator argument for direct destination-in painting of nine piece images.

rendering/RenderObject.h: (WebCore::RenderObject::maskClipRect): (WebCore::RenderObject::paintFillLayerExtended): Base class stubs for RenderBox-implemented methods.

rendering/RenderTable.cpp: (WebCore::RenderTable::paintMask):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask): Modified to call the new paintMaskImages function.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): SVG images now respect composite modes by pushing a transparency layer when the composite mode is anything other than source-over.

12:45 AM Changeset in webkit [32721] by Simon Hausmann

2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Rob Buis.

Fixed crash or assertion if SVG_FOREIGN_OBJECT is not enabled

12:45 AM Changeset in webkit [32720] by Simon Hausmann

2 edits in trunk/WebCore

2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Rob Buis.

Fixed compile, due to API change in XMLSerializer

Apr 29, 2008:

11:13 PM Changeset in webkit [32719] by rwlbuis@webkit.org

4 edits
4 adds in trunk

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=11939
Quirksmode: Ignores media types in stylesheet PIs

Transfer the xml-stylesheet pseudo attribute media to the css
stylesheet created from the ProcessingInstruction.

Tests: fast/css/xml-stylesheet-media-processing.xhtml

10:10 PM Changeset in webkit [32718] by oliver@apple.com

9 edits in branches/squirrelfish/JavaScriptCore

Bug 18643: SQUIRRELFISH: need to support implicit function calls (valueOf, toString, getters/setters)
<https://bugs.webkit.org/show_bug.cgi?id=18643>

Reviewed by Maciej

Prevent static slot optimisation for new variables and functions in
globally re-entrant code called from an an implicit function call.

This is necessary to prevent us from needing to resize the global
slot portion of the root RegisterFile during an implicit (and hence
unguarded) function call.

8:38 PM Changeset in webkit [32717] by adachan@apple.com

5 edits in trunk/WebKit/win

Support text shadow in WebDrawText().
Remove DrawTextAtPoint() since it is only called by WebDrawText().

Reviewed by Adam.

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_debug.def:
WebKitGraphics.cpp: (WebDrawText):
WebKitGraphics.h:

8:27 PM Changeset in webkit [32716] by ddkilzer@apple.com

2 edits in trunk/WebCore

BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref()

On the buildbot, this is a fatal error:

ld: symbols names listed in -exported_symbols_list: WebKitBuild/Release/DerivedSources/WebCore/WebCore.exp not in linked objects
ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv
/usr/bin/libtool: internal link edit command failed

Newer dev tools only produce a warning:

ld warning: cannot export hidden symbol ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv from WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/DocumentLoader.o

WebCore.base.exp: Remove hidden symbol from export list.

8:21 PM Changeset in webkit [32715] by ddkilzer@apple.com

2 edits in trunk/WebKit/mac

2008-04-29 David D. Kilzer <ddkilzer@apple.com>

BUILD FIX for Release build.

Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent separately so the compiler doesn't complain about an unused variable. (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.

7:16 PM Changeset in webkit [32714] by andersca@apple.com

7 edits
4 adds in trunk/WebKit

WebKit:

2008-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add new event handlers.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Refactor the Carbon event handling code out into a separate class in preparation for adding
the Cocoa event handling code.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView _viewHasMoved]):
Plugins/WebBaseNetscapePluginViewInternal.h:
Plugins/WebNetscapePluginEmbeddedView.h:
Plugins/WebNetscapePluginEventHandler.h: Added. (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler): (WebNetscapePluginEventHandler::currentEventIsUserGesture): (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
Plugins/WebNetscapePluginEventHandler.mm: Added. (WebNetscapePluginEventHandler::create):
Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added. (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon): (getCarbonEvent): (modifiersForEvent): (WebNetscapePluginEventHandlerCarbon::sendNullEvent): (WebNetscapePluginEventHandlerCarbon::drawRect): (WebNetscapePluginEventHandlerCarbon::mouseDown): (WebNetscapePluginEventHandlerCarbon::mouseUp): (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseDragged): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::keyDown): (keyMessageForEvent): (WebNetscapePluginEventHandlerCarbon::keyUp): (WebNetscapePluginEventHandlerCarbon::focusChanged): (WebNetscapePluginEventHandlerCarbon::windowFocusChanged): (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler): (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired): (WebNetscapePluginEventHandlerCarbon::startTimers): (WebNetscapePluginEventHandlerCarbon::stopTimers): (WebNetscapePluginEventHandlerCarbon::sendEvent):

5:53 PM Changeset in webkit [32713] by ddkilzer@apple.com

2 edits in trunk/WebCore

Another BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

dom/make_names.pl: Added #if ENABLE(DASHBOARD_SUPPORT) to Dashboard code.

5:31 PM Changeset in webkit [32712] by ddkilzer@apple.com

8 edits in trunk

Top:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

configure.ac: Added conditional for ENABLE_DASHBOARD_SUPPORT.

JavaScriptCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

wtf/Platform.h: Defined ENABLE(DASHBOARD_SUPPORT) to 1 only for PLATFORM(MAC) and PLATFORM(WIN). Changed default to 0 for other ports.

WebCore:

BUILD FIX for ENABLE(DASHBOARD_SUPPORT)

DerivedSources.make: Removed duplication of targets for generating CSSPropertyNames.h and CSSValueKeywords.h.
GNUmakefile.am: Ditto. Added support for ENABLE_DASHBOARD_SUPPORT.
WebCore.pro: Added support for ENABLE_DASHBOARD_SUPPORT. Made both SVG and non-SVG variables of GENERATOR 6-A use new DASHBOARDSUPPORTCSSPROPERTIES variable.

5:13 PM Changeset in webkit [32711] by adachan@apple.com

2 edits in trunk/WebCore

Added missing return.

platform/win/COMPtr.h: (WTF::):

5:07 PM Changeset in webkit [32710] by alp@webkit.org

2 edits in trunk/WebCore

2008-04-29 Alp Toker <alp@nuanti.com>

GTK+ build fix attempt following breakage in r32700 which
conditionalised dashboard support.

GNUmakefile.am:

4:15 PM Changeset in webkit [32709] by mrowe@apple.com

4 edits in tags/Safari-6526.2.1

Versioning.

4:14 PM Changeset in webkit [32708] by mrowe@apple.com

4 edits in tags/Safari-6526.2.1/WebKit/mac

Merge r32706.

4:10 PM Changeset in webkit [32707] by mrowe@apple.com

1 copy in tags/Safari-6526.2.1

New tag.

4:08 PM Changeset in webkit [32706] by mrowe@apple.com

4 edits in trunk/WebKit/mac

2008-04-29 Mark Rowe <mrowe@apple.com>

Reviewed by David Harrison.

Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.

WebKit.exp:
WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.m:

4:00 PM Changeset in webkit [32705] by mitz@apple.com

2 edits in trunk/LayoutTests

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dan Bernstein.

Modified the SVG test case for RGB and RGBA parsing - mixing percentage and
numerical values is illegal.

svg/custom/rgbcolor-syntax.svg:

3:23 PM Changeset in webkit [32704] by Adam Roben

31 edits in trunk

Restore the beloved COMPtr::operator&

WebCore:

Restore the beloved COMPtr::operator&

platform/win/COMPtr.h: Removed the HashTableDeletedValueType constructor and isHashTableDeletedValue and hashTableDeletedValue functions. (WTF::): Changed constructDeletedValue to play nicely with COMPtr::operator&.

WebKit/win:

Restore the beloved COMPtr::operator&

WebKitTools:

Restore the beloved COMPtr::operator&

3:03 PM SquirrelFishPerfIdeas edited by ggaren@apple.com

(diff)

2:53 PM Changeset in webkit [32703] by Adam Roben

1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog order

2:50 PM Changeset in webkit [32702] by Adam Roben

2 edits in trunk/WebCore

Fix assertion on launch on Windows

platform/graphics/win/FontPlatformData.h: Pass WTF::HashTableDeletedValue to the m_font constructor instead of a bogus -1 value. This is needed because m_font is a RefPtr.

2:48 PM Changeset in webkit [32701] by Adam Roben

11 edits in trunk/WebKitTools

Windows build fixes

Replace COMPtr::operator& with COMPtr::adoptionPointer.

2:31 PM Changeset in webkit [32700] by ddkilzer@apple.com

46 edits
2 adds in trunk

JavaScriptCore:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

wtf/Platform.h:

WebCore:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

DerivedSources.make:
WebCore.DashboardSupport.exp: Added.
WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/DashboardRegion.h:
css/DashboardSupportCSSPropertyNames.in: Added.
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::importNode):
dom/Document.h:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clip):
html/CanvasRenderingContext2D.h:
html/HTMLCanvasElement.cpp:
html/HTMLCanvasElement.h:
page/Chrome.cpp:
page/ChromeClient.h:
page/Frame.cpp: (WebCore::Frame::paint):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::layout):
page/FrameView.h:
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
page/mac/FrameMac.mm:
page/mac/WebDashboardRegion.h:
page/mac/WebDashboardRegion.m:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
rendering/RenderObject.h:
rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader):

WebKit/mac:

2008-04-29 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin.

Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:
WebView/WebClipView.m: (-[WebClipView scrollWheel:]):
WebView/WebHTMLView.mm: (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView acceptsFirstMouse:]):
WebView/WebUIDelegatePrivate.h:
WebView/WebView.mm: (-[WebViewPrivate init]):
WebView/WebViewPrivate.h:

2:07 PM Changeset in webkit [32699] by Adam Roben

20 edits in trunk

Windows build fix

WebCore:

Windows build fix

This removes COMPtr::operator&, which didn't jive with HashTable. It
is replaced by COMPtr::adoptionPointer.

Discussed with Darin Adler and Anders Carlsson.

platform/win/COMPtr.h: Replaced operator& with adoptionPointer.

WebKit/win:

Windows build fix

Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.

2:02 PM Changeset in webkit [32698] by Adam Roben

2 edits in trunk/WebKit/win

Fix a Windows build error

WebScriptCallFrame.cpp: (WebScriptCallFrame::variableNames): Don't use ::adopt now that PropertyNameArray has no swap function.

1:49 PM Changeset in webkit [32697] by hyatt@apple.com

1 add in trunk/WebKitSite/blog-files/kate-reflected.png

Add reflection example photo.

1:39 PM Changeset in webkit [32696] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

In nested program code, don't propogate "this" back to the parent
register file. ("this" should remain constant in the parent register
file, regardless of the scripts it invokes.)

VM/RegisterFile.cpp: (KJS::RegisterFile::copyGlobals):

1:34 PM Changeset in webkit [32695] by hyatt@apple.com

26 edits
23 adds in trunk

WebCore:

2008-04-29 David Hyatt <hyatt@apple.com>

Implement the new box-reflect property in CSS. This property enables real-time reflections on
objects (yes you can reflect <video>!).

Reviewed by Dan Bernstein

Test cases added in fast/reflections/

GNUmakefile.am:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForReflection): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseTransform):
css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSReflectValue.cpp: Added. (WebCore::CSSReflectValue::cssText):
css/CSSReflectValue.h: Added. (WebCore::): (WebCore::CSSReflectValue::CSSReflectValue): (WebCore::CSSReflectValue::direction): (WebCore::CSSReflectValue::offset): (WebCore::CSSReflectValue::mask): (WebCore::CSSReflectValue::setDirection): (WebCore::CSSReflectValue::setOffset): (WebCore::CSSReflectValue::setMask):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapNinePieceImage):
css/CSSStyleSelector.h:
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintMask):
rendering/Length.h: (WebCore::Length::calcFloatValue):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowLeft): (WebCore::RenderBlock::overflowTop): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::computeAbsoluteRepaintRect):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::transparencyClipBox): (WebCore::RenderLayer::operator delete): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer): (WebCore::RenderLayer::insertOnlyThisLayer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::reflectionLayer): (WebCore::RenderLayer::createReflection): (WebCore::RenderLayer::updateReflectionStyle):
rendering/RenderLayer.h: (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::reflection): (WebCore::RenderLayer::paintingInsideReflection):
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::updateImage): (WebCore::RenderObject::reflectionBox): (WebCore::RenderObject::reflectionOffset):
rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasReflection): (WebCore::RenderObject::hasReflection):
rendering/RenderReplica.cpp: Added. (WebCore::RenderReplica::RenderReplica): (WebCore::RenderReplica::~RenderReplica): (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
rendering/RenderReplica.h: Added. (WebCore::RenderReplica::renderName): (WebCore::RenderReplica::requiresLayer):
rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::applyTransform):
rendering/RenderStyle.h: (WebCore::TranslateTransformOperation::apply): (WebCore::StyleReflection::StyleReflection): (WebCore::StyleReflection::operator==): (WebCore::StyleReflection::operator!=): (WebCore::StyleReflection::direction): (WebCore::StyleReflection::offset): (WebCore::StyleReflection::mask): (WebCore::StyleReflection::setDirection): (WebCore::StyleReflection::setOffset): (WebCore::StyleReflection::setMask): (WebCore::RenderStyle::boxReflect): (WebCore::RenderStyle::setBoxReflect): (WebCore::RenderStyle::initialBoxReflect):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paintMask):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintMask):

LayoutTests:

2008-04-29 David Hyatt <hyatt@apple.com>

Implement support for the new box-reflect property. Tests of the new property.

Reviewed by Dan Bernstein

fast/reflections: Added.
fast/reflections/reflection-computed-style-expected.txt: Added.
fast/reflections/reflection-computed-style.html: Added.
fast/reflections/reflection-direction.html: Added.
fast/reflections/reflection-masks.html: Added.
fast/reflections/reflection-nesting.html: Added.
fast/reflections/resources: Added.
fast/reflections/resources/kate.png: Added.
fast/reflections/resources/vignette-mask.png: Added.

1:27 PM Changeset in webkit [32694] by Beth Dakin

5 edits in trunk/WebCore

2008-04-29 Beth Dakin <Beth Dakin>

Reviewed by Alice.

Initial implementation of the following ARIA roles: button,
checkbox, heading, link, radio, textbox.

html/HTMLAttributeNames.in: Add 'role' to list of attributes.

page/AccessibilityObject.cpp: When an ARIA role is set, the role overrides whatever the actual

11:09 AM Changeset in webkit [32693] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

2008-04-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Keep call count.

profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::FunctionCallProfile): (KJS::FunctionCallProfile::didExecute): Implements call count and fixed a bug where a stackIndex of 0 was causing the assert to be hit. (KJS::FunctionCallProfile::stopProfiling): (KJS::FunctionCallProfile::endAndRecordCall):
profiler/FunctionCallProfile.h:

10:36 AM Changeset in webkit [32692] by timothy@apple.com

3 edits in trunk/WebCore

Make the exceptions that the InspectorController catches log the
original file and line number, if present on the exception object.

Reviewed by Adam Roben.

page/InspectorController.cpp:

(WebCore::InspectorController::callFunction): Pass the context to HANDLE_EXCEPTION.
(WebCore::InspectorController::~InspectorController): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::updateScriptResourceRequest): Ditto.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
(WebCore::InspectorController::handleException): Take a context. Pull the line
and sourceURL properties off the exception if it is an object.

page/InspectorController.h: Change handleException to take a context.

10:12 AM Changeset in webkit [32691] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Remove .idl and .in files from WebCore's framework Resources.

10:05 AM Changeset in webkit [32690] by timothy@apple.com

3 edits in trunk/WebCore

Fixes a regression where the Page's debugger would not be reattached
when a new JSDOMWindow is created.

Reviewed by Sam Weinig.

bindings/js/kjs_proxy.cpp:

(WebCore::KJSProxy::clear): Call attachDebugger after creating the JSDOMWindow.

history/CachedPage.cpp:

(WebCore::CachedPage::restore): For the case where the CachedPage doesn't
contain a window, reattach the debugger to the new JSDOMWindow by calling
proxy->attachDebugger. Also restore the setPageGroupIdentifier.

9:50 AM Changeset in webkit [32689] by mitz@apple.com

6 edits in trunk

WebCore:

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
Fixed RGB and RGBA parsing to ignore the declaration when the value is not
"either three integer values or three percentage values."

css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

LayoutTests:

2008-04-29 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
Updated the results of the layout test for "RGB color syntax error handling".

platform/mac/css2.1/t040306-syntax-01-f-expected.checksum:
platform/mac/css2.1/t040306-syntax-01-f-expected.png:
platform/mac/css2.1/t040306-syntax-01-f-expected.txt:

7:41 AM Changeset in webkit [32688] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Fix crash when setHtml gets called from slots connected to QWebPage::unsupportedContent

Ben found this crash in the demo browser.

In void MainResourceLoader::continueAfterContentPolicy(PolicyAction contentPolicy,

case PolicyDownload:

frameLoader()->client()->download(m_handle.get(), request(), m_handle.get()->request(), r);
receivedError(interruptionForPolicyChangeError());

We are in a policy check, the download() call will call setHtml, which will start loading
the data into a frame. The loading will cancel all policy checks and call ResourceLoader::releaseResources
which will set m_frame to 0. Then we return and invoke interruptionForPolicyChangeError() which
will use the m_frame->loader() but it is gone. Do not call into receivedError and
interruptionForPolicyChangeError if we are gone anyway...

7:34 AM Changeset in webkit [32687] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Qt/Windows build fix. The externally declared hash tables are actually
declared const and the const is mangled in the symbol name, so when
importing they also need to be marked const.

When compiling without MULTIPLE_THREADS use a const HashTable&
instead of a HashTable& in ThreadClassInfoHashTables to avoid
initializing the latter with a const reference.

7:16 AM Changeset in webkit [32686] by Simon Hausmann

209 edits in trunk/LayoutTests

Simon Hausmann <Simon Hausmann>

Updated the layout tests after the latest submits to the Qt port
to our new baseline, after numerous fixes in RenderThemeQt
and assorted.

Updated the Skipped file with new expected failures that need
fixing.

2:47 AM Changeset in webkit [32685] by Simon Hausmann

2 edits in trunk/WebKit/qt

Lincoln Ramsay <lincoln.ramsay@trolltech.com>

Fix compilation with QT_NO_PRINTER

1:51 AM Changeset in webkit [32684] by Simon Hausmann

2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Ensure that relative URL is converted to absolute URL.

This is necessary because loading a relative URL is not really supported
(the web page may load, but the subsequent URLs for images and links will
not be resolved properly).
This also fixes https://bugs.webkit.org/show_bug.cgi?id=18484

1:51 AM Changeset in webkit [32683] by Simon Hausmann

2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Simplification of Qt Launcher (no animation and use standard progress bar widget)

Status bar shows the hovered link without any animation. Progress bar just uses the standard QProgressBar (no custom widget). The launcher is leaner and faster to use under the debugger and/or valgrind.

1:51 AM Changeset in webkit [32682] by Simon Hausmann

2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

Update the cursor when the frame/page loading is finished.

This fixes https://bugs.webkit.org/show_bug.cgi?id=18712

1:51 AM Changeset in webkit [32681] by Simon Hausmann

3 edits in trunk/WebKit/qt

Simon Hausmann <shausman@trolltech.com>

Fixes: QWebPage::acceptNavigationRequest not being called / linkClicked() not being emitted when clicking on <a href="..." target="_blank"> kind of links.

Call QWebPage::acceptNavigationRequest when the creation of a new window with
URL is requested. The frame pointer is set to null in this case.

1:47 AM Changeset in webkit [32680] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Rely on auto-boxing of C++ for the QCursor c'tor

1:47 AM Changeset in webkit [32679] by Simon Hausmann

3 edits in trunk/WebCore

Holger Hans Peter Freyther <zecke@selfish.org>

Add the remaining cursors that defaulted to PointerCursor

1:47 AM Changeset in webkit [32678] by Simon Hausmann

3 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <zecke@selfish.org>

Use the WebCore facility to do the scrolling. Move some code around.

1:42 AM Changeset in webkit [32677] by alice.liu@apple.com

3 edits
2 adds in trunk

WebCore:

2008-04-29 Alice Liu <alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

Test: fast/parser/tabindex-parsing.html

html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):

LayoutTests:

2008-04-29 Alice Liu <alice.liu@apple.com>

Reviewed by Beth Dakin.

Comply with HTML5 spec about parsing tabindex property according to
integer parsing rules

fast/parser/tabindex-parsing-expected.txt: Added.
fast/parser/tabindex-parsing.html: Added.

1:36 AM Changeset in webkit [32676] by Simon Hausmann

3 edits in trunk/WebCore

Fixes: Fix timing problem where scrollbars in subframes were sometimes not property repainted.

https://bugs.webkit.org/show_bug.cgi?id=18482

We need to repaint scrollbars after a geometry change, and also make sure
the computed clipping rect for the corners between scrollbars is propagated
to the chrome client without beeing intersected by the visible content rect
of the frame.

12:49 AM Changeset in webkit [32675] by Simon Hausmann

2 edits in trunk/WebKit/qt

Ariya Hidayat <ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.

12:43 AM Changeset in webkit [32674] by Simon Hausmann

6 edits in trunk

Holger Hans Peter Freyther <zecke@selfish.org>

Calling QWebView::setCursor will override the WebCore Cursor.
Calling QWebView::setCursor will override the WebCore Cursor using
QWidget::unsetCursor will revert to the WebCore Cursor.

For detecting the unset we have to compare the shape of the
cursor to the default arrow. Qt::WA_SetCursor can not be used
as it is set unconditionally but conditionally removed.

Calling QWidget::setCursor will immediately send the CursorChange
event. We listen to this event to decide if we currently use a
WebCore cursor, got a cursor from outside, or revert to the default.

This should be race free and work reliable, the manual test for this
is WebCore/manual-tests/cursor.html

12:34 AM Changeset in webkit [32673] by Simon Hausmann

6 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <kdpalara@trolltech.com>

Documentation fixes:

Fixed a qdoc warning
Mention that fav icons can be of arbitrary size
Fix signature of QWebPage::acceptNavigationRequest show in the documentation

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed