Context Navigation

fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
fast/dom/Window/closure-access-after-navigation-window.html: Added.
fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
fast/dom/Window/dom-access-from-closure-iframe.html: Added.
fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
fast/dom/Window/dom-access-from-closure-window.html: Added.
fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
fast/dom/Window/resources/notify-opener-done.html: Added.
fast/dom/Window/resources/notify-parent-done.html: Added.

5:02 PM Changeset in webkit [32844] by weinig@apple.com

23 edits
2 moves in trunk/WebCore

2008-05-03 Sam Weinig <sam@webkit.org>

Rubber-stamped by Geoffrey Garen.

Rename JSDOMWindowWrapper to JSDOMWindowShell.

2:40 PM Changeset in webkit [32843] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam.

fix accidental breakage from last patch

VM/Machine.cpp: (KJS::Machine::privateExecute):

2:08 PM Changeset in webkit [32842] by mjs@apple.com

7 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.

a bunch more opcode documentation and corresponding parameter name fixes

I renamed a few opcodes:

type_of --> typeof (that's what the JS operator is named)
instance_of --> instanceof (ditto)
create_error --> new_error (for consistency with other new_* opcodes)

I documented the following opcodes:

load
new_object
new_array
new_regexp
mov
pre_inc
pre_dec
post_inc
post_dec
to_jsnumber
negate
bitnot
not
instanceof
typeof
in
new_func
new_funcexp
new_error

I also fixed formatting on some existing opcode docs.

VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewError):
VM/CodeGenerator.h: (KJS::CodeGenerator::scopeDepth): (KJS::CodeGenerator::addVar):
VM/Machine.cpp: (KJS::Machine::privateExecute):
VM/Opcode.h:
kjs/nodes.cpp: (KJS::Node::emitThrowError): (KJS::RegExpNode::emitCode): (KJS::TypeOfValueNode::emitCode): (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode): (KJS::InstanceOfNode::emitCode): (KJS::InNode::emitCode):

1:53 PM Changeset in webkit [32841] by mjs@apple.com

2 edits
2 adds in branches/squirrelfish/JavaScriptCore

2008-05-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff and Sam.

generate HTML bytecode docs at build time

DerivedSources.make:
docs: Added.
docs/make-bytecode-docs.pl: Added.

1:35 PM Changeset in webkit [32840] by ggaren@apple.com

7 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Update ExecState::m_scopeChain when switching scope chains inside the
machine.

This fixes uses of lexicalGlobalObject, such as, in a subframe

alert(top.makeArray() instanceof Array ? "FAIL" : "PASS");

and a bunch of the security failures listed in
https://bugs.webkit.org/show_bug.cgi?id=18870. (Those tests still fail,
seemingly because of regressions in exception messages).

SunSpider reports no change.

VM/Machine.cpp: Factored out scope chain updating into a common function that takes care to update ExecState::m_scopeChain, too.

kjs/ExecState.h: I made Machine a friend of ExecState so that Machine could update ExecState::m_scopeChain, even though that value is read-only for everyone else.

kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Changed this client to be a little friendlier to ExecState's internal storage type for scope chain data.

12:36 PM Changeset in webkit [32839] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed https://bugs.webkit.org/show_bug.cgi?id=18876
Squirrelfish: ScopeChainNode leak in op_jmp_scopes.

SunSpider reports no change.

VM/Machine.cpp: (KJS::Machine::privateExecute): Don't construct a ScopeChain object, since the direct threaded interpreter will goto across its destructor.

2:14 AM Changeset in webkit [32838] by ggaren@apple.com

8 edits in branches/squirrelfish/JavaScriptCore

2008-05-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A bit more efficient fix than r32832: Don't copy globals into function
register files; instead, have the RegisterFileStack track only the base
of the last *global* register file, so the global object's register
references stay good.

SunSpider reports a .3% speedup. Not sure what that's about.

12:20 AM Changeset in webkit [32837] by oliver@apple.com

6 edits in branches/squirrelfish/JavaScriptCore

Bug 18864: SquirrelFish: Support getter and setter definition in object literals
<https://bugs.webkit.org/show_bug.cgi?id=18864>

Reviewed by Maciej

Add new opcodes to allow us to add getters and setters to an object. These are
only used by the codegen for object literals.

May 2, 2008:

11:44 PM Changeset in webkit [32836] by rwlbuis@webkit.org

6 edits
2 adds in trunk

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=18568
background: currentColor fails

Implement currentColor from CSS3 color module.

Tests: fast/css/background-currentcolor.html

11:43 PM Changeset in webkit [32835] by mrowe@apple.com

4 edits in tags/Safari-6526.3.3

Versioning.

11:40 PM Changeset in webkit [32834] by mrowe@apple.com

2 edits in tags/Safari-6526.3.3/WebKitLibraries

Merge r32649.

11:30 PM Changeset in webkit [32833] by mrowe@apple.com

1 copy in tags/Safari-6526.3.3

New tag.

10:40 PM Changeset in webkit [32832] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-05-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

properly copy globals into and out of implicit call register files, otherwise they will fail at global lookup

Fixes fast/js/array-tostring-and-join.html layout test.

VM/RegisterFileStack.cpp: (KJS::RegisterFileStack::pushGlobalRegisterFile): (KJS::RegisterFileStack::popGlobalRegisterFile): (KJS::RegisterFileStack::pushFunctionRegisterFile): (KJS::RegisterFileStack::popFunctionRegisterFile):

7:25 PM Changeset in webkit [32831] by ggaren@apple.com

5 edits in branches/squirrelfish/JavaScriptCore

2008-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed https://bugs.webkit.org/show_bug.cgi?id=18822
SQUIRRELFISH: incorrect eval used in some cases

Changed all code inside the machine to fetch the lexical global object
directly from the scope chain, instead of from the ExecState.

Clients who fetch the lexical global object through the ExecState
still don't work.

SunSpider reports no change.

VM/Machine.cpp: (KJS::Machine::privateExecute): Fetch the lexical global object from the scope chain.

kjs/ExecState.h: (KJS::ExecState::ExecState::lexicalGlobalObject): Moved the logic for this function into ScopeChainNode, but kept this function around to support existing clients.

5:44 PM Changeset in webkit [32830] by andersca@apple.com

5 edits in trunk

WebCore:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Turns out calling locationInWindow on keyboard events will not throw an exception,
but the point returned is completely bogus, so remove coordinates from the keyboard event struct.

bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Various Cocoa event model and 64-bit plug-in fixes.

Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): Set click count.

(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
Don't try to get the mouse location for keyboard events.

Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.

5:21 PM Changeset in webkit [32829] by andersca@apple.com

2 edits in trunk

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Add an "x86_64" make rule.

Makefile.shared:

4:10 PM Changeset in webkit [32828] by alp@webkit.org

2 edits in trunk/WebCore

2008-05-02 Benjamin Otte <otte@gnome.org>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18856
[GTK] variable initialization missing

Not initializing the m_needsXEmbed variable could have very funny
results. Most often those results would be crashes.

plugins/PluginView.cpp: (WebCore::PluginView::PluginView):

3:21 PM Changeset in webkit [32827] by alp@webkit.org

4 edits in trunk

2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=18811
Enable dashboard and offline web apps in autotools

2:07 PM Changeset in webkit [32826] by mrowe@apple.com

2 edits in tags/Safari-6526.3.2/JavaScriptCore

Merge r32654.

2:04 PM Changeset in webkit [32825] by mrowe@apple.com

4 edits in tags/Safari-6526.3.2

Versioning.

2:02 PM Changeset in webkit [32824] by mrowe@apple.com

1 copy in tags/Safari-6526.3.2

New tag.

1:21 PM Changeset in webkit [32823] by mrowe@apple.com

4 edits in tags/Safari-6526.3.1/WebKit/mac

Merge r32706.

1:05 PM Changeset in webkit [32822] by ap@webkit.org

4 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

Get rid of static data in nodes.cpp (well, at least of non-debug one).

No measurable change on SunSpider.

kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
kjs/nodes.cpp: (KJS::newTrackedObjects): (KJS::trackedObjectExtraRefCounts): (KJS::initializeNodesThreading): (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::ref): (KJS::ParserRefCounted::deref): (KJS::ParserRefCounted::refcount): (KJS::ParserRefCounted::deleteNewObjects):
kjs/nodes.h: Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.

12:23 PM Changeset in webkit [32821] by andersca@apple.com

4 edits in trunk

WebCore:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam.

Name the event union so it will work in plain C.

bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam.

The event union is now named.

Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):

11:15 AM Changeset in webkit [32820] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark.

Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.

Call preflightAndReturnError on the bundle, which will check if any of the architectures
in the bundle match the current architecture.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):

11:10 AM Changeset in webkit [32819] by ap@webkit.org

5 edits in trunk/JavaScriptCore

Reviewed by Darin.

Move call stack depth counter to global object.

kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to per-thread data.
kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.

kjs/object.cpp: (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now the only thing in JSObject::call that needs a PIC branch. (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth tracking.

10:53 AM Changeset in webkit [32818] by mitz@apple.com

2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

add an option to svn-apply to set the reviewer name in change logs

Scripts/svn-apply: Added a [-rreviewer name] option.

9:15 AM Changeset in webkit [32817] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by John Sullivan.

render text shadows with zero offset, as the shadow can be seen behind the text if the text is translucent

Test: fast/text/shadow-no-blur.html

platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the shadow offset. Since isEmpty() is also true for sizes that have one or more non-positive components, this also ensures that subpixel antialiasing of the text is maintained with shadows in all directions. (WebCore::Font::drawGlyphs): Ditto.
platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.

LayoutTests:

Reviewed by John Sullivan.

add pixel test for text shadows with zero blur and various offsets, including zero offset

fast/text/shadow-no-blur.html: Added.
platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
platform/mac/fast/text/shadow-no-blur-expected.png: Added.
platform/mac/fast/text/shadow-no-blur-expected.txt: Added.

7:48 AM Changeset in webkit [32816] by Simon Hausmann

102 edits
14 adds in trunk/LayoutTests

2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com>

Updated Qt layout-tests to match changes in font metrics.

7:09 AM Changeset in webkit [32815] by Simon Hausmann

2 edits in trunk/WebCore

Ariya Hidayat <ariya.hidayat@trolltech.com>

Build the Qt port with SVG Use and As Image support.

6:40 AM Changeset in webkit [32814] by Simon Hausmann

2 edits in trunk/WebCore

Ariya Hidayat <ariya.hidayat@trolltech.com>

Fixed potential crash on SVG animation (added more checks to the assert).

6:21 AM Changeset in webkit [32813] by Simon Hausmann

2 edits in trunk/WebKit/qt

Benjamin Meyer <bmeyer@trolltech.com>

Doc: Mention that you have to enable plugins in QWebSettings for them to work.

6:07 AM Changeset in webkit [32812] by ap@webkit.org

2 edits in trunk/WebCore

Rubber-stamped by John Sullivan.

Fix a debug-only crash in layout tests.

loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): Don't call resourceForURL() for null URLs.

5:07 AM Changeset in webkit [32811] by Simon Hausmann

2 edits in trunk/WebCore

Fix the Qt build on Windows when Phonon is enabled for Audio/Video support

4:04 AM Changeset in webkit [32810] by Simon Hausmann

8 edits in trunk

Fix the Qt build, add ExecState where required.

3:32 AM Changeset in webkit [32809] by Simon Hausmann

4 edits in trunk/WebCore

Fix the Qt/Win build.

3:29 AM Changeset in webkit [32808] by ap@webkit.org

9 edits in trunk

Reviewed by Darin.

Make JavaScriptGlue and JavaScriptCore API functions implicitly call initializeThreading
for the sake of non-WebKit clients.

JavaScriptCore:

API/JSBase.cpp: (JSGarbageCollect):
API/JSContextRef.cpp: (JSGlobalContextCreate): These are the JavaScriptCore API bottlenecks. There are a few other JSStringRef and JSClassRef functions that can be called earlier, but they do not do anything that requires initializeThreading.

kjs/InitializeThreading.cpp: (KJS::doInitializeThreading): (KJS::initializeThreading): On Darwin, make the initialization happen under pthread_once, since there is no guarantee that non-WebKit clients won't try to call this function re-entrantly.

kjs/InitializeThreading.h:
wtf/Threading.h: Spell out initializeThreading contract.

wtf/ThreadingPthreads.cpp: (WTF::isMainThread): Make sure that results are correct on Darwin, even if threading was initialized from a secondary thread.

JavaScriptGlue:

JavaScriptGlue.cpp: (JSRunCreate): (JSCollect): (JSCreateJSArrayFromCFArray): (JSLockInterpreter): These are all possible JavaScriptGlue entry points.

3:07 AM Changeset in webkit [32807] by ap@webkit.org