⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 5, 2008:

11:29 PM SquirrelFish edited by ggaren@apple.com
(diff)
10:01 PM Changeset in webkit [32901] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix 60 crashes seen on the buildbots that were misreported as hangs.

Reviewed by Dan Bernstein.

  • dom/Document.cpp:

(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.

9:09 PM Changeset in webkit [32900] by beidson@apple.com
  • 3 edits in trunk/WebCore

2008-05-05 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz Pettel RTL

Preparation for upcoming work making LocalStorage persistent.

The other half of the StorageMap::importItem() addition.

  • storage/StorageArea.cpp: (WebCore::StorageArea::importItem):
  • storage/StorageArea.h:
9:03 PM Changeset in webkit [32899] by beidson@apple.com
  • 5 edits in trunk/WebCore

2008-05-05 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz Pettel RTL

Preparation for upcoming work making LocalStorage persistent.

  • Create the LocalStorage object for a PageGroup the moment the first Page is added to it The Settings of the first Page define what persistent path the LocalStorage will use
  • Add a Frame argument for the LocalStorageArea request - this will allow a client object to be queried before the LocalStorageArea is established
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
  • page/PageGroup.cpp: (WebCore::PageGroup::addPage): (WebCore::PageGroup::localStorage):
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument. Deep copy the path as it will be used from another thread. (WebCore::LocalStorage::storageArea):
  • storage/LocalStorage.h: (WebCore::LocalStorage::create):
8:16 PM Changeset in webkit [32898] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Fix call frame set up for native -> JS function calls.

Review by Geoff

8:14 PM Changeset in webkit [32897] by beidson@apple.com
  • 3 edits in trunk/WebCore

2008-05-05 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz Pettel RTL

Preparation for upcoming work making LocalStorage persistent.

StorageMaps normally have copy-on-write semantics to help support SessionStorage.
For LocalStorage, we never want this behavior. When we forcefully import items into
a StorageMap from the LocalStorage background thread, this new import method will be used.

  • storage/StorageMap.cpp: (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying about copy-on-write.
  • storage/StorageMap.h:
7:24 PM Changeset in webkit [32896] by ggaren@apple.com
  • 8 edits
    2 adds in branches/squirrelfish

JavaScriptCore:

2008-05-05 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed ecma_3/Object/8.6.2.6-001.js, and similar bugs.


SunSpider reports a .4% speedup. Not sure what that's about.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Check for exception return from equal, since toPrimitive can throw.
  • kjs/operations.cpp: (KJS::strictEqual): In response to an error I made in an earlier version of this patch, I changed strictEqual to make clear the fact that it performs no conversions and can't throw, making it slightly more efficient in the process.

LayoutTests:

2008-05-05 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Layout test for exceptions thrown from equality comparisons.

  • fast/js/exception-thrown-from-equal-expected.txt: Added.
  • fast/js/exception-thrown-from-equal.html: Added.
5:45 PM Changeset in webkit [32895] by sfalken@apple.com
  • 3 edits in trunk/WebKitTools

Copy dependencies of ImageDiff, DumpRenderTree in post-build step.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
5:23 PM Changeset in webkit [32894] by sfalken@apple.com
  • 2 edits in tags/Safari-6526.3.4/WebCore

Merged r32711.

5:21 PM Changeset in webkit [32893] by sfalken@apple.com
  • 5 edits in tags/Safari-6526.3.4

Merged r32699, 32701, 32702, 32704.

5:15 PM Changeset in webkit [32892] by sfalken@apple.com
  • 2 edits in tags/Safari-6526.3.4/WebKit/win

Merged r32698.

5:08 PM Changeset in webkit [32891] by sfalken@apple.com
  • 2 edits in tags/Safari-6526.3.4/WebCore

Merged r32659.

5:01 PM Changeset in webkit [32890] by kmccullough@apple.com
  • 4 edits
    6 adds in trunk/WebCore

2008-05-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Begininings of a UI for the Profiler in the WebInspector.

  • English.lproj/InspectorLocalizedStrings.js: Add new strings to be localized.
  • page/inspector/DatabasesPanel.js: Changed the name of the Databae's results table to be more generic as it is now also used by the profiler.
  • page/inspector/Images/glossySelected.png: Added.
  • page/inspector/Images/profilesIcon.png: Added.
  • page/inspector/Images/treeUpTriangleBlack.png: Added.
  • page/inspector/Images/treeUpTriangleWhite.png: Added.
  • page/inspector/ProfileView.js: Added. Sets up the header of the table.
  • page/inspector/ProfilesPanel.js: Added.
  • page/inspector/ProfilesPanel.js: Added. Sets up the containers of the profiler's content.
  • page/inspector/inspector.css: Change database-result-table to be more generic as well as add the styles needed by the profiler.
  • page/inspector/inspector.html: Add profiler support.
4:42 PM Changeset in webkit [32889] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-05-05 Brady Eidson <​beidson@apple.com>

Change by Darin, reviewed by Brady

Small efficiency improvement Darin just spotted

  • storage/StorageMap.cpp: (WebCore::StorageMap::setItem):
4:41 PM Changeset in webkit [32888] by sfalken@apple.com
  • 3 edits in tags/Safari-6526.3.4/WebCore

Merged r32656, r32657.

4:31 PM Changeset in webkit [32887] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-05-05 Antti Koivisto <Antti Koivisto>

Reviewed by Anders.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=18899
Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

  • loader/loader.cpp: (WebCore::Loader::Loader):
4:04 PM Changeset in webkit [32886] by weinig@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix for <rdar://problem/5884383>
Escape look-a-like characters from the the entire url.

  • Misc/WebNSURLExtras.mm: (escapeUnsafeCharacters): (-[NSURL _web_userVisibleString]):
4:00 PM Changeset in webkit [32885] by sfalken@apple.com
  • 1 copy in tags/Safari-6526.3.4

New tag.

3:57 PM Changeset in webkit [32884] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-05-05 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Fix a bug in StorageMap iterator tracking where the iterator was not successfully
invalidated at an appropriate time.

  • storage/StorageMap.cpp: (WebCore::StorageMap::setItem): ALWAYS invalidate it here
3:50 PM Changeset in webkit [32883] by justin.garcia@apple.com
  • 7 edits in trunk

WebCore:

2008-05-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.

<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end


Disable Range mutation on document modifications in Tiger and Leopard Mail,
since they do their own mutation which interferes with ours.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::disableRangeMutationForOldAppleMail):
  • page/Settings.h: (WebCore::Settings::rangeMutationDisabledForOldAppleMail):

WebKit/mac:

2008-05-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.


<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

  • WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to the document for Tiger and Leopard Mail. There is code in Mail that does it, and the two interfere.
3:47 PM Changeset in webkit [32882] by weinig@apple.com
  • 8 edits
    1 add
    1 delete in trunk

WebCore:

2008-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Tim Hatcher.

Make the Inspector's localizable strings file match the format used by Dashboard widgets.

  • English.lproj/InspectorLocalizedStrings.js: Removed.
  • English.lproj/localizedStrings.js: Added.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/inspector/inspector.js:

WebKit/mac:

2008-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Tim Hatcher.

Make the Inspector's localizable strings file match the format used by Dashboard widgets.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL):

WebKit/win:

2008-05-05 Sam Weinig <​sam@webkit.org>

Reviewed by Tim Hatcher.

Make the Inspector's localizable strings file match the format used by Dashboard widgets.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL):
1:51 PM Changeset in webkit [32881] by sfalken@apple.com
  • 18 edits in trunk

2008-05-05 Steve Falkenburg <​sfalken@apple.com>

Add WebPreference for application chrome mode.


Reviewed by Dave Hyatt.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::inApplicationChromeMode): (WebPreferences::setApplicationChromeMode):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2008-05-05 Steve Falkenburg <​sfalken@apple.com>

Add support for default button appearance.
Add WebCore setting for app chrome mode.


Reviewed by Dave Hyatt.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in: Added default-button value keyword.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setApplicationChromeMode):
  • page/Settings.h: (WebCore::Settings::inApplicationChromeMode):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::setStyle): (WebCore::RenderButton::timerFired):
  • rendering/RenderButton.h:
  • rendering/RenderStyle.h: (WebCore::):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::isDefault):
  • rendering/RenderTheme.h: (WebCore::):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): (WebCore::RenderThemeSafari::adjustRepaintRect): (WebCore::RenderThemeSafari::adjustButtonStyle):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus):
1:35 PM Changeset in webkit [32880] by adele@apple.com
  • 2 edits in trunk/WebKitTools

2008-05-05 Adele Peterson <​adele@apple.com>

Reviewed by Adam.

Look for the right ImageDiff executable for debug builds.

  • Scripts/run-webkit-tests:
11:29 AM Changeset in webkit [32879] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=11947
nbsps should be converted to entities in innerHTML

​https://bugs.webkit.org/show_bug.cgi?id=18769
replacing &nbsp; with spaces using regexp creates inconsistent result

Tests: fast/dom/innerHTML-nbsp.html

fast/dom/innerHTML-escaping-attribute.html

  • editing/markup.cpp: (WebCore::appendAttributeValue): (WebCore::escapeContentText): (WebCore::appendEscapedContent): Added U+00a0/nbsp to the list of characters to escape.
11:26 AM Changeset in webkit [32878] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-05-05 David Hyatt <​hyatt@apple.com>

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18821. Fix some bugs in both get/PutImageData of <canvas>.

Reviewed by Eric

New tests added in fast/canvas/

  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):

LayoutTests:

2008-05-05 David Hyatt <​hyatt@apple.com>

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.

Reviewed by Eric

  • fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
  • fast/canvas/canvas-alphaImageData-behavior.html: Added.
  • fast/canvas/canvas-alphaImageData-behavior.js: Added.
9:59 AM Changeset in webkit [32877] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-05-05 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • fix debug-only leak seen on buildbot
  • wtf/HashTable.h: (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a deleted value on top of it, call the destructor so the empty value doesn't leak.
9:47 AM Changeset in webkit [32876] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-05-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Jess.

Apparently preflighting can cause hangs for some reason. Revert this for now.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
9:44 AM Changeset in webkit [32875] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-05-05 Darin Adler <Darin Adler>

  • Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit leak tests.
9:34 AM Changeset in webkit [32874] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-05-05 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • WebView/WebView.mm: (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the NSWindowWillCloseNotification if the view was moved out of the window but still had that window set as the host window. Also make sure this function doesn't do anything if the WebView is already closed. (-[WebView setHostWindow:]): Ditto.
9:31 AM Changeset in webkit [32873] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Rubber-stamped by Adam Roben.

  • fix test failure due to Windows' preference for Mac results over generic results
  • platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.
9:27 AM Changeset in webkit [32872] by mitz@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/block/basic/adding-near-anonymous-block.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): When adding a floating or positioned object, if it follows an anonymous block, put it inside the anonymous block. When adding an inline, check if it comes after an anonymous block and put it in the anonymous block.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/block/basic/adding-near-anonymous-block.html: Added.
  • media/video-controls-rendering.html: Changed to work around ​https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this test in its original form.
  • platform/mac/css1/box_properties/clear-expected.txt:
  • platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
  • platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
  • platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
  • platform/mac/fast/forms/input-align-image-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
9:09 AM Changeset in webkit [32871] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-05-05 Antti Koivisto <Antti Koivisto>

Reviewed by Darin.

Speculative fix for <rdar://problem/5906790>
Crash in Loader::servePendingRequests() due to hash table being modified during iteration


I don't know how to reproduce this. It would require the load to fail (or succeed)
synchronously, something that should not usually happen.

  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host):
  • loader/loader.h: (WebCore::Loader::Host::name):
6:43 AM UsingGitWithWebKit edited by dan+macosforge@danwalters.net
fix repository url (diff)
3:43 AM Changeset in webkit [32870] by mjs@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-05-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • fix some dumb mistakes in my last patch
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitGetPropertyNames):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
3:26 AM Changeset in webkit [32869] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Ariya Hidayat <​ariya.hidayat@trolltech.com>

In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)

2:59 AM Changeset in webkit [32868] by Simon Hausmann
  • 2 edits in trunk/WebCore

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
changes.

2:34 AM Changeset in webkit [32867] by mjs@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

2008-05-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • document opcodes relating to jumps, scopes, and property name iteration


Documented jmp, jtrue, false, push_scope, pop_scope, get_pnames,
next_pname and jmp_scopes.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode): (KJS::ConditionalNode::emitCode): (KJS::IfNode::emitCode): (KJS::IfElseNode::emitCode): (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::WithNode::emitCode):
1:01 AM Changeset in webkit [32866] by oliver@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

Bug 18749: SQUIRRELFISH: const support is broken
<​https://bugs.webkit.org/show_bug.cgi?id=18749>

Cameron Zwarich <​cwzwarich@uwaterloo.ca>
Reviewed by Oliver.

Adds support for const during code generation.

Fixes 2 layout tests.

May 4, 2008:

11:48 PM Changeset in webkit [32865] by mjs@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

2008-05-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


  • document some more opcodes (and fix argument names)


Added docs for eq, neq, stricteq, nstriceq, less and lesseq.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/nodes.cpp: (KJS::LessNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):
11:46 PM Changeset in webkit [32864] by ggaren@apple.com
  • 10 edits in branches/squirrelfish/JavaScriptCore

2008-05-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

More scaffolding for f.arguments.


Track the offset of the last call frame in the ExecState, so we can
produce a backtrace at any time.


Also, record numLocals, the sum of numVars + numParameters, in each code
block, to make updates to the ExecState a little cheaper than they
would be otherwise.


We now use numLocals in a bunch of places where we used to calculate
numVars + numParameters or -numVars - numParameters.


Reports are mixed, but all in all, this seems to be a wash on SunSpider.

10:30 PM Changeset in webkit [32863] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Allow events to specify the ID of the particular wxWebView they are to be sent to.

​https://bugs.webkit.org/show_bug.cgi?id=18659

9:46 PM Changeset in webkit [32862] by Antti Koivisto
  • 1 edit
    2 adds in trunk/LayoutTests

2008-05-02 Antti Koivisto <Antti Koivisto>

Reviewed by Mitz.


Test for <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

  • fast/transforms/container-transform-crash-expected.txt: Added.
  • fast/transforms/container-transform-crash.html: Added.
9:44 PM Changeset in webkit [32861] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-05-02 Antti Koivisto <Antti Koivisto>

Reviewed by Mitz.

Fix <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject


Non-block objects can have transforms so containingBlock() could end up returning null.
RenderObject::container() needs to match.

Test: fast/transforms/container-transform-crash.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
9:42 PM Changeset in webkit [32860] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Whoops, correctly handle properties that don't exist in the
symbol table.

Reviewed by Geoff

7:14 PM Changeset in webkit [32859] by oliver@apple.com
  • 8 edits in branches/squirrelfish/JavaScriptCore

Add attribute information to SymbolTable as ground work for
various DontEnum and ReadOnly issues.

Reviewed by Geoff

7:05 PM Changeset in webkit [32858] by ggaren@apple.com
  • 6 edits in branches/squirrelfish/JavaScriptCore

2008-05-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


More scaffolding for f.arguments.


Store the register file associated with an ExecState in the ExecState.


SunSpider reports no change.

  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Moved registerFileStack above globalExec, so it gets initialized first. Removed remnants of old activation scheme.
6:48 PM Changeset in webkit [32857] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-05-04 Sam Weinig <​sam@webkit.org>

Roll out r32851. It broke tiger builds.

  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): (WebCore::createDOMWrapper):
6:11 PM Changeset in webkit [32856] by mjs@apple.com
  • 7 edits in branches/squirrelfish/JavaScriptCore

2008-05-04 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Oliver.


  • renamed a few opcodes and fixed assembly formatting to accomodate the longest opcode


equal --> eq
nequal --> neq
resolve_base_and_property --> resolve_with_base
resolve_base_and_func --> resolve_func
get_prop_id --> get_by_id
put_prop_id --> put_by_id
delete_prop_id --> del_by_id
get_prop_val --> get_by_val
put_prop_val --> put_by_val
delete_prop_val --> del_by_val
put_prop_index --> put_by_index


  • VM/CodeBlock.cpp: (KJS::printUnaryOp): (KJS::printBinaryOp): (KJS::printConditionalJump): (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
  • kjs/nodes.cpp: (KJS::ArrayNode::emitCode): (KJS::PropertyListNode::emitCode): (KJS::BracketAccessorNode::emitCode): (KJS::DotAccessorNode::emitCode): (KJS::EvalFunctionCallNode::emitCode): (KJS::FunctionCallResolveNode::emitCode): (KJS::FunctionCallBracketNode::emitCode): (KJS::FunctionCallDotNode::emitCode): (KJS::PostIncResolveNode::emitCode): (KJS::PostDecResolveNode::emitCode): (KJS::PostIncBracketNode::emitCode): (KJS::PostDecBracketNode::emitCode): (KJS::PostIncDotNode::emitCode): (KJS::PostDecDotNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::TypeOfResolveNode::emitCode): (KJS::PreIncResolveNode::emitCode): (KJS::PreDecResolveNode::emitCode): (KJS::PreIncBracketNode::emitCode): (KJS::PreDecBracketNode::emitCode): (KJS::PreIncDotNode::emitCode): (KJS::PreDecDotNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ForInNode::emitCode): (KJS::TryNode::emitCode):
4:29 PM Changeset in webkit [32855] by oliver@apple.com
  • 3 edits
    3 adds in branches/squirrelfish

Fix assertion when accessing arguments object with too many arguments provided

Reviewed by Maciej

The arguments constructor was assuming that the register offset given for argv
was an absolute offset into the registerfile, rather than the offset from the
frame. This patches corrects that issue.

3:03 PM Changeset in webkit [32854] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/gradients/crash-on-remove.html

  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue): (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the value. (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref() the value.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/gradients/crash-on-remove-expected.txt: Added.
  • fast/gradients/crash-on-remove.html: Added.
2:52 PM Changeset in webkit [32853] by weinig@apple.com
  • 5 edits in trunk/LayoutTests

2008-05-04 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

Don't print out the full url.

  • fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
  • fast/dom/Window/dom-access-from-closure-window-expected.txt:
  • fast/dom/Window/resources/dom-access-from-closure-iframe-child.html:
  • fast/dom/Window/resources/dom-access-from-closure-window-child.html:
2:52 PM Changeset in webkit [32852] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Make parameters match for WebChromeClient::addMessageToConsole()

Reviewed by John.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::addMessageToConsole): Renamed sourceID parameter to sourceURL to match implementation in WebChromeClient.mm.
2:29 PM Changeset in webkit [32851] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-05-03 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
the WebCore namespace now that the required compilers don't freak out about
this anymore.

  • bindings/objc/DOMUtility.mm: (WebCore::createDOMWrapper):
11:27 AM Changeset in webkit [32850] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-04 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Sam Weinig.


Cleaned up Machine.cpp according to our style guidelines: moved static
data to the top of the file; moved stand-alone functions below that;
moved the Machine constructor above other Machine member functions.

Note: See TracTimeline for information about the timeline view.