Context Navigation

← Previous Period
Next Period →

Timeline

May 11, 2008:

10:14 PM Changeset in webkit [33037] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Previous commit made bdash sad. Restore happiness state by fixing missed style issue.

10:06 PM Changeset in webkit [33036] by kevino@webkit.org

5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix scrolling issues by implementing transitionToCommittedNewPage() so the scroll positions are reset when a new page is loaded, and also maintained so that back and next restore the scroll positions as well. This also simplifies the logic for initializing and managing wxWebView.

https://bugs.webkit.org/show_bug.cgi?id=18992

9:58 PM Changeset in webkit [33035] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Since wx popup menus dismiss themselves when an item is selected we need to call hidePopup so webkit's internal state is correct.

https://bugs.webkit.org/show_bug.cgi?id=19000

5:34 PM Changeset in webkit [33034] by weinig@apple.com

4 edits
1 add in trunk/WebCore

2008-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move some generic parsing functions into a new ParserUtilities header so that
they can be used for non-SVG builds too.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/text/ParserUtilities.h: Added. (WebCore::skipString):
svg/SVGParserUtilities.h: (WebCore::isWhitespace): (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrDelimiter):

1:26 PM Changeset in webkit [33033] by weinig@apple.com

6 edits
6 adds in trunk/WebCore

2008-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add scaffolding for the implementation of Access Control for Cross-site Requests.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
xml/AccessControlList.cpp: Added. (WebCore::AccessControlList::AccessControlList): (WebCore::AccessControlList::~AccessControlList): (WebCore::AccessControlList::parseAccessControlHeader): (WebCore::AccessControlList::checkOrigin):
xml/AccessControlList.h: Added.
xml/AccessItem.cpp: Added. (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):
xml/AccessItem.h: Added.
xml/AccessItemRule.cpp: Added. (WebCore::AccessItemRule::AccessItemRule): (WebCore::AccessItemRule::parseAccessItemRule):
xml/AccessItemRule.h: Added.

9:36 AM Changeset in webkit [33032] by jchaffraix@webkit.org

2 edits in trunk/WebCore

2008-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Debug build fix.

loader/appcache/ApplicationCache.cpp: Include stdio.h as we are using printf in ApplicationCache::dump().

4:15 AM Changeset in webkit [33031] by cwzwarich@webkit.org

3 edits
3 adds in branches/squirrelfish

2008-05-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 18961: SQUIRRELFISH: Gmail doesn't load
<https://bugs.webkit.org/show_bug.cgi?id=18961>

Fix codegen for logical nodes so that they don't use their destination
as a temporary.

kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode):

fast/js/codegen-temporaries-expected.txt: Added.
fast/js/codegen-temporaries.html: Added.
fast/js/resources/codegen-temporaries.js: Added.

May 10, 2008:

7:28 PM Changeset in webkit [33030] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Jessica Kahn.

add a copy assignment operator to FontPlatformData on Mac to properly retain the m_font data member.

platform/graphics/mac/FontPlatformData.h:
platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont):

3:01 PM Changeset in webkit [33029] by adele@apple.com

2 edits in trunk/WebCore

2008-05-10 Adele Peterson <adele@apple.com>

Reviewed by Tim Hatcher.

Fix crash for WebKit clients that don't set a group name for the WebView/Page.

page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): Instead of adding the Page directly to the group, call the addPage method, since it does extra work initializing m_localStorage.

2:18 PM Changeset in webkit [33028] by mjs@apple.com

1 edit
1 add in branches/squirrelfish/WebCore

2008-05-10 Maciej Stachowiak <mjs@apple.com>

Build fix.

add missing forwarding header

ForwardingHeaders/kjs/SourceProvider.h: Added.

1:36 PM Changeset in webkit [33027] by mjs@apple.com

38 edits
3 adds in branches/squirrelfish

JavaScriptCore:

2008-05-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

JavaScriptCore part of fix for: "SQUIRRELFISH: function toString broken after calling" https://bugs.webkit.org/show_bug.cgi?id=18869

Three layout tests are fixed:

fast/js/toString-elision-trailing-comma.html
fast/js/toString-prefix-postfix-preserve-parens.html
fast/js/kde/lval-exceptions.html

Functions now save a shared subrange of the original source used
to make them (so in the common case this adds no storage above the
memory cache).

kjs/SourceProvider.h: Added. (KJS::SourceProvider): New abstract base class for classes that provide on-demand access to the source for a JavaScript program. This allows function objects to have access to their original source without copying. (KJS::UStringSourceProvider): SourceProvider subclass backed by a KJS::UString. (KJS::UStringSourceProvider::create): (KJS::UStringSourceProvider::getRange): (KJS::UStringSourceProvider::data): (KJS::UStringSourceProvider::length): (KJS::UStringSourceProvider::UStringSourceProvider):
kjs/SourceRange.h: Added. (KJS::SourceRange::SourceRange): Class that holds a SourceProvider and a character range into the source, to encapsulate on-demand access to the source of a function. (KJS::SourceRange::toString):
VM/Machine.cpp: (KJS::eval): Pass a UStringSourceProvider to the parser.
kjs/Parser.cpp: (KJS::Parser::parse): Take a SourceProvider and pass it on to the lexer.
kjs/Parser.h: (KJS::Parser::parse): Take a SourceProvider.
kjs/lexer.cpp: (KJS::Lexer::setCode): Take a SourceProvider; keep it around, and use it to get the raw buffer and length.
kjs/lexer.h: (KJS::Lexer::sourceRange): Convenience function to get a source range based on the lexer's source provieder, and char offsets right before and after the desired range.
kjs/function.cpp: (KJS::globalFuncEval): Pass a UStringSourceProvider to the parser.
kjs/function_object.cpp: (KJS::functionProtoFuncToString): Use toSourceString to get the source. (KJS::FunctionObjectImp::construct): Give the parser a UStringSourceProvider.
kjs/grammar.y: When parsing a function declaration, function expression, or getter or setter, tell the function body about its SourceRange.
kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): Pass a SourceProvider to the parser. (KJS::Interpreter::evaluate): Pass a SourceProvider to the parser.
kjs/interpreter.h:
kjs/nodes.h: (KJS::FunctionBodyNode::setSource): Establish a SourceRange for this function. (KJS::FunctionBodyNode::toSourceString): Get the source string out of the SourceRange. (KJS::FuncExprNode::): Take a SourceRange and set it on the body. (KJS::FuncDeclNode::): ditto
kjs/testkjs.cpp: (prettyPrintScript): Use a SourceProvider appropriately.
JavaScriptCore.exp: Export new symbols.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add new files.
JavaScriptCore.xcodeproj/project.pbxproj: Add new files.

JavaScriptGlue:

2008-05-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

JavaScriptGlue part of fix for: "SQUIRRELFISH: function toString broken after calling" https://bugs.webkit.org/show_bug.cgi?id=18869

JSRun.cpp: (JSRun::Evaluate): Use UString version of eveluate() instead of the now departed UChar*/length variant; use of the lower-level version was gratuitous in any case. (JSRun::CheckSyntax): Ditto for checkSyntax().

WebCore:

2008-05-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

JavaScriptGlue part of fix for: "SQUIRRELFISH: function toString broken after calling" https://bugs.webkit.org/show_bug.cgi?id=18869

bindings/js/StringSourceProvider.h: Added. SourceProvider subclass backed by a WebCore::String. (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::getRange): (WebCore::StringSourceProvider::data): (WebCore::StringSourceProvider::length): (WebCore::StringSourceProvider::StringSourceProvider):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Pass a StringSourceProvider to evaluate() instead of UChar* / length.
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::text): Modified to return the original string as-is when the script element contains only a single text node, to avoid excess memory use.

WebCore.vcproj/WebCore.vcproj: Add new file to build.
WebCore.xcodeproj/project.pbxproj: ditto

LayoutTests:

2008-05-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

test changes for: "SQUIRRELFISH: function toString broken after calling" https://bugs.webkit.org/show_bug.cgi?id=18869

All of these tests expected function.toString to somewhat change
things from the raw original source. They are now prepared for the
fact that this does not happen.