Timeline
May 24, 2008:
- 10:25 PM Changeset in webkit [34116] by
-
- 2 edits in trunk/WebKitTools
2008-05-24 Andreia Gaita <shana@isninja.com>
Reviewed by Alp Toker.
cygwin-downloader.py fixes.
Remove two non-working mirrors. Add a check for missing dependency
packages to avoid bailing out on an inconsistent Cygwin package list.
- CygwinDownloader/cygwin-downloader.py:
- 9:47 PM Changeset in webkit [34115] by
-
- 2 edits in trunk/WebCore
Fixes a huge leak with the Inspector where it was protecting
a large object that was not being unprotected.
<rdar://problem/5961999> Inspector protects a large JavaScript
object and never unprotects it (large leak)
Reviewed by Darin Adler.
- page/InspectorController.cpp:
(WebCore::InspectorController::inspectedPageDestroyed): Call close()
and removed a call to stopDebugging() and moved it to close().
(WebCore::InspectorController::close): Add stopDebugging() and
stopUserInitiatedProfiling(). Removed an ASSERT and added an
if statement before calling JSValueUnprotect. We don't always have
a m_scriptContext and m_scriptObject.
- 9:24 PM Changeset in webkit [34114] by
-
- 1 edit in trunk/JavaScriptCore/docs
Ignore generated bytecode.html file.
- 9:19 PM Changeset in webkit [34113] by
-
- 2 edits in trunk
2008-05-24 Alp Toker <alp@nuanti.com>
GTK+/Win32 build fixes. Link against Windows ICU without using
icu-config since it's not available on that platform.
Link against Ws2_32 when the curl http backend is chosen since we
use select() directly.
- configure.ac:
- 8:45 PM Changeset in webkit [34112] by
-
- 2 edits in trunk/WebCore
2008-05-24 Alp Toker <alp@nuanti.com>
Win32/gcc3 build fix in Pango font backend. UChar needs to be
explicitly cast to gunichar2.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8):
- 6:58 PM Changeset in webkit [34111] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-24 Alp Toker <alp@nuanti.com>
Win32/gcc build fix. Remove MSVC assumption.
- wtf/TCSpinLock.h: (TCMalloc_SlowLock):
- 6:51 PM Changeset in webkit [34110] by
-
- 2 edits in trunk/WebKit/gtk
2008-05-24 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=18825
webkitgtk fails to build from source: "Database Tracker" has not been declared
GTK+ fix for building without database support.
exceededDatabaseQuota() still needs to be present, just a no-op.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
- 6:01 PM Changeset in webkit [34109] by
-
- 3 edits in trunk/WebCore
Fixes a crash where a new Inspector would get an old
JSInspectedObjectWrapper for a user agent CSSStyleDeclaration.
Since these style objects shared between pages, the wrapper cache
would have a wrapper for the object still. But the wrapper was
for a previous global object and with a disconnected frame. This
fixes the wrapper cache so wrappers are remembered per global object
and the object they are wrapping.
<rdar://problem/5958567> repro crash in WebCore::Frame::keepAlive()
opening inspector window after closing it
Reviewed by Darin Adler.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::wrappers): Return a GlobalObjectWrapperMap reference.
(WebCore::JSInspectedObjectWrapper::wrap): Find the WrapperMap
by the dynamicGlobalObject then find the wrapper for unwrappedObject.
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Changes
how the wrapper is added to the wrapper cache.
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Changes
how the wrapper is removed from the wrapper cache.
- bindings/js/JSQuarantinedObjectWrapper.h:
(WebCore::JSQuarantinedObjectWrapper:unwrappedGlobalObject): Added.
- 2:12 PM Changeset in webkit [34108] by
-
- 8 edits2 adds in trunk/WebCore
Reviewed by Maciej.
Optimize Node::textContent() to avoid O(n2) string appending behavior.
1.6% speedup at Acid3 test 26.
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- WebCore.vcproj/WebCore.vcproj:
- platform/text/StringBuilder.cpp: Added. (WebCore::StringBuilder::append): (WebCore::StringBuilder::toString):
- platform/text/StringBuilder.h: Added. (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::isNull): Added a simple class to efficiently build a string by appending. Potentially, it can be extended to be more like java.lang.StringBuilder, but we don't need that much flexibility now.
- dom/Node.cpp: (WebCore::Node::appendTextContent): (WebCore::Node::textContent):
- dom/Node.h: Changed to use StringBuilder.
- 6:26 AM Changeset in webkit [34107] by
-
- 8 edits4 deletes in trunk/WebCore
2008-05-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 9191: JS*ElementWrapperFactory should be autogenerated
https://bugs.webkit.org/show_bug.cgi?id=9191
This is a first pass for generation of JS*ElementWrapperFactory, in the long term we should move the make_names.pl
intelligence to the *.in files.
- Add a new parameter to make_names.pl --wrapperFactory which works like --wrapper but generates the JS*ElementWrapperFactory files.
- Removed JS*ElementWrapperFactory files in WebCore/bindings/js, replaced by the generated ones.
- Updated the build systems to account for the previous changes.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSHTMLElementWrapperFactory.cpp: Removed.
- bindings/js/JSHTMLElementWrapperFactory.h: Removed.
- bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
- bindings/js/JSSVGElementWrapperFactory.h: Removed.
- dom/make_names.pl:
- 5:48 AM Changeset in webkit [34106] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixed ChangeLog.
- 5:43 AM Changeset in webkit [34105] by
-
- 5 edits in trunk
Rubber-stamped, tweaked and landed by Alexey.
Build fix for gcc 4.3. Added missing standard includes.
May 23, 2008:
- 11:34 PM Changeset in webkit [34104] by
-
- 2 edits in trunk/WebCore
Fixes a bug where a timer would keep firing after the Inspector
was closed. It turns out this timer wasn't needed anymore now
that we can add an event listener to the inspected page and have
it get called in the Inspector's context.
https://bugs.webkit.org/show_bug.cgi?id=18577
Reviewed by Mark Rowe.
- page/inspector/ElementsPanel.js:
- 9:18 PM Changeset in webkit [34103] by
-
- 3 edits2 copies in tags/Safari-6526.8
Merge r34097.
- 8:52 PM Changeset in webkit [34102] by
-
- 3 edits in trunk/WebCore
2008-05-23 Anthony Ricaud <rik24d@gmail.com>
Changes the largerResourcesButton tooltip to toggle.
Reviewed by Tim Hatcher.
- WebCore/English.lproj/localizedStrings.js: New string and clean an double string "Dock to main window."
- WebCore/page/inspector/ResourcesPanel.js: Toggle the tooltip and change the default tooltip
- 7:47 PM Changeset in webkit [34101] by
-
- 4 edits in trunk
Versioning.
- 7:44 PM Changeset in webkit [34100] by
-
- 1 copy in tags/Safari-6526.8
New tag.
- 6:33 PM Changeset in webkit [34099] by
-
- 6 edits in trunk/WebKitTools
2008-05-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Darin Adler.
Remove useQmake usage. QMake build doesn't support Gtk port
anymore.
Also fix 2 occurences of "Web Kit". Should be WebKit.
- Scripts/build-webkit:
- Scripts/run-javascriptcore-tests:
- Scripts/run-launcher:
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 5:56 PM Changeset in webkit [34098] by
-
- 2 edits in trunk/LayoutTests/editing/execCommand
Check Paste, instead of checking Copy twice.
- 5:29 PM Changeset in webkit [34097] by
-
- 3 edits2 adds in trunk
WebCore:
2008-05-23 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)
Execute cut, copy and paste if they are invoked explicitly, via execCommand or -[WebView copy:], even
if they are disabled. This will fire oncopy, oncut and onpaste, but won't perform any other work, like
writing to the pasteboard during cut/copy or deleting the selection during cut/paste. This matches FF3,
which actually goes further and fires oncopy on any Command-C.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::): (WebCore::Editor::Command::execute):
LayoutTests:
2008-05-23 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)
- editing/execCommand/5939887-expected.txt: Added.
- editing/execCommand/5939887.html: Added.
- 4:51 PM Changeset in webkit [34096] by
-
- 4 edits1 add in trunk/WebCore
Adds a percentage toggle button the profile view status bar that
changes the time columns between absolute and percents.
https://bugs.webkit.org/show_bug.cgi?id=19224
Reviewed by Kevin McCullough.
- English.lproj/localizedStrings.js: New strings.
- page/inspector/Images/percentButtons.png: Added.
- page/inspector/ProfileView.js: Make the button and add it to the
status bar. Make clicking toggle the showAsPercent* properties.
- page/inspector/inspector.css: New styles.
- 4:44 PM Changeset in webkit [34095] by
-
- 5 edits in trunk/JavaScriptCore
2008-05-23 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5959886> REGRESSION: Assertion failure in JSImmediate::toString when loading GMail (19217)
Change List to store a JSValue* pointer + an offset instead of a JSValue pointer to protect against the case where
a register file changes while a list object points to its buffer.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/JSActivation.cpp: (KJS::JSActivation::createArgumentsObject):
- kjs/list.cpp: (KJS::List::getSlice):
- kjs/list.h: (KJS::List::List): (KJS::List::at): (KJS::List::append): (KJS::List::begin): (KJS::List::end): (KJS::List::buffer):
- 4:41 PM Changeset in webkit [34094] by
-
- 3 edits in trunk/WebKitSite
2008-05-23 William Siegrist <wsiegrist@apple.com>
Reviewed by Mark Rowe
Rename duplicated "notice" id to "terms".
- css/main.css:
- nav.inc:
- 4:37 PM Changeset in webkit [34093] by
-
- 3 edits in trunk/LayoutTests
2008-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
LayoutTests that send an OPTIONS request don't work on Tiger or Window due
to a bug in Apache 1.3
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 4:07 PM Changeset in webkit [34092] by
-
- 3 edits in trunk/JavaScriptCore
2008-05-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam.
<rdar://problem/5960012> JSProfiler: Stack overflow if recursion is
too deep.
-Use a simple depth limit to restrict too deep of recursion.
- profiler/Profile.cpp: (KJS::Profile::willExecute): (KJS::Profile::didExecute):
- profiler/Profile.h:
- 2:30 PM Changeset in webkit [34091] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Removed terrible lie from ChangeLog.
- 2:28 PM Changeset in webkit [34090] by
-
- 5 edits in trunk/JavaScriptCore
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Rolling back in r34085, with performance resolved.
Apparently, passing the eval function to callEval gave GCC a hernia.
Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.
Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
JavaScript profiler
- VM/Machine.cpp: (KJS::callEval): Made this profiler hooks slightly faster by passing in the eval function.
(KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
when unwinding from inside eval and/or program code: detect the
difference, and do the right thing. Also, be sure to notify the profiler
*before* deref'ing the scope chain, since the profiler uses the scope chain.
(KJS::Machine::execute): Fixed incorrect reporting / crash when calling
a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
should not invoke the didExecute hook, because op_ret already does that.
Also, use the new function's ExecState when calling out to the profiler.
(Not important now, but could have become a subtle bug later.)
(KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
profiling JS functions: notify the profiler *before* deref'ing the scope
chain, since the profiler uses the scope chain.
- kjs/object.cpp: (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.
- profiler/Profile.cpp: Added a comment to explain a subtlety that only Kevin and I understood previously. (Now, the whole world can understand!)
- profiler/Profiler.cpp: (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was a hack to fix bugs that no longer exist.
Finally, sped things up a little bit by changing the "Is the profiler
running?" check into an ASSERT, since we only call into the profiler
when it's running:
(KJS::Profiler::willExecute):
(KJS::Profiler::didExecute):
- 1:49 PM Changeset in webkit [34089] by
-
- 3 edits2 adds in trunk
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
- fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
SunSpider reports no change.
This is a reworking of r34073, which I rolled out because it caused
lots of crashes.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Use removeDirect to nix old properties whose names collide with new functions. (Don't use putWithAttributes because that tries to write to the register file, which hasn't grown to fit this program yet.)
LayoutTests:
2008-05-23 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
- fast/js/function-redefinition-expected.txt: Added.
- fast/js/function-redefinition.html: Added.
- 12:42 PM Changeset in webkit [34088] by
-
- 6 edits in trunk/JavaScriptCore
2008-05-23 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
As allocateNumber is used via jsNumberCell outside of JavaScriptCore,
we need to provide a non-inlined version of it to avoid creating a
weak external symbol.
- JavaScriptCore.exp:
- kjs/AllInOneFile.cpp:
- kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::allocateNumber):
- kjs/collector.h: (KJS::Collector::allocate): (KJS::Collector::inlineAllocateNumber):
- kjs/value.h: (KJS::NumberImp::operator new):
- 12:34 PM Changeset in webkit [34087] by
-
- 3 edits2 deletes in trunk
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Rolled out r34073 because it caused lots of layout test crashes.
LayoutTests:
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Rolled out r34073 because it caused lots of layout test crashes.
- 12:12 PM Changeset in webkit [34086] by
-
- 5 edits in trunk/JavaScriptCore
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Rolled out r34085 because it measured as a 7.6% performance regression.
- 10:50 AM Changeset in webkit [34085] by
-
- 5 edits in trunk/JavaScriptCore
2008-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.
Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
JavaScript profiler
- VM/Machine.cpp: (KJS::callEval): Made this profiler hooks slightly faster by passing in the eval function.
(KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
when unwinding from inside eval and/or program code: detect the
difference, and do the right thing. Also, be sure to notify the profiler
*before* deref'ing the scope chain, since the profiler uses the scope chain.
(KJS::Machine::execute): Fixed incorrect reporting / crash when calling
a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
should not invoke the didExecute hook, because op_ret already does that.
Also, use the new function's ExecState when calling out to the profiler.
(Not important now, but could have become a subtle bug later.)
(KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
profiling JS functions: notify the profiler *before* deref'ing the scope
chain, since the profiler uses the scope chain.
- kjs/object.cpp: (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.
- profiler/Profile.cpp: Added a comment to explain a subtlety that only Kevin and I understood previously. (Now, the whole world can understand!)
- profiler/Profiler.cpp: (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was a hack to fix bugs that no longer exist.
Finally, sped things up a little bit by changing the "Is the profiler
running?" check into an ASSERT, since we only call into the profiler
when it's running:
(KJS::Profiler::willExecute):
(KJS::Profiler::didExecute):
- 10:48 AM Changeset in webkit [34084] by
-
- 4 edits in trunk
2008-05-23 Alp Toker <alp@nuanti.com>
GTK+ fixes for building without database support.
- 10:41 AM Changeset in webkit [34083] by
-
- 2 edits in trunk/WebCore
Fixes a bug where excluding nodes from the profile could
show an empty parent node.
<rdar://problem/5959573> Excluding nodes from the profile could show
an empty parent node
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: Only say we have children if
all of our children nodes are visible.
- 10:19 AM Changeset in webkit [34082] by
-
- 2 edits in trunk/WebCore
2008-05-23 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Add IconFetcher to project.
- WebCore.vcproj/WebCore.vcproj:
- 10:15 AM Changeset in webkit [34081] by
-
- 2 edits in trunk/WebCore
Fixes a bug where the Web Insepctor would jump back to
Elements each time it is opened instead of staying at the
last selected panel.
<rdar://problem/5959475> Inspector jumps to the Elements panel
each time it is opened, instead of staying at the previous panel
Reviewed by Adam Roben.
- page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Reset
m_showAfterVisible to CurrentPanel, so the next time setWindowVisible
is called it will use CurrentPanel unless showPanel was called again.
- 10:03 AM Changeset in webkit [34080] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add the profiler directory to the include path.
- 9:54 AM Changeset in webkit [34079] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5933759> REGRESSION: Frames don't appear as AX children of the top level web area
- 9:38 AM Changeset in webkit [34078] by
-
- 6 edits3 adds in trunk/WebKit/win
2008-05-22 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Add IWebIconFetcher interface and implementation.
- Interfaces/IWebFramePrivate.idl:
- Interfaces/IWebIconFetcher.idl: Added.
- Interfaces/WebKit.idl:
- WebFrame.cpp:
- WebFrame.h:
- WebIconFetcher.cpp: Added.
- WebIconFetcher.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- 8:23 AM Changeset in webkit [34077] by
-
- 2 edits in trunk/WebKit/qt
2008-05-21 Siraj Razick <siraj.razick@collabora.co.uk>
Reviewed by Simon.
Add <param name="classid"/> support for application/x-qt-object plugins
- 7:24 AM Changeset in webkit [34076] by
-
- 3 edits in trunk/WebCore
2008-05-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
For Qt port, support painting to native Windows HDC.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
- 7:23 AM Changeset in webkit [34075] by
-
- 4 edits in trunk/JavaScriptCore
SQUIRRELFISH: JavaScript error messages are missing informative text
Reviewed by Anders
Partial fix.
Tidy up error messages, makes a couple of them provide slightly more info.
Inexplicably leads to a 1% SunSpider Progression.
- 4:37 AM Changeset in webkit [34074] by
-
- 2 edits in trunk/JavaScriptCore
Fix call stack reported by profiler when entering event handlers.
Reviewed by Tim H
JSObject::call was arbitrarily notifying the profiler when it was
called, even if it was JS code, which notifies the profile on entry
in any case.
- 3:43 AM Changeset in webkit [34073] by
-
- 3 edits2 adds in trunk
2008-05-23 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Delete any existing properties before creating the function (this should really be done at execution time not codegen time).
LayoutTests:
2008-05-23 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
- fast/js/function-redefinition-expected.txt: Added.
- fast/js/function-redefinition.html: Added.
- 3:12 AM Changeset in webkit [34072] by
-
- 5 edits in trunk/WebCore
Fixes a bug where the Inspector could have 0ms timers firing
even after it is closed.
https://bugs.webkit.org/show_bug.cgi?id=18577
Reviewed by Oliver Hunt.
- page/inspector/DatabasesPanel.js: Removes setTimeouts that call
the same function with a 0ms delay. These we not doing any good anyway,
so they weren't needed and just caused problems.
- page/inspector/ElementsPanel.js: Ditto.
- page/inspector/ProfilesPanel.js: Ditto.
- page/inspector/ResourcesPanel.js: Ditto.
- 2:54 AM Changeset in webkit [34071] by
-
- 2 edits in trunk/JavaScriptCore
+2008-05-16 Alp Toker <alp@nuanti.com>
Build fix for gcc 3. Default constructor required in ExecState,
used by OldInterpreterExecState.
- kjs/ExecState.h: (KJS::ExecState::ExecState):
- 2:41 AM Changeset in webkit [34070] by
-
- 4 edits in trunk/WebCore
Make the Inspector correctly populate the profiles when
closed and re-opened.
Reviewed by Adam Roben.
- page/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects): Call populateInterface
in inspector.js.
- page/inspector/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.populateInterface): If visible,
call _populateProfiles. Else just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype.reset): Don't call _populateProfiles.
Just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype._populateProfiles): Delete
this._shouldPopulateProfiles.
- page/inspector/inspector.js:
(WebInspector.populateInterface): Added. Call populateInterface on all the
panels if they implement it.
- 2:38 AM Changeset in webkit [34069] by
-
- 5 edits in trunk
Fix <rdar://problem/5954997> global-recursion-on-full-stack.html crashes under guardmalloc.
Growing the register file with uncheckedGrow from within Machine::execute is not safe as the
register file may be too close to its maximum size to grow successfully. By using grow,
checking the result and throwing a stack overflow error we can avoid crashing.
Reviewed by Oliver Hunt.
- VM/Machine.cpp:
(KJS::Machine::execute):
- VM/RegisterFile.h: Remove the now-unused uncheckedGrow.
- 2:32 AM Changeset in webkit [34068] by
-
- 6 edits in trunk/WebCore
2008-05-23 Kevin McCullough <kmccullough@apple.com>
RS = Adam.
Editorial changes
- manual-tests/inspector/profiler-test-apply.html:
- manual-tests/inspector/profiler-test-document-dot-write.html:
- manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html:
- manual-tests/inspector/profiler-test-one-execution-context.html:
- manual-tests/inspector/profiler-test-two-execution-contexts.html:
- 2:07 AM Changeset in webkit [34067] by
-
- 4 edits in trunk/JavaScriptCore
Remove JAVASCRIPT_PROFILER define
RS=Kevin McCullough
- 2:01 AM Changeset in webkit [34066] by
-
- 2 edits in trunk/WebCore
Fixes the bug where the profile was not added when finished.
<rdar://problem/5958851> Stop Profiling from the Develop menu does
not add the Profile to the Inspector
Reviewed by Adam Roben.
- page/InspectorController.cpp:
(WebCore::InspectorController::stopUserInitiatedProfiling): Call
addProfile with the result of stopProfiling.
- 1:56 AM Changeset in webkit [34065] by
-
- 5 edits in trunk/JavaScriptCore
<rdar://problem/5951561> Turn on JavaScript Profiler
Reviewed by Kevin McCullough
Flipped the switch on the profiler, rearranged how we
signal the the profiler is active so that calls aren't
needed in the general case.
Also fixed the entry point for Machine::execute(FunctionBodyNode..)
to correctly indicate function exit.
Results in a 0.7-1.0% regression in SunSpider :-(
- 1:35 AM Changeset in webkit [34064] by
-
- 2 edits in trunk/WebCore
Tweak the Web Insector toolbar look to be smaller when attached to
the inspected page.
Reviewed by Adam Roben.
- page/inspector/inspector.css:
- 1:03 AM Changeset in webkit [34063] by
-
- 2 edits in trunk/WebKit/mac
Fix attaching and detaching the Web Inspector. This change removes
the clunky animation that never looked right and was causing issues
where the inspected WebView would get into a no useable state.
<rdar://problem/5958812> Attaching and Detaching the Web Inspector
can cause the inspected WebVIew to be unusable
Reviewed by Adam Roben.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController close]): Removes animation code.
Sets the frame directly and does a displayIfNeeded to prevent
showing the Inspector in the page and in the Inspector window.
(-[WebInspectorWindowController showWindow:]): Removes animation code.
Sets the frame directly.
(-[WebInspectorWindowController attach]): Simplified.
(-[WebInspectorWindowController detach]): Ditto.
- 12:58 AM Changeset in webkit [34062] by
-
- 4 edits in trunk
Fix the Qt build by adding profiler/ to the include path and providing
an empty stub for AXObjectCache::handleAriaRoleChanged to build without
accessibility.
- 12:05 AM Changeset in webkit [34061] by
-
- 3 edits in trunk/WebCore
2008-05-23 Alice Liu <alice.liu@apple.com>
Reviewed by Mark Rowe.
Remove call to function whose body was commented out. Returning the
children for a menu button by the normal calculation works just as well.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addChildren):
- page/AccessibilityRenderObject.h:
