⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 25, 2008:

7:57 PM ApplicationsGtk edited by alp@atoker.com
Update an entry (diff)
7:29 PM Changeset in webkit [34130] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined

Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.

Reviewed by Darin Adler.

  • WebView/WebFrame.mm:

(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
4:55 PM Changeset in webkit [34129] by Chris Fleizach
  • 5 edits in trunk/WebCore

<rdar://problem/3582905> elements on separate pages need to be distinct

4:23 PM Changeset in webkit [34128] by mjs@apple.com
  • 4 edits in trunk/WebCore

2008-05-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • don't repaint nodes that are removed before layout 4.3% speedup on Acid3 test 26

Mitz points out the new flag can also be used to optimize other
cases of needless repaint such as
<​https://bugs.webkit.org/show_bug.cgi?id=15129>.


  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): If the child has never had a layout, don't bother to repaint it, since there's nothing to dirty.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): Initialize m_everHadLayout to false. (WebCore::RenderObject::setNeedsLayout): Set m_everHadLayout to true if we are being marked as not needing layout.
  • rendering/RenderObject.h:
1:13 PM Changeset in webkit [34127] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/caret-outside-block.html

  • editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Restored this function which was removed in r28523, but changed it to inflate only the width. (WebCore::SelectionController::caretRepaintRect): Changed back to use repaintRectForCaret(). (WebCore::SelectionController::recomputeCaretRect): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/caret-outside-block.html: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.txt: Added.
7:36 AM Changeset in webkit [34126] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-25 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18940
[CURL] Allow \n as line terminator for headers

The line terminator for message-header fields should be CRLF. However,
it is recommended to recognise as a line terminator also a single LF.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Allow headers to be terminated by "\n" and not just by "\r\n".
7:14 AM Changeset in webkit [34125] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Alp Toker <​alp@nuanti.com>

Reviewed by Niko.

Drop WebView focus when the widget is focused out.

  • webkit/webkitwebview.cpp:
4:30 AM Changeset in webkit [34124] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Alexey.

Fix the test.

4:15 AM Changeset in webkit [34123] by jmalonzo@webkit.org
  • 4 edits in trunk

2008-05-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19142
[Gtk] Remove build options --svg-experimental and --cross-document-messaging

  • configure.ac
  • WebCore/GNUmakefile.am:
3:41 AM Changeset in webkit [34122] by rwlbuis@webkit.org
  • 12 edits in trunk/LayoutTests

RS=Oliver

Fix SVG test results for tiger buildbot.

2:55 AM Changeset in webkit [34121] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18935
[Gtk] Plugin Load crashes with NP_FULL mode

Fix crash due to uninitialized variable.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient):
12:46 AM Changeset in webkit [34120] by oliver@apple.com
  • 12 edits in trunk/LayoutTests

Fix leopard results following changes to SVG path dumping.

RS=Alexey

12:35 AM Changeset in webkit [34119] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fixing a typo in the previous commit made as a last minute change.

  • kjs/regexp_object.cpp:
12:15 AM Changeset in webkit [34118] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changed regular expression matching result array to be lazily filled, because many callers
only care about it being non-null.

2% improvement on Acid3 test 26.

  • kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses to use.
  • kjs/array_instance.h: (KJS::ArrayInstance::lazyCreationData): (KJS::ArrayInstance::setLazyCreationData): Added methods to access it from subclasses.
  • kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpObjectImp::arrayOfMatches): RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until accessed for the first time.
12:11 AM Changeset in webkit [34117] by rwlbuis@webkit.org
  • 595 edits in trunk

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=18927
Unify path data debug output

Implement unified path data output for Mac svg tests.

May 24, 2008:

10:25 PM Changeset in webkit [34116] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-05-24 Andreia Gaita <​shana@isninja.com>

Reviewed by Alp Toker.

cygwin-downloader.py fixes.

Remove two non-working mirrors. Add a check for missing dependency
packages to avoid bailing out on an inconsistent Cygwin package list.

  • CygwinDownloader/cygwin-downloader.py:
9:47 PM Changeset in webkit [34115] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a huge leak with the Inspector where it was protecting
a large object that was not being unprotected.

<rdar://problem/5961999> Inspector protects a large JavaScript
object and never unprotects it (large leak)

Reviewed by Darin Adler.

  • page/InspectorController.cpp:

(WebCore::InspectorController::inspectedPageDestroyed): Call close()
and removed a call to stopDebugging() and moved it to close().
(WebCore::InspectorController::close): Add stopDebugging() and
stopUserInitiatedProfiling(). Removed an ASSERT and added an
if statement before calling JSValueUnprotect. We don't always have
a m_scriptContext and m_scriptObject.

9:24 PM Changeset in webkit [34114] by Darin Adler
  • 1 edit in trunk/JavaScriptCore/docs

Ignore generated bytecode.html file.

9:19 PM Changeset in webkit [34113] by alp@webkit.org
  • 2 edits in trunk

2008-05-24 Alp Toker <​alp@nuanti.com>

GTK+/Win32 build fixes. Link against Windows ICU without using
icu-config since it's not available on that platform.

Link against Ws2_32 when the curl http backend is chosen since we
use select() directly.

  • configure.ac:
8:45 PM Changeset in webkit [34112] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-24 Alp Toker <​alp@nuanti.com>

Win32/gcc3 build fix in Pango font backend. UChar needs to be
explicitly cast to gunichar2.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8):
6:58 PM Changeset in webkit [34111] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-05-24 Alp Toker <​alp@nuanti.com>

Win32/gcc build fix. Remove MSVC assumption.

  • wtf/TCSpinLock.h: (TCMalloc_SlowLock):
6:51 PM Changeset in webkit [34110] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-24 Alp Toker <​alp@nuanti.com>

​https://bugs.webkit.org/show_bug.cgi?id=18825
webkitgtk fails to build from source: "Database Tracker" has not been declared

GTK+ fix for building without database support.
exceededDatabaseQuota() still needs to be present, just a no-op.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
6:01 PM Changeset in webkit [34109] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a crash where a new Inspector would get an old
JSInspectedObjectWrapper for a user agent CSSStyleDeclaration.
Since these style objects shared between pages, the wrapper cache
would have a wrapper for the object still. But the wrapper was
for a previous global object and with a disconnected frame. This
fixes the wrapper cache so wrappers are remembered per global object
and the object they are wrapping.

<rdar://problem/5958567> repro crash in WebCore::Frame::keepAlive()
opening inspector window after closing it

Reviewed by Darin Adler.

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::wrappers): Return a GlobalObjectWrapperMap reference.
(WebCore::JSInspectedObjectWrapper::wrap): Find the WrapperMap
by the dynamicGlobalObject then find the wrapper for unwrappedObject.
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Changes
how the wrapper is added to the wrapper cache.
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Changes
how the wrapper is removed from the wrapper cache.

  • bindings/js/JSQuarantinedObjectWrapper.h:

(WebCore::JSQuarantinedObjectWrapper:unwrappedGlobalObject): Added.

2:12 PM Changeset in webkit [34108] by ap@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Maciej.

Optimize Node::textContent() to avoid O(n2) string appending behavior.

1.6% speedup at Acid3 test 26.

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/text/StringBuilder.cpp: Added. (WebCore::StringBuilder::append): (WebCore::StringBuilder::toString):
  • platform/text/StringBuilder.h: Added. (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::isNull): Added a simple class to efficiently build a string by appending. Potentially, it can be extended to be more like java.lang.StringBuilder, but we don't need that much flexibility now.
  • dom/Node.cpp: (WebCore::Node::appendTextContent): (WebCore::Node::textContent):
  • dom/Node.h: Changed to use StringBuilder.
6:26 AM Changeset in webkit [34107] by jchaffraix@webkit.org
  • 8 edits
    4 deletes in trunk/WebCore

2008-05-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 9191: JS*ElementWrapperFactory should be autogenerated
​https://bugs.webkit.org/show_bug.cgi?id=9191

This is a first pass for generation of JS*ElementWrapperFactory, in the long term we should move the make_names.pl
intelligence to the *.in files.

  • Add a new parameter to make_names.pl --wrapperFactory which works like --wrapper but generates the JS*ElementWrapperFactory files.
  • Removed JS*ElementWrapperFactory files in WebCore/bindings/js, replaced by the generated ones.
  • Updated the build systems to account for the previous changes.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Removed.
  • bindings/js/JSHTMLElementWrapperFactory.h: Removed.
  • bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
  • bindings/js/JSSVGElementWrapperFactory.h: Removed.
  • dom/make_names.pl:
5:48 AM Changeset in webkit [34106] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed ChangeLog.

5:43 AM Changeset in webkit [34105] by ap@webkit.org
  • 5 edits in trunk

Rubber-stamped, tweaked and landed by Alexey.

Build fix for gcc 4.3. Added missing standard includes.

Note: See TracTimeline for information about the timeline view.