Timeline
May 26, 2008:
- 10:04 PM Changeset in webkit [34145] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-26 Stephanie Lewis <Stephanie Lewis>
Windows build fix.
- kjs/testkjs.cpp:
- 7:48 PM Changeset in webkit [34144] by
-
- 3 edits in trunk/WebCore
2008-05-26 Alp Toker <alp@nuanti.com>
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=16495
[GTK] Accessibility support with ATK/AT-SPI
Implement basic action, text and editable text accessibility.
Provide utility functions to simplify const string return and casting
and add some more stubs.
It's now possible to navigate and manipulate forms and text using
assistive technologies.
- page/gtk/AccessibilityObjectWrapperAtk.cpp: (returnString): (core):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::imageTitle):
- 7:10 PM Changeset in webkit [34143] by
-
- 14 edits in trunk
2008-05-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- make addStaticGlobals protected instead of private so subclasses can use it
- JavaScriptCore.exp:
- kjs/JSGlobalObject.h:
WebCore:
2008-05-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- bind the window's "document" and "window" properties to static slots 1.7% speedup on Acid3 test 26
Only the "document" part matters for Acid3, but since I was doing
this anyway, "window" also seemed like a good one to optimize.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable slots for document and window; but just put null in the document slot for now. (WebCore::JSDOMWindowBase::updateDocument): Fill in the document slot. (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop tracking us.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet for our still-not-dead inner windows. (WebCore::JSDOMWindowShell::updateDocument): Update all our inner windows ever (to make sure the update to the document property shows up everywhere).
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow): Update our hash. (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Don't set self as a property map property of the window, this is no longer necessary.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript): Update document for the newly created window.
- bindings/js/kjs_proxy.h:
- page/Frame.cpp: (WebCore::Frame::setDocument): If the document is not null, update our window.
LayoutTests:
2008-05-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- update test result for document/window being allocated to var slots
- http/tests/security/cross-frame-access-put-expected.txt:
- 4:49 PM Changeset in webkit [34142] by
-
- 13 edits in trunk/LayoutTests
2008-05-26 James Ren <jamesjren@gmail.com>
Reviewed by Sam Weinig, landed by Collin Jackson.
Modified some http/security layout tests to allow them to run in Firefox.
- http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
- http/tests/security/resources/localhost-accesssor.html: Added a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=434912
- http/tests/security/resources/cross-frame-access.js: Changed shouldBe to also gracefully handle exceptions
- http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added feature detection for setBaseAndExtent and selectAllChildren
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- http/tests/security/cross-frame-access-enumeration.html: Fixed typo (missing '.html')
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- http/tests/security/cross-frame-access-first-time.html:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/cross-frame-access-selection.html: Caught exceptions that Firefox throws, to allow the test to run to completion.
- 2:13 PM Changeset in webkit [34141] by
-
- 7 edits1 add in trunk/WebCore
2008-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
This patch does two things:
- It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know that the node doesn't have a wrapper. This avoids a hash lookup.
- It adds toJSNewlyCreated methods for JSElement and JSText.
All in all this is a 4.3% speedup on Acid 3 test 26.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
- bindings/js/JSTextCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- 1:53 PM Changeset in webkit [34140] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed date of ChangeLog entry.
- 1:41 PM Changeset in webkit [34139] by
-
- 7 edits in trunk/WebCore
2008-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
and JSDocument for a 1-2% speedup on Acide 3 test 26.
- bindings/js/JSEventTargetNode.cpp:
- bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 1:07 PM Changeset in webkit [34138] by
-
- 16 edits in trunk/WebCore
2008-05-25 Darin Adler <Darin Adler>
Reviewed by Maciej.
Removed code that would only useful if if there was any way to create an Entity
node or if we populated EntityReference nodes. It's likely that we'll remove
these node types entirely in some future version of WebKit, depending in part
on what happens with these in HTML 5.
1.8% speedup of Acid3 test 26.
The only read-only nodes we ever create are EntityReference nodes.
These are only created by explicit calls to the Document.createEntityReference
function. Since the created nodes are read-only, there can be no children of
these nodes, so no other types of nodes can be read-only despite the rule that
makes descendants of Entity and EntityReference nodes read-only.
- bindings/objc/DOM.mm: Removed unneeded include.
- dom/Attr.cpp: (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check. (WebCore::Attr::setNodeValue): Ditto.
- dom/CharacterData.cpp: (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::substringData): Don't initialize the ec variable before calling checkCharDataOperation, since that function already does it. (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::insertData): Don't initialize ec. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setNodeValue): Removed now-misleading comment. (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary isReadOnlyNode check.
- dom/CharacterData.h: Made checkCharDataOperation private and non-virtual since it's never used or defined in any other class.
- dom/Element.cpp: (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.
- dom/Entity.cpp: Removed the entire contents of this file.
- dom/Entity.h: Replaced the class with a stub -- just enough to keep the public bindings (JavaScript and Objective-C compiling), but the class is abstract and can't be instantianted.
- dom/EntityReference.cpp: Removed unused constructor. (WebCore::EntityReference::cloneNode): Removed unneeded code and comments to clone nonexistent child nodes.
- dom/EntityReference.h: Removed unused constructor and unnecessary override of childTypeAllowed, since no children are allowed at all.
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check. (WebCore::NamedAttrMap::removeNamedItem): Ditto.
- dom/NamedAttrMap.h: Removed isReadOnlyNode function.
- dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of virtual nodeType function calls.
- dom/Node.h: (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode function with a new simple non-virtual one.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode check.
- dom/Text.cpp: (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check. (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion. There is no reason for this function to go out of its way to mention the read-only node issue when none of the other DOM mutation functions do.
- 12:38 PM Changeset in webkit [34137] by
-
- 2 edits in trunk/WebCore
2008-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Sam.
Cleanup SecurityOrigin::canAccess. Removed comment referring to an
old version of the code. Removed some useless code.
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
- 11:57 AM Changeset in webkit [34136] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors'
- 11:50 AM Changeset in webkit [34135] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
error, all profile stack frames are incorrect
SunSpider reports a .3% speedup, possibly because eval of a string is a
little more efficient now.
- VM/Machine.cpp: (KJS::callEval): Make sure to call didExecute when returning early. I simplified this function to remove one early return, making the job of adding special code to early returns easier.
(KJS::Machine::execute): Use the new function ExecState when notifying
the profiler. (This doesn't change behavior now, but it might lead to
subtle errors in the future.)
- 11:43 AM Changeset in webkit [34134] by
-
- 3 edits in trunk/LayoutTests
2008-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Add a name to the source frame.
- fast/frames/viewsource-empty-attribute-value-expected.txt:
- fast/frames/viewsource-empty-attribute-value.html:
- 5:45 AM Changeset in webkit [34133] by
-
- 2 edits in trunk/WebCore
2008-05-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
Reviewed by Alp Toker.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.
- 5:29 AM Changeset in webkit [34132] by
-
- 4 edits in trunk
2008-05-23 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fixed toLower and toUpper implementations to allow being called
with a null result pointer and resultLength, to determine the
number of characters needed for the case conversion.
LayoutTests:
008-05-23 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Added a comment to the skipping of fast/css/case-transform.html that
mentions the reason of failure being a Qt bug.
- 4:39 AM Changeset in webkit [34131] by
-
- 2 edits in trunk/LayoutTests
2008-05-26 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Update QtWebkit layout-tests in accordance with bug 18976
The test fast/xsl/xslt-text.xml is on our skipped list due to
missing XSLT support in Qt.
May 25, 2008:
- 7:57 PM ApplicationsGtk edited by
- Update an entry (diff)
- 7:29 PM Changeset in webkit [34130] by
-
- 4 edits in trunk/WebKit/mac
<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
Reviewed by Darin Adler.
- WebView/WebFrame.mm:
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- 4:55 PM Changeset in webkit [34129] by
-
- 5 edits in trunk/WebCore
<rdar://problem/3582905> elements on separate pages need to be distinct
- 4:23 PM Changeset in webkit [34128] by
-
- 4 edits in trunk/WebCore
2008-05-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- don't repaint nodes that are removed before layout 4.3% speedup on Acid3 test 26
Mitz points out the new flag can also be used to optimize other
cases of needless repaint such as
<https://bugs.webkit.org/show_bug.cgi?id=15129>.
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): If the child has never had a layout, don't bother to repaint it, since there's nothing to dirty.
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): Initialize m_everHadLayout to false. (WebCore::RenderObject::setNeedsLayout): Set m_everHadLayout to true if we are being marked as not needing layout.
- rendering/RenderObject.h:
- 1:13 PM Changeset in webkit [34127] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19086 <rdar://problem/5962254> REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block
Test: fast/repaint/caret-outside-block.html
- editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Restored this function which was removed in r28523, but changed it to inflate only the width. (WebCore::SelectionController::caretRepaintRect): Changed back to use repaintRectForCaret(). (WebCore::SelectionController::recomputeCaretRect): Ditto.
LayoutTests:
Reviewed by Darin Adler.
- pixel test for https://bugs.webkit.org/show_bug.cgi?id=19086 <rdar://problem/5962254> REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block
- fast/repaint/caret-outside-block.html: Added.
- platform/mac/fast/repaint/caret-outside-block-expected.checksum: Added.
- platform/mac/fast/repaint/caret-outside-block-expected.png: Added.
- platform/mac/fast/repaint/caret-outside-block-expected.txt: Added.
- 7:36 AM Changeset in webkit [34126] by
-
- 2 edits in trunk/WebCore
2008-05-25 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18940
[CURL] Allow \n as line terminator for headers
The line terminator for message-header fields should be CRLF. However,
it is recommended to recognise as a line terminator also a single LF.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Allow headers to be terminated by "\n" and not just by "\r\n".
- 7:14 AM Changeset in webkit [34125] by
-
- 2 edits in trunk/WebKit/gtk
2008-05-25 Alp Toker <alp@nuanti.com>
Reviewed by Niko.
Drop WebView focus when the widget is focused out.
- webkit/webkitwebview.cpp:
- 4:30 AM Changeset in webkit [34124] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Alexey.
Fix the test.
- 4:15 AM Changeset in webkit [34123] by
-
- 4 edits in trunk
2008-05-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=19142
[Gtk] Remove build options --svg-experimental and --cross-document-messaging
- configure.ac
- WebCore/GNUmakefile.am:
- 3:41 AM Changeset in webkit [34122] by
-
- 12 edits in trunk/LayoutTests
RS=Oliver
Fix SVG test results for tiger buildbot.
- 2:55 AM Changeset in webkit [34121] by
-
- 2 edits in trunk/WebKit/gtk
2008-05-25 Sriram Neelakandan <sriram.neelakandan@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18935
[Gtk] Plugin Load crashes with NP_FULL mode
Fix crash due to uninitialized variable.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient):
- 12:46 AM Changeset in webkit [34120] by
-
- 12 edits in trunk/LayoutTests
Fix leopard results following changes to SVG path dumping.
RS=Alexey
- 12:35 AM Changeset in webkit [34119] by
-
- 2 edits in trunk/JavaScriptCore
Fixing a typo in the previous commit made as a last minute change.
- kjs/regexp_object.cpp:
- 12:15 AM Changeset in webkit [34118] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Darin.
Changed regular expression matching result array to be lazily filled, because many callers
only care about it being non-null.
2% improvement on Acid3 test 26.
- kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses to use.
- kjs/array_instance.h: (KJS::ArrayInstance::lazyCreationData): (KJS::ArrayInstance::setLazyCreationData): Added methods to access it from subclasses.
- kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpObjectImp::arrayOfMatches): RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until accessed for the first time.
- 12:11 AM Changeset in webkit [34117] by
-
- 595 edits in trunk
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=18927
Unify path data debug output
Implement unified path data output for Mac svg tests.
