Timeline
May 27, 2008:
- 9:31 PM Changeset in webkit [34168] by
-
- 3 edits in tags/Safari-6526.8.1/JavaScriptCore
Merge r34165.
- 9:28 PM Changeset in webkit [34167] by
-
- 1 copy in tags/Safari-6526.8.1
New tag.
- 9:20 PM Changeset in webkit [34166] by
-
- 6 edits in trunk
WebCore:
2008-05-27 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver.
<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)
It wasn't enough to break out of the header, to match other browsers we
also need to not preserve the typing style.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertParagraphSeparatorCommand.h:
LayoutTests:
2008-05-27 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver.
<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)
- editing/inserting/5803706-1-expected.txt: Adjust this already checked-in test to reflect the new expected behavior.
- editing/inserting/5803706-1.html:
- 8:54 PM Changeset in webkit [34165] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Remove code that appended Cygwin's /bin directory to PATH.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Prepend Cygwin's /bin directory to PATH. We prepend instead of append so that Cygwin's utilities will win out over Win32 versions of the same utilities (particularly perl). We do the prepend here instead of in the Makefile because nmake doesn't seem to like prepending to PATH inside the Makefile. This also matches the way WebCoreGenerated works.
- 8:54 PM Changeset in webkit [34164] by
-
- 3 edits in trunk/JavaScriptCore
Roll out r34163
A better fix is on the way.
- DerivedSources.make:
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- 8:31 PM Changeset in webkit [34163] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- DerivedSources.make: Don't generate the bytecode docs if OMIT_BYTECODE_DOCS is set to 1.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Set OMIT_BYTECODE_DOCS for production builds.
- 7:45 PM Changeset in webkit [34162] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5966961> REGRESSION: Font previews in the Web
Inspector always show in Lucida Grande (not the real font)
Reviewed by Adam Roben.
- page/inspector/FontView.js: Add a style element that loads the
@font-face rule that is excepted by the preview element.
- 7:45 PM Changeset in webkit [34161] by
-
- 3 edits in trunk/WebCore
Fixes a regression where the Image and Font preview views do not
size correctly.
<rdar://problem/5966723> REGRESSION (r33991): Image and font previews
are shrunken and can't be made larger (19281)
Reviewed by Adam Roben.
- page/inspector/FontView.js: Adjust the font size based only on the
container width minus padding.
- page/inspector/inspector.css: Updated styles for the image and
font views.
- 5:44 PM Changeset in webkit [34160] by
-
- 3 edits3 adds in trunk
2008-05-27 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff and Maciej.
<rdar://problem/5806428>
https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto
Set slotIsWriteable to false for proto, we want setting proto to go through JSObject::put instead.
- kjs/object.h: (KJS::JSObject::getOwnPropertySlotForWrite):
LayoutTests:
2008-05-27 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff and Maciej.
<rdar://problem/5806428>
https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto
- fast/js/resources/this-non-object-proto.js: Added.
- fast/js/this-non-object-proto-expected.txt: Added.
- fast/js/this-non-object-proto.html: Added.
- 4:38 PM Changeset in webkit [34159] by
-
- 1 edit in trunk/WebCore/html/HTMLTokenizer.h
Fix typo in comment.
- 4:33 PM Changeset in webkit [34158] by
-
- 3 edits in trunk/WebCore
Fix Bug 19276: XHR resources are classified as "Other" until Inspector is closed and reopened
<https://bugs.webkit.org/show_bug.cgi?id=19276>
<rdar://problem/5965742>
Reviewed by Tim Hatcher.
- page/InspectorController.cpp: (WebCore::InspectorController::updateScriptResourceResponse): Moved code that updates the resource's type from here... (WebCore::InspectorController::updateScriptResourceType): ...to here. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Call updateScriptResourceType now that we know this resource was retrieved via an XHR.
- page/InspectorController.h:
- 4:25 PM Changeset in webkit [34157] by
-
- 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp
Roll out r34156, which was accidentally checked in
- 4:22 PM Changeset in webkit [34156] by
-
- 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp
add printInstruction
- 2:50 PM Changeset in webkit [34155] by
-
- 2 edits in trunk/WebCore
Removes a redundant call to InspectorController::stopDebugging().
Rubber-stamped by Adam Roben.
- page/InspectorController.cpp:
(WebCore::InspectorController::showWindow):
- 1:44 PM Changeset in webkit [34154] by
-
- 2 edits in trunk/WebKit/mac
Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.
<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts
Reviewed by Kevin Decker.
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
- 11:46 AM Changeset in webkit [34153] by
-
- 4 edits2 adds in trunk/WebCore
2008-05-27 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Added and updated some manual test for the profiler.
- manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html:
- manual-tests/inspector/profiler-test-apply.html:
- manual-tests/inspector/profiler-test-call.html:
- manual-tests/inspector/profiler-test-deep-recursion.html: Added.
- manual-tests/inspector/profiler-test-simple-event-call.html: Added.
- 10:49 AM Changeset in webkit [34152] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
- 9:29 AM Changeset in webkit [34151] by
-
- 4 edits in trunk
wx build fix. Accidently left a couple fixes out of the previous commit.
- 9:12 AM Changeset in webkit [34150] by
-
- 6 edits in trunk
wx build fixes after introduction of SquirrelFish and other updates.
- 7:43 AM Changeset in webkit [34149] by
-
- 3 edits in trunk/JavaScriptCore
2008-05-27 Darin Adler <Darin Adler>
Reviewed by Tim Hatcher.
- https://bugs.webkit.org/show_bug.cgi?id=19180 speed up SunSpider by optimizing immediate number cases
Add immediate number cases for the &, |, and operators.
Makes standalone SunSpider 1.010x faster.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Add areBothImmediateNumbers special cases for the &, |, and operators.
- kjs/JSImmediate.h: (KJS::JSImmediate::xorImmediateNumbers): Added. (KJS::JSImmediate::orImmediateNumbers): Added.
- 3:31 AM Changeset in webkit [34148] by
-
- 2 edits in trunk/WebCore
2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix linking error (missing gdi32 and user32 libraries).
- WebCore.pro:
- 2:49 AM Changeset in webkit [34147] by
-
- 2 edits in trunk/WebKit/qt
2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix web inspector does not returns its state properly after its window is minimized.
As hinted by Holger, InspectorClientView::hideEvent is not needed.
This fixes bug https://bugs.webkit.org/show_bug.cgi?id=18967
- 2:02 AM Changeset in webkit [34146] by
-
- 2 edits in trunk/WebCore
2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Update the WebKit.qrc so that Web Inspector is functional again.
- page/inspector/WebKit.qrc:
May 26, 2008:
- 10:04 PM Changeset in webkit [34145] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-26 Stephanie Lewis <Stephanie Lewis>
Windows build fix.
- kjs/testkjs.cpp:
- 7:48 PM Changeset in webkit [34144] by
-
- 3 edits in trunk/WebCore
2008-05-26 Alp Toker <alp@nuanti.com>
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=16495
[GTK] Accessibility support with ATK/AT-SPI
Implement basic action, text and editable text accessibility.
Provide utility functions to simplify const string return and casting
and add some more stubs.
It's now possible to navigate and manipulate forms and text using
assistive technologies.
- page/gtk/AccessibilityObjectWrapperAtk.cpp: (returnString): (core):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::imageTitle):
- 7:10 PM Changeset in webkit [34143] by
-
- 14 edits in trunk
2008-05-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- make addStaticGlobals protected instead of private so subclasses can use it
- JavaScriptCore.exp:
- kjs/JSGlobalObject.h:
WebCore:
2008-05-25 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- bind the window's "document" and "window" properties to static slots 1.7% speedup on Acid3 test 26
Only the "document" part matters for Acid3, but since I was doing
this anyway, "window" also seemed like a good one to optimize.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable slots for document and window; but just put null in the document slot for now. (WebCore::JSDOMWindowBase::updateDocument): Fill in the document slot. (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop tracking us.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet for our still-not-dead inner windows. (WebCore::JSDOMWindowShell::updateDocument): Update all our inner windows ever (to make sure the update to the document property shows up everywhere).
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow): Update our hash. (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Don't set self as a property map property of the window, this is no longer necessary.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript): Update document for the newly created window.
- bindings/js/kjs_proxy.h:
- page/Frame.cpp: (WebCore::Frame::setDocument): If the document is not null, update our window.
LayoutTests:
2008-05-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders.
- update test result for document/window being allocated to var slots
- http/tests/security/cross-frame-access-put-expected.txt:
- 4:49 PM Changeset in webkit [34142] by
-
- 13 edits in trunk/LayoutTests
2008-05-26 James Ren <jamesjren@gmail.com>
Reviewed by Sam Weinig, landed by Collin Jackson.
Modified some http/security layout tests to allow them to run in Firefox.
- http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
- http/tests/security/resources/localhost-accesssor.html: Added a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=434912
- http/tests/security/resources/cross-frame-access.js: Changed shouldBe to also gracefully handle exceptions
- http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added feature detection for setBaseAndExtent and selectAllChildren
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- http/tests/security/cross-frame-access-enumeration.html: Fixed typo (missing '.html')
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- http/tests/security/cross-frame-access-first-time.html:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/cross-frame-access-selection.html: Caught exceptions that Firefox throws, to allow the test to run to completion.
- 2:13 PM Changeset in webkit [34141] by
-
- 7 edits1 add in trunk/WebCore
2008-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
This patch does two things:
- It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know that the node doesn't have a wrapper. This avoids a hash lookup.
- It adds toJSNewlyCreated methods for JSElement and JSText.
All in all this is a 4.3% speedup on Acid 3 test 26.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
- bindings/js/JSTextCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- 1:53 PM Changeset in webkit [34140] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed date of ChangeLog entry.
- 1:41 PM Changeset in webkit [34139] by
-
- 7 edits in trunk/WebCore
2008-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
and JSDocument for a 1-2% speedup on Acide 3 test 26.
- bindings/js/JSEventTargetNode.cpp:
- bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 1:07 PM Changeset in webkit [34138] by
-
- 16 edits in trunk/WebCore
2008-05-25 Darin Adler <Darin Adler>
Reviewed by Maciej.
Removed code that would only useful if if there was any way to create an Entity
node or if we populated EntityReference nodes. It's likely that we'll remove
these node types entirely in some future version of WebKit, depending in part
on what happens with these in HTML 5.
1.8% speedup of Acid3 test 26.
The only read-only nodes we ever create are EntityReference nodes.
These are only created by explicit calls to the Document.createEntityReference
function. Since the created nodes are read-only, there can be no children of
these nodes, so no other types of nodes can be read-only despite the rule that
makes descendants of Entity and EntityReference nodes read-only.
- bindings/objc/DOM.mm: Removed unneeded include.
- dom/Attr.cpp: (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check. (WebCore::Attr::setNodeValue): Ditto.
- dom/CharacterData.cpp: (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::substringData): Don't initialize the ec variable before calling checkCharDataOperation, since that function already does it. (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::insertData): Don't initialize ec. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setNodeValue): Removed now-misleading comment. (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary isReadOnlyNode check.
- dom/CharacterData.h: Made checkCharDataOperation private and non-virtual since it's never used or defined in any other class.
- dom/Element.cpp: (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.
- dom/Entity.cpp: Removed the entire contents of this file.
- dom/Entity.h: Replaced the class with a stub -- just enough to keep the public bindings (JavaScript and Objective-C compiling), but the class is abstract and can't be instantianted.
- dom/EntityReference.cpp: Removed unused constructor. (WebCore::EntityReference::cloneNode): Removed unneeded code and comments to clone nonexistent child nodes.
- dom/EntityReference.h: Removed unused constructor and unnecessary override of childTypeAllowed, since no children are allowed at all.
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check. (WebCore::NamedAttrMap::removeNamedItem): Ditto.
- dom/NamedAttrMap.h: Removed isReadOnlyNode function.
- dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of virtual nodeType function calls.
- dom/Node.h: (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode function with a new simple non-virtual one.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode check.
- dom/Text.cpp: (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check. (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion. There is no reason for this function to go out of its way to mention the read-only node issue when none of the other DOM mutation functions do.
- 12:38 PM Changeset in webkit [34137] by
-
- 2 edits in trunk/WebCore
2008-05-26 Adam Barth <abarth@webkit.org>
Reviewed by Sam.
Cleanup SecurityOrigin::canAccess. Removed comment referring to an
old version of the code. Removed some useless code.
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
- 11:57 AM Changeset in webkit [34136] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors'
- 11:50 AM Changeset in webkit [34135] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
error, all profile stack frames are incorrect
SunSpider reports a .3% speedup, possibly because eval of a string is a
little more efficient now.
- VM/Machine.cpp: (KJS::callEval): Make sure to call didExecute when returning early. I simplified this function to remove one early return, making the job of adding special code to early returns easier.
(KJS::Machine::execute): Use the new function ExecState when notifying
the profiler. (This doesn't change behavior now, but it might lead to
subtle errors in the future.)
- 11:43 AM Changeset in webkit [34134] by
-
- 3 edits in trunk/LayoutTests
2008-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Add a name to the source frame.
- fast/frames/viewsource-empty-attribute-value-expected.txt:
- fast/frames/viewsource-empty-attribute-value.html:
- 5:45 AM Changeset in webkit [34133] by
-
- 2 edits in trunk/WebCore
2008-05-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
Reviewed by Alp Toker.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.
- 5:29 AM Changeset in webkit [34132] by
-
- 4 edits in trunk
2008-05-23 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fixed toLower and toUpper implementations to allow being called
with a null result pointer and resultLength, to determine the
number of characters needed for the case conversion.
LayoutTests:
008-05-23 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Added a comment to the skipping of fast/css/case-transform.html that
mentions the reason of failure being a Qt bug.
- 4:39 AM Changeset in webkit [34131] by
-
- 2 edits in trunk/LayoutTests
2008-05-26 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Update QtWebkit layout-tests in accordance with bug 18976
The test fast/xsl/xslt-text.xml is on our skipped list due to
missing XSLT support in Qt.
