Context Navigation

← Previous Period
Next Period →

Timeline

May 28, 2008:

9:15 PM Changeset in webkit [34192] by oliver@apple.com

5 edits in trunk

Fix codegen for assignment being used as a function.

Reviewed by Anders.

FunctionCallValueNode::emitCode failed to account for the
potential of the function expression to allocate arbitrary
registers.

7:11 PM Changeset in webkit [34191] by Beth Dakin

6 edits in trunk/JavaScriptGlue

2008-05-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed total destruction in Software Update.app.

Updated JavaScriptGlue to honor squirrelfish's new getCallData mechanism for
indicating that an object can be called as a function.

5:51 PM Changeset in webkit [34190] by adachan@apple.com

2 edits in trunk/WebCore

<rdar://problem/5957036> REGRESSION (r31960): 20-30% slowdown in i-Bench JavaScript test on XP Home
Conditionalize the timer latency change (r31960) only for vista since it does not
help xp anyway.

Reviewed by Steve Falkenburg.

platform/win/SharedTimerWin.cpp: (WebCore::isRunningOnVistaOrLater): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):

5:44 PM Changeset in webkit [34189] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

Remove workaround, this is no longer a problem.

WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]):

4:20 PM Changeset in webkit [34188] by andersca@apple.com

2 edits in trunk/WebCore

2008-05-28 Anders Carlsson <andersca@apple.com>

Build fix.

storage/LocalStorage.cpp: (WebCore::LocalStorage::scheduleImport):

3:50 PM Changeset in webkit [34187] by andersca@apple.com

4 edits in trunk/WebCore

2008-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Tim.

<rdar://problem/5965960>
CrashTracer: [USER] 4 crashes in Safari at libxml2.2.dylib: xmlGenericErrorDefaultFunc + 76

Turns out that while libxml has two different error callbacks, they both use the same context, so we need to
set both error callbacks to prevent one of the error callbacks from using the context as a FILE pointer.

xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::genericErrorFunc): (WebCore::docLoaderFunc):
xml/XSLTProcessor.h:

3:45 PM Changeset in webkit [34186] by beidson@apple.com

4 edits in trunk/WebCore

2008-05-28 Brady Eidson <beidson@apple.com>

Reviewed by Adam

Fix hang I introduced to WebKit clients without their LocalStorage paths set
Such as DRT...

storage/LocalStorage.cpp: (WebCore::LocalStorage::scheduleImport): Return a bool, namely to signify whether or not there is a LocalStorageThread to schedule the import on.
storage/LocalStorage.h:

storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): If the scheduleImport failed, mark the imported flag as true so the LocalStorageArea doesn't wait around locking the main thread.

3:25 PM Changeset in webkit [34185] by pewtermoose@webkit.org

3 edits in trunk/WebCore

2008-05-28 Anthony Ricaud <rik24d@gmail.com>

User stylesheets are now non-editable and displayed as user-stylesheets

<https://bugs.webkit.org/show_bug.cgi?id=17602>
<rdar://problem/5967637>

Reviewed by Tim Hatcher.

English.lproj/localizedStrings.js: Added a string
page/inspector/StylesSidebarPane.js:

2:48 PM Drosera edited by pewtermoose@webkit.org

Add note about Drosera going to the giant debugger in the sky (diff)

2:00 PM Changeset in webkit [34184] by andersca@apple.com

2 edits in trunk/WebCore

2008-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/5819989>
Crash in WebKit!KJS::Window::printErrorMessage quitting Safari after pop up window on uk.real.com was closed

Add null check for Frame::settings().

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):

1:57 PM Changeset in webkit [34183] by kevino@webkit.org

5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

This patch adds a new wx event type and code to send it when a new title is set by the page being loaded.

https://bugs.webkit.org/show_bug.cgi?id=19067

1:47 PM Changeset in webkit [34182] by ggaren@apple.com

13 edits in trunk

JavaScriptCore:

2008-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Tim Hatcher.

Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html

Added two new debugger hooks, willExecuteProgram and didExecuteProgram,
along with code to generate them, code to invoke them when unwinding
due to an exception, and code to dump them.

SunSpider reports no change.

VM/CodeBlock.cpp: (KJS::debugHookName): I had to mark this function NEVER_INLINE to avoid a .4% performance regression. The mind boggles.

WebCore:

2008-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Tim Hatcher.

Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html

Added implementations for willExecuteProgram and didExecuteProgram. They
take care to update our call frame when entering and exiting programs,
preventing us from keeping around a stale global frame after executing
a program.

eval programs now show up as "anonymous function" in a new scope. This
is slightly better than what they used to do -- overwriting the current
scope -- but obviously we can do better.

WebKit/mac:

2008-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Tim Hatcher.

Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html

Added implementations for willExecuteProgram and didExecuteProgram, which
take care of making sure we're not hanging on to stale data.

1:28 PM Changeset in webkit [34181] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

This patch tweaks the wxWebView class to make it conform to normal wx patterns for widget classes. It adds a default ctor and the Create method so it can use the 2-phase create pattern, adds wxRTTI macros which is important for wxPython and XRC, and fixes the LoadURL method to pass a wxString reference to save a copy.

https://bugs.webkit.org/show_bug.cgi?id=19068

1:13 PM Changeset in webkit [34180] by Adam Roben

2 edits in trunk/JavaScriptCore

Fix JavaScriptCore tests on OS X

We were quoting the path to testkjs too late, after it had already
been combined with spaces and other options.

tests/mozilla/jsDriver.pl: (top level): Move path quoting from here... (sub get_kjs_engine_command): ...to here.

11:55 AM Changeset in webkit [34179] by beidson@apple.com

4 edits in trunk/WebCore

2008-05-28 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/5946834> - LocalStorage threads appearing in apps that don't want them.

Decided to fix this bug from a few different avenues to make sure we only create LocalStorage resources
when we *really* want them.

page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Account for the possibility that the LocalStorage object might be null.

storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Don't create the thread if there is no path name - we know we'll never be needing it when there is no file backing us on disk. (WebCore::LocalStorage::scheduleImport): Null check the thread, as it might not exist. (WebCore::LocalStorage::scheduleSync): Ditto

storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::localStorageThread): Clear the threadID after termination - clear way to signify that this thread is truly done. (WebCore::LocalStorageThread::scheduleImport): ASSERT that the queue is live, and the threadID exists (WebCore::LocalStorageThread::scheduleSync): Ditto (WebCore::LocalStorageThread::terminate): Don't schedule termination and wait for it to complete if the thread isn't live.

11:36 AM Changeset in webkit [34178] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Rescale image to fit the destination rect so that we don't get a crash when drawing in a destination rect that's bigger than the image rect. Also adds an optimization for drawing an image that is a solid color.

https://bugs.webkit.org/show_bug.cgi?id=18465

11:13 AM Changeset in webkit [34177] by andersca@apple.com

3 edits
3 adds in trunk

JavaScriptCore:

2008-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5968071> "const f" crashes in JavaScriptCore

Make sure to null check the initializer.

kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):

LayoutTests:

2008-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5968071> "const f" crashes in JavaScriptCore

fast/js/const-without-initializer-expected.txt: Added.
fast/js/const-without-initializer.html: Added.
fast/js/resources/const-without-initializer.js: Added.

11:04 AM Changeset in webkit [34176] by alp@webkit.org

3 edits in trunk/WebKit/gtk

2008-05-28 Alp Toker <alp@nuanti.com>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=18704
[gtk] cannot type letters with dead keys in textarea

http://bugs.webkit.org/show_bug.cgi?id=14120
[GDK] Support input methods

Add support for input method composition.

Remove some old hacks so we handle input method events more
consistently.

WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing): (WebKit::EditorClient::textDidChangeInTextField): (WebKit::EditorClient::doTextFieldCommandFromEvent):
webkit/webkitwebview.cpp:

10:31 AM Changeset in webkit [34175] by Adam Roben

2 edits in trunk/BugsSite

Make PrettyPatch able to handle diffs taken from outside the WebKit source tree

Part of Bug 19290: More patches not handled by PrettyPatch.rb
<https://bugs.webkit.org/show_bug.cgi?id=19290>

Reviewed by David Kilzer.

PrettyPatch/PrettyPatch.rb: (PrettyPatch.find_url_and_path): Added. Searches the file path from the bottom up looking for a directory that exists in the source tree. (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.

10:31 AM Changeset in webkit [34174] by Adam Roben

2 edits in trunk/JavaScriptCore

Make run-javascriptcore-tests work with a space in the path to testkjs

Reviewed by Alexey Proskuryakov.

tests/mozilla/jsDriver.pl: Quote the path to the engine so that spaces will be interpreted correctly.

8:46 AM Changeset in webkit [34173] by Adam Roben

3 edits in trunk/BugsSite

Print exceptions from PrettyPatch to stdout

This will make it much easier to debug problems with PrettyPatch,
since we'll be able to see the exceptions in the browser.

Reviewed by Sam Weinig.

PrettyPatch/prettify.rb: Added a --html-exceptions option, which will print exceptions to stdout as HTML.
attachment.cgi: Changed to pass --html-exceptions to prettify.rb.

5:36 AM Changeset in webkit [34172] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Fixed a misguiding comment - my measurement for negative numbers only included cases
where both operands were negative, which is not very interesting.

VM/Machine.cpp:

3:48 AM Changeset in webkit [34171] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Based on a patch by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

1.4% speedup on SunSpider.

VM/Machine.cpp: (KJS::Machine::privateExecute):
kjs/JSImmediate.h: (KJS::JSImmediate::incImmediateNumber): (KJS::JSImmediate::decImmediateNumber): Added fast paths for ++ and --.

(KJS::JSImmediate::canDoFastAdditiveOperations): Corrected a comment.

2:47 AM Changeset in webkit [34170] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

2% speedup overall, maximum 10% on controlflow-recursive and bitops-3bit-bits-in-byte,
but a 4% regression on bitops-bits-in-byte and bitops-bitwise-and.

kjs/JSImmediate.h: (KJS::JSImmediate::canDoFastAdditiveOperations): (KJS::JSImmediate::addImmediateNumbers): (KJS::JSImmediate::subImmediateNumbers): Added fast cases that work with positive values less than 2^30.

VM/Machine.cpp: (KJS::Machine::privateExecute): Use the above operations. Also updated SunSpider frequencies with my results (looks like tag values have changed, not sure what caused the minor variation in actual frequencies).

12:44 AM Changeset in webkit [34169] by Simon Hausmann

2 edits in trunk/WebCore

2008-05-27 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon

Close the video widget explicitly so we don't hang
when exiting the application.

May 27, 2008:

9:31 PM Changeset in webkit [34168] by mrowe@apple.com

3 edits in tags/Safari-6526.8.1/JavaScriptCore

Merge r34165.

9:28 PM Changeset in webkit [34167] by mrowe@apple.com

1 copy in tags/Safari-6526.8.1

New tag.

9:20 PM Changeset in webkit [34166] by justin.garcia@apple.com

6 edits in trunk

WebCore:

2008-05-27 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

It wasn't enough to break out of the header, to match other browsers we
also need to not preserve the typing style.

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-05-27 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

editing/inserting/5803706-1-expected.txt: Adjust this already checked-in test to reflect the new expected behavior.
editing/inserting/5803706-1.html:

8:54 PM Changeset in webkit [34165] by Adam Roben

3 edits in trunk/JavaScriptCore

Windows build fix

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Remove code that appended Cygwin's /bin directory to PATH.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Prepend Cygwin's /bin directory to PATH. We prepend instead of append so that Cygwin's utilities will win out over Win32 versions of the same utilities (particularly perl). We do the prepend here instead of in the Makefile because nmake doesn't seem to like prepending to PATH inside the Makefile. This also matches the way WebCoreGenerated works.

8:54 PM Changeset in webkit [34164] by Adam Roben

3 edits in trunk/JavaScriptCore

Roll out r34163

A better fix is on the way.

DerivedSources.make:
JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

8:31 PM Changeset in webkit [34163] by Adam Roben

3 edits in trunk/JavaScriptCore

Windows build fix

DerivedSources.make: Don't generate the bytecode docs if OMIT_BYTECODE_DOCS is set to 1.
JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Set OMIT_BYTECODE_DOCS for production builds.

7:45 PM Changeset in webkit [34162] by timothy@apple.com

2 edits in trunk/WebCore

<rdar://problem/5966961> REGRESSION: Font previews in the Web
Inspector always show in Lucida Grande (not the real font)

Reviewed by Adam Roben.

page/inspector/FontView.js: Add a style element that loads the

@font-face rule that is excepted by the preview element.

7:45 PM Changeset in webkit [34161] by timothy@apple.com

3 edits in trunk/WebCore

Fixes a regression where the Image and Font preview views do not
size correctly.

<rdar://problem/5966723> REGRESSION (r33991): Image and font previews
are shrunken and can't be made larger (19281)

Reviewed by Adam Roben.

page/inspector/FontView.js: Adjust the font size based only on the

container width minus padding.

page/inspector/inspector.css: Updated styles for the image and

font views.

5:44 PM Changeset in webkit [34160] by andersca@apple.com

3 edits
3 adds in trunk

JavaScriptCore:

2008-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

Set slotIsWriteable to false for proto, we want setting proto to go through JSObject::put instead.

kjs/object.h: (KJS::JSObject::getOwnPropertySlotForWrite):

LayoutTests:

2008-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

fast/js/resources/this-non-object-proto.js: Added.
fast/js/this-non-object-proto-expected.txt: Added.
fast/js/this-non-object-proto.html: Added.

4:38 PM Changeset in webkit [34159] by ddkilzer@apple.com

1 edit in trunk/WebCore/html/HTMLTokenizer.h

Fix typo in comment.

4:33 PM Changeset in webkit [34158] by Adam Roben

3 edits in trunk/WebCore

Fix Bug 19276: XHR resources are classified as "Other" until Inspector is closed and reopened

<https://bugs.webkit.org/show_bug.cgi?id=19276>
<rdar://problem/5965742>

Reviewed by Tim Hatcher.

page/InspectorController.cpp: (WebCore::InspectorController::updateScriptResourceResponse): Moved code that updates the resource's type from here... (WebCore::InspectorController::updateScriptResourceType): ...to here. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Call updateScriptResourceType now that we know this resource was retrieved via an XHR.
page/InspectorController.h:

4:25 PM Changeset in webkit [34157] by Adam Roben

1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

Roll out r34156, which was accidentally checked in

4:22 PM Changeset in webkit [34156] by Adam Roben

1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

add printInstruction

2:50 PM Changeset in webkit [34155] by timothy@apple.com

2 edits in trunk/WebCore

Removes a redundant call to InspectorController::stopDebugging().

Rubber-stamped by Adam Roben.

page/InspectorController.cpp:

(WebCore::InspectorController::showWindow):

1:44 PM Changeset in webkit [34154] by timothy@apple.com

2 edits in trunk/WebKit/mac

Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.

<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts

Reviewed by Kevin Decker.

Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.

11:46 AM Changeset in webkit [34153] by kmccullough@apple.com