Context Navigation

rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Ensured that floats occurring in trailing whitespace after a line break are added to the last line's floats vector.

LayoutTests:

Reviewed by Darin Adler.

test for https://bugs.webkit.org/show_bug.cgi?id=19278 <rdar://problem/5968621> REGRESSION (r31114-r31132): image float disappears on refresh

fast/dynamic/float-in-trailing-whitespace-after-last-line-break.html: Added.
platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.checksum: Added.
platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png: Added.
platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt: Added.

11:06 PM Changeset in webkit [34276] by timothy@apple.com

2 edits in trunk/WebCore

Implements the back and forward buttons in the Scripts panel.

Reviewed by Adam Roben.

page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel): Add the back and forward button elements and remove the FIXMEs. (WebInspector.ScriptsPanel.prototype.reset): Reset _backForwardList and _currentBackForwardIndex. Then call _updateBackAndForwardButtons(). (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Added a fromBackForwardAction argument. If fromBackForwardAction is false then update the _currentBackForwardIndex and _backForwardList. (WebInspector.ScriptsPanel.prototype._updateBackAndForwardButtons): Update the disabled state of the buttons. (WebInspector.ScriptsPanel.prototype._goBack): Update the _currentBackForwardIndex and call _showScriptOrResource() and _updateBackAndForwardButtons(). (WebInspector.ScriptsPanel.prototype._goForward): Ditto.

11:05 PM Changeset in webkit [34275] by timothy@apple.com

5 edits in trunk/WebCore

Made clicking a Console message URL originating from a JavaScript
source show the Resource in the Scripts panel. This only happens
when the debugger is attached.

Reviewed by Adam Roben.

page/inspector/Console.js: (WebInspector.Console.prototype._formaterror): Add a preferredPanel of "scripts". (WebInspector.ConsoleMessage.prototype.toMessageElement): Add a preferredPanel of "scripts" when the source is JS.
page/inspector/ScriptView.js: (WebInspector.ScriptView.prototype.highlightLine): Added. Calls through to the sourceFrame. Matches SourceView.
page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.canShowResource): Added. Returns true if the debugger is attached and the resource has scripts. (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Call highlightLine on the view.
page/inspector/inspector.js: (WebInspector.documentClick): Pass the preferredPanel to showResourceForURL. (WebInspector.showResourceForURL): Resolve the preferredPanel from the string passed in. Checks if the panel implements showResource and canShowResource. Reverts to the Resources panel if any of that is false or not implemented.

11:05 PM Changeset in webkit [34274] by timothy@apple.com

2 edits in trunk/WebCore

Fixed an "undefined type" exception that was being thrown when
selecting a eval script from the file menu in the Scripts panel.
This would also happen when stepping into an eval which would
break other parts of the Inspector interface.

Reviewed by Adam Roben.

page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Use the scriptOrResource variable instead of the undefined script variable.

11:05 PM Changeset in webkit [34273] by timothy@apple.com

27 edits in trunk

Made the starting line number of scripts be 1-based throughout the engine.

JavaScriptCore:

2008-05-30 Timothy Hatcher <timothy@apple.com>

Made the starting line number of scripts be 1-based throughout the engine.
This cleans up script line numbers so they are all consistent now and fixes
some cases where script execution was shown as off by one line in the debugger.

No change in SunSpider.

Reviewed by Oliver Hunt.

API/minidom.c: (main): Pass a line number of 1 instead of 0 to parser().parse().
API/testapi.c: (main): Ditto. And removes a FIXME and changed an assertEqualsAsNumber to use 1 instead of 2 for the line number.
VM/Machine.cpp: (KJS::callEval): Pass a line number of 1 instead of 0. (KJS::Machine::debug): Use firstLine for WillExecuteProgram instead of lastLine. Use lastLine for DidExecuteProgram instead of firstLine.
kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::evaluate): Pass a line number of 1 instead of 0 to parser().parse().
kjs/Parser.cpp: (KJS::Parser::parse): ASSERT startingLineNumber is greatter than 0. Change the startingLineNumber to be 1 if it was less than or equal to 0. This is needed for release builds to maintain compatibility with the JavaScriptCore API.
kjs/function.cpp: (KJS::globalFuncEval): Pass a line number of 1 instead of 0 to parser().parse().
kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a line number of 1 instead of 0 to construct().
kjs/lexer.cpp: (Lexer::setCode): Made yylineno = startingLineNumber instead of adding 1.
kjs/testkjs.cpp: (functionRun): Pass a line number of 1 instead of 0 to Interpreter::evaluate(). (functionLoad): Ditto. (prettyPrintScript): Ditto. (runWithScripts): Ditto.
profiler/Profiler.cpp: (WebCore::createCallIdentifier): Removed a plus 1 of startingLineNumber.

WebCore:

2008-05-30 Timothy Hatcher <timothy@apple.com>

Made the starting line number of scripts be 1-based throughout the engine.
This cleans up script line numbers so they are all consistent now and fixes
some cases where script execution was shown as off by one line in the debugger.

Doing this also exposed a bug where JSLazyEventListener created in XHML or SVG
documents would always have a line number of 0. So this change fixed that bug
to pass all the SVG and XHTML tests.

All layout tests pass.

Reviewed by Oliver Hunt.

bindings/js/kjs_events.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): Set the line number to 1 if it was passed in as 0. This can happen when listeners are created with a setAttribute call from JavaScript. (WebCore::JSLazyEventListener::parseCode): Add a FIXME about the URL being incorrect when listeners are created with a setAttribute call from JavaScript.
bindings/js/kjs_events.h: Remove the default value for lineNumber, since no callers need it.
bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]): Pass a line number of 1 instead of 0 to Interpreter::evaluate().
bridge/NP_jsobject.cpp: (_NPN_Evaluate): Ditto.
bridge/jni/jni_jsobject.mm: (JavaJSObject::eval): Ditto.
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Call KJSProxy::setEventHandlerLineno() around the call to handleElementAttributes, so any JSLazyEventListener created from those attributes have line numbers. (WebCore::XMLTokenizer::endElementNs): Remove a minus 1 of the line number. (WebCore::XMLTokenizer::notifyFinished): Pass a line number of 1 instead of 0. (WebCore::XMLTokenizer::parseEndElement): Remove a minus 1 of the line number.
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript): Add a FIXME about the starting line number being incorrect in some cases when this function is called.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Add a plus 1 to the line number when setting scriptStartLineno so it is 1-based. Same for calling setEventHandlerLineno(). (WebCore::HTMLTokenizer::processToken): Ditto.
html/HTMLTokenizer.h: Change the default line number on scriptExecution() to 1 from 0.
loader/FrameLoader.cpp: (FrameLoader::executeIfJavaScriptURL): Pass a line number of 1 instead of 0 to executeScript().

WebKitTools:

2008-05-30 Timothy Hatcher <timothy@apple.com>

Made the starting line number of scripts be 1-based throughout the engine.
This cleans up script line numbers so they are all consistent now.

Reviewed by Oliver Hunt.

DumpRenderTree/mac/ObjCController.m: (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: (runJavaScriptThread): Ditto.
DumpRenderTree/win/DumpRenderTree.cpp: (runJavaScriptThread): Ditto.

11:05 PM Changeset in webkit [34272] by timothy@apple.com

4 edits in trunk/WebCore

Fixes the regression where image resources don't have a preview icon.

https://bugs.webkit.org/show_bug.cgi?id=18500

Reviewed by Adam Roben.

page/inspector/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement): Call createIconElement before calling the superclass. (WebInspector.ResourceSidebarTreeElement.prototype.createIconElement): Create an iconElement, if the category is images then make a div that contains a preview image. Otherwise just make an img element. If there was a previous iconElement, then replace it. (WebInspector.ResourceSidebarTreeElement.prototype.refresh): Call createIconElement if the category changed.
page/inspector/SidebarTreeElement.js: (WebInspector.SidebarTreeElement): Create an iconElement if one hasn't been made already by a subclass. (WebInspector.SidebarTreeElement.prototype.onattach): Append the iconElement instead of creating one each time.
page/inspector/inspector.css: New and updated style rules.

10:37 PM Changeset in webkit [34271] by mjs@apple.com

10 edits in trunk/WebCore

2008-05-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver (earlier version reviewed by Alexey).

speculative fix for "REGRESSION(r34143?): Frequent crash while browsing" https://bugs.webkit.org/show_bug.cgi?id=19285

("This Time for Sure" Edition)

I'm pretty sure this fixes it but I have not been able to
reproduce and am unsure if my theory of the bug is right.

I belive the bug was because JSDOMWindowBase accessed
JSDOMWindowShell in its destructor to remove itself from a
hashtable, but GC destructor order is not guaranteed, so the
hashtable may have been freed already. This patch changes things
so that a non-GC object (the KJSProxy) does the tracking of live
window objects for a frame. JSDOMWindowBase can null check the frame
pointer to verify if it is still good.

In addition, we must create a similar setup between DOMWindow and
Frame; since the DOMWindow of a given frame can now change over
time, we must ensure that the Frame disconnects every live
DOMWindow when destroyed, not just the last.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell):
bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): (WebCore::KJSProxy::initScript): (WebCore::KJSProxy::updateDocument):
bindings/js/kjs_proxy.h: (WebCore::KJSProxy::clearFormerWindow):
page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow):
page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::setDocument): (WebCore::Frame::clearDOMWindow): (WebCore::Frame::clearFormerDOMWindow):
page/Frame.h:
page/FramePrivate.h:

9:31 PM Changeset in webkit [34270] by mrowe@apple.com

4 edits in branches/WWDC-2008-branch

Versioning.

9:31 PM Changeset in webkit [34269] by mrowe@apple.com

1 copy in tags/Safari-6526.10

New tag.

9:29 PM Changeset in webkit [34268] by mrowe@apple.com

3 edits
3 adds in branches/WWDC-2008-branch

Merge r34204.

2:34 PM Changeset in webkit [34267] by mitz@apple.com

7 edits in trunk

WebCore:

Reviewed by Darin Adler and Dave Hyatt.

eliminate excessive repainting when an object's final position after layout is unchanged

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed the full repaint for the case that the final position is unchanged but the position at which an intermediate layout occurred was different. Any repainting done during the intermediate layout would have happened at the object's initial (and also final) coordinates, since layoutDelta is factored into repaint rect calculations.

LayoutTests:

Reviewed by Darin Adler.

updated pixel results for "eliminate excessive repainting when an object's final position after layout is unchanged"

platform/mac/fast/repaint/intermediate-layout-position-clip-expected.checksum:
platform/mac/fast/repaint/intermediate-layout-position-clip-expected.png:
platform/mac/fast/repaint/intermediate-layout-position-expected.checksum:
platform/mac/fast/repaint/intermediate-layout-position-expected.png:

2:30 PM Changeset in webkit [34266] by justin.garcia@apple.com

2 edits in trunk/WebKit/mac

2008-05-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin.

<rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail

AppKit started putting PNG instead of PICT onto the pasteboard for screen
captures. Added support for PNG with kUTTypePNG. Tiger doesn't support
setting and retrieving pasteboard types with UTIs, but we don't know of any
applications on Tiger that put only PNG on the pasteboard.

WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

1:10 PM Changeset in webkit [34265] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

Also fixed a JavaScriptCore regression seen on PowerPC - we didn't clip left shift
parameter to 0...31.

0.5% improvement on SunSpider overall, although a 8.5 regression on bitops-3bit-bits-in-byte.

VM/Machine.cpp: (KJS::Machine::privateExecute): Added fast paths for >>> and <<.

kjs/JSImmediate.h: (KJS::JSImmediate::toTruncatedUInt32): Added. Same as getTruncatedInt32, but casts the result to unsigned.

11:05 AM Changeset in webkit [34264] by Chris Fleizach

2 edits in trunk/WebCore

<rdar://problem/5959478> r34079: AX: crash at stringForReplacedNode

7:15 AM Changeset in webkit [34263] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-05-30 Carlos Martín Nieto <carlos@cmartin.tk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18383
[GTK] The "hovering-over-link" signal arguments aren't documented.

webkit/webkitwebview.cpp:

4:28 AM Changeset in webkit [34262] by Simon Hausmann

2 edits in trunk/WebCore

2008-05-30 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Fix the build dependencies for the Qt build. Don't generate
SVGCSSPropertyNames.cpp for every build.

WebCore.pro: The output file was renamed, so the compiler rule needs to be adjusted in order for qmake to generate correct depdencies.

3:40 AM Changeset in webkit [34261] by mjs@apple.com

7 edits in trunk/WebCore

2008-05-30 Maciej Stachowiak <mjs@apple.com>

Revert fix for 19285, it just caused more crashes and I need time
to fix it properly.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::updateDocument):
bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::clearFormerWindow):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): (WebCore::KJSProxy::initScript):
bindings/js/kjs_proxy.h:
page/Frame.cpp: (WebCore::Frame::setDocument):

3:28 AM Changeset in webkit [34260] by Simon Hausmann

2 edits in trunk/WebCore

2008-05-30 Adam Treat <treat@kde.org>

Reviewed by Simon.

Fix a huge memory leak by ensuring that on application shutdown
the shared timer is fired one last time if it is active. This
ensures that the GCController timer is fired at the end to free
references to JavaScript objects.

3:08 AM Changeset in webkit [34259] by ap@webkit.org

11 edits
1 add
3 deletes in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=7466
<rdar://problem/4657563> Use of Ctrl as access key modifier conflicts with Mac OS X
emacs-style keybindings

WebCore:

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Use Ctrl+Option for access keys on Mac OS X.

LayoutTests:

fast/events/access-key-self-destruct.html:
fast/forms/access-key.html:
fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-input.html:
fast/forms/legend-access-key.html:
fast/forms/select-accesskey.html: Updated tests to keep passing.

fast/forms/select-accesskey-expected.txt: Added.
fast/forms/select-accesskey.html:
platform/mac/fast/forms/select-accesskey-expected.checksum: Removed.
platform/mac/fast/forms/select-accesskey-expected.png: Removed.
platform/mac/fast/forms/select-accesskey-expected.txt: Removed. Updated to keep passing, made text-only.

fast/forms/focus-selection-textarea.html:
fast/forms/focus-selection-textarea-expected.txt: Added missing platform-specific logic.

2:10 AM Changeset in webkit [34258] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

Also fixed three JavaScriptCore regressions seen on PowerPC - we didn't clip right shift
parameter to 0...31.

1.6% improvement on SunSpider, without significant regressions on any tests.

VM/Machine.cpp: (KJS::Machine::privateExecute): Added fast paths for >>, ==, ===, !=, !==. Changed order of memory accesses in many cases, making them less dependent on gcc's ability to properly assign registers. With this, I could move exception checks back into slow code paths, and saw less randomness in general.

kjs/JSImmediate.h: (KJS::JSImmediate::rightShiftImmediateNumbers): Added.

1:15 AM Changeset in webkit [34257] by mjs@apple.com

7 edits in trunk/WebCore

2008-05-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Alexey.

speculative fix for "REGRESSION(r34143?): Frequent crash while browsing" https://bugs.webkit.org/show_bug.cgi?id=19285

I'm pretty sure this fixes it but I have not been able to
reproduce and am unsure if my theory of the bug is right.

I belive the bug was because JSDOMWindowBase accessed
JSDOMWindowShell in its destructor to remove itself from a
hashtable, but GC destructor order is not guaranteed, so the
hashtable may have been freed already. This patch changes things
so that a non-GC object (the KJSProxy) does the tracking of live
window objects for a frame. JSDOMWindowBase can null check the frame
pointer to verify if it is still good.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell):
bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): (WebCore::KJSProxy::initScript): (WebCore::KJSProxy::updateDocument):
bindings/js/kjs_proxy.h: (WebCore::KJSProxy::clearFormerWindow):
page/Frame.cpp: (WebCore::Frame::setDocument):

12:12 AM Changeset in webkit [34256] by mrowe@apple.com

2 edits in tags/Safari-5525.18.1/WebKit/mac

Merge r34154.

12:10 AM Changeset in webkit [34255] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r34154.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed