⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 2, 2008:

11:26 PM Changeset in webkit [34334] by ggaren@apple.com
  • 29 edits in trunk

JavaScriptCore:

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

Removed JSObject::call, since it just called JSObject::callAsFunction.

SunSpider reports no change.

JavaScriptGlue:

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

Removed JSObject::call, since it just called JSObject::callAsFunction.

SunSpider reports no change.

WebCore:

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.


Removed JSObject::call, since it just called JSObject::callAsFunction.


SunSpider reports no change.

8:48 PM Changeset in webkit [34333] by mjs@apple.com
  • 2 edits in trunk/PlanetWebKit

2008-06-02 Maciej Stachowiak <​mjs@apple.com>

  • config.ini: Correct URL for just-added blog.
8:15 PM Changeset in webkit [34332] by mjs@apple.com
  • 2 edits in trunk/PlanetWebKit

2008-06-02 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark.

7:17 PM Changeset in webkit [34331] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-06-02 Alp Toker <​alp@nuanti.com>

Reviewed by Maciej.

Two of the toJSNewlyCreated() optimisations in r34141 were never
reached due to a generator bug and missing IDL attribute.

Fix header generation to provide the necessary toJSNewlyCreated()
overloads.

Patch includes a related build fix by Jan Michael Alonzo.

  • GNUmakefile.am:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Text.idl:
6:05 PM Changeset in webkit [34330] by ggaren@apple.com
  • 2 edits in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Transparent background!

  • blog-files/squirrelfish.png:
5:30 PM Changeset in webkit [34329] by alp@webkit.org
  • 3 edits in trunk

2008-06-02 Alp Toker <​alp@nuanti.com>

GTK+/autotools Windows build system fixes.

  • GNUmakefile.am:
  • configure.ac:
4:04 PM Changeset in webkit [34328] by alice.liu@apple.com
  • 5 edits in trunk/WebCore

2008-06-02 Alice Liu <​alice.liu@apple.com>

Reviewed by Beth Dakin.

Some ARIA roles are designated to have presentational children, which
means that their descendants aren't exposed to assistive technologies
on an individual basis. What this means in webcore is that descendants
of such roles need to be ignored in terms of accessibility.

  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren):
  • page/AccessibilityObject.h:
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::RoleEntry::): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
  • page/AccessibilityRenderObject.h:
3:28 PM Changeset in webkit [34327] by ggaren@apple.com
  • 2 edits in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Crop!

  • blog-files/squirrelfish-webkit-graph.png:
3:07 PM Changeset in webkit [34326] by ggaren@apple.com
  • 1 edit
    1 move in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Renamed this file quiet down the peanut gallery.

  • blog-files/squirrelfish-webkit-graph.png: Copied from blog-files/webkit-graph.png.
  • blog-files/webkit-graph.png: Removed.
3:02 PM Changeset in webkit [34325] by ggaren@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Added a graph.

  • blog-files/webkit-graph.png: Added.
2:54 PM Changeset in webkit [34324] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

2008-06-02 David Hyatt <​hyatt@apple.com>

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19303

When the right slice value is omitted in border-image it should use the value of the left slice and not
the top slice.

Reviewed by darin

Added fast/borders/border-image-omit-right-slice.html

  • css/CSSParser.cpp: (WebCore::BorderImageParseContext::commitBorderImage)
2:46 PM Changeset in webkit [34323] by andersca@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-02 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt and Mitz.

<rdar://problem/5704119>
repro crash in WebCore::RenderPart::setWidget (plugin-related?)


Test: platform/mac/plugins/update-widget-from-style-recalc.html

Make sure to update the document's rendering before calling updateWidget.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):

WebKitTools:

2008-06-02 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt and Mitz.

<rdar://problem/5704119>
repro crash in WebCore::RenderPart::setWidget (plugin-related?)


Call -[WebView display] in the "plug-in" failed delegate method, simulating
the sheet that Safari puts up.


  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):

LayoutTests:

2008-06-02 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt and Mitz.

<rdar://problem/5704119>
repro crash in WebCore::RenderPart::setWidget (plugin-related?)


  • platform/mac/plugins/update-widget-from-style-recalc-expected.txt: Added.
  • platform/mac/plugins/update-widget-from-style-recalc.html: Added.
2:45 PM Changeset in webkit [34322] by ggaren@apple.com
  • 1 edit
    1 move in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Moved the squirrelfish mascot to the right place.

  • blog-files/squirrelfish.png: Copied from images/squirrelfish.png.
  • images/squirrelfish.png: Removed.
2:41 PM Changeset in webkit [34321] by ggaren@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Uploaded the squirrelfish mascot.

  • images/squirrelfish.png: Added.
1:47 PM Changeset in webkit [34320] by jchaffraix@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

LayoutTests:

2008-06-02 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Bug 18655: [XHR] OnProgress needs more test case
​https://bugs.webkit.org/show_bug.cgi?id=18655

  • http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Added.
  • http/tests/xmlhttprequest/resources/noContentLength.asis: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Added.
1:45 PM Changeset in webkit [34319] by ggaren@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


A little cleanup in the CodeGenerator.

  • VM/CodeGenerator.cpp: A few changes here.

(1) Removed remaining cases of the old hack of putting "this" into the
symbol table; replaced with explicit tracking of m_thisRegister.

(2) Made m_thisRegister behave the same for function, eval, and program
code, removing the static programCodeThis() function.

(3) Added a feature to nix a ScopeNode's declaration stacks when done
compiling, to save memory.

(4) Removed code that copied eval declarations into special vectors: we
just use the originals in the ScopeNode now.


  • VM/CodeGenerator.h: Removed unneded parameters from the CodeGenerator constructor: we just use get that data from the ScopeNode now.
  • VM/Machine.cpp: (KJS::Machine::execute): When executing an eval node, don't iterate a special copy of its declarations; iterate the originals, instead.
  • kjs/nodes.cpp: Moved responsibility for knowing what AST data to throw away into the CodeGenerator. Nodes no longer call shrinkCapacity on their data directly.


  • kjs/nodes.h: Changed FunctionStack to ref its contents, so declaration data stays around even after we've thrown away the AST, unless we explicitly throw away the declaration data, too. This is useful for eval code, which needs to reference its declaration data at execution time. (Soon, it will be useful for program code, too, since program code should do the same.)
1:15 PM Changeset in webkit [34318] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-06-02 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5954226> JSProfiler: Move the calls from
JavaScriptProfileNode to JavaScriptProfile in WebCore (19231)

  • This Makes the profiler now call sorting function s on a per-profile basis instead of on a node in the profile.
  • This is also needed to remove the recursion limit in the profiler <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the profiler since once the limit is removed calling sort on a node will only sort that node's children not the entire sub-tree of that node.
  • page/JavaScriptProfile.cpp: All of these functions were moved from JavaScriptProfileNode. (WebCore::sortTotalTimeDescending): (WebCore::sortTotalTimeAscending): (WebCore::sortSelfTimeDescending): (WebCore::sortSelfTimeAscending): (WebCore::sortCallsDescending): (WebCore::sortCallsAscending): (WebCore::sortFunctionNameDescending): (WebCore::sortFunctionNameAscending): (WebCore::ProfileClass):
  • page/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
  • page/inspector/ProfileView.js: Change uses of JavaScriptProfileNode for sorting to JavaScriptProfile.
1:00 PM Changeset in webkit [34317] by mitz@apple.com
  • 3 edits
    1 move
    28 adds
    3 deletes in trunk

WebCore:

Reviewed by Oliver Hunt.

Tests: fast/canvas/shadow-offset-1.html

fast/canvas/shadow-offset-2.html
fast/canvas/shadow-offset-3.html
fast/canvas/shadow-offset-4.html
fast/canvas/shadow-offset-5.html
fast/canvas/shadow-offset-6.html
fast/canvas/shadow-offset-7.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::adjustedShadowSize): Added this helper function. (WebCore::CanvasRenderingContext2D::setShadow): Changed to call adjustedShadowSize(). (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/canvas/resources/shadow-offset.js: Added.
  • fast/canvas/shadow-offset-1.html: Copied from LayoutTests/fast/canvas/shadow-offset.html.
  • fast/canvas/shadow-offset-2.html: Added.
  • fast/canvas/shadow-offset-3.html: Added.
  • fast/canvas/shadow-offset-4.html: Added.
  • fast/canvas/shadow-offset-5.html: Added.
  • fast/canvas/shadow-offset-6.html: Added.
  • fast/canvas/shadow-offset-7.html: Added.
  • fast/canvas/shadow-offset.html: Removed.
  • platform/mac/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-7-expected.txt: Added.
  • platform/mac/fast/canvas/shadow-offset-expected.checksum: Removed.
  • platform/mac/fast/canvas/shadow-offset-expected.png: Removed.
  • platform/mac/fast/canvas/shadow-offset-expected.txt: Removed.
12:58 PM Changeset in webkit [34316] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix for non-AllInOne builds

  • kjs/array_object.cpp: Added a missing #include.
12:51 PM Changeset in webkit [34315] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

WebCore:

2008-06-02 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Bug 18066: REGRESSION: createAttribute throws NAMESPACE_ERR exception
​https://bugs.webkit.org/show_bug.cgi?id=18066

Test: fast/dom/createAttribute-exception.html

  • dom/Document.cpp: (WebCore::Document::createAttributeNS):
  • dom/Document.h: Add a bool parameter shouldIgnoreNamespaceChecks to createNamespaceNS() used by createAttribute() to bypass namespace checking.

LayoutTests:

2008-06-02 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Bug 18066: REGRESSION: createAttribute throws NAMESPACE_ERR exception
​https://bugs.webkit.org/show_bug.cgi?id=18066

  • fast/dom/createAttribute-exception-expected.txt: Added.
  • fast/dom/createAttribute-exception.html: Added.
11:13 AM Changeset in webkit [34314] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-06-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

Speculative fix for <rdar://problem/5661112>
CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62


Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
layouts to be triggered.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createPlugin]):
10:32 AM Changeset in webkit [34313] by kmccullough@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2008-06-02 Kevin McCullough <​kmccullough@apple.com>

Took out accidental confilct lines I checked in.

  • ChangeLog:
10:30 AM Changeset in webkit [34312] by Darin Adler
  • 8 edits
    1 copy
    2 moves
    5 adds in trunk

WebCore:

2008-06-02 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Tweak implementation a tiny bit for improved performance when the first character does not match. (WebCore::cssPropertyName): Reject property names with a leading uppercase letter.

LayoutTests:

2008-06-02 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • fast/dom/CSSStyleDeclaration: Added.
  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html: Added.
  • fast/dom/CSSStyleDeclaration/resources: Added.
  • fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/Element/resources/TEMPLATE.html.
  • fast/dom/CSSStyleDeclaration/resources/css-properties-case-sensitive.js: Added.
  • fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt: Removed.
  • fast/dom/CSSStyleDeclaration-empty-string-property.html: Removed.
  • fast/dom/CSSStyleDeclaration/empty-string-property-expected.txt: Copied from LayoutTests/fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt.
  • fast/dom/CSSStyleDeclaration/empty-string-property.html: Copied from LayoutTests/fast/dom/CSSStyleDeclaration-empty-string-property.html.
  • fast/js/duplicate-param-crash.html: Allowed the make-js-test-wrappers script to update this file.
  • fast/js/duplicate-param-gc-crash.html: Ditto.
  • fast/js/resources/tostring-exception-in-property-access.js: Ditto.
  • fast/js/var-shadows-arg-crash.html: Ditto.
  • fast/js/var-shadows-arg-gc-crash.html: Ditto.
10:26 AM Changeset in webkit [34311] by Darin Adler
  • 4 edits
    1 copy
    3 adds in trunk

WebCore:

2008-06-02 Darin Adler <Darin Adler>

Reviewed by Mitz.

Test: fast/parser/pre-first-line-break.html

  • editing/markup.cpp: (WebCore::appendStartMarkup): Fix handling of <listing>. Not part of the bug mentioned above, but uncovered by the regression test.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Clear the "discardLF" flag when processing a new tag.

LayoutTests:

2008-06-02 Darin Adler <Darin Adler>

Reviewed by Mitz.

  • fast/parser/pre-first-line-break-expected.txt: Added.
  • fast/parser/pre-first-line-break.html: Added.
  • fast/parser/resources/TEMPLATE.html: Copied from fast/dom/resources/TEMPLATE.html.
  • fast/parser/resources/pre-first-line-break.js: Added.
10:11 AM Changeset in webkit [34310] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-02 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler
Implement Next Sibling pointers as groundwork for removing the recursion
limit in the profiler.

  • profiler/ProfileNode.cpp: Also I renamed parentNode and headNode since 'node' is redundant. (KJS::ProfileNode::ProfileNode): Initialize the nextSibling. (KJS::ProfileNode::willExecute): If there are already children then the new child needs to be the nextSibling of the last child. (KJS::ProfileNode::didExecute): (KJS::ProfileNode::addChild): Ditto. (KJS::ProfileNode::stopProfiling): (KJS::ProfileNode::sortTotalTimeDescending): For all of the sorting algorithms once the children are sorted their nextSibling pointers need to be reset to reflect the new order. (KJS::ProfileNode::sortTotalTimeAscending): (KJS::ProfileNode::sortSelfTimeDescending): (KJS::ProfileNode::sortSelfTimeAscending): (KJS::ProfileNode::sortCallsDescending): (KJS::ProfileNode::sortCallsAscending): (KJS::ProfileNode::sortFunctionNameDescending): (KJS::ProfileNode::sortFunctionNameAscending): (KJS::ProfileNode::resetChildrensSiblings): This new function simply loops over all of the children and sets their nextSibling pointers to the next child in the Vector (KJS::ProfileNode::debugPrintData):
  • profiler/ProfileNode.h: (KJS::ProfileNode::parent): (KJS::ProfileNode::setParent): (KJS::ProfileNode::nextSibling): (KJS::ProfileNode::setNextSibling): (KJS::ProfileNode::totalPercent): (KJS::ProfileNode::selfPercent):
10:08 AM Changeset in webkit [34309] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed the recursion limit from JSObject::call, since the VM does
recursion checking now.

This should allow us to remove JSObject::call entirely, netting a small
speedup.

  • kjs/object.cpp: (KJS::JSObject::call):
9:40 AM Changeset in webkit [34308] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a bug where only the last breakpoint would be hit after reloading
the page. Also fixes a bug where disabled breakpoints would be hit
after reloading the page.

Reviewed by Darin Adler.

  • page/inspector/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): Don't call InspectorController.addBreakpoint() unless the breakpoint is enabled.
  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript): Move the addBreakpoint() call inside the for loop so each breakpoint is added. Also check the breakpoint's enabled state before calling addBreakpoint().
9:40 AM Changeset in webkit [34307] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where the line highlight and the execution line were conflicting.
The line highlight no longer shows up when the execution line changes, only
when showResource or showScript is called with a line number.

Reviewed by Darin Adler.

  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): Pass true for shouldHighlightLine. (WebInspector.ScriptsPanel.prototype.showResource): Ditto. (WebInspector.ScriptsPanel.prototype._showScriptOrResource): Added a shouldHighlightLine argument that triggers the highlightLine() call on the SourceFrame. (WebInspector.ScriptsPanel.prototype._goBack): Pass false for shouldHighlightLine since we need to pass true for fromBackForwardAction. (WebInspector.ScriptsPanel.prototype._goForward): Ditto.
9:39 AM Changeset in webkit [34306] by timothy@apple.com
  • 2 edits in trunk/WebCore

Bring the Web Inspector forward when the debugger pauses.

​https://bugs.webkit.org/show_bug.cgi?id=19095

Reviewed by Darin Adler.

  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused): Call window.focus() and make the Scripts panel the current panel.
9:36 AM Changeset in webkit [34305] by alp@webkit.org
  • 4 edits in trunk

2008-06-02 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

Build WebCore GTK+ sources as part of WebCore, not WebKit.
Split common and GTK+-specific sources into separate file lists.

9:36 AM Changeset in webkit [34304] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Adele Peterson.

Added a specific affordance for avoiding stack overflow when converting
recursive arrays to string, in preparation for removing generic stack
overflow checking from JSObject::call.


Tested by fast/js/toString-stack-overflow.html.

9:32 AM Changeset in webkit [34303] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alice Liu.


Refactored some hand-rolled code to call ScopeChain::globalObject instead.

9:30 AM Changeset in webkit [34302] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed ASSERT due to execution continuing after an exception is thrown
during array sort.

  • kjs/array_instance.cpp: (KJS::AVLTreeAbstractorForArrayCompare::compare_key_key): Don't call the custom comparator function if an exception has been thrown. Just return 1 for everything, so the sort completes quickly. (The result will be thrown away.)

LayoutTests:

2008-06-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Test for an exception thrown from an array sort comparator function.

  • fast/js/throw-from-array-sort-expected.txt: Added.
  • fast/js/throw-from-array-sort.html: Added.
6:39 AM Changeset in webkit [34301] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-06-02 Simon Pieters <​zcorpan@hotmail.com>

Reviewed and landed by Alexey.

​https://bugs.webkit.org/show_bug.cgi?id=19355
createElement() with colon and localName

WebKit behavior has changed to expected during Acid3 work (r31230, r31231), but this
specific case appears to have been an untested side effect, landing it now.

  • fast/dom/createElement-with-column-expected.txt: Added.
  • fast/dom/createElement-with-column.xml: Added.
  • fast/dom/createElement-with-column.html: Added.
3:23 AM Changeset in webkit [34300] by Simon Hausmann
  • 4 edits in trunk/WebCore

2008-05-30 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Implement basic media element controls for the QtWebKit port.

3:23 AM Changeset in webkit [34299] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-30 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Change default styling of media elements to allow controls
to be placed at any position within the media element

3:17 AM Changeset in webkit [34298] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-30 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Use intrinsic size for media elements with no natural size.

3:16 AM Changeset in webkit [34297] by Simon Hausmann
  • 6 edits
    2 adds in trunk/WebCore

2008-05-28 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Allow platform specific adjustments to the default style sheet.

Clients will change the ifdef in RenderTheme.cpp and implement
any platform specific adjustments in RenderThemeXXX.cpp, either
by loading a file as the Qt port does, or by modifying the style
directly.

3:08 AM Changeset in webkit [34296] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-06-02 Siraj Razick <​siraj.razick@collabora.co.uk>

Reviewed by Simon

Allow button fonts to scale based on the text size multiplier.

​https://bugs.webkit.org/show_bug.cgi?id=19251

12:25 AM Changeset in webkit [34295] by mrowe@apple.com
  • 4 edits in tags/Safari-6526.11.1

Versioning.

12:20 AM Changeset in webkit [34294] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.11.1

New tag.

12:19 AM Changeset in webkit [34293] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/JavaScriptCore

Merge r34205.

Jun 1, 2008:

11:44 PM Changeset in webkit [34292] by rwlbuis@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=15823
getPropertyValue for border returns null, should compute the shorthand value

Compute the value for the border shorthand property by computing
its shorthand subproperties.

Test: fast/css/getPropertyValue-border.html

9:31 PM Changeset in webkit [34291] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch

Versioning.

9:30 PM Changeset in webkit [34290] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.11

New tag.

7:08 PM Changeset in webkit [34289] by alp@webkit.org
  • 2 edits
    1 add in trunk

2008-06-01 Josh Triplett <​josh@freedesktop.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16891
[GTK] autotools build is slow

Add dolt revision 5e9eef10 to the autotools build system. Speeds up
the build, often by a factor of two or more on supported platforms,
otherwise falls back to libtool.

See ​http://dolt.freedesktop.org for details.

  • acinclude.m4: Added.
  • configure.ac:
12:48 PM Changeset in webkit [34288] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

12:46 PM Changeset in webkit [34287] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/canvas/shadow-offset.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow): Slightly increase the magnitude of the offsets passed to CGContextSetShadow* to ensure that the end result after truncation is the desired integer offsets. This is the same workaround for <rdar://problem/5539388> that is used in GraphicsContext::setShadow(). Also correct a recent regression where shadow Y offsets were flipped.

LayoutTests:

Reviewed by Darin Adler.

  • fast/canvas/shadow-offset.html: Added.
  • platform/mac/fast/canvas/shadow-offset-expected.checksum: Added.
  • platform/mac/fast/canvas/shadow-offset-expected.png: Added.
  • platform/mac/fast/canvas/shadow-offset-expected.txt: Added.
2:37 AM Changeset in webkit [34286] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-06-01 Alp Toker <​alp@nuanti.com>

Suggested by Christian Dywan.

Use float literals for zoom values and improve documentation wording.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp:
2:24 AM Changeset in webkit [34285] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-06-01 Alp Toker <​alp@nuanti.com>

Reviewed by Oliver.

Remove webkit_web_view_go_backward(),
webkit_web_view_can_go_backward(). These have been obsoleted by
the back() versions for quite a while.

  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
Note: See TracTimeline for information about the timeline view.