⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 6, 2008:

11:03 PM Changeset in webkit [34412] by ap@webkit.org
  • 26 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Darin.

Combine per-thread objects into one, to make it easier to support legacy clients (for
which they shouldn't be really per-thread).

No change on SunSpider total.

  • kjs/JSGlobalData.cpp: Added. (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData): (KJS::JSGlobalData::threadInstance):
  • kjs/JSGlobalData.h: Added. This class encapsulates all data that should be per-thread (or shared between legacy clients). It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.
  • kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually, all of them should, but this will be a separate patch.
  • kjs/identifier.cpp: (KJS::IdentifierTable::literalTable): (KJS::createIdentifierTable): (KJS::deleteIdentifierTable): (KJS::Identifier::add): (KJS::Identifier::addSlowCase): Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.
  • kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.
  • kjs/nodes.cpp: (KJS::Node::Node): (KJS::EvalFunctionCallNode::emitCode): (KJS::ScopeNode::ScopeNode): Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a temporary measure, they will need to use JSGlobalData explicitly.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::callEval):
  • kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
  • kjs/CommonIdentifiers.h:
  • kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::evaluate):
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/ExecState.h: (KJS::ExecState::globalData): (KJS::ExecState::identifierTable): (KJS::ExecState::propertyNames): (KJS::ExecState::emptyList): (KJS::ExecState::lexer): (KJS::ExecState::parser): (KJS::ExecState::arrayTable): (KJS::ExecState::dateTable): (KJS::ExecState::mathTable): (KJS::ExecState::numberTable): (KJS::ExecState::RegExpImpTable): (KJS::ExecState::RegExpObjectImpTable): (KJS::ExecState::stringTable):
  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (KJS::JSGlobalObject::head): (KJS::JSGlobalObject::globalData):
  • kjs/Parser.cpp: (KJS::Parser::parse):
  • kjs/Parser.h:
  • kjs/function.cpp: (KJS::FunctionImp::getParameterName): (KJS::IndexToNameMap::unMap): (KJS::globalFuncEval):
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
  • kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
  • kjs/lexer.cpp: (kjsyylex):
  • kjs/lexer.h:
  • kjs/testkjs.cpp: (prettyPrintScript): Updated for the above changes. Most of threadInstance uses here will need to be replaced with explicitly passed pointers to support legacy JSC clients.
9:51 PM Changeset in webkit [34411] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-06 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19424: Add support for logging opcode pair counts
<​https://bugs.webkit.org/show_bug.cgi?id=19424>

JavaScriptCore:

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::OpcodeStats::OpcodeStats): (KJS::compareOpcodeIndices): (KJS::compareOpcodePairIndices): (KJS::OpcodeStats::~OpcodeStats): (KJS::OpcodeStats::recordInstruction): (KJS::OpcodeStats::resetLastInstruction):
  • VM/Opcode.h:
7:11 PM Changeset in webkit [34410] by jchaffraix@webkit.org
  • 11 edits
    1 add in trunk/WebCore

WebCore:

2008-06-06 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
​https://bugs.webkit.org/show_bug.cgi?id=19200

  • Switched *.in files to XML format.
  • Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.
  • Updated the build systems to include bindings/scripts when executing make_names.pl (for XMLTiny dependency).
  • Cleaned-up make_names.pl a little.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/scripts/XMLTiny.pm: Added.
  • dom/make_names.pl:
  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:
  • svg/svgattrs.in:
  • svg/svgtags.in:
  • svg/xlinkattrs.in:
  • xml/xmlattrs.in:
3:51 PM Changeset in webkit [34409] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-06-06 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= = $= should all accept the empty string, but match nothing

Test: fast/css/begin-end-contain-selector-empty-value.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= = $= should all accept the empty string, but match nothing.

  • fast/css/begin-end-contain-selector-empty-value.html: Added.
  • platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.
3:09 PM Changeset in webkit [34408] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by mitz.

More cleanup of CSSParser.
Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
3:03 PM Changeset in webkit [34407] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by mitz.

More cleanup of CSSParser.
Rename CSSParser::parsedProperties to m_parsedProperties.

  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
2:49 PM Changeset in webkit [34406] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by mitz.

Start the cleanup of CSSParser.
Rename CSSParser::styleElement to CSSParser::m_styleElement

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::document): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h:
2:07 PM Changeset in webkit [34405] by eric@webkit.org
  • 5 edits in trunk

Reviewed by adele. Landed by eseidel.

​https://bugs.webkit.org/show_bug.cgi?id=18337

Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::typeAheadFind):
1:39 PM Changeset in webkit [34404] by justin.garcia@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break


Serialization of font-family:-webkit-monospace when it came from a
CSSMutableStyleDeclaration would wrap the value in single quotes but
serialization of the same property value pair from a CSSComputedStyleDeclaration
wouldn't, which kept code that checked for and removed non-redundant styles from
style spans from working correctly.

A redundant style left on a style span would not normally create a rendering
difference, but it did in this case because an element with
font-family:-webkit-monospace does not appear to inherit font-size.
Added a FIXME about how we might need to keep font-size on a style span if its
non-redundant styles include font-family:-webkit-monospace, although I couldn't
create a test case to produce this scenario.

  • css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Don't return false if the String starts with a '-'. This function now appears identical to isCSSTokenizerIdentifier, so perhaps we should use a single function.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME. Removed the creation of two Strings that were never used.

LayoutTests:

2008-06-06 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break


  • editing/deleting/5890684-expected.txt: Added.
  • editing/deleting/5890684.html: Added.
10:06 AM Changeset in webkit [34403] by justin.garcia@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-06-06 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.

<​https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle can destroy insertedPlaceholder if it needs to move it, but it will set an endingSelection() at [movedPlaceholder, 0] if it does so. Re-fetch insertedPlaceholder if that happens. The long term solution for these crashes is to make moveParagraphs not copy/destroy/move content, and to make VisiblePositions update themselves on DOM mutations.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this in the future, but ASSERT to catch them in debug builds.

LayoutTests:

2008-06-06 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.

<​https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode


  • editing/execCommand/19087-expected.txt: Added.
  • editing/execCommand/19087.html: Added.
10:01 AM WikiStart edited by iain@openedhand.com
Added a link to the Clutter page (diff)
9:58 AM clutter created by iain@openedhand.com
9:48 AM Changeset in webkit [34402] by kmccullough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.

  • Change the remaining functions that do not take arguments, from using recursion to using iteration.
  • JavaScriptCore.exp:
  • profiler/Profile.cpp: (KJS::stopProfiling): (KJS::restoreAll): (KJS::Profile::stopProfiling): Use foreach instead of recursion. (KJS::Profile::restoreAll): Ditto.
  • profiler/Profile.h:
  • profiler/ProfileNode.cpp: Remove recursion. (KJS::ProfileNode::stopProfiling): (KJS::ProfileNode::restore):
  • profiler/ProfileNode.h:
7:48 AM Changeset in webkit [34401] by jchaffraix@webkit.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

LayoutTests:

2008-06-06 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Alexey.

xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
called.
The test was failing because CoreFoundation keeps the data if they are not big enough
(which led to only 1 progress event dispatched).

We now generate a big response instead of a small one.

Warning: this test is not guaranteed to succeed as we cannot guarantee that the server

will send responses' sizes that are close for 2 different requests to the same
resource.

  • http/tests/xmlhttprequest/resources/big-response.php: Added.
  • http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a warning about the possible failure of the test.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.

Jun 5, 2008:

10:09 PM Changeset in webkit [34400] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Fix Greater and GreaterEq nodes to emit code in the correct order.

Reviewed by Alexey.

9:44 PM Changeset in webkit [34399] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19403>
ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): If the selection was all formatting (like an empty list) the format-less text will be empty. Early return to avoid the ASSERT that fires if input(...) is called with an empty String.

LayoutTests:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.


<​https://bugs.webkit.org/show_bug.cgi?id=19403>
ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call


  • editing/execCommand/19403-expected.txt: Added.
  • editing/execCommand/19403.html: Added.
6:43 PM Changeset in webkit [34398] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-06-05 Alp Toker <​alp@nuanti.com>

Add 'Since' documentation for API versioning functions.

  • webkit/webkitversion.cpp:
6:09 PM Changeset in webkit [34397] by alp@webkit.org
  • 4 edits in trunk

2008-06-05 Alp Toker <​alp@nuanti.com>

Build fix for r34387.

  • GNUmakefile.am:
6:00 PM Changeset in webkit [34396] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Antti Koivisto <Antti Koivisto>

Reviewed by Alp Toker.


Fix whitespaces.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters):
5:50 PM Changeset in webkit [34395] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Antti Koivisto <Antti Koivisto>

Reviewed by Darin.


Support compiling JavaScriptCore for ARM.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer):
5:49 PM Changeset in webkit [34394] by Antti Koivisto
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Oops, accidentally commited ChangeLog only.

5:47 PM Changeset in webkit [34393] by Antti Koivisto
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2008-06-05 Antti Koivisto <Antti Koivisto>

Reviewed by Darin.


Support compiling JavaScriptCore for ARM.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer):
5:33 PM Changeset in webkit [34392] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Jon.

  • Name changes.
  • JavaScriptCore.exp:
  • profiler/Profile.cpp: (KJS::Profile::Profile): (KJS::Profile::stopProfiling): (KJS::Profile::didExecute): (KJS::Profile::forEach): (KJS::Profile::debugPrintData): (KJS::Profile::debugPrintDataSampleStyle):
  • profiler/Profile.h: (KJS::Profile::callTree): (KJS::Profile::totalTime): (KJS::Profile::sortTotalTimeDescending): (KJS::Profile::sortTotalTimeAscending): (KJS::Profile::sortSelfTimeDescending): (KJS::Profile::sortSelfTimeAscending): (KJS::Profile::sortCallsDescending): (KJS::Profile::sortCallsAscending): (KJS::Profile::sortFunctionNameDescending): (KJS::Profile::sortFunctionNameAscending): (KJS::Profile::focus): (KJS::Profile::exclude): (KJS::Profile::restoreAll):
5:28 PM Changeset in webkit [34391] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Stephanie Lewis.

Added the -fno-move-loop-invariants flag to the pcre_exec.cpp build, to
tell GCC not to perform loop invariant motion, since GCC's loop
invariant motion doesn't do very well with computed goto code.


SunSpider reports no change.

5:20 PM Changeset in webkit [34390] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints


ApplyStyleCommand::applyInlineStyle does some work and then checks to see
if the start offset of the Range it's operating on is now past the caretMaxOffset
of the start container. If it is, applyInlineStyle updates the position to
[startContainer->traverseNextNode(), 0] and then operates on that new start
position.


caretMaxOffset was incorrect for horizontal rules. It should be 1 and it was 0. So,
if the horizontal rule was the last node in the document, applyInlineStyle would update
its start position to [0, 0] and then try to operate on that position, assuming it was
non-null, leading to the ASSERT.


  • rendering/RenderObject.cpp: (WebCore::RenderObject::caretMaxOffset):

LayoutTests:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.


<​https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints

  • editing/execCommand/19089-expected.txt: Added.
  • editing/execCommand/19089.html: Added.
4:19 PM Changeset in webkit [34389] by Chris Fleizach
  • 3 edits in trunk/WebCore

<rdar://problem/5947396> AccessibilityListBoxOptions should return their string as AXValue, not AXTitle

4:13 PM Changeset in webkit [34388] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Stephanie Lewis.


Added the -fno-tree-pre flag to the Machine.cpp build, to tell GCC not
to perform Partial Redundancy Elimination (PRE) on trees in Machine.cpp,
since GCC's PRE doesn't do very well with computed goto code.


SunSpider reports a .7% speedup.

3:50 PM Changeset in webkit [34387] by christian@webkit.org
  • 7 edits
    1 copy
    1 add in trunk

Please add a version to the Gtk port
​https://bugs.webkit.org/show_bug.cgi?id=14141

Reviewed by Alp Toker.

3:40 PM Changeset in webkit [34386] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Stephanie Lewis (or maybe the other way around).


Minor change to PCRE to help out certain compilers.


SunSpider reports no change, maybe a small speedup.

  • pcre/pcre_exec.cpp: (match): Use instructionPtr++ a little less, to avoid confusing the optimizer.
3:34 PM Changeset in webkit [34385] by justin.garcia@apple.com
  • 3 edits
    6 adds in trunk

WebCore:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Harrison.

<rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice
<rdar://problem/5831310> CrashTracer: [USER] 4 crashes in Mail at WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion
<rdar://problem/5480141> GoogleDocs: Attempting to indent content in <td> closes <table> element


A crash would occur when indenting a selection that started just before a table
and ended inside that table. With a selection like this, we'd indent the entire
table, then try and indent paragraphs inside it, but the stored position for the
next paragraph to indent was inside content that had been removed from the document
during the first Indent.


Fixed the crash adjusting the selection to perform the indent on to prepare it
for paragraph iteration using selectionForParagraphIteration. We do this adjustment
for paragraph iteration in InsertList as well.


Also, indenting paragraphs inside table cells would break table structure because
we were splitting the DOM all the way up to the root editable element to insert
a blockquote. Fixed this by only splitting up to the enclosing table cell. This
matches FF. Lastly, fixed a bug where indenting several paragraphs inside different
table cells would move all the selected text into the same table cell. FF still has
this bug.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion):

LayoutTests:

2008-06-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Harrison.


<rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice

  • editing/execCommand/5658933-1-expected.txt: Added.
  • editing/execCommand/5658933-1.html: Added.
  • editing/execCommand/5658933-2-expected.txt: Added.
  • editing/execCommand/5658933-2.html: Added.
  • editing/execCommand/5658933-3-expected.txt: Added.
  • editing/execCommand/5658933-3.html: Added.
3:17 PM Changeset in webkit [34384] by Chris Fleizach
  • 10 edits in trunk/WebCore

<rdar://problem/5979998> AXList controls should have AXSelectedChildren and its children's AXSelected attribute writable

3:01 PM Changeset in webkit [34383] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by mjs.

Get rid of Uninitialized Memory Reads (UMRs) in the XPath::Value copy constructor.

No functional changes, thus no tests.

  • xml/XPathValue.h: (WebCore::XPath::Value::Value): initialize all values in each constructor
1:51 PM Changeset in webkit [34382] by hyatt@apple.com
  • 3 edits
    1 add in trunk/WebCore

2008-06-04 David Hyatt <​hyatt@apple.com>

Fix for <rdar://problem/5957994> Height doesn't animate

Improve the behavior when transitions are dynamically changed. Make sure to leave older transitions
running and let them obsolete themselves when they finish.

Reviewed by Dan Bernstein

Added WebCore/manual-tests/transitions2.html (must be tested manually)

  • manual-tests/transitions.html:
  • manual-tests/transitions2.html: Added.
  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::property): (WebCore::ImplicitAnimation::setFinished): (WebCore::ImplicitAnimation::markedForDeath): (WebCore::ImplicitAnimation::setMarkedForDeath): (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::reset): (WebCore::ImplicitAnimation::animate): (WebCore::CompositeImplicitAnimation::animate):
1:33 PM Changeset in webkit [34381] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt.

No functional changes, thus no tests.

  • platform/graphics/Color.h: remove unnecessary bitfield use
1:03 PM Changeset in webkit [34380] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Re-landing an independent part of a previously rolled out threading patch.

  • wtf/ThreadSpecific.h: Make sure to initialize POD thread-specific varaibles, too (replaced "new T" with "new T()").
12:56 PM Changeset in webkit [34379] by Antti Koivisto
  • 4 edits in trunk

WebCore:

2008-06-05 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.


Make hasFeature() return true for the animation stuff.

  • dom/DOMImplementation.cpp: (WebCore::isSVG11Feature):

LayoutTests:

2008-06-05 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.


Make hasFeature() return true for the animation stuff.

  • svg/custom/svg-features-expected.txt:
10:54 AM Changeset in webkit [34378] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Hyatt.


  • force inlining of a template function that only has one call site per specialization 1.3% speedup on SunSpider
  • kjs/collector.cpp: (KJS::Collector::heapAllocate): This template function is only called from allocate() and allocateNumber() (once per specialization) and the extra call overhead for GC allocation shows up, so force inlining.
9:55 AM Changeset in webkit [34377] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/transforms/shadows.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow): In Core Graphics, shadow dimensions are always in device space. Account for that, and apply the current context transform to shadow offset, and multiply the blur radius by the inverse of the operator norm of the inverse transform (which is the radius of the circle inscribed in the transformed unit circle).
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBoxShadow): Added 1px separation between the edge of the filled shape and the edge of the clipped-out shape, because in a transformed context, due to antialiasing, the fill can bleed into the clip if they touch.

LayoutTests:

Reviewed by Darin Adler.

  • fast/transforms/shadows.html: Added.
  • platform/mac/fast/transforms/shadows-expected.checksum: Added.
  • platform/mac/fast/transforms/shadows-expected.png: Added.
  • platform/mac/fast/transforms/shadows-expected.txt: Added.
4:45 AM Changeset in webkit [34376] by Simon Hausmann
  • 4 edits in trunk/LayoutTests

2008-06-05 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Update layout tests on Mac based on the changes to html4.css
in r34299. The missing backgroundClip and outlineClip in the
new results is strange, but visually it looks the same.

3:36 AM Changeset in webkit [34375] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-05 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Prevent cycles when converting from DOM objects to
QVariant, due to cycles in the DOM tree.

3:30 AM Changeset in webkit [34374] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey and Oliver.


  • remove profiler fetch hack I measure an 0.5% progression from this, others show a wash. It seems not needed any more.
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
2:19 AM Changeset in webkit [34373] by cwzwarich@webkit.org
  • 7 edits in trunk

2008-06-05 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19400: subscript operator does not protect base when necessary
<​https://bugs.webkit.org/show_bug.cgi?id=19400>

Use a temporary for the base in BracketAccessorNode if the subscript
might possibly modify it.

JavaScriptCore:

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode):
  • kjs/nodes.h: (KJS::BracketAccessorNode::):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:
Note: See TracTimeline for information about the timeline view.