Context Navigation

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_add): (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (WebKit::core):

6:12 PM Changeset in webkit [34434] by Darin Adler

2 edits in trunk/WebKit/gtk

2008-06-07 Darin Adler <Darin Adler>

try to fix build after HistoryItem changes

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create. (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also believe this fixes a memory leak in the old version.

5:20 PM Changeset in webkit [34433] by cwzwarich@webkit.org

4 edits
1 delete in trunk

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Timothy.

Remove the --squirrelfish option from SunSpider, as it is no longer needed.

SunSpider:

sunspider:
tests/LIST-SQUIRRELFISH: Removed.

WebKitTools:

Scripts/run-sunspider:

3:51 PM Changeset in webkit [34432] by Darin Adler

100 edits in trunk

WebCore:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
bindings/js/JSSVGLazyEventListener.h: (WebCore::JSSVGLazyEventListener::create):
bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
bindings/js/JSSVGPointListCustom.cpp: (WebCore::commonExit): (WebCore::commonExitReadOnly): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
bindings/js/kjs_binding.cpp: (WebCore::setDOMException):
bindings/js/kjs_events.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::create): (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): (WebCore::ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSFontFace.h: (WebCore::CSSFontFace::create): (WebCore::CSSFontFace::CSSFontFace):
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
css/CSSParser.cpp: (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::create):
css/Counter.h: (WebCore::Counter::create): (WebCore::Counter::Counter):
css/DashboardRegion.h: (WebCore::DashboardRegion::create): (WebCore::DashboardRegion::DashboardRegion):
css/Rect.h: (WebCore::Rect::create): (WebCore::Rect::Rect):
dom/ChildNodeList.h: (WebCore::ChildNodeList::create):
dom/ClassNodeList.h: (WebCore::ClassNodeList::create):
dom/Clipboard.h:
dom/DOMCoreException.h: (WebCore::DOMCoreException::create):
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::instance):
dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
dom/Document.cpp: (WebCore::Document::addWindowEventListener): (WebCore::Document::removeWindowEventListener): (WebCore::Document::setDecoder): (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::plugins): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems):
dom/Document.h:
dom/DynamicNodeList.h:
dom/EventException.h: (WebCore::EventException::create): (WebCore::EventException::EventException):
dom/EventListener.h:
dom/EventTarget.cpp: (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener):
dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
dom/ExceptionBase.h:
dom/NameNodeList.h: (WebCore::NameNodeList::create):
dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelectorAll):
dom/NodeFilterCondition.h:
dom/NodeList.h:
dom/RangeException.h: (WebCore::RangeException::create): (WebCore::RangeException::RangeException):
dom/RegisteredEventListener.h: (WebCore::RegisteredEventListener::create):
dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
dom/SelectorNodeList.h:
dom/StaticNodeList.cpp: (WebCore::StaticNodeList::StaticNodeList):
dom/StaticNodeList.h: (WebCore::StaticNodeList::adopt):
dom/TagNodeList.h: (WebCore::TagNodeList::create):
history/HistoryItem.cpp: (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::copy):
history/HistoryItem.h: (WebCore::HistoryItem::create):
html/CanvasGradient.h:
html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
html/CanvasPattern.h: (WebCore::CanvasPattern::create):
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor): (WebCore::CanvasRenderingContext2D::createPattern):
html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
html/CanvasStyle.h: (WebCore::CanvasStyle::create):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::create):
html/HTMLCollection.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::children):
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::create):
html/HTMLFormCollection.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::elements):
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::willSaveToCache):
html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create):
html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::create):
html/HTMLOptionsCollection.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::options):
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): (WebCore::HTMLTableRowsCollection::create):
html/HTMLTableRowsCollection.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
html/MediaError.h: (WebCore::MediaError::create): (WebCore::MediaError::MediaError):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::createHistoryItem):
loader/ImageDocument.cpp: (WebCore::ImageEventListener::create): (WebCore::ImageEventListener::ImageEventListener): (WebCore::ImageDocument::createDocumentStructure):
loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::create):
page/Page.cpp: (WebCore::Page::userStyleSheet):
svg/SVGException.h: (WebCore::SVGException::create): (WebCore::SVGException::SVGException):
svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::SVGSMILElement::connectConditions):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData):
xml/XMLHttpRequestException.h: (WebCore::XMLHttpRequestException::create): (WebCore::XMLHttpRequestException::XMLHttpRequestException):
xml/XPathException.h: (WebCore::XPathException::create): (WebCore::XPathException::XPathException):
xml/XPathResult.cpp: (WebCore::InvalidatingEventListener::create): (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::XPathResult::XPathResult):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

History/WebHistoryItem.mm: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
WebView/WebView.mm: (+[WebView _decodeData:]):

WebKit/win:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

WebHistoryItem.cpp: (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::initWithURLString):

3:49 PM Changeset in webkit [34431] by weinig@apple.com

9 edits in trunk/LayoutTests

2008-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix random failures of XSS tests by using window.postMessage().

http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
http/tests/security/resources/cross-frame-access.js:
http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
http/tests/security/resources/cross-frame-iframe.html:
platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

3:37 PM Changeset in webkit [34430] by mitz@apple.com

1 edit
4 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279 REGRESSION (r32660): Text not redrawn correctly when selection changes

fast/text/selection-painted-separately.html: Added.
platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
platform/mac/fast/text/selection-painted-separately-expected.png: Added.
platform/mac/fast/text/selection-painted-separately-expected.txt: Added.

2:56 PM Changeset in webkit [34429] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Eric.

Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17548>

kjs/testkjs.cpp: (functionPrint):

12:32 PM Changeset in webkit [34428] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Sam.

Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17547>

kjs/testkjs.cpp: (functionPrint):

12:02 PM Changeset in webkit [34427] by abarth@webkit.org

1 edit
3 adds in trunk/LayoutTests

2008-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Sam.

Tests for https://bugs.webkit.org/show_bug.cgi?id=17911

http/tests/security/resources/iframe-for-synchronous-form.html: Added.
http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
http/tests/security/xss-DENIED-synchronous-form.html: Added.

11:07 AM Changeset in webkit [34426] by christian@webkit.org

6 edits in trunk

Remove PLATFORM ifdefs from ContextMenu.cpp

https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.

3:59 AM Changeset in webkit [34425] by ap@webkit.org

2 edits in trunk/JavaScriptCore

More build fixes.

kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed JSGlobalData::threadInstance() for non-multithreaded builds.

3:41 AM Changeset in webkit [34424] by ap@webkit.org

5 edits in trunk/JavaScriptCore

Build fix - actually adding JSGlobalData.cpp to non-Mac builds!

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:

3:36 AM Changeset in webkit [34423] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Still more CSSParser cleanup

use c++ style member initializers in CSSParser()
change m_styleElement to m_styleSheet and make it a CSSStyleSheet
finally add my copyright to the files I've been cleaning

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
css/CSSParser.h:
css/SVGCSSParser.cpp:

3:35 AM Changeset in webkit [34422] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

More CSSParser cleanup

rename CSSParser::id to m_id
rename CSSParser::data to m_data
fix a few whitespace and argument name issues

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue):
css/CSSParser.h:

3:35 AM Changeset in webkit [34421] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::strict to m_strict

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseColorFromValue): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::parseBorderImage):
css/CSSParser.h:

3:34 AM Changeset in webkit [34420] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::defaultNamespace to m_defaultNamespace

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet):
css/CSSParser.h:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addNamespace):

3:34 AM Changeset in webkit [34419] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::important to m_important

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange):
css/CSSParser.h:

3:33 AM Changeset in webkit [34418] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Yet another cleanup patch for CSSParser
Rename CSSParser::valueList to m_valueList

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
css/CSSParser.h:
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):

3:32 AM Changeset in webkit [34417] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
Remove CSSParser::current and CSSParser::currentParser and use
the magic of YYLEX_PARAM instead.

css/CSSParser.cpp: (WebCore::enterGeneratedParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseMediaQuery):
css/CSSParser.h:

3:20 AM Changeset in webkit [34416] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Try to fix Gtk/gcc 4.3 build.

kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.

2:57 AM Changeset in webkit [34415] by jchaffraix@webkit.org

4 edits in trunk/WebCore

WebCore:

2008-06-07 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200

Added XML attributes' parsing.

Moved (most) capitalization and audio hacks in the *.in files.

dom/make_names.pl:
html/HTMLTagNames.in:
svg/svgtags.in:

1:20 AM Changeset in webkit [34414] by mitz@apple.com

2 edits in trunk/WebCore

2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>

With the help of Jonathon Jongsma.

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
REGRESSION (r32660): Text not redrawn correctly when selection changes

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Add a condition for when ePos <= sPos

12:58 AM Changeset in webkit [34413] by cwzwarich@webkit.org

3 edits in trunk/LayoutTests

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17663: Wrong sequencing of argument list evaluation
<https://bugs.webkit.org/show_bug.cgi?id=17663>

SquirrelFish fixed this bug, but we should add a test.

LayoutTests:

fast/js/order-of-operations-expected.txt:
fast/js/resources/order-of-operations.js:

Jun 6, 2008:

11:03 PM Changeset in webkit [34412] by ap@webkit.org

26 edits
2 adds in trunk/JavaScriptCore

Reviewed by Darin.

Combine per-thread objects into one, to make it easier to support legacy clients (for
which they shouldn't be really per-thread).

No change on SunSpider total.

JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}

kjs/JSGlobalData.cpp: Added. (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData): (KJS::JSGlobalData::threadInstance):
kjs/JSGlobalData.h: Added. This class encapsulates all data that should be per-thread (or shared between legacy clients). It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.

kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually, all of them should, but this will be a separate patch.

kjs/identifier.cpp: (KJS::IdentifierTable::literalTable): (KJS::createIdentifierTable): (KJS::deleteIdentifierTable): (KJS::Identifier::add): (KJS::Identifier::addSlowCase): Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.

kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.

kjs/nodes.cpp: (KJS::Node::Node): (KJS::EvalFunctionCallNode::emitCode): (KJS::ScopeNode::ScopeNode): Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a temporary measure, they will need to use JSGlobalData explicitly.

VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
VM/CodeGenerator.h:
VM/Machine.cpp: (KJS::callEval):
kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
kjs/CommonIdentifiers.h:
kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::evaluate):
kjs/ExecState.cpp: (KJS::ExecState::ExecState):
kjs/ExecState.h: (KJS::ExecState::globalData): (KJS::ExecState::identifierTable): (KJS::ExecState::propertyNames): (KJS::ExecState::emptyList): (KJS::ExecState::lexer): (KJS::ExecState::parser): (KJS::ExecState::arrayTable): (KJS::ExecState::dateTable): (KJS::ExecState::mathTable): (KJS::ExecState::numberTable): (KJS::ExecState::RegExpImpTable): (KJS::ExecState::RegExpObjectImpTable): (KJS::ExecState::stringTable):
kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (KJS::JSGlobalObject::head): (KJS::JSGlobalObject::globalData):
kjs/Parser.cpp: (KJS::Parser::parse):
kjs/Parser.h:
kjs/function.cpp: (KJS::FunctionImp::getParameterName): (KJS::IndexToNameMap::unMap): (KJS::globalFuncEval):
kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate):
kjs/lexer.cpp: (kjsyylex):
kjs/lexer.h:
kjs/testkjs.cpp: (prettyPrintScript): Updated for the above changes. Most of threadInstance uses here will need to be replaced with explicitly passed pointers to support legacy JSC clients.

JavaScriptCore.exp: Removed KJS::parser().

9:51 PM Changeset in webkit [34411] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-06-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19424: Add support for logging opcode pair counts
<https://bugs.webkit.org/show_bug.cgi?id=19424>

JavaScriptCore:

VM/Machine.cpp: (KJS::Machine::privateExecute):
VM/Opcode.cpp: (KJS::OpcodeStats::OpcodeStats): (KJS::compareOpcodeIndices): (KJS::compareOpcodePairIndices): (KJS::OpcodeStats::~OpcodeStats): (KJS::OpcodeStats::recordInstruction): (KJS::OpcodeStats::resetLastInstruction):
VM/Opcode.h:

7:11 PM Changeset in webkit [34410] by jchaffraix@webkit.org

11 edits
1 add in trunk/WebCore

WebCore:

2008-06-06 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Part of bug 19200: *.in files should embed more information
https://bugs.webkit.org/show_bug.cgi?id=19200

Switched *.in files to XML format.

Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.

Updated the build systems to include bindings/scripts when executing make_names.pl (for XMLTiny dependency).

Cleaned-up make_names.pl a little.

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
bindings/scripts/XMLTiny.pm: Added.
dom/make_names.pl:
html/HTMLAttributeNames.in:
html/HTMLTagNames.in:
svg/svgattrs.in:
svg/svgtags.in:
svg/xlinkattrs.in:
xml/xmlattrs.in:

3:51 PM Changeset in webkit [34409] by mrowe@apple.com

3 edits
2 adds in trunk

2008-06-06 Robert Blaut <webkit@blaut.biz>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= ^{= $= should all accept the empty string, but match nothing}

Test: fast/css/begin-end-contain-selector-empty-value.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06 Robert Blaut <webkit@blaut.biz>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= ^{= $= should all accept the empty string, but match nothing.}

fast/css/begin-end-contain-selector-empty-value.html: Added.
platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.

3:09 PM Changeset in webkit [34408] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by mitz.

More cleanup of CSSParser.
Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
css/CSSParser.h:
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):

3:03 PM Changeset in webkit [34407] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by mitz.

More cleanup of CSSParser.
Rename CSSParser::parsedProperties to m_parsedProperties.

css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
css/CSSParser.h:
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):

2:49 PM Changeset in webkit [34406] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by mitz.

Start the cleanup of CSSParser.
Rename CSSParser::styleElement to CSSParser::m_styleElement

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::document): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
css/CSSParser.h:

2:07 PM Changeset in webkit [34405] by eric@webkit.org

5 edits in trunk

Reviewed by adele. Landed by eseidel.

https://bugs.webkit.org/show_bug.cgi?id=18337

Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::typeAheadFind):

1:39 PM Changeset in webkit [34404] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

2008-06-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

Serialization of font-family:-webkit-monospace when it came from a
CSSMutableStyleDeclaration would wrap the value in single quotes but
serialization of the same property value pair from a CSSComputedStyleDeclaration
wouldn't, which kept code that checked for and removed non-redundant styles from
style spans from working correctly.

A redundant style left on a style span would not normally create a rendering
difference, but it did in this case because an element with
font-family:-webkit-monospace does not appear to inherit font-size.
Added a FIXME about how we might need to keep font-size on a style span if its
non-redundant styles include font-family:-webkit-monospace, although I couldn't
create a test case to produce this scenario.

css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Don't return false if the String starts with a '-'. This function now appears identical to isCSSTokenizerIdentifier, so perhaps we should use a single function.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME. Removed the creation of two Strings that were never used.

LayoutTests:

2008-06-06 Justin Garcia <justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

editing/deleting/5890684-expected.txt: Added.
editing/deleting/5890684.html: Added.

10:06 AM Changeset in webkit [34403] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

2008-06-06 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin.

<https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle can destroy insertedPlaceholder if it needs to move it, but it will set an endingSelection() at [movedPlaceholder, 0] if it does so. Re-fetch insertedPlaceholder if that happens. The long term solution for these crashes is to make moveParagraphs not copy/destroy/move content, and to make VisiblePositions update themselves on DOM mutations.
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this in the future, but ASSERT to catch them in debug builds.

LayoutTests:

2008-06-06 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin.

<https://bugs.webkit.org/show_bug.cgi?id=19087>
Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

editing/execCommand/19087-expected.txt: Added.
editing/execCommand/19087.html: Added.

10:01 AM WikiStart edited by iain@openedhand.com

Added a link to the Clutter page (diff)

9:58 AM clutter created by iain@openedhand.com

9:48 AM Changeset in webkit [34402] by kmccullough@apple.com

6 edits in trunk/JavaScriptCore

2008-06-06 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.

Change the remaining functions that do not take arguments, from using recursion to using iteration.

JavaScriptCore.exp:
profiler/Profile.cpp: (KJS::stopProfiling): (KJS::restoreAll): (KJS::Profile::stopProfiling): Use foreach instead of recursion. (KJS::Profile::restoreAll): Ditto.
profiler/Profile.h:
profiler/ProfileNode.cpp: Remove recursion. (KJS::ProfileNode::stopProfiling): (KJS::ProfileNode::restore):
profiler/ProfileNode.h:

7:48 AM Changeset in webkit [34401] by jchaffraix@webkit.org

3 edits
1 add
1 delete in trunk/LayoutTests

LayoutTests:

2008-06-06 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey.

xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
called.
The test was failing because CoreFoundation keeps the data if they are not big enough
(which led to only 1 progress event dispatched).

We now generate a big response instead of a small one.

Warning: this test is not guaranteed to succeed as we cannot guarantee that the server

will send responses' sizes that are close for 2 different requests to the same
resource.

http/tests/xmlhttprequest/resources/big-response.php: Added.
http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.

http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a warning about the possible failure of the test.
http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed