Context Navigation

← Previous Period
Next Period →

Timeline

Jun 8, 2008:

11:26 PM Changeset in webkit [34464] by abarth@webkit.org

1 edit
37 adds
14 deletes in trunk/LayoutTests

2008-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=16631

Improve coverage of our frame navigation test cases. This revealed a
bug in plugin navigation (we aren't setting the opener properly), but
that's probably better addressed in a separate patch.

http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
http/tests/security/frameNavigation/resources/iframe.html: Added.
http/tests/security/frameNavigation/resources/lib.js: Added.
http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
http/tests/security/frameNavigation/resources/open.html: Added.
http/tests/security/frameNavigation/resources/ready.html: Added.
http/tests/security/frameNavigation/resources/target.html: Added.
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.

11:26 PM Changeset in webkit [34463] by abarth@webkit.org

4 edits
1 copy
1 add in trunk/LayoutTests

2008-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=16856

Fix tests not to rely on broken javascript URL behavior.

fast/events/event-listener-html-non-html-confusion.html:
fast/replaced/image-map-bug16782-expected.txt: Added.
fast/replaced/image-map-bug16782.html: Added.
fast/replaced/image-map.html:
svg/custom/prevent-default.svg:

10:20 PM Changeset in webkit [34462] by cwzwarich@webkit.org

3 edits in trunk/LayoutTests

2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17931: Incorrect decompilation with |new|
<https://bugs.webkit.org/show_bug.cgi?id=17931>

This bug was fixed by SquirrelFish, but we should add a test.

fast/js/function-toString-parentheses-expected.txt:
fast/js/resources/function-toString-parentheses.js:

9:47 PM Changeset in webkit [34461] by cwzwarich@webkit.org

3 edits
1 add in trunk/LayoutTests

2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
<https://bugs.webkit.org/show_bug.cgi?id=17932>

This bug was fixed by SquirrelFish, but we should add a test, as well
as tests for related issues found while developing SquirrelFish.

fast/js/continue-break-multiple-labels-expected.txt:
fast/js/continue-break-multiple-labels.html:
fast/js/resources/continue-break-multiple-labels.js: Added.

9:37 PM Changeset in webkit [34460] by abarth@webkit.org

3 edits
11 adds in trunk

WebCore:

2008-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Inherit document.URL from parent's document.URL, not document.baseURI.

https://bugs.webkit.org/show_bug.cgi?id=19257

Tests: http/tests/security/cookies/assign-document-url.html

http/tests/security/cookies/base-about-blank.html
http/tests/security/cookies/base-tag.html
http/tests/security/cookies/basic.html

dom/Document.cpp: (WebCore::Document::open):

LayoutTests:

2008-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Alder.

Add a number of tests for document.cookie access.

https://bugs.webkit.org/show_bug.cgi?id=19257

http/tests/security/cookies: Added.
http/tests/security/cookies/assign-document-url-expected.txt: Added.
http/tests/security/cookies/assign-document-url.html: Added.
http/tests/security/cookies/base-about-blank-expected.txt: Added.
http/tests/security/cookies/base-about-blank.html: Added.
http/tests/security/cookies/base-tag-expected.txt: Added.
http/tests/security/cookies/base-tag.html: Added.
http/tests/security/cookies/basic-expected.txt: Added.
http/tests/security/cookies/basic.html: Added.
http/tests/security/cookies/resources: Added.
http/tests/security/cookies/resources/set-a-cookie.html: Added.

8:39 PM Changeset in webkit [34459] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.

https://bugs.webkit.org/show_bug.cgi?id=19310

7:12 PM Changeset in webkit [34458] by mitz@apple.com

3 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

Test: fast/multicol/content-height-zero-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): Changed to not keep creating overflow columns that have zero height, because they do not help with fitting content in.

LayoutTests:

test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

Reviewed by Darin Adler.

fast/multicol/content-height-zero-crash-expected.txt: Added.
fast/multicol/content-height-zero-crash.html: Added.

5:57 PM Changeset in webkit [34457] by cwzwarich@webkit.org

7 edits in trunk

2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
<https://bugs.webkit.org/show_bug.cgi?id=19346>

A check for whether a function's caller is eval code accidentally included
the case where the caller's caller is native code. Add a CodeType field to
CodeBlock and use this for the eval caller test instead.

JavaScriptCore:

VM/CodeBlock.h: (KJS::CodeBlock::CodeBlock): (KJS::ProgramCodeBlock::ProgramCodeBlock): (KJS::EvalCodeBlock::EvalCodeBlock):
VM/Machine.cpp: (KJS::getCallerFunctionOffset):
kjs/nodes.cpp: (KJS::FunctionBodyNode::generateCode): (KJS::ProgramNode::generateCode):

LayoutTests:

fast/js/function-dot-arguments-and-caller-expected.txt:
fast/js/function-dot-arguments-and-caller.html:

3:18 PM ApplicationsGtk edited by alp@atoker.com

Add NewsKit and Galaxium (diff)

1:57 PM Changeset in webkit [34456] by Adam Roben

2 edits
1 add in trunk/WebCore

Fix Bug 18837: Database panel fails to display tables if any value is NULL

<https://bugs.webkit.org/show_bug.cgi?id=18837>

Reviewed by Darin Adler.

Test: manual-tests/inspector/display-sql-null.html

manual-tests/inspector/display-sql-null.html: Added.
page/inspector/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all objects to strings before operating on them.

1:57 PM Changeset in webkit [34455] by Adam Roben

2 edits
1 add in trunk/WebCore

Fix Bug 19438: Transaction errors are never displayed in database query view

<https://bugs.webkit.org/show_bug.cgi?id=19438>

Reviewed by Darin Adler.

Test: manual-tests/inspector/display-sql-transaction-error.html

manual-tests/inspector/display-sql-transaction-error.html: Added.
page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use _executeSqlError as the error callback for executeSql. (WebInspector.DatabaseQueryView.prototype._queryError): Changed to only take two parameters. This matches what we'll be passed if db.transaction fails. (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added. Calls through to _queryError.

1:36 PM Changeset in webkit [34454] by Darin Adler

3 edits in trunk/WebCore

2008-06-08 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=18840
[CAIRO] Clipping-support for SVG

Support for clipping in SVG/Cairo and fixes transformation of paths.

platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
svg/graphics/cairo/SVGResourceClipperCairo.cpp: (WebCore::SVGResourceClipper::applyClip):

1:33 PM Changeset in webkit [34453] by Darin Adler

2 edits in trunk/WebCore

2008-06-08 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=18663
Add text-stroke support to Cairo.

platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

1:30 PM Changeset in webkit [34452] by Darin Adler

7 edits
3 adds in trunk

WebCore:

2008-06-08 Vincent Ricard <magic@magicninja.org>

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification

Tests: fast/dom/Element/element-traversal.html

dom/Element.cpp: (WebCore::Element::firstElementChild): (WebCore::Element::lastElementChild): (WebCore::Element::previousElementSibling): (WebCore::Element::nextElementSibling): (WebCore::Element::childElementCount):
dom/Element.h:
dom/Element.idl:

LayoutTests:

2008-06-08 Vincent Ricard <magic@magicninja.org>

Reviewed by Darin.

test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
WebKit does not support ElementTraversal specification

fast/dom/Element/element-traversal-expected.txt: Added.
fast/dom/Element/element-traversal.html: Added.
fast/dom/Element/resources/element-traversal.js: Added.

fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5 new properties. It would be good to rewrite this test so it doesn't have to be updated every time we add a property to Node or Element.
fast/dom/resources/domListEnumeration.js: Ditto.

1:01 PM Changeset in webkit [34451] by Darin Adler

4 edits in trunk

WebCore:

2008-06-08 Bradley Meck <genisis329@gmail.com>

Reviewed by Darin.

fix https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value

Test: fast/css/invalid-cursor-property-crash.html

Changed check for empty url() to be a check for null since url() is valid
CSS even if it is empty.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseBorderImage):

LayoutTests:

2008-06-08 Bradley Meck <genisis329@gmail.com>

Reviewed and tweaked by Darin.

test for https://bugs.webkit.org/show_bug.cgi?id=17051 safari should treat "url()" as a valid CSS value

We should really add some more tests for this. One text-only test each for the
four different sites that handle URLs (cursor image, list style image, fill image,
border image) that were fixed. Currently this covers only the cursor image.

fast/css/invalid-cursor-property-crash.html: Updated test to expect the url() to be expanded into the URL of the document itself. The text of the test is now a bit misleading, but it still tests that it's not a crash, and now it also doubles as a check that url() is handled properly.

12:41 PM Changeset in webkit [34450] by Darin Adler

3 edits
3 adds in trunk

WebCore:

2008-06-08 Vincent Ricard <magic@magicninja.org>

Reviewed by Darin.

Bug 18041: DOMNodeRemoved events are sent twice

Test: fast/dom/Node/DOMNodeRemovedEvent.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild):

LayoutTests:

2008-06-08 Vincent Ricard <magic@magicninja.org>

Reviewed by Darin.

Test case for
Bug 18041: DOMNodeRemoved events are sent twice

fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
fast/dom/Node/DOMNodeRemovedEvent.html: Added.
fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.

12:31 PM Changeset in webkit [34449] by Darin Adler

11 edits
3 adds in trunk

WebCore:

2008-06-08 Tony Chang <idealisms@gmail.com>

Reviewed by Eric Seidel.

fix https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac

Move the drag text delay value into the platform specific files.

Test: editing/selection/drag-text-delay.html

page/EventHandler.cpp:
page/EventHandler.h:
page/gtk/EventHandlerGtk.cpp:
page/mac/EventHandlerMac.mm:
page/qt/EventHandlerQt.cpp:
page/win/EventHandlerWin.cpp:
page/wx/EventHandlerWx.cpp:

LayoutTests:

2008-06-08 Tony Chang <idealisms@gmail.com>

Reviewed by Eric Seidel.

test for https://bugs.webkit.org/show_bug.cgi?id=18167 there should be no text-drag delay on any platform except for Mac

Also updated two tests which depend on the drag text delay to be greater
than 0 by making them no longer select text before the mouse down.

editing/selection/drag-text-delay-expected.txt: Added.
editing/selection/drag-text-delay.html: Added.
platform/mac/editing/selection/drag-text-delay-expected.txt: Added.

fast/events/autoscroll.html:
fast/forms/input-readonly-autoscroll.html:

12:21 PM Changeset in webkit [34448] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2008-06-08 Rob Buis <buis@kde.org>

Reviewed by Darin.

fix https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object

Test: svg/custom/getPresentationAttribute-modify.svg

svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style declaration if it is shared before returning the presentation attribute.

LayoutTests:

2008-06-08 Rob Buis <buis@kde.org>

Reviewed by Darin.

test for https://bugs.webkit.org/show_bug.cgi?id=18512 getPresentationAttribute returns a shared object

svg/custom/getPresentationAttribute-modify-expected.txt: Added.
svg/custom/getPresentationAttribute-modify.svg: Added.

12:08 PM Changeset in webkit [34447] by Darin Adler

2 edits in trunk/LayoutTests

2008-06-08 Eric Roman <minatoar@gmail.com>

Reviewed by Adam Roben.

fix https://bugs.webkit.org/show_bug.cgi?id=18550 cross-frame-access-call.html doesn't really test window.open(), since popups are blocked

http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless.

12:04 PM Changeset in webkit [34446] by alp@webkit.org

4 edits in trunk

2008-06-08 Alp Toker <alp@nuanti.com>

autotools/GTK+ build system cleanup. Don't include WebKit API in the
WebCore build as it's no longer needed since r34426.

11:39 AM Changeset in webkit [34445] by Darin Adler

3 edits in trunk/WebCore

2008-06-08 Jonathan Haas <myrdred@gmail.com>

Reviewed by Eric Seidel.
Tweaked by Darin while landing to make it compile.

fix http://bugs.webkit.org/show_bug.cgi?id=19128 SVG fonts don't work with medial Arabic characters

Haven't figured out a way to make an automated test for this.

svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into its 3-bit field. Did the same for orientation's 2-bit field.

svg/SVGFont.cpp: Did a bit of minor tweaking. (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning since the type is now different.

11:22 AM Changeset in webkit [34444] by Darin Adler

2 edits in trunk/WebCore

2008-06-08 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti.

fix https://bugs.webkit.org/show_bug.cgi?id=19299 <rdar://problem/5969392>

Generate the media MIME type list dynamically.

platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes):

11:16 AM Changeset in webkit [34443] by Darin Adler

2 edits in trunk/WebCore

2008-06-08 Christian Persch <chpe@gnome.org>

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19309 uninitialised variable in PluginView

plugins/PluginView.cpp: (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.

11:07 AM Changeset in webkit [34442] by Darin Adler

2 edits in trunk/WebCore

2008-06-08 Darin Adler <Darin Adler>

Reviewed by Mitz.

https://bugs.webkit.org/show_bug.cgi?id=19435 fix warning in PluginDebug.h

plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.

10:44 AM Changeset in webkit [34441] by mitz@apple.com

2 edits in trunk/BugsSite

Reviewed by Adam Roben.

update trac URL in PrettyPatch

PrettyPatch/PrettyPatch.rb:

9:10 AM Changeset in webkit [34440] by alp@webkit.org

3 edits in trunk

2008-06-08 Alp Toker <alp@nuanti.com>

Rubber-stamped by Mark Rowe.

Bring back -fstrict-aliasing for JavaScriptCore which was removed in
r31821, since aliasing issues have now been fixed.

Use -O3, not -O2 for the JavaScriptCore build.

GNUmakefile.am:
configure.ac:

9:01 AM Changeset in webkit [34439] by Darin Adler

2 edits in trunk/WebKitTools

2008-06-08 Darin Adler <Darin Adler>

Scripts/make-js-test-wrappers: Added another exception.

Jun 7, 2008:

10:56 PM Changeset in webkit [34438] by mitz@apple.com

5 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=19431 <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

Covered by fast/css/remove-shorthand.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap): Fixed a typo which mapped the background shorthand to the mask properties.

LayoutTests:

Reviewed by Dave Hyatt.

updated test for https://bugs.webkit.org/show_bug.cgi?id=19431 <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

fast/css/remove-shorthand-expected.txt:
fast/css/remove-shorthand.html:

8:50 PM Changeset in webkit [34437] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Dan Bernstein.

Bug 17928: testkjs shouldn't require "-f"
<https://bugs.webkit.org/show_bug.cgi?id=17928>

kjs/testkjs.cpp: (printUsageStatement): (parseArguments):

6:57 PM Changeset in webkit [34436] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-06-07 Brent Fulgham <bfulgham@gmail.com>

Cairo build fix for r34432

html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):

6:44 PM Changeset in webkit [34435] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Confirmed by Christian Dywan.

Gtk build fix for r34432

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_add): (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (WebKit::core):

6:12 PM Changeset in webkit [34434] by Darin Adler

2 edits in trunk/WebKit/gtk

2008-06-07 Darin Adler <Darin Adler>

try to fix build after HistoryItem changes

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create. (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also believe this fixes a memory leak in the old version.

5:20 PM Changeset in webkit [34433] by cwzwarich@webkit.org

4 edits
1 delete in trunk

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Timothy.

Remove the --squirrelfish option from SunSpider, as it is no longer needed.

SunSpider:

sunspider:
tests/LIST-SQUIRRELFISH: Removed.

WebKitTools:

Scripts/run-sunspider:

3:51 PM Changeset in webkit [34432] by Darin Adler

100 edits in trunk

WebCore:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
bindings/js/JSSVGLazyEventListener.h: (WebCore::JSSVGLazyEventListener::create):
bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
bindings/js/JSSVGPointListCustom.cpp: (WebCore::commonExit): (WebCore::commonExitReadOnly): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
bindings/js/kjs_binding.cpp: (WebCore::setDOMException):
bindings/js/kjs_events.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
bindings/objc/DOM.mm: (WebCore::ObjCNodeFilterCondition::create): (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): (WebCore::ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSFontFace.h: (WebCore::CSSFontFace::create): (WebCore::CSSFontFace::CSSFontFace):
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
css/CSSParser.cpp: (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
css/CSSSegmentedFontFace.h: (WebCore::CSSSegmentedFontFace::create):
css/Counter.h: (WebCore::Counter::create): (WebCore::Counter::Counter):
css/DashboardRegion.h: (WebCore::DashboardRegion::create): (WebCore::DashboardRegion::DashboardRegion):
css/Rect.h: (WebCore::Rect::create): (WebCore::Rect::Rect):
dom/ChildNodeList.h: (WebCore::ChildNodeList::create):
dom/ClassNodeList.h: (WebCore::ClassNodeList::create):
dom/Clipboard.h:
dom/DOMCoreException.h: (WebCore::DOMCoreException::create):
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::instance):
dom/DOMImplementation.h: (WebCore::DOMImplementation::DOMImplementation):
dom/Document.cpp: (WebCore::Document::addWindowEventListener): (WebCore::Document::removeWindowEventListener): (WebCore::Document::setDecoder): (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::plugins): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems):
dom/Document.h:
dom/DynamicNodeList.h:
dom/EventException.h: (WebCore::EventException::create): (WebCore::EventException::EventException):
dom/EventListener.h:
dom/EventTarget.cpp: (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener):
dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
dom/ExceptionBase.h:
dom/NameNodeList.h: (WebCore::NameNodeList::create):
dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelectorAll):
dom/NodeFilterCondition.h:
dom/NodeList.h:
dom/RangeException.h: (WebCore::RangeException::create): (WebCore::RangeException::RangeException):
dom/RegisteredEventListener.h: (WebCore::RegisteredEventListener::create):
dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
dom/SelectorNodeList.h:
dom/StaticNodeList.cpp: (WebCore::StaticNodeList::StaticNodeList):
dom/StaticNodeList.h: (WebCore::StaticNodeList::adopt):
dom/TagNodeList.h: (WebCore::TagNodeList::create):
history/HistoryItem.cpp: (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::copy):
history/HistoryItem.h: (WebCore::HistoryItem::create):
html/CanvasGradient.h:
html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
html/CanvasPattern.h: (WebCore::CanvasPattern::create):
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor): (WebCore::CanvasRenderingContext2D::createPattern):
html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle):
html/CanvasStyle.h: (WebCore::CanvasStyle::create):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::create):
html/HTMLCollection.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::children):
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::create):
html/HTMLFormCollection.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::elements):
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::willSaveToCache):
html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create):
html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::create):
html/HTMLOptionsCollection.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::options):
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): (WebCore::HTMLTableRowsCollection::create):
html/HTMLTableRowsCollection.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
html/MediaError.h: (WebCore::MediaError::create): (WebCore::MediaError::MediaError):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
loader/FrameLoader.cpp: (WebCore::FrameLoader::write): (WebCore::FrameLoader::createHistoryItem):
loader/ImageDocument.cpp: (WebCore::ImageEventListener::create): (WebCore::ImageEventListener::ImageEventListener): (WebCore::ImageDocument::createDocumentStructure):
loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::create):
page/Page.cpp: (WebCore::Page::userStyleSheet):
svg/SVGException.h: (WebCore::SVGException::create): (WebCore::SVGException::SVGException):
svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::SVGSMILElement::connectConditions):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData):
xml/XMLHttpRequestException.h: (WebCore::XMLHttpRequestException::create): (WebCore::XMLHttpRequestException::XMLHttpRequestException):
xml/XPathException.h: (WebCore::XPathException::create): (WebCore::XPathException::XPathException):
xml/XPathResult.cpp: (WebCore::InvalidatingEventListener::create): (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::XPathResult::XPathResult):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

History/WebHistoryItem.mm: (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
WebView/WebView.mm: (+[WebView _decodeData:]):

WebKit/win:

2008-06-07 Darin Adler <Darin Adler>

Reviewed by Mitz.

work on https://bugs.webkit.org/show_bug.cgi?id=17257 start ref counts at 1 instead of 0 for speed

WebHistoryItem.cpp: (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::initWithURLString):

3:49 PM Changeset in webkit [34431] by weinig@apple.com

9 edits in trunk/LayoutTests

2008-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix random failures of XSS tests by using window.postMessage().

http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
http/tests/security/resources/cross-frame-access.js:
http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
http/tests/security/resources/cross-frame-iframe.html:
platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

3:37 PM Changeset in webkit [34430] by mitz@apple.com

1 edit
4 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279 REGRESSION (r32660): Text not redrawn correctly when selection changes

fast/text/selection-painted-separately.html: Added.
platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
platform/mac/fast/text/selection-painted-separately-expected.png: Added.
platform/mac/fast/text/selection-painted-separately-expected.txt: Added.

2:56 PM Changeset in webkit [34429] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Eric.

Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17548>

kjs/testkjs.cpp: (functionPrint):

12:32 PM Changeset in webkit [34428] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Sam.

Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
<https://bugs.webkit.org/show_bug.cgi?id=17547>

kjs/testkjs.cpp: (functionPrint):

12:02 PM Changeset in webkit [34427] by abarth@webkit.org

1 edit
3 adds in trunk/LayoutTests

2008-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Sam.

Tests for https://bugs.webkit.org/show_bug.cgi?id=17911

http/tests/security/resources/iframe-for-synchronous-form.html: Added.
http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
http/tests/security/xss-DENIED-synchronous-form.html: Added.

11:07 AM Changeset in webkit [34426] by christian@webkit.org

6 edits in trunk

Remove PLATFORM ifdefs from ContextMenu.cpp

https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.

3:59 AM Changeset in webkit [34425] by ap@webkit.org

2 edits in trunk/JavaScriptCore

More build fixes.

kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed JSGlobalData::threadInstance() for non-multithreaded builds.

3:41 AM Changeset in webkit [34424] by ap@webkit.org

5 edits in trunk/JavaScriptCore

Build fix - actually adding JSGlobalData.cpp to non-Mac builds!

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:

3:36 AM Changeset in webkit [34423] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Still more CSSParser cleanup

use c++ style member initializers in CSSParser()
change m_styleElement to m_styleSheet and make it a CSSStyleSheet
finally add my copyright to the files I've been cleaning

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule):
css/CSSParser.h:
css/SVGCSSParser.cpp:

3:35 AM Changeset in webkit [34422] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

More CSSParser cleanup

rename CSSParser::id to m_id
rename CSSParser::data to m_data
fix a few whitespace and argument name issues

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseValue):
css/CSSParser.h:

3:35 AM Changeset in webkit [34421] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::strict to m_strict

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseColorFromValue): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::CSSParser::parseBorderImage):
css/CSSParser.h:

3:34 AM Changeset in webkit [34420] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::defaultNamespace to m_defaultNamespace

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet):
css/CSSParser.h:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addNamespace):

3:34 AM Changeset in webkit [34419] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

Rename CSSParser::important to m_important

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange):
css/CSSParser.h:

3:33 AM Changeset in webkit [34418] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by ap.

Yet another cleanup patch for CSSParser
Rename CSSParser::valueList to m_valueList

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin):
css/CSSParser.h:
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):

3:32 AM Changeset in webkit [34417] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by ap.

More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
Remove CSSParser::current and CSSParser::currentParser and use
the magic of YYLEX_PARAM instead.

css/CSSParser.cpp: (WebCore::enterGeneratedParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseMediaQuery):
css/CSSParser.h:

3:20 AM Changeset in webkit [34416] by ap@webkit.org