⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 17, 2008:

9:44 PM Changeset in webkit [34644] by Beth Dakin
  • 6 edits in trunk/WebCore

2008-06-17 Beth Dakin <Beth Dakin>

Reviewed by Tim.

This patch removes all instances of the phrase "TextMarker" from
function names in the C++ accessibility code. TextMarkers only
exists in the Objective-C code.

  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForLine): (WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions): (WebCore::AccessibilityObject::positionOfLeftWord): (WebCore::AccessibilityObject::positionOfRightWord): (WebCore::AccessibilityObject::leftLineVisiblePositionRange): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::AccessibilityObject::sentenceForPosition): (WebCore::AccessibilityObject::paragraphForPosition): (WebCore::AccessibilityObject::styleRangeForPosition): (WebCore::AccessibilityObject::visiblePositionRangeForRange): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::boundsForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityObject::visiblePositionForPoint): (WebCore::AccessibilityObject::nextVisiblePosition): (WebCore::AccessibilityObject::previousVisiblePosition): (WebCore::AccessibilityObject::nextWordEnd): (WebCore::AccessibilityObject::previousWordStart): (WebCore::AccessibilityObject::nextLineEndPosition): (WebCore::AccessibilityObject::previousLineStartPosition): (WebCore::AccessibilityObject::nextSentenceEndPosition): (WebCore::AccessibilityObject::previousSentenceStartPosition): (WebCore::AccessibilityObject::nextParagraphEndPosition): (WebCore::AccessibilityObject::previousParagraphStartPosition): (WebCore::AccessibilityObject::visiblePositionForIndex): (WebCore::AccessibilityObject::accessibilityObjectForPosition): (WebCore::AccessibilityObject::lineForPosition): (WebCore::AccessibilityObject::plainTextRangeForVisiblePositionRange): (WebCore::AccessibilityObject::index): (WebCore::AccessibilityObject::doAXRangeForPosition): (WebCore::AccessibilityObject::doAXStyleRangeForIndex): (WebCore::AccessibilityObject::doAXLineForIndex):
  • page/AccessibilityObject.h:
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::visiblePositionForIndex): (WebCore::AccessibilityRenderObject::index): (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
  • page/AccessibilityRenderObject.h:
  • page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
8:04 PM Changeset in webkit [34643] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Justin Garcia.

  • prefer Leopard results when running on Snow Leopard.
  • Scripts/run-webkit-tests: Added a mapping of Snow Leopard to mac-leopard.
  • Scripts/webkitdirs.pm: Added isSnowLeopard().
6:34 PM Changeset in webkit [34642] by mrowe@apple.com
  • 6 edits in trunk

<rdar://problem/5775802> JavaScriptGlue, WebCore and WebKit should not force use of GCC 4.0.

Reviewed by Darin Adler.

  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebKit.xcodeproj/project.pbxproj:
6:32 PM Changeset in webkit [34641] by Darin Adler
  • 7 edits in trunk/WebCore

2008-06-17 Darin Adler <Darin Adler>

Reviewed by Sam.

  • eliminate the last RefCounted client that needs the "start at 0" behavior, NodeFilter
  • move handling of non-Attr arguments from the code generation script to the DOM itself (as with every other type of argument)
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter): Changed return type to PassRefPtr. Use create instead of new.
  • bindings/objc/DOM.mm: (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Use create instead of new. (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Use PassRefPtr and RefPtr for toNodeFilter and the local variable for NodeFilter arguments. Remove the TypeCanFailConversion mechanism: It's no longer needed for Attr, was not having any effect for VoidCallback, and was returning false for all other types.
  • dom/Element.cpp: (WebCore::Element::setAttributeNode): Added code to return TYPE_MISMATCH_ERR when the attr is 0 -- this matches what the autogenerated bindings did before. (WebCore::Element::setAttributeNodeNS): Ditto. (WebCore::Element::removeAttributeNode): Ditto.
  • dom/NodeFilter.h: Added create, made constructor private, and got rid of code to initialize the refcount to 0.
  • html/CanvasPattern.h: Made CachedResourceClient base class private in a more-explicit way.
6:14 PM Changeset in webkit [34640] by Adam Roben
  • 2 edits in trunk/WebCore

Fix <rdar://6016755> Assertion failure when WebView is child of message-only window

Reviewed by Ada Chan.

No test possible.

  • platform/win/WindowMessageBroadcaster.cpp: (WebCore::WindowMessageBroadcaster::addListener): Only subclass the window when we're adding our first listener. Removed an assertion that an old WNDPROC was returned -- this will be 0 in the case of a message-only window. Added an assertion to help catch cases where we try to subclass the window twice. (WebCore::WindowMessageBroadcaster::unsubclassWindow): Removed an assertion that is not correct in the message-only window case.
6:00 PM Changeset in webkit [34639] by adele@apple.com
  • 3 edits in trunk/WebCore

2008-06-17 Adele Peterson <​adele@apple.com>

Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)

  • loader/MediaDocument.cpp:
  • loader/MediaDocument.h:
5:45 PM Changeset in webkit [34638] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-06-17 Adele Peterson <​adele@apple.com>

Attempt to fix builds by wrapping new code in #if ENABLE(VIDEO)

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
5:07 PM Changeset in webkit [34637] by adele@apple.com
  • 12 edits
    2 adds in trunk/WebCore

2008-06-17 Adele Peterson <​adele@apple.com>

Reviewed by Brady.

Fix for <rdar://problem/5605768> Render full-page video/audio with <video>/<audio> instead of QuickTime plug-in

  • WebCore.xcodeproj/project.pbxproj: Added MediaDocument class.
  • GNUmakefile.am: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCoreSources.bkl: ditto.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument
  • dom/Document.h: (WebCore::Document::isMediaDocument): Added.
  • loader/MediaDocument.cpp: Added. (WebCore::MediaTokenizer::MediaTokenizer): (WebCore::MediaTokenizer::wantsRawData): (WebCore::MediaTokenizer::write): (WebCore::MediaTokenizer::createDocumentStructure): (WebCore::MediaTokenizer::writeRawData): (WebCore::MediaTokenizer::stopParsing): (WebCore::MediaTokenizer::finish): (WebCore::MediaTokenizer::isWaitingForScripts): (WebCore::MediaDocument::MediaDocument): (WebCore::MediaDocument::createTokenizer):
  • loader/MediaDocument.h: Added. (WebCore::MediaDocument::create): (WebCore::MediaDocument::isMediaDocument):
  • page/InspectorController.cpp: (WebCore::getResourceDocumentNode): Added MediaDocument case so it is handled the same as a PluginDocument or ImageDocument.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsType): Added.
  • platform/graphics/MediaPlayer.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility): Instead of checking the html element to decide if the media is audio, check the player. This means that if a video element actually only contains audio, then we will still avoid fading the controls in and out.
3:53 PM Changeset in webkit [34636] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

[GTK] WebKitWebHistoryItem needs properties

​https://bugs.webkit.org/show_bug.cgi?id=19558

Implement properties matching the existing accessors.

Reviewed by Alp.

3:33 PM Changeset in webkit [34635] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the file name and line number for call frames next to
the function name in the Call Stack pane.

​https://bugs.webkit.org/show_bug.cgi?id=19586

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Updated strings.
  • page/inspector/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): Create a subtitle based on the URL and line number.
3:33 PM Changeset in webkit [34634] by timothy@apple.com
  • 12 edits in trunk

Use accurate call frame title's based on the call frame type.
Added a type to DebuggerCallFrame so the under interface can
distinguish anonymous functions and program call frames.

JavaScriptCore:

2008-06-16 Timothy Hatcher <​timothy@apple.com>

Added a type to DebuggerCallFrame so the under interface can
distinguish anonymous functions and program call frames.

​https://bugs.webkit.org/show_bug.cgi?id=19585

Reviewed by Geoff Garen.

  • JavaScriptCore.exp: Export the DebuggerCallFrame::type symbol.
  • kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::type): Added.
  • kjs/DebuggerCallFrame.h:

WebCore:

2008-06-16 Timothy Hatcher <​timothy@apple.com>

Use accurate call frame title's based on the call frame type.

​https://bugs.webkit.org/show_bug.cgi?id=19585

Reviewed by Geoff Garen.

  • English.lproj/localizedStrings.js: Updated strings.
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): Removed the isValid() check since the evaluate() functiondoes the check already. (WebCore::JSJavaScriptCallFrame::thisObject): Removed the isValid() check, since thisObject() does the check and returns null if invalid. (WebCore::JSJavaScriptCallFrame::type): Return a string based on the enum value of the type. (WebCore::JSJavaScriptCallFrame::scopeChain): Removed the isValid() check, since scopeChain() does the check and returns null if invalid. So just null check scopeChain().
  • page/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::type): Return the DebuggerCallFrame::Type. Return DebuggerCallFrame::UnknownType if the call frame is invalid.
  • page/JavaScriptCallFrame.h:
  • page/JavaScriptCallFrame.idl: Add the type property.
  • page/inspector/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): Check the type of the call frame to create the correct title.
  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Use the "(program)" title for the file menu to match the call frames.
3:32 PM Changeset in webkit [34633] by timothy@apple.com
  • 3 edits in trunk/WebCore

Remember the expanded state of objects in the Scope Variables pane when stepping.
​https://bugs.webkit.org/show_bug.cgi?id=19584

Reviewed by Adam Roben.

  • page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Add an optional argument that is the treeElementConstructor to use when making TreeElements. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Use the treeElementConstructor to create TreeElements. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Use the treeElementConstructor to create TreeElements.
  • page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Create an _expandedProperties object on the callframe if one doesn't exist yet. Pass WebInspector.ScopeVariableTreeElement to the ObjectPropertiesSection as the TreeElement constructor we want to use. (WebInspector.ScopeVariableTreeElement): Added. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Expand if the propertyIdentifier is in the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.onexpand): Add the propertyIdentifier to the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.oncollapse): Remove the propertyIdentifier from the pane's _expandedProperties. (WebInspector.ScopeVariableTreeElement.prototype.get propertyIdentifier): Return an identifier that has the section title, subtile and propertyPath concatenated. (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath): Return a string that has the propertyNames up to the root ancestor concatenated with a period.
3:32 PM Changeset in webkit [34632] by timothy@apple.com
  • 2 edits in trunk/WebCore

Focus the mainPanelsElement in a timeout so it happens after the
initial focus, so it doesn't get reset to the first toolbar button.
This initial focus happens on Mac when the window is made key and
the WebHTMLView becomes the first responder.

​https://bugs.webkit.org/show_bug.cgi?id=19587

Reviewed by Adele Peterson.

  • page/inspector/inspector.js: (WebInspector.loaded): Focus the mainPanelsElement in a timeout.
3:32 PM Changeset in webkit [34631] by timothy@apple.com
  • 7 edits in trunk/WebCore

Use tabIndex in the Web Inspector for focusable areas.
​https://bugs.webkit.org/show_bug.cgi?id=19583

Reviewed by Adam Roben.

  • page/inspector/Console.js: (WebInspector.Console): No longer make the messagesElement focusable since the engine handles the case for us. The promptElement now handles the key events. (WebInspector.Console.prototype.show): Set the current focus element to the prompt element. (WebInspector.Console.prototype.hide): Set the current focus element to WebInspector.previousFocusElement. (WebInspector.Console.prototype._messagesFocused): Removed.
  • page/inspector/DataGrid.js: (WebInspector.DataGrid): Remove the focusable class.
  • page/inspector/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): Remove the focusable class. Set tabIndex to 0. The promptElement now handles the key events. (WebInspector.DatabaseQueryView.prototype._focused): Removed.
  • page/inspector/inspector.css: Updated selectors to use :focus instead of .focused and .blurred.
  • page/inspector/inspector.html: Removed focusable, focused and blurred classes and added tabindex attributes.
  • page/inspector/inspector.js: (WebInspector.get previousFocusElement): Added. Returns _previousFocusElement. (WebInspector.set currentFocusElement): Simplified. Stores the previous element in _previousFocusElement for clients that need it. Calls focus on the passed in element or blur on the previous element. (WebInspector.loaded): Removed the event listener for mousedown. Renamed changeFocus to focusChanged. (WebInspector.focusChanged): Renamed from changeFocus. Just sets the currentFocusElement to the event target. (WebInspector.startEditing): Changed to use tabIndex and blur events. Add a more robust check for restoring focus to the previous element when editing finishes that catches focused descendants.
3:32 PM Changeset in webkit [34630] by timothy@apple.com
  • 2 edits in trunk/WebCore

Removed redundant if statements and early returns from
AccessibilityRenderObject::ariaRoleAttribute.

Reviewed by Sam Wenig.

  • page/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::ariaRoleAttribute): Removed redundant if statements and early returns.
3:32 PM Changeset in webkit [34629] by timothy@apple.com
  • 7 edits in trunk/WebCore

Removed duplicate implementations of setTabIndex. They all matched
the HTMLElement::setTabIndex implementation.

Reviewed by Sam Wenig.

  • html/HTMLAnchorElement.cpp: Removed setTabIndex.
  • html/HTMLAreaElement.cpp: Ditto.
  • html/HTMLFormControlElement.cpp: Ditto.
  • html/HTMLFormControlElement.h: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLObjectElement.h: Ditto.
1:28 PM Changeset in webkit [34628] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Tim H.

Remove bogus ASSERT which tripped every time for those who use PAC files.

  • kjs/Parser.cpp: (KJS::Parser::parse):
12:16 PM Changeset in webkit [34627] by Darin Adler
  • 103 edits in trunk

WebCore:

2008-06-17 Darin Adler <Darin Adler>

Reviewed by Sam.

Change StyleBase and all classes derived from it.

  • bindings/js/JSRGBColor.cpp: (WebCore::JSRGBColor::getValueProperty):
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]):
  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::cssText):
  • css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::create):
  • css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::create): (WebCore::CSSCanvasValue::setName): (WebCore::CSSCanvasValue::CSSCanvasValue):
  • css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::create): (WebCore::CSSCharsetRule::encoding): (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::valueForNinePieceImage): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::currentColorOrValidColor): (WebCore::getBorderRadiusCornerValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSComputedStyleDeclaration.h: (WebCore::computedStyle):
  • css/CSSCursorImageValue.h: (WebCore::CSSCursorImageValue::create):
  • css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule):
  • css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::create): (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
  • css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::create): (WebCore::CSSFontFaceSrcValue::createLocal): (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue): (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
  • css/CSSGradientValue.h: (WebCore::CSSGradientColorStop::CSSGradientColorStop): (WebCore::CSSGradientValue::create): (WebCore::CSSGradientValue::CSSGradientValue):
  • css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::isImageGeneratorValue):
  • css/CSSImageValue.h: (WebCore::CSSImageValue::create):
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet):
  • css/CSSImportRule.h: (WebCore::CSSImportRule::create): (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
  • css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::create): (WebCore::CSSInheritedValue::CSSInheritedValue):
  • css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): (WebCore::CSSInitialValue::createImplicit): (WebCore::CSSInitialValue::CSSInitialValue):
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule):
  • css/CSSMediaRule.h: (WebCore::CSSMediaRule::create): (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty):
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::create):
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::create):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::addFillValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::addTransitionValue): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::parseGradientPoint): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::createMediaList): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createMediaRule): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::createFontFaceRule):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::createIdentifier): (WebCore::CSSPrimitiveValue::createColor): (WebCore::CSSPrimitiveValue::create): (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::isPrimitiveValue):
  • css/CSSQuirkPrimitiveValue.h: (WebCore::CSSQuirkPrimitiveValue::create):
  • css/CSSReflectValue.h: (WebCore::CSSReflectValue::create):
  • css/CSSRule.cpp: (WebCore::CSSRule::parentRule): (WebCore::CSSRule::setCssText):
  • css/CSSRule.h: (WebCore::CSSRule::CSSRule): (WebCore::CSSRule::isRule):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  • css/CSSStyleDeclaration.h:
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::type):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::parseUASheet): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::create): (WebCore::CSSStyleSheet::isCSSStyleSheet): (WebCore::CSSStyleSheet::type):
  • css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::create): (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue):
  • css/CSSTransformValue.cpp: (WebCore::CSSTransformValue::CSSTransformValue): (WebCore::CSSTransformValue::~CSSTransformValue): (WebCore::CSSTransformValue::addValue): (WebCore::CSSTransformValue::cssText):
  • css/CSSTransformValue.h: (WebCore::CSSTransformValue::create):
  • css/CSSUnicodeRangeValue.h: (WebCore::CSSUnicodeRangeValue::create): (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue):
  • css/CSSUnknownRule.h:
  • css/CSSValue.h: (WebCore::CSSValue::isImageGeneratorValue): (WebCore::CSSValue::isImageValue): (WebCore::CSSValue::isPrimitiveValue): (WebCore::CSSValue::isValueList): (WebCore::CSSValue::isSVGColor): (WebCore::CSSValue::isSVGPaint): (WebCore::CSSValue::CSSValue):
  • css/CSSValueList.h: (WebCore::CSSValueList::createCommaSeparated): (WebCore::CSSValueList::createSpaceSeparated): (WebCore::CSSValueList::isValueList):
  • css/FontFamilyValue.h: (WebCore::FontFamilyValue::create):
  • css/FontValue.h: (WebCore::FontValue::create): (WebCore::FontValue::FontValue): (WebCore::FontValue::isFontValue):
  • css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText):
  • css/MediaList.h: (WebCore::MediaList::create): (WebCore::MediaList::createAllowingDescriptionSyntax): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries):
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp):
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::glyphOrientationToCSSPrimitiveValue): (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • css/ShadowValue.h: (WebCore::ShadowValue::create):
  • css/StyleBase.h: (WebCore::StyleBase::isCSSStyleSheet): (WebCore::StyleBase::isFontFaceRule): (WebCore::StyleBase::isRule): (WebCore::StyleBase::isStyleRule): (WebCore::StyleBase::isStyleSheet): (WebCore::StyleBase::isXSLStyleSheet): (WebCore::StyleBase::StyleBase):
  • css/StyleList.cpp:
  • css/StyleList.h: (WebCore::StyleList::StyleList):
  • css/StyleSheet.h: (WebCore::StyleSheet::styleSheetChanged): (WebCore::StyleSheet::isStyleSheet):
  • dom/CSSMappedAttributeDeclaration.h: (WebCore::CSSMappedAttributeDeclaration::create): (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet):
  • dom/Document.cpp: (WebCore::Document::createCSSStyleDeclaration): (WebCore::Document::setCSSStyleSheet): (WebCore::Document::elementSheet): (WebCore::Document::mappedElementSheet): (WebCore::Document::recalcStyleSelector):
  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
  • dom/Position.cpp: (WebCore::Position::computedStyle):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
  • dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::createMappedDecl):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::hasTextDecorationProperty): (WebCore::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/Editor.cpp: (WebCore::Editor::selectionHasStyle): (WebCore::Editor::setBaseWritingDirection):
  • editing/EditorCommand.cpp: (WebCore::executeApplyStyle): (WebCore::executeToggleStyle): (WebCore::executeApplyParagraphStyle): (WebCore::stateStyle):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): (WebCore::appendStartMarkup):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::createLinkDecl):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle):
  • page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle):
  • page/Frame.h:
  • rendering/style/RenderStyle.cpp: (WebCore::StyleCachedImage::cssValue):
  • rendering/style/RenderStyle.h:
  • svg/SVGColor.h: (WebCore::SVGColor::create): (WebCore::SVGColor::isSVGColor):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::rebuildFontFace):
  • svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::srcValue):
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::srcValue):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint):
  • svg/SVGPaint.h: (WebCore::SVGPaint::create): (WebCore::SVGPaint::isSVGPaint):
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor):
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::XSLImportRule): (WebCore::XSLImportRule::setXSLStyleSheet):
  • xml/XSLImportRule.h: (WebCore::XSLImportRule::create): (WebCore::XSLImportRule::href): (WebCore::XSLImportRule::isImportRule):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::checkLoaded): (WebCore::XSLStyleSheet::loadChildSheet):
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createEmbedded):
  • xml/XSLTProcessor.cpp: (WebCore::xsltStylesheetPointer):

WebKit/mac:

2008-06-17 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new to create a CSSMutableStyleDeclaration.
11:45 AM Changeset in webkit [34626] by adele@apple.com
  • 15 edits
    18 adds in trunk

WebCore:

2008-06-17 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele.


Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18887
Added support for autofocus controls.

When authors specify the "autofocus" attribute on form controls these
acquire focus automatically as the document is rendered.

Tests: fast/forms/autofocus-attribute.html

fast/forms/autofocus-opera-001.html
fast/forms/autofocus-opera-002.html
fast/forms/autofocus-opera-003.html
fast/forms/autofocus-opera-004.html
fast/forms/autofocus-opera-005.html
fast/forms/autofocus-opera-006.html
fast/forms/autofocus-opera-007.html
fast/forms/autofocus-opera-008.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialize the flag to ignore autofocus.
  • dom/Document.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLButtonElement.idl:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::attach): Sets focus onto the appropriate "autofocus" control (WebCore::HTMLFormControlElement::autofocus): Autofocus attribute getter (WebCore::HTMLFormControlElement::setAutofocus): Autofocus attribute setter
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setUserEdited): Sets the "ignore autofocus" flag on document if the user edited the control.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-06-17 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=18887
Added support for autofocus controls.

Test cases "autofocus-opera*" have been imported from the Opera test suite
originally located at:
​http://tc.labs.opera.com/html/forms/input/common-attributes/autofocus/


  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
  • fast/forms/autofocus-attribute-expected.txt: Added.
  • fast/forms/autofocus-attribute.html: Added.
  • fast/forms/autofocus-opera-001-expected.txt: Added.
  • fast/forms/autofocus-opera-001.html: Added.
  • fast/forms/autofocus-opera-002-expected.txt: Added.
  • fast/forms/autofocus-opera-002.html: Added.
  • fast/forms/autofocus-opera-003-expected.txt: Added.
  • fast/forms/autofocus-opera-003.html: Added.
  • fast/forms/autofocus-opera-004-expected.txt: Added.
  • fast/forms/autofocus-opera-004.html: Added.
  • fast/forms/autofocus-opera-005-expected.txt: Added.
  • fast/forms/autofocus-opera-005.html: Added.
  • fast/forms/autofocus-opera-006-expected.txt: Added.
  • fast/forms/autofocus-opera-006.html: Added.
  • fast/forms/autofocus-opera-007-expected.txt: Added.
  • fast/forms/autofocus-opera-007.html: Added.
  • fast/forms/autofocus-opera-008-expected.txt: Added.
  • fast/forms/autofocus-opera-008.html: Added.
10:59 AM Changeset in webkit [34625] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-06-17 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt and Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=19190
[CAIRO] Canvas rendered as black

Make sure the frame alpha transparency flag is set to true unless
we're certain the image data is solid and can be blitted, since the
Cairo backend implements a fast-path for blittable BitmapImages.

Thanks to Dirk Schulze for helping to track down this problem.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::frameHasAlphaAtIndex):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage):
9:16 AM Changeset in webkit [34624] by kmccullough@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-06-17 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/5951534> JSProfiler: Don't profile console.profile()
or console.profileEnd()

  • profiler/Profile.cpp: (KJS::Profile::stopProfiling): Moved the creation of the (idle) node to the Profile (not ProfileNode). This makes sense since the Profile should be the one to modify the profile tree. Also each stopProfiling() does not need to check if it's the head node anymore. Also fixed an oddity where I was using willExecute to create the node. (KJS::Profile::removeProfileStart): Removes the call to console.profile that started this profile. (KJS::Profile::removeProfileEnd): Removes the call to console.profileEnd that ended this profile.
  • profiler/Profile.h:
  • profiler/ProfileNode.cpp: Moved the creation of the (idle) node to the Profile object. (KJS::ProfileNode::stopProfiling):
  • profiler/ProfileNode.h: Added some helper functions and whitespace to facilitate readability and the removal of profile() and profileEnd() from the Profile tree. (KJS::CallIdentifier::operator const char* ): (KJS::ProfileNode::firstChild): (KJS::ProfileNode::lastChild): (KJS::ProfileNode::removeChild): (KJS::ProfileNode::toString):
9:07 AM Changeset in webkit [34623] by mitz@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Typo fix.

7:59 AM Changeset in webkit [34622] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-06-17 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber stamped by Adam Robben.

Include JSGlobalObject.h to fix the build.

  • kjs/ScopeChain.cpp:
7:45 AM Changeset in webkit [34621] by Simon Hausmann
  • 5 edits in trunk

2008-06-17 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix the Qt port by adding ExecState when necessary.

2:33 AM Changeset in webkit [34620] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Reduce code duplication in emitReadModifyAssignment().

  • kjs/nodes.cpp: (KJS::emitReadModifyAssignment):
1:45 AM Changeset in webkit [34619] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Sort includes alphabetically.

  • kjs/nodes.cpp:
1:29 AM Changeset in webkit [34618] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-06-17 David Hyatt <​hyatt@apple.com>

Fix for slow performance on CSS selector tests at:

​http://jpsykes.com/153/more-css-performance-testing-pt-2

Fix <style> element processing so that we don't reparse the entire stylesheet as chunks come in from
the network (since this is O(n2)). Wait for the parser to deliver all of the data before we
process the sheet for the first time.

Reviewed by olliej

  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishParsingChildren): (WebCore::HTMLStyleElement::childrenChanged):

Jun 16, 2008:

11:22 PM Changeset in webkit [34617] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-16 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19596: LEAK: Gmail leaks SegmentedVector<RegisterID>
<​https://bugs.webkit.org/show_bug.cgi?id=19596>

When growing SegmentedVector, we start adding segments at the position
of the last segment, overwriting it. The destructor frees allocated
segments starting at the segment of index 1, because the segment of
index 0 is assumed to be the initial inline segment. This causes a leak
of the segment that is referenced by index 0. Modifying grow() so that
it starts adding segments at the position after the last segment fixes
the leak.

Since the initial segment is a special case in the lookup code, this
bug never manifested itself via incorrect results.

  • VM/SegmentedVector.h: (KJS::SegmentedVector::grow):
10:59 PM Changeset in webkit [34616] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-06-16 Maciej Stachowiak <​mjs@apple.com>

A handy reference image.

  • blog-files/acid3-timing.png: Added.
10:31 PM Changeset in webkit [34615] by mjs@apple.com
  • 10 edits
    2 deletes in trunk

JavaScriptCore:

2008-06-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey.


  • removed nearly unused types.h and LocalStorageEntry.h headers
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/ExecState.h:
  • kjs/LocalStorageEntry.h: Removed.
  • kjs/RegExpObject.cpp:
  • kjs/error_object.cpp:
  • kjs/grammar.y:
  • kjs/nodes.cpp:
  • kjs/types.h: Removed.

JavaScriptGlue:

2008-06-16 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey.

  • removed nearly unused types.h and LocalStorageEntry.h headers
  • JSUtils.h:
10:07 PM Changeset in webkit [34614] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Justin Garcia.

  • fix <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas

Test: editing/selection/after-line-break.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Changed to not include the position after a line break in its line box, because that position is actually on the next line.

LayoutTests:

Reviewed by Justin Garcia.

  • test and updated results for <rdar://problem/5973313> REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas
  • editing/selection/after-line-break-expected.txt: Added.
  • editing/selection/after-line-break.html: Added.
  • platform/mac/editing/selection/move-left-right-expected.txt: More bogus warnings.
9:49 PM Changeset in webkit [34613] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Trying to fix Windows build.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::variableNames): (WebScriptCallFrame::valueForVariable): Give ExecState to functions that now take it.
8:49 PM Changeset in webkit [34612] by alp@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-06-16 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Geoff.

Change c++ to c in minidom and testapi emacs mode line comments.

  • API/Node.h:
  • API/NodeList.c:
  • API/NodeList.h:
  • API/testapi.c:
8:45 PM Changeset in webkit [34611] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Trying to fix Windows build.

  • kjs/PropertyNameArray.h:
  • kjs/identifier.cpp: Include ExecState.h
7:49 PM Changeset in webkit [34610] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-06-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Slight cleanup to the SymbolTableEntry class.


Renamed isEmpty to isNull, since we usually use "empty" to mean "holds
the valid, empty value", and "null" to mean "holds no value".


Changed an "== 0" to a "!", to match our style guidelines.


Added some ASSERTs to verify the (possibly questionable) assumption that
all register indexes will have their high two bits set. Also clarified a
comment to make that assumption clear.

6:44 PM Changeset in webkit [34609] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Initialize functionQueueMutex in a safe manner.

  • wtf/MainThread.cpp: (WTF::functionQueueMutex): Made it an AtomicallyInitializedStatic.

(WTF::dispatchFunctionsFromMainThread):
(WTF::setMainThreadCallbacksPaused):
Assert that the current thread is main, meaning that the callbacksPaused static can be
accessed.

6:00 PM Changeset in webkit [34608] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings

Reviewed by Darin Adler.

_pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h. They don't belong
in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):

  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
4:28 PM Changeset in webkit [34607] by ap@webkit.org
  • 76 edits in trunk

Reviewed by Geoff Garen.

Make Identifier construction use an explicitly passed IdentifierTable.

No change on SunSpider total.

2:21 PM Changeset in webkit [34606] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore

2008-06-16 Thiago Macieira <​tjmaciei@trolltech.com>

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19577

Fix compilation in C++ environments where C99 headers are not present

The stdbool.h header is a C99 feature, defining the "_Bool" type as well as the
"true" and "false" constants. But it's completely unnecessary in C++ as the
language already defines the "bool" type and its two values.

  • API/JSBase.h:
  • API/JSContextRef.h:
  • API/JSObjectRef.h:
  • API/JSStringRef.h:
  • API/JSValueRef.h:
1:57 PM Changeset in webkit [34605] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-16 Kevin McCullough <​kmccullough@apple.com>

Reviewed by John.

<rdar://problem/6012509> JSProfiler: %s are incorrect if you exclude a
top level node like (idle)

  • profiler/Profile.cpp: (KJS::Profile::focus): (KJS::Profile::exclude): Subtract the selfTime from the totalTime of the head since its self time will only be non-zero when one of its children were excluded. Since the head's totalTime is used to calculate %s when its totalTime is the same as the sum of all its visible childrens' times their %s will sum to 100%.
1:08 PM Changeset in webkit [34604] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-06-16 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Dan Bernstein.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): remove an extra context->save() from the shadow painting code.
12:57 PM Changeset in webkit [34603] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-16 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the profiler.

  • profiler/Profile.cpp: (KJS::Profile::willExecute):
12:52 PM Changeset in webkit [34602] by kmccullough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-16 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.

  • Remove the last of the uses of recursion in the profiler.
  • JavaScriptCore.exp: Export the new function's signature.
  • profiler/Profile.cpp: (KJS::calculateVisibleTotalTime): Added a new static method for recalculating the visibleTotalTime of methods after focus has changed which are visible. (KJS::stopProfiling): (KJS::Profile::focus): Implemented focus without recursion.
  • profiler/Profile.h: Moved implementation into the definition file.
  • profiler/ProfileNode.cpp: (KJS::ProfileNode::traverseNextNodePreOrder): Added an argument for whether or not to process the children nodes, this allows focus to skip sub trees which have been set as not visible. (KJS::ProfileNode::calculateVisibleTotalTime): This function set's a node's total visible time to the sum of its self time and its children's total times. (KJS::ProfileNode::focus): Implemented focus without recursion.
  • profiler/ProfileNode.h: (KJS::CallIdentifier::operator!= ): (KJS::ProfileNode::setActualTotalTime): Expanded setting the total time so that focus could modify only the visible total time. (KJS::ProfileNode::setVisibleTotalTime):
11:16 AM Changeset in webkit [34601] by sfalken@apple.com
  • 1 copy in tags/Safari-5525.19

New tag.

9:24 AM Changeset in webkit [34600] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • WebScriptCallFrame.cpp: Fixed a header name.
6:48 AM Changeset in webkit [34599] by christian@webkit.org
  • 11 edits in trunk/JavaScriptCore

JavaScriptCore headers use C++ style comments

​https://bugs.webkit.org/show_bug.cgi?id=19552

Replace all C++ style comments with C style multiline
comments and remove all "mode" lines.

Reviewed by Sam.

6:39 AM Changeset in webkit [34598] by christian@webkit.org
  • 12 edits in trunk/JavaScriptCore

(JavaScriptCore) minidom uses C++ style comments

​https://bugs.webkit.org/show_bug.cgi?id=19557

Use only C style comments in minidom sources

Reviewed by Sam.

6:29 AM Changeset in webkit [34597] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-06-16 Adriaan de Groot <​groot@kde.org>

Reviewed by Simon.

Fix compilation on Solaris

On some systems, munmap takes a char* instead of a void* (contrary to POSIX and
Single Unix Specification). Since you can always convert from char* to void*
but not vice-versa, do the casting to char*.

5:02 AM Changeset in webkit [34596] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-06-16 Adriaan de Groot <​groot@kde.org>

Reviewed by Simon.

Fix compilation on Sun Studio 12

make_pair is a function template with two template arguments. This is to force
it to have the correct type according to the pair<> structure.

4:58 AM Changeset in webkit [34595] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

​https://bugs.webkit.org/show_bug.cgi?id=19462

Fill the background of scrollbars to the window color before
letting the QStyle paint its primitive elements.

3:14 AM Changeset in webkit [34594] by Simon Hausmann
  • 2 edits in trunk

2008-06-16 Simon Hausmann <Simon Hausmann>

Fix the Qt build. testkjs.pro is now called jsc.pro.

1:19 AM Changeset in webkit [34593] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-16 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Make a UnaryOpNode class to reduce boilerplate code for UnaryPlusNode,
NegateNode, BitwiseNotNode, and LogicalNotNode.

  • VM/CodeGenerator.h: (KJS::CodeGenerator::emitToJSNumber):
  • kjs/nodes.cpp: (KJS::UnaryOpNode::emitCode):
  • kjs/nodes.h: (KJS::UnaryOpNode::UnaryOpNode): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::NegateNode::precedence): (KJS::BitwiseNotNode::): (KJS::BitwiseNotNode::precedence): (KJS::LogicalNotNode::): (KJS::LogicalNotNode::precedence):
1:09 AM Changeset in webkit [34592] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-16 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.