Context Navigation

← Previous Period
Next Period →

Timeline

Jun 19, 2008:

10:43 PM Changeset in webkit [34685] by mitz@apple.com

3 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

two more updated results for the last patch

platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
platform/mac/fast/invalid/020-expected.txt:

8:30 PM Changeset in webkit [34684] by ap@webkit.org

15 edits in trunk

Reviewed by Geoff.

7:53 PM Changeset in webkit [34683] by mitz@apple.com

9 edits
3 moves
9 adds
9 deletes in trunk

WebCore:

Reviewed by John Sullivan.

fix a bug where anonymous tables were inserted in the wrong place

Tests: tables/mozilla/bugs/bug2479-2.html

tables/mozilla/bugs/bug278266.html
tables/mozilla/bugs/bug8411.xml

rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Changed to create an anonymous table and insert it before beforeChild unless the insertion point is right after an existing anonymous table, in which case the existing table is used.

LayoutTests:

Reviewed by John Sullivan.

updated tests and results after fixing a bug where anonymous tables were inserted in the wrong place

fast/forms/form-hides-table.html: Wrapped every case in a block in order to prevent cross-talk.
platform/mac/fast/forms/form-hides-table-expected.checksum:
platform/mac/fast/forms/form-hides-table-expected.png:
platform/mac/fast/forms/form-hides-table-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
platform/mac/tables/mozilla/bugs/bug2479-2-expected.png: Added.
platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/mac/tables/mozilla/bugs/bug278266-expected.checksum: Added.
platform/mac/tables/mozilla/bugs/bug278266-expected.png: Added.
platform/mac/tables/mozilla/bugs/bug278266-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug8411-expected.checksum: Added.
platform/mac/tables/mozilla/bugs/bug8411-expected.png: Added.
platform/mac/tables/mozilla/bugs/bug8411-expected.txt: Added.
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.checksum: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.png: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug278266-expected.txt: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.checksum: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.png: Removed.
platform/mac/tables/mozilla_expected_failures/bugs/bug8411-expected.txt: Removed.
platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
tables/mozilla/bugs/bug2479-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2.html.
tables/mozilla/bugs/bug278266.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug278266.html.
tables/mozilla/bugs/bug8411.xml: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug8411.xml.
tables/mozilla_expected_failures/bugs/bug2479-2.html: Removed.
tables/mozilla_expected_failures/bugs/bug278266.html: Removed.
tables/mozilla_expected_failures/bugs/bug8411.xml: Removed.

6:19 PM Changeset in webkit [34682] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

2008-06-19 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<https://bugs.webkit.org/show_bug.cgi?id=16049>
execCommand('backColor') fails on collapsed selections

editing/EditorCommand.cpp: (WebCore::CommandEntry::): Enable BackColor for caret selections, and disable ForeColor in plaintext-only regions.

LayoutTests:

2008-06-19 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver.

<https://bugs.webkit.org/show_bug.cgi?id=16049>
execCommand('backColor') fails on collapsed selections

editing/execCommand/16049-expected.txt: Added.
editing/execCommand/16049.html: Added.

5:24 PM Changeset in webkit [34681] by justin.garcia@apple.com

21 edits
8 adds in trunk

WebCore:

2008-06-19 Justin Garcia <justin.garcia@apple.com>

Reviewed by John.

<https://bugs.webkit.org/show_bug.cgi?id=19653>
Typing style lost when creating list from, indenting or outdenting an empty paragraph

There were two problems. First, moveParagraphs didn't preserve the style of empty paragraphs.
Second, indent, outdent and list creation returned false from preservesTypingStyle.
The second problem couldn't be fixed by just adding preservesTypingStyle() { return true; }
to those commands, though, because of other bugs.

Cleaned up the implementation of typing style enough to remove FIXMEs for:

<rdar://problem/3769899> Implementation of typing style needs improvement

which has actually been closed for some time now anyway.

dom/Document.cpp: Removed an unused header.
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Preserve the style of an empty paragraph, too.
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Removed FIXME. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Removed FIXME. If there is a typing style to apply after a delete, apply it to any line break that acts as a paragraph placeholder, not only one that was inserted by deletion. This fixes a bug where deleting <div><b>Bold</b><br></div>, changing the selection and then coming back and typing wouldn't produce bold text. Don't set the EditCommand's typingStyle, it has been removed (more on that later). (WebCore::DeleteSelectionCommand::doApply): We don't need to pass calculateTypingStyleAfterDelete the inserted placeholder because it will find it. (WebCore::DeleteSelectionCommand::preservesTypingStyle): Normally deletion doesn't preserve the typing style that was present before it. For example, type a character, Bold, then delete the character and start typing. The Bold typing style shouldn't stick around. We got this right before purely by chance. Deletion should preserve a typing style that *it* sets, however.
editing/DeleteSelectionCommand.h: No longer need to pass calculateTypingStyleAfterDelete the inserted placeholder.
editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clearing or not clearing a removed anchor should not be determined by whether or not a command preservesTypingStyle(). For example, the deletion that removed an anchor (and stored it), may not preserve the typing style, but that doesn't mean that it should then go and clear the removed anchor. All high level commands, and all commands that a TypingCommand spawns, except for text insertions, which should restore a removed anchor, should clear it. There is no longer a typing style on EditCommand, removed code that cleared it. Code that clears the *actual* typing style is now in Editor::appliedEditing, just like before. There is no longer a typing style on EditCommand, removed code to set one. (WebCore::EditCommand::styleAtPosition): Removed FIXME.
editing/EditCommand.h: Removed code assosiated with m_typingStyle. Made preservesTypingStyle() public, so that we can call it from Editor::appliedEditing().
editing/Editor.cpp: (WebCore::Editor::appliedEditing): Removed code to preserve the removedAnchor during the call to setSelection, because we no longer request to clear the typing style with that call. Also removed the FIXME about this. Before, a command would set the Frame's typing style by setting its own typingStyle, and then letting code here, in appliedEditing pick that up and set it on the Frame. Now, the command itself sets the Frame's typing style. Deletion is the only command that does this right now.
editing/IndentOutdentCommand.h: (WebCore::IndentOutdentCommand::preservesTypingStyle): Added, returns true.
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Removed FIXME.
editing/InsertListCommand.h: (WebCore::InsertListCommand::preservesTypingStyle): Added.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Removed FIXME.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Removed FIXME.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed FIXME and also added one about clearing the typing style here. It seems like it's something that could wait until after the command has been performed, since there is no code between this point and the end of the operation that queries or uses the typing style.

LayoutTests:

2008-06-19 Justin Garcia <justin.garcia@apple.com>

Reviewed by John.

https://bugs.webkit.org/show_bug.cgi?id=19653
Typing style lost when creating list from, indenting or outdenting an empty paragraph

These demonstrate fixes:

editing/execCommand/19653-1-expected.txt: Added.
editing/execCommand/19653-1.html: Added.
editing/execCommand/19653-2-expected.txt: Added.
editing/execCommand/19653-2.html: Added.
editing/execCommand/19653-3-expected.txt: Added.
editing/execCommand/19653-3.html: Added.
editing/execCommand/19653-4-expected.txt: Added.
editing/execCommand/19653-4.html: Added. Changed to an equivalent but more bloated DOM because of a pre-existing bug in ApplyStyleCommand:
platform/mac/editing/deleting/delete-br-011-expected.txt: Fixed a bug where the typing style wasn't applied to the placeholder in an empty paragraph, so typing would create text with the right style, but if you were to change the selection and then come back and start typing, the style would be wrong. The size of the caret was also wrong as a result:
platform/mac/editing/deleting/delete-br-012-expected.txt:
platform/mac/editing/deleting/delete-br-012-expected.png:
platform/mac/editing/deleting/delete-br-012-expected.checksum:

5:09 PM Changeset in webkit [34680] by mitz@apple.com

2 edits in trunk/WebCore

2008-06-19 Dan Bernstein <mitz@apple.com>

Reviewed by Alexey Proskuryakov.

fix crash in CSSStyleDeclaration::copyPropertiesInSet()

Covered by many editing tests

css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet): Re-ordered to avoid null pointer deref.

5:06 PM Changeset in webkit [34679] by hyatt@apple.com

3 edits in trunk/WebCore

2008-06-19 David Hyatt <hyatt@apple.com>

Fix out of bounds bug in CSSVariablesDeclaration's item() method.

Reviewed by Sam, Darin

css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::item):
css/CSSVariablesDeclaration.h:

4:42 PM Changeset in webkit [34678] by sullivan@apple.com

2 edits in trunk/WebCore

2008-06-19 John Sullivan <sullivan@apple.com>

Reviewed by Darin

Tweak to previous checkin

page/FrameView.cpp: (WebCore::FrameView::performPostLayoutTasks): clear m_firstLayoutCallbackPending before performing callback, to avoid recursion

4:20 PM Changeset in webkit [34677] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-19 Alp Toker <alp@nuanti.com>

GTK+/autotools build fix. JSGlobalObject.cpp in now in
AllInOneFile.cpp and shouldn't be built separately.

GNUmakefile.am:

4:15 PM Changeset in webkit [34676] by sullivan@apple.com

2 edits in trunk/WebCore

2008-06-19 John Sullivan <sullivan@apple.com>

Reviewed by Darin

fixed <rdar://problem/6021353> Assertion failure (!root->needsLayout()) after certain steps

The didFirstLayout callback was called in a place where trouble would ensue if the client
did any work that would cause the layout to be dirtied. Fixed by delaying the callback
until performPostLayoutTasks.

page/FrameView.cpp: new m_firstLayoutCallbackPending instance member variable in FrameViewPrivate (WebCore::FrameViewPrivate::reset): set m_firstLayoutCallbackPending to false (WebCore::FrameView::layout): set m_firstLayoutCallbackPending instead of a local variable; don't do didFirstLayout callback here (WebCore::FrameView::performPostLayoutTasks): if m_firstLayoutCallbackPending is set, do didFirstLayout callback here, then clear m_firstLayoutCallbackPending

3:39 PM Changeset in webkit [34675] by hyatt@apple.com

5 edits in trunk/WebCore

2008-06-19 David Hyatt <hyatt@apple.com>

Implement some cleanup of CSS variables based off Darin's review comments.

Reviewed by darin

css/CSSParser.cpp: (WebCore::CSSParser::parseVariable): (WebCore::CSSParser::checkForVariables): (WebCore::CSSParser::addUnresolvedProperty):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
css/CSSVariableDependentValue.h:
css/CSSVariablesRule.cpp: (WebCore::CSSVariablesRule::CSSVariablesRule):

3:34 PM Changeset in webkit [34674] by sullivan@apple.com

2 edits in trunk/WebCore

2008-06-19 John Sullivan <sullivan@apple.com>

Rubber-stamped by Dan

Prepended all FrameViewPrivate instance member variables with "m_" (in preparation
for adding a new one in a future patch)

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::didFirstLayout): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint): (WebCore::FrameView::layoutRoot): (WebCore::FrameView::layout): (WebCore::FrameView::scrollTo): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout): (WebCore::FrameView::unscheduleRelayout): (WebCore::FrameView::isTransparent): (WebCore::FrameView::setTransparent): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus):

3:23 PM Changeset in webkit [34673] by ap@webkit.org

4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Get rid of some threadInstance calls.

kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
kjs/Parser.cpp: (KJS::Parser::parse):
kjs/Shell.cpp: (jscmain):

3:13 PM Changeset in webkit [34672] by ap@webkit.org

2 edits in trunk/WebKit/win

Windows build fix.

WebJavaScriptCollector.cpp: Added a missing include.

3:08 PM Changeset in webkit [34671] by hyatt@apple.com

1 edit in trunk/WebCore/WebCoreSources.bkl

Add CSS variables files for wx port.

3:06 PM Changeset in webkit [34670] by hyatt@apple.com

1 edit in trunk/WebCore/GNUmakefile.am

Add CSS variables files to .am makefile.

3:05 PM Changeset in webkit [34669] by hyatt@apple.com

1 edit in trunk/WebCore/WebCore.pro

Add CSS variables files to .pro makefile.

2:59 PM Changeset in webkit [34668] by hyatt@apple.com

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Add CSS Variables files to visual studio project.

2:53 PM Changeset in webkit [34667] by hyatt@apple.com

37 adds in trunk/LayoutTests/platform/mac/fast/css/variables

Add layout test results for new variables test cases.

2:49 PM Changeset in webkit [34666] by hyatt@apple.com

23 edits
27 adds in trunk

WebCore:

2008-06-19 David Hyatt <hyatt@apple.com>

Add initial support for CSS variables. Non-dynamic cases should (hopefully) all work. Things will get
confused if you use the CSS OM to remove variables/inject variables, etc. In addition no DOM APIs are
exposed yet for the new variable interfaces.

Reviewed by Beth

Added many tests to fast/css/variables/

WebCore.xcodeproj/project.pbxproj:
css/CSSFunctionValue.cpp: Added. (WebCore::CSSFunctionValue::CSSFunctionValue): (WebCore::CSSFunctionValue::~CSSFunctionValue): (WebCore::CSSFunctionValue::cssText): (WebCore::CSSFunctionValue::parserValue):
css/CSSFunctionValue.h: Added. (WebCore::CSSFunctionValue::create):
css/CSSGrammar.y:
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::copy):
css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::create): (WebCore::CSSMutableStyleDeclaration::hasVariableDependentValue):
css/CSSParser.cpp: (WebCore::equal): (WebCore::equalIgnoringCase): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParserString::lower): (WebCore::CSSParser::document): (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransitionDuration): (WebCore::CSSParser::parseTransitionRepeatCount): (WebCore::CSSParser::parseTimingFunctionValue): (WebCore::CSSParser::parseTransitionTimingFunction): (WebCore::CSSParser::parseTransitionProperty): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseFontFaceUnicodeRange): (WebCore::CSSParser::parseColorParameters): (WebCore::CSSParser::parseHSLParameters): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseColorFromValue): (WebCore::ShadowParseContext::commitLength): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::parseGradientPoint): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::lex): (WebCore::CSSParser::text): (WebCore::CSSParser::createFloatingValueList): (WebCore::CSSParser::sinkFloatingValueList): (WebCore::CSSParser::createFloatingFunction): (WebCore::CSSParser::sinkFloatingFunction): (WebCore::CSSParser::sinkFloatingValue): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::createCharsetRule): (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::addVariable): (WebCore::CSSParser::clearVariables): (WebCore::CSSParser::parseVariable): (WebCore::CSSParser::parsePropertyWithResolvedVariables): (WebCore::CSSParser::checkForVariables): (WebCore::CSSParser::addUnresolvedProperty): (WebCore::cssPropertyID): (WebCore::cssValueKeywordID):
css/CSSParser.h:
css/CSSParserValues.cpp: Added. (WebCore::CSSParserValueList::~CSSParserValueList): (WebCore::CSSParserValueList::addValue): (WebCore::CSSParserValueList::deleteValueAt): (WebCore::CSSParserValue::createCSSValue):
css/CSSParserValues.h: Added. (WebCore::CSSParserString::operator String): (WebCore::CSSParserString::operator AtomicString): (WebCore::CSSParserValue::): (WebCore::CSSParserValueList::CSSParserValueList): (WebCore::CSSParserValueList::size): (WebCore::CSSParserValueList::current): (WebCore::CSSParserValueList::next): (WebCore::CSSParserValueList::valueAt): (WebCore::CSSParserValueList::clear): (WebCore::CSSParserValueList::containsVariables): (WebCore::CSSParserFunction::~CSSParserFunction):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::setPrimitiveType):
css/CSSRule.h: (WebCore::CSSRule::):
css/CSSRule.idl:
css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::addVariables): (WebCore::CSSStyleSelector::resolveVariableDependentValue): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyDeclarations):
css/CSSStyleSelector.h:
css/CSSValue.h: (WebCore::CSSValue::isVariableDependentValue): (WebCore::CSSValue::parserValue):
css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): (WebCore::CSSValueList::createParserValueList):
css/CSSValueList.h: (WebCore::CSSValueList::createFromParserValueList):
css/CSSVariableDependentValue.cpp: Added. (WebCore::CSSVariableDependentValue::CSSVariableDependentValue): (WebCore::CSSVariableDependentValue::~CSSVariableDependentValue): (WebCore::CSSVariableDependentValue::cssText):
css/CSSVariableDependentValue.h: Added. (WebCore::CSSVariableDependentValue::create): (WebCore::CSSVariableDependentValue::isVariableDependentValue): (WebCore::CSSVariableDependentValue::valueList):
css/CSSVariablesDeclaration.cpp: Added. (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::~CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariable): (WebCore::CSSVariablesDeclaration::length): (WebCore::CSSVariablesDeclaration::item): (WebCore::CSSVariablesDeclaration::parentRule): (WebCore::CSSVariablesDeclaration::cssText):
css/CSSVariablesDeclaration.h: Added. (WebCore::CSSVariablesDeclaration::create):
css/CSSVariablesRule.cpp: Added. (WebCore::CSSVariablesRule::CSSVariablesRule): (WebCore::CSSVariablesRule::~CSSVariablesRule): (WebCore::CSSVariablesRule::cssText):
css/CSSVariablesRule.h: Added. (WebCore::CSSVariablesRule::media): (WebCore::CSSVariablesRule::variables): (WebCore::CSSVariablesRule::type): (WebCore::CSSVariablesRule::isVariablesRule): (WebCore::CSSVariablesRule::setDeclaration):
css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp):
css/MediaQueryExp.h:
css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray):
css/StyleBase.h: (WebCore::StyleBase::isVariablesRule):
css/tokenizer.flex:

LayoutTests:

2008-06-19 David Hyatt <hyatt@apple.com>

Add layout tests for CSS variables.

Reviewed by Beth

fast/css/variables: Added.
fast/css/variables/colors-test.html: Added.
fast/css/variables/font-test.html: Added.
fast/css/variables/image-test.html: Added.
fast/css/variables/import-test.html: Added.
fast/css/variables/invalid-variable-test.html: Added.
fast/css/variables/margin-test.html: Added.
fast/css/variables/misplaced-import-test.html: Added.
fast/css/variables/misplaced-variables-test.html: Added.
fast/css/variables/override-test.html: Added.
fast/css/variables/print-test.html: Added.
fast/css/variables/resources: Added.
fast/css/variables/resources/bad.css: Added.
fast/css/variables/resources/good.css: Added.
fast/css/variables/resources/listmark.gif: Added.
fast/css/variables/shorthand-test.html: Added.
fast/css/variables/single-term-test.html: Added.

2:28 PM Changeset in webkit [34665] by jchaffraix@webkit.org

3 edits
1 move in trunk/WebCore

WebCore:

2008-06-19 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin.

Bug 19529 : Empty clients need to be refactored
https://bugs.webkit.org/show_bug.cgi?id=19529

SVGImageEmptyClients' refactoring in order to be able to use them for other elements.

Trimmed empty spaces that were pointed out by git.

WebCore.xcodeproj/project.pbxproj:
loader/EmptyClients.h: Copied from WebCore/svg/graphics/SVGImageEmptyClients.h.

(WebCore::EmptyChromeClient::~EmptyChromeClient):
(WebCore::EmptyFrameLoaderClient::~EmptyFrameLoaderClient):
(WebCore::EmptyEditorClient::~EmptyEditorClient):
(WebCore::EmptyEditorClient::smartInsertDeleteEnabled):
(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
(WebCore::EmptyDragClient::~EmptyDragClient):
(WebCore::EmptyDragClient::createDragImageForLink):
(WebCore::EmptyInspectorClient::~EmptyInspectorClient):
Renamed SVGImageEmpty*Client classes to Empty*Client.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
svg/graphics/SVGImageEmptyClients.h: Removed.

2:13 PM Changeset in webkit [34664] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Fix an assertion failure at startup.

kjs/JSObject.h: (KJS::JSObject::JSObject): Allow jsNull prototype in an assertion (I had it fixed in a wrong copy of the file, so I wasn't getting the failure).

1:42 PM Changeset in webkit [34663] by mitz@apple.com

6 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()

Test: fast/css/font-face-multiple-families.html

Made changes to reflect the fact that the relationship between
CSSFontFace and CSSSegmentedFontFace is in fact many-to-many.

css/CSSFontFace.cpp: (WebCore::CSSFontFace::addedToSegmentedFontFace): Added. (WebCore::CSSFontFace::removedFromSegmentedFontFace): Added. (WebCore::CSSFontFace::fontLoaded): Changed to notify all segmented font faces that include this font face. (WebCore::CSSFontFace::getFontData): Updated to get the font selector from one of the segmented font faces.
css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace):
css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Fixed the direct cause of the crash, namely releasing the font face when adding it to the first family that uses it, making it impossible to add it to the second and onwards families.
css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): Added code to call CSSFontFace::removedFromSegmentedFontFace(). (WebCore::CSSSegmentedFontFace::overlayRange): Added code to call CSSFontFace::{addedTo, removedFrom}SegmentedFontFace().

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/6008098> REGRESSION: Crash at FontFallbackList::fontDataAt()

fast/css/font-face-multiple-families-expected.txt: Added.
fast/css/font-face-multiple-families.html: Added.

11:32 AM Changeset in webkit [34662] by ap@webkit.org

2 edits in trunk/WebCore

Qt build fix.

bridge/qt/qt_runtime.h: Include completion.h.

11:18 AM Changeset in webkit [34661] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Build fix.

kjs/collector.cpp: (KJS::Heap::Heap): (KJS::allocateBlock):
kjs/collector.h: No, #if PLATFORM(UNIX) was not right. I've just moved the unsafe initialization back for now, as the platforms that use that code path do not use multiple threads yet.

11:03 AM Changeset in webkit [34660] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Windows and Qt build fixes.

kjs/collector.h:
kjs/collector.cpp: (KJS::Heap::Heap): Wrapped m_pagesize in #if PLATFORM(UNIX), which should better match the sequence of #elifs in allocateBlock(). Changed MIN_ARRAY_SIZE to be explicitly size_t, as this type is different on different platforms.

10:29 AM Changeset in webkit [34659] by ap@webkit.org

153 edits
2 adds in trunk

Reviewed by Darin.

Prepare JavaScript heap for being per-thread.

10:24 AM Changeset in webkit [34658] by timothy@apple.com

2 edits in trunk/WebCore

Update the JavaScript syntax highlight colors to match Xcode.
This matches the other Xcode colors we are using for HTML.

Reviewed by Dan Bernstein.

page/inspector/SourceFrame.js:

10:01 AM Changeset in webkit [34657] by timothy@apple.com

4 edits in trunk/WebCore

Added JavaScript syntax highlighting to the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=14360

Reviewed by Tim Hatcher and Adam Roben.

page/inspector/ScriptView.js: Added a call to syntaxHighlightJavascript.
page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Added. Modifies a line content element. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Added. Syntax highlights the entire script.
page/inspector/SourceView.js: Added a call to syntaxHighlightJavascript.

2:57 AM Changeset in webkit [34656] by oliver@apple.com

61 edits
1 copy in trunk/WebCore

Starting to clean up the SVG Filter code. Mostly adding 'create' wrapper
functions and changing raw pointer fields to RefPtrs.

Patch by Alex Mathews

Reviewed by Oliver

Jun 18, 2008:

8:41 PM Changeset in webkit [34655] by adele@apple.com

2 edits in trunk/WebCore

2008-06-18 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix assertion in fast/dom/ImageDocument-image-deletion.html caused by new media document creation.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Create the media document after we're done processing pdfs and images.

8:05 PM Changeset in webkit [34654] by mitz@apple.com

3 edits
1 copy
3 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix https://bugs.webkit.org/show_bug.cgi?id=19598 Crash in WebCore::RenderBlock::determineStartPosition

Test: fast/dynamic/floating-to-positioned-2.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed to also remove relatively positioned floats from object lists when they become positioned, because then they cease to be floating.

LayoutTests:

Reviewed by Darin Adler.

test for https://bugs.webkit.org/show_bug.cgi?id=19598 Crash in WebCore::RenderBlock::determineStartPosition

fast/dynamic/floating-to-positioned-2.html: Copied from fast/dynamic/floating-to-positioned.html.
platform/mac/fast/dynamic/floating-to-positioned-2-expected.checksum: Added.
platform/mac/fast/dynamic/floating-to-positioned-2-expected.png: Added.
platform/mac/fast/dynamic/floating-to-positioned-2-expected.txt: Added.

7:44 PM Changeset in webkit [34653] by Darin Adler

2 edits in trunk/WebCore

2008-06-18 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

fix storage leak

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::copy): Added an adoptRef that I missed when changing these objects to start with a refcount of 1.

3:58 PM Changeset in webkit [34652] by timothy@apple.com

2 edits in trunk/WebCore

Add a script build phase to remove the WebKit.qrc file from
WebCore's resources. This file is used for the Qt port, but we
copy the whole inspector folder for connivence and get this file.

Reviewed by Adam Roben.

WebCore.xcodeproj/project.pbxproj: New script phase.

2:33 PM Changeset in webkit [34651] by timothy@apple.com

2 edits
1 add in trunk/WebCore

Combine the Web Inspector's JavaScript resources into one large
script file to speed up loading of the Inspector.

Reviewed by Adam Roben.

WebCore.xcodeproj/project.pbxproj: Added a Streamline Inspector Source script build phase that calls combine-javascript-resources and moves files around in the build directory.
combine-javascript-resources: Added.

1:50 PM Changeset in webkit [34650] by jchaffraix@webkit.org