Context Navigation

Tests: fast/parser/entity-end-iframe-tag.html

fast/parser/entity-end-script-tag.html
fast/parser/entity-end-style-tag.html
fast/parser/entity-end-textarea-tag.html
fast/parser/entity-end-title-tag.html
fast/parser/entity-end-xmp-tag.html

Previously the parser accepted end tags for textarea, title and
iframe elements that contained entity-escaped characters such as
'<'. The fix is to save the position of the last entity-escaped
character converted and to use that to make sure the end tag does
not contain an escaped character.

Note that this was not an issue for script, style and xmp elements
since they already ignored entity-escaped characters.

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): When looking for a closing tag, ignore any text with entity-escaped characters by making sure lastDecodedEntityPosition is less than the first character of the end tag.

LayoutTests:

Bug 7931: Escaped elements within a textarea block can cause the textarea box to be closed prematurely

<https://bugs.webkit.org/show_bug.cgi?id=7931>

Reviewed by Darin.

The entity-end-textarea-tag.html contains 11 test cases: one
for each character in '</textarea>'. The rest of the tests
only test one encoding: '<' as '<'.

fast/parser/entity-end-iframe-tag-expected.txt: Added.
fast/parser/entity-end-iframe-tag.html: Added.
fast/parser/entity-end-script-tag-expected.txt: Added.
fast/parser/entity-end-script-tag.html: Added.
fast/parser/entity-end-style-tag-expected.txt: Added.
fast/parser/entity-end-style-tag.html: Added.
fast/parser/entity-end-textarea-tag-expected.txt: Added.
fast/parser/entity-end-textarea-tag.html: Added.
fast/parser/entity-end-title-tag-expected.txt: Added.
fast/parser/entity-end-title-tag.html: Added.
fast/parser/entity-end-xmp-tag-expected.txt: Added.
fast/parser/entity-end-xmp-tag.html: Added.

2:42 PM Changeset in webkit [34721] by weinig@apple.com

3 edits
2 adds in trunk

WebCore:

2008-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19647
REGRESSION: Problem with extjs (insertAdjacentHTML)

Test: fast/dynamic/insertAdjacentHTML-allowed-parents.html

html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML): Don't use innerHTML logic for creating the DocumentFragment from the html string.

LayoutTests:

2008-06-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Test for https://bugs.webkit.org/show_bug.cgi?id=19647
REGRESSION: Problem with extjs (insertAdjacentHTML)

fast/dynamic/insertAdjacentHTML-allowed-parents-expected.txt: Added.
fast/dynamic/insertAdjacentHTML-allowed-parents.html: Added.

1:33 PM Changeset in webkit [34720] by abarth@webkit.org

5 edits in trunk/WebCore

2008-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Log error messages to the console when we deny a request for a URL.
These error messages do not appear in LayoutTests, but they do
appear in the WebInspector.

dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad):
loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::printAccessDeniedMessage):
loader/DocLoader.h:
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

1:33 PM Changeset in webkit [34719] by abarth@webkit.org

3 edits
4 adds in trunk

WebCore:

2008-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Fix <https://bugs.webkit.org/show_bug.cgi?id=19649>:

XSL style sheets allowed across origins

Block cross-orgin loads of XSL style sheets, matching Internet
Explorer, Firefox, and Opera. Also, we now block loading of XBL
across origins, matching Firefox. The XBL behavior does not appear
testable because XBL seems to not be enabled.

Test: http/tests/security/cross-origin-xsl-BLOCKED.html

loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):

LayoutTests:

2008-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19649

Test that we block cross-orign loads of XSL style sheets.

http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
http/tests/security/cross-origin-xsl-BLOCKED.html: Added.
http/tests/security/resources/cross-origin-xsl.xml: Added.
http/tests/security/resources/forbidden-stylesheet.xsl: Added.

12:16 PM Changeset in webkit [34718] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Adding bug title and URLs

12:13 PM Changeset in webkit [34717] by mitz@apple.com

2 edits in trunk/WebCore

2008-06-21 Marvin Decker <marv.decker@gmail.com>

Reviewed by Dave Hyatt.

Adds a NULL check for getting the small caps page of glyph data. The
page() function can explicitly return null in some cases, and every
other usage in this function does the check.

platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):

10:55 AM Changeset in webkit [34716] by mitz@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Alexey Proskuryakov.

update results for newly-added CSS variables, file and file list global constructors

fast/dom/Window/window-properties-expected.txt:

10:49 AM Changeset in webkit [34715] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

2008-06-21 Alex Taylor <darwin@milliamp.org>

Reviewed by Dan Bernstein.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=12425>

Adds support for border-radius on legend elements.
Fieldsets with a legend and rounded borders now have a clipping region set
around the legend.

Test: fast/borders/fieldsetBorderRadius.html

rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Removed a FIXME.

LayoutTests:

2008-06-21 Alex Taylor <darwin@milliamp.org>

Reviewed by Dan Bernstein.

<https://bugs.webkit.org/show_bug.cgi?id=12425>
Test support for border-radius on fieldset elements.

fast/borders/fieldsetBorderRadius.html: Added.
platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
platform/mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Added.

10:36 AM Changeset in webkit [34714] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix. Adding CSSVariable* API sources to the Bakefiles.

1:28 AM Changeset in webkit [34713] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-06-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fix the build for non-Mac Darwin platforms by disabling their support
for readline in the JavaScript shell.

kjs/config.h:

12:04 AM Changeset in webkit [34712] by timothy@apple.com

5 edits in trunk/JavaScriptCore

Use member function pointers for the Profile::forEach function.
Eliminating a few static functions and simplified things a little.

Reviewed by Alexey Proskuryakov.

JavaScriptCore.exp: Change the symbol for forEach.
profiler/Profile.cpp: (KJS::Profile::forEach): Use a member function pointer.
profiler/Profile.h: (KJS::Profile::sortTotalTimeDescending): Pass a function pointer. (KJS::Profile::sortTotalTimeAscending): Ditto. (KJS::Profile::sortSelfTimeDescending): Ditto. (KJS::Profile::sortSelfTimeAscending): Ditto. (KJS::Profile::sortCallsDescending): Ditto.
profiler/ProfileNode.h: (KJS::ProfileNode::sortTotalTimeDescending): No longer static. (KJS::ProfileNode::sortTotalTimeAscending): Ditto. (KJS::ProfileNode::sortSelfTimeDescending): Ditto. (KJS::ProfileNode::sortSelfTimeAscending): Ditto. (KJS::ProfileNode::sortCallsDescending): Ditto.

Jun 20, 2008:

11:32 PM Changeset in webkit [34711] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-06-20 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove unused destructors.

kjs/nodes.cpp:
kjs/nodes.h:

9:39 PM Changeset in webkit [34710] by timothy@apple.com

3 edits in trunk/JavaScriptCore

Fixed an ASSERT(m_actualSelfTime <= m_actualTotalTime) when starting
and stopping a profile from the Develop menu. Also prevents
inserting an incorrect parent node as the new head after profiling
is stopped from the Develop menu.

Reviewed by Dan Bernstein.

profiler/Profile.cpp: (KJS::Profile::stopProfiling): If the current node is already the head then there is no more need to record future nodes in didExecute. (KJS::Profile::didExecute): Move the code of setupCurrentNodeAsStopped into here since this was the only caller. When setting the total time keep any current total time while adding the self time of the head. (KJS::Profile::setupCurrentNodeAsStopped): Removed.
profiler/Profile.h: Removed setupCurrentNodeAsStopped.

6:22 PM Changeset in webkit [34709] by weinig@apple.com

2 edits in trunk/WebCore

2008-06-20 Sam Weinig <sam@webkit.org>

Fix Windows build.

bindings/scripts/CodeGeneratorCOM.pm:

3:59 PM Changeset in webkit [34708] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: Add files missing in the previous fix (r34705)

GNUmakefile.am:

3:29 PM Changeset in webkit [34707] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

fix leak of mask images

rendering/RenderObject.cpp: (WebCore::RenderObject::arenaDelete): Added a call to removeClient() on the mask box image.

3:27 PM Changeset in webkit [34706] by pewtermoose@webkit.org

3 edits in trunk/WebKitTools

2008-06-20 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin.

Extend the build-webkit (and set-webkit-configuration) script to
support Cairo-based webkit builds. (see http://bugs.webkit.org/show_bug.cgi?17952)

Scripts/build-webkit: Add --cairo-win32 to the help message
Scripts/webkitdirs.pm: Extend the 'determinePassedConfiguration subroutine to recognize the --cairo-win32 flag. When present, the build configuration is changed from Debug/Release to Debug_Cairo/Release_Cairo. This flag is only active when the isCygwin() test is true.

3:23 PM Changeset in webkit [34705] by jmalonzo@webkit.org

7 edits in trunk/WebCore

2008-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix for r34702, r34700 and r34693
Qt build fix for r34700 and r34693

GNUmakefile.am:
WebCore.pro:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/RenderThemeGtk.h:
platform/qt/RenderThemeQt.cpp:
platform/qt/RenderThemeQt.h:

3:14 PM Changeset in webkit [34704] by kevino@webkit.org

3 edits in trunk/JavaScriptCore

!USE(MULTIPLE_THREADS) on Darwin build fix

2:51 PM Changeset in webkit [34703] by kmccullough@apple.com

2 edits in trunk/JavaScriptCore

2008-06-20 Kevin McCullough <kmccullough@apple.com>

-Leopard Build Fix.

profiler/Profile.cpp: (KJS::Profile::removeProfileStart): (KJS::Profile::removeProfileEnd):

2:43 PM Changeset in webkit [34702] by weinig@apple.com

14 edits
6 adds in trunk/WebCore

2008-06-20 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Add 'files' property to the HTMLInputElement, which returns a FileList object
(when type=file, null otherwise) containing a list of all the files selected.
It currently always contains only 0 or 1 files as multifile input is not supported
yet. The list contains File objects which contains the name and size of the file.
The inspiration for these interfaces is from:

Also fixes <rdar://problem/6022802>

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
bindings/objc/DOMInternal.h:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/IDLStructure.pm:
html/File.cpp: Added. (WebCore::File::File): (WebCore::File::fileSize):
html/File.h: Added. (WebCore::File::create): (WebCore::File::fileName): (WebCore::File::path):
html/File.idl: Added.
html/FileList.cpp: Added. (WebCore::FileList::FileList): (WebCore::FileList::item):
html/FileList.h: Added. (WebCore::FileList::create): (WebCore::FileList::length): (WebCore::FileList::isEmpty): (WebCore::FileList::clear): (WebCore::FileList::append):
html/FileList.idl: Added.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::files):
html/HTMLInputElement.h:
html/HTMLInputElement.idl:
page/DOMWindow.idl:

2:19 PM Changeset in webkit [34701] by hyatt@apple.com

3 edits
4 adds in trunk

WebCore:

2008-06-20 David Hyatt <hyatt@apple.com>

Make sure CSS variables work inside the inline style attribute.

Reviewed by Beth

Added fast/css/variables/inline-style-test.html

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::addParsedProperties):

LayoutTests:

2008-06-20 David Hyatt <hyatt@apple.com>

Make sure CSS variables work inside the inline style attribute.

Reviewed by Beth

fast/css/variables/inline-style-test.html: Added.
platform/mac/fast/css/variables/inline-style-test-expected.checksum: Added.
platform/mac/fast/css/variables/inline-style-test-expected.png: Added.
platform/mac/fast/css/variables/inline-style-test-expected.txt: Added.

1:47 PM Changeset in webkit [34700] by hyatt@apple.com

13 edits
14 adds in trunk

WebCore:

2008-06-20 David Hyatt <hyatt@apple.com>

Add support for the CSSVariablesRule and CSSVariablesDeclaration DOM APIs. These allow querying of
variables names and values, as well as iteration, setting and removal.

Reviewed by Sam

Added multiple new tests to fast/css/variables/

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
bindings/objc/DOMInternal.h:
bindings/scripts/CodeGeneratorJS.pm:
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::parserValue):
css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setCssText): (WebCore::CSSVariablesDeclaration::setChanged):
css/CSSVariablesDeclaration.h:
css/CSSVariablesDeclaration.idl: Added.
css/CSSVariablesRule.h:
css/CSSVariablesRule.idl: Added.

LayoutTests:

2008-06-20 David Hyatt <hyatt@apple.com>

Add tests of the DOM APIs for addition, removal and iteration.

Reviewed by Sam

fast/css/variables/remove-variable-test.html: Added.
fast/css/variables/set-variable-test.html: Added.
fast/css/variables/variable-iteration-test.html: Added.
platform/mac/fast/css/variables/remove-variable-test-expected.checksum: Added.
platform/mac/fast/css/variables/remove-variable-test-expected.png: Added.
platform/mac/fast/css/variables/remove-variable-test-expected.txt: Added.
platform/mac/fast/css/variables/set-variable-test-expected.checksum: Added.
platform/mac/fast/css/variables/set-variable-test-expected.png: Added.
platform/mac/fast/css/variables/set-variable-test-expected.txt: Added.
platform/mac/fast/css/variables/variable-iteration-test-expected.checksum: Added.
platform/mac/fast/css/variables/variable-iteration-test-expected.png: Added.
platform/mac/fast/css/variables/variable-iteration-test-expected.txt: Added.

1:47 PM Changeset in webkit [34699] by kmccullough@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

2008-06-20 Kevin McCullough <kmccullough@apple.com>

Just giving credit.

ChangeLog:

12:47 PM Changeset in webkit [34698] by kmccullough@apple.com

2 edits in trunk/JavaScriptCore

2008-06-20 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6024846> JSProfiler: ASSERT hit in Profiler.

Because InspectorController can call startProfiling() and stopProfiling() we cannot assert that console.profile() and console.profileEnd() will be in the profile tree.

profiler/Profile.cpp: (KJS::Profile::removeProfileStart): (KJS::Profile::removeProfileEnd):

12:38 PM Changeset in webkit [34697] by kmccullough@apple.com

1 edit
1 add in trunk/WebCore

2008-06-20 Kevin McCullough <kmccullough@apple.com>

Rubber stamped by Adele.

manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Added.

12:36 PM Changeset in webkit [34696] by kmccullough@apple.com

13 edits
1 add in trunk

JavaScriptCore:

2008-06-20 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
if profiling is started and finished within the same function. (19230)

Now we profile one more stack frame up from the last frame to allocate the time spent in it, if it exists.

JavaScriptCore.exp:
VM/Machine.cpp: We need to let the profiler know when the JS program has finished since that is what will actually stop the profiler instead of just calling stopProfiling(). (KJS::Machine::execute):
profiler/Profile.cpp: (KJS::Profile::create): Moved from Profile.h since it was getting pretty long. (KJS::Profile::Profile): We now have a client, which is a listener who we will return this profile to, once it has actually finished. (KJS::Profile::stopProfiling): Instead of fully stopping the profiler here, we set the flag and keep it profiling in the background. (KJS::Profile::didFinishAllExecution): This is where the profiler actually finishes and creates the (idle) node if one should be made. (KJS::Profile::removeProfileStart): Don't use m_currentNode since it is needed by the profiler as it runs silently in the background. (KJS::Profile::removeProfileEnd): Ditto. (KJS::Profile::willExecute): Don't profile new functions if we have stopped profiling. (KJS::Profile::didExecute): Only record one more return as all the remaining time will be attributed to that function. (KJS::Profile::setupCurrentNodeAsStopped): Sets the current node's time.
profiler/Profile.h: Added functions and variables for the above changes. (KJS::Profile::client):
profiler/ProfileNode.h: (KJS::CallIdentifier::toString): Debug method.
profiler/Profiler.cpp: Added support for the ProfilerClient. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): No longer return sthe profile. (KJS::Profiler::didFinishAllExecution): Now returns the profile to the client instead of stopProfiling.
profiler/Profiler.h: (KJS::ProfilerClient::~ProfilerClient): Clients will implement this interface.

WebCore:

2008-06-20 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5958770> JSProfiler: Time incorrectly given to (idle)
if profiling is started and finished within the same function. (19230)

Now we profile one more stack frame up from the last frame to allocate the time spent in it, if it exists.

page/Console.cpp:
manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Added. (WebCore::Console::profile): When stating the profiler give a client for the callback of when the profile actually finishes. (WebCore::Console::profileEnd): No longer needs to handle the return of the profile object since it will be retruned in the client's callback. (WebCore::Console::finishedProfiling): Implemenet the ProfileClient callback method.
page/Console.h: Inherit from the ProfileClient.
page/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): Use the client callback. (WebCore::InspectorController::stopUserInitiatedProfiling): Does not need to handle the profile being returned as it is now handled by the client callback. (WebCore::InspectorController::finishedProfiling): Implement the ProfileClient callback method.
page/InspectorController.h: Inherit from the ProfileClient.

12:26 PM Changeset in webkit [34695] by timothy@apple.com

2 edits in trunk/WebCore

Makes the JavaScript syntax highlighter process lines in chunks
so the user interface isn't blocked for large script files.

https://bugs.webkit.org/show_bug.cgi?id=19677

Reviewed by Adam Roben.

page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Use the cells property on the row instead of getElementsByTagName. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Use the cells property on the row instead of getElementsByTagName. Added a nested processChunk function that highlights 10 lines at a time This processChunk function is called at an interval of 25ms. The code is still highlighted quickly, and the user can't tell it wasn't highlighted all at once.

12:26 PM Changeset in webkit [34694] by timothy@apple.com

3 edits in trunk/WebCore

Fixes a bug where the source view in the Resources panel had a
couple of extra pixels at the bottom when fully scrolled.

Reviewed by Adam Roben.

page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.set autoSizesToFitContentHeight): Call removeStyleClass instead of addStyleClass for "webkit-height-sized-to-fit" when sizing to fit is being disabled.
page/inspector/inspector.css: (.resource-view.headers-visible .source-view-frame): Added the vertical-align: top property to prevent line alignment from adding extra pixels on the bottom.

12:26 PM Changeset in webkit [34693] by timothy@apple.com

41 edits
2 adds in trunk

Fixes: Bug 19679: iframes with a height of 32,768px or greater do not layout correctly

WebCore:

2008-06-19 Timothy Hatcher <timothy@apple.com>

Changed all lineHeight, baselinePosition and verticalPositionHint
calls to return int instead of short. The short was overflowing
when a value greater than 32,767 was encountered.

Fixes: iframes with a height of 32,768px or greater do not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=19679

Reviewed by Dave Hyatt.

Test: fast/css/line-height-overflow.html

rendering/RenderBR.cpp: (WebCore::RenderBR::baselinePosition):
rendering/RenderBR.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::lineHeight):
rendering/RenderBlock.h:
rendering/RenderFlow.cpp:
rendering/RenderFlow.h:
rendering/RenderListBox.cpp:
rendering/RenderListBox.h:
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::lineHeight):
rendering/RenderListMarker.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint):
rendering/RenderObject.h: (WebCore::):
rendering/RenderPath.cpp: (WebCore::RenderPath::lineHeight):
rendering/RenderPath.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::lineHeight):
rendering/RenderReplaced.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::lineHeight):
rendering/RenderSVGContainer.h:
rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::lineHeight):
rendering/RenderSVGHiddenContainer.h:
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::lineHeight):
rendering/RenderSVGRoot.h:
rendering/RenderSlider.cpp:
rendering/RenderSlider.h:
rendering/RenderTableCell.cpp:
rendering/RenderTableCell.h:
rendering/RenderTableCol.h:
rendering/RenderTableRow.h:
rendering/RenderTableSection.h:
rendering/RenderText.cpp:
rendering/RenderText.h:
rendering/RenderTextControl.cpp:
rendering/RenderTextControl.h:
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:
rendering/RenderThemeSafari.cpp:
rendering/RenderThemeSafari.h:

LayoutTests:

2008-06-19 Timothy Hatcher <timothy@apple.com>

Test for: iframes with a height of 32,768px or greater do not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=19679

Reviewed by Dave Hyatt.

fast/css/line-height-overflow.html: Added.
platform/mac/fast/css/line-height-overflow-expected.txt: Added.

12:19 PM Changeset in webkit [34692] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix https://bugs.webkit.org/show_bug.cgi?id=19519 <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)

Test: fast/table/prepend-in-anonymous-table.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): Added code to handle the case of inserting before a child that has been wrapped by an anonymous table, in which case if the new child is the type that needs to be in a table, it is inserted into the table, and otherwise it is inserted before the table.
rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added table-column-group alongside table-caption as content that can exist inside an anonymous table without being wrapped in a table section.

LayoutTests:

Reviewed by Darin Adler.

test for https://bugs.webkit.org/show_bug.cgi?id=19519 <rdar://problem/6007345> DOM modification causes stack exhaustion (BUTTON OBJECT COLGROUP)

fast/table/prepend-in-anonymous-table.html: Added.
platform/mac/fast/table/prepend-in-anonymous-table-expected.checksum: Added.
platform/mac/fast/table/prepend-in-anonymous-table-expected.png: Added.
platform/mac/fast/table/prepend-in-anonymous-table-expected.txt: Added.

11:36 AM Changeset in webkit [34691] by hyatt@apple.com

8 edits
4 adds
4 deletes in trunk

WebCore:

2008-06-20 David Hyatt <hyatt@apple.com>

Allow CSS variables to support arbitrary expressions as values instead of just a single term.

Reviewed by Sam

Removed fast/css/variables/single-term-test.html and replaced with multiple-term-test.html

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::addVariable):
css/CSSParser.h:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariable):
css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):

LayoutTests:

2008-06-20 David Hyatt <hyatt@apple.com>

Allow CSS variables to support arbitrary expressions as values instead of just a single term.

Reviewed by Sam

fast/css/variables/single-term-test.html: Removed.
fast/css/variables/multiple-term-test.html: Added.
platform/mac/fast/css/variables/multiple-term-test-expected.checksum: Added.
platform/mac/fast/css/variables/multiple-term-test-expected.png: Added.
platform/mac/fast/css/variables/multiple-term-test-expected.txt: Added.
platform/mac/fast/css/variables/single-term-test-expected.checksum: Removed.
platform/mac/fast/css/variables/single-term-test-expected.png: Removed.
platform/mac/fast/css/variables/single-term-test-expected.txt: Removed.

10:17 AM Changeset in webkit [34690] by Darin Adler

4 edits in trunk/LayoutTests

2008-06-20 Darin Adler <Darin Adler>

updated results for some recent changes

fast/dom/Window/window-properties-expected.txt: Updated results to reflect the new rule type, VARIABLES_RULE (Hyatt's CSS variables patch).

fast/forms/plaintext-mode-1-expected.txt: Updated test and results to expect ForeColor to be disabled when the region is plain-text-only. Justin's execCommand patch for https://bugs.webkit.org/show_bug.cgi?id=16049.
fast/forms/plaintext-mode-1.html: Ditto.

8:22 AM Changeset in webkit [34689] by Simon Hausmann