⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 22, 2008:

6:30 PM Changeset in webkit [34736] by mrowe@apple.com
  • 3 edits in trunk/WebKitSite

2008-06-22 Aaron Digulla <​digulla@hepe.com>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=18993
Bug 18993: Update of buttons in editing toolbar demo lags behind

  • demos/editingToolbar/FancyToolbar.js:
  • demos/editingToolbar/index.html:
6:25 PM Changeset in webkit [34735] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-06-22 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19465
Bug 19465: Cursor sometimes gets 'stuck' in textareas when trying to navigate with arrow keys

Test: editing/input/textarea-arrow-navigation.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): In the case when the next position is to the right of the last text box but the text offset is 0, set the affinity to DOWNSTREAM instead of UPSTREAM so that the cursor doesn't remain on the previous line.
6:20 PM Changeset in webkit [34734] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-06-22 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=17421
Bug 17421: Lack of end tag for SELECT element causes the rest of page to not be rendered

Test: fast/parser/input-textarea-inside-select-element.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
6:06 PM Changeset in webkit [34733] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-06-22 David Krause <​david.krause@gmail.com>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19426
Bug 19426: LOW_BANDWIDTH_DISPLAY build broken

Change ref to addClient and deref to removeClient in code wrapped
by USE(LOW_BANDWIDTH_DISPLAY) to match changes in r31834.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::removeAllLowBandwidthDisplayRequests): (WebCore::FrameLoader::notifyFinished):
6:02 PM Changeset in webkit [34732] by mrowe@apple.com
  • 6 edits
    2 adds in trunk

2008-06-22 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19520
Bug 19520: WebKit incorrectly accepts hidden as the value of outline-style

Test: fast/css/outline-hidden-illegal-value.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::outlineWidth): (WebCore::RenderStyle::outlineOffset):
5:58 PM Changeset in webkit [34731] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-06-22 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19675
Bug 19675: [GTK] negative text-shadows are not rendered

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): The IntSize::isEmpty() call checks that the sizes are > 0, while we need to check for != 0.
5:55 PM Changeset in webkit [34730] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-06-22 kuchhal <​kuchhal@yahoo.com>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19696
Bug 19696: Memory leak in WebCore/editing/DeleteButtonController.cpp

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Delete the Image instance if the platform resource could not be loaded.
5:52 PM Changeset in webkit [34729] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-06-22 kuchhal <​kuchhal@yahoo.com>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19697
Bug 19697: Redundant releaseRef causing memory leak

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::fragmentFromCF_HTML):

Jun 21, 2008:

6:35 PM Changeset in webkit [34728] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Print a blank line when exiting the jsc interactive mode to ensure that the shell
prompt will start on a new line.

Reviewed by Sam Weinig.

  • kjs/Shell.cpp:

(runInteractive):

6:35 PM Changeset in webkit [34727] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Tweak the paths of the items in the "tests" group to clean things up a little.

Rubber-stamped by Sam Weinig.

6:35 PM Changeset in webkit [34726] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix jsc to link against libedit.dylib rather than libedit.2.dylib.

Rubber-stamped by Sam Weinig.

6:35 PM Changeset in webkit [34725] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Copy the JavaScriptCore shell (jsc) into JavaScriptCore.framework so that it will be included in nightly builds.
​https://bugs.webkit.org/show_bug.cgi?id=19691

Reviewed by Sam Weinig.

6:24 PM Changeset in webkit [34724] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-06-21 Sam Weinig <​sam@webkit.org>

Fix Windows build.

  • bindings/scripts/CodeGeneratorCOM.pm:
  • html/HTMLInputElement.idl:
5:35 PM Changeset in webkit [34723] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix a typo "new" in the keywords list for hte JavaScript
syntax highlighter. And adds "get" and "set" to the keyword list.

Reviewed by Sam Weinig.

  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Fixes the "new" typo and adds "get" and "set".
4:49 PM Changeset in webkit [34722] by ddkilzer@apple.com
  • 3 edits
    12 adds in trunk

WebCore:

Bug 7931: Escaped elements within a textarea block can cause the textarea box to be closed prematurely

<​https://bugs.webkit.org/show_bug.cgi?id=7931>

Reviewed by Darin.

Tests: fast/parser/entity-end-iframe-tag.html

fast/parser/entity-end-script-tag.html
fast/parser/entity-end-style-tag.html
fast/parser/entity-end-textarea-tag.html
fast/parser/entity-end-title-tag.html
fast/parser/entity-end-xmp-tag.html

Previously the parser accepted end tags for textarea, title and
iframe elements that contained entity-escaped characters such as
'&lt;'. The fix is to save the position of the last entity-escaped
character converted and to use that to make sure the end tag does
not contain an escaped character.

Note that this was not an issue for script, style and xmp elements
since they already ignored entity-escaped characters.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): When looking for a closing tag, ignore any text with entity-escaped characters by making sure lastDecodedEntityPosition is less than the first character of the end tag.

LayoutTests:

Bug 7931: Escaped elements within a textarea block can cause the textarea box to be closed prematurely

<​https://bugs.webkit.org/show_bug.cgi?id=7931>

Reviewed by Darin.

The entity-end-textarea-tag.html contains 11 test cases: one
for each character in '</textarea>'. The rest of the tests
only test one encoding: '<' as '&lt;'.

  • fast/parser/entity-end-iframe-tag-expected.txt: Added.
  • fast/parser/entity-end-iframe-tag.html: Added.
  • fast/parser/entity-end-script-tag-expected.txt: Added.
  • fast/parser/entity-end-script-tag.html: Added.
  • fast/parser/entity-end-style-tag-expected.txt: Added.
  • fast/parser/entity-end-style-tag.html: Added.
  • fast/parser/entity-end-textarea-tag-expected.txt: Added.
  • fast/parser/entity-end-textarea-tag.html: Added.
  • fast/parser/entity-end-title-tag-expected.txt: Added.
  • fast/parser/entity-end-title-tag.html: Added.
  • fast/parser/entity-end-xmp-tag-expected.txt: Added.
  • fast/parser/entity-end-xmp-tag.html: Added.
2:42 PM Changeset in webkit [34721] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19647
REGRESSION: Problem with extjs (insertAdjacentHTML)

Test: fast/dynamic/insertAdjacentHTML-allowed-parents.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML): Don't use innerHTML logic for creating the DocumentFragment from the html string.

LayoutTests:

2008-06-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19647
REGRESSION: Problem with extjs (insertAdjacentHTML)

  • fast/dynamic/insertAdjacentHTML-allowed-parents-expected.txt: Added.
  • fast/dynamic/insertAdjacentHTML-allowed-parents.html: Added.
1:33 PM Changeset in webkit [34720] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2008-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Log error messages to the console when we deny a request for a URL.
These error messages do not appear in LayoutTests, but they do
appear in the WebInspector.

  • dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::printAccessDeniedMessage):
  • loader/DocLoader.h:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
1:33 PM Changeset in webkit [34719] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2008-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Fix <​https://bugs.webkit.org/show_bug.cgi?id=19649>:

XSL style sheets allowed across origins

Block cross-orgin loads of XSL style sheets, matching Internet
Explorer, Firefox, and Opera. Also, we now block loading of XBL
across origins, matching Firefox. The XBL behavior does not appear
testable because XBL seems to not be enabled.

Test: http/tests/security/cross-origin-xsl-BLOCKED.html

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):

LayoutTests:

2008-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19649

Test that we block cross-orign loads of XSL style sheets.

  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
  • http/tests/security/cross-origin-xsl-BLOCKED.html: Added.
  • http/tests/security/resources/cross-origin-xsl.xml: Added.
  • http/tests/security/resources/forbidden-stylesheet.xsl: Added.
12:16 PM Changeset in webkit [34718] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Adding bug title and URLs

12:13 PM Changeset in webkit [34717] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-06-21 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Dave Hyatt.

Adds a NULL check for getting the small caps page of glyph data. The
page() function can explicitly return null in some cases, and every
other usage in this function does the check.

  • platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
10:55 AM Changeset in webkit [34716] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Alexey Proskuryakov.

  • update results for newly-added CSS variables, file and file list global constructors
  • fast/dom/Window/window-properties-expected.txt:
10:49 AM Changeset in webkit [34715] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-06-21 Alex Taylor <​darwin@milliamp.org>

Reviewed by Dan Bernstein.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=12425>

Adds support for border-radius on legend elements.
Fieldsets with a legend and rounded borders now have a clipping region set
around the legend.


Test: fast/borders/fieldsetBorderRadius.html

  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Removed a FIXME.

LayoutTests:

2008-06-21 Alex Taylor <​darwin@milliamp.org>

Reviewed by Dan Bernstein.

<​https://bugs.webkit.org/show_bug.cgi?id=12425>
Test support for border-radius on fieldset elements.

  • fast/borders/fieldsetBorderRadius.html: Added.
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Added.
10:36 AM Changeset in webkit [34714] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding CSSVariable* API sources to the Bakefiles.

1:28 AM Changeset in webkit [34713] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-21 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fix the build for non-Mac Darwin platforms by disabling their support
for readline in the JavaScript shell.

  • kjs/config.h:
12:04 AM Changeset in webkit [34712] by timothy@apple.com
  • 5 edits in trunk/JavaScriptCore

Use member function pointers for the Profile::forEach function.
Eliminating a few static functions and simplified things a little.

Reviewed by Alexey Proskuryakov.

  • JavaScriptCore.exp: Change the symbol for forEach.
  • profiler/Profile.cpp: (KJS::Profile::forEach): Use a member function pointer.
  • profiler/Profile.h: (KJS::Profile::sortTotalTimeDescending): Pass a function pointer. (KJS::Profile::sortTotalTimeAscending): Ditto. (KJS::Profile::sortSelfTimeDescending): Ditto. (KJS::Profile::sortSelfTimeAscending): Ditto. (KJS::Profile::sortCallsDescending): Ditto.
  • profiler/ProfileNode.h: (KJS::ProfileNode::sortTotalTimeDescending): No longer static. (KJS::ProfileNode::sortTotalTimeAscending): Ditto. (KJS::ProfileNode::sortSelfTimeDescending): Ditto. (KJS::ProfileNode::sortSelfTimeAscending): Ditto. (KJS::ProfileNode::sortCallsDescending): Ditto.
Note: See TracTimeline for information about the timeline view.