⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 25, 2008:

6:52 PM Changeset in webkit [34804] by mjs@apple.com
  • 3 edits in trunk/WebKitSite

2008-06-25 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, web site fix.


Remove blank lines in an attempt to fix feeds.

  • blog/wp-content/themes/webkit/index.php:
  • blog/wp-content/themes/webkit/links.php:
6:10 PM Changeset in webkit [34803] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2008-06-25 Jean-Charles Verdié <​jcverdie@pleyo.com>

Reviewed by Geoffrey Garen.

  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Copied from LayoutTests/dom/xhtml/level2/html/HTMLFrameElement09.xhtml.
5:22 PM Changeset in webkit [34802] by Beth Dakin
  • 6 edits
    8 adds in trunk

WebKitTools:

2008-06-25 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

This patch adds support to the AccessibilityController to query the
following attributes specifically, without a full attribute dump:
AXRole, AXTitle, and AXDescription.

  • DumpRenderTree/AccessibilityController.cpp: (allAttributesForFocusedElementCallback): (roleOfFocusedElementCallback): (titleOfFocusedElementCallback): (descriptionOfFocusedElementCallback): (AccessibilityController::staticFunctions):
  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::allAttributesForFocusedElement): (concatenateAttributeAndValue): (AccessibilityController::roleOfFocusedElement): (AccessibilityController::titleOfFocusedElement): (AccessibilityController::descriptionOfFocusedElement):

LayoutTests:

2008-06-25 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

New tests that exercise the ability to query the following
accessibility attributes individually: role, title, and
description.

  • accessibility/aria-describedby-on-input-expected.txt: Added.
  • accessibility/aria-describedby-on-input.html: Added.
  • accessibility/aria-labelledby-on-input-expected.txt: Added.
  • accessibility/aria-labelledby-on-input.html: Added.
  • accessibility/aria-roles-expected.txt: Added.
  • accessibility/aria-roles.html: Added.
  • accessibility/document-attributes.html:
  • accessibility/resources: Added.
  • accessibility/resources/cake.png: Added.
4:44 PM Changeset in webkit [34801] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-06-25 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Move XMLHttpRequestState enum into XMLHttpRequest and rename to State.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::readyState): (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::open):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::create): (WebCore::XMLHttpRequest::):
2:44 PM Changeset in webkit [34800] by timothy@apple.com
  • 6 edits
    1 copy in trunk

Fixes an ASSERT in the profiler when starting multiple profiles
with the same name inside the same function/program.

Reviewed by Kevin McCullough.

  • profiler/Profile.cpp: (KJS::Profile::Profile): Initialize m_stoppedCallDepth to zero. (KJS::Profile::stopProfiling): Set the current node to the parent, because we are in a call that will not get a didExecute call. (KJS::Profile::removeProfile): Increment m_stoppedCallDepth to account for didExecute not being called for profile. (KJS::Profile::willExecute): Increment m_stoppedCallDepth if stopped. (KJS::Profile::didExecute): Decrement m_stoppedCallDepth if stopped and greater than zero, and return early.
  • profiler/Profile.h: Added stoppedProfiling().
  • profiler/Profiler.cpp: (KJS::Profiler::findProfile): Removed. (KJS::Profiler::startProfiling): Don't return early for stopped profiles. (KJS::Profiler::stopProfiling): Skipp stopped profiles. (KJS::Profiler::didFinishAllExecution): Code clean-up.
  • profiler/Profiler.h: Removed findProfile.
2:22 PM Changeset in webkit [34799] by justin.garcia@apple.com
  • 10 edits
    4 adds in trunk

WebCore:

2008-06-25 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/5994480> Line break lost on some pastes


Merging the the first paragraph of inserted content with the content that came
before the selection that was pasted into would also move content after
the selection that was pasted into if:


1) Only one paragraph was being pasted, and it was not wrapped in a block
2) The selection that was pasted into ended at the end of a block
3) The next paragraph didn't start at the start of a block.


Insert a line break just after the inserted content to separate it from what
comes after and prevent that from happening.


Doing this exposed a bug in deletion where it would insert an unnecessary placeholder
when deleting a paragraph that started or ended with an input element. This was
because its m_startBlock and m_endBlock were still computed with the old deprecated
enclosingBlockFlowOrTableElement().


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Use the new method for getting an enclosing block. (WebCore::DeleteSelectionCommand::doApply): The new method for getting an enclosing block will return 0 if it reaches the root editable element before finding a block, so if we're deleting inside an inline editable root, m_start/endBlock will be 0. Removed an early return for this case (we already have test coverage for it).
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Insert a line break just after the inserted content to separate it from what comes after.
  • dom/Node.h: Removed enclosingBlockFlowOrTableElement().
  • dom/Node.cpp: Ditto.

LayoutTests:

2008-06-25 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.


<rdar://problem/5994480> Line break lost on some pastes


These demonstrate fixes:

  • editing/inserting/5994480.html: Added.
  • editing/inserting/5994480-expected.txt: Added.
  • editing/inserting/5994480-2.html: Added.
  • editing/inserting/5994480-2-expected.txt: Added.


The changes made in this fix caused more of the unrendered text from the original
file to be preserved and show up in the test results. We insert a line break after
inserted content to separate it from content that comes after and prevent it from
being merged. In these what came after was unrendered whitespace that was previously
clobbered by the merge:

  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-010-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
1:51 PM Changeset in webkit [34798] by ddkilzer@apple.com
  • 1 edit in trunk/BugsSite/ChangeLog

Fixed date.

11:49 AM Changeset in webkit [34797] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Make PrettyPatch handle diffs with no Index or diff headers

Part of Bug 19290: More patches not handled by PrettyPatch.rb
<​https://bugs.webkit.org/show_bug.cgi?id=19290>

Reviewed by Adam.

  • PrettyPatch/PrettyPatch.rb: (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to match on "+++ " lines for patches with no "Index" or "diff" header. (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line when the first line of a patch has no "Index" or "diff" header. (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state variable to determine when no "Index" or "diff" header has been found, but a new patch has started with a "--- " line.
11:21 AM Changeset in webkit [34796] by andersca@apple.com
  • 3 edits in trunk/WebCore

2008-06-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Dave Hyatt.

Fix refcount leak in CSSVariablesRule.

  • css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule):
  • css/CSSVariablesRule.h: (WebCore::CSSVariablesRule::create): (WebCore::CSSVariablesRule::setDeclaration):
10:31 AM Changeset in webkit [34795] by andersca@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/6007111>
​https://bugs.webkit.org/show_bug.cgi?id=19516
DOM modification causes Access Violation (NULL pointer?)


Null check the document element.


  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):

LayoutTests:

2008-06-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/6007111>
​https://bugs.webkit.org/show_bug.cgi?id=19516
DOM modification causes Access Violation (NULL pointer?)

  • fast/dom/HTMLHtmlElement/duplicate-html-element-crash-expected.txt: Added.
  • fast/dom/HTMLHtmlElement/duplicate-html-element-crash.html: Added.
9:36 AM Changeset in webkit [34794] by mitz@apple.com
  • 23 edits
    9 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5873639> REGRESSION (r31620): css2.1/t1506-c525-font-wt-00-b fails on Windows

Tests: fast/css/font-face-locally-installed.html

fast/css/font-face-multiple-faces.html

  • WebCore.vcproj/WebCore.vcproj: Added FontTraitsMask.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSFontFace.h: Made CSSFontFace store descriptors from the @font-face rule, as follows: (WebCore::CSSFontFace::create): Added a FontTraitsMask argument. (WebCore::CSSFontFace::traitsMask): Added this accessor. (WebCore::CSSFontFace::addRange): Added. (WebCore::CSSFontFace::ranges): Added. (WebCore::CSSFontFace::UnicodeRange::UnicodeRange): (WebCore::CSSFontFace::UnicodeRange::from): (WebCore::CSSFontFace::UnicodeRange::to): (WebCore::CSSFontFace::CSSFontFace): Added a FontTraitsMask and a vector of UnicodeRanges as member variables.
  • css/CSSFontFaceSource.cpp: Changed the hash key from the font size alone to the font size and the synthetic style bits, needed if the same source supplies different synthesized versions. (WebCore::CSSFontFaceSource::pruneTable): (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::~CSSFontSelector): Added code to delete the contents of the font face, locally-installed font face and segmented font tables. (WebCore::CSSFontSelector::addFontFaceRule): Changed this function to not create segmented font faces, but instead just collect font faces and annotate them with descriptors (traits and unicode ranges). (WebCore::compareFontFaces): Added. Used in getFontData() to sort the font faces by proximity to the desired traits. (WebCore::CSSFontSelector::getFontData): Changed to create the segmented font face here and cache it.
  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp: Changed to keep a vector of font faces instead of font face ranges, as font faces now know their Unicode ranges. (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::isLoaded): (WebCore::CSSSegmentedFontFace::isValid): (WebCore::CSSSegmentedFontFace::appendFontFace): (WebCore::CSSSegmentedFontFace::getFontData): Removed the synthetic traits parameters, and instead changed to set them on each FontData separately based on the difference between the desired traits and the font face's traits.
  • css/CSSSegmentedFontFace.h:
  • platform/graphics/FontCache.h: Removed fontExists() and added getTraitsInFamily().
  • platform/graphics/FontDescription.cpp: (WebCore::FontDescription::traitsMask): Added.
  • platform/graphics/FontDescription.h:
  • platform/graphics/FontTraitsMask.h: Added.
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Changed to fill in with glyphs from all fonts in the segmented font, using each font in turn to fill in characters not covered by earlier fonts.
  • platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getTraitsInFamily): Added a stub.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getTraitsInFamily): Added.
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getTraitsInFamily): Added a stub.
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Added. (WebCore::traitsInFamilyEnumProc): Added. (WebCore::FontCache::getTraitsInFamily): Added.
  • platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getTraitsInFamily): Added a stub.
  • platform/mac/WebFontCache.h:
  • platform/mac/WebFontCache.mm: (toTraitsMask): Added. (+[WebFontCache getTraits:inFamily:]): Added.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/css/font-face-locally-installed.html: Added.
  • fast/css/font-face-multiple-faces.html: Added.
  • platform/mac/fast/css/font-face-locally-installed-expected.checksum: Added.
  • platform/mac/fast/css/font-face-locally-installed-expected.png: Added.
  • platform/mac/fast/css/font-face-locally-installed-expected.txt: Added.
  • platform/mac/fast/css/font-face-multiple-faces-expected.checksum: Added.
  • platform/mac/fast/css/font-face-multiple-faces-expected.png: Added.
  • platform/mac/fast/css/font-face-multiple-faces-expected.txt: Added.
  • platform/win/Skipped: Removed css2.1/t1506-c525-font-wt-00-b.html.
1:38 AM Changeset in webkit [34793] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-25 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Alexey Proskuryakov.

Attempt to fix Windows debug build. The compiler gives a warning when
Structured Exception Handling and destructors are used in the same
function. Using manual locking and unlocking instead of constructors
and destructors should fix the warning.

  • kjs/Shell.cpp: (main):
12:15 AM Changeset in webkit [34792] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Forgot to address a review comment about better names for tracked objects, doing it now.

  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/nodes.cpp: (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::ref): (KJS::ParserRefCounted::deref): (KJS::ParserRefCounted::hasOneRef): (KJS::ParserRefCounted::deleteNewObjects):
12:07 AM Changeset in webkit [34791] by ap@webkit.org
  • 11 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Remove more threadInstance() calls.

  • kjs/JSFunction.cpp: (KJS::JSFunction::getParameterName): (KJS::IndexToNameMap::unMap): (KJS::Arguments::deleteProperty):
  • kjs/JSFunction.h: Access nullIdentifier without going to thread specific storage.
  • JavaScriptCore.exp:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/Parser.cpp: (KJS::Parser::parse):
  • kjs/Parser.h: (KJS::ParserRefCountedData::ParserRefCountedData): (KJS::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::ref): (KJS::ParserRefCounted::deref): (KJS::ParserRefCounted::hasOneRef): (KJS::ParserRefCounted::deleteNewObjects): (KJS::Node::Node): (KJS::StatementNode::StatementNode): (KJS::BreakpointCheckStatement::BreakpointCheckStatement): (KJS::ConstDeclNode::ConstDeclNode): (KJS::BlockNode::BlockNode): (KJS::ForInNode::ForInNode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::ImmediateNumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::EvalFunctionCallNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallDotNode::): (KJS::PrePostResolveNode::): (KJS::PostIncResolveNode::): (KJS::PostDecResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostIncBracketNode::): (KJS::PostDecBracketNode::): (KJS::PostfixDotNode::): (KJS::PostIncDotNode::): (KJS::PostDecDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PreIncResolveNode::): (KJS::PreDecResolveNode::): (KJS::PrefixBracketNode::): (KJS::PreIncBracketNode::): (KJS::PreDecBracketNode::): (KJS::PrefixDotNode::): (KJS::PreIncDotNode::): (KJS::PreDecDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryOpNode::UnaryOpNode): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::BinaryOpNode::BinaryOpNode): (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode): (KJS::MultNode::): (KJS::DivNode::): (KJS::ModNode::): (KJS::AddNode::): (KJS::SubNode::): (KJS::LeftShiftNode::): (KJS::RightShiftNode::): (KJS::UnsignedRightShiftNode::): (KJS::LessNode::): (KJS::GreaterNode::): (KJS::LessEqNode::): (KJS::GreaterEqNode::): (KJS::InstanceOfNode::): (KJS::InNode::): (KJS::EqualNode::): (KJS::NotEqualNode::): (KJS::StrictEqualNode::): (KJS::NotStrictEqualNode::): (KJS::BitAndNode::): (KJS::BitOrNode::): (KJS::BitXOrNode::): (KJS::LogicalAndNode::): (KJS::LogicalOrNode::): (KJS::ConditionalNode::): (KJS::ReadModifyResolveNode::): (KJS::AssignResolveNode::): (KJS::ReadModifyBracketNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::ReadModifyDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::VarDeclCommaNode::): (KJS::ConstStatementNode::): (KJS::SourceElements::SourceElements): (KJS::EmptyStatementNode::): (KJS::DebuggerStatementNode::): (KJS::ExprStatementNode::): (KJS::VarStatementNode::): (KJS::IfNode::): (KJS::IfElseNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::CaseBlockNode::): (KJS::SwitchNode::): Changed ParserRefCounted to hold a JSGlobalData pointer, and used it to replace threadInstance calls.

Jun 24, 2008:

11:34 PM Changeset in webkit [34790] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Alexey Proskuryakov.

Make the JavaScript shell collect the heap from main() instead of
jscmain() to suppress leak messages in debug builds.

  • kjs/Shell.cpp: (main): (jscmain):
9:35 PM Changeset in webkit [34789] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

WebCore:

2008-06-24 Anonymous

Reviewed by Darin Adler. Committed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=19470

Check for a null documentElement() to fix four crashes.

  • WebCore/dom/Document.cpp:
  • WebCore/dom/Node.cpp:

LayoutTests:

2008-06-24 Anonymous

Reviewed by Darin Adler. Committed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=19470

Check for a null documentElement() to fix four crashes.

  • LayoutTests/fast/dom/documentElement-null-expected.txt: Added.
  • LayoutTests/fast/dom/documentElement-null.html: Added.
9:32 PM Changeset in webkit [34788] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests/platform/mac/fast/parser

Fix png mime-type

9:14 PM Changeset in webkit [34787] by abarth@webkit.org
  • 3 edits
    12 adds in trunk

WebCore:

2008-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix <​https://bugs.webkit.org/show_bug.cgi?id=19597>

Correctly parse <!-- </textarea> --> inside a <textarea>, matching
Internet Explorer, Firefox, Opera, and HTML 5.

Tests: fast/parser/comment-in-script-tricky.html

fast/parser/comment-in-style.html
fast/parser/comment-in-textarea.html
fast/parser/comment-in-title.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial):

LayoutTests:

2008-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19597

Test that we correctly parse comments containing end tags in CDATA and
RCDATA contexts.

  • fast/parser/comment-in-script-tricky-expected.txt: Added.
  • fast/parser/comment-in-script-tricky.html: Added.
  • fast/parser/comment-in-style.html: Added.
  • fast/parser/comment-in-textarea.html: Added.
  • fast/parser/comment-in-title-expected.txt: Added.
  • fast/parser/comment-in-title.html: Added.
  • platform/mac/fast/parser/comment-in-style-expected.checksum: Added.
  • platform/mac/fast/parser/comment-in-style-expected.png: Added.
  • platform/mac/fast/parser/comment-in-style-expected.txt: Added.
  • platform/mac/fast/parser/comment-in-textarea-expected.checksum: Added.
  • platform/mac/fast/parser/comment-in-textarea-expected.png: Added.
  • platform/mac/fast/parser/comment-in-textarea-expected.txt: Added.
7:41 PM Changeset in webkit [34786] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

  • add another test using remote fonts to the Tiger skipped list
  • platform/mac-tiger/Skipped: Added fast/css/font-weight-1.html.
7:04 PM Changeset in webkit [34785] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

2008-06-24 Mark Rowe <​mrowe@apple.com>

Exclude the newly-added accessibilityController from the dumped window properties.

  • fast/dom/Window/window-properties.html:
5:41 PM Changeset in webkit [34784] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Make the conversion of the pair (less, jtrue) to jless use register
reference counting information for safety instead of requiring callers
to decide whether it is safe.

No changes on SunSpider codegen.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):
5:36 PM Changeset in webkit [34783] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Stephanie Lewis.

  • move the linker flags from the debug configuration in the project to the shared configuration
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
5:03 PM Changeset in webkit [34782] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • try to fix the Tiger build
  • DumpRenderTree/mac/AccessibilityControllerMac.mm:
4:03 PM Changeset in webkit [34781] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-06-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber stamped by Oliver.

Roll out r34777 due to multiple assertion failures on tests.

  • ChangeLog:
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrueMayCombine): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitJumpScopes):
  • VM/LabelID.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • VM/Opcode.h:
3:31 PM Changeset in webkit [34780] by justin.garcia@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

2008-06-24 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If asked to preserveStyle, we apply styles from the moved paragraph to the destination with applyStyle, which does selection preservation when it needs to apply block styles. Selection preservation uses relatively untested code in TextIterator to count VisiblePositions which fails in this particular test case because it doesn't handle changes in editability properly. We can avoid this bug by not applying block styles from moved paragraphs. This is something that should be done anyway, since the moved paragraph should assume the block styles of the destination.
  • editing/EditCommand.cpp: (WebCore::EditCommand::styleAtPosition): Added a FIXME about how it is misleading for this function to also include the typing style.
  • editing/TextIterator.h: Added a FIXME about how the code path used for selection preservation is buggy and should be phased out when we rewrite moveParagraphs.

LayoutTests:

2008-06-24 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John.

<rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo

  • editing/deleting/6026335-expected.txt: Added.
  • editing/deleting/6026335.html: Added.
2:30 PM Changeset in webkit [34779] by kmccullough@apple.com
  • 1 edit
    1 add in trunk/WebCore

2008-06-24 Kevin McCullough <​kmccullough@apple.com>

-Added a manual test for the profiler.

  • manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Added.
2:22 PM Changeset in webkit [34778] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-24 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6031594> JSProfiler: Profiler goes into an infinite
loop sometimes.
<rdar://problem/6031603> JSProfiler: Profiler asserts in debug and
give the wrong times in release

Fixed two issues found by Tim in the same test.

  • profiler/Profile.cpp: (KJS::Profile::removeProfileStart): No longer take profile's time from all ancestors, but instead attribute it to its parent. Also add an Assert to ensure we only delete the child we mean to. (KJS::Profile::removeProfileEnd): Ditto for profileEnd. (KJS::Profile::didExecute): Cleaned up the execution order and correctly attribute all of the parent's time to the new node.
  • profiler/ProfileNode.cpp: If this node does not have a startTime it should not get a giant total time, but instead be 0. (KJS::ProfileNode::endAndRecordCall):
  • profiler/ProfileNode.h: (KJS::ProfileNode::removeChild): Should reset the sibling pointers since one of them has been removed.
2:19 PM Changeset in webkit [34777] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Groundwork for reimplementing the slow script dialog

Reviewed by Cameron.

Add special loop opcodes as groundwork for slow script
termination. Also added a few assertions to prevent us
from accidentally coalescing conditional jump operands
in a way that might bypass the slow script opcodes.

2:02 PM Changeset in webkit [34776] by Beth Dakin
  • 9 edits
    6 adds in trunk

WebKitTools:

2008-06-24 Sam Weinig and Beth Dakin <Beth Dakin and ​sam@webkit.org>

Reviewed by Darin.

Fix for <rdar://problem/5884881> Make DumpRenderTree support
accessibility tests

This patch adds some basic support for accessibility layout tests
on the Mac.

  • DumpRenderTree/AccessibilityController.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (dumpCurrentAttributesCallback): (AccessibilityController::makeWindowObject): (AccessibilityController::getJSClass): (AccessibilityController::staticFunctions):
  • DumpRenderTree/AccessibilityController.h: Added.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: Added. (descriptionOfValue): (AccessibilityController::dumpCurrentAttributes):
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.h:
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate init]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):

LayoutTests:

2008-06-24 Sam Weinig and Beth Dakin <Beth Dakin and ​sam@webkit.org>

Reviewed by Darin.


First test for <rdar://problem/5884881> Make DumpRenderTree support
accessibility tests

  • accessibility: Added.
  • accessibility/document-attributes-expected.txt: Added.
  • accessibility/document-attributes.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:09 PM Changeset in webkit [34775] by weinig@apple.com
  • 7 edits
    7 adds in trunk

WebCore:

2008-06-24 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add support for loadstart, abort and error events for XMLHttpRequests.

Tests: http/tests/xmlhttprequest/onabort-event.html

http/tests/xmlhttprequest/onerror-event.html
http/tests/xmlhttprequest/onloadstart-event.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::onreadystatechange): (WebCore::JSXMLHttpRequest::onabort): (WebCore::JSXMLHttpRequest::setOnabort): (WebCore::JSXMLHttpRequest::onerror): (WebCore::JSXMLHttpRequest::setOnerror): (WebCore::JSXMLHttpRequest::onload): (WebCore::JSXMLHttpRequest::onloadstart): (WebCore::JSXMLHttpRequest::setOnloadstart): (WebCore::JSXMLHttpRequest::onprogress):
  • dom/EventNames.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::networkError): (WebCore::XMLHttpRequest::abortError): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::updateAndDispatchOnProgress): (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent): (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent): (WebCore::XMLHttpRequest::dispatchAbortEvent): (WebCore::XMLHttpRequest::dispatchErrorEvent): (WebCore::XMLHttpRequest::dispatchLoadEvent): (WebCore::XMLHttpRequest::dispatchLoadStartEvent): (WebCore::XMLHttpRequest::dispatchProgressEvent):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setOnAbortListener): (WebCore::XMLHttpRequest::onAbortListener): (WebCore::XMLHttpRequest::setOnErrorListener): (WebCore::XMLHttpRequest::onErrorListener): (WebCore::XMLHttpRequest::setOnLoadStartListener): (WebCore::XMLHttpRequest::onLoadStartListener):
  • xml/XMLHttpRequest.idl:

LayoutTests:

2008-06-24 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add tests for loadstart, abort and error events for XMLHttpRequests

  • http/tests/xmlhttprequest/onabort-event-expected.txt: Added.
  • http/tests/xmlhttprequest/onabort-event.html: Added.
  • http/tests/xmlhttprequest/onerror-event-expected.txt: Added.
  • http/tests/xmlhttprequest/onerror-event.html: Added.
  • http/tests/xmlhttprequest/onloadstart-event-expected.txt: Added.
  • http/tests/xmlhttprequest/onloadstart-event.html: Added.
  • http/tests/xmlhttprequest/resources/get.txt: Added.
1:03 PM Changeset in webkit [34774] by sullivan@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-24 John Sullivan <​sullivan@apple.com>

Reviewed by Dan Bernstein

  • Scripts/extract-localizable-strings: add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the list of debugging macros, to avoid noise when keeping the list of localized string exceptions up to date
1:00 PM Changeset in webkit [34773] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-06-24 Darin Adler <Darin Adler>

Reviewed by Cameron.

  • kjs/JSObject.cpp: (KJS::JSObject::put): Remove an untested optimization I checked in by accident. The two loops up the prototype chain both need to start from this; instead the second loop was starting where the first loop left off.
12:56 PM Changeset in webkit [34772] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-06-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/5957606>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::DocumentLoader::cancelPendingSubstituteLoad + 23

Remove the loader from the document loader after calling didFail, so that the loader will be deferred corectly
in case the call do didFail starts a new run loop.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didCancel):
12:54 PM Changeset in webkit [34771] by mitz@apple.com
  • 5 edits
    14 adds in trunk

WebKitTools:

Rubber-stamped by Darin Adler.

  • add a font family for testing font-weight
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker flags to create data sections for the WeightWatcher fonts.
  • DumpRenderTree/fonts: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
  • DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
  • DumpRenderTree/mac/DumpRenderTree.mm: (activateFonts): Renamed activateAhemFont to this and made it activate the WeightWatcher fonts in addition to Ahem. (prepareConsistentTestingEnvironment): Adjusted for the name change.
  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Added the WeightWatcher fonts.

LayoutTests:

Rubber-stamped by Darin Adler.

  • add font-weight test for a family that has 9 weights
  • fast/css/font-weight-1.html: Added.
  • platform/mac/fast/css/font-weight-1-expected.checksum: Added.
  • platform/mac/fast/css/font-weight-1-expected.png: Added.
  • platform/mac/fast/css/font-weight-1-expected.txt: Added.
12:50 PM Changeset in webkit [34770] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • kjs/nodes.cpp:
11:06 AM Changeset in webkit [34769] by sullivan@apple.com
  • 2 edits in trunk/WebKit

2008-06-24 John Sullivan <​sullivan@apple.com>

Rubber-stamped by Sam Weinig

  • StringsNotToBeLocalized.txt: brought this file up to date
8:43 AM Changeset in webkit [34768] by ap@webkit.org
  • 3 edits in trunk/WebCore

Release build fix.

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent): Initialize callbackCallType, as the compiler is not smart enough to figure out data flow.
7:33 AM Changeset in webkit [34767] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

2008-06-24 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

For the Qt build on Windows don't depend on the presence of GNU CPP
but use MSVC's preprocessor instead.
dftables accepts a --preprocessor option which is set in pcre.pri for MSVC platforms.

5:35 AM Changeset in webkit [34766] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19723
REGRESSION(r34648): Some SVG tests crash when running under --threaded

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::destroy): Do not attempt to paint during document destruction, because rendering structures are not kept in a consistent state then.
4:28 AM Changeset in webkit [34765] by Simon Hausmann
  • 6 edits in trunk/WebCore

2008-06-24 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19727

Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so
many times in Cairo and Qt ports.

3:58 AM Changeset in webkit [34764] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-24 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18459

Clean up and remove unused platform shadow code.

Minor edits by Simon, removed unused TextShadow struct.

3:35 AM Changeset in webkit [34763] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-06-24 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18459

Implemented basic text-shadow support for the Qt port.

3:27 AM Changeset in webkit [34762] by Simon Hausmann
  • 8 edits in trunk

Fix the Qt build, adapt to various JSCore API changes.

3:07 AM Changeset in webkit [34761] by ap@webkit.org
  • 3 edits in trunk/WebCore

Remove XMLHttpRequestProgressEvent.cpp from more project files.

  • GNUmakefile.am:
  • WebCore.pro:
2:51 AM Changeset in webkit [34760] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Cameron Zwarich.

Make ParserRefCountedCounter actually perform a leak check.

  • kjs/nodes.cpp: (KJS::ParserRefCountedCounter::~ParserRefCountedCounter): Check for leaks in destructor, not in constructor. (KJS::ParserRefCountedCounter::increment): (KJS::ParserRefCountedCounter::decrement): (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::~ParserRefCounted): While at it, also made counting thread-safe.
2:39 AM Changeset in webkit [34759] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-24 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

For the Qt port, fix linking with MinGW.

  • WebCore.pro:
2:38 AM Changeset in webkit [34758] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-06-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
<​https://bugs.webkit.org/show_bug.cgi?id=19730>

Do not convert the pair (less, jtrue) to jless when jtrue is a jump
target. An example of this is when the condition of a while loop is a
LogicalOrNode.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitLabel):

LayoutTests:

  • fast/js/codegen-loops-logical-nodes-expected.txt: Added.
  • fast/js/codegen-loops-logical-nodes.html: Added.
  • fast/js/resources/codegen-loops-logical-nodes.js: Added.
2:06 AM Changeset in webkit [34757] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

2008-06-20 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

Fix compile with MinGW.

  • kjs/Shell.cpp:
  • wtf/Threading.h: (WTF::atomicIncrement): (WTF::atomicDecrement):
Note: See TracTimeline for information about the timeline view.