⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 29, 2008:

11:17 PM Changeset in webkit [34883] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-06-29 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19821: Merge the instruction pair (less, jfalse)
<​https://bugs.webkit.org/show_bug.cgi?id=19821>

This is a 2.4% win on SunSpider. I needed to add an ALWAYS_INLINE
intrinisc to CodeGenerator::rewindBinaryOp() to avoid a massive
regression in regexp-dna.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJumpIfFalse):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
7:07 PM Changeset in webkit [34882] by dsmith@webkit.org
  • 2 edits in trunk/WebCore

2008-06-29 David Smith <​catfish.man@gmail.com>

Rubberstamped by Sam Weinig.

Change a redundant node->isElement() check to an ASSERT for a 1.3% speedup on getElementsByTagName.

  • dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches):
6:41 PM Changeset in webkit [34881] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix SVG layout test regressions
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Made this function work again with primitive values, because the @font-face rules SVG fonts create still use a single primitive value rather than a value list.
5:58 PM Changeset in webkit [34880] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2008-06-29 Dan Bernstein <​mitz@apple.com>

  • add a missing file from the last check-in
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Added.
5:31 PM Changeset in webkit [34879] by mitz@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5734440> Specifying a font-weight for @font-face not working

Tests: fast/css/font-face-descriptor-multiple-values-parsing.html

fast/css/font-face-descriptor-multiple-values.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to work with value lists for the descriptor properties.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Initialize m_hasFontFaceOnlyValues. (WebCore::CSSParser::parseValue): Added a call to deleteFontFaceOnlyValues() if necessary. (WebCore::CSSParser::parseDeclaration): Ditto. (WebCore::CSSParser::clearProperties): Added code to reset m_hasFontFaceOnlyValues to false. (WebCore::CSSParser::parseFontStyle): Added. If there is a single valid identifier other than 'all', creates a CSSPrimitiveValue and assigns it to the property. If 'all' is the only value, or if there are multiple valid identifiers that are not 'all', creates a CSSValueList and assigns it to the property, and sets m_hasFontFaceOnlyValues to true. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto. (WebCore::CSSParser::createStyleRule): Added a call to deleteFontFaceOnlyValues(). (WebCore::CSSParser::createFontFaceRule): Added code to change font descriptor properties that had only one value, and therefore were assigned a CSSPrimitiveValue, into CSSValueLists containing that value. (WebCore::CSSParser::deleteFontFaceOnlyValues): Added. Retroactively invalidates font descriptor properties that had values that are only allowed in @font-face. Those are identified by having CSSValueLists rather than CSSPrimitiveValues as their values.
  • css/CSSParser.h: Added m_hasFontFaceOnlyValues, a flag that says that font descriptor property values that are only valid in @font-face were encountered. This is used when the style declaration is created (and we finally know if it is @font-face or not) to delete invalid properties if needed.

LayoutTests:

Reviewed by Sam Weinig.

  • tests for <rdar://problem/5734440> Specifying a font-weight for @font-face not working
  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Added.
  • fast/css/font-face-descriptor-multiple-values-parsing.html: Added.
  • fast/css/font-face-descriptor-multiple-values.html: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.checksum: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Added.
3:22 PM Changeset in webkit [34878] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
3:18 PM Changeset in webkit [34877] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Build fix for Qt.

  • kjs/DateMath.cpp:
  • kjs/DatePrototype.cpp:
3:14 PM Changeset in webkit [34876] by weinig@apple.com
  • 20 edits
    8 copies
    2 moves in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Splits ErrorConstructor, ErrorPrototype, NativeErrorConstructor and
NativeErrorPrototype out of error_object.h/cpp and renames it ErrorInstance.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/DatePrototype.cpp:
  • kjs/ErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/ErrorInstance.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorInstance.h: Copied from kjs/error_object.h.
  • kjs/ErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
  • kjs/NativeErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/NativeErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/NumberPrototype.cpp:
  • kjs/RegExpConstructor.cpp:
  • kjs/RegExpObject.cpp:
  • kjs/RegExpPrototype.cpp:
  • kjs/StringPrototype.cpp:
  • kjs/error_object.cpp: Removed.
  • kjs/error_object.h: Removed.
  • kjs/internal.cpp:
3:02 PM Changeset in webkit [34875] by jchaffraix@webkit.org
  • 9 edits
    5 adds in branches/XBL2/WebCore

2008-06-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Add the <xbl> element. The hierarchy is inspired from svg:

  • XBLElement is the base class for all XBL elements.
  • XBLXBLElement represents the <xbl> element tag.
  • DerivedSources.make: Added build system information.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::createElement): Create XBL elements if we are in XBL namespace.
  • dom/Node.h: (WebCore::Node::isXBLElement):
  • dom/make_names.pl:
  • page/Frame.cpp: (WebCore::Frame::Frame): Added XBLNames structures initialization.
  • xbl: Added.
  • xbl/XBLElement.h: Added. (WebCore::XBLElement::XBLElement): (WebCore::XBLElement::isXBLElement):
  • xbl/XBLXBLElement.cpp: Added.
  • xbl/XBLXBLElement.h: Added. (WebCore::XBLXBLElement::XBLXBLElement):
  • xbl/xbltags.in: Added.
1:25 PM Changeset in webkit [34874] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix Tiger build.

  • DumpRenderTree/mac/EventSendingController.mm: (eventTypeForMouseButtonAndAction):
1:21 PM Changeset in webkit [34873] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne build.

  • kjs/DateConstructor.cpp:
  • kjs/DateMath.cpp:
  • kjs/JSObject.cpp:
12:53 PM Changeset in webkit [34872] by weinig@apple.com
  • 15 edits
    4 copies in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits DateConstructor and DatePrototype out of date_object.h/cpp
Moves shared Date code into DateMath.

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateConstructor.h: Copied from kjs/date_object.h.
  • kjs/DateMath.cpp: (KJS::ymdhmsToSeconds): (KJS::): (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate): (KJS::timeClip): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime):
  • kjs/DateMath.h: (KJS::gmtoffset):
  • kjs/DatePrototype.cpp: Copied from kjs/date_object.cpp.
  • kjs/DatePrototype.h: Copied from kjs/date_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/internal.cpp:
12:24 PM Changeset in webkit [34871] by eric@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by darin.

Add multi-button mouseevent support to DRT
​https://bugs.webkit.org/show_bug.cgi?id=15173

It's now possible to specify the mouse button with:
eventSender.mouseDown(1); eventSender.mouseUp(1); etc.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/EventSendingController.h:
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (eventTypeForMouseButtonAndAction): (-[EventSendingController updateClickCountForButton:]): (-[EventSendingController mouseDown:]): (-[EventSendingController mouseUp:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
1:19 AM Changeset in webkit [34870] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Cameron Zwarich

Fix Gtk non-AllInOne build

  • GNUmakefile.am: include JSVariableObject.cpp
  • kjs/RegExpConstructor.cpp: include RegExpObject.h
  • kjs/RegExpObject.h: forward declare RegExpPrototype

Jun 28, 2008:

10:56 PM Changeset in webkit [34869] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-06-28 Darin Adler <Darin Adler>

  • fix build
  • WebView/WebView.mm: (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
10:38 PM Changeset in webkit [34868] by Darin Adler
  • 8 edits
    3 adds in trunk

JavaScriptCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

Test: fast/js/array-holes.html

  • kjs/ArrayPrototype.cpp: (KJS::arrayProtoFuncConcat): Changed to use getProperty instead of JSArray::getItem -- need to handle properties from the prototype chain instead of ignoring them.
  • kjs/JSArray.cpp: Removed getItem.
  • kjs/JSArray.h: Ditto.

WebCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

  • bridge/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): Use get instead of getItem, since we always want to consider values from the prototypes when looking at JavaScript arrays.

LayoutTests:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

  • fast/js/array-holes-expected.txt: Added.
  • fast/js/array-holes.html: Added.
  • fast/js/resources/array-holes.js: Added.
8:56 PM Changeset in webkit [34867] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Cameron.

SunSpider says 1.8% faster.

  • kjs/JSArray.cpp: (KJS::JSArray::JSArray): Initialize m_fastAccessCutoff when creating arrays. Also updated for new location of m_vectorLength. (KJS::JSArray::getItem): Updated for new location of m_vectorLength. (KJS::JSArray::getSlowCase): Added. Broke out the non-hot parts of getOwnPropertySlot to make the hot part faster. (KJS::JSArray::getOwnPropertySlot): Added a new faster case for indices lower than m_fastAccessCutoff. We can do theese with no additional checks or branches. (KJS::JSArray::put): Added a new faster case for indices lower than m_fastAccessCutoff. We can do theese with no additional checks or branches. Moved the maxArrayIndex handling out of this function. Added code to set m_fastAccessCutoff when the very last hole in an array is filled; this is how the cutoff gets set for most arrays. (KJS::JSArray::putSlowCase): Moved the rest of the put function logic in here, to make the hot part of the put function faster. (KJS::JSArray::deleteProperty): Added code to lower m_fastAccessCutoff when a delete makes a new hole in the array. (KJS::JSArray::getPropertyNames): Updated for new location of m_vectorLength. (KJS::JSArray::increaseVectorLength): Ditto. (KJS::JSArray::setLength): Added code to lower m_fastAccessCutoff when setLength makes the array smaller. (KJS::JSArray::mark): Updated for new location of m_vectorLength. (KJS::JSArray::sort): Ditto. Set m_fastAccessCutoff after moving all the holes to the end of the array. (KJS::JSArray::compactForSorting): Ditto. (KJS::JSArray::checkConsistency): Added consistency checks fro m_fastAccessCutoff and updated for the new location of m_vectorLength.
  • kjs/JSArray.h: Added declarations for slow case functions. Replaced m_vectorLength with m_fastAccessCutoff.
7:33 PM Changeset in webkit [34866] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-06-28 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Sam.

When executing a native call, check for an exception before writing the
return value.

JavaScriptCore:

  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

  • fast/js/exception-sequencing-expected.txt:
  • fast/js/exception-sequencing.html:
7:21 PM Changeset in webkit [34865] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Mark Rowe <​mrowe@apple.com>

Build fix. Flag headers as private or public as is appropriate.
These settings were accidentally removed during some project file cleanup.

5:44 PM Changeset in webkit [34864] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • allow document markers to touch or overlap if they are not of the same type

Cannot be tested in DumpRenderTree

  • dom/Document.cpp: (WebCore::Document::addMarker):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDocumentMarkers):
5:09 PM Changeset in webkit [34863] by weinig@apple.com
  • 14 edits
    4 copies in trunk/JavaScriptCore

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Splits RegExpConstructor and RegExpPrototype out of RegExpObject.h/cpp

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/RegExpConstructor.cpp: Copied from kjs/RegExpObject.cpp.
  • kjs/RegExpConstructor.h: Copied from kjs/RegExpObject.h.
  • kjs/RegExpObject.cpp:
  • kjs/RegExpObject.h:
  • kjs/RegExpPrototype.cpp: Copied from kjs/RegExpObject.cpp.
  • kjs/RegExpPrototype.h: Copied from kjs/RegExpObject.h.
  • kjs/StringPrototype.cpp:
  • kjs/internal.cpp:
4:44 PM Changeset in webkit [34862] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/StringConstructor.cpp:
4:30 PM Changeset in webkit [34861] by weinig@apple.com
  • 12 edits
    5 copies
    3 moves
    2 adds in trunk

JavaScriptCore:

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Rename string_object.h/cpp to StringObject.h/cpp and split out StringObjectThatMasqueradesAsUndefined,
StringConstructor and StringPrototype.

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/StringConstructor.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringConstructor.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringObject.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringObject.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringObjectThatMasqueradesAsUndefined.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringPrototype.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringPrototype.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/internal.cpp:
  • kjs/string_object.cpp: Removed.
  • kjs/string_object.h: Removed.

WebCore:

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Update includes after remaming string_object.h to StringObject.h and
splitting out StringObjectThatMasqueradesAsUndefined, StringConstructor
and StringPrototype.

  • ForwardingHeaders/kjs/StringObject.h: Copied from WebCore/ForwardingHeaders/kjs/string_object.h.
  • ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Added.
  • ForwardingHeaders/kjs/StringPrototype.h: Added.
  • ForwardingHeaders/kjs/string_object.h: Removed.
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
3:57 PM Changeset in webkit [34860] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix: JSVariableObject is now part of AllInOne

  • GNUmakefile.am:
3:22 PM Changeset in webkit [34859] by jchaffraix@webkit.org
  • 17 edits in branches/XBL2/WebCore

2008-06-27 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Change XBL legacy code's guard to ENABLE(DEPRECATED_XBL)
to enable compilation.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • dom/Document.h:
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
  • loader/loader.cpp: (WebCore::Loader::determinePriority):
  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/RenderStyle.h:
3:21 PM Changeset in webkit [34858] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

  • pcre/pcre_compile.cpp: (jsRegExpCompile): Compile in the string if REGEXP_HISTOGRAM is on.
  • pcre/pcre_exec.cpp: (jsRegExpExecute): Add hook to time execution. (Histogram::~Histogram): Print a sorted list of what took time. (Histogram::add): Accumulate records of what took time. (HistogramTimeLogger::~HistogramTimeLogger): Hook that calls Histogram::add at the right moment and creates the global histogram object.
  • pcre/pcre_internal.h: Define REGEXP_HISTOGRAM.
  • pcre/pcre_tables.cpp: Added missing include of "config.h". Not needed any more, but an omissions an earlier version of this patch detected.
  • pcre/pcre_ucp_searchfuncs.cpp: Ditto.
  • pcre/pcre_xclass.cpp: Ditto.
2:54 PM Changeset in webkit [34857] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <​sam@webkit.org>

Try and fix the Windows build again.

  • kjs/RegExpObject.cpp:
  • kjs/date_object.cpp:
  • kjs/error_object.cpp:
2:45 PM Changeset in webkit [34856] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove unused StringConstructorFunction class.

  • kjs/string_object.h:
2:40 PM Changeset in webkit [34855] by weinig@apple.com
  • 14 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <​sam@webkit.org>

Fix windows build.

  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/BooleanPrototype.h:
  • kjs/FunctionPrototype.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/JSObject.cpp:
  • kjs/MathObject.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/NumberPrototype.h:
  • kjs/ObjectConstructor.cpp:
  • kjs/RegExpObject.h:
  • kjs/error_object.h:
  • kjs/string_object.cpp:
2:22 PM Changeset in webkit [34854] by weinig@apple.com
  • 32 edits
    8 copies
    3 moves
    1 add in trunk

JavaScriptCore:

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits FunctionConstructor out of FunctionPrototype.h/cpp
Splits NumberConstructor and NumberPrototype out of NumberObject.h/cpp
Rename object_object.h/cpp to ObjectPrototype.h/cpp and split out ObjectConstructor.

  • API/JSCallbackConstructor.cpp:
  • API/JSClassRef.cpp:
  • API/JSObjectRef.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayConstructor.h:
  • kjs/FunctionConstructor.cpp: Copied from JavaScriptCore/kjs/FunctionPrototype.cpp.
  • kjs/FunctionConstructor.h: Copied from JavaScriptCore/kjs/FunctionPrototype.h.
  • kjs/FunctionPrototype.cpp:
  • kjs/FunctionPrototype.h:
  • kjs/JSFunction.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/MathObject.h:
  • kjs/NumberConstructor.cpp: Copied from JavaScriptCore/kjs/NumberObject.cpp.
  • kjs/NumberConstructor.h: Copied from JavaScriptCore/kjs/NumberObject.h.
  • kjs/NumberObject.cpp:
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.cpp: Copied from JavaScriptCore/kjs/NumberObject.cpp.
  • kjs/NumberPrototype.h: Copied from JavaScriptCore/kjs/NumberObject.h.
  • kjs/ObjectConstructor.cpp: Copied from JavaScriptCore/kjs/object_object.cpp.
  • kjs/ObjectConstructor.h: Copied from JavaScriptCore/kjs/object_object.h.
  • kjs/ObjectPrototype.cpp: Copied from JavaScriptCore/kjs/object_object.cpp.
  • kjs/ObjectPrototype.h: Copied from JavaScriptCore/kjs/object_object.h.
  • kjs/RegExpObject.h:
  • kjs/Shell.cpp:
  • kjs/error_object.h:
  • kjs/internal.cpp:
  • kjs/nodes.cpp:
  • kjs/object_object.cpp: Removed.
  • kjs/object_object.h: Removed.
  • kjs/string_object.h:

WebCore:

2008-06-28 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update includes after remaming object_object.h to ObjectPrototype.h and
splitting FunctionConstructor out of FunctionPrototype.h

  • ForwardingHeaders/kjs/FunctionConstructor.h: Added.
  • ForwardingHeaders/kjs/ObjectPrototype.h: Copied from WebCore/ForwardingHeaders/kjs/object_object.h.
  • ForwardingHeaders/kjs/object_object.h: Removed.
  • bindings/js/JSEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp:
2:11 PM Applications using WebKit edited by bug@insecti.com
new browser this year! (diff)
1:24 PM SquirrelFishPerfIdeas edited by erich@atlasocean.com
(diff)
10:49 AM Changeset in webkit [34853] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5994621> REGRESSION (r31090-r31114): Weather widget shows missing image icons briefly when (re)loaded
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Changed to not load an image if the 'src' attribute is the empty string and the document's base URI is a file: URL.

LayoutTests:

Reviewed by Darin Adler.

  • updated test and results for <rdar://problem/5994621> REGRESSION (r31090-r31114): Weather widget shows missing image icons briefly when (re)loaded
  • fast/images/load-img-with-empty-src-expected.txt:
  • fast/images/load-img-with-empty-src.html:
9:03 AM Changeset in webkit [34852] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

SunSpider says 0.9% faster.

  • VM/CodeGenerator.h: (KJS::CodeGenerator::tempDestination): Create a new temporary for ignoredResult() too, just as we would for 0. (KJS::CodeGenerator::finalDestination): Use the temporary if the register passed in is ignoredResult() too, just as we would for 0. (KJS::CodeGenerator::destinationForAssignResult): Return 0 if the passed in register is ignoredResult(), just as we would for 0. (KJS::CodeGenerator::moveToDestinationIfNeeded): Return 0 if the register passed in is ignoredResult(). What matters is that we don't want to emit a move. The return value won't be looked at. (KJS::CodeGenerator::emitNode): Allow ignoredResult() and pass it through to the node's emitCode function.
  • VM/RegisterID.h: (KJS::ignoredResult): Added. Special value to indicate the result of a node will be ignored and need not be put in any register.
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): Do nothing if dst == ignoredResult(). (KJS::BooleanNode::emitCode): Ditto. (KJS::NumberNode::emitCode): Ditto. (KJS::StringNode::emitCode): Ditto. (KJS::RegExpNode::emitCode): Ditto. (KJS::ThisNode::emitCode): Ditto. (KJS::ResolveNode::emitCode): Do nothing if dst == ignoredResult() and the identifier resolves to a local variable. (KJS::ObjectLiteralNode::emitCode): Do nothing if dst == ignoredResult() and the object is empty. (KJS::PostIncResolveNode::emitCode): If dst == ignoredResult(), then do nothing for the local constant case, and do a pre-increment in all the other cases. (KJS::PostDecResolveNode::emitCode): Ditto. (KJS::PostIncBracketNode::emitCode): Ditto. (KJS::PostDecBracketNode::emitCode): Ditto. (KJS::PostIncDotNode::emitCode): Ditto. (KJS::PostDecDotNode::emitCode): Ditto. (KJS::DeleteValueNode::emitCode): Pass ignoredResult() when evaluating the expression. (KJS::VoidNode::emitCode): Ditto. (KJS::TypeOfResolveNode::emitCode): If dst == ignoredResult(), do nothing if the identifier resolves to a local variable, and don't bother generating a typeof opcode in the other case. (KJS::TypeOfValueNode::emitCode): Ditto. (KJS::PreIncResolveNode::emitCode): Do nothing if dst == ignoredResult() and the identifier resolves to a local constant. (KJS::PreDecResolveNode::emitCode): Ditto. (KJS::AssignResolveNode::emitCode): Turn ignoredResult() into 0 in a couple places, because we need to put the result into a register so we can assign it. At other sites this is taken care of by functions like finalDestination. (KJS::CommaNode::emitCode): Pass ignoredResult() when evaluating the first expression. (KJS::ForNode::emitCode): Pass ignoredResult() when evaluating the first and third expressions. (KJS::ForInNode::emitCode): Pass ignoredResult() when evaluating the first expression.
8:50 AM Changeset in webkit [34851] by Darin Adler
  • 7 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

SunSpider says 0.8% faster.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Added argv and argc parameters to new_array.
  • VM/Machine.cpp: (KJS::Machine::privateExecute): Ditto.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitNewArray): Added.
  • VM/CodeGenerator.h: Added ElementNode* argument to emitNewArray.
  • kjs/nodes.cpp: (KJS::ArrayNode::emitCode): Pass the ElementNode to emitNewArray so it can be initialized with as many elements as possible. If the array doesn't have any holes in it, that's all that's needed. If there are holes, then emit some separate put operations for the other values in the array and for the length as needed.
  • kjs/nodes.h: Added some accessors to ElementNode so the code generator can iterate through elements and generate code to evaluate them. Now ArrayNode does not need to be a friend. Also took out some unused PlacementNewAdoptType constructors.
8:33 AM Changeset in webkit [34850] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

  • kjs/nodes.h: Remove obsolete PlacementNewAdopt constructors. We no longer mutate the AST in place.
3:48 AM Changeset in webkit [34849] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Build fix

  • VM/Machine.cpp: include stdio.h
3:47 AM Changeset in webkit [34848] by Nikolas Zimmermann
  • 79 edits
    6 moves
    29 adds in trunk/LayoutTests

Reviewed by Oliver.

Update all (except four) SVG pixel tests, after a long time.
Four tests are broken in trunk, filed bugs 19798 & 19799.

Add all missing png/checksum files, and move files around which were misplaced.

3:23 AM Changeset in webkit [34847] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

Copy <test>-expected.png from the right location to /tmp/layout-test-results.
Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.

12:17 AM Changeset in webkit [34846] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.

  • make a test valid
  • fast/images/load-img-with-empty-src.html: Renamed the "status" variable to "results", because "status" is a Window property.
Note: See TracTimeline for information about the timeline view.