⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 30, 2008:

10:45 PM Changeset in webkit [34906] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.


SunSpider says 0.8% faster.

7:49 PM Changeset in webkit [34905] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.

Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

Test: fast/forms/search-hidden-cancel-button.html

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Don't start capturing mouse events if the cancel button isn't visible. This was causing the button to start but never stop capturing mouse events.

LayoutTests:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.

Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

  • fast/forms/search-hidden-cancel-button-expected.txt: Added.
  • fast/forms/search-hidden-cancel-button.html: Added.
7:21 PM Changeset in webkit [34904] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Fix build by adding all (hopefully) the missing includes.

6:56 PM Changeset in webkit [34903] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-06-30 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar
<​https://bugs.webkit.org/show_bug.cgi?id=19830>

Ensure that we do not eliminate a write to a local register when doing
peephole optimizations.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse):

LayoutTests:

  • fast/js/codegen-peephole-locals-expected.txt: Added.
  • fast/js/codegen-peephole-locals.html: Added.
  • fast/js/resources/codegen-peephole-locals.js: Added.
6:18 PM Changeset in webkit [34902] by adele@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Fixing * placement

6:11 PM Changeset in webkit [34901] by weinig@apple.com
  • 19 edits
    1 copy
    1 add in trunk

JavaScriptCore:

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Alder.

Split InternalFunction into its own header file.

  • API/JSCallbackFunction.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/ArrayConstructor.h:
  • kjs/BooleanConstructor.h:
  • kjs/DateConstructor.h:
  • kjs/ErrorConstructor.h:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
  • kjs/JSFunction.h:
  • kjs/NativeErrorConstructor.h:
  • kjs/NumberConstructor.h:
  • kjs/ObjectConstructor.h:
  • kjs/RegExpConstructor.h:
  • kjs/StringConstructor.h:
  • profiler/Profiler.cpp:

WebCore:

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Split InternalFunction into its own header file.

  • ForwardingHeaders/kjs/InternalFunction.h: Added.
  • bridge/runtime_method.h:
5:47 PM Changeset in webkit [34900] by adele@apple.com
  • 11 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Anders.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Test: editing/selection/select-all-textarea.html

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function. (WebCore::Node::shadowTreeRootNode): Added helper function.
  • dom/Node.h:
  • dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
  • dom/Range.h:
  • editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
  • editing/Selection.h:
  • editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
  • page/Frame.cpp: (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions. (WebCore::Frame::markAllMatchesForText): ditto.

LayoutTests:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Anders.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • editing/selection/select-all-textarea-expected.txt: Added.
  • editing/selection/select-all-textarea.html: Added.
4:05 PM Changeset in webkit [34899] by Chris Fleizach
  • 12 edits
    4 adds in trunk

<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

3:52 PM Changeset in webkit [34898] by weinig@apple.com
  • 5 edits
    4 deletes in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Reviewed by Kevin McCullough.

Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Instruction.cpp: Removed.
  • VM/LabelID.cpp: Removed.
  • VM/Register.cpp: Removed.
  • VM/RegisterID.cpp: Removed.
3:43 PM Changeset in webkit [34897] by weinig@apple.com
  • 10 edits
    2 moves in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped (reluctantly) by Kevin McCullough.

Rename date_object.h/cpp to DateInstance.h/cpp

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateInstance.h: Copied from kjs/date_object.h.
  • kjs/DatePrototype.cpp:
  • kjs/DatePrototype.h:
  • kjs/date_object.cpp: Removed.
  • kjs/date_object.h: Removed.
3:10 PM Changeset in webkit [34896] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Adele Peterson.

  • WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added Frame::setSelectionBaseWritingDirection().
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to call Frame::setSelectionBaseWritingDirection().
  • page/Frame.cpp: (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the focused node is a text field or text area, changes its 'dir' attribute. This is what IE does when the user changes the writing direction in a text control. Otherwise, calls down to Editor::setBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Adele Peterson.

  • WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call WebCore::Frame::setSelectionBaseWritingDirection() instead of WebCore::Editor::setBaseWritingDirection(). (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
2:12 PM Changeset in webkit [34895] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Improve HTMLObjectElement data encapsulation

Reviewed by Dave Hyatt.

HTMLObjectElement has some public member variables that should be
private with accessor methods.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder initialization of member variables to match defined order in header.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::classId): Added. (WebCore::HTMLObjectElement::url): Added. (WebCore::HTMLObjectElement::serviceType): Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Use new accessor methods in HTMLObjectElement now that its member variables are private.
2:09 PM Changeset in webkit [34894] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • remove unused member variable
  • page/Page.h: Removed Page::m_focusedNode.
1:52 PM Changeset in webkit [34893] by weinig@apple.com
  • 10 edits
    4 copies
    1 move in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove internal.cpp and move its contents to there own .cpp files.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
  • kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
  • kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.h:
  • kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
  • kjs/NumberConstructor.cpp:
  • kjs/NumberObject.cpp: (KJS::constructNumber): (KJS::constructNumberFromImmediateNumber):
  • kjs/internal.cpp: Removed.
10:00 AM Changeset in webkit [34892] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-06-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6014209>
Crash when loading manifest from application cache fails


There is no need to set any handles to 0 after calling cacheUpdateFailed(), since
that is done inside the function. Furthermore, after calling cacheUpdateFailed() the cache
group could be deleted causing us to access freed memory and then crashing.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didFailToLoadManifest):
8:58 AM Changeset in webkit [34891] by Adam Roben
  • 13 edits in trunk

Fix <rdar://5954749> Assertion failure due to HashTable's use of operator&

JavaScriptCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

HashTable was passing &value to constructDeletedValue, which in
classes like WebCore::COMPtr would cause an assertion. We now pass
value by reference instead of by address so that the HashTraits
implementations have more flexibility in constructing the deleted
value.

Reviewed by Ada Chan.

  • VM/CodeGenerator.h: Updated for changes to HashTraits.
  • wtf/HashTable.h: (WTF::::deleteBucket): Changed to pass bucket by reference instead of by address. (WTF::::checkKey): Ditto.
  • wtf/HashTraits.h: (WTF::): Updated HashTraits for HashTable change.

WebCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

Reviewed by Ada Chan.

  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/StyledElement.cpp:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • platform/text/StringHash.h:
  • platform/win/COMPtr.h:
  • svg/SVGAnimatedTemplate.h: Updated all custom HashTraits for HashTable changes.
8:10 AM Changeset in webkit [34890] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

8:09 AM Changeset in webkit [34889] by mrowe@apple.com
  • 1 copy in tags/Safari-6527

New tag.

4:37 AM Changeset in webkit [34888] by Simon Hausmann
  • 1 edit
    14 deletes in trunk/WebKit/qt

2008-06-30 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Niko.

Removed the obsolete and unmaintained WebKitPart. The integration of
QtWebKit into KDE is now done in the webkitkde component inside KDE.

4:28 AM Changeset in webkit [34887] by Nikolas Zimmermann
  • 113 edits in trunk/LayoutTests

Reviewed by Antti.

Fix all existing tests in svg/dynamic-updates to actually reflect repainting changes, by
removing the timing dependency. Instead model them like frame-getSVGDocument.html by
not including the <script src="js-test-post.js"> element within the TEMPLATE.html but
by dynamically injecting it, if the test actually finished.

4:21 AM Changeset in webkit [34886] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Cameron Zwarich.

Make RegisterFile really unmap memory on destruction.

This fixes run-webkit-tests --threaded, which ran out of address space in a few seconds.

  • VM/RegisterFile.cpp: (KJS::RegisterFile::~RegisterFile): Unmap all the memory, not just 1/4 of it.
  • kjs/JSGlobalObject.h: Don't include RegisterFile.h, so that changes to it don't make half of WebCore rebuild.
  • VM/Machine.h: Don't forward declare RegisterFile, as RegisterFile.h is included already.
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Assert that the allocation succeeded.
2:38 AM Changeset in webkit [34885] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-30 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver.

Correct the documentation for op_put_by_index.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
1:09 AM Changeset in webkit [34884] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-30 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

Added missing includes and changed getItem array calls to use get()
instead.

Jun 29, 2008:

11:17 PM Changeset in webkit [34883] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-06-29 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19821: Merge the instruction pair (less, jfalse)
<​https://bugs.webkit.org/show_bug.cgi?id=19821>

This is a 2.4% win on SunSpider. I needed to add an ALWAYS_INLINE
intrinisc to CodeGenerator::rewindBinaryOp() to avoid a massive
regression in regexp-dna.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJumpIfFalse):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
7:07 PM Changeset in webkit [34882] by dsmith@webkit.org
  • 2 edits in trunk/WebCore

2008-06-29 David Smith <​catfish.man@gmail.com>

Rubberstamped by Sam Weinig.

Change a redundant node->isElement() check to an ASSERT for a 1.3% speedup on getElementsByTagName.

  • dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches):
6:41 PM Changeset in webkit [34881] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix SVG layout test regressions
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Made this function work again with primitive values, because the @font-face rules SVG fonts create still use a single primitive value rather than a value list.
5:58 PM Changeset in webkit [34880] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2008-06-29 Dan Bernstein <​mitz@apple.com>

  • add a missing file from the last check-in
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Added.
5:31 PM Changeset in webkit [34879] by mitz@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5734440> Specifying a font-weight for @font-face not working

Tests: fast/css/font-face-descriptor-multiple-values-parsing.html

fast/css/font-face-descriptor-multiple-values.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to work with value lists for the descriptor properties.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Initialize m_hasFontFaceOnlyValues. (WebCore::CSSParser::parseValue): Added a call to deleteFontFaceOnlyValues() if necessary. (WebCore::CSSParser::parseDeclaration): Ditto. (WebCore::CSSParser::clearProperties): Added code to reset m_hasFontFaceOnlyValues to false. (WebCore::CSSParser::parseFontStyle): Added. If there is a single valid identifier other than 'all', creates a CSSPrimitiveValue and assigns it to the property. If 'all' is the only value, or if there are multiple valid identifiers that are not 'all', creates a CSSValueList and assigns it to the property, and sets m_hasFontFaceOnlyValues to true. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto. (WebCore::CSSParser::createStyleRule): Added a call to deleteFontFaceOnlyValues(). (WebCore::CSSParser::createFontFaceRule): Added code to change font descriptor properties that had only one value, and therefore were assigned a CSSPrimitiveValue, into CSSValueLists containing that value. (WebCore::CSSParser::deleteFontFaceOnlyValues): Added. Retroactively invalidates font descriptor properties that had values that are only allowed in @font-face. Those are identified by having CSSValueLists rather than CSSPrimitiveValues as their values.
  • css/CSSParser.h: Added m_hasFontFaceOnlyValues, a flag that says that font descriptor property values that are only valid in @font-face were encountered. This is used when the style declaration is created (and we finally know if it is @font-face or not) to delete invalid properties if needed.

LayoutTests:

Reviewed by Sam Weinig.

  • tests for <rdar://problem/5734440> Specifying a font-weight for @font-face not working
  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Added.
  • fast/css/font-face-descriptor-multiple-values-parsing.html: Added.
  • fast/css/font-face-descriptor-multiple-values.html: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.checksum: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Added.
3:22 PM Changeset in webkit [34878] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
3:18 PM Changeset in webkit [34877] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Build fix for Qt.

  • kjs/DateMath.cpp:
  • kjs/DatePrototype.cpp:
3:14 PM Changeset in webkit [34876] by weinig@apple.com
  • 20 edits
    8 copies
    2 moves in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Splits ErrorConstructor, ErrorPrototype, NativeErrorConstructor and
NativeErrorPrototype out of error_object.h/cpp and renames it ErrorInstance.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/DatePrototype.cpp:
  • kjs/ErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/ErrorInstance.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorInstance.h: Copied from kjs/error_object.h.
  • kjs/ErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
  • kjs/NativeErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/NativeErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/NumberPrototype.cpp:
  • kjs/RegExpConstructor.cpp:
  • kjs/RegExpObject.cpp:
  • kjs/RegExpPrototype.cpp:
  • kjs/StringPrototype.cpp:
  • kjs/error_object.cpp: Removed.
  • kjs/error_object.h: Removed.
  • kjs/internal.cpp:
3:02 PM Changeset in webkit [34875] by jchaffraix@webkit.org
  • 9 edits
    5 adds in branches/XBL2/WebCore

2008-06-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Add the <xbl> element. The hierarchy is inspired from svg:

  • XBLElement is the base class for all XBL elements.
  • XBLXBLElement represents the <xbl> element tag.
  • DerivedSources.make: Added build system information.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::createElement): Create XBL elements if we are in XBL namespace.
  • dom/Node.h: (WebCore::Node::isXBLElement):
  • dom/make_names.pl:
  • page/Frame.cpp: (WebCore::Frame::Frame): Added XBLNames structures initialization.
  • xbl: Added.
  • xbl/XBLElement.h: Added. (WebCore::XBLElement::XBLElement): (WebCore::XBLElement::isXBLElement):
  • xbl/XBLXBLElement.cpp: Added.
  • xbl/XBLXBLElement.h: Added. (WebCore::XBLXBLElement::XBLXBLElement):
  • xbl/xbltags.in: Added.
1:25 PM Changeset in webkit [34874] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix Tiger build.

  • DumpRenderTree/mac/EventSendingController.mm: (eventTypeForMouseButtonAndAction):
1:21 PM Changeset in webkit [34873] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne build.

  • kjs/DateConstructor.cpp:
  • kjs/DateMath.cpp:
  • kjs/JSObject.cpp:
12:53 PM Changeset in webkit [34872] by weinig@apple.com
  • 15 edits
    4 copies in trunk/JavaScriptCore

2008-06-29 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits DateConstructor and DatePrototype out of date_object.h/cpp
Moves shared Date code into DateMath.

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateConstructor.h: Copied from kjs/date_object.h.
  • kjs/DateMath.cpp: (KJS::ymdhmsToSeconds): (KJS::): (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate): (KJS::timeClip): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime):
  • kjs/DateMath.h: (KJS::gmtoffset):
  • kjs/DatePrototype.cpp: Copied from kjs/date_object.cpp.
  • kjs/DatePrototype.h: Copied from kjs/date_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/internal.cpp:
12:24 PM Changeset in webkit [34871] by eric@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by darin.

Add multi-button mouseevent support to DRT
​https://bugs.webkit.org/show_bug.cgi?id=15173

It's now possible to specify the mouse button with:
eventSender.mouseDown(1); eventSender.mouseUp(1); etc.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/EventSendingController.h:
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (eventTypeForMouseButtonAndAction): (-[EventSendingController updateClickCountForButton:]): (-[EventSendingController mouseDown:]): (-[EventSendingController mouseUp:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
1:19 AM Changeset in webkit [34870] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Cameron Zwarich

Fix Gtk non-AllInOne build

  • GNUmakefile.am: include JSVariableObject.cpp
  • kjs/RegExpConstructor.cpp: include RegExpObject.h
  • kjs/RegExpObject.h: forward declare RegExpPrototype
Note: See TracTimeline for information about the timeline view.