⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 1, 2008:

11:35 PM Changeset in webkit [34946] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19834
Failed assertion in JavaScriptCore/VM/SegmentedVector.h:82

Creating a global object with a custom prototype resets it twice (wasteful!).
So, addStaticGlobals() was called twice, but JSGlobalObject::reset() didn't reset
the register array.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Call setRegisterArray(0, 0).
  • kjs/JSVariableObject.h: Changed registerArray to OwnArrayPtr. Also, added private copy constructor and operator= to ensure that no one attempts to copy this object (for whatever reason, I couldn't make Noncopyable work).
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals): Allocate registerArray with new[].
  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::copyRegisterArray): Allocate registerArray with new[]. (KJS::JSVariableObject::setRegisterArray): Avoid hitting an assertion in OwnArrayPtr when "changing" the value from 0 to 0.
10:39 PM Changeset in webkit [34945] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed and/or reordered exception checks in array-style a[n] access.


SunSpider says 1.4% faster.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): No need to check for exceptions before calling toString, toNumber and/or get. If the call ends up being observable through toString, valueOf, or a getter, we short-circuit it there, instead. In the op_del_by_val case, I removed the incorrect comment without actually removing the code, since I didn't want to tempt the GCC fates!
  • kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Added exception check to prevent toString and valueOf functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.

(KJS::JSObject::defaultValue): Removed redundant exception check here.

  • kjs/PropertySlot.cpp: (KJS::PropertySlot::functionGetter): Added exception check to prevent getter functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.
9:28 PM Changeset in webkit [34944] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix a CSSParserValueList leak seen on the build bot
  • css/CSSParser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
9:21 PM Changeset in webkit [34943] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized a[n] get and put for cases where n is an immediate unsigned
value.


SunSpider says 3.5% faster.

8:27 PM Changeset in webkit [34942] by oliver@apple.com
  • 2 edits
    5 adds in trunk/WebCore

2008-07-01 Alex Mathews <​possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Prep for more Filter class name changes. Added the first few files for
the new Filter architecture to come.

7:12 PM Changeset in webkit [34941] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Update the path to the configuration file.

6:08 PM Changeset in webkit [34940] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-07-01 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19844: JavaScript Switch statement modifies "this"
<​https://bugs.webkit.org/show_bug.cgi?id=19844>

Use a temporary when generating code for switch clauses to avoid
overwriting 'this' or a local variable.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:
5:11 PM Changeset in webkit [34939] by sfalken@apple.com
  • 3 edits in trunk/WebKitLibraries

Bump version numbers.


Reviewed by Mark Rowe.

  • win/tools/scripts/PRODUCTVERSION:
  • win/tools/scripts/VERSION:
5:08 PM Changeset in webkit [34938] by christian@webkit.org
  • 4 edits in trunk

Gtk+ build fix.

4:46 PM Changeset in webkit [34937] by kmccullough@apple.com
  • 4 edits in trunk

JavaScriptCore:

2008-07-01 Kevin McCullough <​kmccullough@apple.com>

Build fix.

WebKit/mac:

2008-07-01 Kevin McCullough <​kmccullough@apple.com>

Build fix.

  • WebView/WebView.mm:
4:44 PM Changeset in webkit [34936] by andersca@apple.com
  • 8 edits in trunk

WebCore:

2008-07-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Add PluginMainThreadScheduler.{cpp|h} to build.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • plugins/PluginMainThreadScheduler.cpp:

WebKit/mac:

2008-07-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createPlugin]): Register the plug-in instance.


(-[WebBaseNetscapePluginView _destroyPlugin]):
Unegister the plug-in instance.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Set NPN_PluginThreadAsyncCall.


  • Plugins/npapi.mm: (NPN_PluginThreadAsyncCall): Implement this.
3:34 PM Changeset in webkit [34935] by mitz@apple.com
  • 9 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • move the method to set the base writing direction from Frame to Editor
  • WebCore.base.exp: Updated.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Changed the parameter to a WritingDirection enum value and added the special behavior when the focused node is a text field or a text area.
  • editing/Editor.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed back to call the Editor method.
  • page/Frame.cpp: Removed setSelectionBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit part of moving the method to set the base writing direction from Frame to Editor
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the Editor method. (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
3:21 PM Changeset in webkit [34934] by Darin Adler
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <Darin Adler>

Reviewed by Oliver.

  • slight tweak of the setHash fix
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash): Use oldRef instead of recomputing url.ref().
3:19 PM Changeset in webkit [34933] by mitz@apple.com
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

  • Mac release build fix

WebCore:

Reviewed by Anders Carlsson.

  • Mac release build fix
  • page/Console.cpp:
2:20 PM Changeset in webkit [34932] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6045896> REGRESSION: Leak in WebCore::StringImpl::create
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup):
2:11 PM Changeset in webkit [34931] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <​sam@webkit.org>

Try and fix mac builds.

2:06 PM Changeset in webkit [34930] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

Don't add the Mozilla user agent quirk for Flash 10.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): (WebCore::PluginPackage::determineQuirks):
1:06 PM Changeset in webkit [34929] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Move data: URL parsing code in HTMLObjectElement to KURL

Reviewed by Ada and Darin.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Extracted data: URL parsing code into WebCore::mimeTypeFromDataURL() in KURL.cpp.
  • platform/KURL.cpp: (WebCore::mimeTypeFromDataURL): Added.
  • platform/KURL.h: (WebCore::mimeTypeFromDataURL): Added.
12:08 PM Changeset in webkit [34928] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6045890> REGRESSION: Leak in WebCore::CSSParser::createFloatingValueList()
  • css/CSSParser.cpp: (WebCore::CSSParser::addUnresolvedProperty):
12:05 PM Changeset in webkit [34927] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-07-01 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Brady Eidson.

Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload
<​https://bugs.webkit.org/show_bug.cgi?id=19822>

Change JSLocation::setHash() to not schedule navigation in the case
where the old fragment is the null String and the new fragment is an
empty String.

WebCore:

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash):

LayoutTests:

  • http/tests/loading/location-hash-reload-cycle-expected.txt: Added.
  • http/tests/loading/location-hash-reload-cycle.html: Added.
11:31 AM Changeset in webkit [34926] by andersca@apple.com
  • 6 edits
    2 adds in trunk/WebCore

2008-06-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Add PluginMainThreadScheduler, a singleton which is responsible for scheduling plug-in
callbacks on the main thread. Use this to implement NPN_PluginThreadAsyncCall on Windows.


  • WebCore.vcproj/WebCore.vcproj: Add PluginMainThreadScheduler.{cpp|h}


  • plugins/PluginMainThreadScheduler.cpp: Added.
  • plugins/PluginMainThreadScheduler.h: Added.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Register with the thread scheduler.


  • plugins/npapi.cpp: (NPN_PluginThreadAsyncCall): Call the thread scheduler.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize the NPN_PluginThreadAsyncCall callback.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Unregister with the scheduler. This makes sure that we won't try to deliver callbacks after the plug-in has been destroyed.
11:02 AM Changeset in webkit [34925] by Adam Roben
  • 105 edits
    2 moves
    2 adds
    7 deletes in trunk

Roll out r34913, as it broke the Windows build due to bad casting

WebCore:

Roll out r34913, as it broke the Windows build due to bad casting

r34913 introduced code that assigned pointers-to-member from a derived
class into a base class pointer-to-member type (e.g., assigned a void
(SVGUseElement::*)() into a void (SVGElement::*)()). This is bad
because it could allow us to call SVGUseElement member functions on a
different SVGElement-derived class. MSVC rightly flagged this as an
error.

Rubberstamped by Anders Carlsson.

LayoutTests:

Roll out r34913, as it broke the Windows build due to bad casting

Rubberstamped by Anders Carlsson.

10:56 AM Changeset in webkit [34924] by Darin Adler
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <Darin Adler>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Fix warnings that indicate this was not working propertly.
10:46 AM Changeset in webkit [34923] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6045893> REGRESSION: Leak in WebCore::HTMLCanvasElement::createPlatformImage() const
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
10:39 AM Changeset in webkit [34922] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <​sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/DateMath.cpp:
10:32 AM Changeset in webkit [34921] by weinig@apple.com
  • 17 edits
    3 copies
    1 add in trunk

JavaScriptCore:

2008-07-01 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/JSPropertyNameIterator.h:
  • kjs/AllInOneFile.cpp:
  • kjs/JSCell.cpp: Copied from JavaScriptCore/kjs/JSValue.cpp.
  • kjs/JSCell.h: Copied from JavaScriptCore/kjs/JSValue.h. (KJS::JSValue::getJSNumber):
  • kjs/JSNumberCell.cpp:
  • kjs/JSNumberCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
  • kjs/JSObject.h:
  • kjs/JSString.cpp: (KJS::jsString): (KJS::jsOwnedString):
  • kjs/JSString.h: (KJS::JSValue::toThisJSString):
  • kjs/JSValue.cpp:
  • kjs/JSValue.h:

WebCore:

2008-07-01 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • ForwardingHeaders/kjs/JSNumberCell.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
10:27 AM Changeset in webkit [34920] by Chris Fleizach
  • 8 edits
    2 adds in trunk

<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0

Fixed incorrect AXSize of radio buttons and checkboxes when they don't have labels

9:42 AM Changeset in webkit [34919] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Anders Carlsson <​andersca@apple.com>

Build fixes.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals):
7:40 AM Changeset in webkit [34918] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

  • fix SVG pointer-events layout test failures
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
7:29 AM Changeset in webkit [34917] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-01 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Don't show the tooltip instantly in the QtLauncher.

Let the QWebView handle tooltips by itself, so we get
the expected delay as everywhere else.

5:21 AM Changeset in webkit [34916] by Nikolas Zimmermann
  • 5 edits
    60 adds in trunk

Reviewed by Antti.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=19841
Fix two small problems in the gradient & pattern code.

Added 12 new layout tests: svg/dynamic-updates/SVGLinearGradientElement*.html

5:15 AM Changeset in webkit [34915] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-01 Simon Hausmann <Simon Hausmann>

Fix the build, include SVGTransformList.h instead of
SVGTransformlist.h

5:01 AM Changeset in webkit [34914] by ap@webkit.org
  • 5 edits
    2 moves
    2 adds in trunk

Reviewed by Antti.

<rdar://problem/6033080> REGRESSION: Some CH characters display as garbage on webpage for
the first time.

Test: fast/encoding/preload-encoding.html

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize): Reset charset when entering a tag, not just when starting a load.
4:33 AM Changeset in webkit [34913] by Nikolas Zimmermann
  • 105 edits
    4 moves
    5 adds in trunk

Reviewed by Antti & Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)

Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).

Add a new synchronization layer to handle SVG DOM -> XML changes.

4:10 AM Changeset in webkit [34912] by oliver@apple.com
  • 23 edits in trunk/WebCore

Class name changes for SVG Light Effect files.

Reviewed by Nikolas Zimmermann.

The class names that changed :

SVGLightSource -> LightSource
SVGDistantLightSource -> DistantLightSource
SVGPointLightSource -> PointLightSource
SVGSpotLightSource -> SpotLightSource

Every other file that is changed is just propagating the class name changes to
dependent files.

1:39 AM Changeset in webkit [34911] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-07-01 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Holger.

autotools cleanup: move some GTK+-specific sources from libwebcore to
libwebcoregtk.

  • GNUmakefile.am:
1:19 AM Changeset in webkit [34910] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix the non-SVG build
  • css/CSSValueKeywords.in: Added 'all'.
  • css/SVGCSSValueKeywords.in: Removed 'all'.
12:09 AM Changeset in webkit [34909] by ggaren@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-01 Geoffrey Garen <​ggaren@apple.com>

Build fix: forgot to check in this file.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):
12:07 AM Changeset in webkit [34908] by Simon Hausmann
  • 4 edits in trunk

Build fixes, include OwnPtr.h and DateInstance.h

12:01 AM Changeset in webkit [34907] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a global object leak caused by the switch to one register file.


Don't unconditionally mark the register file, since that logically
makes all global variables GC roots, even when their global object is
no longer reachable.


Instead, make the global object associated with the register file
responsible for marking the register file.

Jun 30, 2008:

10:45 PM Changeset in webkit [34906] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.


SunSpider says 0.8% faster.

7:49 PM Changeset in webkit [34905] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.

Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

Test: fast/forms/search-hidden-cancel-button.html

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Don't start capturing mouse events if the cancel button isn't visible. This was causing the button to start but never stop capturing mouse events.

LayoutTests:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.

Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

  • fast/forms/search-hidden-cancel-button-expected.txt: Added.
  • fast/forms/search-hidden-cancel-button.html: Added.
7:21 PM Changeset in webkit [34904] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Fix build by adding all (hopefully) the missing includes.

6:56 PM Changeset in webkit [34903] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-06-30 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar
<​https://bugs.webkit.org/show_bug.cgi?id=19830>

Ensure that we do not eliminate a write to a local register when doing
peephole optimizations.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse):

LayoutTests:

  • fast/js/codegen-peephole-locals-expected.txt: Added.
  • fast/js/codegen-peephole-locals.html: Added.
  • fast/js/resources/codegen-peephole-locals.js: Added.
6:18 PM Changeset in webkit [34902] by adele@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Fixing * placement

6:11 PM Changeset in webkit [34901] by weinig@apple.com
  • 19 edits
    1 copy
    1 add in trunk

JavaScriptCore:

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Alder.

Split InternalFunction into its own header file.

  • API/JSCallbackFunction.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/ArrayConstructor.h:
  • kjs/BooleanConstructor.h:
  • kjs/DateConstructor.h:
  • kjs/ErrorConstructor.h:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
  • kjs/JSFunction.h:
  • kjs/NativeErrorConstructor.h:
  • kjs/NumberConstructor.h:
  • kjs/ObjectConstructor.h:
  • kjs/RegExpConstructor.h:
  • kjs/StringConstructor.h:
  • profiler/Profiler.cpp:

WebCore:

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Split InternalFunction into its own header file.

  • ForwardingHeaders/kjs/InternalFunction.h: Added.
  • bridge/runtime_method.h:
5:47 PM Changeset in webkit [34900] by adele@apple.com
  • 11 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Anders.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Test: editing/selection/select-all-textarea.html

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function. (WebCore::Node::shadowTreeRootNode): Added helper function.
  • dom/Node.h:
  • dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
  • dom/Range.h:
  • editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
  • editing/Selection.h:
  • editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
  • page/Frame.cpp: (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions. (WebCore::Frame::markAllMatchesForText): ditto.

LayoutTests:

2008-06-30 Adele Peterson <​adele@apple.com>

Reviewed by Anders.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • editing/selection/select-all-textarea-expected.txt: Added.
  • editing/selection/select-all-textarea.html: Added.
4:05 PM Changeset in webkit [34899] by Chris Fleizach
  • 12 edits
    4 adds in trunk

<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

3:52 PM Changeset in webkit [34898] by weinig@apple.com
  • 5 edits
    4 deletes in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Reviewed by Kevin McCullough.

Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Instruction.cpp: Removed.
  • VM/LabelID.cpp: Removed.
  • VM/Register.cpp: Removed.
  • VM/RegisterID.cpp: Removed.
3:43 PM Changeset in webkit [34897] by weinig@apple.com
  • 10 edits
    2 moves in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped (reluctantly) by Kevin McCullough.

Rename date_object.h/cpp to DateInstance.h/cpp

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateInstance.h: Copied from kjs/date_object.h.
  • kjs/DatePrototype.cpp:
  • kjs/DatePrototype.h:
  • kjs/date_object.cpp: Removed.
  • kjs/date_object.h: Removed.
3:10 PM Changeset in webkit [34896] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Adele Peterson.

  • WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added Frame::setSelectionBaseWritingDirection().
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to call Frame::setSelectionBaseWritingDirection().
  • page/Frame.cpp: (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the focused node is a text field or text area, changes its 'dir' attribute. This is what IE does when the user changes the writing direction in a text control. Otherwise, calls down to Editor::setBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Adele Peterson.

  • WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call WebCore::Frame::setSelectionBaseWritingDirection() instead of WebCore::Editor::setBaseWritingDirection(). (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
2:12 PM Changeset in webkit [34895] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Improve HTMLObjectElement data encapsulation

Reviewed by Dave Hyatt.

HTMLObjectElement has some public member variables that should be
private with accessor methods.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder initialization of member variables to match defined order in header.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::classId): Added. (WebCore::HTMLObjectElement::url): Added. (WebCore::HTMLObjectElement::serviceType): Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Use new accessor methods in HTMLObjectElement now that its member variables are private.
2:09 PM Changeset in webkit [34894] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • remove unused member variable
  • page/Page.h: Removed Page::m_focusedNode.
1:52 PM Changeset in webkit [34893] by weinig@apple.com
  • 10 edits
    4 copies
    1 move in trunk/JavaScriptCore

2008-06-30 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove internal.cpp and move its contents to there own .cpp files.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
  • kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
  • kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.h:
  • kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
  • kjs/NumberConstructor.cpp:
  • kjs/NumberObject.cpp: (KJS::constructNumber): (KJS::constructNumberFromImmediateNumber):
  • kjs/internal.cpp: Removed.
10:00 AM Changeset in webkit [34892] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-06-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6014209>
Crash when loading manifest from application cache fails


There is no need to set any handles to 0 after calling cacheUpdateFailed(), since
that is done inside the function. Furthermore, after calling cacheUpdateFailed() the cache
group could be deleted causing us to access freed memory and then crashing.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didFailToLoadManifest):
8:58 AM Changeset in webkit [34891] by Adam Roben
  • 13 edits in trunk

Fix <rdar://5954749> Assertion failure due to HashTable's use of operator&

JavaScriptCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

HashTable was passing &value to constructDeletedValue, which in
classes like WebCore::COMPtr would cause an assertion. We now pass
value by reference instead of by address so that the HashTraits
implementations have more flexibility in constructing the deleted
value.

Reviewed by Ada Chan.

  • VM/CodeGenerator.h: Updated for changes to HashTraits.
  • wtf/HashTable.h: (WTF::::deleteBucket): Changed to pass bucket by reference instead of by address. (WTF::::checkKey): Ditto.
  • wtf/HashTraits.h: (WTF::): Updated HashTraits for HashTable change.

WebCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

Reviewed by Ada Chan.

  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/StyledElement.cpp:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • platform/text/StringHash.h:
  • platform/win/COMPtr.h:
  • svg/SVGAnimatedTemplate.h: Updated all custom HashTraits for HashTable changes.
8:10 AM Changeset in webkit [34890] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

8:09 AM Changeset in webkit [34889] by mrowe@apple.com
  • 1 copy in tags/Safari-6527

New tag.

4:37 AM Changeset in webkit [34888] by Simon Hausmann
  • 1 edit
    14 deletes in trunk/WebKit/qt

2008-06-30 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Niko.

Removed the obsolete and unmaintained WebKitPart. The integration of
QtWebKit into KDE is now done in the webkitkde component inside KDE.

4:28 AM Changeset in webkit [34887] by Nikolas Zimmermann
  • 113 edits in trunk/LayoutTests

Reviewed by Antti.

Fix all existing tests in svg/dynamic-updates to actually reflect repainting changes, by
removing the timing dependency. Instead model them like frame-getSVGDocument.html by
not including the <script src="js-test-post.js"> element within the TEMPLATE.html but
by dynamically injecting it, if the test actually finished.

4:21 AM Changeset in webkit [34886] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Cameron Zwarich.

Make RegisterFile really unmap memory on destruction.

This fixes run-webkit-tests --threaded, which ran out of address space in a few seconds.

  • VM/RegisterFile.cpp: (KJS::RegisterFile::~RegisterFile): Unmap all the memory, not just 1/4 of it.
  • kjs/JSGlobalObject.h: Don't include RegisterFile.h, so that changes to it don't make half of WebCore rebuild.
  • VM/Machine.h: Don't forward declare RegisterFile, as RegisterFile.h is included already.
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Assert that the allocation succeeded.
2:38 AM Changeset in webkit [34885] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-30 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver.

Correct the documentation for op_put_by_index.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
1:09 AM Changeset in webkit [34884] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-30 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

Added missing includes and changed getItem array calls to use get()
instead.

Note: See TracTimeline for information about the timeline view.