⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 5, 2008:

10:35 PM Changeset in webkit [35024] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/WebKit

Remove WebSearchableTextView as it has been unused for some time now.

Reviewed by John Sullivan.

10:35 PM Changeset in webkit [35023] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.

Reviewed by John Sullivan.

10:26 PM Changeset in webkit [35022] by weinig@apple.com
  • 43 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

First step in broad cleanup effort.

[ File list elided ]

5:10 PM Changeset in webkit [35021] by weinig@apple.com
  • 17 edits
    3 moves in trunk

JavaScriptCore:

2008-07-05 Sam Weinig <sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Rename list.h/cpp to ArgList.h/cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.h:
  • kjs/AllInOneFile.cpp:
  • kjs/ArgList.cpp: Copied from JavaScriptCore/kjs/list.cpp.
  • kjs/ArgList.h: Copied from JavaScriptCore/kjs/list.h.
  • kjs/IndexToNameMap.cpp:
  • kjs/JSGlobalData.cpp:
  • kjs/JSGlobalData.h:
  • kjs/JSObject.h:
  • kjs/collector.cpp:
  • kjs/list.cpp: Removed.
  • kjs/list.h: Removed.

WebCore:

2008-07-05 Sam Weinig <sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Rename list.h/cpp to ArgList.h/cpp.

  • ForwardingHeaders/kjs/ArgList.h: Copied from WebCore/ForwardingHeaders/kjs/list.h.
  • ForwardingHeaders/kjs/list.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/qt/qt_instance.cpp:
  • page/Console.cpp:
4:40 PM Changeset in webkit [35020] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds again.

  • kjs/BooleanPrototype.cpp:
  • kjs/ErrorPrototype.cpp:
  • kjs/FunctionPrototype.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/ObjectPrototype.cpp:
4:36 PM Changeset in webkit [35019] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <sam@webkit.org>

Fix build on case-sensitive build systems.

  • kjs/IndexToNameMap.cpp:
4:32 PM Changeset in webkit [35018] by weinig@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <sam@webkit.org>

Fix build.

  • kjs/Arguments.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/ErrorPrototype.cpp:
  • kjs/FunctionPrototype.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/ObjectPrototype.cpp:
  • kjs/RegExpPrototype.cpp:
  • kjs/StringConstructor.cpp:
  • kjs/lookup.cpp:
4:26 PM Changeset in webkit [35017] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-05 Sam Weinig <sam@webkit.org>

Fix non-AllInOne build.

  • kjs/JSGlobalObject.cpp:
4:19 PM Changeset in webkit [35016] by weinig@apple.com
  • 17 edits
    10 copies
    1 add in trunk

JavaScriptCore:

2008-07-05 Sam Weinig <sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Split Arguments, IndexToNameMap, PrototypeFunction, GlobalEvalFunction and
the functions on the global object out of JSFunction.h/cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/Arguments.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/Arguments.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/GlobalEvalFunction.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/GlobalEvalFunction.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/IndexToNameMap.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/IndexToNameMap.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/JSActivation.cpp:
  • kjs/JSFunction.cpp:
  • kjs/JSFunction.h:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObjectFunctions.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/JSGlobalObjectFunctions.h: Copied from JavaScriptCore/kjs/JSFunction.h. The functions on the global object should be in JSGlobalObject.cpp, but putting them there was a 0.5% regression.
  • kjs/PrototypeFunction.cpp: Copied from JavaScriptCore/kjs/JSFunction.cpp.
  • kjs/PrototypeFunction.h: Copied from JavaScriptCore/kjs/JSFunction.h.
  • kjs/Shell.cpp:
  • kjs/lexer.cpp:
  • kjs/ustring.cpp:

WebCore:

2008-07-05 Sam Weinig <sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Split Arguments, IndexToNameMap, PrototypeFunction, GlobalEvalFunction and
the functions on the global object out of JSFunction.h/cpp.

  • ForwardingHeaders/kjs/PrototypeFunction.h: Added.
  • bindings/js/JSDOMBinding.cpp:
1:44 PM Changeset in webkit [35015] by mitz@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • rename BidiIterator and BidiState

Renamed BidiIterator to InlineIterator and BidiState
to InlineBidiResolver. Renamed variables of type InlineBidiResolver{*,&}
to "resolver".

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::InlineIterator::InlineIterator): (WebCore::operator==): (WebCore::operator!=): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::increment): (WebCore::InlineIterator::atEnd): (WebCore::InlineIterator::current): (WebCore::InlineIterator::direction): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::InlineBidiResolver::appendRun): (WebCore::RenderBlock::bidiReorderLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
10:57 AM Changeset in webkit [35014] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog entry for r35006.

3:35 AM Changeset in webkit [35013] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-05 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Oliver Hunt

Coding style fix

  • html/CanvasRenderingContext2D.cpp: Indentation fix

Jul 4, 2008:

11:44 PM Changeset in webkit [35012] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix windows build

11:18 PM Changeset in webkit [35011] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Really fix the mac build.

10:59 PM Changeset in webkit [35010] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_instance.cpp:
10:47 PM Changeset in webkit [35009] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix mac build.

10:44 PM Changeset in webkit [35008] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-07-04 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/Error.cpp:
  • kjs/GetterSetter.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/operations.cpp:
10:35 PM Changeset in webkit [35007] by weinig@apple.com
  • 31 edits
    4 copies
    1 add in trunk

JavaScriptCore:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • API/JSCallbackObjectFunctions.h:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ClassInfo.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/Error.cpp: Copied from JavaScriptCore/kjs/JSObject.cpp.
  • kjs/Error.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/GetterSetter.cpp:
  • kjs/GetterSetter.h: Copied from JavaScriptCore/kjs/JSObject.h.
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/nodes.h:

JavaScriptGlue:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

  • JSObject.h: Rename the header guard as it now conflicts with the JSObject in JavaScriptCore.

WebCore:

2008-07-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Split Error and GetterSetter out of JSObject.h.

  • ForwardingHeaders/kjs/Error.h: Added.
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSEventTargetBase.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_runtime.cpp:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:
9:51 PM Changeset in webkit [35006] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

Tests: webarchive/archive-empty-frame-dom-expected.txt

webarchive/doctype.html

  • editing/markup.cpp: (WebCore::createFullMarkup): If the Node is a Document or a DocumentType, don't prepend the <!DOCTYPE> tag since that will cause it to be duplicated.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.

LayoutTests:

Bug 15290: REGRESSION (r14184-r14216): Duplicate DOCTYPE definitions when saving files as webarchives

<https://bugs.webkit.org/show_bug.cgi?id=15290>
<rdar://problem/5509173>

Reviewed by Dan Bernstein.

  • webarchive/archive-empty-frame-dom-expected.txt: Updated test results now that we don't emit two <!DOCTYPE> tags.
  • webarchive/doctype-expected.txt: Added.
  • webarchive/doctype.html: Added.
9:34 PM Changeset in webkit [35005] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-04 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix

  • GNUmakefile.am:
3:43 PM Changeset in webkit [35004] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-07-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Eric Seidel.

Bring our implementation of the Netscape plugin API closer to current
code style guidelines.

  • bridge/NP_jsobject.cpp: (getListFromVariantArgs): (jsAllocate): (jsDeallocate): (_NPN_CreateScriptObject): (_NPN_CreateNoScriptObject): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_Enumerate):
  • bridge/npruntime_impl.h:
5:04 AM Changeset in webkit [35003] by Simon Hausmann
  • 5 edits in trunk/WebCore

Fix the Qt/Windows build.

4:37 AM Changeset in webkit [35002] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Mac build for real, don't define listDirectory() twice.

3:55 AM Changeset in webkit [35001] by Simon Hausmann
  • 3 edits in trunk/WebCore

Prospective Mac build fix.

3:41 AM Changeset in webkit [35000] by Simon Hausmann
  • 5 edits
    3 deletes in trunk/WebCore

2008-07-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Move duplicated code from each PluginDatabaseXX-implementation
to PluginDabase.cpp -- ifdefed based on the XP_PLATFORM we are
compiling plugins for.

This make the code cleaner and we can share common patterns.
The only implementation left which is specific is the Win
implementation (also used by QtWebKit/Win), but we might
want to move that too.

3:41 AM Changeset in webkit [34999] by Simon Hausmann
  • 7 edits in trunk/WebCore/platform

2008-06-25 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Add an abstraction for listing files in a directory to FileSystem.h.

Currently this is only implemented for the Qt and GTK port. The other
ports have a default implementations which call notImplemented().

3:10 AM Changeset in webkit [34998] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-04 Benjamin C Meyer <ben@meyerhome.net>

Reviewed by Simon.

Update the webkit version in the QtWebKit useragent string to match trunk

1:28 AM Changeset in webkit [34997] by Simon Hausmann
  • 5 edits in trunk

Fix the Wx build

12:46 AM Changeset in webkit [34996] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Gtk build, adapt to renamed files.

12:37 AM Changeset in webkit [34995] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build, adapt to renamed files.

12:25 AM Changeset in webkit [34994] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix output path of recently-added script phase to reference the correct file.
This prevents Xcode from running the script phase unnecessarily, which caused
the generated header to be recreated and lead to AllInOneFile.cpp rebuilding.

Reviewed by Oliver Hunt.

Note: See TracTimeline for information about the timeline view.