⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 7, 2008:

9:17 PM Changeset in webkit [35057] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Remove extraneous null check.

  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
9:15 PM Changeset in webkit [35056] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19928
Use of CSS3 Namespaces syntax in Selectors API should throw an exception

  • Throw an NAMESPACE_ERR exception if a non-null or "*" namespace is used in a selector passed to querySelector or querySelectorAll.

Test: fast/dom/SelectorAPI/not-supported-namespace-in-selector.html

  • dom/Node.cpp: (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19928
Use of CSS3 Namespaces syntax in Selectors API should throw an exception

  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt: Added.
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector.html: Added.
8:30 PM Changeset in webkit [35055] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

releaseFastMallocFreeMemory() should always be defined

Reviewed by Darin.

  • JavaScriptCore.exp: Changed to export C++ binding for WTF::releaseFastMallocFreeMemory() instead of C binding for releaseFastMallocFreeMemory().
  • wtf/FastMalloc.cpp: Moved definitions of releaseFastMallocFreeMemory() to be in the WTF namespace regardless whether FORCE_SYSTEM_MALLOC is defined.
  • wtf/FastMalloc.h: Moved releaseFastMallocFreeMemory() from extern "C" binding to WTF::releaseFastMallocFreeMemory().
8:19 PM Changeset in webkit [35054] by dino@apple.com
  • 18 edits
    4 adds in trunk

2008-07-07 Simon Fraser <Simon Fraser>

Reviewed by Darin.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19933
nodeIterator with filter fails on documents not in a frame

Tests: traversal/node-iterator-009.html

traversal/tree-walker-006.html

  • bindings/js/JSNodeFilterCondition.cpp:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/js/JSTreeWalkerCustom.cpp:
  • bindings/objc/DOM.mm:
  • dom/NodeFilter.cpp:
  • dom/NodeFilter.h:
  • dom/NodeFilterCondition.cpp:
  • dom/NodeFilterCondition.h:
  • dom/NodeIterator.cpp:
  • dom/NodeIterator.h:
  • dom/Traversal.cpp:
  • dom/Traversal.h:
  • dom/TreeWalker.cpp:
  • dom/TreeWalker.h:


6:25 PM Changeset in webkit [35053] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff.

Bug 19926: URL causes crash within a minute
<​https://bugs.webkit.org/show_bug.cgi?id=19926>

Add a check that lastGlobalObject is non-null in Machine::execute()
before copying its globals to the current register file.

In theory, it is possible to make a test case for this, but it will
take a while to get it right.

  • VM/Machine.cpp: (KJS::Machine::execute):
6:13 PM Changeset in webkit [35052] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-07-07 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19924
<rdar://problem/6057160> Disabled file input element updates its displayed file info when a file is dropped from the Finder.

  • page/DragController.cpp: (WebCore::DragController::concludeDrag): Check that the file control is enabled before taking dropped files.

LayoutTests:

2008-07-07 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19924
<rdar://problem/6057160> Disabled file input element updates its displayed file info when a file is dropped from the Finder.

  • fast/forms/dragging-to-disabled-file-input-expected.txt: Added.
  • fast/forms/dragging-to-disabled-file-input.html: Added.
5:46 PM Changeset in webkit [35051] by adele@apple.com
  • 6 edits in trunk

WebCore:

2008-07-07 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

Fix for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime

Change default volume setting to 1.0.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):

LayoutTests:

2008-07-07 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

Test for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime

  • media/video-volume-expected.txt:
  • media/video-volume.html:
5:29 PM Changeset in webkit [35050] by Darin Adler
  • 4 edits in trunk/WebCore

2008-07-07 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

  • fix <rdar://problem/6020441> REGRESSION: Layers on NWA.com render ugly

The old version of the OpenCube QuickMenu library used on this site still has code
that detects Netscape 4 by checking appVersion to see if it has the substring "4."
in it. We decided to special-case the filename of the script and tweak the appVersion
for files with that name.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): Replace m_processingInlineCode with m_sourceURL. Use false instead of 0 to initialize a boolean. (WebCore::ScriptController::evaluate): Call argument sourceURL, not filename. Store current sourceURL in m_sourceURL. This fixes a mistake in the code that maintained the value of m_processingInlineCode, since the old code set it to false rather than restoring it. Renamed a local variable named sourceURL to exceptionSourceURL for clarity. (WebCore::ScriptController::processingUserGesture): Code that formerly used m_processingInlineCode to detect that it was evaluating code with no URL now uses m_sourceURL to do the same check.
  • bindings/js/ScriptController.h: Renamed filename argument to sourceURL; it has always been a URL, not a file path. Added a public sourceURL function and m_sourceURL and removed m_processingInlineCode.
  • page/Navigator.cpp: (WebCore::shouldHideFourDot): Added. Returns true if the currently running script has a source URL ending in "/dqm_script.js" and if the settings say we should do site-specific quirks (really JavaScript-library-specific in this case). (WebCore::Navigator::appVersion): Replace "4." with "4_" if shouldHideFourDot is true.
4:51 PM Changeset in webkit [35049] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-07-07 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff.

Bug 19907: REGRESSION(r34824-r34941): Reproducible crash trying to log in to MediaTemple.net Account Center
<​https://bugs.webkit.org/show_bug.cgi?id=19907>

Clear exceptions set on ExecStates before returning from NPAPI
callbacks, in order to avoid causing problems for the next script that
executes.

While fixing this bug, the question was raised of whether we are
correctly propagating exception information back to the caller:

Bug 19936: Correctly propagate exception information from NPAPI callbacks
<​https://bugs.webkit.org/show_bug.cgi?id=19936>

  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_Enumerate):
4:26 PM Changeset in webkit [35048] by Beth Dakin
  • 5 edits
    2 adds in trunk

WebKitTools:

2008-07-07 Beth Dakin <Beth Dakin>

Reviewed by Anders.

This patch extends DRT accessibility tests to add the ability to
query the intValue, minValue, and maxValue of the focused element.

  • DumpRenderTree/AccessibilityController.cpp: (intValueOfFocusedElementCallback): (minValueOfFocusedElementCallback): (maxValueOfFocusedElementCallback): (AccessibilityController::staticFunctions):
  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::intValueOfFocusedElement): (AccessibilityController::minValueOfFocusedElement): (AccessibilityController::maxValueOfFocusedElement):

LayoutTests:

2008-07-07 Beth Dakin <Beth Dakin>

Reviewed by Anders.

New test that uses the ability to query int value, min value, and
max value in the accessibility tests.

  • accessibility/aria-range-value-expected.txt: Added.
  • accessibility/aria-range-value.html: Added.
4:07 PM Changeset in webkit [35047] by mitz@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6057650> REGRESSION (r35025): Crash beneath FontCache::invalidate() when activating Safari with no windows open
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Added a null check because docLoader() can return 0 now.
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::docLoader): Added a null check of m_document. (WebCore::CSSFontSelector::addFontFaceRule): Ditto. (WebCore::CSSFontSelector::fontLoaded): Ditto. (WebCore::CSSFontSelector::fontCacheInvalidated): Ditto. (WebCore::fontDataForGenericFamily): Added a null check of document.
  • css/CSSFontSelector.h: (WebCore::CSSFontSelector::clearDocument): Added.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::~CSSStyleSelector): Added a call to CSSFontSelector::clearDocument(). When the style selector is destroyed, there is no guarantee that the document will continue to exist.
3:39 PM Changeset in webkit [35046] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-07-07 Darin Adler <Darin Adler>

Rubber stamped by Adele.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Fix a typo in a comment.
3:38 PM Changeset in webkit [35045] by jchaffraix@webkit.org
  • 3 edits in trunk/WebCore

WebCore:

2008-07-07 Julien Chaffraix <​jchaffraix@webkit.org>

Not reviewed.

No svg build fix.

  • DerivedSources.make: Add JSSVGElementWrapperFactory.cpp target.
  • svg/animation/SMILTimeContainer.cpp: Add ENABLE(SVG) guard.
3:33 PM Changeset in webkit [35044] by sfalken@apple.com
  • 5 edits in trunk

JavaScriptCore:

2008-07-07 Steve Falkenburg <​sfalken@apple.com>

Build fixes.

WebKitTools:

2008-07-07 Steve Falkenburg <​sfalken@apple.com>

Fix build.

  • DumpRenderTree/win/ImageDiff.vcproj:
3:02 PM Changeset in webkit [35043] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Speculative fix for
<rdar://problem/5839800>
CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389


Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].


My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
This is usually protected by _private->closed, but in this case it might still be false.

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
2:34 PM Changeset in webkit [35042] by adele@apple.com
  • 5 edits
    10 adds in trunk

WebCore:

2008-07-07 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele.

Support for CSS3 :read-only and :read-write pseudoclasses for readonly text controls.

URL: ​http://www.w3.org/TR/web-forms-2/#relation

Tests: fast/css/readonly-pseudoclass-opera-001.html

fast/css/readonly-pseudoclass-opera-002.html
fast/css/readonly-pseudoclass-opera-003.html
fast/css/readonly-pseudoclass-opera-004.html
fast/css/readonly-pseudoclass-opera-005.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added "read-only" and "read-write" values for PseudoType extraction.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoReadOnly and PseudoReadWrite entries in PseudoType enum.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Checks to determine whether to match :read-only and :read-write pseudoclasses on text controls.

LayoutTests:

2008-07-07 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele.

Test suite for :read-only and :read-write pseudoclasses, imported from
Opera.

  • fast/css/readonly-pseudoclass-opera-001-expected.txt: Added.
  • fast/css/readonly-pseudoclass-opera-001.html: Added.
  • fast/css/readonly-pseudoclass-opera-002-expected.txt: Added.
  • fast/css/readonly-pseudoclass-opera-002.html: Added.
  • fast/css/readonly-pseudoclass-opera-003-expected.txt: Added.
  • fast/css/readonly-pseudoclass-opera-003.html: Added.
  • fast/css/readonly-pseudoclass-opera-004-expected.txt: Added.
  • fast/css/readonly-pseudoclass-opera-004.html: Added.
  • fast/css/readonly-pseudoclass-opera-005-expected.txt: Added.
  • fast/css/readonly-pseudoclass-opera-005.html: Added.
2:29 PM Changeset in webkit [35041] by weinig@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19928
querySelectorAll should throw an exception if a NSResolver is passed in.

  • Throw an NOT_SUPPORTED_ERR if a non-null or undefined parameter is passed as the second argument to querySelector or querySelectorAll.

Test: fast/dom/SelectorAPI/not-supported-NSResolver.html

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::querySelector): (WebCore::JSDocument::querySelectorAll):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::querySelector): (WebCore::JSElement::querySelectorAll):
  • dom/Document.idl:
  • dom/Element.idl:

LayoutTests:

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19928
querySelectorAll should throw an exception if a NSResolver is passed in.

  • fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Added.
  • fast/dom/SelectorAPI/not-supported-NSResolver.html: Added.
1:35 PM Changeset in webkit [35040] by beidson@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-07-07 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz and Geoff

Test: fast/loader/empty-ref-versus-no-ref.html

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18951 and <rdar://problem/5921760>
"all DOM operations stop working when location.hash set to '#'"

The underlying problem is that KURL didn't really know the difference between "empty ref"
and "no ref at all" when changing the ref. So changing to the empty ref in JS ended up
affecting removal of the ref, which ended up causing an infinite load load, also killing
javascript.

  • platform/KURL.cpp: (WebCore::KURL::setRef): Changed "isEmpty()" to "isNull()", since NULL has the special meaning of "no ref at all" while empty means "empty ref"

LayoutTests:

2008-07-07 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz and Geoff

Test the fix for ​https://bugs.webkit.org/show_bug.cgi?id=18951 and <rdar://problem/5921760>

  • fast/loader/empty-ref-versus-no-ref-expected.txt: Added.
  • fast/loader/empty-ref-versus-no-ref.html: Added.
11:12 AM Changeset in webkit [35039] by kmccullough@apple.com
  • 10 edits
    2 adds in trunk

JavaScriptCore:

2008-07-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

When the profiler is running it gathers information and creates a
Profile. After it finishes the Profile can be sorted and have other
data refinements run over it. Both of these were done in the same class
before. Now I split the gathering operations into a new class called
ProfileGenerator.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/Profile.cpp: Removed code related to the gather stage of a Profile's creation. (KJS::Profile::create): (KJS::Profile::Profile):
  • profiler/Profile.h: Ditto. (KJS::Profile::title): (KJS::Profile::callTree): (KJS::Profile::setHead):
  • profiler/ProfileGenerator.cpp: Added. This is the class that will handle the stage of creating a Profile. Once the Profile is finished being created, this class goes away. (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator): (KJS::ProfileGenerator::title): (KJS::ProfileGenerator::willExecute): (KJS::ProfileGenerator::didExecute): (KJS::ProfileGenerator::stopProfiling): (KJS::ProfileGenerator::didFinishAllExecution): (KJS::ProfileGenerator::removeProfileStart): (KJS::ProfileGenerator::removeProfileEnd):
  • profiler/ProfileGenerator.h: Added. (KJS::ProfileGenerator::profile): (KJS::ProfileGenerator::originatingGlobalExec): (KJS::ProfileGenerator::pageGroupIdentifier): (KJS::ProfileGenerator::client): (KJS::ProfileGenerator::stoppedProfiling):
  • profiler/Profiler.cpp: Now operates with the ProfileGenerator instead of the Profile. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): (KJS::Profiler::didFinishAllExecution): It is here that the Profile is handed off to its client and the Profile Generator is no longer needed. (KJS::dispatchFunctionToProfiles): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute):
  • profiler/Profiler.h: Cleaned up the includes and subsequently the forward declarations. Also use the new ProfileGenerator. (KJS::ProfilerClient::~ProfilerClient): (KJS::Profiler::currentProfiles):
  • profiler/TreeProfile.cpp: Use Profile's new interface. (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
  • profiler/TreeProfile.h:

WebCore:

2008-07-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

Because profiler.h no longer #includes profile.h we need to explicitly
include it in console.cpp.

  • page/Console.cpp:
10:59 AM Changeset in webkit [35038] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

Not reviewed. Build fix.
Fix --svg-filters build (affects Qt build, mac/win don't have it on by default)

9:01 AM Changeset in webkit [35037] by weinig@apple.com
  • 18 edits in trunk/JavaScriptCore

2008-07-07 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Third step in broad cleanup effort.

[ File list elided ]

7:28 AM Changeset in webkit [35036] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Fix references to WebRenderNode.h and WebRenderNode.mm in Xcode project so that they don't have an unnecessary ".." in the path.

7:12 AM Changeset in webkit [35035] by Nikolas Zimmermann
  • 101 edits
    4 moves
    6 adds in trunk

Reviewed by Antti.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

Revised version of the patch, not using pointer-to-member function callbacks anymore - after discussion with Adam Roben.
Remove unneccessary parameters of all macros. Hopefully build on Windows works as expected now, watching build bot...

5:55 AM Changeset in webkit [35034] by Nikolas Zimmermann
  • 11 edits in trunk/WebCore

Reviewed by Oliver.

Working on: ​http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

Splitting up large patch in small chunk: Land valueAsString() implementation on it's own.

Added valueAsString() conversion for all SVG primitive types, needed by the SVG<->XML synchronization layer.
Unify "null value for a SVG animated type" concept, which was implemented in SVGDocumentExtensions before, in SVGAnimatedTemplate.

2:33 AM Changeset in webkit [35033] by jchaffraix@webkit.org
  • 3 edits in branches/XBL2/WebCore

WebCore:

2008-07-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Disable renderer creation for XBLElement and
XBLDocument.

  • xbl/XBLDocument.h: (WebCore::XBLDocument::XBLDocument):
  • xbl/XBLElement.h: (WebCore::XBLElement::createRendererIfNeeded):
1:14 AM Changeset in webkit [35032] by jchaffraix@webkit.org
  • 4 edits
    1 add in branches/XBL2/WebCore

WebCore:

2008-07-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 19918: [XBL] Add XBLDocument.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Added XBLDocument creation.
  • dom/Document.h: (WebCore::Document::isXBLDocument):
  • xbl/XBLDocument.h: Added. (WebCore::XBLDocument::create): (WebCore::XBLDocument::isXBLDocument): (WebCore::XBLDocument::XBLDocument):

Jul 6, 2008:

11:14 PM Changeset in webkit [35031] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Rename "Access-Contol-Origin" to "Origin" to match the latest
Access Control for Cross-Site Request draft. (Editor's Draft 25 May 2008)

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):

LayoutTests:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Rename "Access-Contol-Origin" to "Origin" to match the latest
Access Control for Cross-Site Request draft. (Editor's Draft 25 May 2008)

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-expected.txt:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
9:17 PM Changeset in webkit [35030] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • WebCore.vcproj/WebCore.vcproj:
8:10 PM Changeset in webkit [35029] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • add missing brace
  • platform/graphics/qt/FontCacheQt.cpp:
8:08 PM Changeset in webkit [35028] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the Qt build
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::addClient): (WebCore::FontCache::removeClient):
7:49 PM Changeset in webkit [35027] by weinig@apple.com
  • 71 edits in trunk

JavaScriptCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Second step in broad cleanup effort.

[ File list elided ]

WebCore:

2008-07-06 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Add #include for kjs/protect.h.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
7:40 PM Changeset in webkit [35026] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Save a few more bits in RenderStyle

Reviewed by Darin.

No test cases added since there is no change in behavior.

This changes WebCore::StyleMarqueeData from using 6 bits to 5 bits,
WebCore::RenderStyle::inherited_flags from using 36 bits to 35 bits,
and WebCore::RenderStyle::noninherited_flags from using 49 bits to
47 bits.

  • rendering/style/RenderStyle.h: (WebCore::StyleMarqueeData::behavior): Reduce from 3 bits to 2 bits since EMarqueeBehavior has 4 items. (WebCore::RenderStyle::inherited_flags._text_align): Reduce from 4 bits to 3 bits since ETextAlign has 8 items. (WebCore::RenderStyle::noninherited_flags._overflowX): Reduce from 4 bits to 3 bits since EOverflow has 6 items. (WebCore::RenderStyle::noninherited_flags._overflowY): Ditto.
5:00 PM Changeset in webkit [35025] by mitz@apple.com
  • 11 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5735163> WebCore caching makes text look wrong after font changes; need to respond appropriately instead
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): Added a call to FontCache::addClient(). (WebCore::CSSFontSelector::~CSSFontSelector): Added a call to FontCache::removeClient(). (WebCore::CSSFontSelector::fontCacheInvalidated): Added. Called by the font cache when it is invalidated, and ensures that the document is updated.
  • css/CSSFontSelector.h:
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Added code to compare the font fallback lists' font cache generations.
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::addClient): Added. (WebCore::FontCache::removeClient): Added. (WebCore::FontCache::generation): Added. (WebCore::FontCache::invalidate): Added. Deletes the platform data cache, increments the generation counter, and notifies all clients.
  • platform/graphics/FontCache.h:
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): Added initialization of m_generation. (WebCore::FontFallbackList::invalidate): Added code to reset m_generation. (WebCore::FontFallbackList::fontDataAt): Added an assertion. (WebCore::FontFallbackList::fontDataForCharacters): Ditto. (WebCore::FontFallbackList::setPlatformFont): Ditto.
  • platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::generation): Added. Returns the font cache generation used to populate the list.
  • platform/graphics/FontSelector.h: (WebCore::FontSelector::fontCacheInvalidated): Added.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheATSNotificationCallback): Added. Calls FontCache::invalidate(). (WebCore::FontCache::platformInit): Added code to register for ATS notifications.
  • svg/SVGFontFaceElement.cpp: Removed unneeded #inlcudes.
Note: See TracTimeline for information about the timeline view.