Context Navigation

The root of this problem was that calling init() on a new frame could end up calling arbitrary
javascript that might end up removing the frame from the tree. This opened up a small can of worms
such as the frame not having yet been installed in its frame tree, and other assumed behavior while
destroying the frame.

Test: fast/loader/frame-creation-removal.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoadingMainResource): If the frame doesn't have a page, don't close up the document and parser because they don't exist, and this frame is on its way out. (WebCore::FrameLoader::finishedParsing): We can't rely on the refCount check to discover "am I being deleted?" because we no longer store refCounts of 0. The new check is "do I have a FrameView?" while will always be false if the Frame is being destroyed.

WebKit/mac:

2008-07-09 Brady Eidson <beidson@apple.com>

Reviewed by Darin

<rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
has been installed in a frame tree.

The root of this problem was that calling init() on a new frame could end up calling arbitrary
javascript that might end up removing the frame from the tree. This opened up a small can of worms
such as the frame not having yet been installed in its frame tree, and other assumed behavior while
destroying the frame.

Note that each platforms WebKit API layer needs to make this new guarantee:
"The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
I am fixing Mac, and Windows and GTK already have this property. Wx currently has subframes disabled
but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.

Alternately, the way frames are created right now is roundabout and asinine, and this is a key
architectural improvement we can make in the future so the individual platform clients are no longer
vulnerable to this problem, which should really have been a WebCore issue.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame): Don't bother null checking the newCoreFrame - can't be NULL. Don't appendChild() the new frame here. Null-check the new frame's page before loading the URL into it, as it might already have been removed from the page.

WebView/WebFrame.mm: (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): If there is an ownerElement, go ahead and install the new frame in the frame tree *before* calling init() on it.

LayoutTests:

2008-07-09 Brady Eidson <beidson@apple.com>

Reviewed by Darin

Test for <rdar://problem/5823684>

fast/loader/frame-creation-removal-expected.txt: Added.
fast/loader/frame-creation-removal.html: Added.
fast/loader/resources/frame-creation-removal-iframe.html: Added.

9:32 PM Changeset in webkit [35087] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-07-09 Darin Adler <Darin Adler>

JavaScriptCore.pri: Fix Qt build by adding HeavyProfile.cpp.

8:33 PM Memory Use edited by ggaren@apple.com

(diff)

8:31 PM WikiStart edited by ggaren@apple.com

(diff)

8:31 PM Memory Use edited by ggaren@apple.com

(diff)

8:30 PM Memory Use created by ggaren@apple.com

8:11 PM Changeset in webkit [35086] by dino@apple.com

2 edits in trunk/WebCore

Changed to use the correct license in header comment (via Darin)

css/WebKitCSSTransformValue.idl:

6:39 PM Changeset in webkit [35085] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

wx biuld fix. Add HeavyProfile.cpp to build files.

6:02 PM Changeset in webkit [35084] by dino@apple.com

9 edits
1 add in trunk/WebCore

Add DOM interface for WebKitCSSTransformValue.
https://bugs.webkit.org/show_bug.cgi?id=19863

Reviewed by Hyatt.

bindings/objc/DOMInternal.h:
css/WebKitCSSTransformValue.idl: Added.

bindings/scripts/CodeGeneratorObjC.pm:

make sure new class inherits from CSSValue not Node

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

Adding new generated files

5:22 PM Changeset in webkit [35083] by britto@apple.com

19 edits
3 adds in trunk

2008-07-09 Maxime Britto <britto@apple.com>

Reviewed by NOBODY (OOPS!).

http://bugs.webkit.org/show_bug.cgi?id=14227
Add the middle click panning feature to the windows release.
Details on almost each method below.
Manual test is included in the patch.

ChangeLog:
WebCore.vcproj/WebCore.vcproj:
manual-tests/panScroll.html: Added.
manual-tests/resources/big-page.html: Added.
page/EventHandler.cpp: Added the panScroll start/stop handlers and adapted the autoscroll for both to share some functions. (WebCore::EventHandler::EventHandler): Initialize the new class members for the panScroll (WebCore::EventHandler::handleMouseDraggedEvent): Prevent the autoscroll to trigger if the panScroll is in progress (WebCore::EventHandler::handleMouseReleaseEvent): Prevent the autoscroll to stop the panScroll on mouse release (WebCore::EventHandler::handleAutoscroll): Added the specific calls for the panScroll (save mouse position, draw the panScroll icon) to the shared code (WebCore::EventHandler::autoscrollTimerFired): Specify the calls to perform for each function (autoscroll and panScroll) (WebCore::EventHandler::stopAutoscrollTimer): Specify the calls to perform for each function (autoscroll and panScroll) (WebCore::EventHandler::handleMousePressEvent): Trigger for the panScroll. Test is the button is the middle button and try to find a renderer where the panScroll is possible. If it finds one, it calls the handleAutoscroll method.
page/EventHandler.h: (WebCore::EventHandler::panScrollInProgress): Getter used by the sub frames's EventHandler to notice the main frame EventHandler (WebCore::EventHandler::setPanScrollInProgress): Setter used by the sub frames's EventHandler to notice the main frame EventHandler
platform/ScrollView.h: Added a method used by the RenderObject to test if the view can be scrolled. Added the print/remove panScroll icon methods between the windows platform flags
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::isScrollable): Not implemented : returns true
platform/mac/ScrollViewMac.mm: Implemented because it was useful for the autoscroll feature. (WebCore::ScrollView::isScrollable):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::isScrollable): Not implemented : returns true
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added a boolean and an IntPoint to draw the icon. (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): If the icon must be drawn, define the rect to invalidate to erase the previous icon and to display the new one. (WebCore::ScrollView::updateContents): I split this method to be able to invalidate a rect with window coordinates instead of contents coordinates. This function now converts the contents coord in window coord and calls the new updateWindowRect() method (WebCore::ScrollView::updateWindowRect): New method which performs the work that was doing the end of the old updateContents : invalidate a rect with window coordinates (WebCore::ScrollView::isScrollable): checks is the view has scrollbars (WebCore::ScrollView::printPanScrollIcon): sets the boolean and the IntPoint for the icon. Invalidate his rect and ask for repaint. (WebCore::ScrollView::removePanScrollIcon): sets the boolean to false. Invalidate his rect and ask for repaint. (WebCore::ScrollView::paint): Modified to draw the icon if needed.
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::isScrollable): Not implemented : returns true
rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): Receives the Middle click location and retrieves the currentMouse position from the EventHandler. With these informations it computes the direction to scroll to and the speed then calls for the final scroll.
rendering/RenderLayer.h:
rendering/RenderListBox.cpp: Adapt the panScroll to the ListBox object to scroll by lines instead of pixels (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::scrollToward): (WebCore::RenderListBox::autoscroll):
rendering/RenderListBox.h: (WebCore::RenderListBox::shouldPanScroll):
rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Improved the verification to avoid triggering the autoscroll/panScroll when the root object can't scroll (WebCore::RenderObject::panScroll): Calls the RenderLayer's panScrollFromPoint() method
rendering/RenderObject.h: (WebCore::RenderObject::stopPanScroll):

2008-07-09 Maxime Britto <britto@apple.com>

Reviewed by NOBODY (OOPS!).

Added the panning icon in the ressources.
Its name is compass.png to make a difference with moveCursor.png (from the WebCore ressources)

ChangeLog:
WebKit.vcproj/WebKit.rc:
WebKit.vcproj/panIcon.png: Added.
WebKit.vcproj/resource.h:
WebKitDLL.cpp: Declared the new ressource with the name "panIcon" (loadResourceIntoBuffer):

5:17 PM Changeset in webkit [35082] by eric@webkit.org

5 edits in trunk

Reviewed by bdash.

Fix copying of expected results to correct location

Scripts/run-webkit-tests:

5:12 PM Changeset in webkit [35081] by dino@apple.com

10 edits
2 moves in trunk/WebCore

Rename CSSTransformValue to WebKitCSSTransformValue as it is non-standard for
the moment. Also, WebKitCSSTransformValue is a CSSValueList (comma sep)
https://bugs.webkit.org/show_bug.cgi?id=19861

Reviewed by Hyatt

css/CSSParser.cpp:
css/CSSStyleSelector.cpp:
css/CSSTransformValue.cpp: Removed.
css/CSSTransformValue.h: Removed.
css/CSSValueList.h:
css/WebKitCSSTransformValue.cpp: Added.
css/WebKitCSSTransformValue.h: Added.

GNUmakefile.am:
WebCore.order:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

updated for new file names

4:37 PM Changeset in webkit [35080] by kmccullough@apple.com

2 edits in trunk/JavaScriptCore

2008-07-09 Kevin McCullough <kmccullough@apple.com>

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

4:24 PM Changeset in webkit [35079] by kmccullough@apple.com

2 edits in trunk/JavaScriptCore

2008-07-09 Kevin McCullough <kmccullough@apple.com>

Build fix.

profiler/HeavyProfile.cpp: (KJS::HeavyProfile::mergeProfiles):

4:17 PM Changeset in webkit [35078] by eric@webkit.org

8 edits
3 adds in trunk

Updated printing test patch

4:07 PM Changeset in webkit [35077] by kmccullough@apple.com

9 edits
2 adds in trunk/JavaScriptCore

2008-07-09 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff and Adam.

<rdar://problem/5951532> JSProfiler: Implement Bottom-Up view (19228)

This is the plumbing for bottom-up, but does not include calculating time, mostly because I'm still undclear about what the end result should look like.
This, obviously, does not include the UI to expose this in the inspector yet.

JavaScriptCore.xcodeproj/project.pbxproj:
profiler/CallIdentifier.h: (KJS::CallIdentifier::CallIdentifier): (WTF::): Added HashTraits for CallIdentifiers to be used by a HashMap.
profiler/HeavyProfile.cpp: Added. (KJS::HeavyProfile::HeavyProfile): (KJS::HeavyProfile::generateHeavyStructure): (KJS::HeavyProfile::addNode): (KJS::HeavyProfile::mergeProfiles): (KJS::HeavyProfile::addAncestorsAsChildren):
profiler/HeavyProfile.h: Added. (KJS::HeavyProfile::create): (KJS::HeavyProfile::heavyProfile): (KJS::HeavyProfile::treeProfile):
profiler/Profile.cpp: Removed old commented out includes.
profiler/Profile.h: The m_head is needed by the HeavyProfile so it is now protected as opposed to private.
profiler/ProfileNode.cpp: (KJS::ProfileNode::ProfileNode): Created a constructor to copy ProfileNodes. (KJS::ProfileNode::findChild): Added a null check to make HeavyProfile children finding easier and avoid a potential crasher.
profiler/ProfileNode.h: Mostly moved things around but also added some functionality needed by HeavyProfile. (KJS::ProfileNode::create): (KJS::ProfileNode::functionName): (KJS::ProfileNode::url): (KJS::ProfileNode::lineNumber): (KJS::ProfileNode::head): (KJS::ProfileNode::setHead): (KJS::ProfileNode::setNextSibling): (KJS::ProfileNode::actualTotalTime): (KJS::ProfileNode::actualSelfTime):
profiler/TreeProfile.cpp: Implemented the ability to get a HeavyProfile. (KJS::TreeProfile::heavyProfile):
profiler/TreeProfile.h:

3:42 PM Changeset in webkit [35076] by eric@webkit.org

6 edits
20 moves in trunk

Reviewed by weinig.

Add Content-Type support to DumpRenderTree and run-webkit-tests
and move expected.txt files to expected.webarchive

https://bugs.webkit.org/show_bug.cgi?id=15565

DumpRenderTree/cg/ImageDiffCG.cpp: (compareImages): (main):
DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG):
DumpRenderTree/mac/DumpRenderTree.mm: (dump):
Scripts/run-webkit-tests:

2:30 PM Changeset in webkit [35075] by adele@apple.com

1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fixing my typo from the last checkin

2:11 PM Changeset in webkit [35074] by hyatt@apple.com

4 edits in trunk/WebCore

2008-07-09 David Hyatt <hyatt@apple.com>

Switch transitions back to a "destination" model as far as choosing which transitions should apply on a style
change. Preserve the behavior of allowing stale transitions (in the absence of property changes) to run to
completion.

Reviewed by Dean

manual-tests/transitions.html:
manual-tests/transitions2.html:
page/AnimationController.cpp: (WebCore::ImplicitAnimation::reset): (WebCore::CompositeImplicitAnimation::animate): (WebCore::AnimationControllerPrivate::get): (WebCore::AnimationController::updateImplicitAnimations):

1:46 PM Changeset in webkit [35073] by adele@apple.com

5 edits in trunk/WebCore

2008-07-09 Michelangelo De Simone <m.des@mac.com>

Reviewed by Adele.

Added the virtual function Node::isTextControl() in order to simplify text field and textarea checks.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Clean up in PseudoReadOnly and PseudoReadWrite cases removing unnecessary checks and casts in favor of the sole isTextControl() check.
dom/Node.h: Added base isTextControl().
html/HTMLInputElement.h: Added isTextControl() which wraps HTMLInputElement::isTextField().
html/HTMLTextAreaElement.h: Added isTextControl().

1:36 PM Changeset in webkit [35072] by rwlbuis@webkit.org

66 edits in trunk

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=15431
SVGRenderStyle should store pre-modified resource URIs

Store pre-modified resource URIs to decrease string
operations during layout/rendering.

12:55 PM Changeset in webkit [35071] by andersca@apple.com

5 edits in trunk/WebKit/mac

2008-07-09 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Make some WebPlugin and WebPluginFactory SPI public.

Plugins/WebPlugin.h:
Plugins/WebPluginPrivate.h:
Plugins/WebPluginViewFactory.h:
Plugins/WebPluginViewFactoryPrivate.h:

11:35 AM Changeset in webkit [35070] by andersca@apple.com

2 edits in trunk/WebCore

2008-07-09 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz.

Remove an unused instance variable.

loader/DocumentLoader.h:

10:23 AM Changeset in webkit [35069] by mitz@apple.com

9 edits in trunk/WebCore

Reviewed by Anders Carlsson.

remove unused #includes

dom/XMLTokenizer.cpp:
html/PreloadScanner.cpp:
loader/CachedCSSStyleSheet.cpp:
loader/CachedScript.cpp:
loader/CachedXBLDocument.cpp:
loader/CachedXSLStyleSheet.cpp:
page/mac/FrameMac.mm:
xml/XSLTProcessor.cpp:

Jul 8, 2008:

11:28 PM Changeset in webkit [35068] by ggaren@apple.com

5 edits in trunk

JavaScriptCore:

2008-07-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Added support for checking if an object has custom properties in its
property map. WebCore uses this to optimize marking DOM wrappers.

WebCore:

2008-07-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Only artificially mark JS DOM wrappers if they have custom properties.

21X speedup on http://nerget.com/jstests/dom-mandelbrot.html.

No, that is not a typo.

bindings/js/JSDOMBinding.cpp: (WebCore::ScriptInterpreter::markDOMNodesForDocument):

4:46 PM Changeset in webkit [35067] by jhoneycutt@apple.com

5 edits in trunk

2008-07-08 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
unsuccessful.

Plugins/WebBaseNetscapePluginStream.h: Added new member, newStreamSuccessful.
Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member. (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set newStreamSuccessful to YES. (-[WebBaseNetscapePluginStream _destroyStream]): Only call NPP_DestroyStream if newStreamSuccessful is true.

Port r34988 to Mac: allow tests to define JavaScript to execute when
NPP_DestroyStream or NPP_URLNotify is called.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Remove initialization that happens in pluginAllocate. Look for new arguments onStreamDestroy and onURLNotify. (NPP_Destroy): Free onStreamDestroy and onURLNotify. (executeScript): Code moved from onStreamLoad. (NPP_NewStream): Call executeScript. (NPP_DestroyStream): Same. (NPP_URLNotify): Same.

3:32 PM Changeset in webkit [35066] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Fix to previous patch for handling mouse up events.

https://bugs.webkit.org/show_bug.cgi?id=18464

1:20 PM Changeset in webkit [35065] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Brady Eidson.

initialize the Archives log channel's state

platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

11:45 AM Changeset in webkit [35064] by dino@apple.com

1 edit
1 add in trunk/LayoutTests

2008-07-08 Simon Fraser <Simon Fraser>

Reviewed by Darin.

Dean forgot to add this file needed for the tests.

traversal/resources/node-iterator-009-data.xml: Added.

11:38 AM Changeset in webkit [35063] by kmccullough@apple.com

1 edit
1 add in trunk/WebCore

2008-07-08 Kevin McCullough <kmccullough@apple.com>

Added manual test for the new heavy view.

manual-tests/inspector/profiler-test-heavy-view.html: Added.

9:40 AM Changeset in webkit [35062] by Darin Adler

2 edits in trunk/WebCore

2008-07-08 Darin Adler <Darin Adler>

Reviewed by Mitz.

fix <rdar://problem/6043731> REGRESSION (3-4): RedEnvelope.com looks wrong due to OpenCube QuickMenu appVersion check

page/Navigator.cpp: (WebCore::shouldHideFourDot): Add dqm_loader.js as another filename.

9:24 AM Changeset in webkit [35061] by mitz@apple.com

18 edits in trunk

WebCore:

Reviewed by John Sullivan.

WebCore part of <rdar://problem/6008409> Need a way to disable updates in offscreen views

Added a setting, updatesWhenOffscreen(), which controls whether an
offscreen web view gets marked as needing update when its contents
change (the existing behavior) or not (a new behavior), in which case it
will be marked as needing update just before it goes on screen. The
existing behavior (updating while offscreen) remains the default.

WebCore.base.exp: Added Settings::setUpdatesWhenOffscreen().
page/FrameView.cpp: (WebCore::FrameView::shouldUpdateWhenOffscreen): Added. Returns the value from settings.
page/FrameView.h:
page/Settings.cpp: (WebCore::Settings::setUpdatesWhenOffscreen): Added.
page/Settings.h: (WebCore::Settings::updatesWhenOffscreen): Added.
platform/ScrollView.h:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents): Added code to return early and not call -setNeedsDisplayInRect: if the view is not in a visible window and the setting is not to update when offscreen.

WebKit/mac:

Reviewed by John Sullivan.

WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views

WebView/WebHTMLView.mm: (-[WebHTMLView addWindowObservers]): Added code to observe when the window goes onscreen. (-[WebHTMLView removeWindowObservers]): Added. (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to not update when offscreen, calls -setNeedsDisplay: just before it comes onscreen.
WebView/WebPreferenceKeysPrivate.h: Added preference key.
WebView/WebPreferences.m: (+[WebPreferences initialize]): Made updates when offscreen on by default. (-[WebPreferences updatesWhenOffscreen]): Added. (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added code to update the updatesWhenOffscreen setting in WebCore.

WebKitLibraries:

Reviewed by John Sullivan.

WebKitSystemInterface part of <rdar://problem/6008409> Need a way to disable updates in offscreen views

WebKitSystemInterface.h: Added WKWindowWillOrderOnScreenNotification.
libWebKitSystemInterfaceLeopard.a: Updated.
libWebKitSystemInterfaceTiger.a: Updated.

8:45 AM Changeset in webkit [35060] by ap@webkit.org

2 edits in trunk/JavaScriptGlue

Reviewed by Darin.

<rdar://problem/6058368> REGRESSION: Crash occurs in KJS::Machine after launching
Apple Installer

The problem was that JSUserObject::getCallData() was setting call type to native, but
left callData.native.function uninitialized.

JSObject.cpp: (JSUserObject::getCallData): Initialize callData.native.function. (nativeCallFunction): Call UserObjectImp::callAsFunction().

1:29 AM Changeset in webkit [35059] by Simon Hausmann

3 edits in trunk/JavaScriptCore

Prospective Gtk/Wx build fixes, add ProfileGenerator.cpp to the build.

1:22 AM Changeset in webkit [35058] by Simon Hausmann

4 edits in trunk

Fix the Qt build and the SVG filter enabled build in general.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed