⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 12, 2008:

6:18 PM Changeset in webkit [35154] by mitz@apple.com
  • 2 edits in trunk

Remove conflict markers.

4:42 PM Changeset in webkit [35153] by weinig@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

2008-07-12 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update version of Selectors API test from ​http://ejohn.org/apps/selectortest/
and fix the spelling of the authors name.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt.
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Removed.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Removed.
4:32 PM Changeset in webkit [35152] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/block/basic/min-pref-width-nowrap-floats.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Fixed a case where a float's width was added to the minimum preferred widths instead of just acting as a lower bound on the minimum preferred width (since the float can always be pushed down to be the only thing on the line).

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/block/basic/min-pref-width-nowrap-floats.html: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.png: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Added.
2:33 PM Changeset in webkit [35151] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk/WebCore

Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

<​https://bugs.webkit.org/show_bug.cgi?id=13067>

Reviewed by Darin.

Test: WebCore/manual-tests/hash-ref.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load(const KURL& newURL, const String& referrer,

FrameLoadType newLoadType, const String& frameName, Event* event,
PassRefPtr<FormState> formState)): Extracted logic into

shouldScrollToAnchor() for determining when to scroll to an anchor.

(WebCore::FrameLoader::load(DocumentLoader* loader, FrameLoadType type,

PassRefPtr<FormState> formState)): Added check for

shouldScrollToAnchor() to catch cases when the user manually added a
hash ref to the URL in the address bar. This is the bug fix.

(WebCore::FrameLoader::shouldReload): Simplified early return logic.
We only need to check if the destinationURL has a hash ref, not the
currentURL, per the comment in the method.

(WebCore::FrameLoader::shouldScrollToAnchor): Added. Logic extracted
from the FrameLoader::load(const KURL& newURL, ...) method. Fixed order
of arguments to shouldReload() since they were backwards, although the
previous logic in the method made this irrelevant.

(WebCore::FrameLoader::loadItem): Removed call to shouldReload(). Since
we're navigating to a HistoryItem, it doesn't make sense to ask whether
we need to reload the page or not. Additionally, the logic at the end
of shouldReload() is also checked in urlsMatchItem(), so there's no need
to call the method. This fixed the fast/css/target-fragment-match.html
test from continuously reloading after the other changes.

  • loader/FrameLoader.h: (WebCore::FrameLoader::shouldScrollToAnchor): Added.
  • manual-tests/hash-ref.html: Added.
  • manual-tests/resources/hash-ref-test.html: Added.
1:09 AM Changeset in webkit [35150] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-07-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk, Qt and Wx build fix: Add wtf/RefCountedLeakCounter in the
build scripts

12:49 AM Changeset in webkit [35149] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update layout test results for new compareDocumentPosition method

Jul 11, 2008:

10:51 PM Changeset in webkit [35148] by Stephanie Lewis
  • 22 edits
    1 move
    4 adds in trunk

2008-07-11 Stephanie Lewis <Stephanie Lewis>

Reviewed by Darin Adler and Oliver Hunt.

JavaScriptCore:

Refactor RefCounting Leak counting code into a common class.

In order to export the symbols I needed to put the debug defines inside the function names


Before we had a separate channel for each Logging each Leak type. Since the leak channels were only used in one location, and only at quit for simplicity I combined them all into one leak channel.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: add new class
  • kjs/nodes.cpp: remove old leak counting code
  • wtf/RefCountedLeakCounter.cpp: Added. create a common leak counting class
  • wtf/RefCountedLeakCounter.h: Added.

WebCore:

No Functionality Changed. Change all the leak counting code to use the new WTF leak counter class.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener):
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::Range::Range): (WebCore::Range::~Range):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::~RenderObject):
  • rendering/bidi.cpp: (WebCore::throw): (WebCore::BidiRun::operator delete):

WebKit

Move WebPreferences.m to objc++ so it can include the new WTF leak counting class.

  • WebKit.xcodeproj/project.pbxproj:

Disable WTF leak messages when using fast teardown. Use full document teardown while running in debug.

  • WebView/WebPreferences.m: Removed.
  • WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m. (+[WebPreferences initialize]): if running in Default enable full document teardown (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setFullDocumentTeardownEnabled:]):
  • WebView/WebView.mm: (-[WebView _close]): disable leak messages if using fast teardown

WebKitTools:

Make sure we read WebCore Leak messages. Force full document teardown for DumpRenderTree.

Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
  • Scripts/run-webkit-tests:
7:52 PM Changeset in webkit [35147] by hyatt@apple.com
  • 1 edit in trunk/WebCore/dom/Node.h

Clean up some funny whitespace from my previous Node.h checkin

7:50 PM Changeset in webkit [35146] by weinig@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

Test: svg/custom/selectSubString.html

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::selectSubString):

LayoutTests:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

  • svg/custom/acid3-test-77-expected.txt:
  • svg/custom/acid3-test-77.html:
  • svg/custom/getSubStringLength-expected.txt:
  • svg/custom/resources/getSubStringLength.js:
  • svg/custom/resources/selectSubString.js: Added.
  • svg/custom/selectSubString-expected.txt: Added.
  • svg/custom/selectSubString.html: Added.
7:28 PM Changeset in webkit [35145] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

Test: fast/dom/SelectorAPI/id-fastpath.html

  • dom/Node.cpp: (WebCore::Node::querySelector):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):

LayoutTests:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

  • fast/dom/SelectorAPI/id-fastpath-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath.html: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath.js: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt:
7:24 PM Changeset in webkit [35144] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-11 David Hyatt <​hyatt@apple.com>

Add an insertBefore method to ListHashSet to allow for insertions in the middle of the list (rather than just
at the end).

Reviewed by Anders

  • wtf/ListHashSet.h: (WTF::::insertBefore): (WTF::::insertNodeBefore):
7:13 PM Changeset in webkit [35143] by hyatt@apple.com
  • 35 edits in trunk

2008-07-11 David Hyatt <​hyatt@apple.com>

Implement the DOM level 3 compareDocumentPosition method on Node.

Reviewed by Darin

  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/Node.h:
  • dom/Node.idl:
5:29 PM Changeset in webkit [35142] by weinig@apple.com
  • 8 edits
    2 copies in trunk/JavaScriptCore

2008-07-11 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Move call function to CallData.cpp and construct to ConstructData.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/CallData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/ConstructData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/JSValue.cpp:
3:51 PM Changeset in webkit [35141] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Brady Eidson <​beidson@apple.com>

Rubberstamped by Sam

Removed unneeded export

  • WebCore.base.exp:
3:42 PM Changeset in webkit [35140] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6067178> REGRESSION: Start profile button in profiler
now profiles inspector rather than actual page (19833)

  • The JSQuarantinedObjectWrapper should use the wrapped exec state so that calls to it execute in its quarantined world.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
3:40 PM Changeset in webkit [35139] by dino@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

StyleRareNonInheritedData needs to initialize and compare
m_maskBoxImage.
<​https://bugs.webkit.org/show_bug.cgi?id=20005>

  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
3:34 PM Changeset in webkit [35138] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-07-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Bug 18885: RenderLayer::enclosingPositionedAncestor() should
look for transforms, since transforms create containing
blocks.
<​https://bugs.webkit.org/show_bug.cgi?id=18885>

Test: fast/transforms/transform-positioned-ancestor.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor):
3:30 PM Changeset in webkit [35137] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-07-11 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by Darin Adler

​http://bugs.webkit.org/show_bug.cgi?id=19978
GTK port always ends up with # at the end of resource URLs (and hence can't load files)

  • Optimized KURL::removeRef() and used it rather than setRef("") which after r35040 does the wrong thing.
  • platform/KURL.cpp: (WebCore::KURL::removeRef):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::initializeHandle):
3:07 PM Changeset in webkit [35136] by jmalonzo@webkit.org
  • 7 edits in trunk/WebKit/gtk

2008-07-08 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Christian Dywan.

Replace 'const' with G_CONST_RETURN macro to make it flexible to
disable constness

  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebhistoryitem.h:
2:46 PM Changeset in webkit [35135] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Anders.

Skip the printing tests since they fail between machines.
​https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/mac/Skipped:
2:19 PM Changeset in webkit [35134] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-07-11 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Import Selectors API test from ​http://ejohn.org/apps/selectortest/.

  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Added.
2:17 PM Changeset in webkit [35133] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by cpst.

Update results to match the buildbot (even though this now fails on my machine)
I think the failure for me is possibly leopard vs. tiger or git vs. svn.

  • webarchive/test-xml-stylesheet-expected.webarchive:
11:51 AM Changeset in webkit [35132] by sfalken@apple.com
  • 2 edits in tags/Safari-6527.1.2/WebKit/win

Merged r35130.

11:37 AM Changeset in webkit [35131] by sfalken@apple.com
  • 1 copy in tags/Safari-6527.1.2

New tag.

11:35 AM Changeset in webkit [35130] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

10:02 AM Changeset in webkit [35129] by Simon Hausmann
  • 2 edits in trunk/WebCore

008-07-11 Simon Hausmann <Simon Hausmann>

Fix the Qt/Windows build, include windows.h for HWND directly
instead of implicit inclusion through Timer.h.

9:54 AM Changeset in webkit [35128] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix popularity tracking for cached resources, which regressed in r23923
  • loader/Cache.cpp: (WebCore::Cache::requestResource): Changed to increase the access count whenever this function returns a CachedResource and the cache is enabled, instead of only when creating a new CachedResources. The incorrect behavior resulted in all resources in the cache having an access count of exactly 1 at all times. (WebCore::Cache::requestUserCSSStyleSheet): Ditto.
8:43 AM Changeset in webkit [35127] by Simon Hausmann
  • 11 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Enable Netscape plugins for the Qt/Windows build.

This required various smaller fixes across a wider set of
files described below.

5:08 AM Changeset in webkit [35126] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-11 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Enable Database and Icondatabase functionality for the Qt/Windows
build when building inside Qt, as we can use the builtin copy of
sqlite then.

4:51 AM Changeset in webkit [35125] by dino@apple.com
  • 5 edits in trunk/LayoutTests

Updated test results for
​https://bugs.webkit.org/show_bug.cgi?id=19864

  • css3/transform-computed-style-001-expected.txt:
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:28 AM Changeset in webkit [35124] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

Fix compile with MinGW since it does not like friend static function.

  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
3:33 AM Changeset in webkit [35123] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix Qt/Win32 build.

  • platform/graphics/qt/GraphicsContextQt.cpp:
12:34 AM Changeset in webkit [35122] by weinig@apple.com
  • 21 edits
    9 adds
    2 deletes in trunk

WebCore:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • Namespace resolution is done after parsing by iterating over all the parts of the CSSSelector.

Tests: fast/dom/SelectorAPI/NSResolver-basic.xhtml

fast/dom/SelectorAPI/NSResolver-exceptions.xhtml

  • GNUmakefile.am: Updated with new files.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSDOMBinding.cpp: (WebCore::execStateFromNode):
  • bindings/js/JSDOMBinding.h: Move execStateFromNode here from NodeFilter.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::querySelector): Don't throw a NOT_SUPPORTED_ERR for NSResolver and instead create one if the argument is not undefined or null. (WebCore::JSDocument::querySelectorAll): Ditto.
  • bindings/js/JSDocumentFragmentCustom.cpp: (WebCore::JSDocumentFragment::querySelector): Ditto. (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::querySelector): Ditto. (WebCore::JSElement::querySelectorAll): Ditto.
  • bindings/js/JSNSResolver.cpp: Added. (WebCore::JSNSResolver::JSNSResolver): (WebCore::JSNSResolver::mark): (WebCore::JSNSResolver::lookupNamespaceURI): Try and get the function from the passed in argument, either the value itself, or the result of getting the lookupNamespaceURI property, and call it. (WebCore::toNSResolver):
  • bindings/js/JSNSResolver.h: Added. (WebCore::JSNSResolver::create):
  • dom/Document.idl: Update with NSResolver parameter.
  • dom/DocumentFragment.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NSResolver.h: Added. (WebCore::NSResolver::~NSResolver): (WebCore::NSResolver::mark): Abstract base class.
  • dom/NSResolver.idl: Added.
  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::forEachSelector): Functions to iterate over all parts of the selector.

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
Functor to be passed to forEachSelector to determine if a selector
needs namespace resolution, for the case when no NSResolver is passed
and we need to determine whether to throw a NAMESPACE_ERR.

(WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
(WebCore::ResolveNamespaceFunctor::operator()):
Functor to resolve namespaces for the selector.

(WebCore::selectorNeedsNamespaceResolution):
(WebCore::resolveNamespacesForSelector):
(WebCore::Node::querySelector): Resolve namepspaces, including the defaultNamespace
if a NSResolver is passed in.
(WebCore::Node::querySelectorAll): Ditto.

  • dom/Node.h:
  • dom/NodeFilter.cpp:
  • dom/NodeFilter.h:
  • dom/NodeIterator.h: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
  • dom/TreeWalker.h: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Use the version of execStateFromNode in JSDOMBinding.

LayoutTests:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-basic.xhtml: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Added.
  • fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Removed.
  • fast/dom/SelectorAPI/not-supported-NSResolver.html: Removed.
  • fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Added.
Note: See TracTimeline for information about the timeline view.