⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 13, 2008:

10:23 PM Changeset in webkit [35157] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebCore

2008-07-13 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt and Dan Bernstein.

Fix for <rdar://problem/5888127>
​https://bugs.webkit.org/show_bug.cgi?id=18699

  • Match Firefox in restricting the size of custom cursor to images to 128x128 px.
  • Restrict custom cursor hotspots to values within the bounds of the cursor image.
  • manual-tests/cursor-max-size.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
7:46 PM Changeset in webkit [35156] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Add wtf/RefCountedLeakCounter to the project.

3:50 PM Changeset in webkit [35155] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

Jul 12, 2008:

6:18 PM Changeset in webkit [35154] by mitz@apple.com
  • 2 edits in trunk

Remove conflict markers.

4:42 PM Changeset in webkit [35153] by weinig@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

2008-07-12 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update version of Selectors API test from ​http://ejohn.org/apps/selectortest/
and fix the spelling of the authors name.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt.
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Removed.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Removed.
4:32 PM Changeset in webkit [35152] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/block/basic/min-pref-width-nowrap-floats.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Fixed a case where a float's width was added to the minimum preferred widths instead of just acting as a lower bound on the minimum preferred width (since the float can always be pushed down to be the only thing on the line).

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/block/basic/min-pref-width-nowrap-floats.html: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.png: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Added.
2:33 PM Changeset in webkit [35151] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk/WebCore

Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

<​https://bugs.webkit.org/show_bug.cgi?id=13067>

Reviewed by Darin.

Test: WebCore/manual-tests/hash-ref.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load(const KURL& newURL, const String& referrer,

FrameLoadType newLoadType, const String& frameName, Event* event,
PassRefPtr<FormState> formState)): Extracted logic into

shouldScrollToAnchor() for determining when to scroll to an anchor.

(WebCore::FrameLoader::load(DocumentLoader* loader, FrameLoadType type,

PassRefPtr<FormState> formState)): Added check for

shouldScrollToAnchor() to catch cases when the user manually added a
hash ref to the URL in the address bar. This is the bug fix.

(WebCore::FrameLoader::shouldReload): Simplified early return logic.
We only need to check if the destinationURL has a hash ref, not the
currentURL, per the comment in the method.

(WebCore::FrameLoader::shouldScrollToAnchor): Added. Logic extracted
from the FrameLoader::load(const KURL& newURL, ...) method. Fixed order
of arguments to shouldReload() since they were backwards, although the
previous logic in the method made this irrelevant.

(WebCore::FrameLoader::loadItem): Removed call to shouldReload(). Since
we're navigating to a HistoryItem, it doesn't make sense to ask whether
we need to reload the page or not. Additionally, the logic at the end
of shouldReload() is also checked in urlsMatchItem(), so there's no need
to call the method. This fixed the fast/css/target-fragment-match.html
test from continuously reloading after the other changes.

  • loader/FrameLoader.h: (WebCore::FrameLoader::shouldScrollToAnchor): Added.
  • manual-tests/hash-ref.html: Added.
  • manual-tests/resources/hash-ref-test.html: Added.
1:09 AM Changeset in webkit [35150] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-07-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk, Qt and Wx build fix: Add wtf/RefCountedLeakCounter in the
build scripts

12:49 AM Changeset in webkit [35149] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update layout test results for new compareDocumentPosition method

Note: See TracTimeline for information about the timeline view.