Timeline
Jul 14, 2008:
- 11:16 PM Changeset in webkit [35178] by
-
- 2 edits in trunk/WebCore
- Tiger build fix
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- 7:17 PM Changeset in webkit [35177] by
-
- 4 edits in trunk/JavaScriptCore
Fix https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.
Reviewed by Sam Weinig.
- kjs/ustring.cpp:
(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.
- kjs/ustring.h:
- profiler/CallIdentifier.h:
(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.
- 5:16 PM Changeset in webkit [35176] by
-
- 5 edits in trunk
WebCore:
Reviewed by John Sullivan.
- WebCore part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Changed to account for the case of drawing into a bitmap context that is not a window's backing store. In that case, -displayRectIgnoringOpacity:inContext: is used to redirect the drawing to the correct context, after setting up the right transform on it. For subframes, additional code ensures that the scroll view will not paint the background behind a transparent frame.
WebKit/mac:
Reviewed by John Sullivan.
- WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed to account for the case of being drawn into a bitmap context that is not a window's backing store. In that case, there are no valid "rects being drawn" to clip to.
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Added an override of this NSView method which is used in for -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing machinery overrides, it sets subviews aside before invoking the superclass implementation. On Tiger, it also updates the layout.
- 4:15 PM Changeset in webkit [35175] by
-
- 2 edits in trunk/WebKit/win
Don't include autoversion.h in WebKitDLL.cpp.
autoversion.h changes for every build, so we don't want to include it unless necessary.
Rubber stamped by Ada Chan.
- WebKitDLL.cpp:
- 3:43 PM Changeset in webkit [35174] by
-
- 14 edits6 adds in trunk
<rdar://problem/6038106> AXChildren returned for this web area is null
The accessibility of image maps needed to be brought inline with the new AX architecture
- 3:31 PM Changeset in webkit [35173] by
-
- 5 edits in trunk/WebCore
2008-07-14 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Remove unused ExceptionCode parameter from compareDocumentPosition.
- dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
- dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
- dom/Node.h:
- dom/Node.idl:
- 3:10 PM Changeset in webkit [35172] by
-
- 13 edits9 adds in trunk
2008-07-14 David Hyatt <hyatt@apple.com>
Fix for bugzilla bug 5476, link and style elements should be allowed outside the <head>.
Reviewed by Sam
Added fast/css/style-outside-head.html
Added fast/css/link-outside-head.html
- dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode): (WebCore::Document::removeStyleSheetCandidateNode): (WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::insertedIntoDocument): (WebCore::ProcessingInstruction::removedFromDocument): (WebCore::ProcessingInstruction::finishParsingChildren):
- dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::setCreatedByParser):
- dom/StyleElement.cpp: (WebCore::StyleElement::removedFromDocument):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::):
- html/HTMLElementFactory.cpp: (WebCore::linkConstructor):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::insertedIntoDocument): (WebCore::HTMLLinkElement::removedFromDocument): (WebCore::HTMLLinkElement::finishParsingChildren):
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::setCreatedByParser):
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::removedFromDocument):
- 3:08 PM Changeset in webkit [35171] by
-
- 2 edits in trunk/WebKitTools
2008-07-14 Steve Falkenburg <sfalken@apple.com>
Build fix.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 2:48 PM Changeset in webkit [35170] by
-
- 2 edits in trunk/WebKitTools
Attempted Windows build fix
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add CoreFoundation/OSXCompatibilityHeadersGNUCompatibility to the include path.
- 2:21 PM Changeset in webkit [35169] by
-
- 2 edits in trunk/WebCore
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Sort interface extended attributes to appease *the* Mark Rowe.
- page/DOMWindow.idl:
- 2:16 PM Changeset in webkit [35168] by
-
- 4 edits2 adds in trunk
WebCore:
2008-07-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE
Don't bubble the scroll event.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
LayoutTests:
2008-07-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE
Add test.
- fast/events/scroll-event-does-not-bubble-expected.txt: Added.
- fast/events/scroll-event-does-not-bubble.html: Added.
- 1:58 PM Changeset in webkit [35167] by
-
- 2 edits in trunk/WebCore
2008-07-14 Adele Peterson <adele@apple.com>
Reviewed by Geoff.
Fix for <rdar://problem/5784890> REGRESSION (Safari 3): Can't edit SpeedStream 4100 DSL modem settings
The web server on this particular piece of hardware doesn't handle "text/xml" in the
Accept header if the headers are sent in a certain order. Safari 2 used to send "*/*" in
the Accept header. Firefox 2 sent "text/xml" but in an acceptable order for the web
server. And Firefox 3 doesn't send "text/xml" at all in the Accept header since it
is being deprecated in favor of "application/xml". We decided that the best solution is
to match Firefox 3 and stop sending "text/xml" in the Accept header.
No test. There appears to be no way to get the raw headers in the original order in perl/php.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- 1:56 PM Changeset in webkit [35166] by
-
- 5 edits3 adds in trunk
WebCore:
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Fix for <rdar://problem/5769819>
Test: http/tests/security/cross-frame-access-object-prototype.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyAttributes): Perform security check. (WebCore::JSDOMWindow::defineGetter): Ditto. (WebCore::JSDOMWindow::defineSetter): Ditto. (WebCore::JSDOMWindow::lookupGetter): Ditto. (WebCore::JSDOMWindow::lookupSetter): Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Add support for custom versions of all the core JSObject functionality.
- page/DOMWindow.idl: Override remaining core JSObject functionality, to inject security checks.
LayoutTests:
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Test for <rdar://problem/5769819>
- http/tests/security/cross-frame-access-object-prototype-expected.txt: Added.
- http/tests/security/cross-frame-access-object-prototype.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-object-prototype-test.html: Added.
- 1:37 PM Changeset in webkit [35165] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-14 David Hyatt <hyatt@apple.com>
Fix a crashing bug in ListHashSet's -- operator. Make sure that end() can be -- by special-casing the null
position.
Reviewed by Maciej
- wtf/ListHashSet.h: (WTF::ListHashSetConstIterator::operator--):
- 1:04 PM Changeset in webkit [35164] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-14 David Hyatt <hyatt@apple.com>
Buidl fix. Make sure the second insertBefore method returns a value.
- wtf/ListHashSet.h: (WTF::::insertBefore):
- 12:21 PM Changeset in webkit [35163] by
-
- 9 edits in trunk
Windows build fixes
Windows build fix
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Added include/pthreads to the include path.
WebCore:
Windows build fixes
- WebCore.vcproj/WebCore.vcproj: Add include/pthreads to the include path.
- bindings/scripts/CodeGeneratorCOM.pm: Touched this to force COM bindings to regenerate.
- loader/FTPDirectoryDocument.cpp:
- loader/FTPDirectoryParser.cpp: Fixed some duplicate macro definitions now that we're including pthread.h again.
WebKit/win:
Windows build fix
- WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Updated to match -[WebCoreStatistics javaScriptsObjectCount].
- 11:23 AM Changeset in webkit [35162] by
-
- 8 edits in trunk
Reviewed by Kevin McCullough.
Make JSGlobalData refcounted in preparation to adding a way to create contexts that share
global data.
- JavaScriptCore.exp:
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::create):
- kjs/JSGlobalData.h: Made contructor private, and added a static create() method. Made the class inherit from RefCounted.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::globalData): JSGlobalData is now owned by JSGlobalObject (except for the shared one, and the common WebCore one, which are never deleted).
- kjs/Shell.cpp: (main): Create JSGlobalData with create() method.
WebCore:
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData): Create JSGlobalData with create() method.
- 7:13 AM Changeset in webkit [35161] by
-
- 2 edits in trunk/WebCore
2008-07-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Make listDirectory() in the Qt port work with empty namefilters.
Don't include . and .. to avoid scanning the parent directory.
- 5:12 AM Changeset in webkit [35160] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-14 Simon Hausmann <Simon Hausmann>
Fix the single-threaded build.
- 4:28 AM Changeset in webkit [35159] by
-
- 40 edits2 adds in trunk
Reviewed by Geoff Garen.
Eliminate per-thread JavaScript global data instance support and make arbitrary
global data/global object combinations possible.
- 3:20 AM Changeset in webkit [35158] by
-
- 4 edits in trunk/WebCore
2008-07-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
MinGW build fixes
- plugins/win/PluginDatabaseWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
- svg/SynchronizableTypeWrapper.h: (WebCore::::SynchronizableTypeWrapper):
Jul 13, 2008:
- 10:23 PM Changeset in webkit [35157] by
-
- 2 edits1 add in trunk/WebCore
2008-07-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt and Dan Bernstein.
Fix for <rdar://problem/5888127>
https://bugs.webkit.org/show_bug.cgi?id=18699
- Match Firefox in restricting the size of custom cursor to images to 128x128 px.
- Restrict custom cursor hotspots to values within the bounds of the cursor image.
- manual-tests/cursor-max-size.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
- 7:46 PM Changeset in webkit [35156] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Add wtf/RefCountedLeakCounter to the project.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 3:50 PM Changeset in webkit [35155] by
-
- 2 edits in trunk/WebCore
wx build fix.
