⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 16, 2008:

11:51 PM Changeset in webkit [35214] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-16 Jon Honeycutt <​jhoneycutt@apple.com>

CygwinDownloader fails to install necessary packages
​https://bugs.webkit.org/show_bug.cgi?id=20075

Reviewed by Mark Rowe.

  • CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken mirrors removed in r34116. Set MIME type to application/octet-stream.
11:20 PM Changeset in webkit [35213] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-16 Jon Honeycutt <​jhoneycutt@apple.com>

CygwinDownloader's make-zip.sh script fails
​https://bugs.webkit.org/show_bug.cgi?id=20074

Reviewed by Mark Rowe.

  • CygwinDownloader/cygwin-downloader.py:
11:17 PM Changeset in webkit [35212] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-07-16 Jon Honeycutt <​jhoneycutt@apple.com>

REGRESSION: Can't create windowless plug-in with Flash 9
​https://bugs.webkit.org/show_bug.cgi?id=20070

Reviewed by Mark Rowe.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Reverse argument order; PlatformModuleVersion constructor takes leastSig, mostSig.
11:13 PM Changeset in webkit [35211] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by mitz.

Make ATSULayoutParameters a real C++ class
(Give it a destructor to clean up after itself)
(Also use OwnArrayPtr instead of manual member cleanup)

  • platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::~ATSULayoutParameters): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
11:12 PM Changeset in webkit [35210] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by mitz.

Make ownership of copied UChar buffer clearer
(and more leak-proof) by using a OwnArrayPtr.

No functional changes, thus no tests.

  • platform/graphics/mac/FontMac.mm: (WebCore::copyRunForDirectionalOverrideIfNecessary): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::offsetForPositionForComplexText):
10:27 PM Changeset in webkit [35209] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix JavaScript in 64-bit by using a pointer-sized integer
type in the Register union. Also includes a rename of
the intType constant to IntType.

Rubber-stamped by Geoff Garen.

  • VM/Machine.cpp:

(KJS::Machine::initializeCallFrame):

  • VM/Register.h:

(KJS::Register::):
(KJS::Register::Register):

9:04 PM Changeset in webkit [35208] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Sam.

Split out TextRun into its own header file.
Re-order members to place all bools together
(to allow compilers to better pack the struct)

No functional changes, thus no tests.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h: Moved TextRun into its own file.
  • platform/graphics/TextRun.h: Split out from Font.h
6:16 PM Changeset in webkit [35207] by dino@apple.com
  • 3 edits
    3 adds in trunk

2008-07-16 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

AnimationController needs to adjust z-index in the blended
style in case opacity or transform were changed by blending.

​https://bugs.webkit.org/show_bug.cgi?id=20047

Test: transitions/opacity-transition-zindex.html

  • page/AnimationController.cpp: (WebCore::AnimationController::updateImplicitAnimations):
5:41 PM Changeset in webkit [35206] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=20052
Export the tag & attribute names as string literals for SVGNames/XLinkNames and one property in HTMLNames.

5:22 PM Changeset in webkit [35205] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

Rubber stamped by Eric.
Update pixel test results for two tests that have been changed.

4:34 PM Changeset in webkit [35204] by Nikolas Zimmermann
  • 46 edits
    1 add in trunk/WebCore

Reviewed by Eric.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=10745 (SVGLength object needs some weight loss)
Don't store a context pointer in SVGLength, saving memory.

3:47 PM Changeset in webkit [35203] by ggaren@apple.com
  • 22 edits in trunk

JavaScriptCore:

2008-07-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


First step toward putting doubles in registers: Turned Register into a
proper abstraction layer. It is no longer possible to cast a Register
to a JSValue*, or a Register& to a JSValue*&, or to access the union
inside a Register directly.


SunSpider reports no change.


In support of this change, I had to make the following mechanical changes
in a lot of places:


  1. Clients now use explicit accessors to read data out of Registers, and implicit copy constructors to write data into registers.


So, assignment that used to look like


x.u.jsValue = y;


now looks like


x = y;


And access that used to look like


x = y.u.jsValue;


now looks like


x = y.jsValue();

  1. I made generic flow control specific in opcodes that made their flow control generic by treating a Register& as a JSValue*&. This had the added benefit of removing some exception checking branches from immediate number code.
  1. I beefed up PropertySlot to support storing a Register* in a property slot. For now, only JSVariableObject's symbolTableGet and symbolTablePut use this functionality, but I expect more clients to use it in the future.


  1. I changed ArgList to be a buffer of Registers, not JSValue*'s, and I changed ArgList iterator clients to iterate Registers, not JSValue*'s.

WebCore:

2008-07-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Support for JavaScriptCore's first step toward putting doubles in
registers: Treat ArgList iterators as Register*'s, not JSValue*'s.

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
2:41 PM Changeset in webkit [35202] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed build.

  • kjs/JSGlobalObject.cpp:
2:24 PM Changeset in webkit [35201] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Anders Carlsson.
Add missing layout test results.

1:37 PM Changeset in webkit [35200] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-16 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam and Geoff.

<rdar://problem/5958840> Navigating to another page while profiler is
attached results in slow JavaScript for all time.

  • The UNLIKELY keeps this from being a sunspider performance regression.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::~JSGlobalObject): Stop the profiler associated with this exec state.
1:19 PM Changeset in webkit [35199] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-07-16 Sam Weinig <​sam@webkit.org>

Reviewed by Steve Falkenburg.

Replace adopting UString constructor in favor of explicit
static adopt method.

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
  • kjs/StringConstructor.cpp: (KJS::stringFromCharCode):
  • kjs/StringPrototype.cpp: (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase):
  • kjs/ustring.cpp: (KJS::UString::adopt):
  • kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString):
3:14 AM Changeset in webkit [35198] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-16 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

​http://trolltech.com/developer/task-tracker/index_html?method=entry&id=216179
Fix potential crash (on Qt for Windows port) when performing JavaScript date
conversion.

  • kjs/DateMath.cpp: (KJS::getLocalTime): For the Qt port, prefer to use Windows code, i.e. localtime_s() instead of localtime() since the latter might crash (on Windows) given a non-sensible, e.g. NaN, argument.
1:24 AM Changeset in webkit [35197] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix a typo in ChangeLog.

1:20 AM Changeset in webkit [35196] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders and Geoff.

​https://bugs.webkit.org/show_bug.cgi?id=20023
Failed assertion in PropertyNameArray.cpp

This is already tested by testapi.

  • API/JSObjectRef.cpp: (JSPropertyNameAccumulatorAddName): Add the string to identifier table to appeaase PropertyNameArray.
1:07 AM Changeset in webkit [35195] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Dereference identifiers when deleting a hash table (fixes leaks with private JSGlobalData
objects).

  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData):
  • kjs/lookup.cpp: (KJS::HashTable::deleteTable):
  • kjs/lookup.h:
  • kjs/lexer.cpp: (KJS::Lexer::~Lexer) HashTable cannot have a destructor, because check-for-global-initializers complains about having a global constructor then.
12:58 AM Changeset in webkit [35194] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Check pthread_key_create return value.

This check was helpful when debugging a crash in run-webkit-tests --threaded that happened
because JSGlobalData objects were not deleted, and we were running out of pthread keys soon.
It also looks useful for production builds.

  • wtf/ThreadSpecific.h: (WTF::::ThreadSpecific):

Jul 15, 2008:

9:53 PM Changeset in webkit [35193] by weinig@apple.com
  • 19 edits
    3 adds in trunk

WebKitTools:

2008-07-15 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Refactor accessibility testing code.

We now have:

  • AccessibilityController Controller which has access to the WebView and can provide the focused element, root element and in the future, elementAtPoint.
  • AccessibilityUIElement Object which provides access to the data provided by the Accessibility APIs.
  • DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): (getRootElementCallback): (AccessibilityController::getJSClass):
  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityUIElement.cpp: Added. (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (finalize): (AccessibilityUIElement::makeJSAccessibilityUIElement): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h: Added. (AccessibilityUIElement::platformUIElement):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added. (AccessibilityUIElement::AccessibilityUIElement): (descriptionOfValue): (attributesOfElement): (nsStringToJSStringRef): (concatenateAttributeAndValue): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue):

LayoutTests:

2008-07-15 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Update for refactored accessibility testing code.

  • accessibility/aria-describedby-on-input.html:
  • accessibility/aria-labelledby-on-input.html:
  • accessibility/aria-range-value.html:
  • accessibility/aria-range.html:
  • accessibility/aria-roles.html:
  • accessibility/aria-slider.html:
  • accessibility/aria-spinbutton.html:
  • accessibility/document-attributes.html:
  • accessibility/image-map1.html:
  • accessibility/image-map2.html:
  • accessibility/internal-link-anchors.html:
  • accessibility/radio-button-checkbox-size.html:
  • accessibility/radio-button-group-members.html:
9:11 PM Changeset in webkit [35192] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

9:10 PM Changeset in webkit [35191] by mrowe@apple.com
  • 1 copy in tags/Safari-6527.2

New tag.

8:17 PM Changeset in webkit [35190] by britto@apple.com
  • 9 edits in trunk/WebCore

2008-07-15 Maxime Britto <​britto@apple.com>

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=17589
<rdar://problem/5770893>
Retrieve the wheel sensitivity setting from windows system settings for the horizontal and the vertical scrolling.
Allows the page scrolling with the wheel (if activated in windows settings) on both horizontal and vertical ways
For the other platforms, nothing is changed but if someone want to activate this feature
he/she has to retrieve the settings and fill out the m_lineScrollSensitivity and/or m_charScrollSensitivity in his/her PlatformWheelEvent constructor.

  • ChangeLog:
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): static inline function to avoid copy/paste in the member functions (WebCore::EventHandler::handleWheelEvent): Call to the above mentionned static inline function with the right parameters
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): Now returns the delta multiplied by the user settings for the number of lines to scroll (WebCore::PlatformWheelEvent::deltaY): Now returns the delta multiplied by the user settings for the number of chars to scroll (WebCore::PlatformWheelEvent::isPageXScrollModeEnabled): (WebCore::PlatformWheelEvent::isPageYScrollModeEnabled):
  • platform/gtk/WheelEventGtk.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/ScrollViewWin.cpp: Added the page scroll (horiz/vertical) and reduced the number of pixels to scroll per line to keep the standard behavior with the factor (WebCore::adjustDeltaForPageScrollMode): static inline function to avoid copy/paste in the member functions (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/win/WheelEventWin.cpp: Retrieves the new values by using the win32 API. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
8:09 PM Changeset in webkit [35189] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix - adding AccessibilityImageMapLink.cpp to the wx build.

4:46 PM Changeset in webkit [35188] by kmccullough@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-07-15 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Dan.

<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)

Frames did not set the createdByParser flag even when they were.

  • html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor):

LayoutTests:

2008-07-15 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Dan.

<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)

  • fast/forms/form-and-frame-interaction-retains-values-expected.txt: Added.
  • fast/forms/form-and-frame-interaction-retains-values.html: Added.
  • fast/forms/resources/form-and-frame-interaction-retains-values-main.html: Added.
  • fast/forms/resources/form-and-frame-interaction-retains-values-submit.html: Added.
4:20 PM Changeset in webkit [35187] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • update results for the addition of the compareDocumentPosition-related constants
  • fast/dom/domListEnumeration-expected.txt:
3:53 PM Changeset in webkit [35186] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/reflections/inline-crash.html

  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): Added setHasReflection(false). Inline flows never have reflections.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/reflections/inline-crash.html: Added.
  • platform/mac/fast/reflections/inline-crash-expected.checksum: Added.
  • platform/mac/fast/reflections/inline-crash-expected.png: Added.
  • platform/mac/fast/reflections/inline-crash-expected.txt: Added.
2:24 PM Changeset in webkit [35185] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

2008-07-14 David Hyatt <​hyatt@apple.com>

Allow <style> and <link> pretty much anywhere. They will still be moved to the <head> if
no <body> exists yet though.

Reviewed by Sam

Added fast/css/style-parsed-outside-of-head.html

  • html/HTMLElement.cpp: (WebCore::inlineTagList):
10:48 AM Changeset in webkit [35184] by kmccullough@apple.com
  • 10 edits in trunk

JavaScriptCore:

2008-07-15 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setProfileGroup): (KJS::JSGlobalObject::profileGroup):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h: (KJS::ProfileGenerator::profileGroup):
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling): (KJS::dispatchFunctionToProfiles): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute):

WebCore:

2008-07-15 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clear): (WebCore::ScriptController::initScript):
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
10:06 AM Changeset in webkit [35183] by adele@apple.com
  • 2 edits in trunk/LayoutTests

2008-07-15 Adele Peterson <​adele@apple.com>

Updating results for my fix to <rdar://problem/5784890>.

  • http/tests/misc/xhtml-expected.txt:
9:49 AM Changeset in webkit [35182] by Adam Roben
  • 9 edits in trunk

Add WebKit[Set]ShouldUseFontSmoothing functions

WebCore:

WebCore part of adding WebKit[Set]ShouldUseFontSmoothing functions

<rdar://6059127>

Reviewed by John Sullivan.

  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Pass the result of WebCoreShouldUseFontSmoothing() into wkSetFontSmoothingStyle.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetShouldUseFontSmoothing): (WebCore::WebCoreShouldUseFontSmoothing): Added.
  • platform/win/WebCoreTextRenderer.h:

WebKit/win:

Add WebKit[Set]ShouldUseFontSmoothing functions

<rdar://6059127>

Reviewed by John Sullivan.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Export the new functions.
  • WebKitGraphics.cpp: (WebKitSetShouldUseFontSmoothing): (WebKitShouldUseFontSmoothing): Call through to the relevant WebCore functions.
  • WebKitGraphics.h:
9:32 AM Changeset in webkit [35181] by mitz@apple.com
  • 7 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

  • platform/mac/tables/mozilla/bugs/bug26553-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.png:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
8:34 AM Changeset in webkit [35180] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Add AccessibilityImageMapLink.{cpp,h} to the project.
1:14 AM Changeset in webkit [35179] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2008-07-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix for the Gtk+ and Qt platform.

  • GNUmakefile.am: Add AccessibilityImageMapLink.cpp to the build
  • WebCore.pro: Add AccessibilityImageMapLink.cpp to the build
Note: See TracTimeline for information about the timeline view.