Context Navigation

← Previous Period
Next Period →

Timeline

Jul 18, 2008:

9:40 PM Changeset in webkit [35247] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):

9:11 PM Changeset in webkit [35246] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix.

kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):

6:44 PM Changeset in webkit [35245] by oliver@apple.com

37 edits
2 adds in trunk

Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Cameron Zwarich

Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.

6:36 PM Changeset in webkit [35244] by britto@apple.com

8 edits
3 adds in trunk

2008-07-18 Maxime Britto <britto@apple.com>

Reviewed by Adele.

Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.

Test: fast/events/autoscroll-with-non-scrollable-parent.html

ChangeLog:
page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>

Reviewed by Adele.

Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes

ChangeLog:
fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
fast/events/autoscroll-with-non-scrollable-parent.html: Added.
fast/events/resources/big-page-with-input.html: Added.

5:22 PM Changeset in webkit [35243] by weinig@apple.com

4 edits in trunk/WebCore

2008-07-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest

Overload XMLHttpRequests send() method to accept File tokens.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
xml/XMLHttpRequest.h:

3:18 PM Changeset in webkit [35242] by ggaren@apple.com

34 edits in trunk

JavaScriptCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Three renames:

"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

JavaScriptGlue:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Three renames:

"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

ChangeLog:
JSObject.cpp: (JSUserObject::getCallData):

WebCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Three renames:

"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

3:15 PM Changeset in webkit [35241] by adele@apple.com

2 edits in trunk/WebCore

2008-07-18 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):

3:04 PM Changeset in webkit [35240] by Simon Fraser

2 edits in trunk/WebCore

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by mitz

Remove braces around single-line conditional.

css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):

2:59 PM Changeset in webkit [35239] by Simon Fraser

5 edits in trunk

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.

https://bugs.webkit.org/show_bug.cgi?id=20008

Testcase: LayoutTests/fast/css/computed-style-without-renderer

LayoutTests/fast/css/computed-style-expected.txt

2:44 PM Changeset in webkit [35238] by Simon Fraser

2 edits in trunk/WebCore

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086

2:25 PM Changeset in webkit [35237] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized <= for immediate number cases.

SunSpider reports no overall change, but a 10% speedup on access-nsieve.

2:03 PM Changeset in webkit [35236] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Fix some casts added in a previous build fix to match the style used
throughout WebKit.

Rubber-stamped by Sam Weinig.

VM/Machine.cpp:

(KJS::Machine::initializeCallFrame):

VM/Register.h:

(KJS::Register::Register):

11:31 AM Changeset in webkit [35235] by ap@webkit.org

2 edits in trunk/LayoutTests

Update expected results for a recently added test to what is seen when running the
full test suite.

fast/forms/form-and-frame-interaction-retains-values-expected.txt:

8:31 AM Changeset in webkit [35234] by ddkilzer@apple.com

7 edits in trunk

Bug 19975: [OpenBSD] Patches to enable build of WebKit

JavaScriptCore:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

Support for OpenBSD, mostly threading and libm tweaks.

kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
kjs/config.h: OpenBSD also provides <pthread_np.h>
wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro

WebKitTools:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.

8:21 AM Changeset in webkit [35233] by ddkilzer@apple.com

2 edits in trunk/WebKitSite

Fixed indentation of example code for C++ pointers/references!

coding/coding-style.html:

8:15 AM Changeset in webkit [35232] by ddkilzer@apple.com

2 edits in trunk/WebKitSite

2008-07-18 Robert Blaut <webkit@blaut.biz>

Reviewed by David Kilzer.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions

coding/coding-style.html:

Jul 17, 2008:

9:00 PM Changeset in webkit [35231] by ggaren@apple.com

7 edits in trunk/JavaScriptCore

2008-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Next step toward putting doubles in registers: Store constant pool
entries as registers, not JSValue*s.

SunSpider reports no change.

4:53 PM Changeset in webkit [35230] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by John Sullivan and Oliver Hunt.

A tiny bit of tidying in function call register allocation.

This patch saves one register when invoking a function expression and/or
a new expression that is stored in a temporary.

Since it's just one register, I can't make a testcase for it.

VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall): No need to ref the function we're calling or its base. We'd like the call frame to overlap with them, if possible. op_call will read the function and its base before writing the call frame, so this is safe.

kjs/nodes.cpp: (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing, for the same reasons stated above.

(KJS::FunctionCallValueNode::emitCode): ditto

3:28 PM Changeset in webkit [35229] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

2008-07-17 Steve Falkenburg <sfalken@apple.com>

Build fix.

kjs/InternalFunction.cpp:

2:42 PM Changeset in webkit [35228] by ggaren@apple.com

5 edits
3 adds in trunk

JavaScriptCore:

2008-07-17 Sam Weinig <sam@webkit.org>

Roll out r35199 as it is causing failures on the PPC build.

LayoutTests:

2008-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by David Kilzer.

Test for https://bugs.webkit.org/show_bug.cgi?id=20067
Support function.name (Firefox extension)

fast/js/function-name-expected.txt: Added.
fast/js/function-name.html: Added.
fast/js/resources/function-name.js: Added.

2:11 PM Changeset in webkit [35227] by weinig@apple.com

6 edits in trunk/JavaScriptCore

2008-07-17 Sam Weinig <sam@webkit.org>

Roll out r35199 as it is causing failures on the PPC build.

1:39 PM Changeset in webkit [35226] by ggaren@apple.com

3 edits
3 adds in trunk

JavaScriptCore:

2008-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed <rdar://problem/6081636> Functions calls use more temporary
registers than necessary

Holding a reference to the last statement result register caused each
successive statement to output its result to an even higher register.

Happily, statements don't actually need to return a result register
at all. I hope to make this clearer in a future cleanup patch,
but this change will fix the major bug for now.

kjs/nodes.cpp: (KJS::statementListEmitCode):

LayoutTests:

2008-07-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Test for <rdar://problem/6081636> Functions calls use more temporary
registers than necessary

fast/js/function-call-register-allocation.html: Added.
fast/js/function-call-register-allocation-expected.txt: Added.
fast/js/resources/function-call-register-allocation.js: Added.

12:49 PM Changeset in webkit [35225] by rwlbuis@webkit.org

4 edits
2 adds in trunk

Reviewed by rwlbuis@gmail.com

https://bugs.webkit.org/show_bug.cgi?id=19965

Added "@"{ident} rule (below other @-rules) to use flex for longest match (if an earlier rule - e.g. @media - also matches then flex chooses that one

however, if a longer match - e.g. @mediaall matches flex will choose that)

Updated grammar to defined ATKEYWORD token and to use that instead of '@' in the error recovery grammar.

Test: css2.1/atrule_longest_match.html

12:24 PM Changeset in webkit [35224] by barraclough@apple.com

5 edits in trunk/JavaScriptCore

2008-07-17 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Merge pre&post dot nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).

kjs/grammar.y:
kjs/nodes.cpp:
kjs/nodes.h:
kjs/nodes2string.cpp:

11:24 AM Changeset in webkit [35223] by hyatt@apple.com

2 edits in trunk/WebCore

2008-07-17 David Hyatt <hyatt@apple.com>

Make sure the check to see if a frame/iframe is being rendered inside a transparency layer is
recursive (and checks for transparency layers all the way up the ancestor document chain back to
the top-level frame).