⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 19, 2008:

10:29 PM Changeset in webkit [35250] by oliver@apple.com
  • 8 edits in trunk

Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression
<https://bugs.webkit.org/show_bug.cgi?id=20104>

Reviewed by Cameron Zwarich

To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.

3:05 PM Changeset in webkit [35249] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix windows build.

8:46 AM Changeset in webkit [35248] by Nikolas Zimmermann
  • 116 edits
    1 add in trunk/WebCore

Reviewed by Oliver & parts by Eric.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051

Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)

Jul 18, 2008:

9:40 PM Changeset in webkit [35247] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):
9:11 PM Changeset in webkit [35246] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):
6:44 PM Changeset in webkit [35245] by oliver@apple.com
  • 37 edits
    2 adds in trunk

Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Cameron Zwarich

Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.

6:36 PM Changeset in webkit [35244] by britto@apple.com
  • 8 edits
    3 adds in trunk

2008-07-18 Maxime Britto <britto@apple.com>

Reviewed by Adele.


Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.

Test: fast/events/autoscroll-with-non-scrollable-parent.html

  • ChangeLog:
  • page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
  • rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>

Reviewed by Adele.

Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes

  • ChangeLog:
  • fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
  • fast/events/autoscroll-with-non-scrollable-parent.html: Added.
  • fast/events/resources/big-page-with-input.html: Added.
5:22 PM Changeset in webkit [35243] by weinig@apple.com
  • 4 edits in trunk/WebCore

2008-07-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest

  • Overload XMLHttpRequests send() method to accept File tokens.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
  • xml/XMLHttpRequest.h:
3:18 PM Changeset in webkit [35242] by ggaren@apple.com
  • 34 edits in trunk

JavaScriptCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

JavaScriptGlue:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

  • ChangeLog:
  • JSObject.cpp: (JSUserObject::getCallData):

WebCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

3:15 PM Changeset in webkit [35241] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-18 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
3:04 PM Changeset in webkit [35240] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by mitz

Remove braces around single-line conditional.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
2:59 PM Changeset in webkit [35239] by Simon Fraser
  • 5 edits in trunk

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.

https://bugs.webkit.org/show_bug.cgi?id=20008

Testcase: LayoutTests/fast/css/computed-style-without-renderer

LayoutTests/fast/css/computed-style-expected.txt

2:44 PM Changeset in webkit [35238] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-07-18 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086

2:25 PM Changeset in webkit [35237] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized <= for immediate number cases.


SunSpider reports no overall change, but a 10% speedup on access-nsieve.

2:03 PM Changeset in webkit [35236] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix some casts added in a previous build fix to match the style used
throughout WebKit.

Rubber-stamped by Sam Weinig.

  • VM/Machine.cpp:

(KJS::Machine::initializeCallFrame):

  • VM/Register.h:

(KJS::Register::Register):

11:31 AM Changeset in webkit [35235] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Update expected results for a recently added test to what is seen when running the
full test suite.

  • fast/forms/form-and-frame-interaction-retains-values-expected.txt:
8:31 AM Changeset in webkit [35234] by ddkilzer@apple.com
  • 7 edits in trunk

Bug 19975: [OpenBSD] Patches to enable build of WebKit

JavaScriptCore:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

Support for OpenBSD, mostly threading and libm tweaks.

  • kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
  • kjs/config.h: OpenBSD also provides <pthread_np.h>
  • wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
  • wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro

WebKitTools:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

  • DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
8:21 AM Changeset in webkit [35233] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitSite

Fixed indentation of example code for C++ pointers/references!

  • coding/coding-style.html:
8:15 AM Changeset in webkit [35232] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-18 Robert Blaut <webkit@blaut.biz>

Reviewed by David Kilzer.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions

  • coding/coding-style.html:
Note: See TracTimeline for information about the timeline view.