Timeline

Jul 28, 2008:

5:37 PM Changeset in webkit [35417] by andersca@apple.com

• 3 edits in trunk/WebCore

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch from Dimcho Balev.

Windows part of

​https://bugs.webkit.org/show_bug.cgi?id=18676
<rdar://problem/6106578>
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

• plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
• plugins/PluginStream.h:

4:38 PM Changeset in webkit [35416] by jchaffraix@webkit.org

• 11 edits
  2 adds in branches/XBL2

WebCore:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20196: [XBL] Re-enable CSS binding attachment

• Re-enable legacy CSS attachment code.

• Add XBLBindingManager bits so that it also creates / removes the required bindings.

• Renamed '-webkit-binding' property to 'binding' (the name in the specification)

Test: fast/xbl/xbl-css-attachment.html

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
• css/CSSPropertyNames.in:
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings): Added remove bindings and the style information associated.

• css/CSSStyleSelector.h:
• dom/Element.cpp: (WebCore::Element::hasBinding): Update the style as it will cause binding updates.

• rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::BindingURI::BindingURI):
• rendering/style/RenderStyle.h:
• xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding): Limit to one binding per element with the same uri as the CSS attachment code can be hit twice.

LayoutTests:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20196: [XBL] Re-enable CSS binding attachment

• fast/xbl/xbl-css-attachment-expected.txt: Added.
• fast/xbl/xbl-css-attachment.html: Added.

4:34 PM Changeset in webkit [35415] by beidson@apple.com

• 6 edits
  4 adds in trunk

WebCore:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Test: security/autocomplete-cleared-on-back.html

<rdar://problem/6093281> - autocomplete="off" should work when going back

Taken care of in two ways:
1 - Listening for the page cache notification to clear the form, in cases where the page

is being restored from the page cache

2 - Not saving such form elements when doing the normal "save state" to a history item,

for cases with no page cache

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::didRestoreFromCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
• html/HTMLFormElement.h:

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsCacheCallback): (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute indicate we should. (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type and attribute are clear of needing registration. (WebCore::HTMLInputElement::didRestoreFromCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
• html/HTMLInputElement.h:

LayoutTests:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6093281> - autocomplete="off" should work when going back

• security/autocomplete-cleared-on-back-expected.txt: Added.
• security/autocomplete-cleared-on-back.html: Added.
• security/resources: Added.
• security/resources/autocomplete-cleared-on-back2.html: Added.

3:50 PM Changeset in webkit [35414] by hyatt@apple.com

• 14 edits
  16 adds in trunk

2008-07-28 David Hyatt <​hyatt@apple.com>

Add support for CSS variable declaration blocks.

Reviewed by Sam

Added tests in fast/css/variables.

• css/CSSGrammar.y:
• css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
• css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
• css/CSSParser.h:
• css/CSSProperty.cpp: (WebCore::CSSProperty::cssText):
• css/CSSPropertyNames.in:
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
• css/CSSStyleSelector.h:
• css/CSSValueList.h: (WebCore::CSSValueList::isValueList):
• css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable): (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
• css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
• css/StyleBase.cpp: (WebCore::StyleBase::cssText):
• css/StyleBase.h: (WebCore::StyleBase::isValueList): (WebCore::StyleBase::isMutableStyleDeclaration):

3:46 PM Changeset in webkit [35413] by andersca@apple.com

• 4 edits
  4 adds in trunk

../../../../../../LayoutTests:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150

Add tests.

• http/tests/xmlhttprequest/resources/forbidden.txt: Added.
• http/tests/xmlhttprequest/resources/redirect.php: Added.
• http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
• http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150

Handle willSendRequest correctly.

• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequest): Make sure to keep the previous URL around so we know when to call willSendRequest.

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): Abort if we don't have access to the response URL.

(WebCore::XMLHttpRequest::willSendRequest):
Dispatch a network error if we can't access the new URL.

2:15 PM Changeset in webkit [35412] by jchaffraix@webkit.org

• 4 edits
  1 add in branches/XBL2/WebCore

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20171: [XBL] Add <binding> 'element' attribute

• DerivedSources.make: Add attrs file.
• GNUmakefile.am: Ditto.
• WebCore.pro: Ditto.
• xbl/xblattrs.in: Added.

1:04 PM Changeset in webkit [35411] by ggaren@apple.com

• 25 edits in trunk

JavaScriptCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

WebCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

12:23 PM Changeset in webkit [35410] by andersca@apple.com

• 2 edits in trunk

Add radar number

12:20 PM Changeset in webkit [35409] by andersca@apple.com

• 10 edits in trunk

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.

​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

• bridge/npapi.h: Add new enum values.

• loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream if an error occurs.

• loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams): Add new client method.

../../../../../../WebKit/mac:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.

​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

• Plugins/WebBaseNetscapePluginStream.h: Add NPP_GetValue pointer.

• Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): Initialize NPP_GetValue.

(-[WebBaseNetscapePluginStream wantsAllStreams]):
Call NPP_GetValue.

• Plugins/WebPlugInStreamLoaderDelegate.h:
• WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
• WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: (WebNetscapePlugInStreamLoaderClient::wantsAllStreams): Implement this and call down to the stream.

9:59 AM Changeset in webkit [35408] by andersca@apple.com

• 2 edits in trunk/WebKit/mac

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6105529>
​https://bugs.webkit.org/show_bug.cgi?id=19659
Turning off plugins causes crash

When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
end up in a state where they don't have an event handler. Because of this, we need to
check that the plug-in has been started before calling the event handler.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView inputContext]):

12:37 AM Changeset in webkit [35407] by mrowe@apple.com

• 2 edits in trunk/WebKitSite

2008-07-28 Robert Blaut <​webkit@blaut.biz>

Reviewed by Mark Rowe.

Fix for bug: Website provides no guidance on debugging
<​https://bugs.webkit.org/show_bug.cgi?id=3643>

• building/debug.html: added info about Xcode Debugging Guide.

Jul 27, 2008:

3:03 PM Changeset in webkit [35406] by weinig@apple.com

• 5 edits
  6 adds in trunk

WebCore:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

Turn the querySelector/querySelectorAll id optimization back on
for only strict and almost strict mode. In quirks mode, the optimiztion
won't work as the id match is not case sensitive.

Tests: fast/dom/SelectorAPI/caseID-almost-strict.html

fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/caseID.html

• dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
• dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
• dom/SelectorNodeList.h:

LayoutTests:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

• fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
• fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
• fast/dom/SelectorAPI/caseID-expected.txt: Added.
• fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
• fast/dom/SelectorAPI/caseID-strict.html: Added.
• fast/dom/SelectorAPI/caseID.html: Added.

2:34 PM Changeset in webkit [35405] by ddkilzer@apple.com

• 2 edits in trunk/WebKit/qt

Fix Qt build failure.

• Api/qwebframe.h: (QWebFrame::setScrollOffset): Make argument const.

2:27 PM Changeset in webkit [35404] by ddkilzer@apple.com

• 3558 edits in trunk/LayoutTests

Set svn:mime-type to image/png.

2:08 PM Changeset in webkit [35403] by ddkilzer@apple.com

• 9 edits
  3 adds in trunk

WebCore:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:

• not to fail when closing braces are not found for a declaration at the end of the file
• not to accept "!important fail" as valid
• to keep accepting @import when it comes after invalid @ rules
• not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.

CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.

• css/CSSGrammar.y:

LayoutTests:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Updated layout CSS2.1 test suite tests related to css parsing:
​https://bugs.webkit.org/show_bug.cgi?id=14346

• platform/mac/css2.1/t040105-import-01-b-expected.checksum:
• platform/mac/css2.1/t040105-import-01-b-expected.png:
• platform/mac/css2.1/t040105-import-01-b-expected.txt:
• platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
• platform/mac/css2.1/t0402-syntax-05-f-expected.png:
• platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
• platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
• platform/mac/css2.1/t0402-syntax-06-f-expected.png:
• platform/mac/css2.1/t0402-syntax-06-f-expected.txt:

3:43 AM Changeset in webkit [35402] by jmalonzo@webkit.org

• 5 edits in trunk/WebCore

2008-07-27 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

Use --outputDir instead of --output when invoking make_names.pl
There's no option named "output" in make_names.pl

• GNUmakefile.am:
• WebCore.pro:
• DerivedSources.make: Remove --output. Not necessary here.
• bindings/scripts/generate-bindings.pl: Rename --outputdir to --outputDir for consistency with make_names.pl

3:28 AM HackingGtk edited by jserv.tw@gmail.com

(diff)