⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 7, 2008:

9:05 PM Changeset in webkit [35636] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug numbers.

9:04 PM Changeset in webkit [35635] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.0.3/WebCore/DerivedSources.cpp

Build fix.

9:04 PM Changeset in webkit [35634] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.3

Versioning.

8:56 PM Changeset in webkit [35633] by timothy@apple.com
  • 2 edits in trunk/WebCore

Change highlight time from 300ms to 500ms and fade effect from 1s to 2s

​https://bugs.webkit.org/show_bug.cgi?id=17589

Reviewed by Timothy Hatcher.

  • page/inspector/SourceFrame.js:
8:55 PM Changeset in webkit [35632] by timothy@apple.com
  • 3 edits in trunk/WebCore

The search is only performed if the field contains more than 3
letters or if Enter is pressed.

Search is now performed through a keyup event.

Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).

​https://bugs.webkit.org/show_bug.cgi?id=18548

Reviewed by Timothy Hatcher.

  • page/inspector/inspector.html: Removed the onsearch and incremental attributes
  • page/inspector/inspector.js:
8:30 PM Changeset in webkit [35631] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.3

New tag.

5:35 PM Changeset in webkit [35630] by mrowe@apple.com
  • 2 edits
    1 add in tags/Safari-6528.0.2/WebCore

Merge r35629.

4:38 PM Changeset in webkit [35629] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebCore

Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.


Reviewed by Mark Rowe.

  • DerivedSources.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj:
3:29 PM Changeset in webkit [35628] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
​https://bugs.webkit.org/show_bug.cgi?id=16791
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages

  • page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/InspectorController.h:
  • page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
2:55 PM Changeset in webkit [35627] by Simon Fraser
  • 10 edits
    2 adds in trunk/WebCore

2008-08-07 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Rename Marquee to RenderMarquee and move to its own file.
​https://bugs.webkit.org/show_bug.cgi?id=20319

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLMarqueeElement.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
1:32 PM Changeset in webkit [35626] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
10:28 AM Changeset in webkit [35625] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6115981> Start the profiler in Heavy view

  • page/inspector/ProfileView.js:
9:04 AM Changeset in webkit [35624] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.


WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.


Reviewed by Geoff Garen.

  • WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
5:09 AM Changeset in webkit [35623] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-07 Alp Toker <​alp@nuanti.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20313
Add null check in String::fromUTF8()

Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.

  • platform/text/String.cpp: (WebCore::String::fromUTF8):
5:08 AM Changeset in webkit [35622] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-08-07 Kalle Vahlman <​zuh@iki.fi>

Reviewed by David Kilzer.

Check for correct flex version to avoid faulty builds

A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
​https://bugs.webkit.org/show_bug.cgi?id=20253

acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version

  • acinclude.m4:
  • configure.ac:
4:31 AM Changeset in webkit [35621] by Simon Hausmann
  • 3 edits
    8 adds in trunk

2008-08-07 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Added API tests for QWebPage/QWebFrame based on QTestLib.

Aug 6, 2008:

8:52 PM Changeset in webkit [35620] by kevino@webkit.org
  • 4 edits
    2 adds in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Create a wxWebFrame API to match other ports and to prepare for frames support.
Also fixes a frame leak in wx port on trunk.

​https://bugs.webkit.org/show_bug.cgi?id=19041

5:46 PM Changeset in webkit [35619] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning.

4:48 PM Changeset in webkit [35618] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after Frame -> ScriptController moves. Also, remove a character which was in an unknown encoding and replace it with an ANSI representation (which the author used for their Bugzilla account too).

4:08 PM Changeset in webkit [35617] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Make XHR console message clearer.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
4:07 PM Changeset in webkit [35616] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Created a new function to create DOM links from text without converting back and forth from HTML and messing with escaping special characters.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
3:39 PM Changeset in webkit [35615] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by hyatt.

Fix a large animation leak found on the buildbot
(m_animations and m_transitions were never deleted)
Drag RenderStyle (kicking and screaming) into the 21st century
of memory management with a little application of OwnPtr.

  • rendering/style/RenderStyle.cpp: (WebCore::FillLayer::cullEmptyLayers): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): (WebCore::RenderStyle::setContent): (WebCore::BindingURI::BindingURI): (WebCore::RenderStyle::setBoxShadow): (WebCore::ShadowData::ShadowData): (WebCore::RenderStyle::counterDirectives): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::adjustAnimations): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::clearAnimations): (WebCore::RenderStyle::clearTransitions):
3:17 PM Changeset in webkit [35614] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Brady Eidson <​beidson@apple.com>

Reviewed by MitzPettel

<rdar://problem/6078543> - Many LocalStorageThreads may be started

The original decision to key LocalStorage sets to PageGroups was a poor one.

It seems a much better solution is to key them to the actual path of on-disk storage,
which also solves all of the avenues that could lead to a boundless number of threads.

In this patch, I am not attempting to completely sever the attachment of LocalStorage
to PageGroups as that would require a more substantial re-working of the lifetime
between pages, groups, and local storage threads.

  • page/PageGroup.cpp: (WebCore::PageGroup::addPage):
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Map paths to LocalStorage objects here. (WebCore::LocalStorage::localStorage): Return the shared LocalStorage object for this path, or create a new one if it doesn't yet exist. (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::~LocalStorage): Add to remove the path->LocalStorage mapping
  • storage/LocalStorage.h:
3:12 PM Changeset in webkit [35613] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-08-06 Beth Dakin <Beth Dakin>

Reviewed by Adele.

Fix for <rdar://problem/6130724>

Disconnected frames should not be allowed to resize the window.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
2:27 PM Changeset in webkit [35612] by mitz@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Added bug URLs

2:15 PM Changeset in webkit [35611] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

<​https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>

Reviewed by Eric Seidel.

Test: fast/forms/submit-to-url-fragment.html

The problem was that isFormSubmission was not being set to true in
FrameLoader::loadWithDocumentLoader() when we were actually
submitting a form, causing the page to scroll instead of the form to
be submitted.

The isFormSubmission variable wasn't set to true because a FormState
object was not being created in
FrameLoader::loadFrameRequestWithFormAndValues().

The FormState object was not being created because
HTMLFormElement::submit(Event*, bool activateSubmitButton) would
only set FrameLoader::m_formAboutToBeSubmitted to the current form
if there was a "text field" element in the form (type = text,
password, search or isindex).

Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
called FrameLoader::loadFrameRequestWithFormAndValues(), a null
HTMLFormElement pointer would be sent and cause the above failures.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Call new FrameLoader::setFormAboutToBeSubmitted() method outside the for loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly once for any form submission. The FrameLoader::recordFormValue() method is only called with the name/value pair of each text field.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that only sets m_formAboutToBeSubmitted. (WebCore::FrameLoader::recordFormValue): Removed PassRefPtr<HTMLFormElement> argument since this method only sets name/value pairs on m_formValuesAboutToBeSubmitted now. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a FormState object as long as submitForm is not null so that other FrameLoader methods know when a form is being submitted.
  • loader/FrameLoader.h:

LayoutTests:

Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

<​https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>

Reviewed by Eric Seidel.

  • fast/forms/submit-to-url-fragment-expected.txt: Added.
  • fast/forms/submit-to-url-fragment.html: Added.
1:26 PM Changeset in webkit [35610] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
1:22 PM Changeset in webkit [35609] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj: Added PlugInImageElement.*
1:01 PM Changeset in webkit [35608] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

Reviewed by darin.

Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.

I've made AccessibilityUIElement a stack object for now. It could be
made RefCounted, but I figured that might be overkill for the moment.
Essentially it's just a RefPtr itself. :)

I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
which was causing additional leaks. :)

I added toAXElement to remove a bunch of copy/paste code.

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (lineForIndexCallback): (boundsForRangeCallback): (childAtIndexCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (getInsertionPointLineNumberCallback): (finalize):
  • DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement):
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::focusedElement):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren):
11:47 AM Changeset in webkit [35607] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim and Darin.

<rdar://problem/6126160> URLs in the console should be clickable.

  • Implemented and now use linkifyString() to parse console messages for URLs.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
10:23 AM Changeset in webkit [35606] by ddkilzer@apple.com
  • 8 edits
    10 adds in trunk

WebCore:

Images using QT plugin do not display correctly

<​https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>

Reviewed by Darin.

Tests: fast/images/embed-image.html

fast/images/object-image.html

Use RenderImage instead of RenderPartObject for a renderer when
the <embed> tag references an image. Extract common code from
HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.

  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • html/HTMLEmbedElement.cpp: Cleaned up #include statements. (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr and srcAttr cases. Create or clear HTMLImageLoader as needed for srcAttr. (WebCore::HTMLEmbedElement::rendererIsNeeded): Use HTMLPlugInElement::rendererIsNeeded() for images. (WebCore::HTMLEmbedElement::createRenderer): Create a RenderImage instead of a RenderPartObject for images. (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader, load image and populate RenderImage for images. (WebCore::HTMLEmbedElement::updateWidget): Don't call RenderPartObject::updateWidget() for images. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
  • html/HTMLEmbedElement.h: Removed unneeded namespace and class declarations. Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added. (WebCore::HTMLEmbedElement::serviceType): Moved to HTMLPlugInImageElement. (WebCore::HTMLEmbedElement::url): Ditto.
  • html/HTMLObjectElement.cpp: Cleaned up #include statements. (WebCore::HTMLObjectElement::attach): Removed local variable. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement.
  • html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement. (WebCore::HTMLObjectElement::serviceType): Ditto. (WebCore::HTMLObjectElement::url): Ditto.
  • html/HTMLPlugInImageElement.cpp: Added. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::isImageType): Moved from HTMLObjectElement.
  • html/HTMLPlugInImageElement.h: Added. (WebCore::HTMLPlugInImageElement::isImageType): Added from HTMLObjectElement. (WebCore::HTMLPlugInImageElement::serviceType): Ditto. (WebCore::HTMLPlugInImageElement::url): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Return urlString for embed elements with images.

LayoutTests:

Images using QT plugin do not display correctly

<​https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>

Reviewed by Darin.

Test images rendered by both embed and object elements.

  • fast/images/embed-image.html: Added.
  • fast/images/object-image.html: Added.
  • platform/mac/fast/images/embed-image-expected.checksum: Added.
  • platform/mac/fast/images/embed-image-expected.png: Added.
  • platform/mac/fast/images/embed-image-expected.txt: Added.
  • platform/mac/fast/images/object-image-expected.checksum: Added.
  • platform/mac/fast/images/object-image-expected.png: Added.
  • platform/mac/fast/images/object-image-expected.txt: Added.
9:33 AM Changeset in webkit [35605] by Chris Fleizach
  • 4 edits in trunk

Fix an accessibility layout test that was failing on different platforms

7:50 AM Changeset in webkit [35604] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Try to fix the Windows build bots

  • API/JSBase.cpp: Touch this to force JSC to rebuild and re-copy the WTF headers.
6:30 AM Changeset in webkit [35603] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-06 Benjamin C Meyer <​ben@meyerhome.net>

Reviewed by Simon.

During the drag operation only accept the event if the action is not ignore action.

6:02 AM Changeset in webkit [35602] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert change 35595.

5:46 AM Changeset in webkit [35601] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-06 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=20295
RegularExpression::match should not crash when a null string is passed

RegularExpression::match used to pass null subject strings to
jsRegExpExecute causing an ASSERT failure and then a crash.
There is no need to fix also RegularExpression:search and
RegularExpression::searchRev as they just call
RegularExpression::match.

  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match): Return -1 if the string is null.
5:40 AM Changeset in webkit [35600] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-08-06 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=20276
[GTK] Makefile rules for the enum GTypes files depend on Makefile
instead of GNUmakefile

The patch committed in revision 34649 added the code needed to
generate GTypes for enums but the makefile rules for
stamp-webkitenumtypes.h and webkitenumtypes.cpp were depending on
Makefile (used by other ports) instead of GNUmakefile.

  • GNUmakefile.am: Depend on GNUmakefile instead of Makefile.
5:35 AM Changeset in webkit [35599] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-08-06 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix only

  • bindings/js/ScriptControllerGtk.cpp:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
5:11 AM Changeset in webkit [35598] by eric@webkit.org
  • 11 edits in trunk

Reviewed by Cameron Zwarich.

Fix warnings and errors seen on Qt bot.
Including one correctness fix for ThreadingQt.
According to the Qt 4.4 docs, we were always passing
seconds to "wait()" when we should have been passing
milliseconds.

Lots of float <-> int conversion warnings.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • dom/Element.cpp: (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • loader/CachedImage.cpp: (WebCore::CachedImage::imageRect):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
  • plugins/npapi.cpp:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::intrinsicSizeChanged):
4:46 AM Changeset in webkit [35597] by vestbo@webkit.org
  • 4 edits in trunk

2008-08-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix the Qt build due to recent ScriptController refactoring.

4:46 AM Changeset in webkit [35596] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix non-Mac build.

4:17 AM Changeset in webkit [35595] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix non-Mac build.

3:50 AM Changeset in webkit [35594] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-06 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Darin. Landed by Cameron.

Bug 20272: typo in JavaScriptCore
<​https://bugs.webkit.org/show_bug.cgi?id=20272>

Correct the documentation for op_not. (typo)
Fix #undef. (typo)

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
3:37 AM Changeset in webkit [35593] by cwzwarich@webkit.org
  • 18 edits
    3 adds in trunk

2008-08-06 Cameron Zwarich <​cwzwarich@webkit.org>

Reviewed by Maciej.

Bug 20286: Load constants all at once instead of using op_load
<​https://bugs.webkit.org/show_bug.cgi?id=20286>

Load constants all at once into temporary registers instead of using
individual instances of op_load.

This is a 2.6% speedup on SunSpider.

JavaScriptCore:

  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): (KJS::CodeBlock::mark):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::newTemporary): (KJS::CodeGenerator::addConstant): (KJS::CodeGenerator::addUnexpectedConstant): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitUnexpectedLoad): (KJS::CodeGenerator::emitNewError):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • VM/Opcode.h:
  • VM/RegisterID.h: (KJS::RegisterID::RegisterID): (KJS::RegisterID::makeConstant): (KJS::RegisterID::isTemporary):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing):
  • kjs/Parser.h: (KJS::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::BooleanNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::ArrayNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ReturnNode::emitCode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create): (KJS::FunctionBodyNode::emitCode):
  • kjs/nodes.h: (KJS::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/constant-count-expected.txt: Added.
  • fast/js/constant-count.html: Added.
  • fast/js/deep-recursion-test.html:
  • fast/js/resources/constant-count.js: Added.
3:34 AM Changeset in webkit [35592] by eric@webkit.org
  • 6 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Windows and Qt builds.

  • bindings/js/ScriptControllerWin.cpp: add runtime.h include
  • bindings/js/ScriptControllerQt.cpp: add QWidget include
  • page/win/FrameWin.cpp: remove bogus using namespace
  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): use script()
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): use script() (WebCore::PluginView::~PluginView): use script()
3:17 AM Changeset in webkit [35591] by eric@webkit.org
  • 3 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Linux and --no-svg builds.

  • bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch
3:01 AM Changeset in webkit [35590] by eric@webkit.org
  • 35 edits
    3 copies
    1 add in trunk

Reviewed by Cameron Zwarich.

Move more methods from Frame into ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=20294

Finally finish more of the work which Darin started long ago
Move a few more Frame methods into ScriptController.
I also took this opportunity to clean up some of the plugin
code as well, and moved some of that into ScriptController.

I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()

No functional changes, thus no test cases.

  • GNUmakefile.am:
  • WebCore.NPAPI.exp:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::createRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement): New method. (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::ScriptController::cleanupScriptObjectsForPlugin): (WebCore::ScriptController::clearScriptObjects):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::clearFormerWindow):
  • bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::Frame::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerMac.mm: Added. (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::windowScriptObject): (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::updateRenderingForBindings): (WebCore::ScriptController::initJavaJSBindings):
  • bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/jni/jni_jsobject.mm: (createRootObject):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::renderWidgetForJSBindings): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::detach): (WebCore::HTMLPlugInElement::getInstance): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::getNPObject):
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/gtk/FrameGtk.cpp:
  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
2:06 AM Changeset in webkit [35589] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Cameron Zwarich.

Speculative fix for an error I keep seeing in my Cygwin build

  • Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
12:09 AM Changeset in webkit [35588] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • fix an assertion failure in Cache::setCapacities()
  • Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize() to uint64_t.
  • Misc/WebKitSystemBits.m: (WebMemorySize):
  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
Note: See TracTimeline for information about the timeline view.