⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 8, 2008:

8:56 PM Changeset in webkit [35651] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2008-08-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 20330: JSCore crash loading any filehurricane media page
<​https://bugs.webkit.org/show_bug.cgi?id=20330>

Fix a typo in the constant loading patch. Also, add a case for
op_unexpected_load to CodeBlock::dump().

JavaScriptCore:

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::addUnexpectedConstant):

LayoutTests:

  • fast/js/resources/unexpected-constant-crash.js: Added.
  • fast/js/unexpected-constant-crash-expected.txt: Added.
  • fast/js/unexpected-constant-crash.html: Added.
8:37 PM Changeset in webkit [35650] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe

This change reintroduces <​https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an unsuccessful workaround for <rdar://problem/5668489>, because invoking layout may change the view hierarchy during the drawing operation, which is not supported on Leopard.
6:05 PM Changeset in webkit [35649] by Beth Dakin
  • 4 edits in trunk/WebCore

2008-08-08 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This patch makes the findString and markAllMatchesForText functions
work with disconnected frames that are contained within
overflow:hidden blocks.

  • editing/Editor.cpp: (WebCore::Editor::rangeVisibility): (WebCore::Editor::firstVisibleRange): (WebCore::Editor::lastVisibleRange):
  • editing/Editor.h: (WebCore::Editor::):
  • page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
5:15 PM Changeset in webkit [35648] by britto@apple.com
  • 15 edits
    2 adds in trunk

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
​https://bugs.webkit.org/show_bug.cgi?id=20270
Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.

  • WebCore.base.exp:
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent):
  • page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled. (WebCore::RenderLayer::autoscroll):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

  • WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.
​https://bugs.webkit.org/show_bug.cgi?id=20270
This test is automatic and can also be run manually.

  • fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
  • fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.
4:40 PM Changeset in webkit [35647] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

<rdar://problem/6137022>
<​https://bugs.webkit.org/show_bug.cgi?id=20331>
REGRESSION(r35177-r35203): Scrolling slowly over a scrollable field scrolls the page instead of the field (20331)

  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): fixed the wrong cast for the wheel delta which was truncated to 0 on slow wheel scrolls.
1:44 PM Changeset in webkit [35646] by dino@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Execute CSS Animations using new AnimationController
​https://bugs.webkit.org/show_bug.cgi?id=20119

I still need to file some follow-on bugs that EricS noticed.

Reviewed by Dave Hyatt

Some new tests:

  • manual-tests/animate-duration.html: Added.
  • manual-tests/animate-left.html: Added.
  • manual-tests/animate-none.html: Added.
  • css/CSSStyleSelector.cpp:
  • dom/Document.cpp:
    • don't redo style when page is place into cache
  • page/AnimationController.cpp:
  • page/AnimationController.h:
    • execute the animations
  • rendering/RenderObject.cpp:
  • rendering/style/RenderStyle.h:
    • make border radii const (for blending)
1:25 PM Changeset in webkit [35645] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-08-08 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6136326> JSProfiler: Start/stop profiling button in the
Web Inspector does not match the menu.

  • page/InspectorController.cpp: (WebCore::InspectorController::toggleRecordButton): Toggle the record button in the webInspector. (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • page/InspectorController.h:
  • page/inspector/ProfilesPanel.js: Move the UI part of the record button into its funtion so that it can be called from the Inspector controller.
  • page/inspector/inspector.js:
11:57 AM Changeset in webkit [35644] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-08 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, build fix.

11:48 AM Changeset in webkit [35643] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-08 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Fix for <rdar://problem/5865504>

This bug was actually *largely* fixed by ​http://trac.webkit.org/changeset/35538.
But with that same patch, it became possible for a WebResource to fail to initialize.
Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
Lets fix that, shall we?

  • WebView/WebArchive.mm: (-[WebArchive subresources]):
11:21 AM Changeset in webkit [35642] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-08 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6131187> Profiles don't show up immediately when run
with the UI.

  • page/InspectorController.cpp: (WebCore::startProfiling): Added so that the inspector's JS code could call through to the same function used by the Develop menu. This way both can call didFinishAllExecution() which puts the profile in the Web Inspector. (WebCore::stopProfiling): Ditto (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::stopUserInitiatedProfiling): Now calls didFinishAllExecution() to put the profile in the Web Inspector. This should be safe since the UIs shouldn't work if JS is still running.
  • page/inspector/ProfilesPanel.js: Use the new functions.
10:38 AM Changeset in webkit [35641] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5961260> GDI text: transparent fill color text does not render if it it has a stroke or shadow
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
5:59 AM Changeset in webkit [35640] by jchaffraix@webkit.org
  • 11 edits
    7 adds in branches/XBL2

WebCore:

2008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Tests: fast/xbl/xbl-crash-inline.xhtml

fast/xbl/xbl-document-sheets-modification.xhtml
fast/xbl/xbl-element-binding.xhtml

Bug 20212: [XBL] Add full support for element="" attachment

  • Add attributeChanged method to XBLBindingElement to catch "element" changes and update the bindings.
  • Translate "element" attribute to a stylesheet that is added to the bound document's sheets.
  • GNUmakefile.am: Add XBLBindingElement.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add binding sheets.
  • dom/Document.cpp: (WebCore::Document::~Document): Remove binding sheet information.

(WebCore::Document::recalcStyleSelector): When
recalculating the style selector, remove all the bindings
as the removed sheets would never remove theirs.

(WebCore::Document::addBindingSheet): Update binding manager
information.
(WebCore::Document::removeBindingSheet): Ditto.

  • dom/Document.h:
  • xbl/XBLBindingElement.cpp: Added. (WebCore::XBLBindingElement::XBLBindingElement): (WebCore::XBLBindingElement::attributeChanged): Check for "element" changes and update the cached sheet and the bound element's bindings style sheets.

(WebCore::XBLBindingElement::generateBindingSheet): Create
the style sheet from the "element" attribute.

  • xbl/XBLBindingElement.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBindingSheet): (WebCore::XBLBindingManager::removeBindingSheet): (WebCore::XBLBindingManager::clearBindingSheets): (WebCore::XBLBindingManager::getBindingSheets): All 4 previous methods are used to manage the binding sheets.
  • xbl/XBLBindingManager.h:

LayoutTests:

2008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20212: [XBL] Add full support for element="" attachment


  • fast/xbl/xbl-crash-inline-expected.txt: Added.
  • fast/xbl/xbl-crash-inline.xhtml: Added.
  • fast/xbl/xbl-document-sheets-modification-expected.txt: Added.
  • fast/xbl/xbl-document-sheets-modification.xhtml: Added.
  • fast/xbl/xbl-element-binding-expected.txt: Added.
  • fast/xbl/xbl-element-binding.xhtml: Added.


2:48 AM Changeset in webkit [35639] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Improve performance of arithmetic operators

Reviewed by Cameron Zwarich

Added a fast (non-virtual) mechanism to determine if a non-immediate JSValue*
is a JSNumberCell. We then use this to allow improved specialisation in many
arithmetic operators. SunSpider reports a 2.5% progression overall, with greater
than 10% progressions on a number of arithmetic heavy tests.

2:32 AM Changeset in webkit [35638] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-08 Adam Treat <​treat@kde.org>

Reviewed by Simon.

Return the canonical file path in Qt's listDirectory as WebCore::PluginDatabase
uses this method to retrieve a list of possible plugins. Many linux systems
have nested symbolic links scattered throughout the plugin directories which
resulted in the PluginDatabase loading the same plugin N times depending on
the number of symbolic links.

1:21 AM Changeset in webkit [35637] by jchaffraix@webkit.org
  • 5 edits in branches/XBL2/WebCore

008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Re-enable last bits of XBLDocument loading
legacy code.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
  • xbl/XBLDocument.h: (WebCore::XBLDocument::create): Removed adoptRef to match other Document 'create' method as it would lead to refcount churn. Also added missing 'const' in isXBLDocument.

Aug 7, 2008:

9:05 PM Changeset in webkit [35636] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug numbers.

9:04 PM Changeset in webkit [35635] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.0.3/WebCore/DerivedSources.cpp

Build fix.

9:04 PM Changeset in webkit [35634] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.3

Versioning.

8:56 PM Changeset in webkit [35633] by timothy@apple.com
  • 2 edits in trunk/WebCore

Change highlight time from 300ms to 500ms and fade effect from 1s to 2s

​https://bugs.webkit.org/show_bug.cgi?id=17589

Reviewed by Timothy Hatcher.

  • page/inspector/SourceFrame.js:
8:55 PM Changeset in webkit [35632] by timothy@apple.com
  • 3 edits in trunk/WebCore

The search is only performed if the field contains more than 3
letters or if Enter is pressed.

Search is now performed through a keyup event.

Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).

​https://bugs.webkit.org/show_bug.cgi?id=18548

Reviewed by Timothy Hatcher.

  • page/inspector/inspector.html: Removed the onsearch and incremental attributes
  • page/inspector/inspector.js:
8:30 PM Changeset in webkit [35631] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.3

New tag.

5:35 PM Changeset in webkit [35630] by mrowe@apple.com
  • 2 edits
    1 add in tags/Safari-6528.0.2/WebCore

Merge r35629.

4:38 PM Changeset in webkit [35629] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebCore

Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.


Reviewed by Mark Rowe.

  • DerivedSources.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj:
3:29 PM Changeset in webkit [35628] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
​https://bugs.webkit.org/show_bug.cgi?id=16791
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages

  • page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/InspectorController.h:
  • page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
2:55 PM Changeset in webkit [35627] by Simon Fraser
  • 10 edits
    2 adds in trunk/WebCore

2008-08-07 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Rename Marquee to RenderMarquee and move to its own file.
​https://bugs.webkit.org/show_bug.cgi?id=20319

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLMarqueeElement.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
1:32 PM Changeset in webkit [35626] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
10:28 AM Changeset in webkit [35625] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6115981> Start the profiler in Heavy view

  • page/inspector/ProfileView.js:
9:04 AM Changeset in webkit [35624] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.


WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.


Reviewed by Geoff Garen.

  • WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
5:09 AM Changeset in webkit [35623] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-07 Alp Toker <​alp@nuanti.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20313
Add null check in String::fromUTF8()

Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.

  • platform/text/String.cpp: (WebCore::String::fromUTF8):
5:08 AM Changeset in webkit [35622] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-08-07 Kalle Vahlman <​zuh@iki.fi>

Reviewed by David Kilzer.

Check for correct flex version to avoid faulty builds

A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
​https://bugs.webkit.org/show_bug.cgi?id=20253

acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version

  • acinclude.m4:
  • configure.ac:
4:31 AM Changeset in webkit [35621] by Simon Hausmann
  • 3 edits
    8 adds in trunk

2008-08-07 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Added API tests for QWebPage/QWebFrame based on QTestLib.

Note: See TracTimeline for information about the timeline view.