⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 11, 2008:

9:28 PM Changeset in webkit [35678] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.

Reviewed by Tim Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=20326

  • page/inspector/StylesSidebarPane.js:
9:20 PM Changeset in webkit [35677] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed the line highlight transition for an easier animation.

Reviewed by Tim Hatcher.

  • page/inspector/SourceFrame.js:
8:57 PM Changeset in webkit [35676] by timothy@apple.com
  • 2 edits in trunk/WebCore

Added support for some Firebug Command Line APIs.

Reviewed by Tim Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=19867
​https://bugs.webkit.org/show_bug.cgi?id=19868
​https://bugs.webkit.org/show_bug.cgi?id=19869
​https://bugs.webkit.org/show_bug.cgi?id=19875
​https://bugs.webkit.org/show_bug.cgi?id=19876
​https://bugs.webkit.org/show_bug.cgi?id=19880

  • page/inspector/Console.js: (WebInspector.Console.prototype._evalInInspectedWindow): Create an object on the inspected window that holds the console command line API functions. This object is used in a with statement around the typed expression.
7:55 PM Changeset in webkit [35675] by Nikolas Zimmermann
  • 1 edit
    110 adds in trunk/LayoutTests

Rubber stamped by Oliver.

Add a bunch of new dynamic-updates tests covering SVGLineElement & SVGRadialGradientElement.
No functional changes needed, all work out of the box.

7:22 PM Changeset in webkit [35674] by Nikolas Zimmermann
  • 11 edits
    15 adds in trunk

Reviewed by Antti.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17736

JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)

Added tests: svg/custom/svg-modify-currentTranslate.html

svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html

Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html

5:34 PM Changeset in webkit [35673] by beidson@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Brady Eidson <​beidson@apple.com>

Reviewed by John and Anders

Fix for <rdar://problem/6141797>

When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.

When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.

The guarantee was a good one and should be restored.

Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.

  • loader/SubstituteResource.h: (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This well help any future subclassers not make this mistake.
  • loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): Return 0 if the data is null.
3:44 PM Changeset in webkit [35672] by Simon Fraser
  • 3 edits
    2 adds in trunk

2008-08-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.

Test: transitions/interrupted-all-transition.html

  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::AnimationControllerPrivate::blendProperties): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::setTransitionStartTime): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::onAnimationEnd): (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::affectsProperty): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
1:45 PM Changeset in webkit [35671] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Because console messages have group levels now, newly created messages that do not specify the level lose their message since the number of arguments is wrong.


  • page/inspector/Console.js:
  • page/inspector/Resource.js:
12:52 PM Changeset in webkit [35670] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-08-11 Alp Toker <​alp@nuanti.com>

Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.

  • GNUmakefile.am:
11:48 AM Changeset in webkit [35669] by timothy@apple.com
  • 2 edits in trunk/WebCore

Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.

​https://bugs.webkit.org/show_bug.cgi?id=20346

Reviewed by Adam Roben.

  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Removed, factored into syntaxHighlightJavascript as an inline function. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Pulled in the _syntaxHighlightJavascriptLine so it will create a closure. Generate the finders before iterating the lines.
11:31 AM Changeset in webkit [35668] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file, too.
11:04 AM Changeset in webkit [35667] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc

Test: fast/css/counters/invalidate-cached-counter-node.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all RenderCounters in :before and :after content.
  • rendering/RenderContainer.h:
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this to match the RenderObject method. (WebCore::RenderCounter::invalidate): Added. Resets the cached CounterNode and invalidates the object's layout and preferred widths. (WebCore::destroyCounterNodeChildren): Added a call to invalidateCounters().
  • rendering/RenderCounter.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::invalidateCounters):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
  • fast/css/counters/invalidate-cached-counter-node.html: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
10:24 AM Changeset in webkit [35666] by dino@apple.com
  • 19 edits
    7 adds in trunk/WebCore

Implement CSS Animation and Transition Events
​https://bugs.webkit.org/show_bug.cgi?id=20337

Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.

Reviewed by Tim Hatcher and Dave Hyatt.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Build configs for new files

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventCustom.cpp:
  • dom/Document.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventTarget.cpp:
  • dom/EventTargetNode.cpp:
  • dom/EventTargetNode.h:
  • html/HTMLElement.cpp:
  • page/AnimationController.cpp:

do all the new event stuff

  • html/HTMLAttributeNames.in:

the onwebkitanimation* and onwebkittransitionend attrs

  • dom/WebKitAnimationEvent.cpp: Added.
  • dom/WebKitAnimationEvent.h: Added.
  • dom/WebKitAnimationEvent.idl: Added.
  • dom/WebKitTransitionEvent.cpp: Added.
  • dom/WebKitTransitionEvent.h: Added.
  • dom/WebKitTransitionEvent.idl: Added.

New files for the events

  • manual-tests/transition-events.html: Added.

New testfile

10:21 AM Changeset in webkit [35665] by Adam Roben
  • 5 edits
    2 adds in trunk

Move WTF::notFound into its own header so that it can be used independently of Vector

JavaScriptCore:

Move WTF::notFound into its own header so that it can be used
independently of Vector

Rubberstamped by Darin Adler.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NotFound.h to the project.
  • wtf/NotFound.h: Added. Moved the notFound constant here...
  • wtf/Vector.h: ...from here.

WebCore:

Add a ForwardingHeader for wtf/NotFound.h

Rubberstamped by Darin Adler.

  • ForwardingHeaders/wtf/NotFound.h: Added.
9:53 AM Changeset in webkit [35664] by timothy@apple.com
  • 2 edits
    2 adds in trunk/WebCore

Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.

​https://bugs.webkit.org/show_bug.cgi?id=20345

Reviewed by Adam Roben.

  • manual-tests/inspector/resources/script-error.js: Added.
  • manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Check the nodeType and not the nodeName, this is less fragile. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Check if the lastChild is an error bubble, if so remove it before getting the line's textContent. Add the error bubble back at the end.
5:01 AM Changeset in webkit [35663] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
  • kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while sweeping the heap.

Aug 10, 2008:

10:07 PM Changeset in webkit [35662] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over three large ChangeLogs.

9:51 PM Changeset in webkit [35661] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • dom/make_names.pl: Removed "using namespace WebCore::*Names" from *ElementFactory.cpp files.
7:17 PM Changeset in webkit [35660] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.

Reviewed by Cameron Zwarich.

  • bindings/js/ScriptControllerGtk.cpp: Fix the logic.
  • bindings/js/ScriptControllerWin.cpp: Ditto.
  • bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
3:36 PM Changeset in webkit [35659] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty

Test: fast/tokenizer/ampersand-in-special-tag.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Changed to only advance lastDecodedEntityPosition if an entity was found and decoded.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty
  • fast/tokenizer/ampersand-in-special-tag-expected.txt: Added.
  • fast/tokenizer/ampersand-in-special-tag.html: Added.
11:21 AM Changeset in webkit [35658] by alp@webkit.org
  • 9 edits
    3 deletes in trunk

2008-08-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed (and updated) by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=16620
[GTK] Autotools make dist and make check support

Get make dist working.

Note that not all possible configurations have been tested yet.

  • GNUmakefile.am:

2008-08-10 Alp Toker <​alp@nuanti.com>

Remove leftover qmake/GTK+ build files.

  • DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
  • GtkLauncher/GtkLauncher.pro: Removed.
3:06 AM Changeset in webkit [35657] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Added same heap debug checks to more code paths.

  • kjs/JSActivation.cpp: (KJS::JSActivation::put): (KJS::JSActivation::putWithAttributes):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::putWithAttributes):
  • kjs/JSObject.h: (KJS::JSObject::putDirect):
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePut): (KJS::JSVariableObject::symbolTablePutWithAttributes):
Note: See TracTimeline for information about the timeline view.