⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 14, 2008:

11:15 PM Changeset in webkit [35774] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Update cache capacities to match values used on Mac.


Reviewed by Dan Bernstein.

  • WebView.cpp: (WebView::setCacheModel):
10:10 PM Changeset in webkit [35773] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)

5:53 PM Changeset in webkit [35772] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache

Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
5:44 PM Changeset in webkit [35771] by weinig@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-14 Sam Weinig <​sam@webkit.org>

Reviewed by Jon Honeycutt.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
  • WebView.h:
4:58 PM Changeset in webkit [35770] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add the bug URL to the ChangeLog.

4:57 PM Changeset in webkit [35769] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Make Firebug command line API respect predefined variables.

Reviewed by Tim Hatcher.

  • page/inspector/Console.js:
4:45 PM Changeset in webkit [35768] by Simon Fraser
  • 2 edits
    2 adds in trunk/LayoutTests

2008-08-14 Simon Fraser <Simon Fraser>

Fix testcase and add pixel results for testcase in
​https://bugs.webkit.org/show_bug.cgi?id=20367

  • platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.txt:
4:33 PM Changeset in webkit [35767] by weinig@apple.com
  • 9 edits in trunk

WebCore:

2008-08-14 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.

  • WebCore.base.exp:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
  • html/HTMLTokenizer.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
  • page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):

WebKit/mac:

2008-08-14 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
  • WebView/WebViewPrivate.h:
4:20 PM Changeset in webkit [35766] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Beth.

Move us one step closer to cross-platform svg/graphics code

  • WebCore.xcodeproj/project.pbxproj:
  • html/CanvasStyle.cpp:
  • platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
  • platform/graphics/Color.h:
  • svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
  • svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
4:19 PM Changeset in webkit [35765] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Alexey.

Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • html/CanvasStyle.cpp:
  • html/HTMLCanvasElement.cpp:
4:19 PM Changeset in webkit [35764] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Clean up GlyphBuffer.h, removing more #ifdefs

  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
4:19 PM Changeset in webkit [35763] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Clean up AffineTransform.h, removing #ifdefs

  • platform/graphics/AffineTransform.h:
  • platform/graphics/cairo/AffineTransformCairo.cpp:
  • platform/graphics/cg/AffineTransformCG.cpp:
  • platform/graphics/qt/AffineTransformQt.cpp:
  • platform/graphics/wx/AffineTransformWx.cpp:
4:12 PM Changeset in webkit [35762] by mitz@apple.com
  • 4 edits in trunk/WebCore

2008-08-14 Dan Bernstein <​mitz@apple.com>

  • fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
4:08 PM Changeset in webkit [35761] by mitz@apple.com
  • 6 edits in trunk/WebCore

2008-08-14 Dan Bernstein <​mitz@apple.com>

Reviewed by Brady Eidson.

  • fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
  • platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
  • platform/graphics/ImageSource.h: Added frameSizeAtIndex().
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
4:04 PM Changeset in webkit [35760] by Simon Fraser
  • 3 edits
    2 adds in trunk

2008-08-13 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Fix @font-face inside @media rule crash.
​https://bugs.webkit.org/show_bug.cgi?id=20367

Test: fast/css/font-face-in-media-rule.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
3:52 PM Changeset in webkit [35759] by kevino@webkit.org
  • 6 edits in trunk/WebCore

wx build fixes after recent changes to Canvas and Image classes.

12:26 PM Changeset in webkit [35758] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Maxime Britto <​britto@apple.com>

Reviewed by Sam Weinig.

rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
12:14 PM Changeset in webkit [35757] by christian@webkit.org
  • 4 edits in trunk/WebCore

Gtk+/ Cairo build fix, patch by Dirk Schulze.

11:11 AM Changeset in webkit [35756] by kmccullough@apple.com
  • 16 edits in trunk

JavaScriptCore:

2008-08-14 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
  • profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
  • profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
  • profiler/Profile.h: (KJS::Profile::uid):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h:
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
  • profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
  • profiler/TreeProfile.h:

WebCore:

2008-08-14 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
  • page/InspectorController.h:
  • page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
  • page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
  • page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
10:41 AM Changeset in webkit [35755] by timothy@apple.com
  • 3 edits in trunk/WebCore

Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
9:12 AM Changeset in webkit [35754] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.

​https://bugs.webkit.org/show_bug.cgi?id=20376

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
8:07 AM Changeset in webkit [35753] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

partial Gtk build fix, not reviewed

  • platform/graphics/cairo/PatternCairo.cpp:

Aug 13, 2008:

9:49 PM Changeset in webkit [35752] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-13 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlson.

Fix style issue.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
9:26 PM Changeset in webkit [35751] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2008-08-13 Stephanie Lewis <Stephanie Lewis>

fix 64bit build

  • WebCoreSupport/WebInspectorClient.mm:
8:43 PM Changeset in webkit [35750] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-08-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
fillGetterProperty, which references a global function pointer,
out-of-line.


.2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
custom property access benchmark for objects with one property.

  • kjs/JSObject.cpp: (KJS::JSObject::fillGetterPropertySlot):
8:16 PM Changeset in webkit [35749] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

8:13 PM Changeset in webkit [35748] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.1

New tag.

8:06 PM Changeset in webkit [35747] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.

7:38 PM Changeset in webkit [35746] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.

7:26 PM Changeset in webkit [35745] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.

7:22 PM Changeset in webkit [35744] by Nikolas Zimmermann
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Eric.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=20372

Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.

This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)

As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.

No functional changes yet, as SVGScriptElement doesn't yet use the new base class.

7:17 PM Changeset in webkit [35743] by eric@webkit.org
  • 4 edits in trunk/WebCore

Attempt to fix the Gtk build, no review.

I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/qt/GradientQt.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
7:06 PM Changeset in webkit [35742] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

Attempt to fix the windows build, not review.

  • WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
7:03 PM Changeset in webkit [35741] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
6:29 PM Changeset in webkit [35740] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
6:24 PM Changeset in webkit [35739] by eric@webkit.org
  • 2 edits in trunk/WebCore

Attempt to fix the Qt build, no review.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::image):
6:21 PM Changeset in webkit [35738] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/graphics/win/ImageWin.cpp: (WebCore::Image::loadPlatformResource):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintMissingPluginIcon):
6:15 PM Changeset in webkit [35737] by eric@webkit.org
  • 3 edits in trunk/WebCore

Another attempt to fix the Qt build, no review.

  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/StillImageQt.h:
6:05 PM Changeset in webkit [35736] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Fix mac build, due to change in new code since my patch was written.

  • svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
5:59 PM Changeset in webkit [35735] by eric@webkit.org
  • 3 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Qt build.

  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::create): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize):
5:42 PM Changeset in webkit [35734] by eric@webkit.org
  • 2 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Qt build.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
5:30 PM Changeset in webkit [35733] by eric@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Sam.

Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
​https://bugs.webkit.org/show_bug.cgi?id=20351

Test: http/misc/canvas-pattern-from-incremental-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
5:29 PM Changeset in webkit [35732] by eric@webkit.org
  • 16 edits
    5 adds in trunk/WebCore

Reviewed by Niko.

Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
​https://bugs.webkit.org/show_bug.cgi?id=20351

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::parseRepetitionType): (WebCore::CanvasPattern::CanvasPattern):
  • html/CanvasPattern.h: (WebCore::CanvasPattern::create): (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
  • html/CanvasRenderingContext2D.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
5:29 PM Changeset in webkit [35731] by eric@webkit.org
  • 26 edits in trunk/WebCore

Reviewed by Niko.

Make Images RefCounted (and clean up callers)
​https://bugs.webkit.org/show_bug.cgi?id=20351

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::createImage):
  • loader/CachedImage.h:
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource):
  • loader/icon/IconRecord.h:
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::create):
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/Image.cpp: (WebCore::Image::nullImage):
  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
  • platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::create): (WebCore::PDFDocumentImage::destroyDecodedData): (WebCore::PDFDocumentImage::decodedSize):
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource):
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::SVGPaintServerPattern::setup):
  • svg/graphics/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback):
  • svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
5:28 PM Changeset in webkit [35730] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Remove #ifdefs from CanvasStyle by using platform/Color.h

There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.

Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32

If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::colorWithOverrideAlpha): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/CanvasStyle.h:
  • platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte): (WebCore::makeRGBA32FromFloats):
  • platform/graphics/Color.h:
4:50 PM Changeset in webkit [35729] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-08-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fix for <rdar://problem/6137931>
​https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry

Tests: media/video-source-type-params.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';' to isSupportedMediaMIMEType()

LayoutTests:

2008-08-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6137931>
​https://bugs.webkit.org/show_bug.cgi?id=20360
Add test case for parameters on a <source> element 'type' attribute.

  • media/video-source-type-params-expected.txt: Added.
  • media/video-source-type-params.html: Added.
2:36 PM Changeset in webkit [35728] by Beth Dakin
  • 4 edits in trunk/WebCore

2008-08-13 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6141345>

This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Now returns a bool instead of the visiblity enum. (WebCore::Editor::firstVisibleRange): This now returns the very first visible range in the document. It's no longer dependent on searching forward. (WebCore::Editor::lastVisibleRange): This now returns the very last visible range in the document. It's no longer dependent on searching backwards. (WebCore::Editor::nextVisibleRange): This returns the next visible range in the appropriate direction from the current range.
  • editing/Editor.h:
  • page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
1:07 PM Changeset in webkit [35727] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for case-sensitive platforms, like Linux.

1:00 PM Changeset in webkit [35726] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-13 Alp Toker <​alp@nuanti.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20349
WTF::initializeThreading() fails if threading is already initialized

Fix threading initialization logic to support cases where
g_thread_init() has already been called elsewhere.

Resolves database-related crashers reported in several applications.

  • wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
12:56 PM Changeset in webkit [35725] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-13 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented

Original patch by Christian Dywan.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
12:42 PM Changeset in webkit [35724] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-13 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add

g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.

  • platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
12:03 PM Changeset in webkit [35723] by adachan@apple.com
  • 6 edits in trunk/WebKit/win

Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
content into a device context. Changed WebView::paintDocumentRectToContext()
to call that WebFrame method.

Reviewed by Adam Roben.

  • DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::paintDocumentRectToContext): (WebFrame::frameElement):
  • WebFrame.h:
  • WebView.cpp: (WebView::paintDocumentRectToContext):
11:11 AM Changeset in webkit [35722] by timothy@apple.com
  • 7 edits in trunk

Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.

WebCore:

2008-08-13 Timothy Hatcher <​timothy@apple.com>

Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.

Reviewed by Kevin McCullough.

  • WebCore.base.exp: Updated the symbol for setWindowVisible.
  • page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Added an attached argument, that defaults to false.Call setAttachedWindow with the attached argument. (WebCore::InspectorController::setAttachedWindow): Call the script version of setAttachedWindow.
  • page/InspectorController.h:
  • page/inspector/inspector.js: (WebInspector.setAttachedWindow): Set the attached property.

WebKit/mac:

2008-08-13 Timothy Hatcher <​timothy@apple.com>

Remember the docked state of the Web Inspector, so it can be
reopened docked if it was last docked.

​https://bugs.webkit.org/show_bug.cgi?id=14271

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Initialize _shouldAttach to the value stored in the user defaults. If there has never been a value stored, default to being attached. (-[WebInspectorWindowController showWindow:]): Pass the attached state to InspectorController::setWindowVisible.
11:10 AM Changeset in webkit [35721] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Remove the Inspector's WebView for the view hierarchy when closed
while attached. This prevents it from showing in the background
while the page changes.

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close:]): Call removeFromSuperview on the Inspector's WebView if it isn't attached, so it will not be visible when navigating pages while closed.
11:10 AM Changeset in webkit [35720] by timothy@apple.com
  • 6 edits
    1 add in trunk/WebCore

Added a close button to the Inspector's toolbar when docked.

​https://bugs.webkit.org/show_bug.cgi?id=14270

Reviewed by Kevin McCullough.

  • page/InspectorController.cpp: (WebCore::closeWindow): Call InspectorController::closeWindow. (WebCore::InspectorController::windowScriptObjectAvailable): Added closeWindow to the script class.
  • page/InspectorController.h:
  • page/inspector/Images/closeButtons.png: Added.
  • page/inspector/inspector.css: Added and changed styles.
  • page/inspector/inspector.html: Added the close button.
  • page/inspector/inspector.js: (WebInspector.loaded): Added click event listener to the close button. (WebInspector.close): Call InspectorController.closeWindow.
11:10 AM Changeset in webkit [35719] by timothy@apple.com
  • 23 edits in trunk

Make the docked Web Inspector resizable.

WebCore:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.

​https://bugs.webkit.org/show_bug.cgi?id=14282

Reviewed by Kevin McCullough.

  • loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
  • page/InspectorClient.h: Added setAttachedWindowHeight.
  • page/InspectorController.cpp: (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight on the InspectorController. (WebCore::InspectorController::setAttachedWindowHeight): Call setAttachedWindowHeight on the client. (WebCore::InspectorController::windowScriptObjectAvailable): Added setAttachedWindowHeight to the script class.
  • page/InspectorController.h:
  • page/inspector/inspector.css: Make the cursor on the toolbar be row-resize when docked.
  • page/inspector/inspector.js: (WebInspector.loaded): Always add the toolbarDragStart event listener. (WebInspector.toolbarDragStart): Return early if we are not attached and not on Leopard. Call WebInspector.elementDragStart. (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd. (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight, otherwise call moveByUnrestricted.

WebKit/gtk:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::setAttachedWindowHeight): Call notImplemented().
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Make the docked Web Inspector resizable.

​https://bugs.webkit.org/show_bug.cgi?id=14282

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight: on the WebInspectorWindowController. (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:. (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code from showWindow: and generalized to allow being called multiple times. Remembers the last height passed, which is used by showWindow: the next time the Inspector attaches.

WebKit/qt:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::setAttachedWindowHeight): Call notImplemented().
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
  • WebCoreSupport/WebInspectorClient.h:

WebKit/wx:

2008-08-12 Timothy Hatcher <​timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::setAttachedWindowHeight): Call notImplemented().
  • WebKitSupport/InspectorClientWx.h:
7:32 AM Changeset in webkit [35718] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Use full-page zoom in QtLauncher.

  • QtLauncher/main.cpp: (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::resetZoom): (MainWindow::setupUI):
7:32 AM Changeset in webkit [35717] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix linking with QtWebKit.

  • Api/qwebframe.h: remove non-existing function/property.
6:43 AM Changeset in webkit [35716] by Simon Hausmann
  • 9 edits in trunk

WebCore:

2008-08-13 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Initialize m_zoomsTextOnly in the Settings constructor.

WebKit/qt:

2008-08-13 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Based on patch by Siraj razick <​siraj.razick@collabora.co.uk>

​https://bugs.webkit.org/show_bug.cgi?id=19125

Added functions to get/set the zoom factor.

Added a QWebFrame/QWebView::zoomFactor as well as a boolean
ZoomTextOnly attribute in QWebSettings.

6:33 AM Changeset in webkit [35715] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
this test hasn't been failing locally for a long time.

  • platform/win/Skipped:
6:31 AM Changeset in webkit [35714] by Simon Hausmann
  • 4 edits in trunk

2008-08-13 Brad Hughes <​bhughes@trolltech.com>

Reviewed by Simon.

Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux

The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).

6:24 AM Changeset in webkit [35713] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-13 Prasanth Ullattil <​prasanth.ullattil@trolltech.com>

Reviewed by Simon.

Fix QtWebKit not displaying content on 403 HTTP responses

Just like with 404 responses also display content with 403, as
used by ​http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/

6:16 AM Changeset in webkit [35712] by Simon Hausmann
  • 3 edits
    2 adds in trunk

WebCore:

2008-08-13 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Qt part of ​https://bugs.webkit.org/show_bug.cgi?id=18994

Make the formatting of String::format() locale independent through the use of QString::vsprintf.

LayoutTests:

2008-08-13 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Adjusted the length-list-parser layout test to compensate for the subtle difference of
dropping a sign for a "negative zero" as a result of the QString::vsprintf use.

5:07 AM Changeset in webkit [35711] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-08-13 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Revert r31585 and disable http tests for the Qt build again unless
explicitly enabled.

Running the http tests unfortunately currently still triggers
failures in non-http tests due to side-effects. Disable them by default for
now, for more reliable results.

5:02 AM Changeset in webkit [35710] by Simon Hausmann
  • 4 edits in trunk

2008-08-13 Simon Hausmann <Simon Hausmann>

Reviewed by Lars.

Fix QWebFrame::setHtml() not setting the new contents immediately.

Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.

Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.

4:51 AM Changeset in webkit [35709] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2008-08-13 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Fix QWebPage::isModified().

isModified() would return true after loading a new page or it would continue to
return true after undoing modifications. Fix this by eliminating the
QWebPagePrivate::modified variable and use the undoStack's canUndo() property
instead.

​https://bugs.webkit.org/show_bug.cgi?id=19252

4:38 AM Changeset in webkit [35708] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-13 David Boddie <​dboddie@trolltech.com>

Reviewed by Simon.

Updated docs with the signal emission behavior of urlChanged()

4:35 AM Changeset in webkit [35707] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix Ctrl+Y to work again when editing text in contextEditable mode.

This fixes regression in LayoutTests/editing/pasteboard/emacs-cntl-y-001.html

2:58 AM Changeset in webkit [35706] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative GTK build fix.

2:11 AM Changeset in webkit [35705] by Simon Hausmann
  • 4 edits in trunk

2008-08-13 Thiago Macieira <​tjmaciei@trolltech.com>

Reviewed by Simon.

Fix encoding of [ and ] in the host part of the URL

Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
​http://[::1]/
is valid and should not be reencoded to:
​http://%5b::1%5d/

Note: See TracTimeline for information about the timeline view.