⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 15, 2008:

11:53 PM Changeset in webkit [35803] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap

Reviewed by Oliver Hunt.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.

11:48 PM Changeset in webkit [35802] by mrowe@apple.com
  • 15 edits in trunk

<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework

Rubber-stamped by Geoff Garen.

3:58 PM Changeset in webkit [35801] by Antti Koivisto
  • 6 edits in trunk/WebCore

2008-08-15 Antti Koivisto <Antti Koivisto>

Reviewed by Anders.

Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.


Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.


With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::scanningBody): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
  • html/PreloadScanner.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::preload): (WebCore::DocLoader::checkForPendingPreloads): (WebCore::DocLoader::requestPreload):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
2:08 PM Changeset in webkit [35800] by adachan@apple.com
  • 2 edits in trunk/WebCore

Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.

Reviewed by Dave Hyatt and Dan Bernstein.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle):
1:48 PM Changeset in webkit [35799] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-08-15 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Some loader performance tweaks:

  • Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue to not delay rendering.
  • Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup can take long time when latency is high so it is good to get started early.
  • When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the load queues. Issue remaining loads to the network layer.
  • loader/loader.cpp: (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
  • loader/loader.h:
11:35 AM Changeset in webkit [35798] by timothy@apple.com
  • 2 edits in trunk/WebCore

Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.

https://bugs.webkit.org/show_bug.cgi?id=20402

Reviewed by Adam Roben.

  • page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Call stopDebugging() if the window is no longer visible.
11:27 AM Changeset in webkit [35797] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tim Hatcher.

  • update results for console.dir
  • fast/dom/Window/window-properties-expected.txt:
11:12 AM Changeset in webkit [35796] by Simon Hausmann
  • 7 edits in trunk/WebKit/qt

2008-08-15 Håvard Wall <hwall@trolltech.com>

Reviewed by Simon.

Fixes: compile with QT_NO_UNDOCOMMAND/STACK

11:12 AM Changeset in webkit [35795] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-15 Håvard Wall <hwall@trolltech.com>

Reviewed by Simon.

Fixes: compile with QT_NO_STYLE_STYLESHEET

11:12 AM Changeset in webkit [35794] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Håvard Wall <hwall@trolltech.com>

Fixes: compile with QT_NO_SHORTCUT

11:12 AM Changeset in webkit [35793] by Simon Hausmann
  • 9 edits in trunk

2008-08-15 Håvard Wall <hwall@trolltech.com>

Reviewed by Simon.

Fixes: compile with QT_NO_CONTEXTMENU

11:11 AM Changeset in webkit [35792] by Simon Hausmann
  • 7 edits in trunk

2008-08-15 Håvard Wall <hwall@trolltech.com>

Reviewed by Simon.

Fixes: compile with QT_NO_WHEELEVENT

11:11 AM Changeset in webkit [35791] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Håvard Wall <hwall@trolltech.com>

Fixes: compile with QT_NO_PRINTER

11:10 AM Changeset in webkit [35790] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-08-15 David Boddie <dboddie@trolltech.com>

Reviewed by Simon.

Doc: Added documentation for default property values.

11:10 AM Changeset in webkit [35789] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

David Boddie <dboddie@trolltech.com>

Doc: Renamed snippets that appear in the code directory.

10:48 AM Changeset in webkit [35788] by timothy@apple.com
  • 7 edits in trunk/WebCore

Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector

https://bugs.webkit.org/show_bug.cgi?id=20210

Reviewed by Tim Hatcher.

  • page/Console.cpp: (WebCore::Console::group): (WebCore::Console::groupEnd):
  • page/Console.h: (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
  • page/InspectorController.cpp: (WebCore::InspectorController::startGroup): Increments group level by one and adds console message with StartGroupMessaageLevel. (WebCore::InspectorController::endGroup): Decrements group level by one and adds console message with EndGroupMessaageLevel.
  • page/InspectorController.h:
  • page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup if the message is StartGroupMessaageLevel. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleGroup.prototype.addMessage):
  • page/inspector/inspector.js:
10:35 AM Changeset in webkit [35787] by timothy@apple.com
  • 8 edits in trunk/WebCore

Adds support for console.dir to the Inspector

https://bugs.webkit.org/show_bug.cgi?id=19155

Reviewed by Tim Hatcher.

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::dir):
  • page/Console.cpp: (WebCore::Console::dir):
  • page/Console.h: Added ObjectMessageLevel.
  • page/Console.idl: Added console.dir.
  • page/inspector/Console.js: (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an ObjectPropertiesSection if the MessageLevel is Object.
  • page/inspector/ObjectPropertiesSection.js: "in" operator can't be used on primitive data types.
  • page/inspector/inspector.css:
10:06 AM Changeset in webkit [35786] by timothy@apple.com
  • 2 edits in trunk/WebCore

Adds support for clear() in the Inspector console.

https://bugs.webkit.org/show_bug.cgi?id=19873

Reviewed by Tim Hatcher.

  • page/inspector/Console.js:
10:02 AM Changeset in webkit [35785] by timothy@apple.com
  • 2 edits in trunk/WebCore

Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.

Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>

Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313

Reviewed by Tim Hatcher.

  • page/inspector/inspector.js: Added a case for the F key
9:50 AM Changeset in webkit [35784] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix for error when the string doesn't contain a webkit-profile link.

https://bugs.webkit.org/show_bug.cgi?id=20399

Reviewed by Tim Hatcher.

  • page/inspector/inspector.js:
9:33 AM Changeset in webkit [35783] by timothy@apple.com
  • 3 edits
    1 add in trunk/WebCore

Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.

The first issue was JSLazyEventListener not checking the paused
state before parsing the code.

The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.

https://bugs.webkit.org/show_bug.cgi?id=20284

Reviewed by Adam Roben.

  • bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Check the paused state of the ScriptController. Return early if paused.
  • manual-tests/inspector/debugger-execution-while-paused.html: Added.
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Pass the paused argument to the Page version of setJavaScriptPaused.
7:55 AM Changeset in webkit [35782] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix the 64-bit build.

Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.

  • kjs/JSImmediate.h:

(KJS::JSImmediate::intValue):
(KJS::JSImmediate::uintValue):

4:59 AM Changeset in webkit [35781] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Still fixing Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString to yet another place.
4:41 AM Changeset in webkit [35780] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/kjs/JSImmediate.h

Windows build fix

4:14 AM Changeset in webkit [35779] by ap@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

Trying to fix non-Apple builds.

  • ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
3:42 AM Changeset in webkit [35778] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-08-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
but instead holds an immediate value encoded within the pointer. This patch changes the
encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
a 31 bit value to be stored. All other immediates are tagged with the value 10, and
distinguished by a secondary tag.

Roughly +2% on SunSpider.

  • kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for

descption of new layout.

3:18 AM Changeset in webkit [35777] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

More build fixes.

  • API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
  • API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
  • JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
1:32 AM Changeset in webkit [35776] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Build fix.

  • JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
  • kjs/identifier.cpp: (KJS::Identifier::checkSameIdentifierTable):
  • kjs/identifier.h: (KJS::Identifier::add): Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be non-inline in release builds, too.
12:43 AM Changeset in webkit [35775] by ap@webkit.org
  • 19 edits
    2 adds in trunk

Reviewed by Geoff Garen.

JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.

Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.

Aug 14, 2008:

11:15 PM Changeset in webkit [35774] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Update cache capacities to match values used on Mac.


Reviewed by Dan Bernstein.

  • WebView.cpp: (WebView::setCacheModel):
10:10 PM Changeset in webkit [35773] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)

5:53 PM Changeset in webkit [35772] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache

Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
5:44 PM Changeset in webkit [35771] by weinig@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Jon Honeycutt.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
  • WebView.h:
4:58 PM Changeset in webkit [35770] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add the bug URL to the ChangeLog.

4:57 PM Changeset in webkit [35769] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Make Firebug command line API respect predefined variables.

Reviewed by Tim Hatcher.

  • page/inspector/Console.js:
4:45 PM Changeset in webkit [35768] by Simon Fraser
  • 2 edits
    2 adds in trunk/LayoutTests

2008-08-14 Simon Fraser <Simon Fraser>

Fix testcase and add pixel results for testcase in
https://bugs.webkit.org/show_bug.cgi?id=20367

  • platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.txt:
4:33 PM Changeset in webkit [35767] by weinig@apple.com
  • 9 edits in trunk

WebCore:

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.

  • WebCore.base.exp:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
  • html/HTMLTokenizer.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
  • page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):

WebKit/mac:

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
  • WebView/WebViewPrivate.h:
4:20 PM Changeset in webkit [35766] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Beth.

Move us one step closer to cross-platform svg/graphics code

  • WebCore.xcodeproj/project.pbxproj:
  • html/CanvasStyle.cpp:
  • platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
  • platform/graphics/Color.h:
  • svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
  • svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
4:19 PM Changeset in webkit [35765] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Alexey.

Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • html/CanvasStyle.cpp:
  • html/HTMLCanvasElement.cpp:
4:19 PM Changeset in webkit [35764] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Clean up GlyphBuffer.h, removing more #ifdefs

  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
4:19 PM Changeset in webkit [35763] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Clean up AffineTransform.h, removing #ifdefs

  • platform/graphics/AffineTransform.h:
  • platform/graphics/cairo/AffineTransformCairo.cpp:
  • platform/graphics/cg/AffineTransformCG.cpp:
  • platform/graphics/qt/AffineTransformQt.cpp:
  • platform/graphics/wx/AffineTransformWx.cpp:
4:12 PM Changeset in webkit [35762] by mitz@apple.com
  • 4 edits in trunk/WebCore

2008-08-14 Dan Bernstein <mitz@apple.com>

  • fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
4:08 PM Changeset in webkit [35761] by mitz@apple.com
  • 6 edits in trunk/WebCore

2008-08-14 Dan Bernstein <mitz@apple.com>

Reviewed by Brady Eidson.

  • fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
  • platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
  • platform/graphics/ImageSource.h: Added frameSizeAtIndex().
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
4:04 PM Changeset in webkit [35760] by Simon Fraser
  • 3 edits
    2 adds in trunk

2008-08-13 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367

Test: fast/css/font-face-in-media-rule.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
3:52 PM Changeset in webkit [35759] by kevino@webkit.org
  • 6 edits in trunk/WebCore

wx build fixes after recent changes to Canvas and Image classes.

12:26 PM Changeset in webkit [35758] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Maxime Britto <britto@apple.com>

Reviewed by Sam Weinig.

rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
12:14 PM Changeset in webkit [35757] by christian@webkit.org
  • 4 edits in trunk/WebCore

Gtk+/ Cairo build fix, patch by Dirk Schulze.

11:11 AM Changeset in webkit [35756] by kmccullough@apple.com
  • 16 edits in trunk

JavaScriptCore:

2008-08-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
  • profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
  • profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
  • profiler/Profile.h: (KJS::Profile::uid):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h:
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
  • profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
  • profiler/TreeProfile.h:

WebCore:

2008-08-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
  • page/InspectorController.h:
  • page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
  • page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
  • page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
10:41 AM Changeset in webkit [35755] by timothy@apple.com
  • 3 edits in trunk/WebCore

Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
9:12 AM Changeset in webkit [35754] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.

https://bugs.webkit.org/show_bug.cgi?id=20376

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
8:07 AM Changeset in webkit [35753] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>

partial Gtk build fix, not reviewed

  • platform/graphics/cairo/PatternCairo.cpp:
Note: See TracTimeline for information about the timeline view.