Timeline
Aug 16, 2008:
- 10:06 PM Changeset in webkit [35805] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:28 PM Changeset in webkit [35804] by
-
- 3 edits in trunk/WebCore
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Aug 15, 2008:
- 11:53 PM Changeset in webkit [35803] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
- 11:48 PM Changeset in webkit [35802] by
-
- 15 edits in trunk
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
Rubber-stamped by Geoff Garen.
- 3:58 PM Changeset in webkit [35801] by
-
- 6 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::scanningBody): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
- html/PreloadScanner.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::preload): (WebCore::DocLoader::checkForPendingPreloads): (WebCore::DocLoader::requestPreload):
- loader/DocLoader.h:
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- 2:08 PM Changeset in webkit [35800] by
-
- 2 edits in trunk/WebCore
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle):
- 1:48 PM Changeset in webkit [35799] by
-
- 3 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the load queues. Issue remaining loads to the network layer.
- loader/loader.cpp: (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 11:35 AM Changeset in webkit [35798] by
-
- 2 edits in trunk/WebCore
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
Reviewed by Adam Roben.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Call stopDebugging() if the window is no longer visible.
- 11:27 AM Changeset in webkit [35797] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tim Hatcher.
- update results for console.dir
- fast/dom/Window/window-properties-expected.txt:
- 11:12 AM Changeset in webkit [35796] by
-
- 7 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_UNDOCOMMAND/STACK
- 11:12 AM Changeset in webkit [35795] by
-
- 2 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_STYLE_STYLESHEET
- 11:12 AM Changeset in webkit [35794] by
-
- 2 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_SHORTCUT
- 11:12 AM Changeset in webkit [35793] by
-
- 9 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
- 11:11 AM Changeset in webkit [35792] by
-
- 7 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
- 11:11 AM Changeset in webkit [35791] by
-
- 3 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_PRINTER
- 11:10 AM Changeset in webkit [35790] by
-
- 3 edits in trunk/WebKit/qt
2008-08-15 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Doc: Added documentation for default property values.
- 11:10 AM Changeset in webkit [35789] by
-
- 2 edits in trunk/WebKit/qt
David Boddie <dboddie@trolltech.com>
Doc: Renamed snippets that appear in the code directory.
- 10:48 AM Changeset in webkit [35788] by
-
- 7 edits in trunk/WebCore
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
Reviewed by Tim Hatcher.
- page/Console.cpp: (WebCore::Console::group): (WebCore::Console::groupEnd):
- page/Console.h: (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
- page/InspectorController.cpp: (WebCore::InspectorController::startGroup): Increments group level by one and adds console message with StartGroupMessaageLevel. (WebCore::InspectorController::endGroup): Decrements group level by one and adds console message with EndGroupMessaageLevel.
- page/InspectorController.h:
- page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup if the message is StartGroupMessaageLevel. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleGroup.prototype.addMessage):
- page/inspector/inspector.js:
- 10:35 AM Changeset in webkit [35787] by
-
- 8 edits in trunk/WebCore
Adds support for console.dir to the Inspector
Reviewed by Tim Hatcher.
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::dir):
- page/Console.cpp: (WebCore::Console::dir):
- page/Console.h: Added ObjectMessageLevel.
- page/Console.idl: Added console.dir.
- page/inspector/Console.js: (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an ObjectPropertiesSection if the MessageLevel is Object.
- page/inspector/ObjectPropertiesSection.js: "in" operator can't be used on primitive data types.
- page/inspector/inspector.css:
- 10:06 AM Changeset in webkit [35786] by
-
- 2 edits in trunk/WebCore
Adds support for clear() in the Inspector console.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 10:02 AM Changeset in webkit [35785] by
-
- 2 edits in trunk/WebCore
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
- page/inspector/inspector.js: Added a case for the F key
- 9:50 AM Changeset in webkit [35784] by
-
- 2 edits in trunk/WebCore
Fix for error when the string doesn't contain a webkit-profile link.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 9:33 AM Changeset in webkit [35783] by
-
- 3 edits1 add in trunk/WebCore
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
Reviewed by Adam Roben.
- bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Check the paused state of the ScriptController. Return early if paused.
- manual-tests/inspector/debugger-execution-while-paused.html: Added.
- page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Pass the paused argument to the Page version of setJavaScriptPaused.
- 7:55 AM Changeset in webkit [35782] by
-
- 2 edits in trunk/JavaScriptCore
Fix the 64-bit build.
Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.
- kjs/JSImmediate.h:
(KJS::JSImmediate::intValue):
(KJS::JSImmediate::uintValue):
- 4:59 AM Changeset in webkit [35781] by
-
- 2 edits in trunk/JavaScriptCore
Still fixing Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString to yet another place.
- 4:41 AM Changeset in webkit [35780] by
-
- 1 edit in trunk/JavaScriptCore/kjs/JSImmediate.h
Windows build fix
- 4:14 AM Changeset in webkit [35779] by
-
- 1 edit1 add in trunk/JavaScriptCore
Trying to fix non-Apple builds.
- ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
- 3:42 AM Changeset in webkit [35778] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
but instead holds an immediate value encoded within the pointer. This patch changes the
encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
a 31 bit value to be stored. All other immediates are tagged with the value 10, and
distinguished by a secondary tag.
Roughly +2% on SunSpider.
- kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
descption of new layout.
- 3:18 AM Changeset in webkit [35777] by
-
- 4 edits in trunk/JavaScriptCore
More build fixes.
- API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
- API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
- JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
- 1:32 AM Changeset in webkit [35776] by
-
- 5 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
- kjs/identifier.cpp: (KJS::Identifier::checkSameIdentifierTable):
- kjs/identifier.h: (KJS::Identifier::add): Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be non-inline in release builds, too.
- JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
- 12:43 AM Changeset in webkit [35775] by
-
- 19 edits2 adds in trunk
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
