⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 18, 2008:

9:39 PM Changeset in webkit [35830] by Darin Adler
  • 47 edits
    3 adds in trunk

JavaScriptCore:

2008-08-12 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • eliminate JSValue::type()

This will make it slightly easier to change the JSImmediate design without
having to touch so many call sites.

SunSpider says this change is a wash (looked like a slight speedup, but not
statistically significant).

  • API/JSStringRef.cpp: Removed include of JSType.h.
  • API/JSValueRef.cpp: Removed include of JSType.h. (JSValueGetType): Replaced use of JSValue::type() with JSValue::is functions.
  • VM/JSPropertyNameIterator.cpp: Removed type() implementation. (KJS::JSPropertyNameIterator::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • VM/JSPropertyNameIterator.h: Ditto.
  • VM/Machine.cpp: (KJS::fastIsNumber): Updated for name change. (KJS::fastToInt32): Ditto. (KJS::fastToUInt32): Ditto. (KJS::jsAddSlowCase): Updated toPrimitive caller for change from JSType to PreferredPrimitiveType. (KJS::jsAdd): Replaced calls to JSValue::type() with calls to JSValue::isString(). (KJS::jsTypeStringForValue): Replaced calls to JSValue::type() with multiple calls to JSValue::is -- we could make this a virtual function instead if we want to have faster performance. (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32 to JSImmediate::getTruncatedUInt32 for consistency with other functions. Changed two calls of JSValue::type() to JSValue::isString().
  • kjs/GetterSetter.cpp: (KJS::GetterSetter::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType. (KJS::GetterSetter::isGetterSetter): Added.
  • kjs/GetterSetter.h:
  • kjs/JSCell.cpp: (KJS::JSCell::isString): Added. (KJS::JSCell::isGetterSetter): Added. (KJS::JSCell::isObject): Added.
  • kjs/JSCell.h: Eliminated type function. Added isGetterSetter. Made isString and isObject virtual. Changed toPrimitive to take PreferredPrimitiveType argument instead of JSType. (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance. (KJS::JSValue::isGetterSetter): Added. (KJS::JSValue::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • kjs/JSImmediate.h: Removed JSValue::type() and replaced JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32. (KJS::JSImmediate::isEitherImmediate): Added.
  • kjs/JSNotAnObject.cpp: (KJS::JSNotAnObject::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • kjs/JSNotAnObject.h: Ditto.
  • kjs/JSNumberCell.cpp: (KJS::JSNumberCell::toPrimitive): Ditto.
  • kjs/JSNumberCell.h: (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no other "slow" version of this once you have a JSNumberCell, so there's no need for "fast" in the name. It's a feature that this hides the base class toInt32, which does the same job less efficiently (and has an additional ExecState argument). (KJS::JSNumberCell::toUInt32): Ditto.
  • kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Use isGetterSetter instead of type. (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType. (KJS::JSObject::defaultValue): Ditto. (KJS::JSObject::defineGetter): Use isGetterSetter. (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::lookupGetter): Ditto. (KJS::JSObject::lookupSetter): Ditto. (KJS::JSObject::toNumber): Use PreferredPrimitiveType. (KJS::JSObject::toString): Ditto. (KJS::JSObject::isObject): Added.
  • kjs/JSObject.h: (KJS::JSObject::inherits): Call the isObject from JSCell; it's now hidden by our override of isObject. (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter instead of type. (KJS::JSObject::getOwnPropertySlot): Ditto. (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
  • kjs/JSString.cpp: (KJS::JSString::toPrimitive): Use PreferredPrimitiveType. (KJS::JSString::isString): Added.
  • kjs/JSString.h: Ditto.
  • kjs/JSValue.h: Removed type(), added isGetterSetter(). Added PreferredPrimitiveType enum and used it as the argument for the toPrimitive function. (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
  • kjs/collector.cpp: (KJS::typeName): Changed to use JSCell::is functions instead of calling JSCell::type.
  • kjs/collector.h: (KJS::Heap::isNumber): Renamed from fastIsNumber.
  • kjs/nodes.h: Added now-needed include of JSType, since the type is used here to record types of values in the tree.
  • kjs/operations.cpp: (KJS::equal): Rewrote to no longer depend on type(). (KJS::strictEqual): Ditto.

JavaScriptGlue:

2008-08-12 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • JSUtils.cpp: (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with JSValue::is functions.
  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot): Ditto. (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument instead of JSType argument.
  • UserObjectImp.h: Ditto.

WebCore:

2008-08-12 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • bridge/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean, since that's never passed.
  • bridge/c/c_instance.h: Ditto.
  • bridge/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions instead of JSValue::type(). Removed unneeded code to handle "unspecified".
  • bridge/jni/jni_instance.cpp: (JavaInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
  • bridge/jni/jni_instance.h: Ditto.
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::convertValueToJObject): Use JSValue::is functions instead of JSValue::type().
  • bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed unused argument.
  • bridge/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): Removed unused argument. (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean and another dead code path for unknown types.
  • bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed override of type() that caused the fallback object to return "UndefinedType" when there is no invokeUndefinedMethodFromWebScript:withArguments: method defined. That didn't accomplish much, since most checks for undefined don't ever call type().
  • bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::defaultValue): Ditto.
  • bridge/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
  • bridge/qt/qt_instance.h: Ditto.
  • bridge/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): Removed unsed argument.
  • bridge/runtime_object.cpp: (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument.
  • bridge/runtime_object.h: Ditto.

WebKit/mac:

2008-08-12 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • WebView/WebView.mm: (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead of a switch on JSValue::type().

LayoutTests:

2008-08-12 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • added a test since I had to rewrite the == and === operators
  • fast/js/equality-expected.txt: Added.
  • fast/js/equality.html: Added.
  • fast/js/resources/equality.js: Added.
5:42 PM Changeset in webkit [35829] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-18 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :

FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.

This patch matches FF3 behavior by disabling every key but the esc key.

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped. (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
5:20 PM Changeset in webkit [35828] by mitz@apple.com
  • 10 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

Test: fast/replaced/max-width-percent.html

Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidth):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcPrefWidths):
  • rendering/RenderVideo.h:

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
  • fast/replaced/max-width-percent.html: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.png: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.txt: Added.
4:08 PM Changeset in webkit [35827] by Simon Fraser
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Make transition_shorthand_parsing.html a text-only test.

  • fast/css/transition_shorthand_parsing-expected.txt: Added.
  • fast/css/transition_shorthand_parsing.html:
  • platform/mac/fast/css/transition_shorthand_parsing-expected.txt:
3:47 PM Changeset in webkit [35826] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-08-18 Daniel Macks <​dmacks@netspace.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.

  • platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::read):
3:11 PM Changeset in webkit [35825] by Simon Fraser
  • 3 edits
    2 adds in trunk

Reviewed by Dave Hyatt

Need to make sure we have an Animation in the AnimationList
before setting the initial value.
​https://bugs.webkit.org/show_bug.cgi?id=20408

Test: fast/css/transition_shorthand_parsing.html

  • css/CSSStyleSelector.cpp:
2:55 PM Changeset in webkit [35824] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.

1:53 PM Changeset in webkit [35823] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-08-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

If there are no nodes in a profile all the time should be attributed to
(idle)

  • profiler/Profile.cpp: If ther are no nodes make sure we still process the head. (KJS::Profile::forEach):
  • profiler/ProfileGenerator.cpp: Remove some useless code. (KJS::ProfileGenerator::stopProfiling):
1:53 PM Changeset in webkit [35822] by jchaffraix@webkit.org
  • 8 edits
    5 adds in branches/XBL2

WebCore:

2008-08-18 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20347: [XBL] Add support for DocumentXBL interface

  • Add a custom NamedNodeMap for document.bindingsDocument as it is a static map that throws NO_MODIFICATIN_ALLOWED_ERR on modification.

Test: fast/xbl/xbl-bindingDocuments.html

  • GNUmakefile.am: Add NamedStaticDocumentMap.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_bindingDocuments. (WebCore::Document::~Document): Zero m_bindingDocuments. (WebCore::Document::bindingDocuments): Getter method. (WebCore::Document::loadBindingDocument): Stub method as we need an helper class to load bindings. (WebCore::Document::createBindingDocumentsIfNeeded):
  • dom/Document.h:
  • dom/Document.idl: Add documentXBL interface.
  • dom/NamedStaticDocumentMap.cpp: Added. (WebCore::NamedStaticDocumentMap::NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::~NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::getNamedItem): (WebCore::NamedStaticDocumentMap::removeNamedItem): (WebCore::NamedStaticDocumentMap::getNamedItemNS): (WebCore::NamedStaticDocumentMap::removeNamedItemNS): (WebCore::NamedStaticDocumentMap::setNamedItem): (WebCore::NamedStaticDocumentMap::item): (WebCore::NamedStaticDocumentMap::addItem):
  • dom/NamedStaticDocumentMap.h: Added. (WebCore::NamedStaticDocumentMap::create): (WebCore::NamedStaticDocumentMap::length): (WebCore::NamedStaticDocumentMap::clear): Custom NamedNodeMap that match the specification.

LayoutTests:

2008-08-18 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20347: [XBL] Add support for DocumentXBL interface

  • fast/xbl/resources/bindingDocuments.js: Added.
  • fast/xbl/xbl-bindingDocuments-expected.txt: Added.
  • fast/xbl/xbl-bindingDocuments.html: Added.
1:21 PM Changeset in webkit [35821] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.

  • page/inspector/ProfilesPanel.js:
12:55 PM Changeset in webkit [35820] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages

  • page/inspector/Console.js:
8:54 AM Changeset in webkit [35819] by jchaffraix@webkit.org
  • 8 edits
    5 adds in branches/XBL2

WebCore:

2008-08-18 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20263: [XBL] Add loading code for XBLBinding

Test: fast/xbl/xbl-empty-fragment-loadBinding.html

  • GNUmakefile.am: Add XBLBinding.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • xbl/XBLBinding.cpp: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::~XBLBinding): (WebCore::XBLBinding::setXBLDocument): (WebCore::XBLBinding::getBindingElement):
  • xbl/XBLBinding.h: Inherit from CachedResourceClient to use the Cache management. Also added the bound element, the <binding> element as members.


  • xbl/XBLBindingManager.cpp: Changed Vector<XBLBinding>* to Vector<XBLBinding*>* as we were taking a pointer to a local value.


(WebCore::XBLBindingManager::addBinding): Ditto.
(WebCore::XBLBindingManager::removeBinding): Ditto.
(WebCore::XBLBindingManager::hasBinding): Ditto.
(WebCore::XBLBindingManager::removeAllBindings): Ditto.

  • xbl/XBLBindingManager.h: Ditto.

LayoutTests:

2008-08-18 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.


Test case for bug 20263: [XBL] Add loading code for XBLBinding


  • fast/xbl/resources/xbl-failed-binding.xbl: Added.
  • fast/xbl/resources/xbl-passed-binding.xbl: Added.
  • fast/xbl/xbl-empty-fragment-loadBinding-expected.txt: Added.
  • fast/xbl/xbl-empty-fragment-loadBinding.html: Added.


7:54 AM Changeset in webkit [35818] by mrowe@apple.com
  • 77 edits in trunk/WebKitSite

Upgrade to WordPress 2.6.1.

4:20 AM Changeset in webkit [35817] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-18 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.

​https://bugs.webkit.org/show_bug.cgi?id=20405

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
4:14 AM Changeset in webkit [35816] by jmalonzo@webkit.org
  • 8 edits in trunk

2008-08-18 Alp Toker <​alp@nuanti.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=20350
[GTK] Get DumpRenderTree working

WebKit/gtk:

Add a private function to WebFrame to dump the render tree as required
for the DumpRenderTree testing tool.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

WebKitTools/DumpRenderTree/gtk:

Fixes and enhancements to DumpRenderTree. With these changes, the test
suite can now complete a run producing text and render tree dumps.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dump): (runTest): (webViewLoadFinished): (webViewWindowObjectCleared): (webViewConsoleMessage): (webViewScriptAlert): (webViewScriptPrompt): (webViewScriptConfirm): (webViewTitleChanged): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList): (LayoutTestController::pathToLocalResource): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (waitToDumpWatchdogFired): (LayoutTestController::windowCount):
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (JSStringCopyUTF8CString): (ScriptItem::invoke):
1:09 AM Changeset in webkit [35815] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Make JSGlobalContextRetain/Release actually work.

  • API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): Ref/deref global data to give checking for globalData.refCount() some sense.
  • API/tests/testapi.c: (main): Added a test for this bug.
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData): While checking for memory leaks, found that JSGlobalData::emptyList has changed to a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.

Aug 17, 2008:

8:21 PM Changeset in webkit [35814] by timothy@apple.com
  • 3 edits in trunk/WebCore

Complete in scope variables in the Console when paused.

​https://bugs.webkit.org/show_bug.cgi?id=19115

Reviewed by Geoffrey Garen.

  • page/inspector/Console.js: (WebInspector.Console.prototype.completions): If the expressionString is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame to get an object that declares all the in scope variables. That way "top level" expressions are completed.
  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame): Return an object that has all the variables that are in scope for the selected call frame. The value of each property is just true. The return object is useful for quick lookups or auto completion.
7:42 PM Changeset in webkit [35813] by cwzwarich@webkit.org
  • 7 edits in trunk

2008-08-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Change the counting of constants so that preincrement and predecrement of
const local variables are considered unexpected loads.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::PrefixResolveNode::emitCode):
  • kjs/nodes.h: (KJS::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/deep-recursion-test.html:
4:38 PM Changeset in webkit [35812] by oliver@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
<​https://bugs.webkit.org/show_bug.cgi?id=20386>

Reviewed by Cameron Zwarich.

This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain. Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind. Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution. This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.

2:34 PM Changeset in webkit [35811] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-08-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Speculative Qt build fix.

  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
2:27 PM Changeset in webkit [35810] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-08-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 20419: Remove op_jless
<​https://bugs.webkit.org/show_bug.cgi?id=20419>

Remove op_jless, which is rarely used now that we have op_loop_if_less.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.h:
2:18 PM Changeset in webkit [35809] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Dan Bernstein.

Fix a typo in r35807 that is also causing build failures for
non-AllInOne builds.

  • kjs/NumberConstructor.cpp:
1:28 PM Changeset in webkit [35808] by ggaren@apple.com
  • 9 edits in trunk

JavaScriptGlue:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Updated project files to XCode 3.1.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Updated project files to XCode 3.1.

  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Updated project files to XCode 3.1.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Updated project files to XCode 3.1.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1:23 PM Changeset in webkit [35807] by ggaren@apple.com
  • 85 edits in trunk

JavaScriptCore:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Made room for a free word in JSCell.


SunSpider says no change.


I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
store auxiliary data in a secondary structure.

I changed InternalFunction to store the function's name in the property
map.


I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
JSDOMWindowBaseData could inherit from it safely. (It's a strange design
for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
but that's really our only option, given the size constraint.)


I also added a bunch of compile-time ASSERTs, and removed lots of comments
in JSObject.h because they were often out of date, and they got in the
way of reading what was actually going on.


Also renamed JSArray::getLength to JSArray::length, to match our style
guidelines.

WebCore:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Made room for a free word in JSCell.


Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.


Added a bunch of ASSERTs, to help catch over-sized objects.

WebKit/mac:

2008-08-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Made room for a free word in JSCell.


(Updated for JavaScriptCore changes.)

12:57 AM Changeset in webkit [35806] by ggaren@apple.com
  • 10 edits in trunk/JavaScriptCore

2007-08-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Sped up property access for array.length and string.length by adding a
mechanism for returning a temporary value directly instead of returning
a pointer to a function that retrieves the value.


Also removed some unused cruft from PropertySlot.


SunSpider says 0.5% - 1.2% faster.

NOTE: This optimization is not a good idea in general, because it's
actually a pessimization in the case of resolve for assignment,
and it may get in the way of other optimizations in the future.

Note: See TracTimeline for information about the timeline view.