Timeline
Aug 20, 2008:
- 11:52 PM Changeset in webkit [35871] by
-
- 2 edits in trunk/WebCore
Fix build failure.
Reviewed by Jon Honeycutt.
- bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.
- 10:03 PM Changeset in webkit [35870] by
-
- 2 edits in trunk/PlanetWebKit
Add Anthony Ricaud's blog.
Reviewed by Tim Hatcher.
- config.ini: Add Anthony Ricaud's blog.
- 9:01 PM Changeset in webkit [35869] by
-
- 3 edits in trunk/WebCore
Build fix.
- 5:33 PM Changeset in webkit [35868] by
-
- 14 edits in trunk
WebCore:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and rename related methods and variables accordingly.
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen):
- page/FrameView.h:
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents):
WebKit/mac:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen, rename related methods and variables accordingly, and make -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen WebView API.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
- WebView/WebView.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView setShouldUpdateWhileOffscreen:]): (-[WebView shouldUpdateWhileOffscreen]):
- WebView/WebViewPrivate.h:
- 5:13 PM Changeset in webkit [35867] by
-
- 2 edits in trunk/WebCore
2008-08-20 Brady Eidson <beidson@apple.com>
Reviewed by Mitzpettel
<rdar://problem/6163636> - Many images broken in Mail
This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.
When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is CachedResource::PreloadReferenced.
- 4:20 PM Changeset in webkit [35866] by
-
- 7 edits in trunk/WebKit/mac
Switch to non-deprecated NSFileManager APIs.
In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.
Reviewed by Darin Adler.
- 4:04 PM Changeset in webkit [35865] by
-
- 2 adds in trunk/LayoutTests/fast/css
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
- fast/css/getComputedStyle-transform-expected.txt: Added.
- fast/css/getComputedStyle-transform.html: Added.
(Missed these test files on last commit)
- 3:50 PM Changeset in webkit [35864] by
-
- 3 edits in trunk/WebCore
2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Catch up with the JSValue::type elimination.
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::defaultValue):
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::QtRuntimeConnectionMethod::call):
- 3:15 PM Changeset in webkit [35863] by
-
- 2 edits in trunk/WebCore
2008-08-20 Chris Teague <chris.teague@gmail.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
- ChangeLog:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 2:57 PM Changeset in webkit [35862] by
-
- 5 edits in trunk
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
Test: fast/css/getComputedStyle-transform.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
- rendering/style/RenderStyle.h:
- 2:04 PM Changeset in webkit [35861] by
-
- 6 edits in trunk
WebCore:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- bridge/npapi.h: (_NPCocoaEvent::):
WebKit/mac:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
WebKitExamplePlugins:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- NetscapeCocoaPlugin/main.m: (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent):
- 1:46 PM Changeset in webkit [35860] by
-
- 12 edits in trunk
WebCore:
2008-08-20 Beth Dakin <Beth Dakin>
Reviewed by Darin.
Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.
This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.
- dom/Node.cpp: (WebCore::Node::isInShadowTree):
- dom/Node.h:
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Returns false if excludeFromTextSearch() is true.
In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):
- editing/Editor.h:
excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.
- WebCore.base.exp:
- page/Frame.cpp: (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.
WebKit/mac:
2008-08-20 Beth Dakin <Beth Dakin>
Reviewed by Darin.
Fix for <rdar://problem/6145626>
Allows a WebKit client to mark a frame as not-text-searchable
through SPI.
- WebView/WebFrame.mm: (-[WebFrame _setExcludeFromTextSearch:]):
- WebView/WebFramePrivate.h:
- 12:10 PM Changeset in webkit [35859] by
-
- 4 edits in trunk/WebCore
Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.
Reviewed by Kevin McCullough.
- English.lproj/localizedStrings.js: Updated the strings.
- page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Renamed the boxPartValue function to createBoxPartElement and made it create the entire element. Made it understand how to get position style properties. Don't use the figure dash when 0px is used for positions, since the 0 is meaningful there. Instead use the figure dash when a position is auto.
- page/inspector/inspector.css: Added a new rule for position.
- 12:01 PM Changeset in webkit [35858] by
-
- 5 edits in trunk
2008-08-20 Maxime Britto <britto@apple.com>
Reviewed by Ada Chan.
rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
- Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
- WebView.cpp: (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
2008-08-20 Maxime Britto <britto@apple.com>
Reviewed by Ada Chan.
rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
- DumpRenderTree/win/UIDelegate.h: (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
- 11:34 AM Changeset in webkit [35857] by
-
- 2 edits in trunk/WebCore
Qt build fix
- 11:28 AM Changeset in webkit [35856] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- avoid using a deprecated NSScroller method on Leopard
- platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion):
- 4:40 AM Changeset in webkit [35855] by
-
- 3 edits in trunk/WebCore
2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix
- GNUmakefile.am:
- page/AccessibilityTable.cpp: Change nil to 0 (WebCore::AccessibilityTable::cellForColumnAndRow):
- 3:40 AM Changeset in webkit [35854] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
- 12:23 AM Changeset in webkit [35853] by
-
- 100 edits5 adds in trunk
Reviewed by Geoff Garen.
Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
Aug 19, 2008:
- 10:51 PM BuildingOnWindows edited by
- (diff)
- 4:33 PM Changeset in webkit [35852] by
-
- 15 edits in trunk/WebCore
Reviewed by Geoff Garen.
Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.
I'll follow this up with actual *Skia.cpp files in a separate patch.
- platform/graphics/AffineTransform.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.h:
- 3:46 PM Changeset in webkit [35851] by
-
- 2 edits in trunk/WebCore
Fix Windows build more.
- WebCore.vcproj/WebCore.vcproj:
- 3:36 PM Changeset in webkit [35850] by
-
- 2 edits in trunk/WebKit/mac
Fixes the Web Inspector flashing white while resizing after
highlighting a page element. Calling disableScreenUpdatesUntilFlush
when attaching and detaching the Inspector page highlight is bad,
since the browser window might not flush again for a while. So screen
updates could be disabled for long periods of time, causing backing store
flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
when attaching or detaching the child window.
Reviewed by John Sullivan and Kevin McCullough.
- WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush. (-[WebNodeHighlight detach]): Ditto.
- 3:34 PM Changeset in webkit [35849] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- 3:29 PM Changeset in webkit [35848] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
- 3:22 PM Changeset in webkit [35847] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim and Mark.
Implement DTrace hooks for dashcode and instruments.
- API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be turned on from a client. The DTrace probes were added within the profiler mechanism for performance reasons so the profiler must be started to enable tracing. (JSStartProfiling): (JSEndProfiling):
- API/JSProfilerPrivate.h: Added. Ditto.
- JavaScriptCore.exp: Exposing the start/stop methods to clients.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Tracing.d: Define the DTrace probes.
- kjs/Tracing.h: Ditto.
- profiler/ProfileGenerator.cpp: Implement the DTrace probes in the profiler. (KJS::ProfileGenerator::willExecute): (KJS::ProfileGenerator::didExecute):
- 3:05 PM Changeset in webkit [35846] by
-
- 12 edits30 adds in trunk
<rdar://problem/4003764> Expose tables as AXTables
Exposes "data" tables in HTML as AXTables through accessibility
- 2:35 PM Changeset in webkit [35845] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- kjs/operations.cpp: (KJS::equal):
- 1:18 PM Changeset in webkit [35844] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
is waiting for crash reporter to let it exit.
The fix does not work on Tiger, because the state of the process is indistinguishable from
other waiting processes, at least not with this technique.
- Scripts/run-webkit-tests:
- 11:39 AM Changeset in webkit [35843] by
-
- 2 edits in trunk/WebCore
Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.
- WebCore.vcproj/QTMovieWin.vcproj:
- 11:33 AM Changeset in webkit [35842] by
-
- 6 edits in trunk/WebCore
Added support for console.count in the inspector.
Reviewed by Geoff Garen.
- page/Console.cpp: (WebCore::Console::count):
- page/Console.h:
- page/Console.idl: Added console.count.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Clears m_counts. (WebCore::InspectorController::count): Updates the count number sing "title@source:line" as the identifier, and adds a message to the console.
- page/InspectorController.h: Added m_counts.
- 11:33 AM Changeset in webkit [35841] by
-
- 2 edits in trunk/WebCore
Clear console.time timers when changing page.
Reviewed by Geoff Garen.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- 10:55 AM Changeset in webkit [35840] by
-
- 3 edits in trunk/WebCore
2008-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404
Ignore setVisible() when visibility doesn't change.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::setVisible):
- 10:01 AM Changeset in webkit [35839] by
-
- 2 edits in trunk/WebKit/mac
Correctly remembers the attached state of the Web Inspector so
it opens in that state for the next window, or next launch.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey to YES in the user defaults. (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey to NO in the user defaults.
- 10:01 AM Changeset in webkit [35838] by
-
- 2 edits in trunk/WebCore
Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype._changeView): Call _sortProfile on the next profile before assigning it to this.profile. (WebInspector.ProfileView.prototype._sortData): Call _sortProfile. (WebInspector.ProfileView.prototype._sortProfile): Moves from _sortData and takes a profile argument. If the profile passed in matches the this.profile, then call refresh.
- 10:01 AM Changeset in webkit [35837] by
-
- 2 edits in trunk/WebCore
Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView): Changed the default sort column. Also assign heavyProfile to profile, so the sortSelfTimeDescending call happens on the heavy profile before assigning to this.profile.
- 10:00 AM Changeset in webkit [35836] by
-
- 2 edits in trunk/JavaScriptCore
Fix an assertion when generating a heavy profile because the
empty value and deleted value of CallIdentifier where equal.
Reviewed by Dan Bernstein.
- profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier use empty strings for URL and function name.
- 10:00 AM Changeset in webkit [35835] by
-
- 6 edits in trunk/WebCore
Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.
Reviewed by Kevin McCullough.
- page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Set editable to true by default. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Factored out code into update, and calls update. (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title gets made later in onattach. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early if shouldRefreshChildren is true. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing. (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update. (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for this element (code moved from the constructor.) (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all sibling property elements. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call WebInspector.startEditing after rememebring some context. (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft for the list element, since it might have scrolled during editing. (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded then restore the state from the context. Then call update to restore the title. (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled if the user input and the previous input are the same. Call editingEnded, then call applyExpression to commit the user input. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression and stores the result on the object for the property name of this element. If the expression is empty, delete the property and remove the tree element.
- page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused property on each ObjectPropertiesSection. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach since it is now implemented.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument that defaults to true if omitted. It specifies whether to call update on the scope chain.
- page/inspector/inspector.css: New styles.
- page/inspector/treeoutline.js: (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
- 10:00 AM Changeset in webkit [35834] by
-
- 2 edits in trunk/WebCore
Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Add parenthesis around the expression. And add couple comments.
- 9:38 AM Changeset in webkit [35833] by
-
- 3 edits in trunk/WebCore
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
-Implement a page() function to extract a common code pattern.
- WebCore.xcodeproj/project.pbxproj:
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::assertCondition): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupEnd): (WebCore::Console::finishedProfiling): (WebCore::Console::warn): (WebCore::Console::framePage):
- page/Console.h:
- 7:35 AM Changeset in webkit [35832] by
-
- 1 edit1 move in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg
Disabling the test while the crash is being investigated.
- 12:27 AM Changeset in webkit [35831] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=19347
<rdar://problem/5977562> Input methods do not work after switching to a password field
and back.
Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
reconversion) in a different way which doesn't conflict with context caching performed
by AppKit.
This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
because input methods are disabled in password fields. Attempting to reconvert text typed
with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
password field behavior and disable reconversion completely.
- WebView/WebHTMLView.mm: (isInPasswordField): Factored out code to determine that the current selection is in a password field. (inputContext): Removed a hack that was breaking TSMGetActiveDocument(). (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields. (-[WebHTMLView textStorage]): Ditto.