Timeline
Aug 22, 2008:
- 8:17 PM Changeset in webkit [35898] by
-
- 8 edits in trunk/JavaScriptCore
2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Some cleanup to match our coding style.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/ExecState.cpp:
- kjs/ExecState.h:
- kjs/completion.h:
- kjs/identifier.cpp: (KJS::Identifier::equal): (KJS::CStringTranslator::hash): (KJS::CStringTranslator::equal): (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::equal): (KJS::UCharBufferTranslator::translate): (KJS::Identifier::remove):
- kjs/operations.h:
- 4:44 PM Changeset in webkit [35897] by
-
- 10 edits in trunk
2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to make a Windows WebView transparent.
Reviewed by Dan Bernstein.
- Interfaces/IWebViewPrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call updateBackground() when a new frame is attached, matching the Mac.
- WebFrame.cpp: (WebFrame::updateBackground): Propagate WebView transparency to ourself and our child frames.
- WebFrame.h:
- WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): Pass m_transparent when creating a GraphicsContext, so the context will be created with an alpha channel. (WebView::setTransparent): (WebView::transparent):
- WebView.h:
- 4:44 PM Changeset in webkit [35896] by
-
- 4 edits in trunk/WebKit/win
2008-08-12 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to get a handle to the WebView's backing store bitmap.
Reviewed by Dan Bernstein.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::backingStore):
- WebView.h:
- 1:35 PM Changeset in webkit [35895] by
-
- 2 edits in trunk/WebCore
Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.
- page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Removes parenthesis around the expression.
- 12:39 PM Changeset in webkit [35894] by
-
- 2 edits in trunk/JavaScriptGlue
2008-08-22 Anders Carlsson <andersca@apple.com>
Fix build for real this time.
- UserObjectImp.h:
- 12:14 PM Changeset in webkit [35893] by
-
- 3 edits in trunk/JavaScriptGlue
2008-08-22 Anders Carlsson <andersca@apple.com>
Fix build.
- UserObjectImp.cpp: (UserObjectImp::toPrimitive):
- UserObjectImp.h:
- 11:39 AM Changeset in webkit [35892] by
-
- 3 edits2 adds in trunk
Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.
WebCore:
2008-08-22 Timothy Hatcher <timothy@apple.com>
Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.
Reviewed by Dan Bernstein.
Test: fast/css/overflow-property.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
LayoutTests:
2008-08-22 Timothy Hatcher <timothy@apple.com>
Test for the tests the parsing and retrieval of the overflow,
overflow-x and overflow-y properties
Reviewed by Dan Bernstein.
- fast/css/overflow-property-expected.txt: Added.
- fast/css/overflow-property.html: Added.
- 11:39 AM Changeset in webkit [35891] by
-
- 2 edits in trunk/WebCore
Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.
Reviewed by Darin Adler.
- page/inspector/treeoutline.js: (TreeOutline._removeChildren): Remove the offsetTop call that was forcing a layout, since layout causes scroll positions to be clamped to the new scrollHeight/Width. Layout will happen normally when needed.
- 10:38 AM Changeset in webkit [35890] by
-
- 1 edit2 deletes in trunk/LayoutTests
Reviewed by Darin Adler
css3/transform-computed-style-001.html is better tested
by fast/css/getComputedStyle-transform.html, so removed.
https://bugs.webkit.org/show_bug.cgi?id=20477
- css3/transform-computed-style-001-expected.txt: Removed.
- css3/transform-computed-style-001.fhtml: Removed.
- 9:25 AM Changeset in webkit [35889] by
-
- 2 edits in trunk/WebCore
wx build fix. Add AccessibilityTable sources.
Aug 21, 2008:
- 11:29 PM Changeset in webkit [35888] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported ascent and 100% to its reported descent.
LayoutTests:
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.
- 7:20 PM Changeset in webkit [35887] by
-
- 2 edits in trunk/WebKit/win
2008-08-21 Jonas Klink <klinktech@gmail.com>
Reviewed by Jon Honeycutt.
Fix https://bugs.webkit.org/show_bug.cgi?id=20231
Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
from accNavigate if no screen element is found in the specified direction.
- AccessibleBase.cpp: (AccessibleBase::accNavigate):
- 7:20 PM Changeset in webkit [35886] by
-
- 2 edits in trunk/WebKit/win
2008-08-21 Jonas Klink <klinktech@gmail.com>
Reviewed by Jon Honeycutt.
Fix http://bugs.webkit.org/show_bug.cgi?id=20230
Bug 20230: get_accState should be testing state on childObj
Also initializes output parameter action to 0 in get_accDefaultAction.
- AccessibleBase.cpp: (AccessibleBase::get_accState): (AccessibleBase::get_accDefaultAction):
- 7:10 PM Changeset in webkit [35885] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bug number in ChangeLog.
- 7:07 PM Changeset in webkit [35884] by
-
- 2 edits in trunk/WebCore
2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] Crash on some pages due to a plugin
Fix handling of badly formatted and empty plugin mime descriptions
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 7:07 PM Changeset in webkit [35883] by
-
- 2 edits in trunk/WebCore
2008-08-21 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Darin Adler.
Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameDurationAtIndex):
- 5:39 PM Changeset in webkit [35882] by
-
- 3 edits3 adds in trunk
2008-08-21 Maxime Britto <britto@apple.com>
Reviewed by Kevin McCullough.
Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
https://bugs.webkit.org/show_bug.cgi?id=20451
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
(WebCore::EventHandler::handleMousePressEvent): ditto
2008-08-21 Maxime Britto <britto@apple.com>
Reviewed by Kevin McCullough.
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
https://bugs.webkit.org/show_bug.cgi?id=20451
This test can be run automatically or manually as well.
- fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
- fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
- fast/events/resources/big-page-with-overflow-hidden.html: Added.
- 4:54 PM Changeset in webkit [35881] by
-
- 2 edits in trunk/WebCore
Small optimization for when the dividers in the Inspector's
Resources panel are updated.
Reviewed by Tim Hatcher.
- page/inspector/ResourcesPanel.js: (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Combind a for loop and clone the divider element.
- 4:44 PM Changeset in webkit [35880] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe
Make build-launcher-app work when run from a git repository.
https://bugs.webkit.org/show_bug.cgi?id=20478
- BuildSlaveSupport/build-launcher-app:
- 4:35 PM Changeset in webkit [35879] by
-
- 3 edits2 adds in trunk
2008-08-21 Chris Marrin <cmarrin@apple.com>
Allow 0 (without units) for Time eg. duration
Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
Reviewed by Dave Hyatt.
Test: css1/units/zero-duration-without-units.html
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 1:13 PM Changeset in webkit [35878] by
-
- 2 edits in trunk/WebCore
Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted): Don't check for hasAttributes on the parseElement, continuing through the function will correctly remove the attribute. If the parseElement is null, call _editingCancelled not editingCancelled, this fixes an exception.
- 1:12 PM Changeset in webkit [35877] by
-
- 3 edits in trunk/WebCore
Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add event listeners for the "style edited" and "style property toggled" events, so the Metrics pane is updated. (WebInspector.ElementsPanel.prototype._stylesPaneEdited): Update the Metrics pane.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Dispatch the "style property toggled" event. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Dispatch the "style edited" event when the CSS text is restored. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Dispatch the "style edited" event.
- 1:12 PM Changeset in webkit [35876] by
-
- 4 edits in trunk/WebCore
Make the Inspector's Metrics sidebar pane editable.
https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add an event listener for the "metrics edited" event, so the Styles pane is updated.
- page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Remember the node so future updates work. Add a double click event listener for the metric values to start editing. (WebInspector.MetricsSidebarPane.prototype.startEditing): Call WebInspector.startEditing with some context. (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype.editingCommitted): Set the user input on the elements inline style. Fire the "metrics edited" event.
- 11:42 AM Changeset in webkit [35875] by
-
- 2 edits in trunk/WebCore
Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.
Don't post a timer message if one is already pending.
Reviewed by Ada Chan.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::setSharedTimerFireTime):
- 9:36 AM Changeset in webkit [35874] by
-
- 2 edits in trunk/WebCore
After trying to add the expression, try again with quotes for
easier edition.
Reviewed by Tim Hatcher.
- page/inspector/ObjectPropertiesSection.js: Added an evaluateExpression function.
- 9:33 AM Changeset in webkit [35873] by
-
- 2 edits in trunk/WebCore
Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 4:22 AM Changeset in webkit [35872] by
-
- 2 edits in trunk/WebCore
2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error
In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
